Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-31 Thread Michael Roberts

I may also be able to do so -- I expect to have an Oracle server
available to me in the near future and I've done some work with the
Oracle OCI.

Michael

Scott Goodwin wrote:

>Can anyone identify where the latest copy of the ns_ora driver
>resides? Let's have it imported into the AOLserver SourceForge area
>and find someone to maintain it. Looks like Jeremy may be signing up
>for that daunting duty :)
>
>
>/s.
>
>>+-- On May 30, Jeremy Collins said:
>>
>>>Who currently maintains the AOLserver Oracle driver?
>>>
>>No one, as far as I know. I was the last maintainer at ArsDigita.
>>
>Since
>
>>I no longer use AOLserver professionally and do very little with it
>>
>in
>
>>my spare time, and since the Oracle driver source code is incredibly
>>ugly, I have no interest in doing any further work on it.
>>
>>Therefore I suggest that you package up your version and call
>>
>yourself
>
>>the maintainer.
>>
>>
>
>/s.
>
>Scott S. Goodwin
>e: [EMAIL PROTECTED] | u: http://scottg.net | aim: scottgnet
>-+-+-+-+-+-+-+-+-+-+-+-+-
>If to err is human, I must be more human than most.
>



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Roberto Mello

On Thu, May 30, 2002 at 10:09:02PM -0400, Andrew Piskorski wrote:



> As far as I know the OpenACS folks have not (yet?) modified the Oracle
> driver at all.  You might want to ask them to be sure, but this
> (relatively recent, I think) OpenACS 4 install doc says to still
> download AOLserver 3.3+ad13 from aD:
>   http://openacs.org/doc/openacs-4/aolserver.html

I don't think we (OACS 4) have modified the oracle driver.



> And, just what is the difference between the "postgres.c" and
> "nspostgres.c" drivers?  They're both available on SourceForge, in
> different places.  postgres.c is what OpenACS uses, and looks much
> more recent.  Was it forked off from nspostgres.c at some point?
>
>   http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/acs-pg/driver-2.3/
>   http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/aolserver/nspostgres/

As far as I remember, the nspostgres in AOLserver stagnated in time.
postgres.c available from the OpenACS 3 tree on sourceforge is a much
enhanced PostgreSQL driver, with memory management cleanups, performance
improvements, pseudo-bind variables, etc.

I don't think anyone from the OACS camp who improved the driver has commit
privs to the AOLserver tree.

-Roberto

--
+| http://fslc.usu.edu/ USU Free Software & GNU/Linux Club |--+
  Roberto Mello - Computer Science, USU - http://www.brasileiro.net/
   http://www.sdl.usu.edu/ - Space Dynamics Lab, Developer
Why be normal if you can be diferent ???



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Rob Mayoff

+-- On May 30, Andrew Piskorski said:
> I believe the latest Oracle driver is version 2.6, from c. June 11
> 2001.  At least, that's the version I have, and it came with the
> AOLserver 3.3+ad13 from ArsDigita.

As I recall, I never packaged version 2.6 separately from AOLserver
3.3+ad13.



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Andrew Piskorski

On Thu, May 30, 2002 at 03:58:27PM -0400, Scott Goodwin wrote:
> Can anyone identify where the latest copy of the ns_ora driver
> resides? Let's have it imported into the AOLserver SourceForge area
> and find someone to maintain it. Looks like Jeremy may be signing up
> for that daunting duty :)

I believe the latest Oracle driver is version 2.6, from c. June 11
2001.  At least, that's the version I have, and it came with the
AOLserver 3.3+ad13 from ArsDigita.  It's ora8.c has this CVS Id tag at
the top of the file:

/* $Id: ora8.c,v 1.59 2001/06/11 20:11:14 mayoff Exp $ */

The README in the Oracle driver's source distribution mentions at the
top that it's version 2.4, but there is a change log further down
listing changes for 2.5 and 2.6, and according to the version.h file
it's definitely 2.6.  Looks like all that stuff is currently still
available from aD:
  http://www.arsdigita.com/acs-repository/older?&type=other

As far as I know the OpenACS folks have not (yet?) modified the Oracle
driver at all.  You might want to ask them to be sure, but this
(relatively recent, I think) OpenACS 4 install doc says to still
download AOLserver 3.3+ad13 from aD:
  http://openacs.org/doc/openacs-4/aolserver.html

Another variant of all that stuff is mentioned in that same install
doc page:
  http://uptime.openacs.org/aolserver-openacs/

Todd Gillespie also hacked some form of ref cursor support into the
Oracle driver at one point:
  http://www.toddbrandlabs.com/code/

While your're at this sort of thing, OpenACS seems to also have an
"ns_xmlrpc" module that might be of interest:
  http://openacs.org/sdm/one-package.tcl?package_id=12

And, just what is the difference between the "postgres.c" and
"nspostgres.c" drivers?  They're both available on SourceForge, in
different places.  postgres.c is what OpenACS uses, and looks much
more recent.  Was it forked off from nspostgres.c at some point?

  http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/acs-pg/driver-2.3/
  http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/aolserver/nspostgres/

--
Andrew Piskorski <[EMAIL PROTECTED]>
http://www.piskorski.com



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Jeremy Collins

My guess (and what my patch is based on) is:

http://www.arsdigita.com/acs-repository/one-version?version_id=956

I believe http://www.ybos.net/ has a slightly modified version that
compiles against Oracle 9i.  I think the only change was to the Makefile
and I've included that in my patch.

What if I just gave you a tarball of my current driver and you imported
that?  Call it 2.6 beta, or something?

Jeremy

On Thu, 2002-05-30 at 14:58, Scott Goodwin wrote:
> Can anyone identify where the latest copy of the ns_ora driver
> resides? Let's have it imported into the AOLserver SourceForge area
> and find someone to maintain it. Looks like Jeremy may be signing up
> for that daunting duty :)
>
>
> /s.
>
> > +-- On May 30, Jeremy Collins said:
> > > Who currently maintains the AOLserver Oracle driver?
> >
> > No one, as far as I know. I was the last maintainer at ArsDigita.
> Since
> > I no longer use AOLserver professionally and do very little with it
> in
> > my spare time, and since the Oracle driver source code is incredibly
> > ugly, I have no interest in doing any further work on it.
> >
> > Therefore I suggest that you package up your version and call
> yourself
> > the maintainer.
> >
> >
>
> /s.
>
> Scott S. Goodwin
> e: [EMAIL PROTECTED] | u: http://scottg.net | aim: scottgnet
> -+-+-+-+-+-+-+-+-+-+-+-+-
> If to err is human, I must be more human than most.
>



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Jeremy Collins

On Thu, May 30, 2002 at 02:13:22PM -0700, Jeff Hobbs wrote:
>
> How far apart is this from the general oratcl extension?  That
> one is currently maintained by Todd Helfter, and has been recently
> updated for Oracle9 support and new features.
>
> If it is possible to just make minor adaptations of that to work
> in AOLServer, I'm sure that he would accept the changes.
>

There are pretty major differences between oratcl and ns_ora.  For one
ns_ora can automatically do binding of local variables.  Not to mention
that oratcl doesn't use AOLserver's connection pooling.  Although for the
Oracle driver we could use Oracle 9i's new pooling in the OCI.

Jeremy



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Rob Mayoff

+-- On May 30, Jeff Hobbs said:
> How far apart is this from the general oratcl extension?

Very, in the sense that it is a completely different codebase (as far as
I know) and implements the AOLserver database driver API.



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Peter M. Jansson

While it might be possible to get the oratcl extension to work, it
probably wouldn't take advantage of AOLserver's DB handle pools, which are
one of the major benefits of AOLserver.  Still, for folks coming in with
oratcl experience, it might help get them up-to-speed more quickly.  But I
think any performance-minded app is going to want to use the AOLserver DB
infrastructure.  (I write this not knowing whether oratcl provides db
handle pooling; if it does, then please pardon me for talking through my
hat.)

On Thursday, May 30, 2002, at 05:13 PM, Jeff Hobbs wrote:
> How far apart is this from the general oratcl extension?  That
> one is currently maintained by Todd Helfter, and has been recently
> updated for Oracle9 support and new features.
>
> If it is possible to just make minor adaptations of that to work
> in AOLServer, I'm sure that he would accept the changes.



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Jeff Hobbs

Rob Mayoff wrote:
> +-- On May 30, Jeremy Collins said:
> > Who currently maintains the AOLserver Oracle driver?
>
> No one, as far as I know. I was the last maintainer at ArsDigita. Since
> I no longer use AOLserver professionally and do very little with it in
> my spare time, and since the Oracle driver source code is incredibly
> ugly, I have no interest in doing any further work on it.
>
> Therefore I suggest that you package up your version and call yourself
> the maintainer.

How far apart is this from the general oratcl extension?  That
one is currently maintained by Todd Helfter, and has been recently
updated for Oracle9 support and new features.

If it is possible to just make minor adaptations of that to work
in AOLServer, I'm sure that he would accept the changes.

Jeff



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Scott Goodwin

Can anyone identify where the latest copy of the ns_ora driver
resides? Let's have it imported into the AOLserver SourceForge area
and find someone to maintain it. Looks like Jeremy may be signing up
for that daunting duty :)


/s.

> +-- On May 30, Jeremy Collins said:
> > Who currently maintains the AOLserver Oracle driver?
>
> No one, as far as I know. I was the last maintainer at ArsDigita.
Since
> I no longer use AOLserver professionally and do very little with it
in
> my spare time, and since the Oracle driver source code is incredibly
> ugly, I have no interest in doing any further work on it.
>
> Therefore I suggest that you package up your version and call
yourself
> the maintainer.
>
>

/s.

Scott S. Goodwin
e: [EMAIL PROTECTED] | u: http://scottg.net | aim: scottgnet
-+-+-+-+-+-+-+-+-+-+-+-+-
If to err is human, I must be more human than most.



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Andrew Piskorski

On Thu, May 30, 2002 at 03:38:29PM -0500, Rob Mayoff wrote:
> +-- On May 30, Jeremy Collins said:
> > Who currently maintains the AOLserver Oracle driver?
>
> No one, as far as I know. I was the last maintainer at ArsDigita. Since
> I no longer use AOLserver professionally and do very little with it in
> my spare time, and since the Oracle driver source code is incredibly
> ugly, I have no interest in doing any further work on it.

Rob, any comments on what made the code is so ugly, how to avoid that
in future, etc.?

--
Andrew Piskorski <[EMAIL PROTECTED]>
http://www.piskorski.com



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Rob Mayoff

+-- On May 30, Jeremy Collins said:
> Who currently maintains the AOLserver Oracle driver?

No one, as far as I know. I was the last maintainer at ArsDigita. Since
I no longer use AOLserver professionally and do very little with it in
my spare time, and since the Oracle driver source code is incredibly
ugly, I have no interest in doing any further work on it.

Therefore I suggest that you package up your version and call yourself
the maintainer.



Re: [AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Andrew Piskorski

On Thu, May 30, 2002 at 02:10:29PM -0500, Jeremy Collins wrote:

> Who currently maintains the AOLserver Oracle driver?  I made a few
> changes to it.  Below is a brief summary that I wrote to explain

That's a good question, Jeremy.  I don't know, but the OpenACS folks
use the Oracle driver, so they'd probably be interested in knowing
about your patch.

--
Andrew Piskorski <[EMAIL PROTECTED]>
http://www.piskorski.com



[AOLSERVER] AOLserver Oracle Driver Improvements

2002-05-30 Thread Jeremy Collins

All,

Who currently maintains the AOLserver Oracle driver?  I made a few
changes to it.  Below is a brief summary that I wrote to explain
the changes.  I wanted to get any feedback on the API call, if any.

This new version adds multiple OUT variables, and the ability to bind
a single REF CURSOR. The single REF CURSOR limitation is because the
current driver only allows for a single OCIStmt handle to be associated
with a db handle. That is the *ONLY* reason for the limitation.
Should we write [ns_oracle exec|fetch|etc $stmt] this limitation could
go away.  And yes, to use the new command you call [ns_oracle] not
[ns_ora]. The new [ns_oracle] is written against the Tcl 8.x API and
the older version is not so I had to create a new command.

The new command is as follows:

Syntax:

 ns_oracle plsql dbhandle sql ?ref?

Optional arguments:

 ?ref? - Name of bind variable that is a REF CURSOR.

Example:

 set db [ns_db gethandle]
 set out ""
 set firm_id 44
 set firm_name "My new Firm name"

 ns_oracle plsql $db "begin pmpc_admin.rename_firm(:firm_id, :firm_name,
:out); end;"

Notes:

 Note how I had to set "out" to an empty string. This is required for
 any argument unless you specify it as a REF CURSOR. I think this is
 a reasonable request and makes implementation easier. Alternatively
 we could just always default to "" if the variable doesn't exist but
 that might have unwanted side effects. Finally we could continue
 with the horrible way the current driver does it and require that
 the programmer tell us which bind variables are OUT.

Jeremy