Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/ --- (Updated Nov. 23, 2013, 6:38 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 403117 Bugs: ASTERISK-22780 https://issues.asterisk.org/jira/browse/ASTERISK-22780 Repository: Asterisk Description --- This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge). Diffs - /branches/12/rest-api/api-docs/channels.json 402890 /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION /branches/12/res/res_stasis_snoop.c PRE-CREATION /branches/12/res/res_ari_channels.c 402890 /branches/12/res/ari/resource_channels.c 402890 /branches/12/res/ari/resource_channels.h 402890 /branches/12/main/audiohook.c 402890 /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3003/diff/ Testing --- Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon! Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/ --- (Updated Nov. 22, 2013, 5:20 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-22780 https://issues.asterisk.org/jira/browse/ASTERISK-22780 Repository: Asterisk Description --- This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge). Diffs (updated) - /branches/12/rest-api/api-docs/channels.json 402890 /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION /branches/12/res/res_stasis_snoop.c PRE-CREATION /branches/12/res/res_ari_channels.c 402890 /branches/12/res/ari/resource_channels.c 402890 /branches/12/res/ari/resource_channels.h 402890 /branches/12/main/audiohook.c 402890 /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3003/diff/ Testing --- Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon! Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/#review10263 --- Ship it! Ship It! - Matt Jordan On Nov. 22, 2013, 5:20 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/ --- (Updated Nov. 22, 2013, 5:20 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-22780 https://issues.asterisk.org/jira/browse/ASTERISK-22780 Repository: Asterisk Description --- This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge). Diffs - /branches/12/rest-api/api-docs/channels.json 402890 /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION /branches/12/res/res_stasis_snoop.c PRE-CREATION /branches/12/res/res_ari_channels.c 402890 /branches/12/res/ari/resource_channels.c 402890 /branches/12/res/ari/resource_channels.h 402890 /branches/12/main/audiohook.c 402890 /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3003/diff/ Testing --- Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon! Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels
On Nov. 21, 2013, 8:05 p.m., Matt Jordan wrote: /branches/12/res/res_stasis_snoop.c, lines 215-228 https://reviewboard.asterisk.org/r/3003/diff/3/?file=48153#file48153line215 Going out on a limb here, but if this ever occurs, something has gone horribly wrong. We should never masquerade a Snoop channel: that means someone has performed an ast_channel_yank and is now doing something godawful. It may be worthwhile having an assert in here, or something that indicates that this should not have occurred - even if we do try to 'handle it gracefully'. It's perfectly legal for this to happen, an example would be redirecting the Snoop channel to the dialplan. It will continue to work and nothing funky will happen. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/#review10253 --- On Nov. 12, 2013, 6:43 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/ --- (Updated Nov. 12, 2013, 6:43 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-22780 https://issues.asterisk.org/jira/browse/ASTERISK-22780 Repository: Asterisk Description --- This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge). Diffs - /branches/12/rest-api/api-docs/channels.json 402707 /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION /branches/12/res/res_stasis_snoop.c PRE-CREATION /branches/12/res/res_ari_channels.c 402707 /branches/12/res/ari/resource_channels.c 402707 /branches/12/res/ari/resource_channels.h 402707 /branches/12/main/audiohook.c 402707 /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3003/diff/ Testing --- Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon! Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/#review10253 --- /branches/12/res/res_stasis_snoop.c https://reviewboard.asterisk.org/r/3003/#comment19601 I'm not sure this needs to be dynamically expanded. Unique ids of channels have a well defined upper bound, AST_MAX_UNIQUEID defined in channel.h. You could just as well make this a char array and save yourself the trouble. /branches/12/res/res_stasis_snoop.c https://reviewboard.asterisk.org/r/3003/#comment19602 Going out on a limb here, but if this ever occurs, something has gone horribly wrong. We should never masquerade a Snoop channel: that means someone has performed an ast_channel_yank and is now doing something godawful. It may be worthwhile having an assert in here, or something that indicates that this should not have occurred - even if we do try to 'handle it gracefully'. - Matt Jordan On Nov. 12, 2013, 6:43 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/ --- (Updated Nov. 12, 2013, 6:43 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-22780 https://issues.asterisk.org/jira/browse/ASTERISK-22780 Repository: Asterisk Description --- This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge). Diffs - /branches/12/rest-api/api-docs/channels.json 402707 /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION /branches/12/res/res_stasis_snoop.c PRE-CREATION /branches/12/res/res_ari_channels.c 402707 /branches/12/res/ari/resource_channels.c 402707 /branches/12/res/ari/resource_channels.h 402707 /branches/12/main/audiohook.c 402707 /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3003/diff/ Testing --- Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon! Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels
On Nov. 14, 2013, 4:53 p.m., Mark Michelson wrote: /branches/12/res/res_stasis_snoop.c, line 142 https://reviewboard.asterisk.org/r/3003/diff/3/?file=48153#file48153line142 Hm, would it be more useful to publish the snoop messages on the spyee channel's topic? I would suspect that most people would think of the spyee's channel as the real channel and would expect to see the publications on that channel instead of the snoop channel. Joshua Colp wrote: It's possible when spying is started to do that but doing it at the end and guaranteeing you get it would require holding a reference to the channel, which I avoided at all costs. As long as we're fine with that... then sure. I'd prefer not, actually. Usually, the channel that initiates the Spying is the one whose topic has the messages published on it. Granted, in this case, the Snoop channel is a little odd, but it is still the channel doing the Spying, not the target of the Spying operation. Switching the order of the channels here takes it out of alignment with the messages published in ChanSpy. From a consumer perspective, most things that receive ChanSpy messages have also already subscribed to the ast_channel_topic_all topic, which means the individual channel topics are kind of a moot point. - Matt --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/#review10183 --- On Nov. 12, 2013, 6:43 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/ --- (Updated Nov. 12, 2013, 6:43 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-22780 https://issues.asterisk.org/jira/browse/ASTERISK-22780 Repository: Asterisk Description --- This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge). Diffs - /branches/12/rest-api/api-docs/channels.json 402707 /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION /branches/12/res/res_stasis_snoop.c PRE-CREATION /branches/12/res/res_ari_channels.c 402707 /branches/12/res/ari/resource_channels.c 402707 /branches/12/res/ari/resource_channels.h 402707 /branches/12/main/audiohook.c 402707 /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3003/diff/ Testing --- Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon! Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
