Re: [asterisk-dev] [Code Review] 4112: testsuite: Make tests/fax/pjsip/* depend on chan_pjsip

[Corey Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4112/
---

(Updated Oct. 28, 2014, 6:07 a.m.)


Status
--

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
---

Committed in revision 5797


Repository: testsuite


Description
---

PJSIP fax tests are missing dependency on chan_pjsip and res_pjsip_t38, causing 
them all to fail if Asterisk was compiled without pjproject.

I have not looked into if these tests actually require res_pjsip_t38 (I don't 
have pjproject on my system).  I added it since all tests have 't38' in the 
name.


Diffs
-

  /asterisk/trunk/tests/fax/pjsip/t38/test-config.yaml 5649 
  /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/test-config.yaml 5649 
  /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/test-config.yaml 5649 
  /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml 
5649 

Diff: https://reviewboard.asterisk.org/r/4112/diff/


Testing
---

Verified these tests no longer attempt to run when Asterisk was compiled 
without pjproject.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4112: testsuite: Make tests/fax/pjsip/* depend on chan_pjsip

[Corey Farrell]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4112/
---

(Updated Oct. 27, 2014, 4:31 a.m.)


Review request for Asterisk Developers.


Changes
---

Address Walters findings about chan_sip dependencies


Repository: testsuite


Description
---

PJSIP fax tests are missing dependency on chan_pjsip and res_pjsip_t38, causing 
them all to fail if Asterisk was compiled without pjproject.

I have not looked into if these tests actually require res_pjsip_t38 (I don't 
have pjproject on my system).  I added it since all tests have 't38' in the 
name.


Diffs (updated)
-

  /asterisk/trunk/tests/fax/pjsip/t38/test-config.yaml 5649 
  /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/test-config.yaml 5649 
  /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/test-config.yaml 5649 
  /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml 
5649 

Diff: https://reviewboard.asterisk.org/r/4112/diff/


Testing
---

Verified these tests no longer attempt to run when Asterisk was compiled 
without pjproject.


Thanks,

Corey Farrell

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4112: testsuite: Make tests/fax/pjsip/* depend on chan_pjsip

[wdoekes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4112/#review13595
---

Ship it!


Sounds good. Note that the following three tests also require chan_sip.


/asterisk/trunk/tests/fax/pjsip/gateway_native_t38/test-config.yaml


Also requires chan_sip.



/asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/test-config.yaml


Also requires chan_sip.



/asterisk/trunk/tests/fax/pjsip/t38/test-config.yaml


Also requires chan_sip.


- wdoekes


On Oct. 27, 2014, 7:41 a.m., Corey Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4112/
> ---
> 
> (Updated Oct. 27, 2014, 7:41 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> ---
> 
> PJSIP fax tests are missing dependency on chan_pjsip and res_pjsip_t38, 
> causing them all to fail if Asterisk was compiled without pjproject.
> 
> I have not looked into if these tests actually require res_pjsip_t38 (I don't 
> have pjproject on my system).  I added it since all tests have 't38' in the 
> name.
> 
> 
> Diffs
> -
> 
>   /asterisk/trunk/tests/fax/pjsip/t38/test-config.yaml 5649 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/test-config.yaml 5649 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/test-config.yaml 5649 
>   /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml 
> 5649 
> 
> Diff: https://reviewboard.asterisk.org/r/4112/diff/
> 
> 
> Testing
> ---
> 
> Verified these tests no longer attempt to run when Asterisk was compiled 
> without pjproject.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-- 
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev