Re: [Asterisk-Users] meetme + sendtext
On 11/23/05, Jean-Denis Girard <[EMAIL PROTECTED]> wrote: > BJ Weschke wrote: > > Yes. The biggest challenge is putting together a mux device that > > mixes the text frames out to all of the user/channel threads in the > > conference. > > I've updated my initial patch two days ago. Now a new thread is created > for each new message sent to the conference: this thread sends the > message to all members of the conference, and then exits. So there is no > more risk of blocking the sending channel. There is no mixing of text > messages, but do we really need that ? > > As a side note I didn't get email from bug tracker about my update > (http://bugs.digium.com/view.php?id=5808). > Your latest patch is an improvement from your original one, but it still doesn't really follow the design model and creates a situation where your thread and the user's conf_run thread could be trying to get at the same channel at the same time. While you can deal with this kind of situation with channel locking, I think it'd still be "cleaner" to integrate the distribution of the messages into the conf_run thread that exists already for each leg in the conference. Additionally, mantis won't send you emails about updates you personally make to issues. -- Bird's The Word Technologies, Inc. http://www.btwtech.com/ ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] meetme + sendtext
BJ Weschke wrote: > Yes. The biggest challenge is putting together a mux device that > mixes the text frames out to all of the user/channel threads in the > conference. I've updated my initial patch two days ago. Now a new thread is created for each new message sent to the conference: this thread sends the message to all members of the conference, and then exits. So there is no more risk of blocking the sending channel. There is no mixing of text messages, but do we really need that ? As a side note I didn't get email from bug tracker about my update (http://bugs.digium.com/view.php?id=5808). Thanks, -- Jean-Denis Girard SysNux Systèmes Linux en Polynésie française http://www.sysnux.pf/ Tél: +689 483 527 / GSM: +689 797 527 ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] meetme + sendtext
Yes. The biggest challenge is putting together a mux device that mixes the text frames out to all of the user/channel threads in the conference. On 11/21/05, Olle E. Johansson <[EMAIL PROTECTED]> wrote: > BJ Weschke wrote: > > On 11/19/05, Jean-Denis Girard <[EMAIL PROTECTED]> wrote: > > > >>Hi all, > >> > >>Is sending text to a conference supported by asterisk-1.2, ie one member > >>of the conference sends text, it is received by all other members of the > >>conference (provided their channel supports text of course) ? > >> > >>I made a quick test with IAX softphones, and it seems that text isn't > >>sent to IAX channels through the conference. > >> > >>If it is not supported, how difficult would that be to add this > >>functionnality ? > >> > > > > > > It's not supported at this time, but you're also not the first person > > to ask about it. I suppose it wouldn't be too difficult to add. > > > Well, we have no routing of incoming text messages through the dial > plan, but I guess this is a bit more simple, since we have open channels > into meetme. > > /o > ___ > --Bandwidth and Colocation sponsored by Easynews.com -- > > Asterisk-Users mailing list > Asterisk-Users@lists.digium.com > http://lists.digium.com/mailman/listinfo/asterisk-users > To UNSUBSCRIBE or update options visit: > http://lists.digium.com/mailman/listinfo/asterisk-users > -- Bird's The Word Technologies, Inc. http://www.btwtech.com/ ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] meetme + sendtext
BJ Weschke wrote: > On 11/19/05, Jean-Denis Girard <[EMAIL PROTECTED]> wrote: > >>Hi all, >> >>Is sending text to a conference supported by asterisk-1.2, ie one member >>of the conference sends text, it is received by all other members of the >>conference (provided their channel supports text of course) ? >> >>I made a quick test with IAX softphones, and it seems that text isn't >>sent to IAX channels through the conference. >> >>If it is not supported, how difficult would that be to add this >>functionnality ? >> > > > It's not supported at this time, but you're also not the first person > to ask about it. I suppose it wouldn't be too difficult to add. > Well, we have no routing of incoming text messages through the dial plan, but I guess this is a bit more simple, since we have open channels into meetme. /o ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] meetme + sendtext
Matt Riddell wrote: > Jean-Denis Girard wrote: > >>Attached is a simple patch I made to asterisk's app_meetme for text >>conferencing. I've only tested with 2 MozPhone in the conference, but it >>is works for me. I'll submit the patch to the bug tracker as soon as my >>account is active. > > > Could you post the url to the bugtracker entry once its up? > Here it is: bug 5808 (http://bugs.digium.com/view.php?id=5808) Thanks, Jean-Denis Girard ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] meetme + sendtext
Jean-Denis Girard wrote: > Attached is a simple patch I made to asterisk's app_meetme for text > conferencing. I've only tested with 2 MozPhone in the conference, but it > is works for me. I'll submit the patch to the bug tracker as soon as my > account is active. Could you post the url to the bugtracker entry once its up? -- Cheers, Matt Riddell ___ http://www.sineapps.com/news.php (Daily Asterisk News - html) http://freevoip.gedameurope.com (Free Asterisk Voip Community) http://www.sineapps.com/rssfeed.php (Daily Asterisk News - rss) ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] meetme + sendtext
Jean-Denis Girard wrote:
> Thanks for the replies, comments in line.
>
> Matt Riddell wrote:
>
>>BJ Weschke wrote:
>>
>>
>>>On 11/19/05, Jean-Denis Girard <[EMAIL PROTECTED]> wrote:
>>>
>>>
>>>It's not supported at this time, but you're also not the first person
>>>to ask about it. I suppose it wouldn't be too difficult to add.
>
>
> I also thought it wouldn't be too difficult, but after reading
> app_meetme.c I don't even know where to start... :(
OK it wasn't that difficult after all :)
Attached is a simple patch I made to asterisk's app_meetme for text
conferencing. I've only tested with 2 MozPhone in the conference, but it
is works for me. I'll submit the patch to the bug tracker as soon as my
account is active.
Thanks,
--
Jean-Denis Girard
SysNux Systèmes Linux en Polynésie française
http://www.sysnux.pf/ Tél: +689 483 527 / GSM: +689 797 527
--- apps/app_meetme.c.ORIG 2005-11-12 09:03:40.0 -1000
+++ apps/app_meetme.c 2005-11-19 23:02:56.0 -1000
@@ -1309,6 +1309,20 @@
*/
write(fd, f->data, f->datalen);
}
+} else if (f->frametype == AST_FRAME_TEXT) {
+ /* Text conference support */
+ struct ast_conf_user *u = calloc(1, sizeof(*user));
+ ast_log(LOG_DEBUG, "Text frame '%s' from %s\n", (char*) f->data, user->chan->name);
+ for (u = conf->firstuser; u; u = u->nextuser) {
+ if (u==user)
+ continue;
+ if ( u->chan->tech->send_text) {
+ /* We should use: ast_sendtext(u->chan, f->data)
+ * but it generates a blocking warning */
+ u->chan->tech->send_text(u->chan, f->data);
+ }
+ }
+ free(u);
} else if ((f->frametype == AST_FRAME_DTMF) && (confflags & CONFFLAG_EXIT_CONTEXT)) {
char tmp[2];
___
--Bandwidth and Colocation sponsored by Easynews.com --
Asterisk-Users mailing list
Asterisk-Users@lists.digium.com
http://lists.digium.com/mailman/listinfo/asterisk-users
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] meetme + sendtext
Thanks for the replies, comments in line. Matt Riddell wrote: > BJ Weschke wrote: > >>On 11/19/05, Jean-Denis Girard <[EMAIL PROTECTED]> wrote: >> >> >> It's not supported at this time, but you're also not the first person >>to ask about it. I suppose it wouldn't be too difficult to add. I also thought it wouldn't be too difficult, but after reading app_meetme.c I don't even know where to start... :( > > > Could you not send them to an agi (don't remember the option letter) and then > rig something up with a backend db and AGI SEND TEXT/AGI RECEIVE TEXT? > AGI may be an option, but the we'll loose the simplicity of meetme. I haven't looked at app_conference yet, would text be supported ? Does it work with asterisk-1.2 ? (I'll also ask these question on iaxclient mailing list) Thanks, Jean-Denis ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] meetme + sendtext
BJ Weschke wrote: > On 11/19/05, Jean-Denis Girard <[EMAIL PROTECTED]> wrote: > >>Hi all, >> >>Is sending text to a conference supported by asterisk-1.2, ie one member >>of the conference sends text, it is received by all other members of the >>conference (provided their channel supports text of course) ? >> >>I made a quick test with IAX softphones, and it seems that text isn't >>sent to IAX channels through the conference. >> >>If it is not supported, how difficult would that be to add this >>functionnality ? >> > > > It's not supported at this time, but you're also not the first person > to ask about it. I suppose it wouldn't be too difficult to add. Could you not send them to an agi (don't remember the option letter) and then rig something up with a backend db and AGI SEND TEXT/AGI RECEIVE TEXT? -- Cheers, Matt Riddell ___ http://www.sineapps.com/news.php (Daily Asterisk News - html) http://freevoip.gedameurope.com (Free Asterisk Voip Community) http://www.sineapps.com/rssfeed.php (Daily Asterisk News - rss) ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
Re: [Asterisk-Users] meetme + sendtext
On 11/19/05, Jean-Denis Girard <[EMAIL PROTECTED]> wrote: > Hi all, > > Is sending text to a conference supported by asterisk-1.2, ie one member > of the conference sends text, it is received by all other members of the > conference (provided their channel supports text of course) ? > > I made a quick test with IAX softphones, and it seems that text isn't > sent to IAX channels through the conference. > > If it is not supported, how difficult would that be to add this > functionnality ? > It's not supported at this time, but you're also not the first person to ask about it. I suppose it wouldn't be too difficult to add. -- Bird's The Word Technologies, Inc. http://www.btwtech.com/ ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
[Asterisk-Users] meetme + sendtext
Hi all, Is sending text to a conference supported by asterisk-1.2, ie one member of the conference sends text, it is received by all other members of the conference (provided their channel supports text of course) ? I made a quick test with IAX softphones, and it seems that text isn't sent to IAX channels through the conference. If it is not supported, how difficult would that be to add this functionnality ? Thanks, -- Jean-Denis Girard SysNux Systèmes Linux en Polynésie française http://www.sysnux.pf/ Tél: +689 483 527 / GSM: +689 797 527 ___ --Bandwidth and Colocation sponsored by Easynews.com -- Asterisk-Users mailing list Asterisk-Users@lists.digium.com http://lists.digium.com/mailman/listinfo/asterisk-users To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-users
