Re: [PATCH v3 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi
On 5/6/24 12:39, Marc Gonzalez wrote:
On 29/04/2024 16:07, Marc Gonzalez wrote:
The ath10k driver waits for an "MSA_READY" indicator
to complete initialization. If the indicator is not
received, then the device remains unusable.
cf. ath10k_qmi_driver_event_work()
Several msm8998-based devices are affected by this issue.
Oddly, it seems safe to NOT wait for the indicator, and
proceed immediately when QMI_EVENT_SERVER_ARRIVE.
Jeff Johnson wrote:
The feedback I received was "it might be ok to change all ath10k qmi
to skip waiting for msa_ready", and it was pointed out that ath11k
(and ath12k) do not wait for it.
However with so many deployed devices, "might be ok" isn't a strong
argument for changing the default behavior.
cf. also
https://wiki.postmarketos.org/wiki/Qualcomm_Snapdragon_835_(MSM8998)#WLAN
Signed-off-by: Marc Gonzalez
---
arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi
b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 67b8374ddf02f..4e6245095adfc 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -3234,6 +3234,7 @@ wifi: wifi@1880 {
iommus = <_smmu 0x1900>,
<_smmu 0x1901>;
qcom,snoc-host-cap-8bit-quirk;
+ qcom,no-msa-ready-indicator;
};
};
};
Bjorn,
This patch is supposed to go through your tree, right?
Reviewed-by: Konrad Dybcio
Konrad
Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi
On 30.03.2024 7:25 PM, Krzysztof Kozlowski wrote:
> On 28/03/2024 18:39, Marc Gonzalez wrote:
>> The ath10k driver waits for an "MSA_READY" indicator
>> to complete initialization. If the indicator is not
>> received, then the device remains unusable.
>>
>> cf. ath10k_qmi_driver_event_work()
>>
>> Several msm8998-based devices are affected by this issue.
>> Oddly, it seems safe to NOT wait for the indicator, and
>> proceed immediately when QMI_EVENT_SERVER_ARRIVE.
>>
>> Jeff Johnson wrote:
>>
>> The feedback I received was "it might be ok to change all ath10k qmi
>> to skip waiting for msa_ready", and it was pointed out that ath11k
>> (and ath12k) do not wait for it.
>>
>> However with so many deployed devices, "might be ok" isn't a strong
>> argument for changing the default behavior.
>>
>
> I think you got pretty clear comments:
>
> "This sounds more like a firmware feature, not a hardware feature."
>
> "This is why having this property in DT does not look right
> place for this."
Translating from dt maintainer speak to English, a functionally-equivalent
resolution of adding an of_machine_is_compatible("qcom,msm8998") is more
in line with the guidelines of not sprinkling firmware specifics in DTs
Konrad
Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop
On 3/13/24 16:09, Marc Gonzalez wrote:
[ Dropping the DT fellows ]
On 05/03/2024 20:20, Kalle Valo wrote:
Marc Gonzalez wrote:
I need to build a kernel + rootfs + FW to test the proposed solution,
then I can spin a formal submission.
Yeah, please do test this to make sure we are not missing anything :)
I used buildroot ( https://buildroot.org ) to generate a kernel + rootfs
for my board (a variation of qcom/msm8998-mtp.dts)
Not sure if I must use the vendor FW blobs? Or if I can use the blobs
from linux-firmware-20240115.tar.xz (as supported by BR2).
All I see from the ath10k driver (with debugging cranked to the max) is:
[0.539801] ath10k_snoc 1880.wifi: Adding to iommu group 0
[0.541941] ath10k_snoc 1880.wifi: snoc xo-cal-data return -22
[0.543633] ath10k_snoc 1880.wifi: supply vdd-3.3-ch1 not found, using
dummy regulator
[0.544002] ath10k_snoc 1880.wifi: qmi msa.paddr: 0x9440 ,
msa.vaddr: 0x(ptrval)
[0.544271] ath10k_snoc 1880.wifi: snoc probe
# ip link
1: lo: mtu 65536 qdisc noqueue qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: enp1s0: mtu 1500 qdisc pfifo_fast qlen 1000
link/ether 34:27:92:82:48:ec brd ff:ff:ff:ff:ff:ff
No wlan device at this point.
I got shell-shock from reading these setup steps:
https://wiki.postmarketos.org/wiki/Qualcomm_Snapdragon_835_(MSM8998)#WLAN
https://github.com/jhugo/linux/blob/5.5rc2_wifi/README
Jeffrey, Bjorn, Konrad,
Has someone written idiot-proof (such as myself) steps to enable
the ath10k core on a msm8998 board?
$ cat /tmp/x.json
[
{"names": ["bus=snoc,qmi-board-id=stinkyboard"], "data":
"board_stink.bin"}
]
$ ls -lh board_stink.bin
-rw-rw-r-- 1 konrad konrad 19K Mar 13 16:42 board_stink.bin
$ python3 ~/qca-swiss-army-knife/tools/scripts/ath10k/ath10k-bdencoder -c
/tmp/x.json -o board-2.bin
board binary file 'board-2.bin' is created
I believe Kalle aggregates these boardfiles and then uploads a big
combined board-2.bin to linux-firmware nowadays?
Konrad
Re: [PATCH RFC 4/4] arm64: dts: qcom: qrb4210-rb1: add firmware-name qualifier to WiFi node
On 30.01.2024 17:38, Dmitry Baryshkov wrote: > Add firmware-name property to the WiFi device tree node to specify > board-specific lookup directory. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad
Re: [PATCH RFC 3/4] arm64: dts: qcom: qrb2210-rb1: add firmware-name qualifier to WiFi node
On 30.01.2024 17:38, Dmitry Baryshkov wrote: > Add firmware-name property to the WiFi device tree node to specify > board-specific lookup directory. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad
Re: [PATCH RFC 2/4] wifi: ath10k: support board-specific firmware overrides
On 30.01.2024 17:38, Dmitry Baryshkov wrote:
> Different Qualcomm platforms using WCN3990 WiFI chip use SoC-specific
> firmware versions with different features. For example firmware for
> SDM845 doesn't use single-chan-info-per-channel feature, while firmware
> for QRB2210 / QRB4210 requires that feature. Allow board DT files to
> override the subdir of the fw dir used to lookup the firmware-N.bin file
> decribing corresponding WiFi firmware.
>
> Signed-off-by: Dmitry Baryshkov
> ---
> drivers/net/wireless/ath/ath10k/core.c | 11 ++-
> drivers/net/wireless/ath/ath10k/core.h | 2 ++
> drivers/net/wireless/ath/ath10k/snoc.c | 3 +++
> 3 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c
> b/drivers/net/wireless/ath/ath10k/core.c
> index 0032f8aa892f..ef7ce8b3f8fb 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -942,11 +942,20 @@ static const struct firmware
> *ath10k_fetch_fw_file(struct ath10k *ar,
> if (dir == NULL)
> dir = ".";
>
> + if (ar->board_name) {
> + snprintf(filename, sizeof(filename), "%s/%s/%s",
> + dir, ar->board_name, file);
> + ret = firmware_request_nowarn(, filename, ar->dev);
> + ath10k_dbg(ar, ATH10K_DBG_BOOT, "boot fw request '%s': %d\n",
> +filename, ret);
Perhaps it'd be useful to move to a more noisy loglevel
Konrad
Re: [PATCH v4] dt-bindings: net: Convert ATH10K to YAML
On 17.04.2023 12:12, Kalle Valo wrote: > Konrad Dybcio writes: > >> Convert the ATH10K bindings to YAML. >> >> Dropped properties that are absent at the current state of mainline: >> - qcom,msi_addr >> - qcom,msi_base > > Very good, thanks. Clearly I had missed that those were unused during > the review. > >> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should >> be reconsidered on the driver side, especially the latter one. > > I'm curious, what do you mean very little? We set ath10k firmware > parameters based on these coex properties. How would you propose to > handle these? Right, I first thought they did nothing and then realized they're sent to the fw.. I never amended the commit message though.. > >> Somewhat based on the ath11k bindings. >> >> Signed-off-by: Konrad Dybcio > > [...] > >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml >> @@ -0,0 +1,358 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath10k.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies ATH10K wireless devices > > [...] > >> + wifi-firmware: >> +type: object >> +additionalProperties: false >> +description: | >> + The ATH10K Wi-Fi node can contain one optional firmware subnode. >> + Firmware subnode is needed when the platform does not have Trustzone. > > Is there a reason why you write ath10k in upper case? There are two case > of that in the yaml file. We usually write it in lower case, can I > change to that? No particular reason, my brain just implicitly decided that it should be this way.. Please unify it (or LMK if you want me to perform another resend)! Konrad > ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH v4] dt-bindings: net: Convert ATH10K to YAML
Convert the ATH10K bindings to YAML.
Dropped properties that are absent at the current state of mainline:
- qcom,msi_addr
- qcom,msi_base
qcom,coexist-support and qcom,coexist-gpio-pin do very little and should
be reconsidered on the driver side, especially the latter one.
Somewhat based on the ath11k bindings.
Signed-off-by: Konrad Dybcio
---
v3 -> v4:
- Disallow interrupt-names for the SNoC variant (unused)
- Remove unnecessary interrupt-names/minItems under qcom,ipq4019-wifi
- Update the MAINTAINERS entry with the shiny new YAML file
- Drop the dts patch, Bjorn picked it up
v3:
https://lore.kernel.org/r/20230406-topic-ath10k_bindings-v3-0-00895afc7...@linaro.org
v2 -> v3:
- Ran dt_binding_check explicitly to uncover an issue with the
example - I had 2 levels of wifi-firmware{}.. Fixed that..
I hope you folks don't mind me resending so quickly, but it was a
trivial issue. Patch 2 unchanged.
v2:
https://lore.kernel.org/r/20230406-topic-ath10k_bindings-v2-0-557f884a6...@linaro.org
v1 -> v2:
Dropped:
- '|' in /description
- /properties/resets/minItems
- Unnecessary level of 'items:' in /properties/ext-fem-name
- reserved-memory in examples
- status in examples
- labels in examples
Added:
- /properties/wifi-firmware/additionalProperties: false
- /properties/wifi-firmware/properties/iommus
- /properties/qcom,coexist-support/enum (and reworded the description)
- wifi-firmware and supplies in the SNoC example
Patch 2 is unchanged, picked up rb.
v1:
https://lore.kernel.org/r/20230406-topic-ath10k_bindings-v1-0-1ef181c50...@linaro.org
This is my attempt at (finally) moving ATH10K to YAML.
One inexistent dt property came out as part of that.
---
.../bindings/net/wireless/qcom,ath10k.txt | 215 -
.../bindings/net/wireless/qcom,ath10k.yaml | 358 +
MAINTAINERS| 2 +-
3 files changed, 359 insertions(+), 216 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
deleted file mode 100644
index b61c2d5a0ff7..
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ /dev/null
@@ -1,215 +0,0 @@
-* Qualcomm Atheros ath10k wireless devices
-
-Required properties:
-- compatible: Should be one of the following:
- * "qcom,ath10k"
- * "qcom,ipq4019-wifi"
- * "qcom,wcn3990-wifi"
-
-PCI based devices uses compatible string "qcom,ath10k" and takes calibration
-data along with board specific data via "qcom,ath10k-calibration-data".
-Rest of the properties are not applicable for PCI based devices.
-
-AHB based devices (i.e. ipq4019) uses compatible string "qcom,ipq4019-wifi"
-and also uses most of the properties defined in this doc (except
-"qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-data"
-to carry pre calibration data.
-
-In general, entry "qcom,ath10k-pre-calibration-data" and
-"qcom,ath10k-calibration-data" conflict with each other and only one
-can be provided per device.
-
-SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
-
-- reg: Address and length of the register set for the device.
-- reg-names: Must include the list of following reg names,
-"membase"
-- interrupts: reference to the list of 17 interrupt numbers for
"qcom,ipq4019-wifi"
- compatible target.
- reference to the list of 12 interrupt numbers for
"qcom,wcn3990-wifi"
- compatible target.
- Must contain interrupt-names property per entry for
- "qcom,ath10k", "qcom,ipq4019-wifi" compatible targets.
-
-- interrupt-names: Must include the entries for MSI interrupt
- names ("msi0" to "msi15") and legacy interrupt
- name ("legacy") for "qcom,ath10k", "qcom,ipq4019-wifi"
- compatible targets.
-
-Optional properties:
-- resets: Must contain an entry for each entry in reset-names.
- See ../reset/reseti.txt for details.
-- reset-names: Must include the list of following reset names,
- "wifi_cpu_init"
- "wifi_radio_srif"
- "wifi_radio_warm"
- "wifi_radio_cold"
- "wifi_core_warm"
- "wifi_core_cold"
-- clocks: List of clock specifiers, must contain an entry for each required
- entry in clock-names.
-- clock-names: Should contain the clock names "wifi_wcss_cmd", "wifi_wcss_ref",
- "wifi_wcss_rtc" for "qcom,ipq4019-wifi" compatible target and
- "cxo_ref_clk_pin" and optionally "qdss" for
Re: [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML
On 11.04.2023 17:59, Krzysztof Kozlowski wrote: > On 06/04/2023 14:55, Konrad Dybcio wrote: >> Convert the ATH10K bindings to YAML. >> >> Dropped properties that are absent at the current state of mainline: >> - qcom,msi_addr >> - qcom,msi_base >> >> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should >> be reconsidered on the driver side, especially the latter one. >> >> Somewhat based on the ath11k bindings. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/net/wireless/qcom,ath10k.txt | 215 - >> .../bindings/net/wireless/qcom,ath10k.yaml | 357 >> + >> 2 files changed, 357 insertions(+), 215 deletions(-) > > You should have received kernel test robot warning. If not, just > confirming here - you need to fix paths (docs, maintainers). Will do Konrad > > Best regards, > Krzysztof > ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML
On 6.04.2023 20:30, Krzysztof Kozlowski wrote:
> On 06/04/2023 20:26, Konrad Dybcio wrote:
>
>>>> +interrupts:
>>>> + items:
>>>> +- description: CE0
>>>> +- description: CE1
>>>> +- description: CE2
>>>> +- description: CE3
>>>> +- description: CE4
>>>> +- description: CE5
>>>> +- description: CE6
>>>> +- description: CE7
>>>> +- description: CE8
>>>> +- description: CE9
>>>> +- description: CE10
>>>> +- description: CE11
>>>
>>> What about interrupt-names here? If they are not expected, then just
>>> interrupt-names: false
>> They obviously wouldn't hurt, but they're unused on the driver side:
>>
>> for (i = 0; i < CE_COUNT; i++) {
>> ret = platform_get_irq(ar_snoc->dev, i);
>>
>> So I will forbid them.
>
> Assuming DTS does not have them.
Tested locally, no warnings, so looks like nobody used them in dt.
Konrad
>
> Best regards,
> Krzysztof
>
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML
On 6.04.2023 19:15, Krzysztof Kozlowski wrote:
> On 06/04/2023 14:55, Konrad Dybcio wrote:
>> Convert the ATH10K bindings to YAML.
>>
>> Dropped properties that are absent at the current state of mainline:
>> - qcom,msi_addr
>> - qcom,msi_base
>>
>> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should
>> be reconsidered on the driver side, especially the latter one.
>>
>> Somewhat based on the ath11k bindings.
>
>
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +allOf:
>> + - if:
>> + properties:
>> +compatible:
>> + contains:
>> +enum:
>> + - qcom,ipq4019-wifi
>> +then:
>> + properties:
>> +interrupts:
>> + minItems: 17
>> + maxItems: 17
>> +
>> +interrupt-names:
>> + minItems: 17
>
> Drop minItems (the number of items is defined by listing them below, as
> you did).
OK
>
>> + items:
>> +- const: msi0
>> +- const: msi1
>> +- const: msi2
>> +- const: msi3
>> +- const: msi4
>> +- const: msi5
>> +- const: msi6
>> +- const: msi7
>> +- const: msi8
>> +- const: msi9
>> +- const: msi10
>> +- const: msi11
>> +- const: msi12
>> +- const: msi13
>> +- const: msi14
>> +- const: msi15
>> +- const: legacy
>> +
>> +clocks:
>> + items:
>> +- description: Wi-Fi command clock
>> +- description: Wi-Fi reference clock
>> +- description: Wi-Fi RTC clock
>> +
>> +clock-names:
>> + items:
>> +- const: wifi_wcss_cmd
>> +- const: wifi_wcss_ref
>> +- const: wifi_wcss_rtc
>> +
>> + required:
>> +- clocks
>> +- clock-names
>> +- interrupts
>> +- interrupt-names
>> +- resets
>> +- reset-names
>> +
>> + - if:
>> + properties:
>> +compatible:
>> + contains:
>> +enum:
>> + - qcom,wcn3990-wifi
>> +
>> +then:
>> + properties:
>> +clocks:
>> + minItems: 1
>> + items:
>> +- description: XO reference clock
>> +- description: Qualcomm Debug Subsystem clock
>> +
>> +clock-names:
>> + minItems: 1
>> + items:
>> +- const: cxo_ref_clk_pin
>> +- const: qdss
>> +
>> +interrupts:
>> + items:
>> +- description: CE0
>> +- description: CE1
>> +- description: CE2
>> +- description: CE3
>> +- description: CE4
>> +- description: CE5
>> +- description: CE6
>> +- description: CE7
>> +- description: CE8
>> +- description: CE9
>> +- description: CE10
>> +- description: CE11
>
> What about interrupt-names here? If they are not expected, then just
> interrupt-names: false
They obviously wouldn't hurt, but they're unused on the driver side:
for (i = 0; i < CE_COUNT; i++) {
ret = platform_get_irq(ar_snoc->dev, i);
So I will forbid them.
Konrad
>
>
>
> Best regards,
> Krzysztof
>
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH v3 1/2] dt-bindings: net: Convert ATH10K to YAML
Convert the ATH10K bindings to YAML.
Dropped properties that are absent at the current state of mainline:
- qcom,msi_addr
- qcom,msi_base
qcom,coexist-support and qcom,coexist-gpio-pin do very little and should
be reconsidered on the driver side, especially the latter one.
Somewhat based on the ath11k bindings.
Signed-off-by: Konrad Dybcio
---
.../bindings/net/wireless/qcom,ath10k.txt | 215 -
.../bindings/net/wireless/qcom,ath10k.yaml | 357 +
2 files changed, 357 insertions(+), 215 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
deleted file mode 100644
index b61c2d5a0ff7..
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ /dev/null
@@ -1,215 +0,0 @@
-* Qualcomm Atheros ath10k wireless devices
-
-Required properties:
-- compatible: Should be one of the following:
- * "qcom,ath10k"
- * "qcom,ipq4019-wifi"
- * "qcom,wcn3990-wifi"
-
-PCI based devices uses compatible string "qcom,ath10k" and takes calibration
-data along with board specific data via "qcom,ath10k-calibration-data".
-Rest of the properties are not applicable for PCI based devices.
-
-AHB based devices (i.e. ipq4019) uses compatible string "qcom,ipq4019-wifi"
-and also uses most of the properties defined in this doc (except
-"qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-data"
-to carry pre calibration data.
-
-In general, entry "qcom,ath10k-pre-calibration-data" and
-"qcom,ath10k-calibration-data" conflict with each other and only one
-can be provided per device.
-
-SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
-
-- reg: Address and length of the register set for the device.
-- reg-names: Must include the list of following reg names,
-"membase"
-- interrupts: reference to the list of 17 interrupt numbers for
"qcom,ipq4019-wifi"
- compatible target.
- reference to the list of 12 interrupt numbers for
"qcom,wcn3990-wifi"
- compatible target.
- Must contain interrupt-names property per entry for
- "qcom,ath10k", "qcom,ipq4019-wifi" compatible targets.
-
-- interrupt-names: Must include the entries for MSI interrupt
- names ("msi0" to "msi15") and legacy interrupt
- name ("legacy") for "qcom,ath10k", "qcom,ipq4019-wifi"
- compatible targets.
-
-Optional properties:
-- resets: Must contain an entry for each entry in reset-names.
- See ../reset/reseti.txt for details.
-- reset-names: Must include the list of following reset names,
- "wifi_cpu_init"
- "wifi_radio_srif"
- "wifi_radio_warm"
- "wifi_radio_cold"
- "wifi_core_warm"
- "wifi_core_cold"
-- clocks: List of clock specifiers, must contain an entry for each required
- entry in clock-names.
-- clock-names: Should contain the clock names "wifi_wcss_cmd", "wifi_wcss_ref",
- "wifi_wcss_rtc" for "qcom,ipq4019-wifi" compatible target and
- "cxo_ref_clk_pin" and optionally "qdss" for "qcom,wcn3990-wifi"
- compatible target.
-- qcom,msi_addr: MSI interrupt address.
-- qcom,msi_base: Base value to add before writing MSI data into
- MSI address register.
-- qcom,ath10k-calibration-variant: string to search for in the board-2.bin
- variant list with the same bus and device
- specific ids
-- qcom,ath10k-calibration-data : calibration data + board specific data
-as an array, the length can vary between
-hw versions.
-- qcom,ath10k-pre-calibration-data : pre calibration data as an array,
-the length can vary between hw versions.
-- -supply: handle to the regulator device tree node
- optional "supply-name" are "vdd-0.8-cx-mx",
- "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
- and "vdd-3.3-ch1".
-- memory-region:
- Usage: optional
- Value type:
- Definition: reference to the reserved-memory for the msa region
- used by the wifi firmware running in Q6.
-- iommus:
- Usage: optional
- Value type:
- Definition: A list of phandle and IOMMU specifier pairs.
-- ext-fem-nam
[PATCH v3 0/2] ATH10K YAML conversion
v2 -> v3:
- Ran dt_binding_check explicitly to uncover an issue with the
example - I had 2 levels of wifi-firmware{}.. Fixed that..
I hope you folks don't mind me resending so quickly, but it was a
trivial issue. Patch 2 unchanged.
v2:
https://lore.kernel.org/r/20230406-topic-ath10k_bindings-v2-0-557f884a6...@linaro.org
v1 -> v2:
Dropped:
- '|' in /description
- /properties/resets/minItems
- Unnecessary level of 'items:' in /properties/ext-fem-name
- reserved-memory in examples
- status in examples
- labels in examples
Added:
- /properties/wifi-firmware/additionalProperties: false
- /properties/wifi-firmware/properties/iommus
- /properties/qcom,coexist-support/enum (and reworded the description)
- wifi-firmware and supplies in the SNoC example
Patch 2 is unchanged, picked up rb.
v1:
https://lore.kernel.org/r/20230406-topic-ath10k_bindings-v1-0-1ef181c50...@linaro.org
This is my attempt at (finally) moving ATH10K to YAML.
One inexistent dt property came out as part of that.
Signed-off-by: Konrad Dybcio
---
Konrad Dybcio (2):
dt-bindings: net: Convert ATH10K to YAML
arm64: dts: qcom: sdm845-polaris: Drop inexistent properties
.../bindings/net/wireless/qcom,ath10k.txt | 215 -
.../bindings/net/wireless/qcom,ath10k.yaml | 357 +
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 -
3 files changed, 357 insertions(+), 217 deletions(-)
---
base-commit: 8417c8f5007bf4567ccffda850a3157c7d905f67
change-id: 20230406-topic-ath10k_bindings-9af5fa834235
Best regards,
--
Konrad Dybcio
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH v3 2/2] arm64: dts: qcom: sdm845-polaris: Drop inexistent properties
Drop the qcom,snoc-host-cap-skip-quirk that was never introduced to
solve schema warnings.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
index 1b7fdbae6a2b..56f2d855df78 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
@@ -712,7 +712,5 @@ {
vdd-1.3-rfa-supply = <_l17a_1p3>;
vdd-3.3-ch0-supply = <_l25a_3p3>;
vdd-3.3-ch1-supply = <_l23a_3p3>;
-
- qcom,snoc-host-cap-skip-quirk;
status = "okay";
};
--
2.40.0
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v2 1/2] dt-bindings: net: Convert ATH10K to YAML
On 6.04.2023 14:47, Rob Herring wrote: > > On Thu, 06 Apr 2023 13:54:04 +0200, Konrad Dybcio wrote: >> Convert the ATH10K bindings to YAML. >> >> Dropped properties that are absent at the current state of mainline: >> - qcom,msi_addr >> - qcom,msi_base >> >> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should >> be reconsidered on the driver side, especially the latter one. >> >> Somewhat based on the ath11k bindings. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/net/wireless/qcom,ath10k.txt | 215 >> .../bindings/net/wireless/qcom,ath10k.yaml | 359 >> + >> 2 files changed, 359 insertions(+), 215 deletions(-) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.example.dtb: > wifi@1880: wifi-firmware: 'wifi-firmware' does not match any of the > regexes: 'pinctrl-[0-9]+' > From schema: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.example.dtb: > wifi@1880: wifi-firmware: 'iommus' is a required property > From schema: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml > > doc reference errors (make refcheckdocs): > MAINTAINERS: Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > > See > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230406-topic-ath10k_bindings-v2-1-557f884a6...@linaro.org Oh, CHECK_DTBS=1 doesn't run dt_binding_check and I didn't run that explicitly before resending.. my bad.. Konrad > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH v2 1/2] dt-bindings: net: Convert ATH10K to YAML
Convert the ATH10K bindings to YAML.
Dropped properties that are absent at the current state of mainline:
- qcom,msi_addr
- qcom,msi_base
qcom,coexist-support and qcom,coexist-gpio-pin do very little and should
be reconsidered on the driver side, especially the latter one.
Somewhat based on the ath11k bindings.
Signed-off-by: Konrad Dybcio
---
.../bindings/net/wireless/qcom,ath10k.txt | 215
.../bindings/net/wireless/qcom,ath10k.yaml | 359 +
2 files changed, 359 insertions(+), 215 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
deleted file mode 100644
index b61c2d5a0ff7..
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ /dev/null
@@ -1,215 +0,0 @@
-* Qualcomm Atheros ath10k wireless devices
-
-Required properties:
-- compatible: Should be one of the following:
- * "qcom,ath10k"
- * "qcom,ipq4019-wifi"
- * "qcom,wcn3990-wifi"
-
-PCI based devices uses compatible string "qcom,ath10k" and takes calibration
-data along with board specific data via "qcom,ath10k-calibration-data".
-Rest of the properties are not applicable for PCI based devices.
-
-AHB based devices (i.e. ipq4019) uses compatible string "qcom,ipq4019-wifi"
-and also uses most of the properties defined in this doc (except
-"qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-data"
-to carry pre calibration data.
-
-In general, entry "qcom,ath10k-pre-calibration-data" and
-"qcom,ath10k-calibration-data" conflict with each other and only one
-can be provided per device.
-
-SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
-
-- reg: Address and length of the register set for the device.
-- reg-names: Must include the list of following reg names,
-"membase"
-- interrupts: reference to the list of 17 interrupt numbers for
"qcom,ipq4019-wifi"
- compatible target.
- reference to the list of 12 interrupt numbers for
"qcom,wcn3990-wifi"
- compatible target.
- Must contain interrupt-names property per entry for
- "qcom,ath10k", "qcom,ipq4019-wifi" compatible targets.
-
-- interrupt-names: Must include the entries for MSI interrupt
- names ("msi0" to "msi15") and legacy interrupt
- name ("legacy") for "qcom,ath10k", "qcom,ipq4019-wifi"
- compatible targets.
-
-Optional properties:
-- resets: Must contain an entry for each entry in reset-names.
- See ../reset/reseti.txt for details.
-- reset-names: Must include the list of following reset names,
- "wifi_cpu_init"
- "wifi_radio_srif"
- "wifi_radio_warm"
- "wifi_radio_cold"
- "wifi_core_warm"
- "wifi_core_cold"
-- clocks: List of clock specifiers, must contain an entry for each required
- entry in clock-names.
-- clock-names: Should contain the clock names "wifi_wcss_cmd", "wifi_wcss_ref",
- "wifi_wcss_rtc" for "qcom,ipq4019-wifi" compatible target and
- "cxo_ref_clk_pin" and optionally "qdss" for "qcom,wcn3990-wifi"
- compatible target.
-- qcom,msi_addr: MSI interrupt address.
-- qcom,msi_base: Base value to add before writing MSI data into
- MSI address register.
-- qcom,ath10k-calibration-variant: string to search for in the board-2.bin
- variant list with the same bus and device
- specific ids
-- qcom,ath10k-calibration-data : calibration data + board specific data
-as an array, the length can vary between
-hw versions.
-- qcom,ath10k-pre-calibration-data : pre calibration data as an array,
-the length can vary between hw versions.
-- -supply: handle to the regulator device tree node
- optional "supply-name" are "vdd-0.8-cx-mx",
- "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
- and "vdd-3.3-ch1".
-- memory-region:
- Usage: optional
- Value type:
- Definition: reference to the reserved-memory for the msa region
- used by the wifi firmware running in Q6.
-- iommus:
- Usage: optional
- Value type:
- Definition: A list of phandle and IOMMU specifier pairs.
-- ext-fem-nam
[PATCH v2 0/2] ATH10K YAML conversion
v1 -> v2: Dropped: - '|' in /description - /properties/resets/minItems - Unnecessary level of 'items:' in /properties/ext-fem-name - reserved-memory in examples - status in examples - labels in examples Added: - /properties/wifi-firmware/additionalProperties: false - /properties/wifi-firmware/properties/iommus - /properties/qcom,coexist-support/enum (and reworded the description) - wifi-firmware and supplies in the SNoC example Patch 2 is unchanged, picked up rb. v1: https://lore.kernel.org/r/20230406-topic-ath10k_bindings-v1-0-1ef181c50...@linaro.org This is my attempt at (finally) moving ATH10K to YAML. One inexistent dt property came out as part of that. Signed-off-by: Konrad Dybcio --- Konrad Dybcio (2): dt-bindings: net: Convert ATH10K to YAML arm64: dts: qcom: sdm845-polaris: Drop inexistent properties .../bindings/net/wireless/qcom,ath10k.txt | 215 .../bindings/net/wireless/qcom,ath10k.yaml | 359 + arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 - 3 files changed, 359 insertions(+), 217 deletions(-) --- base-commit: 8417c8f5007bf4567ccffda850a3157c7d905f67 change-id: 20230406-topic-ath10k_bindings-9af5fa834235 Best regards, -- Konrad Dybcio ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH 1/2] dt-bindings: net: Convert ATH10K to YAML
On 6.04.2023 10:06, Krzysztof Kozlowski wrote: > On 06/04/2023 02:59, Konrad Dybcio wrote: >> Convert the ATH10K bindings to YAML. >> >> Dropped properties that are absent at the current state of mainline: >> - qcom,msi_addr >> - qcom,msi_base >> >> qcom,coexist-support and qcom,coexist-gpio-pin do very little and should >> be reconsidered on the driver side, especially the latter one. >> >> Somewhat based on the ath11k bindings. >> Ack to everything, thanks Konrad > > Thank you for your patch. There is something to discuss/improve. > >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml >> new file mode 100644 >> index ..2ff004e404d9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml >> @@ -0,0 +1,357 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath10k.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies ATH10K wireless devices >> + >> +maintainers: >> + - Kalle Valo >> + >> +description: | > > Do not need '|'. > >> + Qualcomm Technologies, Inc. IEEE 802.11ac devices. >> + >> +properties: >> + compatible: >> +enum: >> + - qcom,ath10k # SDIO-based devices >> + - qcom,ipq4019-wifi >> + - qcom,wcn3990-wifi # SNoC-based devices >> + >> + reg: >> +maxItems: 1 >> + >> + reg-names: >> +items: >> + - const: membase >> + >> + interrupts: >> +minItems: 12 >> +maxItems: 17 >> + >> + interrupt-names: >> +minItems: 12 >> +maxItems: 17 >> + >> + memory-region: >> +maxItems: 1 >> +description: >> + Reference to the MSA memory region used by the Wi-Fi firmware >> + running on the Q6 core. >> + >> + iommus: >> +minItems: 1 >> +maxItems: 2 >> + >> + clocks: >> +minItems: 1 >> +maxItems: 3 >> + >> + clock-names: >> +minItems: 1 >> +maxItems: 3 >> + >> + resets: >> +minItems: 6 > > Drop minItems here. > >> +maxItems: 6 >> + >> + reset-names: >> +items: >> + - const: wifi_cpu_init >> + - const: wifi_radio_srif >> + - const: wifi_radio_warm >> + - const: wifi_radio_cold >> + - const: wifi_core_warm >> + - const: wifi_core_cold >> + >> + ext-fem-name: >> +$ref: /schemas/types.yaml#/definitions/string >> +description: Name of external front end module used. >> +items: > > Drop items (it's just enum) > >> + enum: >> +- microsemi-lx5586 >> +- sky85703-11 >> +- sky85803 >> + >> + wifi-firmware: >> +type: object > > additionalProperties: false > >> +description: | >> + The ATH10K Wi-Fi node can contain one optional firmware subnode. >> + Firmware subnode is needed when the platform does not have Trustzone. > > properties: > iommus: > maxItems: 1 > >> +required: >> + - iommus >> + >> + qcom,ath10k-calibration-data: >> +$ref: /schemas/types.yaml#/definitions/uint8-array >> +description: >> + Calibration data + board-specific data as a byte array. The length >> + can vary between hardware versions. >> + >> + qcom,ath10k-calibration-variant: >> +$ref: /schemas/types.yaml#/definitions/string >> +description: >> + Unique variant identifier of the calibration data in board-2.bin >> + for designs with colliding bus and device specific ids >> + >> + qcom,ath10k-pre-calibration-data: >> +$ref: /schemas/types.yaml#/definitions/uint8-array >> +description: >> + Pre-calibration data as a byte array. The length can vary between >> + hardware versions. >> + >> + qcom,coexist-support: >> +$ref: /schemas/types.yaml#/definitions/uint8 > > enum: [0, 1] > >> +description: >> + 0 or 1 to indicate coex support by the hardware. >> + >> + qcom,coexist-gpio-pin: >> +$ref: /schemas/types.yaml#/definitions/uint32 >> +description: >> + COEX GPIO number provided to the Wi-Fi firmware. >> + >> + qcom,msa-fi
[PATCH 0/2] ATH10K YAML conversion
This is my attempt at (finally) moving ATH10K to YAML. One inexistent dt property came out as part of that. Signed-off-by: Konrad Dybcio --- Konrad Dybcio (2): dt-bindings: net: Convert ATH10K to YAML arm64: dts: qcom: sdm845-polaris: Drop inexistent properties .../bindings/net/wireless/qcom,ath10k.txt | 215 - .../bindings/net/wireless/qcom,ath10k.yaml | 357 + arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 - 3 files changed, 357 insertions(+), 217 deletions(-) --- base-commit: 8417c8f5007bf4567ccffda850a3157c7d905f67 change-id: 20230406-topic-ath10k_bindings-9af5fa834235 Best regards, -- Konrad Dybcio ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH 1/2] dt-bindings: net: Convert ATH10K to YAML
Convert the ATH10K bindings to YAML.
Dropped properties that are absent at the current state of mainline:
- qcom,msi_addr
- qcom,msi_base
qcom,coexist-support and qcom,coexist-gpio-pin do very little and should
be reconsidered on the driver side, especially the latter one.
Somewhat based on the ath11k bindings.
Signed-off-by: Konrad Dybcio
---
.../bindings/net/wireless/qcom,ath10k.txt | 215 -
.../bindings/net/wireless/qcom,ath10k.yaml | 357 +
2 files changed, 357 insertions(+), 215 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
deleted file mode 100644
index b61c2d5a0ff7..
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ /dev/null
@@ -1,215 +0,0 @@
-* Qualcomm Atheros ath10k wireless devices
-
-Required properties:
-- compatible: Should be one of the following:
- * "qcom,ath10k"
- * "qcom,ipq4019-wifi"
- * "qcom,wcn3990-wifi"
-
-PCI based devices uses compatible string "qcom,ath10k" and takes calibration
-data along with board specific data via "qcom,ath10k-calibration-data".
-Rest of the properties are not applicable for PCI based devices.
-
-AHB based devices (i.e. ipq4019) uses compatible string "qcom,ipq4019-wifi"
-and also uses most of the properties defined in this doc (except
-"qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-data"
-to carry pre calibration data.
-
-In general, entry "qcom,ath10k-pre-calibration-data" and
-"qcom,ath10k-calibration-data" conflict with each other and only one
-can be provided per device.
-
-SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
-
-- reg: Address and length of the register set for the device.
-- reg-names: Must include the list of following reg names,
-"membase"
-- interrupts: reference to the list of 17 interrupt numbers for
"qcom,ipq4019-wifi"
- compatible target.
- reference to the list of 12 interrupt numbers for
"qcom,wcn3990-wifi"
- compatible target.
- Must contain interrupt-names property per entry for
- "qcom,ath10k", "qcom,ipq4019-wifi" compatible targets.
-
-- interrupt-names: Must include the entries for MSI interrupt
- names ("msi0" to "msi15") and legacy interrupt
- name ("legacy") for "qcom,ath10k", "qcom,ipq4019-wifi"
- compatible targets.
-
-Optional properties:
-- resets: Must contain an entry for each entry in reset-names.
- See ../reset/reseti.txt for details.
-- reset-names: Must include the list of following reset names,
- "wifi_cpu_init"
- "wifi_radio_srif"
- "wifi_radio_warm"
- "wifi_radio_cold"
- "wifi_core_warm"
- "wifi_core_cold"
-- clocks: List of clock specifiers, must contain an entry for each required
- entry in clock-names.
-- clock-names: Should contain the clock names "wifi_wcss_cmd", "wifi_wcss_ref",
- "wifi_wcss_rtc" for "qcom,ipq4019-wifi" compatible target and
- "cxo_ref_clk_pin" and optionally "qdss" for "qcom,wcn3990-wifi"
- compatible target.
-- qcom,msi_addr: MSI interrupt address.
-- qcom,msi_base: Base value to add before writing MSI data into
- MSI address register.
-- qcom,ath10k-calibration-variant: string to search for in the board-2.bin
- variant list with the same bus and device
- specific ids
-- qcom,ath10k-calibration-data : calibration data + board specific data
-as an array, the length can vary between
-hw versions.
-- qcom,ath10k-pre-calibration-data : pre calibration data as an array,
-the length can vary between hw versions.
-- -supply: handle to the regulator device tree node
- optional "supply-name" are "vdd-0.8-cx-mx",
- "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
- and "vdd-3.3-ch1".
-- memory-region:
- Usage: optional
- Value type:
- Definition: reference to the reserved-memory for the msa region
- used by the wifi firmware running in Q6.
-- iommus:
- Usage: optional
- Value type:
- Definition: A list of phandle and IOMMU specifier pairs.
-- ext-fem-nam
[PATCH 2/2] arm64: dts: qcom: sdm845-polaris: Drop inexistent properties
Drop the qcom,snoc-host-cap-skip-quirk that was never introduced to
solve schema warnings.
Signed-off-by: Konrad Dybcio
---
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
index 1b7fdbae6a2b..56f2d855df78 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
@@ -712,7 +712,5 @@ {
vdd-1.3-rfa-supply = <_l17a_1p3>;
vdd-3.3-ch0-supply = <_l25a_3p3>;
vdd-3.3-ch1-supply = <_l23a_3p3>;
-
- qcom,snoc-host-cap-skip-quirk;
status = "okay";
};
--
2.40.0
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply
On 3.03.2023 08:12, Krzysztof Kozlowski wrote: > On 03/03/2023 03:42, Konrad Dybcio wrote: >> Mention the newly added vdd-smps supply. > > There is no explanation here, but looking at your driver change it > suggests name is not correct. You named it based on regulator (so the > provider), not the consumer. Right, I admit this could have been posted with an RFC tag. Maybe Kalle knows more. Konrad > > Best regards, > Krzysztof > ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH 1/2] dt-bindings: ath10k: Add vdd-smps supply
Mention the newly added vdd-smps supply. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt index b61c2d5a0ff7..8697e63aeffa 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt @@ -66,7 +66,7 @@ Optional properties: - -supply: handle to the regulator device tree node optional "supply-name" are "vdd-0.8-cx-mx", "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0", - and "vdd-3.3-ch1". + "vdd-3.3-ch1" and "vdd-smps". - memory-region: Usage: optional Value type: -- 2.39.2 ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
[PATCH 2/2] wifi: ath10k: snoc: Add VDD_SMPS regulator
At least SM6375 (bundled with soc_id 0x400e) and SM4350 (bundled
with unknown, probably the same) expect one more supply, called vdd-smps
downstream. It's set to 0.984V and connected to a - you guessed it - SMPS
regulator on PM6125. Add support for it.
Signed-off-by: Konrad Dybcio
---
The smps name sounds like a quick downstream hack and is probably
something more exquisite in reality.. Not something I know, though.
drivers/net/wireless/ath/ath10k/snoc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath10k/snoc.c
b/drivers/net/wireless/ath/ath10k/snoc.c
index 9a82f0336d95..6443523131db 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -48,6 +48,7 @@ static const char * const ath10k_regulators[] = {
"vdd-1.3-rfa",
"vdd-3.3-ch0",
"vdd-3.3-ch1",
+ "vdd-smps",
};
static const char * const ath10k_clocks[] = {
--
2.39.2
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
