Re: [ath5k-devel] ath5k tx completion
2013/11/7 Adrian Chadd adr...@freebsd.org: On 7 November 2013 06:20, Bob Copeland m...@bobcopeland.com wrote: On Wed, Nov 06, 2013 at 09:17:46AM -0800, Adrian Chadd wrote: The TL;DR version - you need to keep the the final descriptor around for each hardware queue. The legacy madwifi/freebsd way of doing it was to keep the last descriptor that was handled. This wasn't enough. It needs to be per TX queue. You also must never program TxDP after you've programmed it once - you can only program it again after you've completely torn down TX DMA for the particular queue. This is a goldmine -- thank you for taking the time to write it up! I believe we can clean up ath5k's transmit loop a lot now... You're very welcome. I spent quite a lot of time waist deep in this crap. It turns out I had to go to the hardware guys and wade through the verilog to figure out what the hell was actually going on. * read-and-clear bugs * PHY register read problems, and why ANI may occasionally look whacked One thing at a time for me... but do we even want to know? :) If you want to avoid crazy crashes and hangs, yes? :) Also, ask me about key cache corruption too. -adrian ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel Adrian/Bob, these fixes (along with power saving etc) are very interesting projects and I was thinking to submit them in OPW (http://kernelnewbies.org/OPWIntro). Are you interested in mentoring (http://kernelnewbies.org/OPWMentor) ? I'm planing to submit ar5513 support and ar5210 fixes there and mentor (for the next period -June to September-). -- GPG ID: 0xEE878588 As you read this post global entropy rises. Have Fun ;-) Nick ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] ath5k tx completion
On 9 November 2013 05:40, Nick Kossifidis mickfl...@gmail.com wrote: Adrian/Bob, these fixes (along with power saving etc) are very interesting projects and I was thinking to submit them in OPW (http://kernelnewbies.org/OPWIntro). Are you interested in mentoring (http://kernelnewbies.org/OPWMentor) ? I'm happy to provide guidance for the technical / chip side of things, sure. I'm planing to submit ar5513 support and ar5210 fixes there and mentor (for the next period -June to September-). Cool! I hope you beat me to ar5513 support. The HAL is sufficiently different that even bringing it up on the latest madwifi or freebsd requires a lot of manual love. -adrian ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] ath5k tx completion
On Sat, Nov 09, 2013 at 07:54:31AM -0800, Adrian Chadd wrote: On 9 November 2013 05:40, Nick Kossifidis mickfl...@gmail.com wrote: Adrian/Bob, these fixes (along with power saving etc) are very interesting projects and I was thinking to submit them in OPW (http://kernelnewbies.org/OPWIntro). Are you interested in mentoring (http://kernelnewbies.org/OPWMentor) ? I'm happy to provide guidance for the technical / chip side of things, sure. Sounds intriguing -- yes I'd consider formally mentoring such a project. -- Bob Copeland %% www.bobcopeland.com ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] ath5k tx completion
2013/11/9 Adrian Chadd adr...@freebsd.org: On 9 November 2013 05:40, Nick Kossifidis mickfl...@gmail.com wrote: Adrian/Bob, these fixes (along with power saving etc) are very interesting projects and I was thinking to submit them in OPW (http://kernelnewbies.org/OPWIntro). Are you interested in mentoring (http://kernelnewbies.org/OPWMentor) ? I'm happy to provide guidance for the technical / chip side of things, sure. I'm planing to submit ar5513 support and ar5210 fixes there and mentor (for the next period -June to September-). Cool! I hope you beat me to ar5513 support. The HAL is sufficiently different that even bringing it up on the latest madwifi or freebsd requires a lot of manual love. Thanks m8 ! The idea is to allocate some time to study the code and any related docs (if you have any please share, I'll ping Atheros too), come up with a plan (especially for the PHY/RF part) and be prepared to mentor on the next period, that is June to September 2014. I know it's far away from now but I don't have any time to work on this at the moment and I don't want to risk any bad mentoring, plus we'll have hw by that time (Pavel already offered to help on this) and all that's needed. Where do you plan on working on this for FreeBSD ? -- GPG ID: 0xEE878588 As you read this post global entropy rises. Have Fun ;-) Nick ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] ath5k tx completion
2013/11/9 Bob Copeland m...@bobcopeland.com: On Sat, Nov 09, 2013 at 07:54:31AM -0800, Adrian Chadd wrote: On 9 November 2013 05:40, Nick Kossifidis mickfl...@gmail.com wrote: Adrian/Bob, these fixes (along with power saving etc) are very interesting projects and I was thinking to submit them in OPW (http://kernelnewbies.org/OPWIntro). Are you interested in mentoring (http://kernelnewbies.org/OPWMentor) ? I'm happy to provide guidance for the technical / chip side of things, sure. Sounds intriguing -- yes I'd consider formally mentoring such a project. Cool ! Are you ok to go for this period (December - March) or the next one (June - September) ? -- GPG ID: 0xEE878588 As you read this post global entropy rises. Have Fun ;-) Nick ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] ath5k tx completion
On Sat, Nov 09, 2013 at 05:55:00PM +, Nick Kossifidis wrote: Are you ok to go for this period (December - March) or the next one (June - September) ? From the site it looks a little late for this term (looks like final selection is just a few days away) -- but June would be better anyway. -- Bob Copeland %% www.bobcopeland.com ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
