Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS
On Sun, 2009-12-06 at 18:22 +0100, Lukáš Turek wrote: The new attribute NL80211_ATTR_WIPHY_COVERAGE_CLASS sets IEEE 802.11 Coverage Class, This patch assumes that all hardware supports this, which is not really what you want. You'll want to know if it can't be set. Yes, we assume rts/cts can be set always, but that's a _much_ safer bet. johannes signature.asc Description: This is a digitally signed message part ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS
On 6.12.2009 19:01 Johannes Berg wrote: This patch assumes that all hardware supports this, which is not really what you want. You'll want to know if it can't be set. Yes, we assume rts/cts can be set always, but that's a _much_ safer bet. If the hardware does not support it, the operation will fail with EOPNOTSUPP: # iw phy0 set coverage 1 command failed: Operation not supported (-95) Or is there a better solution? Lukas Turek signature.asc Description: This is a digitally signed message part. ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS
On Sun, 2009-12-06 at 19:45 +0100, Lukáš Turek wrote: On 6.12.2009 19:01 Johannes Berg wrote: This patch assumes that all hardware supports this, which is not really what you want. You'll want to know if it can't be set. Yes, we assume rts/cts can be set always, but that's a _much_ safer bet. If the hardware does not support it, the operation will fail with EOPNOTSUPP: # iw phy0 set coverage 1 command failed: Operation not supported (-95) Umm, no it won't, that's only with your specific mac80211 implementation. Try on rndis for instance. johannes signature.asc Description: This is a digitally signed message part ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS
On 6.12.2009 19:49 Johannes Berg wrote: Umm, no it won't, that's only with your specific mac80211 implementation. Try on rndis for instance. I looked at the rndis driver, but it seems it could be configured via wireless extensions only, it does not define cfg80211_ops at all, so I think it cannot be managed via nl80211 and I don't see your point there... Lukas Turek signature.asc Description: This is a digitally signed message part. ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS
On 6.12.2009 20:28 Lukáš Turek wrote: I looked at the rndis driver, but it seems it could be configured via wireless extensions only, it does not define cfg80211_ops at all, so I think it cannot be managed via nl80211 and I don't see your point there... Sorry, I looked at some older version of the driver... Lukas Turek signature.asc Description: This is a digitally signed message part. ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS
On 6.12.2009 19:49 Johannes Berg wrote: Umm, no it won't, that's only with your specific mac80211 implementation. Try on rndis for instance. So I looked at both drivers that define set_wiphy_params: rndis and iwmc3200wifi. Both ignore WIPHY_PARAM_RETRY_SHORT and WIPHY_PARAM_RETRY_LONG, so WIPHY_PARAM_COVERAGE_CLASS is just another parameter they would ignore. Anyway, I don't mind adding set_coverage_class to cfg80211_ops if you think it's the best solution. It won't change the netlink API. Lukas Turek signature.asc Description: This is a digitally signed message part. ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Re: [ath5k-devel] [PATCH 1/4] nl80211: Add new WIPHY attribute COVERAGE_CLASS
On Sun, 2009-12-06 at 22:59 +0100, Lukáš Turek wrote: On 6.12.2009 19:49 Johannes Berg wrote: Umm, no it won't, that's only with your specific mac80211 implementation. Try on rndis for instance. So I looked at both drivers that define set_wiphy_params: rndis and iwmc3200wifi. Both ignore WIPHY_PARAM_RETRY_SHORT and WIPHY_PARAM_RETRY_LONG, so WIPHY_PARAM_COVERAGE_CLASS is just another parameter they would ignore. Anyway, I don't mind adding set_coverage_class to cfg80211_ops if you think it's the best solution. It won't change the netlink API. Maybe we can just keep it the way you did it, and add capability flags for all of it (retry too) eventually. johannes signature.asc Description: This is a digitally signed message part ___ ath5k-devel mailing list ath5k-devel@lists.ath5k.org https://lists.ath5k.org/mailman/listinfo/ath5k-devel
