Re: [ath9k-devel] [RFCv2 09/10] ath9k: disable dynack algorithm when coverage class is set

2014-07-13 Thread Felix Fietkau
On 2014-07-13 12:18, Lorenzo Bianconi wrote:
> Disable ack timeout estimation algorithm if the coverage class has been
> configured
> 
> Signed-off-by: Lorenzo Bianconi 
I think this is broken, since it doesn't allow you to re-enable dynack
through the same way as it was disabled.
I would recommend adding an 'auto' value for coverage class.

- Felix
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel


Re: [ath9k-devel] [RFCv2 09/10] ath9k: disable dynack algorithm when coverage class is set

2014-07-13 Thread Hosam Hittini
I don’t know why I’m a part of this
Getting so many emails!

Regards,
Eng. Hosam Hittini

On Jul 13, 2014, at 2:30 PM, Felix Fietkau  wrote:

> On 2014-07-13 12:18, Lorenzo Bianconi wrote:
>> Disable ack timeout estimation algorithm if the coverage class has been
>> configured
>> 
>> Signed-off-by: Lorenzo Bianconi 
> I think this is broken, since it doesn't allow you to re-enable dynack
> through the same way as it was disabled.
> I would recommend adding an 'auto' value for coverage class.
> 
> - Felix
> ___
> ath9k-devel mailing list
> ath9k-devel@lists.ath9k.org
> https://lists.ath9k.org/mailman/listinfo/ath9k-devel

___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel


Re: [ath9k-devel] [RFCv2 09/10] ath9k: disable dynack algorithm when coverage class is set

2014-07-13 Thread Lorenzo Bianconi
> On 2014-07-13 12:18, Lorenzo Bianconi wrote:
>> Disable ack timeout estimation algorithm if the coverage class has been
>> configured
>>
>> Signed-off-by: Lorenzo Bianconi 
> I think this is broken, since it doesn't allow you to re-enable dynack
> through the same way as it was disabled.
> I would recommend adding an 'auto' value for coverage class.

Ok. Could we use 255 as 'auto' value? Did you mean something else?
According to the standard maximum value for coverage class is 31, isn't it?

>
> - Felix

Best regards,

Lorenzo


-- 
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep
___
ath9k-devel mailing list
ath9k-devel@lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel