Re: [9] Review request for 8165428: Security Warning dialog should be always on the top when multiple applets with APPLICATION_MODAL dialog launched in a browser

[Alexey Ivanov]

Looks fine to me too.


Regards,
Alexey

On 07.12.2016 21:01, dmitry markov wrote:

Thank you very much, Sergey!
Looking for the second +1 from someone else.

Thanks,
Dmitry
On 07/12/2016 19:25, Sergey Bylokhov wrote:

Looks fine.

7 дек. 2016 г., в 2:24, Dmitry Markov > написал(а):


Hi Sergey,

I agree, it is not necessary to increase the toolkit counter here. 
It is a copy-paste error. I am sorry about that. Please find the 
updated webrev here: 
http://cr.openjdk.java.net/~dmarkov/8165428/webrev.02/ 



Thanks,
Dmitry
On 07 Dec 2016, at 03:40, Sergey Bylokhov 
mailto:sergey.bylok...@oracle.com>> wrote:


This logic looks better by it is unclear why you increase the 
toolkit’s counter?

[AWTToolkit eventCountPlusPlus];
This counter should be increased in the native callbacks and should 
indicate that there are some activity on the toolkit thread. But it 
seems it is unnecessary in the new isBlocked() method?


2 дек. 2016 г., в 3:16, dmitry markov > написал(а):


Hi Sergey,

According to the current implementation we disable a window only 
when we are going to show a modal dialog. However I agree it is 
not a good idea to use isEnabled flag for testing whether the 
window is blocked or not, since such logic is not clear and might 
be accidentally broken. So I have updated the fix; new webrev is 
located at http://cr.openjdk.java.net/~dmarkov/8165428/webrev.01/ 


Summary of changes:
- Added a new function isBlocked() to CPlatformWindow class
- In AWTWindow.m use isBlocked() instead of isEnabled in the cases 
where we have to decide whether the ordering operation is required 
or not.


Thanks,
Dmitry
On 01/12/2016 03:29, Sergey Bylokhov wrote:

Hi, Dmitry.
Is it true that the window is disable only if blocked by some 
other window? Is it possible a situation when it can be disabled 
by application and in the same moment can have an enabled child 
which should be moved upfront?

Re: [9] Review request for 8165428: Security Warning dialog should be always on the top when multiple applets with APPLICATION_MODAL dialog launched in a browser

[dmitry markov]

Thank you very much, Sergey!
Looking for the second +1 from someone else.

Thanks,
Dmitry
On 07/12/2016 19:25, Sergey Bylokhov wrote:

Looks fine.

7 дек. 2016 г., в 2:24, Dmitry Markov > написал(а):


Hi Sergey,

I agree, it is not necessary to increase the toolkit counter here. It 
is a copy-paste error. I am sorry about that. Please find the updated 
webrev here: http://cr.openjdk.java.net/~dmarkov/8165428/webrev.02/ 



Thanks,
Dmitry
On 07 Dec 2016, at 03:40, Sergey Bylokhov 
mailto:sergey.bylok...@oracle.com>> wrote:


This logic looks better by it is unclear why you increase the 
toolkit’s counter?

[AWTToolkit eventCountPlusPlus];
This counter should be increased in the native callbacks and should 
indicate that there are some activity on the toolkit thread. But it 
seems it is unnecessary in the new isBlocked() method?


2 дек. 2016 г., в 3:16, dmitry markov > написал(а):


Hi Sergey,

According to the current implementation we disable a window only 
when we are going to show a modal dialog. However I agree it is not 
a good idea to use isEnabled flag for testing whether the window is 
blocked or not, since such logic is not clear and might be 
accidentally broken. So I have updated the fix; new webrev is 
located at http://cr.openjdk.java.net/~dmarkov/8165428/webrev.01/ 


Summary of changes:
- Added a new function isBlocked() to CPlatformWindow class
- In AWTWindow.m use isBlocked() instead of isEnabled in the cases 
where we have to decide whether the ordering operation is required 
or not.


Thanks,
Dmitry
On 01/12/2016 03:29, Sergey Bylokhov wrote:

Hi, Dmitry.
Is it true that the window is disable only if blocked by some 
other window? Is it possible a situation when it can be disabled 
by application and in the same moment can have an enabled child 
which should be moved upfront?

Re: [9] Review request for 8165428: Security Warning dialog should be always on the top when multiple applets with APPLICATION_MODAL dialog launched in a browser

[Sergey Bylokhov]

Looks fine.

> 7 дек. 2016 г., в 2:24, Dmitry Markov  написал(а):
> 
> Hi Sergey,
> 
> I agree, it is not necessary to increase the toolkit counter here. It is a 
> copy-paste error. I am sorry about that. Please find the updated webrev here: 
> http://cr.openjdk.java.net/~dmarkov/8165428/webrev.02/ 
> 
> 
> Thanks,
> Dmitry 
>> On 07 Dec 2016, at 03:40, Sergey Bylokhov > > wrote:
>> 
>> This logic looks better by it is unclear why you increase the toolkit’s 
>> counter?
>> [AWTToolkit eventCountPlusPlus];
>> This counter should be increased in the native callbacks and should indicate 
>> that there are some activity on the toolkit thread. But it seems it is 
>> unnecessary in the new isBlocked() method?
>> 
>>> 2 дек. 2016 г., в 3:16, dmitry markov >> > написал(а):
>>> 
>>> Hi Sergey,
>>> 
>>> According to the current implementation we disable a window only when we 
>>> are going to show a modal dialog. However I agree it is not a good idea to 
>>> use isEnabled flag for testing whether the window is blocked or not, since 
>>> such logic is not clear and might be accidentally broken. So I have updated 
>>> the fix; new webrev is located at 
>>> http://cr.openjdk.java.net/~dmarkov/8165428/webrev.01/ 
>>> 
>>> Summary of changes:
>>> - Added a new function isBlocked() to CPlatformWindow class
>>> - In AWTWindow.m use isBlocked() instead of isEnabled in the cases where we 
>>> have to decide whether the ordering operation is required or not.
>>> 
>>> Thanks,
>>> Dmitry
>>> On 01/12/2016 03:29, Sergey Bylokhov wrote:
 Hi, Dmitry.
 Is it true that the window is disable only if blocked by some other 
 window? Is it possible a situation when it can be disabled by application 
 and in the same moment can have an enabled child which should be moved 
 upfront?
 
>>> 
>> 
> 

Re: [9] Review request for 8165428: Security Warning dialog should be always on the top when multiple applets with APPLICATION_MODAL dialog launched in a browser

[Dmitry Markov]

Hi Sergey,

I agree, it is not necessary to increase the toolkit counter here. It is a 
copy-paste error. I am sorry about that. Please find the updated webrev here: 
http://cr.openjdk.java.net/~dmarkov/8165428/webrev.02/

Thanks,
Dmitry 
> On 07 Dec 2016, at 03:40, Sergey Bylokhov  wrote:
> 
> This logic looks better by it is unclear why you increase the toolkit’s 
> counter?
> [AWTToolkit eventCountPlusPlus];
> This counter should be increased in the native callbacks and should indicate 
> that there are some activity on the toolkit thread. But it seems it is 
> unnecessary in the new isBlocked() method?
> 
>> 2 дек. 2016 г., в 3:16, dmitry markov > > написал(а):
>> 
>> Hi Sergey,
>> 
>> According to the current implementation we disable a window only when we are 
>> going to show a modal dialog. However I agree it is not a good idea to use 
>> isEnabled flag for testing whether the window is blocked or not, since such 
>> logic is not clear and might be accidentally broken. So I have updated the 
>> fix; new webrev is located at 
>> http://cr.openjdk.java.net/~dmarkov/8165428/webrev.01/ 
>> 
>> Summary of changes:
>> - Added a new function isBlocked() to CPlatformWindow class
>> - In AWTWindow.m use isBlocked() instead of isEnabled in the cases where we 
>> have to decide whether the ordering operation is required or not.
>> 
>> Thanks,
>> Dmitry
>> On 01/12/2016 03:29, Sergey Bylokhov wrote:
>>> Hi, Dmitry.
>>> Is it true that the window is disable only if blocked by some other window? 
>>> Is it possible a situation when it can be disabled by application and in 
>>> the same moment can have an enabled child which should be moved upfront?
>>> 
>> 
> 

Re: [9] Review request for 8165428: Security Warning dialog should be always on the top when multiple applets with APPLICATION_MODAL dialog launched in a browser

[Sergey Bylokhov]

This logic looks better by it is unclear why you increase the toolkit’s counter?
[AWTToolkit eventCountPlusPlus];
This counter should be increased in the native callbacks and should indicate 
that there are some activity on the toolkit thread. But it seems it is 
unnecessary in the new isBlocked() method?

> 2 дек. 2016 г., в 3:16, dmitry markov  написал(а):
> 
> Hi Sergey,
> 
> According to the current implementation we disable a window only when we are 
> going to show a modal dialog. However I agree it is not a good idea to use 
> isEnabled flag for testing whether the window is blocked or not, since such 
> logic is not clear and might be accidentally broken. So I have updated the 
> fix; new webrev is located at 
> http://cr.openjdk.java.net/~dmarkov/8165428/webrev.01/
> Summary of changes:
> - Added a new function isBlocked() to CPlatformWindow class
> - In AWTWindow.m use isBlocked() instead of isEnabled in the cases where we 
> have to decide whether the ordering operation is required or not.
> 
> Thanks,
> Dmitry
> On 01/12/2016 03:29, Sergey Bylokhov wrote:
>> Hi, Dmitry.
>> Is it true that the window is disable only if blocked by some other window? 
>> Is it possible a situation when it can be disabled by application and in the 
>> same moment can have an enabled child which should be moved upfront?
>> 
> 

Re: [9] Review request for 8165428: Security Warning dialog should be always on the top when multiple applets with APPLICATION_MODAL dialog launched in a browser

[dmitry markov]

Hi Sergey,

According to the current implementation we disable a window only when we 
are going to show a modal dialog. However I agree it is not a good idea 
to use isEnabled flag for testing whether the window is blocked or not, 
since such logic is not clear and might be accidentally broken. So I 
have updated the fix; new webrev is located at 
http://cr.openjdk.java.net/~dmarkov/8165428/webrev.01/

Summary of changes:
- Added a new function isBlocked() to CPlatformWindow class
- In AWTWindow.m use isBlocked() instead of isEnabled in the cases where 
we have to decide whether the ordering operation is required or not.


Thanks,
Dmitry
On 01/12/2016 03:29, Sergey Bylokhov wrote:

Hi, Dmitry.
Is it true that the window is disable only if blocked by some other 
window? Is it possible a situation when it can be disabled by 
application and in the same moment can have an enabled child which 
should be moved upfront?

Re: [9] Review request for 8165428: Security Warning dialog should be always on the top when multiple applets with APPLICATION_MODAL dialog launched in a browser

[Sergey Bylokhov]

Hi, Dmitry.
Is it true that the window is disable only if blocked by some other 
window? Is it possible a situation when it can be disabled by 
application and in the same moment can have an enabled child which 
should be moved upfront?


--
Best regards, Sergey.

[9] Review request for 8165428: Security Warning dialog should be always on the top when multiple applets with APPLICATION_MODAL dialog launched in a browser

[Dmitry Markov]

Hello,

Could you review a fix for jdk9, please?

bug: https://bugs.openjdk.java.net/browse/JDK-8165428
webrev: http://cr.openjdk.java.net/~dmarkov/8165428/webrev.00/

Problem description:
Sometimes the function orderChildWindows() might be called for the window which 
is blocked by a modal dialog. That may cause the following problem: the modal 
dialog is overlapped by window’s children windows which are popped up during 
ordering.

Fix:
The ordering should not be performed for blocked windows.

Thanks,
Dmitry