Review request for JDK-8025409: Fix javadoc comments errors and warning reported by doclint report
Hi, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8025409 Fix javadoc comments errors and warning reported by doclint report webrev: http://cr.openjdk.java.net/~cl/8025409/webrev.00/ Thanks Christine
Review request for JDK-8025840: Fix all the doclint warnings about trademark
Hi, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8025840 Fix all the doclint warnings about trademark webrev: http://cr.openjdk.java.net/~cl/8025840/webrev.00/ Thanks Christine
Re: Review request for JDK-8025840: Fix all the doclint warnings about trademark
Artem, Yes, there are warnings about it, in the same report as those trademark warnings in http://rehudson.us.oracle.com:8080/hudson/job/christine/lastSuccessfulBuild/artifact/client-doclint-html/javax_swing-accessibility.txt /tmp/workspace/christine-2-solaris-i586/jdk8-awt/382/jdk/src/share/classes/javax/swing/BoxLayout.java:39: warning: attribute obsolete, use CSS instead: ALIGN * ^ /tmp/workspace/christine-2-solaris-i586/jdk8-awt/382/jdk/src/share/classes/javax/swing/BoxLayout.java:42: warning: attribute obsolete, use CSS instead: ALIGN * When I saw them, I fixed them together. But then realized there are more warnings like this in other files, which should be done in another CR and another push. So I focus on trademark warnings but keep BoxLayout.java fix. Thanks for reviewing. Christine Artem Ananiev wrote: Hi, Christine, trademark changes look fine. What's wrong with the table in BoxLayout.java? Were there any warnings reported about it? Thanks, Artem On 10/5/2013 4:08 AM, [email protected] wrote: Hi, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8025840 Fix all the doclint warnings about trademark webrev: http://cr.openjdk.java.net/~cl/8025840/webrev.00/ Thanks Christine
Review request for JDK-8026021: more fix of javadoc errors and warnings reported by doclint
Hi, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8026021 more fix of javadoc errors and warnings reported by doclint, see the description webrev: http://cr.openjdk.java.net/~cl/8026021/webrev.00/ Thanks Christine
Re: Review request for JDK-8026021: more fix of javadoc errors and warnings reported by doclint
Please see my comment inline.
Anthony Petrov wrote:
Hi Christine,
src/share/classes/java/awt/event/InputEvent.java
- *
+ * {@code
The {@code} is redundant here because the tag forces the text to
use a fixed-size font already. Same comment for
src/share/classes/java/awt/font/LineBreakMeasurer.java.
Without {@code}, I will need to change & to & because it is an
error. I can simply change & to & then I don't need {@code
/hudson/jobs/jdk8-jdk-build-all/workspace/jdk/src/share/classes/java/awt/event/InputEvent.java:448:
error: bad HTML entity
*if ((event.getModifiersEx() & (onmask | offmask)) == onmask) {
^
In my Crucible code review, Joe suggested to use {@code} so we can leave
>, <, & unchanged.
src/share/classes/java/awt/event/MouseEvent.java
- * Component). Due to platform-dependent Drag&Drop
implementations,
+ * Component). Due to platform-dependent Drag&Drop
implementations,
Since you change this line anyway, I also suggest to replace
with {@code} here. Same comment for
src/share/classes/java/awt/font/NumericShaper.java.
For NumericShaper.java, if I change ... to {@code ... },
it introduces 2 errors. If I only change & to & then it is fine.
NumericShaper.java:1215: error: unterminated inline tag
* {@code if ((shaper.getRanges() & shaper.ARABIC) != 0) { ... }
^
NumericShaper.java:1214: error: element not closed: blockquote
*
^
Thanks
Christine
src/share/classes/java/awt/font/OpenType.java
- * ( href=http://www.microsoft.com/typography/otspec/";>http://www.microsoft.com/typography/otspec/l
).
+ * ( href="http://www.microsoft.com/typography/otspec/";>http://www.microsoft.com/typography/otspec/l
).
There's an extra 'l' character right before the closing , which
needs to be removed.
--
best regards,
Anthony
On 10/08/2013 05:59 AM, [email protected] wrote:
Hi,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8026021
more fix of javadoc errors and warnings reported by doclint, see the
description
webrev: http://cr.openjdk.java.net/~cl/8026021/webrev.00/
Thanks
Christine
Re: Review request for JDK-8026021: more fix of javadoc errors and warnings reported by doclint
Thank you all for reviewing. I have posted a new webrev at
http://cr.openjdk.java.net/~cl/8026021/webrev.01
Thanks
Christine
Sergey Bylokhov wrote:
Hi Christine,
Also looks like you fix include the fix for
http://mail.openjdk.java.net/pipermail/awt-dev/2013-September/005699.html
InputContext.java:
If you look to the generated javadoc you'll see that now the space
before list is not the same to the space after the list. So
from the beggining should be removed as well.
On 10/8/13 12:51 PM, Anthony Petrov wrote:
Hi
Christine,
src/share/classes/java/awt/event/InputEvent.java
- *
+ * {@code
I think not in this case. Since pre tag does not work with &
correctly. Probably pre can be removed here?
I n the NumericShaper.java I see that & was changed to the
& inside . I suppose it is not necessary and
can be changed to {@code}
Same question about JTextComponent.java can we use {@code} tag for the
code instead of ≥
The {@code} is redundant here because the tag forces the
text to use a fixed-size font already. Same comment for
src/share/classes/java/awt/font/LineBreakMeasurer.java.
src/share/classes/java/awt/event/MouseEvent.java
- * Component).
Due to platform-dependent Drag&Drop implementations,
+ * Component). Due to platform-dependent
Drag&Drop implementations,
Since you change this line anyway, I also suggest to replace
with {@code} here. Same comment for
src/share/classes/java/awt/font/NumericShaper.java.
src/share/classes/java/awt/font/OpenType.java
- * ( http://www.microsoft.com/typography/otspec/">http://www.microsoft.com/typography/otspec/l
).
+ * ( "http://www.microsoft.com/typography/otspec/">http://www.microsoft.com/typography/otspec/l
).
There's an extra 'l' character right before the closing ,
which needs to be removed.
--
best regards,
Anthony
On 10/08/2013 05:59 AM, [email protected]
wrote:
Hi,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8026021
more fix of javadoc errors and warnings reported by doclint, see the
description
webrev: http://cr.openjdk.java.net/~cl/8026021/webrev.00/
Thanks
Christine
--
Best regards, Sergey.
Review request for JDK-8032527: fix the errors reported by doclint report in jdk repo
Hi, Please review a fix for JDK-8032527 fix the errors reported by doclint report in jdk repo. webrev: http://cr.openjdk.java.net/~cl/8032527/webrev.00/ Thanks Christine
