Re: [Axis2] Issues with the current code base
On 1/29/07, Deepal Jayasinghe <[EMAIL PROTECTED]> wrote: Hi all; I just went though the current code base and realized that MessageContext code has been changed a lot . I found few issues with the code base and hope we need to fix them. So I thought of sending this mail for everyone's consideration. Well someone please explain to me whose going to need MessageContext serialization , Chamikara : Do you want that for Sandesha ? Currently no. But Matt had mentioned that he is working on something that uses this. Matt ? Ruchith : Do you want that for Security ? If none of you want this , who else need this ? I am asking this question b'coz introduction of MC serialization we have the following for each req. - When ever Axis2 received a message it calls activateMessageContext(msgContext); - And what that does is , it calls mc.activate(engineContext); method Unfortunately that method is TOO long and was very difficult to understand :). Ann can you simplify the method (that will be very helpful) . In the meantime code convention in MC has changed a lot and need to have very consistent code convention, please do not differ form that. Among the all , the most worst thing I saw in the code is following kind of things, I strongly believe we should not have this kind of code in the code base, If you found such kind of code please point out them then and there. - String tmpClassNameStr = "null"; (is this the way we initialize to NULL ) - String tmpHasList = "no list" - Unnecessary casting - A number of unused variables - Variable declarations here and there (as an example private static final String - selfManagedDataDelimiter = "*";) In addition to that someone has added code to change OutInAxisOperation name in the client side temporally, can I know why ? So please comment your ideas on this. Thanks Deepal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (AXIS2-1990) myService5.init(sc) and myService5.destroy(sc) not called on a http://alpha1:8080/manager/html/start?path=/axis2 -> start /stop-click in scope=application
[ https://issues.apache.org/jira/browse/AXIS2-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josef Stadelmann updated AXIS2-1990: Attachment: MyService5.aar Hi Deepal, here is the wanted aar file. Take care, scope should be soapsessions to track down the reported bug's. but is at application now, as I had to go on with development. Josef > myService5.init(sc) and myService5.destroy(sc) not called on a > http://alpha1:8080/manager/html/start?path=/axis2 -> start /stop-click in > scope=application > --- > > Key: AXIS2-1990 > URL: https://issues.apache.org/jira/browse/AXIS2-1990 > Project: Axis 2.0 (Axis2) > Issue Type: Bug > Components: samples, build,site >Affects Versions: 1.1 > Environment: Any tomcat platform and version and axis2-1.1.x in > scope=application >Reporter: Josef Stadelmann > Assigned To: Deepal Jayasinghe > Attachments: MyService5.aar > > > Hi Team, > I am running myService5 in application scope! axis2-1.1 > when stop is called from http://alpha1:8080/manager/html/start?path=/axis2 > myService5.destroy() is called too late and an exception is raised > 2007-01-17 08:01:54,518 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying module : addressing-1.1 > 2007-01-17 08:01:54,518 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying module : logging > 2007-01-17 08:01:54,549 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying module : soapmonitor-1.1 > 2007-01-17 08:01:54,908 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying Web service Library.aar > 2007-01-17 08:01:54,940 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying Web service MyService.aar > 2007-01-17 08:01:54,971 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying Web service MyService1.aar > 2007-01-17 08:01:55,705 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying Web service MyService4.aar > 2007-01-17 08:01:56,143 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying Web service MyService5.aar > 2007-01-17 08:01:56,174 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying Web service MyServiceWithModule.aar > 2007-01-17 08:01:56,190 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying Web service version.aar > 2007-01-17 08:01:56,205 INFO org.apache.axis2.deployment.DeploymentEngine - > Deploying Web service WsaMappingService.aar > 2007-01-17 08:01:56,221 INFO userguide.example5.MyService - > MyService5.init() called > So far the stdout_20070117.log of tomcat running on my PC > BUG: calling myService5.destroy(sc) in scope=application is called too late > up on receiving the stop signal from the tomcat manager > The exception logged is > 2007-01-17 08:07:32,808 INFO org.apache.axis2.engine.DependencyManager - > Exception trying to call destroy > java.lang.reflect.InvocationTargetException > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:585) > at > org.apache.axis2.engine.DependencyManager.destroyServiceObject(DependencyManager.java:127) > at > org.apache.axis2.context.ConfigurationContext.cleanupServiceContexts(ConfigurationContext.java:356) > at > org.apache.axis2.context.ConfigurationContext.cleanupContexts(ConfigurationContext.java:370) > at > org.apache.axis2.engine.ListenerManager.stop(ListenerManager.java:177) > at > org.apache.axis2.transport.http.AxisServlet.destroy(AxisServlet.java:114) > at > org.apache.catalina.core.StandardWrapper.unload(StandardWrapper.java:1326) > at > org.apache.catalina.core.StandardWrapper.stop(StandardWrapper.java:1654) > at > org.apache.catalina.core.StandardContext.stop(StandardContext.java:4345) > at > org.apache.catalina.manager.ManagerServlet.stop(ManagerServlet.java:1226) > at > org.apache.catalina.manager.HTMLManagerServlet.stop(HTMLManagerServlet.java:545) > at > org.apache.catalina.manager.HTMLManagerServlet.doGet(HTMLManagerServlet.java:106) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:689) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:802) > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252) > at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) > at > org.netbeans.modules
[Axis2] Issues with the current code base
Hi all; I just went though the current code base and realized that MessageContext code has been changed a lot . I found few issues with the code base and hope we need to fix them. So I thought of sending this mail for everyone's consideration. Well someone please explain to me whose going to need MessageContext serialization , Chamikara : Do you want that for Sandesha ? Ruchith : Do you want that for Security ? If none of you want this , who else need this ? I am asking this question b'coz introduction of MC serialization we have the following for each req. - When ever Axis2 received a message it calls activateMessageContext(msgContext); - And what that does is , it calls mc.activate(engineContext); method Unfortunately that method is TOO long and was very difficult to understand :). Ann can you simplify the method (that will be very helpful) . In the meantime code convention in MC has changed a lot and need to have very consistent code convention, please do not differ form that. Among the all , the most worst thing I saw in the code is following kind of things, I strongly believe we should not have this kind of code in the code base, If you found such kind of code please point out them then and there. - String tmpClassNameStr = "null"; (is this the way we initialize to NULL ) - String tmpHasList = "no list" - Unnecessary casting - A number of unused variables - Variable declarations here and there (as an example private static final String - selfManagedDataDelimiter = "*";) In addition to that someone has added code to change OutInAxisOperation name in the client side temporally, can I know why ? So please comment your ideas on this. Thanks Deepal - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (AXIS2-1959) Mistake in ../axis2/java/xdocs/faq.html#d4 (Axis2 Documentation)
[ https://issues.apache.org/jira/browse/AXIS2-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chatra Nakkawita resolved AXIS2-1959. - Resolution: Fixed Made correction. Thanks, Chatra > Mistake in ../axis2/java/xdocs/faq.html#d4 (Axis2 Documentation) > - > > Key: AXIS2-1959 > URL: https://issues.apache.org/jira/browse/AXIS2-1959 > Project: Axis 2.0 (Axis2) > Issue Type: Bug > Components: documentation >Reporter: Sameera Madushan Jayasoma > Assigned To: Chatra Nakkawita >Priority: Minor > Fix For: nightly > > Attachments: patch.txt > > > In the 4th queston of faq ( ../axis2/java/xdocs/faq.html#d4) following > correction is need to be done. > maven dist-std-binWill generate the binary version of Axis2 standard > distribution > - maven dist-std-bin Will generate the source version of Axis2 standard > distribution > maven dist-std-binWill generate the binary version of Axis2 standard > distribution > + maven dist-std-src Will generate the source version of Axis2 standard > distribution > patch is attached > > Sameera -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (AXIS2-2036) Made minor changes to the files in xdocs.
[ https://issues.apache.org/jira/browse/AXIS2-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chatra Nakkawita resolved AXIS2-2036. - Resolution: Fixed Reviewed and committed. Thanks loads, Chatra > Made minor changes to the files in xdocs. > - > > Key: AXIS2-2036 > URL: https://issues.apache.org/jira/browse/AXIS2-2036 > Project: Axis 2.0 (Axis2) > Issue Type: Improvement > Components: documentation >Affects Versions: 1.1.1 > Environment: Windows XP >Reporter: Marietta Lovendhal >Priority: Minor > Fix For: 1.2, nightly > > Attachments: axis2-xdocs.patch > > > Made minor corrections in the following files: maven-help, svn, siteHowTo, > reflib, guidelines, articles, download -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Axis2]Question for Deepal regarding changes to ConfigurationContext under SVN revision 500187
Hi Jeff ; I do not think that we need to do that . In the meantime if we can do that that will be great as well , then we can minimize the number of issues users are getting when they trying to create a ConfigurationContext. Thanks Deepal >Howdy Deepal, > >Since you took out the initalization of the instance variables in >ConfigurationContext and moved it to the ConfigurationContextFactory, >shouldn't the ConfigurationContext constructor change be package protected >instead of public to force the use of the factory, and thus get those >instance variables initialized? > >Thanks, >Jeff > >IBM Software Group - WebSphere Web Services Development >Phone: 512-838-4587 or Tie Line 678-4587 >Internet e-mail and Sametime ID: [EMAIL PROTECTED] > >- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] > > > > > -- Thanks, Deepal "The highest tower is built one brick at a time" - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (AXIS2-2048) RequestWrapper annotation reading incorrect default
[ https://issues.apache.org/jira/browse/AXIS2-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Thaker closed AXIS2-2048. > RequestWrapper annotation reading incorrect default > --- > > Key: AXIS2-2048 > URL: https://issues.apache.org/jira/browse/AXIS2-2048 > Project: Axis 2.0 (Axis2) > Issue Type: Bug > Components: jaxws >Reporter: Nikhil Thaker > Assigned To: Nikhil Thaker > Attachments: JIRA_2048_RequestWrapperDefault.txt > > > RequestWrapper annotation is reading EndpointImpl as the default class this > is incorrect causing an unmarshalling Exception in JAXB. I am submitting the > patch that will correct the default to seiMethod converted to java Class > clas RequestWrapper default. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (AXIS2-2048) RequestWrapper annotation reading incorrect default
[ https://issues.apache.org/jira/browse/AXIS2-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Thaker resolved AXIS2-2048. -- Resolution: Fixed Revision 500866 > RequestWrapper annotation reading incorrect default > --- > > Key: AXIS2-2048 > URL: https://issues.apache.org/jira/browse/AXIS2-2048 > Project: Axis 2.0 (Axis2) > Issue Type: Bug > Components: jaxws >Reporter: Nikhil Thaker > Assigned To: Nikhil Thaker > Attachments: JIRA_2048_RequestWrapperDefault.txt > > > RequestWrapper annotation is reading EndpointImpl as the default class this > is incorrect causing an unmarshalling Exception in JAXB. I am submitting the > patch that will correct the default to seiMethod converted to java Class > clas RequestWrapper default. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (AXIS2-2048) RequestWrapper annotation reading incorrect default
[ https://issues.apache.org/jira/browse/AXIS2-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Thaker updated AXIS2-2048: - Attachment: JIRA_2048_RequestWrapperDefault.txt > RequestWrapper annotation reading incorrect default > --- > > Key: AXIS2-2048 > URL: https://issues.apache.org/jira/browse/AXIS2-2048 > Project: Axis 2.0 (Axis2) > Issue Type: Bug > Components: jaxws >Reporter: Nikhil Thaker > Assigned To: Nikhil Thaker > Attachments: JIRA_2048_RequestWrapperDefault.txt > > > RequestWrapper annotation is reading EndpointImpl as the default class this > is incorrect causing an unmarshalling Exception in JAXB. I am submitting the > patch that will correct the default to seiMethod converted to java Class > clas RequestWrapper default. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Assigned: (AXIS2-2048) RequestWrapper annotation reading incorrect default
[ https://issues.apache.org/jira/browse/AXIS2-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Thaker reassigned AXIS2-2048: Assignee: Nikhil Thaker > RequestWrapper annotation reading incorrect default > --- > > Key: AXIS2-2048 > URL: https://issues.apache.org/jira/browse/AXIS2-2048 > Project: Axis 2.0 (Axis2) > Issue Type: Bug > Components: jaxws >Reporter: Nikhil Thaker > Assigned To: Nikhil Thaker > > RequestWrapper annotation is reading EndpointImpl as the default class this > is incorrect causing an unmarshalling Exception in JAXB. I am submitting the > patch that will correct the default to seiMethod converted to java Class > clas RequestWrapper default. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (AXIS2-2048) RequestWrapper annotation reading incorrect default
RequestWrapper annotation reading incorrect default --- Key: AXIS2-2048 URL: https://issues.apache.org/jira/browse/AXIS2-2048 Project: Axis 2.0 (Axis2) Issue Type: Bug Components: jaxws Reporter: Nikhil Thaker RequestWrapper annotation is reading EndpointImpl as the default class this is incorrect causing an unmarshalling Exception in JAXB. I am submitting the patch that will correct the default to seiMethod converted to java Class clas RequestWrapper default. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
