Re: [Babel-users] [babel] Babel MAC auth fails due to packet reordering
Hi Juliusz, On Sat, Jul 23, 2022 at 09:44:58PM +0200, Juliusz Chroboczek wrote: > > > > While this is not fatal for the reordering fix per-se your RTT patch also > > breaks because of this AFAICT. Since the IHU tstamps only ever arrive via > > unicast. At least with my `unicast true` babeld config. > > More exactly, with "unicast true" babeld will send a IHUs over unicast, > which will in turn force it to include an unscheduled unicast hello. You > should be able to work around the issue by setting > > rfc6126-compatible true > > in babeld. However, this has other consequences, such as breaking > source-specific routing. Ah I see. That could be an option I suppose, since I don't need SSR. > > Nothing bad seems to happen if I just comment this out :) Do you have have > > any pointers as to what needs to be impl-emented in bird to properly support > > unicast hellos? > > You don't need full support for unicast hellos, you just need to parse the > sub-TLVs of unicast hellos in order to extract the timestamp. I'm literally testig a patch that does just that now, sounds like I'm on the right track then. Thanks! --Daniel ___ Babel-users mailing list Babel-users@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/babel-users
Re: [Babel-users] [babel] Babel MAC auth fails due to packet reordering
> > While this is not fatal for the reordering fix per-se your RTT patch also > breaks because of this AFAICT. Since the IHU tstamps only ever arrive via > unicast. At least with my `unicast true` babeld config. More exactly, with "unicast true" babeld will send a IHUs over unicast, which will in turn force it to include an unscheduled unicast hello. You should be able to work around the issue by setting rfc6126-compatible true in babeld. However, this has other consequences, such as breaking source-specific routing. > Nothing bad seems to happen if I just comment this out :) Do you have have > any pointers as to what needs to be impl-emented in bird to properly support > unicast hellos? You don't need full support for unicast hellos, you just need to parse the sub-TLVs of unicast hellos in order to extract the timestamp. -- Juliusz ___ Babel-users mailing list Babel-users@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/babel-users
Re: [Babel-users] [babel] Babel MAC auth fails due to packet reordering
Hi Toke, I've spent some time today trying to debug the weird behaviour with your ooo-pc bird patch. I found the bird code ignores unicast hellos entirely which I wasn't expecting :) babel_read_hello: /* We currently don't support unicast Hello */ u16 flags = get_u16(&tlv->flags); if (flags & BABEL_HF_UNICAST) return PARSE_IGNORE; Nothing bad seems to happen if I just comment this out :) Do you have have any pointers as to what needs to be implemented in bird to properly support unicast hellos? While this is not fatal for the reordering fix per-se your RTT patch also breaks because of this AFAICT. Since the IHU tstamps only ever arrive via unicast. At least with my `unicast true` babeld config. --Daniel ___ Babel-users mailing list Babel-users@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/babel-users
