Re: [PATCH 01/11] b43: N-PHY: add some registers and structs definitions
On Sunday 28 February 2010 02:37:21 Rafał Miłecki wrote: W dniu 27 lutego 2010 15:51 użytkownik Michael Buesch m...@bu3sch.de napisał: On Saturday 27 February 2010 12:12:23 Rafał Miłecki wrote: 2010/2/10 Michael Buesch m...@bu3sch.de: On Tuesday 09 February 2010 21:04:33 Rafał Miłecki wrote: +#define B43_MMIO_PSM_PHY_HDR 0x492 /* programmable state machine */ The comment doesn't make a lot of sense. In case you don't know, the PSM is the part of the hardware that executes the firmware. Well, guess you're right. It was me hearing for the first time PSM so decided to write it. Guess it's pretty obvious for every device driver developer :) Well, what I wanted to say is that it's more important to explain what PHY_HDR means. Something like /* PSM PHY header */ ? Sure, explaining HDR sounds great, but do you actually know it's header? Personally I have no idea, so I am not sure if you know that with nice probability of being right, or are you just guessing? :) Well, I assumed you could deduce the meaning from the code. If not, it's better to leave it without a comment. I don't know for sure what this means. But declaring the definition as Programmable State Machine is also wrong. So let's simply leave it without a comment. -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH 01/11] b43: N-PHY: add some registers and structs definitions
2010/2/10 Michael Buesch m...@bu3sch.de: On Tuesday 09 February 2010 21:04:33 Rafał Miłecki wrote: +#define B43_MMIO_PSM_PHY_HDR 0x492 /* programmable state machine */ The comment doesn't make a lot of sense. In case you don't know, the PSM is the part of the hardware that executes the firmware. Well, guess you're right. It was me hearing for the first time PSM so decided to write it. Guess it's pretty obvious for every device driver developer :) -- Rafał ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH 01/11] b43: N-PHY: add some registers and structs definitions
On Saturday 27 February 2010 12:12:23 Rafał Miłecki wrote: 2010/2/10 Michael Buesch m...@bu3sch.de: On Tuesday 09 February 2010 21:04:33 Rafał Miłecki wrote: +#define B43_MMIO_PSM_PHY_HDR 0x492 /* programmable state machine */ The comment doesn't make a lot of sense. In case you don't know, the PSM is the part of the hardware that executes the firmware. Well, guess you're right. It was me hearing for the first time PSM so decided to write it. Guess it's pretty obvious for every device driver developer :) Well, what I wanted to say is that it's more important to explain what PHY_HDR means. Something like /* PSM PHY header */ ? -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH 01/11] b43: N-PHY: add some registers and structs definitions
2010/2/15 John W. Linville linvi...@tuxdriver.com: On Wed, Feb 10, 2010 at 12:02:11AM +0100, Michael Buesch wrote: On Tuesday 09 February 2010 21:04:33 Rafał Miłecki wrote: +#define B43_MMIO_PSM_PHY_HDR 0x492 /* programmable state machine */ The comment doesn't make a lot of sense. In case you don't know, the PSM is the part of the hardware that executes the firmware. Rafał, Are you going to repost this series and/or respond to Michael's comments? I tried to apply some of the ones Michael didn't comment upon, but they seem to depend on the ones in question. I got some exams recently and today I got one more for recrucation for new studies level. Will fix patches this week. -- Rafał ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH 01/11] b43: N-PHY: add some registers and structs definitions
On Wed, Feb 10, 2010 at 12:02:11AM +0100, Michael Buesch wrote: On Tuesday 09 February 2010 21:04:33 Rafał Miłecki wrote: +#define B43_MMIO_PSM_PHY_HDR 0x492 /* programmable state machine */ The comment doesn't make a lot of sense. In case you don't know, the PSM is the part of the hardware that executes the firmware. Rafał, Are you going to repost this series and/or respond to Michael's comments? I tried to apply some of the ones Michael didn't comment upon, but they seem to depend on the ones in question. Thanks, John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
[PATCH 01/11] b43: N-PHY: add some registers and structs definitions
Signed-off-by: Rafał Miłecki zaj...@gmail.com
---
drivers/net/wireless/b43/b43.h |1 +
drivers/net/wireless/b43/phy_n.h |9 +
drivers/net/wireless/b43/tables_nphy.h |9 +
3 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/b43/b43.h b/drivers/net/wireless/b43/b43.h
index 6a6ab0f..bd7c505 100644
--- a/drivers/net/wireless/b43/b43.h
+++ b/drivers/net/wireless/b43/b43.h
@@ -104,6 +104,7 @@
#define B43_MMIO_MACFILTER_CONTROL 0x420
#define B43_MMIO_MACFILTER_DATA0x422
#define B43_MMIO_RCMTA_COUNT 0x43C
+#define B43_MMIO_PSM_PHY_HDR 0x492 /* programmable state machine */
#define B43_MMIO_RADIO_HWENABLED_LO0x49A
#define B43_MMIO_GPIO_CONTROL 0x49C
#define B43_MMIO_GPIO_MASK 0x49E
diff --git a/drivers/net/wireless/b43/phy_n.h b/drivers/net/wireless/b43/phy_n.h
index 403aad3..47d20dc 100644
--- a/drivers/net/wireless/b43/phy_n.h
+++ b/drivers/net/wireless/b43/phy_n.h
@@ -711,6 +711,8 @@
#define B43_NPHY_PAPD_EN1 B43_PHY_N(0x29B) /* PAPD
Enable1 TBD */
#define B43_NPHY_EPS_TABLE_ADJ1B43_PHY_N(0x29C) /* EPS
Table Adj1 TBD */
+#define B43_PHY_B_BBCFGB43_PHY_N_BMODE(0x001)
/* BB config */
+#define B43_PHY_B_TEST B43_PHY_N_BMODE(0x00A)
/* Broadcom 2055 radio registers */
@@ -924,6 +926,13 @@
struct b43_wldev;
+struct b43_chanspec {
+ u8 channel;
+ u8 sideband;
+ u8 b_width;
+ u8 b_freq;
+};
+
struct b43_phy_n_iq_comp {
s16 a0;
s16 b0;
diff --git a/drivers/net/wireless/b43/tables_nphy.h
b/drivers/net/wireless/b43/tables_nphy.h
index 9c1c6ec..b23036f 100644
--- a/drivers/net/wireless/b43/tables_nphy.h
+++ b/drivers/net/wireless/b43/tables_nphy.h
@@ -4,6 +4,15 @@
#include linux/types.h
+struct b43_phy_n_sfo_cfg {
+ u16 phy_bw1a;
+ u16 phy_bw2;
+ u16 phy_bw3;
+ u16 phy_bw4;
+ u16 phy_bw5;
+ u16 phy_bw6;
+};
+
struct b43_nphy_channeltab_entry {
/* The channel number */
u8 channel;
--
1.6.4.2
___
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
Re: [PATCH 01/11] b43: N-PHY: add some registers and structs definitions
On Tuesday 09 February 2010 21:04:33 Rafał Miłecki wrote: +#define B43_MMIO_PSM_PHY_HDR 0x492 /* programmable state machine */ The comment doesn't make a lot of sense. In case you don't know, the PSM is the part of the hardware that executes the firmware. -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
