Re: [Beignet] Haswell issues
After revert the beignet's atomic in l3 patch [9e8874c ?], the i915.enable_ppgtt=2 should work for HSW platform. If it's that easy to really fix this, I agree we should do so; I'd taken the absence of anything other than patch the kernel in the documentation to mean that no other fix was known. Daniel already submitted a patchset to address part of this issue. http://lists.freedesktop.org/archives/intel-gfx/2015-April/064635.html ? could you help to identify the first kernel version which this enable_ppgtt=2 works for beignet? Looks like https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=78a423772d08eb5a048765a883b5b5a308ea0d0f but I don't have the hardware to try it. ___ Beignet mailing list Beignet@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/beignet
Re: [Beignet] Haswell issues
-Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Rebecca N. Palmer Sent: Wednesday, April 29, 2015 8:13 PM To: beignet@lists.freedesktop.org Subject: Re: [Beignet] Haswell issues After revert the beignet's atomic in l3 patch [9e8874c ?], the i915.enable_ppgtt=2 should work for HSW platform. If it's that easy to really fix this, I agree we should do so; I'd taken the absence of anything other than patch the kernel in the documentation to mean that no other fix was known. Ok, then I will revert that patch soon. Daniel already submitted a patchset to address part of this issue. http://lists.freedesktop.org/archives/intel-gfx/2015-April/064635.html ? Exactly. could you help to identify the first kernel version which this enable_ppgtt=2 works for beignet? Looks like https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=78a4 23772d08eb5a048765a883b5b5a308ea0d0f but I don't have the hardware to try it. We will do some testing on this. And once we get the exact version, I will submit a new patch to give some warn if the user is using an unsupported kernel. As now we have better solution than patch kernel manually, I will change the document to suggest user to upgrade to a supported kernel rather than patch kernel manually. Thanks, Zhigang Gong. ___ Beignet mailing list Beignet@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/beignet ___ Beignet mailing list Beignet@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/beignet
Re: [Beignet] Haswell issues
Andi, Thanks for your comments and that makes sense for me, just check kernel version is not an ideal method for those unofficial kernels with back porting patches. Then we have the following open questions in my mind: How do we check whether the i915 KMD support secure batch buffer execution if the batch buffer pass the cmd parser check under full-ppgtt mode in UMD? How do we check whether the i915 KMD support secure batch buffer execution with aliasing ppgtt after the merging of the patch drm/i915: Arm cmd parser with aliasing ppgtt only in UMD? CC to Daniel, do you have any suggestion here? Thanks, Zhigang Gong. -Original Message- From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of Andi Kleen Sent: Thursday, April 30, 2015 12:19 PM To: beignet@lists.freedesktop.org Cc: zhigang.g...@linux.intel.com Subject: Re: [Beignet] Haswell issues Zhigang Gong zhigang.g...@linux.intel.com writes: but I don't have the hardware to try it. We will do some testing on this. And once we get the exact version, I will submit a new patch to give some warn if the user is using an unsupported kernel. As now we have better solution than patch kernel manually, I will change the document to suggest user to upgrade to a supported kernel rather than patch kernel manually. It would be better to add something to the kernel interface that can be probed without relying on the kernel version. The problem with checking versions is that it'll break if someone backports the fixes to older kernels, which is not uncommon. -Andi -- a...@linux.intel.com -- Speaking for myself only ___ Beignet mailing list Beignet@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/beignet ___ Beignet mailing list Beignet@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/beignet
Re: [Beignet] Haswell issues
Zhigang Gong zhigang.g...@linux.intel.com writes: but I don't have the hardware to try it. We will do some testing on this. And once we get the exact version, I will submit a new patch to give some warn if the user is using an unsupported kernel. As now we have better solution than patch kernel manually, I will change the document to suggest user to upgrade to a supported kernel rather than patch kernel manually. It would be better to add something to the kernel interface that can be probed without relying on the kernel version. The problem with checking versions is that it'll break if someone backports the fixes to older kernels, which is not uncommon. -Andi -- a...@linux.intel.com -- Speaking for myself only ___ Beignet mailing list Beignet@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/beignet
Re: [Beignet] Haswell issues
I will raise this issue to Linux i915 kernel team. And hope we can get a clean fix in Linux kernel side finally. I agree that's a good idea, but given how long it is likely to take, I'd like to at least give a clear user-friendly error in the meantime. -Is it likely that drm_intel_gem_bo_context_exec() failed: Invalid argument (since 9e8874c) affects _all_ Haswell hardware? If so, I'd consider this an improvement over the previous some work (as long as you don't use __local), some silently do nothing, and put the i915_cmd_parser workaround in the error message. -What happens when you do try to use __local (without https://01.org/zh/beignet/downloads/linux-kernel-patch-hsw-support): an explicit error, or wrong results? -It was suggested some time ago that i915.enable_ppgtt=2 might help; does it? (This kernel parameter can only be set at boot time, and is an unsafe parameter i.e. may crash your system, but would be easier than recompiling Linux.) ___ Beignet mailing list Beignet@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/beignet
