[Bf-committers] Swiss Cheese Text Editor Refactor/Merge
During the last GSoC I made some modifications to the text editor so that it would batch text before drawing it instead of drawing on character at a time. (Since I was removing immediate mode calls from swiss-cheese, sending one character at a time as WAY too much overhead.) The recent changes to the text editor have been a bit of a nightmare to merge. The code is complicated and fragile (both mine and the original). I wanted to touch base and see if it would be OK to see about going ahead and integrating swiss-cheese's more efficient text rendering into trunk. Perhaps I could also refactor some of the code to be a little bit more maintainable as well. The reason I'm asking is I'm not sure if somebody else might have plans for this area, so I don't want to just continue as I am (merging complex changes) if it just going to be blown away. ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Swiss Cheese Text Editor Refactor/Merge
Would this also include the more efficient BLF rendering? I'm guessing the text editor changes are dependent on that? I'd really love to see BLF getting away from glBegin/glEnd. On Tue, Apr 2, 2013 at 1:28 PM, Jason Wilkins wrote: > During the last GSoC I made some modifications to the text editor so that > it would batch text before drawing it instead of drawing on character at a > time. (Since I was removing immediate mode calls from swiss-cheese, > sending one character at a time as WAY too much overhead.) > > The recent changes to the text editor have been a bit of a nightmare to > merge. The code is complicated and fragile (both mine and the original). > > I wanted to touch base and see if it would be OK to see about going ahead > and integrating swiss-cheese's more efficient text rendering into trunk. > Perhaps I could also refactor some of the code to be a little bit more > maintainable as well. > > The reason I'm asking is I'm not sure if somebody else might have plans for > this area, so I don't want to just continue as I am (merging complex > changes) if it just going to be blown away. > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Swiss Cheese Text Editor Refactor/Merge
The drawing would be more efficient regardless of the underlying BLF rendering due to the batching. The text editor changes aren't really dependent on the other changes. My problem is that the text editor (text_draw.c) is starting to diverge in inconvenient ways. On Tue, Apr 2, 2013 at 9:11 PM, Mitchell Stokes wrote: > Would this also include the more efficient BLF rendering? I'm guessing the > text editor changes are dependent on that? I'd really love to see BLF > getting away from glBegin/glEnd. > > > On Tue, Apr 2, 2013 at 1:28 PM, Jason Wilkins >wrote: > > > During the last GSoC I made some modifications to the text editor so that > > it would batch text before drawing it instead of drawing on character at > a > > time. (Since I was removing immediate mode calls from swiss-cheese, > > sending one character at a time as WAY too much overhead.) > > > > The recent changes to the text editor have been a bit of a nightmare to > > merge. The code is complicated and fragile (both mine and the original). > > > > I wanted to touch base and see if it would be OK to see about going ahead > > and integrating swiss-cheese's more efficient text rendering into trunk. > > Perhaps I could also refactor some of the code to be a little bit more > > maintainable as well. > > > > The reason I'm asking is I'm not sure if somebody else might have plans > for > > this area, so I don't want to just continue as I am (merging complex > > changes) if it just going to be blown away. > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > http://lists.blender.org/mailman/listinfo/bf-committers > > > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Swiss Cheese Text Editor Refactor/Merge
Would it work with multicolumn characters which were recently added by http://projects.blender.org/tracker/index.php?func=detail&aid=34373&group_id=9&atid=127? On Wed, Apr 3, 2013 at 11:34 AM, Jason Wilkins wrote: > The drawing would be more efficient regardless of the underlying BLF > rendering due to the batching. The text editor changes aren't really > dependent on the other changes. > > My problem is that the text editor (text_draw.c) is starting to diverge > in inconvenient ways. > > > On Tue, Apr 2, 2013 at 9:11 PM, Mitchell Stokes > wrote: > > > Would this also include the more efficient BLF rendering? I'm guessing > the > > text editor changes are dependent on that? I'd really love to see BLF > > getting away from glBegin/glEnd. > > > > > > On Tue, Apr 2, 2013 at 1:28 PM, Jason Wilkins > >wrote: > > > > > During the last GSoC I made some modifications to the text editor so > that > > > it would batch text before drawing it instead of drawing on character > at > > a > > > time. (Since I was removing immediate mode calls from swiss-cheese, > > > sending one character at a time as WAY too much overhead.) > > > > > > The recent changes to the text editor have been a bit of a nightmare to > > > merge. The code is complicated and fragile (both mine and the > original). > > > > > > I wanted to touch base and see if it would be OK to see about going > ahead > > > and integrating swiss-cheese's more efficient text rendering into > trunk. > > > Perhaps I could also refactor some of the code to be a little bit more > > > maintainable as well. > > > > > > The reason I'm asking is I'm not sure if somebody else might have plans > > for > > > this area, so I don't want to just continue as I am (merging complex > > > changes) if it just going to be blown away. > > > ___ > > > Bf-committers mailing list > > > Bf-committers@blender.org > > > http://lists.blender.org/mailman/listinfo/bf-committers > > > > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > http://lists.blender.org/mailman/listinfo/bf-committers > > > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Swiss Cheese Text Editor Refactor/Merge
After digging into this problem a bit I got frustrated. The new blf_font_draw_mono code determines how much wide text is while drawing it, which isn't really compatible with batching up as much text as possible before drawing it. I guess I won't be able to sort this out in 45 minutes like I'd hoped. On Tue, Apr 2, 2013 at 3:28 PM, Jason Wilkins wrote: > During the last GSoC I made some modifications to the text editor so that > it would batch text before drawing it instead of drawing on character at a > time. (Since I was removing immediate mode calls from swiss-cheese, > sending one character at a time as WAY too much overhead.) > > The recent changes to the text editor have been a bit of a nightmare to > merge. The code is complicated and fragile (both mine and the original). > > I wanted to touch base and see if it would be OK to see about going ahead > and integrating swiss-cheese's more efficient text rendering into trunk. > Perhaps I could also refactor some of the code to be a little bit more > maintainable as well. > > The reason I'm asking is I'm not sure if somebody else might have plans > for this area, so I don't want to just continue as I am (merging complex > changes) if it just going to be blown away. > > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Swiss Cheese Text Editor Refactor/Merge
This is what I'm talking about. The multicolumn character feature modifies code that has a basic design flaw. I've fixed that flaw already, but it isn't in trunk. I'm trying to puzzle out how to fix it again, but I need to make sure I'm not stomping on any toes. On Wed, Apr 3, 2013 at 2:58 AM, Lockal S wrote: > Would it work with multicolumn characters which were recently added by > > http://projects.blender.org/tracker/index.php?func=detail&aid=34373&group_id=9&atid=127 > ? > > > On Wed, Apr 3, 2013 at 11:34 AM, Jason Wilkins >wrote: > > > The drawing would be more efficient regardless of the underlying BLF > > rendering due to the batching. The text editor changes aren't really > > dependent on the other changes. > > > > My problem is that the text editor (text_draw.c) is starting to diverge > > in inconvenient ways. > > > > > > On Tue, Apr 2, 2013 at 9:11 PM, Mitchell Stokes > > wrote: > > > > > Would this also include the more efficient BLF rendering? I'm guessing > > the > > > text editor changes are dependent on that? I'd really love to see BLF > > > getting away from glBegin/glEnd. > > > > > > > > > On Tue, Apr 2, 2013 at 1:28 PM, Jason Wilkins < > jason.a.wilk...@gmail.com > > > >wrote: > > > > > > > During the last GSoC I made some modifications to the text editor so > > that > > > > it would batch text before drawing it instead of drawing on character > > at > > > a > > > > time. (Since I was removing immediate mode calls from swiss-cheese, > > > > sending one character at a time as WAY too much overhead.) > > > > > > > > The recent changes to the text editor have been a bit of a nightmare > to > > > > merge. The code is complicated and fragile (both mine and the > > original). > > > > > > > > I wanted to touch base and see if it would be OK to see about going > > ahead > > > > and integrating swiss-cheese's more efficient text rendering into > > trunk. > > > > Perhaps I could also refactor some of the code to be a little bit > more > > > > maintainable as well. > > > > > > > > The reason I'm asking is I'm not sure if somebody else might have > plans > > > for > > > > this area, so I don't want to just continue as I am (merging complex > > > > changes) if it just going to be blown away. > > > > ___ > > > > Bf-committers mailing list > > > > Bf-committers@blender.org > > > > http://lists.blender.org/mailman/listinfo/bf-committers > > > > > > > ___ > > > Bf-committers mailing list > > > Bf-committers@blender.org > > > http://lists.blender.org/mailman/listinfo/bf-committers > > > > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > http://lists.blender.org/mailman/listinfo/bf-committers > > > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Swiss Cheese Text Editor Refactor/Merge
Hi Jason, The multi-column character support is what I've implemented. If your change breaks something, I maybe can help you to fix it. Anyway, I'm not planning to change the text editor drastically in the near future. IRIE Shinsuke 13/04/03, Jason Wilkins wrote: > This is what I'm talking about. The multicolumn character feature modifies > code that has a basic design flaw. I've fixed that flaw already, but it > isn't in trunk. I'm trying to puzzle out how to fix it again, but I need > to make sure I'm not stomping on any toes. > > > On Wed, Apr 3, 2013 at 2:58 AM, Lockal S wrote: > >> Would it work with multicolumn characters which were recently added by >> >> http://projects.blender.org/tracker/index.php?func=detail&aid=34373&group_id=9&atid=127 >> ? >> >> >> On Wed, Apr 3, 2013 at 11:34 AM, Jason Wilkins >> wrote: >> >>> The drawing would be more efficient regardless of the underlying BLF >>> rendering due to the batching. The text editor changes aren't really >>> dependent on the other changes. >>> >>> My problem is that the text editor (text_draw.c) is starting to diverge >>> in inconvenient ways. >>> >>> >>> On Tue, Apr 2, 2013 at 9:11 PM, Mitchell Stokes >>> wrote: >>> Would this also include the more efficient BLF rendering? I'm guessing >>> the text editor changes are dependent on that? I'd really love to see BLF getting away from glBegin/glEnd. On Tue, Apr 2, 2013 at 1:28 PM, Jason Wilkins < >> jason.a.wilk...@gmail.com > wrote: > During the last GSoC I made some modifications to the text editor so >>> that > it would batch text before drawing it instead of drawing on character >>> at a > time. (Since I was removing immediate mode calls from swiss-cheese, > sending one character at a time as WAY too much overhead.) > > The recent changes to the text editor have been a bit of a nightmare >> to > merge. The code is complicated and fragile (both mine and the >>> original). > > I wanted to touch base and see if it would be OK to see about going >>> ahead > and integrating swiss-cheese's more efficient text rendering into >>> trunk. > Perhaps I could also refactor some of the code to be a little bit >> more > maintainable as well. > > The reason I'm asking is I'm not sure if somebody else might have >> plans for > this area, so I don't want to just continue as I am (merging complex > changes) if it just going to be blown away. > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers >>> ___ >>> Bf-committers mailing list >>> Bf-committers@blender.org >>> http://lists.blender.org/mailman/listinfo/bf-committers >>> >> ___ >> Bf-committers mailing list >> Bf-committers@blender.org >> http://lists.blender.org/mailman/listinfo/bf-committers >> > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Swiss Cheese Text Editor Refactor/Merge
Great. I did manage to merge the two versions after a lot of thought. However, I need to spend some time refining and testing it before I commit any changes. On Wed, Apr 3, 2013 at 8:28 AM, IRIE Shinsuke wrote: > Hi Jason, > > The multi-column character support is what I've implemented. > If your change breaks something, I maybe can help you to fix it. > > Anyway, I'm not planning to change the text editor drastically in the > near future. > > IRIE Shinsuke > > 13/04/03, Jason Wilkins wrote: > > This is what I'm talking about. The multicolumn character feature > modifies > > code that has a basic design flaw. I've fixed that flaw already, but it > > isn't in trunk. I'm trying to puzzle out how to fix it again, but I need > > to make sure I'm not stomping on any toes. > > > > > > On Wed, Apr 3, 2013 at 2:58 AM, Lockal S wrote: > > > >> Would it work with multicolumn characters which were recently added by > >> > >> > http://projects.blender.org/tracker/index.php?func=detail&aid=34373&group_id=9&atid=127 > >> ? > >> > >> > >> On Wed, Apr 3, 2013 at 11:34 AM, Jason Wilkins < > jason.a.wilk...@gmail.com > >>> wrote: > >> > >>> The drawing would be more efficient regardless of the underlying BLF > >>> rendering due to the batching. The text editor changes aren't really > >>> dependent on the other changes. > >>> > >>> My problem is that the text editor (text_draw.c) is starting to diverge > >>> in inconvenient ways. > >>> > >>> > >>> On Tue, Apr 2, 2013 at 9:11 PM, Mitchell Stokes > >>> wrote: > >>> > Would this also include the more efficient BLF rendering? I'm guessing > >>> the > text editor changes are dependent on that? I'd really love to see BLF > getting away from glBegin/glEnd. > > > On Tue, Apr 2, 2013 at 1:28 PM, Jason Wilkins < > >> jason.a.wilk...@gmail.com > > wrote: > > > During the last GSoC I made some modifications to the text editor so > >>> that > > it would batch text before drawing it instead of drawing on character > >>> at > a > > time. (Since I was removing immediate mode calls from swiss-cheese, > > sending one character at a time as WAY too much overhead.) > > > > The recent changes to the text editor have been a bit of a nightmare > >> to > > merge. The code is complicated and fragile (both mine and the > >>> original). > > > > I wanted to touch base and see if it would be OK to see about going > >>> ahead > > and integrating swiss-cheese's more efficient text rendering into > >>> trunk. > > Perhaps I could also refactor some of the code to be a little bit > >> more > > maintainable as well. > > > > The reason I'm asking is I'm not sure if somebody else might have > >> plans > for > > this area, so I don't want to just continue as I am (merging complex > > changes) if it just going to be blown away. > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > http://lists.blender.org/mailman/listinfo/bf-committers > > > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > > >>> ___ > >>> Bf-committers mailing list > >>> Bf-committers@blender.org > >>> http://lists.blender.org/mailman/listinfo/bf-committers > >>> > >> ___ > >> Bf-committers mailing list > >> Bf-committers@blender.org > >> http://lists.blender.org/mailman/listinfo/bf-committers > >> > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > http://lists.blender.org/mailman/listinfo/bf-committers > > > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
