[Bf-committers] Visibility of attribution
Hi all, When doing some work for a client recently, I developed a patch for Blender. The client is happy to contribute the code back to Blender, however they are concerned about attribution. Currently it seems there are no clear guidelines about how attribution is given for contributions. My preference, and that of my client, is that detailed copyright notices should be visible both in the code and in Blender's GUI. This is not unusual: consider the Linux kernel (e.g. [1]) and the GIMP (e.g. [2-4]), and the About dialog boxes of gedit[5] and Firefox[6]. Apart from giving contributors credit, detailed copyright notices in the code would better satisfy the GPL, which states in section 2.a: a) You must cause the modified files to carry prominent notices stating that you changed the files and the date of any change. I propose that: 1. All future contributions be attributed in modified source files as "Copyright ", or at the contributor's option, in another form that conveys the same information. 2. The same copyright information be collected in a place accessible from the GUI, either in the splash screen itself (perhaps in a tab) or on a web page linked to from the splash screen. What do you think? Cheers, Alex -- Alex Fraser Software Engineer The Victorian Partnership for Advanced Computing [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=kernel/cgroup.c [2] http://git.gnome.org/browse/gimp/plain/plug-ins/common/polar-coords.c [3] http://git.gnome.org/browse/gimp/tree/plug-ins/twain/twain.h [4] http://git.gnome.org/browse/gimp/tree/libgimp/gimpitemcombobox.c [5] http://www.pasteall.org/pic/13959 [6] http://www.pasteall.org/pic/13961 ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
On Mon, Jun 20, 2011 at 6:52 PM, Alex Fraser wrote: > Hi all, > > When doing some work for a client recently, I developed a patch for Blender. > The client is happy to contribute the code back to Blender, however they are > concerned about attribution. Currently attribution is in a link on the download page for each version http://www.blender.org/development/release-logs/blender-257/contributor-credits/ And in the files that are patched. LetterRip ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
Also in the release note documentation will usually mention who coded the feature of interest. Note that the release log is linked from the splash screen. (Hmm looks like I said download page previously the contributor credits are linked to from the release log, not the download page). LetterRip On Mon, Jun 20, 2011 at 7:11 PM, Tom M wrote: > On Mon, Jun 20, 2011 at 6:52 PM, Alex Fraser wrote: >> Hi all, >> >> When doing some work for a client recently, I developed a patch for Blender. >> The client is happy to contribute the code back to Blender, however they are >> concerned about attribution. > > Currently attribution is in a link on the download page for each version > > http://www.blender.org/development/release-logs/blender-257/contributor-credits/ > > And in the files that are patched. > > LetterRip > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
On Tue, Jun 21, 2011 at 12:52:32PM +1000, Alex Fraser wrote: > > I propose that: > > 1. All future contributions be attributed in modified source files as > "Copyright ", or at the contributor's option, > in another form that conveys the same information. > > 2. The same copyright information be collected in a place accessible from > the GUI, either in the splash screen itself (perhaps in a tab) or on a web > page linked to from the splash screen. I do not remember the exact circumstances, but we had a situation before where some corporation wanted an attribution notice put in the UI before they would contribute code. The answer was no. Personally, I am not sure of the value of asserting copyright over code that is GPL'ed. -- Stephen Swaney sswa...@centurytel.net ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
On Tue, Jun 21, 2011 at 3:22 AM, Stephen Swaney wrote: > On Tue, Jun 21, 2011 at 12:52:32PM +1000, Alex Fraser wrote: >> >> I propose that: >> >> 1. All future contributions be attributed in modified source files as >> "Copyright ", or at the contributor's option, >> in another form that conveys the same information. >> >> 2. The same copyright information be collected in a place accessible from >> the GUI, either in the splash screen itself (perhaps in a tab) or on a web >> page linked to from the splash screen. re 1) The contributors are free to add in their own attribution in the patch, perhaps it would help to formalize this, though the few times I've had to deal with this a line in the header assigning copyright was ok. So don't mind either way. re 2) Having a web page for this could work, but -1 for listing all contributors/copyright-assignments in the GUI. > > I do not remember the exact circumstances, but we had a situation > before where some corporation wanted an attribution notice put in the > UI before they would contribute code. The answer was no. > > Personally, I am not sure of the value of asserting copyright over code > that is GPL'ed. In practice probably not much though it does mean if we want to add some GPL exception like we did for the BGE or one day move to GPLv3, copyright holders need to agree, -- - Campbell ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
On Tue, Jun 21, 2011 at 03:39:25AM +, Campbell Barton wrote: > On Tue, Jun 21, 2011 at 3:22 AM, Stephen Swaney wrote: > > > > Personally, I am not sure of the value of asserting copyright over code > > that is GPL'ed. > > In practice probably not much though it does mean if we want to add > some GPL exception like we did for the BGE or one day move to GPLv3, > copyright holders need to agree, There is a good point. That would seem to be a deal-breaker, right there. -- Stephen Swaney sswa...@centurytel.net ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
- Original Message - > From: "Stephen Swaney" > I do not remember the exact circumstances, but we had a situation > before where some corporation wanted an attribution notice put in the > UI before they would contribute code. The answer was no. Do you remember what the objection was? Note that we aren't asking to be attributed more prominently than other contributors; just on the same page. Nor are we asking for a logo to be displayed on the web site. I think attribution in a place that users can see is a fair trade for code contribution. Attribution in the release notes is good (thanks Tom, I didn't know about that page), but that means you become invisible in the next release. - Original Message - > From: "Campbell Barton" > re 1) The contributors are free to add in their own attribution in the > patch, perhaps it would help to formalize this, though the few times > I've had to deal with this a line in the header assigning copyright > was ok. > So don't mind either way. I think it would be good to formalise this, particularly to include the date that the contributions were made. > > Personally, I am not sure of the value of asserting copyright over > > code that is GPL'ed. > > In practice probably not much though it does mean if we want to add > some GPL exception like we did for the BGE or one day move to GPLv3, > copyright holders need to agree, Yes, one thing attribution does is make it easier to track who owns what. And it really is an incentive to contribute. Cheers, Alex -- Alex Fraser Software Engineer The Victorian Partnership for Advanced Computing ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
- Original Message - > From: "Stephen Swaney" > On Tue, Jun 21, 2011 at 03:39:25AM +, Campbell Barton wrote: > > In practice probably not much though it does mean if we want to add > > some GPL exception like we did for the BGE or one day move to GPLv3, > > copyright holders need to agree, > > There is a good point. That would seem to be a deal-breaker, right > there. Copyright notices are a statement of fact. If you don't have them, the author still owns the code - you just don't know who they are. Cheers, Alex -- Alex Fraser Software Engineer The Victorian Partnership for Advanced Computing ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
:cry: I don't see my name between patch makers ;-( :cry: On 21 June 2011 05:11, Tom M wrote: > Currently attribution is in a link on the download page for each version > > http://www.blender.org/development/release-logs/blender-257/contributor-credits/ > > And in the files that are patched. > > LetterRip ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
Hi Alex, last time I remember this been brought up was for Blender 2.49. In the occasion we had some sponsored contributions and a solution was: 1) to add a name + link in the contributors page: http://wiki.blender.org/index.php/Template:Release_Notes/2.49/Contributors 2) to add credit+thank notes in the header of the source files: e.g. header of KX_Dome.cpp and KX_Dome.h read: # Contributor(s): Dalai Felinto This source uses some of the ideas and code from Paul Bourke. Developed as part of a Research and Development project for SAT - La Societe des arts technologiques. # 3) include a node with no link/logo in the wiki page of the feature: http://wiki.blender.org/index.php/Dev:Source/GameEngine/2.49/Fisheye_Dome_Camera 4) add a note in the commit log (don't remember now what it said, but probably "this feature was implemented with the partial support from ") My client was happy, Blender Foundation was happy, and me, well, I couldn't care less ;) I was happy that everyone was happy. But I guess it doesn't hurt to be acknowledged on your work. In my humble opinion this is enough credit. -- Dalai 2011/6/20 Damir Prebeg > :cry: I don't see my name between patch makers ;-( :cry: > > On 21 June 2011 05:11, Tom M wrote: > > Currently attribution is in a link on the download page for each version > > > > > http://www.blender.org/development/release-logs/blender-257/contributor-credits/ > > > > And in the files that are patched. > > > > LetterRip > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
Hi Alex, Dalai's reply is excellent, hope you can follow this for now. For Blender we really should resolve this topic now indeed; there's a strong (legal) lobby in the OS world to make projects use developer agreements, whith good clarity about copryright origins of contributions and an agreement by contributors to accept on the GPL (or other) license. Another relevant topic is to clearly define in which cases (c) goes to BF. There's sensitive development areas that can easily picked up by legal lizards to start IP or patent violation investigations. This is a reason why FSF advices to migrate rights to them. Blender has a fortunate legal base in the EU, giving it a bit more stable grounds for IP/patent attacks than in USA. A developer agreement can also cover up for future adjustments in the covered license, worded in a way developers feel confident in (like keep it gpl compliant) but with sufficient open ends to upgrade a license or give out minor but relevant exceptions for extensions via Py or plugins. I've mailed a while ago about this initiative: http://harmonyagreements.org/ Proposal: I'll check on this during the next 2 weeks in more detail, and come with a proposal for it. Will get at least feedback/ endorsement from the current project admins (brecht, campbell, matt e, martin p) on this too! We then can have the topic for public review here. -Ton- Ton Roosendaal Blender Foundation t...@blender.orgwww.blender.org Blender Institute Entrepotdok 57A 1018AD Amsterdam The Netherlands On 21 Jun, 2011, at 4:52, Alex Fraser wrote: > Hi all, > > When doing some work for a client recently, I developed a patch for > Blender. The client is happy to contribute the code back to Blender, > however they are concerned about attribution. > > Currently it seems there are no clear guidelines about how > attribution is given for contributions. My preference, and that of > my client, is that detailed copyright notices should be visible both > in the code and in Blender's GUI. This is not unusual: consider the > Linux kernel (e.g. [1]) and the GIMP (e.g. [2-4]), and the About > dialog boxes of gedit[5] and Firefox[6]. > > Apart from giving contributors credit, detailed copyright notices in > the code would better satisfy the GPL, which states in section 2.a: > >a) You must cause the modified files to carry prominent notices >stating that you changed the files and the date of any change. > > > I propose that: > > 1. All future contributions be attributed in modified source files > as "Copyright ", or at the > contributor's option, in another form that conveys the same > information. > > 2. The same copyright information be collected in a place accessible > from the GUI, either in the splash screen itself (perhaps in a tab) > or on a web page linked to from the splash screen. > > What do you think? > > Cheers, > Alex > > -- > Alex Fraser > Software Engineer > The Victorian Partnership for Advanced Computing > > [1] > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=kernel/cgroup.c > [2] http://git.gnome.org/browse/gimp/plain/plug-ins/common/polar-coords.c > [3] http://git.gnome.org/browse/gimp/tree/plug-ins/twain/twain.h > [4] http://git.gnome.org/browse/gimp/tree/libgimp/gimpitemcombobox.c > [5] http://www.pasteall.org/pic/13959 > [6] http://www.pasteall.org/pic/13961 > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
Hi Ton, - Original Message - > From: "Ton Roosendaal" > Dalai's reply is excellent, hope you can follow this for now. > > For Blender we really should resolve this topic now indeed; there's a > strong (legal) lobby in the OS world to make projects use developer > agreements, whith good clarity about copryright origins of > contributions and an agreement by contributors to accept on the GPL > (or other) license. Dalai's reply is great. However if you think the contributor agreement will be drawn up soon, I would rather wait for that. I would feel more comfortable if there was a formal agreement in place. > Another relevant topic is to clearly define in which cases (c) goes to > BF. There's sensitive development areas that can easily picked up by > legal lizards to start IP or patent violation investigations. This is > a reason why FSF advices to migrate rights to them. Blender has a > fortunate legal base in the EU, giving it a bit more stable grounds > for IP/patent attacks than in USA. My personal opinion is that a requirement for copyright assignment would hinder contributions. But maybe it can be decided on a case-by-case basis. > [...] > Proposal: I'll check on this during the next 2 weeks in more detail, > and come with a proposal for it. Will get at least feedback/ > endorsement from the current project admins (brecht, campbell, matt e, > martin p) on this too! We then can have the topic for public review > here. That sounds good! Please consider my proposals (below) for the format and location of the attribution. Cheers, Alex -- Alex Fraser Software Engineer The Victorian Partnership for Advanced Computing > On 21 Jun, 2011, at 4:52, Alex Fraser wrote: > > > [...] > > I propose that: > > > > 1. All future contributions be attributed in modified source files > > as "Copyright ", or at the > > contributor's option, in another form that conveys the same > > information. > > > > 2. The same copyright information be collected in a place accessible > > from the GUI, either in the splash screen itself (perhaps in a tab) > > or on a web page linked to from the splash screen. ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
Hi all, - Original Message - > From: "Ton Roosendaal" > Subject: Re: [Bf-committers] Guidelines for developer logs, docs & blogs > Hi, > > Our bug tracker should facilitate that better I guess... I've seen the > Linux patch system to add a disclaimer (you hereby confirm the code is > yours or OK to submit) and a license/copyright note. It's great that there has been progress on the contributor agreements. I like the idea of the simple disclaimer. Please forgive me for bringing up the topic of attribution again. I would like to add a "Credits" link to the splash screen, like this: http://www.pasteall.org/pic/17174 It would link to a page like this one: http://wiki.blender.org/index.php/Dev:Ref/Release_Notes/Source_code/Contributors which would list all contributors for the life of the project. This is different to the current "Release Log" link, because 1. Credits won't become invisible after the next release. 2. It's much easier to find the credits page. For now it might be easiest to add all the 2.5x credits pages to the page mentioned above. But as suggested by Campbell, we could move to a more scalable format that shows each developer and the number of commits they have made, like this: http://www.libreoffice.org/about-us/credits/ Even though many patches are committed by a developer on behalf of someone else, it might be possible to get most of the information by processing the SVN log. What do you think? Cheers, Alex > On 21 Jun, 2011, at 4:52, Alex Fraser wrote: > > > Hi all, > > > > When doing some work for a client recently, I developed a patch for > > Blender. The client is happy to contribute the code back to Blender, > > however they are concerned about attribution. > > > > Currently it seems there are no clear guidelines about how > > attribution is given for contributions. My preference, and that of > > my client, is that detailed copyright notices should be visible both > > in the code and in Blender's GUI. This is not unusual: consider the > > Linux kernel (e.g. [1]) and the GIMP (e.g. [2-4]), and the About > > dialog boxes of gedit[5] and Firefox[6]. > > > > Apart from giving contributors credit, detailed copyright notices in > > the code would better satisfy the GPL, which states in section 2.a: > > > >a) You must cause the modified files to carry prominent notices > >stating that you changed the files and the date of any change. > > > > > > I propose that: > > > > 1. All future contributions be attributed in modified source files > > as "Copyright ", or at the > > contributor's option, in another form that conveys the same > > information. > > > > 2. The same copyright information be collected in a place accessible > > from the GUI, either in the splash screen itself (perhaps in a tab) > > or on a web page linked to from the splash screen. > > > > What do you think? > > > > Cheers, > > Alex > > > > -- > > Alex Fraser > > Software Engineer > > The Victorian Partnership for Advanced Computing > > > > [1] > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=kernel/cgroup.c > > [2] > > http://git.gnome.org/browse/gimp/plain/plug-ins/common/polar-coords.c > > [3] http://git.gnome.org/browse/gimp/tree/plug-ins/twain/twain.h > > [4] http://git.gnome.org/browse/gimp/tree/libgimp/gimpitemcombobox.c > > [5] http://www.pasteall.org/pic/13959 > > [6] http://www.pasteall.org/pic/13961 > > ___ > > Bf-committers mailing list > > Bf-committers@blender.org > > http://lists.blender.org/mailman/listinfo/bf-committers > > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
- Original Message - > From: "Alex Fraser" > > For now it might be easiest to add all the 2.5x credits pages to the > page mentioned above. But as suggested by Campbell, we could move to a > more scalable format that shows each developer and the number of > commits they have made, like this: > > http://www.libreoffice.org/about-us/credits/ ... except that it would be great if we could show companies that sponsor development there too. In my case, I would be happy for the commits I make on behalf of a client be listed as a commit by that company, rather than by me. Cheers, Alex ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
On Wed, Aug 31, 2011 at 3:29 PM, Alex Fraser wrote: > - Original Message - >> From: "Alex Fraser" >> >> For now it might be easiest to add all the 2.5x credits pages to the >> page mentioned above. But as suggested by Campbell, we could move to a >> more scalable format that shows each developer and the number of >> commits they have made, like this: >> >> http://www.libreoffice.org/about-us/credits/ > > ... except that it would be great if we could show companies that sponsor > development there too. In my case, I would be happy for the commits I make on > behalf of a client be listed as a commit by that company, rather than by me. > > Cheers, > Alex Credits link from splash seems reasonable, or link from help menu, or prominent link from download page - I'm not that fussed as long as its not getting in the way too much. As for how to maintain this list - I doubt maintaining by hand will work, developers already don't add themselves to the `Contributors` section in the header much, so if this page is only to allow people to add themselves who like being credited - then I suppose it serves that purpose but wont end up crediting people who don't make the effort to add themselves there. Mostly I see this as being an extra wiki document to maintain, we already barely manage to keep lists of module owners, changelogs, release logs, py api changelogs, regression files etc. Up to date, so I'd be surprised if this page ends up being properly maintained. So I'll propose to parse svn logs, do some basic regex to get patch numbers and find the patch author names so we credit them too. The script can have some hard coded remappings to credit companies rather than the committers - think this wont be too hard to manage. If Ton's ok with it, I can look into this, think its only a few hrs work. -- - Campbell ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
Hi Campbell, Sure, proper crediting of our contributors is always cool! Let's do this as you propose for now, and investigate other methods later. -Ton- Ton Roosendaal Blender Foundation t...@blender.orgwww.blender.org Blender Institute Entrepotdok 57A 1018AD Amsterdam The Netherlands On 31 Aug, 2011, at 7:59, Campbell Barton wrote: > On Wed, Aug 31, 2011 at 3:29 PM, Alex Fraser wrote: >> - Original Message - >>> From: "Alex Fraser" >>> >>> For now it might be easiest to add all the 2.5x credits pages to the >>> page mentioned above. But as suggested by Campbell, we could move >>> to a >>> more scalable format that shows each developer and the number of >>> commits they have made, like this: >>> >>> http://www.libreoffice.org/about-us/credits/ >> >> ... except that it would be great if we could show companies that >> sponsor development there too. In my case, I would be happy for the >> commits I make on behalf of a client be listed as a commit by that >> company, rather than by me. >> >> Cheers, >> Alex > > Credits link from splash seems reasonable, or link from help menu, or > prominent link from download page - I'm not that fussed as long as its > not getting in the way too much. > > As for how to maintain this list - I doubt maintaining by hand will > work, developers already don't add themselves to the `Contributors` > section in the header much, so if this page is only to allow people to > add themselves who like being credited - then I suppose it serves that > purpose but wont end up crediting people who don't make the effort to > add themselves there. > > Mostly I see this as being an extra wiki document to maintain, we > already barely manage to keep lists of module owners, changelogs, > release logs, py api changelogs, regression files etc. Up to date, > so I'd be surprised if this page ends up being properly maintained. > > > So I'll propose to parse svn logs, do some basic regex to get patch > numbers and find the patch author names so we credit them too. The > script can have some hard coded remappings to credit companies rather > than the committers - think this wont be too hard to manage. > If Ton's ok with it, I can look into this, think its only a few hrs > work. > > -- > - Campbell > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
Committed https://svn.blender.org/svnroot/bf-blender/trunk/blender/intern/tools/credits_svn_gen.py Does basic commit stats as well as finding patches and attributing the patch authors. And added a link to the credits page from the splash. http://www.blender.org/development/credits Remaining todo's are: * Possibly some text on the credits page, none came to mind but easy to add. * I didn't find everyones real names (26 usernames left to find, falls back to the ID's they commit under) * Theres a section for companies and organizations, added 2 that sponsored features in blender but sure there are more. On Thu, Sep 1, 2011 at 7:59 PM, Ton Roosendaal wrote: > Hi Campbell, > > Sure, proper crediting of our contributors is always cool! > Let's do this as you propose for now, and investigate other methods > later. > > -Ton- > > > Ton Roosendaal Blender Foundation t...@blender.org www.blender.org > Blender Institute Entrepotdok 57A 1018AD Amsterdam The Netherlands > > On 31 Aug, 2011, at 7:59, Campbell Barton wrote: > >> On Wed, Aug 31, 2011 at 3:29 PM, Alex Fraser wrote: >>> - Original Message - From: "Alex Fraser" For now it might be easiest to add all the 2.5x credits pages to the page mentioned above. But as suggested by Campbell, we could move to a more scalable format that shows each developer and the number of commits they have made, like this: http://www.libreoffice.org/about-us/credits/ >>> >>> ... except that it would be great if we could show companies that >>> sponsor development there too. In my case, I would be happy for the >>> commits I make on behalf of a client be listed as a commit by that >>> company, rather than by me. >>> >>> Cheers, >>> Alex >> >> Credits link from splash seems reasonable, or link from help menu, or >> prominent link from download page - I'm not that fussed as long as its >> not getting in the way too much. >> >> As for how to maintain this list - I doubt maintaining by hand will >> work, developers already don't add themselves to the `Contributors` >> section in the header much, so if this page is only to allow people to >> add themselves who like being credited - then I suppose it serves that >> purpose but wont end up crediting people who don't make the effort to >> add themselves there. >> >> Mostly I see this as being an extra wiki document to maintain, we >> already barely manage to keep lists of module owners, changelogs, >> release logs, py api changelogs, regression files etc. Up to date, >> so I'd be surprised if this page ends up being properly maintained. >> >> >> So I'll propose to parse svn logs, do some basic regex to get patch >> numbers and find the patch author names so we credit them too. The >> script can have some hard coded remappings to credit companies rather >> than the committers - think this wont be too hard to manage. >> If Ton's ok with it, I can look into this, think its only a few hrs >> work. >> >> -- >> - Campbell >> ___ >> Bf-committers mailing list >> Bf-committers@blender.org >> http://lists.blender.org/mailman/listinfo/bf-committers > > ___ > Bf-committers mailing list > Bf-committers@blender.org > http://lists.blender.org/mailman/listinfo/bf-committers > -- - Campbell ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
Missed some points last mail. * Currently names are sorted alphabetically to avoid this becoming some kind of ranking. * Having 1 liner credits for each developer could be nice too but with 255 devs in the list, writing all this text is a big task, at least having a blank field and allowing others to fill in could work, if someone wants to help out writing this info I dont mind adding the field. * There seems to be some unicode problems with some names, have to look into this. On Fri, Sep 2, 2011 at 1:51 PM, Campbell Barton wrote: > Committed > https://svn.blender.org/svnroot/bf-blender/trunk/blender/intern/tools/credits_svn_gen.py > > Does basic commit stats as well as finding patches and attributing the > patch authors. > > And added a link to the credits page from the splash. > > http://www.blender.org/development/credits > > Remaining todo's are: > * Possibly some text on the credits page, none came to mind but easy to add. > * I didn't find everyones real names (26 usernames left to find, falls > back to the ID's they commit under) > * Theres a section for companies and organizations, added 2 that > sponsored features in blender but sure there are more. > > > On Thu, Sep 1, 2011 at 7:59 PM, Ton Roosendaal wrote: >> Hi Campbell, >> >> Sure, proper crediting of our contributors is always cool! >> Let's do this as you propose for now, and investigate other methods >> later. >> >> -Ton- >> >> >> Ton Roosendaal Blender Foundation t...@blender.org www.blender.org >> Blender Institute Entrepotdok 57A 1018AD Amsterdam The Netherlands >> >> On 31 Aug, 2011, at 7:59, Campbell Barton wrote: >> >>> On Wed, Aug 31, 2011 at 3:29 PM, Alex Fraser wrote: - Original Message - > From: "Alex Fraser" > > For now it might be easiest to add all the 2.5x credits pages to the > page mentioned above. But as suggested by Campbell, we could move > to a > more scalable format that shows each developer and the number of > commits they have made, like this: > > http://www.libreoffice.org/about-us/credits/ ... except that it would be great if we could show companies that sponsor development there too. In my case, I would be happy for the commits I make on behalf of a client be listed as a commit by that company, rather than by me. Cheers, Alex >>> >>> Credits link from splash seems reasonable, or link from help menu, or >>> prominent link from download page - I'm not that fussed as long as its >>> not getting in the way too much. >>> >>> As for how to maintain this list - I doubt maintaining by hand will >>> work, developers already don't add themselves to the `Contributors` >>> section in the header much, so if this page is only to allow people to >>> add themselves who like being credited - then I suppose it serves that >>> purpose but wont end up crediting people who don't make the effort to >>> add themselves there. >>> >>> Mostly I see this as being an extra wiki document to maintain, we >>> already barely manage to keep lists of module owners, changelogs, >>> release logs, py api changelogs, regression files etc. Up to date, >>> so I'd be surprised if this page ends up being properly maintained. >>> >>> >>> So I'll propose to parse svn logs, do some basic regex to get patch >>> numbers and find the patch author names so we credit them too. The >>> script can have some hard coded remappings to credit companies rather >>> than the committers - think this wont be too hard to manage. >>> If Ton's ok with it, I can look into this, think its only a few hrs >>> work. >>> >>> -- >>> - Campbell >>> ___ >>> Bf-committers mailing list >>> Bf-committers@blender.org >>> http://lists.blender.org/mailman/listinfo/bf-committers >> >> ___ >> Bf-committers mailing list >> Bf-committers@blender.org >> http://lists.blender.org/mailman/listinfo/bf-committers >> > > > > -- > - Campbell > -- - Campbell ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Visibility of attribution
On Fri, Sep 2, 2011 at 5:29 PM, Campbell Barton wrote: > * There seems to be some unicode problems with some names, have to > look into this. In Firefox, switching the page encoding to "Western (ISO 8859-1)" seems to get the characters showing up correctly... Damned charset issues. ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
