Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-21 Thread Yoav Weiss (@Shopify) 
On Thu, Mar 21, 2024 at 8:07 AM Marcos Caceres  wrote:

>
>
> On Wednesday, March 20, 2024 at 4:57:56 AM UTC+11 Sanket Joshi (Edge)
> wrote:
>
> Hi Marcos,
>
> The spec for the writing suggestions attribute
>  doesn't specify how
> UAs should implement writing suggestions under the hood, it just aims to
> provide developers with a way to control whether the writing suggestions
> are shown on their site or not.
>
>
> Right, but I think what we missed in the spec is describing how this plays
> with input events, and composition events, which is where this is now
> causing issues.
>

Once the dust settles and we understand why this is causing issues in
WebKit, and if/how the Edge implementation has avoided those issues, it'd
make sense to revisit the spec here and codify what implementers should be
doing to avoid such issues, and ensure interoperability. (either as a note,
or as part of the normative spec language, depending on what the
investigation would come up with)


>
> I don't think this attribute or its on-by-default state carries inherent
> compat risk.
>
>
> It might if the predictive text fires events and participates in the DOM
> (as it does in WebKit).
>
>
> I think any compat issues/quirks would depend on the implementation of
> writing suggestions, which will vary from browser to browser. I responded
> in the Github issue too, but we'll likely need to get to the bottom of what
> is breaking those sites with Safari's implementation of writing
> suggestions. We can continue discussions on Github.
>
>
> Yes, let's do that. Just think that because we didn't discuss input and
> composition events as part of standardization, we might have overlooked
> this aspect.
>
> Again, it depends on how this is implemented... like floating bubbles
> on-top of text might not fire events... but combining this with input and
> composition events seems to have issues. We might have been overly
> ambitious on the WebKit side making it participate in the composition /
> event set of events, but not sure.
>
>
>
> Thanks,
> Sanket
> On Tuesday, March 19, 2024 at 12:02:18 AM UTC-7 yoav...@chromium.org
> wrote:
>
> Thanks for the heads up, Marcos! :)
>
> On Tue, Mar 19, 2024 at 3:51 AM Marcos Caceres  wrote:
>
> Hi Blink-Dev Friends!
>
> We (WebKit) hit some web compat issues with this feature while testing our
> implementation is Safari Tech Preview.
>
> Could you please take a look at:
> https://github.com/whatwg/html/issues/10209
>
> And see if there is a way to leave this on by default somehow without
> affecting websites?
>
> Looking forward to discussions.
> Marcos
>
> On Friday, March 15, 2024 at 9:29:19 AM UTC+11 sligh...@chromium.org
> wrote:
>
> LGTM3
>
> On Thursday, March 14, 2024 at 2:59:45 PM UTC-7 Mike Taylor wrote:
>
> LGTM2
> On 3/14/24 12:43 AM, Domenic Denicola wrote:
>
> Awesome! LGTM1.
>
> On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev <
> blin...@chromium.org> wrote:
>
> Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name"
> field to kWritingSuggestions and removed the "Non-finch justification"
> field.
>
> On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola wrote:
>
> On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev <
> blin...@chromium.org> wrote:
>
> We do have a runtime feature flag 'WritingSuggestions
> '.
> We didn't think a Finch Trial was necessary, as the bulk of the changes were
> just adding the attribute and IDL functions
> .
> Since everything is implemented on the blink side, is a Finch feature flag
> still necessary? If it is, then I'll add that flag :)
>
>
> A runtime feature flag automatically generates
> 
> a Finch flag, unless you turn that off :). So I think this is just a matter
> of updating the Chrome Status entry.
>
>
>
> On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola wrote:
>
>
>
> On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang wrote:
>
> *Contact emails*
> *sa...@microsoft.com*, *dan...@microsoft.com*,
> *stephanie.zh...@microsoft.com*
>
> *Explainer*
>
> *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*
> 
>
> *Specification*
>
> *https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions*
> 
>
> *Summary*
> UAs are starting to provide writing suggestions to users as they type on
> various editable fields across the web. While this

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-21 Thread Marcos Caceres 


On Wednesday, March 20, 2024 at 4:57:56 AM UTC+11 Sanket Joshi (Edge) wrote:

Hi Marcos,

The spec for the writing suggestions attribute 
 doesn't specify how UAs 
should implement writing suggestions under the hood, it just aims to 
provide developers with a way to control whether the writing suggestions 
are shown on their site or not. 


Right, but I think what we missed in the spec is describing how this plays 
with input events, and composition events, which is where this is now 
causing issues. 
 

I don't think this attribute or its on-by-default state carries inherent 
compat risk. 


It might if the predictive text fires events and participates in the DOM 
(as it does in WebKit). 
 

I think any compat issues/quirks would depend on the implementation of 
writing suggestions, which will vary from browser to browser. I responded 
in the Github issue too, but we'll likely need to get to the bottom of what 
is breaking those sites with Safari's implementation of writing 
suggestions. We can continue discussions on Github.


Yes, let's do that. Just think that because we didn't discuss input and 
composition events as part of standardization, we might have overlooked 
this aspect. 

Again, it depends on how this is implemented... like floating bubbles 
on-top of text might not fire events... but combining this with input and 
composition events seems to have issues. We might have been overly 
ambitious on the WebKit side making it participate in the composition / 
event set of events, but not sure. 
 


Thanks,
Sanket
On Tuesday, March 19, 2024 at 12:02:18 AM UTC-7 yoav...@chromium.org wrote:

Thanks for the heads up, Marcos! :)

On Tue, Mar 19, 2024 at 3:51 AM Marcos Caceres  wrote:

Hi Blink-Dev Friends!

We (WebKit) hit some web compat issues with this feature while testing our 
implementation is Safari Tech Preview. 

Could you please take a look at:
https://github.com/whatwg/html/issues/10209

And see if there is a way to leave this on by default somehow without 
affecting websites? 

Looking forward to discussions. 
Marcos 

On Friday, March 15, 2024 at 9:29:19 AM UTC+11 sligh...@chromium.org wrote:

LGTM3

On Thursday, March 14, 2024 at 2:59:45 PM UTC-7 Mike Taylor wrote:

LGTM2
On 3/14/24 12:43 AM, Domenic Denicola wrote:

Awesome! LGTM1.

On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev <
blin...@chromium.org> wrote:

Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name" 
field to kWritingSuggestions and removed the "Non-finch justification" 
field. 

On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola wrote:

On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev <
blin...@chromium.org> wrote:

We do have a runtime feature flag 'WritingSuggestions 
'.
 
We didn't think a Finch Trial was necessary, as the bulk of the changes were 
just adding the attribute and IDL functions 
. Since 
everything is implemented on the blink side, is a Finch feature flag still 
necessary? If it is, then I'll add that flag :)


A runtime feature flag automatically generates 

 
a Finch flag, unless you turn that off :). So I think this is just a matter 
of updating the Chrome Status entry.
 


On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola wrote:



On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang wrote:

*Contact emails*
*sa...@microsoft.com*, *dan...@microsoft.com*, 
*stephanie.zh...@microsoft.com*

*Explainer*
*https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*
 


*Specification*
*https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions* 


*Summary*
UAs are starting to provide writing suggestions to users as they type on 
various editable fields across the web. While this is generally useful for 
users, there are cases when developers may want to turn off UA-provided 
writing assistance, such as extensions or sites that wish to provide 
similar functionality on their own. To that end, developers need a solution 
that would turn on/off UA-provided writing assistance. The new attribute 
'writingsuggestions' has values 'true'/'false' that would allow developers 
to turn on/off browser-provided writing suggestions. The attribute's state 
for an element can also be inherited from ancestor elements, thereby 
allowing developers to control this functionality at a per-element or 
per-

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-19 Thread 'Sanket Joshi (Edge)' via blink-dev 
Hi Marcos,

The spec for the writing suggestions attribute 
 doesn't specify how UAs 
should implement writing suggestions under the hood, it just aims to 
provide developers with a way to control whether the writing suggestions 
are shown on their site or not. I don't think this attribute or its 
on-by-default state carries inherent compat risk. I think any compat 
issues/quirks would depend on the implementation of writing suggestions, 
which will vary from browser to browser. I responded in the Github issue 
too, but we'll likely need to get to the bottom of what is breaking those 
sites with Safari's implementation of writing suggestions. We can continue 
discussions on Github.

Thanks,
Sanket
On Tuesday, March 19, 2024 at 12:02:18 AM UTC-7 yoav...@chromium.org wrote:

> Thanks for the heads up, Marcos! :)
>
> On Tue, Mar 19, 2024 at 3:51 AM Marcos Caceres  wrote:
>
>> Hi Blink-Dev Friends!
>>
>> We (WebKit) hit some web compat issues with this feature while testing 
>> our implementation is Safari Tech Preview. 
>>
>> Could you please take a look at:
>> https://github.com/whatwg/html/issues/10209
>>
>> And see if there is a way to leave this on by default somehow without 
>> affecting websites? 
>>
>> Looking forward to discussions. 
>> Marcos 
>>
>> On Friday, March 15, 2024 at 9:29:19 AM UTC+11 sligh...@chromium.org 
>> wrote:
>>
>>> LGTM3
>>>
>>> On Thursday, March 14, 2024 at 2:59:45 PM UTC-7 Mike Taylor wrote:
>>>
 LGTM2
 On 3/14/24 12:43 AM, Domenic Denicola wrote:

>>> Awesome! LGTM1.

 On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev <
 blin...@chromium.org> wrote:

 Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name" 
> field to kWritingSuggestions and removed the "Non-finch justification" 
> field. 
>
> On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola 
> wrote:
>
>> On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev <
>> blin...@chromium.org> wrote:
>>
>>> We do have a runtime feature flag 'WritingSuggestions 
>>> '.
>>>  
>>> We didn't think a Finch Trial was necessary, as the bulk of the changes 
>>> were 
>>> just adding the attribute and IDL functions 
>>> . 
>>> Since everything is implemented on the blink side, is a Finch feature 
>>> flag 
>>> still necessary? If it is, then I'll add that flag :)
>>
>>
>> A runtime feature flag automatically generates 
>> 
>>  
>> a Finch flag, unless you turn that off :). So I think this is just a 
>> matter 
>> of updating the Chrome Status entry.
>>  
>>
>>>
>>> On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola 
>>> wrote:
>>>


 On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang 
 wrote:

 *Contact emails*
 *sa...@microsoft.com*, *dan...@microsoft.com*, 
 *stephanie.zh...@microsoft.com*

 *Explainer*

 *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*
  
 

 *Specification*

 *https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions*
  
 

 *Summary*
 UAs are starting to provide writing suggestions to users as they 
 type on various editable fields across the web. While this is 
 generally 
 useful for users, there are cases when developers may want to turn off 
 UA-provided writing assistance, such as extensions or sites that wish 
 to 
 provide similar functionality on their own. To that end, developers 
 need a 
 solution that would turn on/off UA-provided writing assistance. The 
 new 
 attribute 'writingsuggestions' has values 'true'/'false' that would 
 allow 
 developers to turn on/off browser-provided writing suggestions. The 
 attribute's state for an element can also be inherited from ancestor 
 elements, thereby allowing developers to control this functionality at 
 a 
 per-element or per-document/sub-document scale.


 *Blink component*
 *Blink>Editing*

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-19 Thread Yoav Weiss (@Shopify) 
Thanks for the heads up, Marcos! :)

On Tue, Mar 19, 2024 at 3:51 AM Marcos Caceres  wrote:

> Hi Blink-Dev Friends!
>
> We (WebKit) hit some web compat issues with this feature while testing our
> implementation is Safari Tech Preview.
>
> Could you please take a look at:
> https://github.com/whatwg/html/issues/10209
>
> And see if there is a way to leave this on by default somehow without
> affecting websites?
>
> Looking forward to discussions.
> Marcos
>
> On Friday, March 15, 2024 at 9:29:19 AM UTC+11 sligh...@chromium.org
> wrote:
>
>> LGTM3
>>
>> On Thursday, March 14, 2024 at 2:59:45 PM UTC-7 Mike Taylor wrote:
>>
>>> LGTM2
>>> On 3/14/24 12:43 AM, Domenic Denicola wrote:
>>>
>> Awesome! LGTM1.
>>>
>>> On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev <
>>> blin...@chromium.org> wrote:
>>>
>>> Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name"
 field to kWritingSuggestions and removed the "Non-finch justification"
 field.

 On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola wrote:

> On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev <
> blin...@chromium.org> wrote:
>
>> We do have a runtime feature flag 'WritingSuggestions
>> '.
>> We didn't think a Finch Trial was necessary, as the bulk of the changes 
>> were
>> just adding the attribute and IDL functions
>> .
>> Since everything is implemented on the blink side, is a Finch feature 
>> flag
>> still necessary? If it is, then I'll add that flag :)
>
>
> A runtime feature flag automatically generates
> 
> a Finch flag, unless you turn that off :). So I think this is just a 
> matter
> of updating the Chrome Status entry.
>
>
>>
>> On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola
>> wrote:
>>
>>>
>>>
>>> On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang
>>> wrote:
>>>
>>> *Contact emails*
>>> *sa...@microsoft.com*, *dan...@microsoft.com*,
>>> *stephanie.zh...@microsoft.com*
>>>
>>> *Explainer*
>>>
>>> *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*
>>> 
>>>
>>> *Specification*
>>>
>>> *https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions*
>>> 
>>>
>>> *Summary*
>>> UAs are starting to provide writing suggestions to users as they
>>> type on various editable fields across the web. While this is generally
>>> useful for users, there are cases when developers may want to turn off
>>> UA-provided writing assistance, such as extensions or sites that wish to
>>> provide similar functionality on their own. To that end, developers 
>>> need a
>>> solution that would turn on/off UA-provided writing assistance. The new
>>> attribute 'writingsuggestions' has values 'true'/'false' that would 
>>> allow
>>> developers to turn on/off browser-provided writing suggestions. The
>>> attribute's state for an element can also be inherited from ancestor
>>> elements, thereby allowing developers to control this functionality at a
>>> per-element or per-document/sub-document scale.
>>>
>>>
>>> *Blink component*
>>> *Blink>Editing*
>>> 
>>>
>>> *TAG review*
>>> *https://github.com/w3ctag/design-reviews/issues/924*
>>> 
>>>
>>> *TAG review status*
>>> Issues addressed
>>>
>>> *Risks*
>>>
>>>
>>> *Interoperability and Compatibility*
>>> None
>>>
>>>
>>> *Gecko*: No signal (
>>> *https://github.com/mozilla/standards-positions/issues/855*
>>> )
>>>
>>> *WebKit*: In development (
>>> *https://github.com/WebKit/standards-positions/issues/308*
>>> ) WebKit
>>> Implementation PR: *https://github.com/WebKit/WebKit/pull/24051*
>>> 
>>>
>>> *Web developers*: No signals
>>>
>>> *Other signals*:
>>>
>>> *Ergonomics*
>>> None
>>>
>>>
>>> *Activation*
>>> None
>>>
>>>
>>> *Security*
>>>

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-18 Thread Marcos Caceres 
Hi Blink-Dev Friends!

We (WebKit) hit some web compat issues with this feature while testing our 
implementation is Safari Tech Preview. 

Could you please take a look at:
https://github.com/whatwg/html/issues/10209

And see if there is a way to leave this on by default somehow without 
affecting websites? 

Looking forward to discussions. 
Marcos 

On Friday, March 15, 2024 at 9:29:19 AM UTC+11 sligh...@chromium.org wrote:

> LGTM3
>
> On Thursday, March 14, 2024 at 2:59:45 PM UTC-7 Mike Taylor wrote:
>
>> LGTM2
>> On 3/14/24 12:43 AM, Domenic Denicola wrote:
>>
> Awesome! LGTM1.
>>
>> On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev <
>> blin...@chromium.org> wrote:
>>
>> Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name" 
>>> field to kWritingSuggestions and removed the "Non-finch justification" 
>>> field. 
>>>
>>> On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola wrote:
>>>
 On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev <
 blin...@chromium.org> wrote:

> We do have a runtime feature flag 'WritingSuggestions 
> '.
>  
> We didn't think a Finch Trial was necessary, as the bulk of the changes 
> were 
> just adding the attribute and IDL functions 
> . 
> Since everything is implemented on the blink side, is a Finch feature 
> flag 
> still necessary? If it is, then I'll add that flag :)


 A runtime feature flag automatically generates 
 
  
 a Finch flag, unless you turn that off :). So I think this is just a 
 matter 
 of updating the Chrome Status entry.
  

>
> On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola 
> wrote:
>
>>
>>
>> On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang wrote:
>>
>> *Contact emails*
>> *sa...@microsoft.com*, *dan...@microsoft.com*, 
>> *stephanie.zh...@microsoft.com*
>>
>> *Explainer*
>>
>> *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*
>>  
>> 
>>
>> *Specification*
>>
>> *https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions*
>>  
>> 
>>
>> *Summary*
>> UAs are starting to provide writing suggestions to users as they type 
>> on various editable fields across the web. While this is generally 
>> useful 
>> for users, there are cases when developers may want to turn off 
>> UA-provided 
>> writing assistance, such as extensions or sites that wish to provide 
>> similar functionality on their own. To that end, developers need a 
>> solution 
>> that would turn on/off UA-provided writing assistance. The new attribute 
>> 'writingsuggestions' has values 'true'/'false' that would allow 
>> developers 
>> to turn on/off browser-provided writing suggestions. The attribute's 
>> state 
>> for an element can also be inherited from ancestor elements, thereby 
>> allowing developers to control this functionality at a per-element or 
>> per-document/sub-document scale.
>>
>>
>> *Blink component*
>> *Blink>Editing* 
>> 
>>
>> *TAG review*
>> *https://github.com/w3ctag/design-reviews/issues/924* 
>> 
>>
>> *TAG review status*
>> Issues addressed
>>
>> *Risks*
>>
>>
>> *Interoperability and Compatibility*
>> None
>>
>>
>> *Gecko*: No signal (
>> *https://github.com/mozilla/standards-positions/issues/855* 
>> )
>>
>> *WebKit*: In development (
>> *https://github.com/WebKit/standards-positions/issues/308* 
>> ) WebKit 
>> Implementation PR: *https://github.com/WebKit/WebKit/pull/24051* 
>> 
>>
>> *Web developers*: No signals
>>
>> *Other signals*:
>>
>> *Ergonomics*
>> None
>>
>>
>> *Activation*
>> None
>>
>>
>> *Security*
>> None
>>
>>
>> *WebView application risks*
>> *Does this intent deprecate or change behavior of existing APIs, such 
>> that it has pote

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-14 Thread Alex Russell 
LGTM3

On Thursday, March 14, 2024 at 2:59:45 PM UTC-7 Mike Taylor wrote:

> LGTM2
> On 3/14/24 12:43 AM, Domenic Denicola wrote:
>
> Awesome! LGTM1.
>
> On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev <
> blink-dev@chromium.org> wrote:
>
>> Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name" 
>> field to kWritingSuggestions and removed the "Non-finch justification" 
>> field. 
>>
>> On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola wrote:
>>
>>> On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev <
>>> blin...@chromium.org> wrote:
>>>
 We do have a runtime feature flag 'WritingSuggestions 
 '.
  
 We didn't think a Finch Trial was necessary, as the bulk of the changes 
 were 
 just adding the attribute and IDL functions 
 . 
 Since everything is implemented on the blink side, is a Finch feature flag 
 still necessary? If it is, then I'll add that flag :)
>>>
>>>
>>> A runtime feature flag automatically generates 
>>> 
>>>  
>>> a Finch flag, unless you turn that off :). So I think this is just a matter 
>>> of updating the Chrome Status entry.
>>>  
>>>

 On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola wrote:

>
>
> On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang wrote:
>
> *Contact emails*
> *sa...@microsoft.com*, *dan...@microsoft.com*, 
> *stephanie.zh...@microsoft.com*
>
> *Explainer*
>
> *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*
>  
> 
>
> *Specification*
>
> *https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions*
>  
> 
>
> *Summary*
> UAs are starting to provide writing suggestions to users as they type 
> on various editable fields across the web. While this is generally useful 
> for users, there are cases when developers may want to turn off 
> UA-provided 
> writing assistance, such as extensions or sites that wish to provide 
> similar functionality on their own. To that end, developers need a 
> solution 
> that would turn on/off UA-provided writing assistance. The new attribute 
> 'writingsuggestions' has values 'true'/'false' that would allow 
> developers 
> to turn on/off browser-provided writing suggestions. The attribute's 
> state 
> for an element can also be inherited from ancestor elements, thereby 
> allowing developers to control this functionality at a per-element or 
> per-document/sub-document scale.
>
>
> *Blink component*
> *Blink>Editing* 
> 
>
> *TAG review*
> *https://github.com/w3ctag/design-reviews/issues/924* 
> 
>
> *TAG review status*
> Issues addressed
>
> *Risks*
>
>
> *Interoperability and Compatibility*
> None
>
>
> *Gecko*: No signal (
> *https://github.com/mozilla/standards-positions/issues/855* 
> )
>
> *WebKit*: In development (
> *https://github.com/WebKit/standards-positions/issues/308* 
> ) WebKit 
> Implementation PR: *https://github.com/WebKit/WebKit/pull/24051* 
> 
>
> *Web developers*: No signals
>
> *Other signals*:
>
> *Ergonomics*
> None
>
>
> *Activation*
> None
>
>
> *Security*
> None
>
>
> *WebView application risks*
> *Does this intent deprecate or change behavior of existing APIs, such 
> that it has potentially high risk for Android WebView-based applications?*
> None
>
>
> *Debuggability*
> None
>
>
> *Will this feature be supported on all six Blink platforms (Windows, 
> Mac, Linux, ChromeOS, Android, and Android WebView)?*
> Yes
> Attribute is available on all platforms.
>
>
> *Is this feature fully tested by* *web-platform-tests* 
> 
> *?*
> Yes
>
> *https://wpt.fyi/results/html/editing/editing-0/writing-sugg

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-14 Thread Mike Taylor 

LGTM2

On 3/14/24 12:43 AM, Domenic Denicola wrote:

Awesome! LGTM1.

On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev 
 wrote:


Thanks for clarifying! Updated the Chrome Status' "Finch Feature
Name" field to kWritingSuggestions and removed the "Non-finch
justification" field.

On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola
wrote:

On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via
blink-dev  wrote:

We do have a runtime feature flag 'WritingSuggestions

'.
We didn't think a Finch Trial was necessary, as the bulk
of the changes were just adding the attribute and IDL
functions
.
Since everything is implemented on the blink side, is a
Finch feature flag still necessary? If it is, then I'll
add that flag :)


A runtime feature flag automatically generates


a Finch flag, unless you turn that off :). So I think this is
just a matter of updating the Chrome Status entry.


On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic
Denicola wrote:



On Thursday, March 14, 2024 at 2:08:28 AM UTC+9
Stephanie Zhang wrote:

*Contact emails*

_sa...@microsoft.com_,_daniec@microsoft.com_,_stephanie.zh...@microsoft.com_

*Explainer*

_https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md_



*Specification*

_https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions_


*Summary*
UAs are starting to provide writing suggestions to
users as they type on various editable fields
across the web. While this is generally useful for
users, there are cases when developers may want to
turn off UA-provided writing assistance, such as
extensions or sites that wish to provide similar
functionality on their own. To that end,
developers need a solution that would turn on/off
UA-provided writing assistance. The new attribute
'writingsuggestions' has values 'true'/'false'
that would allow developers to turn on/off
browser-provided writing suggestions. The
attribute's state for an element can also be
inherited from ancestor elements, thereby allowing
developers to control this functionality at a
per-element or per-document/sub-document scale.


*Blink component*
_Blink>Editing_



*TAG review*
_https://github.com/w3ctag/design-reviews/issues/924_


*TAG review status*
Issues addressed

*Risks*


*Interoperability and Compatibility*
None


/Gecko/: No signal
(_https://github.com/mozilla/standards-positions/issues/855_
)

/WebKit/: In development
(_https://github.com/WebKit/standards-positions/issues/308_
)
WebKit Implementation
PR:_https://github.com/WebKit/WebKit/pull/24051_


/Web developers/: No signals

/Other signals/:

*Ergonomics*
None


*Activation*
None


*Security*
None


*WebView application risks*
/Does this intent deprecate or change behavior of
existing APIs, such that it has potentially

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-13 Thread Domenic Denicola 
Awesome! LGTM1.

On Thu, Mar 14, 2024 at 1:35 PM 'Stephanie Zhang' via blink-dev <
blink-dev@chromium.org> wrote:

> Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name"
> field to kWritingSuggestions and removed the "Non-finch justification"
> field.
>
> On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola wrote:
>
>> On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev <
>> blin...@chromium.org> wrote:
>>
>>> We do have a runtime feature flag 'WritingSuggestions
>>> '.
>>> We didn't think a Finch Trial was necessary, as the bulk of the changes were
>>> just adding the attribute and IDL functions
>>> .
>>> Since everything is implemented on the blink side, is a Finch feature flag
>>> still necessary? If it is, then I'll add that flag :)
>>
>>
>> A runtime feature flag automatically generates
>> 
>> a Finch flag, unless you turn that off :). So I think this is just a matter
>> of updating the Chrome Status entry.
>>
>>
>>>
>>> On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola wrote:
>>>


 On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang wrote:

 *Contact emails*
 *sa...@microsoft.com*, *dan...@microsoft.com*,
 *stephanie.zh...@microsoft.com*

 *Explainer*

 *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*
 

 *Specification*

 *https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions*
 

 *Summary*
 UAs are starting to provide writing suggestions to users as they type
 on various editable fields across the web. While this is generally useful
 for users, there are cases when developers may want to turn off UA-provided
 writing assistance, such as extensions or sites that wish to provide
 similar functionality on their own. To that end, developers need a solution
 that would turn on/off UA-provided writing assistance. The new attribute
 'writingsuggestions' has values 'true'/'false' that would allow developers
 to turn on/off browser-provided writing suggestions. The attribute's state
 for an element can also be inherited from ancestor elements, thereby
 allowing developers to control this functionality at a per-element or
 per-document/sub-document scale.


 *Blink component*
 *Blink>Editing*
 

 *TAG review*
 *https://github.com/w3ctag/design-reviews/issues/924*
 

 *TAG review status*
 Issues addressed

 *Risks*


 *Interoperability and Compatibility*
 None


 *Gecko*: No signal (
 *https://github.com/mozilla/standards-positions/issues/855*
 )

 *WebKit*: In development (
 *https://github.com/WebKit/standards-positions/issues/308*
 ) WebKit
 Implementation PR: *https://github.com/WebKit/WebKit/pull/24051*
 

 *Web developers*: No signals

 *Other signals*:

 *Ergonomics*
 None


 *Activation*
 None


 *Security*
 None


 *WebView application risks*
 *Does this intent deprecate or change behavior of existing APIs, such
 that it has potentially high risk for Android WebView-based applications?*
 None


 *Debuggability*
 None


 *Will this feature be supported on all six Blink platforms (Windows,
 Mac, Linux, ChromeOS, Android, and Android WebView)?*
 Yes
 Attribute is available on all platforms.


 *Is this feature fully tested by* *web-platform-tests*
 
 *?*
 Yes

 *https://wpt.fyi/results/html/editing/editing-0/writing-suggestions/writingsuggestions.html?label=master&label=experimental&aligned*
 


 *Flag name on chrome://flags*
 None

 *Finch feature name*
 None


 Per the flag guidelines

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-13 Thread 'Stephanie Zhang' via blink-dev 
Thanks for clarifying! Updated the Chrome Status' "Finch Feature Name" 
field to kWritingSuggestions and removed the "Non-finch justification" 
field. 

On Wednesday, March 13, 2024 at 9:20:57 PM UTC-7 Domenic Denicola wrote:

> On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev <
> blin...@chromium.org> wrote:
>
>> We do have a runtime feature flag 'WritingSuggestions 
>> '.
>>  
>> We didn't think a Finch Trial was necessary, as the bulk of the changes were 
>> just adding the attribute and IDL functions 
>> . 
>> Since everything is implemented on the blink side, is a Finch feature flag 
>> still necessary? If it is, then I'll add that flag :)
>
>
> A runtime feature flag automatically generates 
> 
>  
> a Finch flag, unless you turn that off :). So I think this is just a matter 
> of updating the Chrome Status entry.
>  
>
>>
>> On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola wrote:
>>
>>>
>>>
>>> On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang wrote:
>>>
>>> *Contact emails*
>>> *sa...@microsoft.com*, *dan...@microsoft.com*, 
>>> *stephanie.zh...@microsoft.com*
>>>
>>> *Explainer*
>>>
>>> *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*
>>>  
>>> 
>>>
>>> *Specification*
>>>
>>> *https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions*
>>>  
>>> 
>>>
>>> *Summary*
>>> UAs are starting to provide writing suggestions to users as they type on 
>>> various editable fields across the web. While this is generally useful for 
>>> users, there are cases when developers may want to turn off UA-provided 
>>> writing assistance, such as extensions or sites that wish to provide 
>>> similar functionality on their own. To that end, developers need a solution 
>>> that would turn on/off UA-provided writing assistance. The new attribute 
>>> 'writingsuggestions' has values 'true'/'false' that would allow developers 
>>> to turn on/off browser-provided writing suggestions. The attribute's state 
>>> for an element can also be inherited from ancestor elements, thereby 
>>> allowing developers to control this functionality at a per-element or 
>>> per-document/sub-document scale.
>>>
>>>
>>> *Blink component*
>>> *Blink>Editing* 
>>> 
>>>
>>> *TAG review*
>>> *https://github.com/w3ctag/design-reviews/issues/924* 
>>> 
>>>
>>> *TAG review status*
>>> Issues addressed
>>>
>>> *Risks*
>>>
>>>
>>> *Interoperability and Compatibility*
>>> None
>>>
>>>
>>> *Gecko*: No signal (
>>> *https://github.com/mozilla/standards-positions/issues/855* 
>>> )
>>>
>>> *WebKit*: In development (
>>> *https://github.com/WebKit/standards-positions/issues/308* 
>>> ) WebKit 
>>> Implementation PR: *https://github.com/WebKit/WebKit/pull/24051* 
>>> 
>>>
>>> *Web developers*: No signals
>>>
>>> *Other signals*:
>>>
>>> *Ergonomics*
>>> None
>>>
>>>
>>> *Activation*
>>> None
>>>
>>>
>>> *Security*
>>> None
>>>
>>>
>>> *WebView application risks*
>>> *Does this intent deprecate or change behavior of existing APIs, such 
>>> that it has potentially high risk for Android WebView-based applications?*
>>> None
>>>
>>>
>>> *Debuggability*
>>> None
>>>
>>>
>>> *Will this feature be supported on all six Blink platforms (Windows, 
>>> Mac, Linux, ChromeOS, Android, and Android WebView)?*
>>> Yes
>>> Attribute is available on all platforms.
>>>
>>>
>>> *Is this feature fully tested by* *web-platform-tests* 
>>> 
>>> *?*
>>> Yes
>>>
>>> *https://wpt.fyi/results/html/editing/editing-0/writing-suggestions/writingsuggestions.html?label=master&label=experimental&aligned*
>>>  
>>> 
>>>
>>>
>>> *Flag name on chrome://flags*
>>> None
>>>
>>> *Finch feature name*
>>> None
>>>
>>>
>>> Per the flag guidelines 
>>> ,
>>>  
>>> all new features are required to be placed behind a Finch feature flag 
>>> (i.e. base::Feature flag). Ca

Re: [blink-dev] Re: Intent to Ship: 'writingsuggestions' attribute

2024-03-13 Thread Domenic Denicola 
On Thu, Mar 14, 2024 at 12:54 PM 'Stephanie Zhang' via blink-dev <
blink-dev@chromium.org> wrote:

> We do have a runtime feature flag 'WritingSuggestions
> '.
> We didn't think a Finch Trial was necessary, as the bulk of the changes were
> just adding the attribute and IDL functions
> .
> Since everything is implemented on the blink side, is a Finch feature flag
> still necessary? If it is, then I'll add that flag :)


A runtime feature flag automatically generates

a Finch flag, unless you turn that off :). So I think this is just a matter
of updating the Chrome Status entry.


>
> On Wednesday, March 13, 2024 at 6:55:48 PM UTC-7 Domenic Denicola wrote:
>
>>
>>
>> On Thursday, March 14, 2024 at 2:08:28 AM UTC+9 Stephanie Zhang wrote:
>>
>> *Contact emails*
>> *sa...@microsoft.com*, *dan...@microsoft.com*,
>> *stephanie.zh...@microsoft.com*
>>
>> *Explainer*
>>
>> *https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WritingSuggestions/explainer.md*
>> 
>>
>> *Specification*
>>
>> *https://html.spec.whatwg.org/multipage/interaction.html#writing-suggestions*
>> 
>>
>> *Summary*
>> UAs are starting to provide writing suggestions to users as they type on
>> various editable fields across the web. While this is generally useful for
>> users, there are cases when developers may want to turn off UA-provided
>> writing assistance, such as extensions or sites that wish to provide
>> similar functionality on their own. To that end, developers need a solution
>> that would turn on/off UA-provided writing assistance. The new attribute
>> 'writingsuggestions' has values 'true'/'false' that would allow developers
>> to turn on/off browser-provided writing suggestions. The attribute's state
>> for an element can also be inherited from ancestor elements, thereby
>> allowing developers to control this functionality at a per-element or
>> per-document/sub-document scale.
>>
>>
>> *Blink component*
>> *Blink>Editing*
>> 
>>
>> *TAG review*
>> *https://github.com/w3ctag/design-reviews/issues/924*
>> 
>>
>> *TAG review status*
>> Issues addressed
>>
>> *Risks*
>>
>>
>> *Interoperability and Compatibility*
>> None
>>
>>
>> *Gecko*: No signal (
>> *https://github.com/mozilla/standards-positions/issues/855*
>> )
>>
>> *WebKit*: In development (
>> *https://github.com/WebKit/standards-positions/issues/308*
>> ) WebKit
>> Implementation PR: *https://github.com/WebKit/WebKit/pull/24051*
>> 
>>
>> *Web developers*: No signals
>>
>> *Other signals*:
>>
>> *Ergonomics*
>> None
>>
>>
>> *Activation*
>> None
>>
>>
>> *Security*
>> None
>>
>>
>> *WebView application risks*
>> *Does this intent deprecate or change behavior of existing APIs, such
>> that it has potentially high risk for Android WebView-based applications?*
>> None
>>
>>
>> *Debuggability*
>> None
>>
>>
>> *Will this feature be supported on all six Blink platforms (Windows, Mac,
>> Linux, ChromeOS, Android, and Android WebView)?*
>> Yes
>> Attribute is available on all platforms.
>>
>>
>> *Is this feature fully tested by* *web-platform-tests*
>> 
>> *?*
>> Yes
>>
>> *https://wpt.fyi/results/html/editing/editing-0/writing-suggestions/writingsuggestions.html?label=master&label=experimental&aligned*
>> 
>>
>>
>> *Flag name on chrome://flags*
>> None
>>
>> *Finch feature name*
>> None
>>
>>
>> Per the flag guidelines
>> ,
>> all new features are required to be placed behind a Finch feature flag
>> (i.e. base::Feature flag). Can you ensure this is done and update the
>> Chrome Status entry?
>>
>>
>>
>> *Non-finch justification*
>> No finch trial needed.
>>
>>
>> *Requires code in //chrome?*
>> False
>>
>> *Estimated milestones*
>> Shipping on desktop 124
>>
>> Shipping on Android 124
>>
>> Shipping on WebView 124
>>
>>
>>
>> *Anticipated spec changes*
>> *Open questions about a feature may be a source of future web compat or
>> interop issues. Ple