[jira] [Commented] (BOOKKEEPER-789) Update README to reflect bookkeeper modules
[
https://issues.apache.org/jira/browse/BOOKKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170685#comment-14170685
]
Sijie Guo commented on BOOKKEEPER-789:
--
committed as r1631681 in trunk.
Update README to reflect bookkeeper modules
---
Key: BOOKKEEPER-789
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-789
Project: Bookkeeper
Issue Type: Task
Components: bookkeeper-stats
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.3.0, 4.4.0
Attachments: BOOKKEEPER-789.diff
{quote}
BookKeeper project contains: section missing the following projects info.
- bookkeeper-stats (Stats API for bookkeeper)
- hedwig-client-jms (Hedwig client jms)
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (BOOKKEEPER-790) Add JNA license in NOTICE files
[ https://issues.apache.org/jira/browse/BOOKKEEPER-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-790. -- Resolution: Fixed committed as r1631683 in trunk Add JNA license in NOTICE files --- Key: BOOKKEEPER-790 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-790 Project: Bookkeeper Issue Type: Task Reporter: Sijie Guo Assignee: Sijie Guo Priority: Blocker Fix For: 4.3.0, 4.4.0 Attachments: BOOKKEEPER-790.patch Add JNA in NOTICE file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-792) Split bookkeeper client into a separate maven module
[ https://issues.apache.org/jira/browse/BOOKKEEPER-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172023#comment-14172023 ] Sijie Guo commented on BOOKKEEPER-792: -- I just have one concern how we commit this. How we could keep the history of those moved files? Split bookkeeper client into a separate maven module Key: BOOKKEEPER-792 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-792 Project: Bookkeeper Issue Type: Bug Reporter: Ivan Kelly Assignee: Ivan Kelly Fix For: 4.4.0 Attachments: 0001-Split-the-bookkeeper-client-from-the-server.patch, 0001-Split-the-bookkeeper-client-from-the-server.patch, 0001-Split-the-bookkeeper-client-from-the-server.patch Right now, to include bookkeeper as a dependency, you need to include org.apache.bookkeeper:bookkeeper-server This pulls in all the bookkeeper-server code, and all the server dependencies as well as the client. The server dependencies are larger than the client dependencies. For one thing, it pulls in jna and log4j which should never be pulled in from the client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-792) Split bookkeeper client into a separate maven module
[ https://issues.apache.org/jira/browse/BOOKKEEPER-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172025#comment-14172025 ] Sijie Guo commented on BOOKKEEPER-792: -- BTW, did you config your git to detect renames (diff.renames=true)? could you also put your patch onto review board, otherwise it is hard to track what files moved and what files are modified. Split bookkeeper client into a separate maven module Key: BOOKKEEPER-792 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-792 Project: Bookkeeper Issue Type: Bug Reporter: Ivan Kelly Assignee: Ivan Kelly Fix For: 4.4.0 Attachments: 0001-Split-the-bookkeeper-client-from-the-server.patch, 0001-Split-the-bookkeeper-client-from-the-server.patch, 0001-Split-the-bookkeeper-client-from-the-server.patch Right now, to include bookkeeper as a dependency, you need to include org.apache.bookkeeper:bookkeeper-server This pulls in all the bookkeeper-server code, and all the server dependencies as well as the client. The server dependencies are larger than the client dependencies. For one thing, it pulls in jna and log4j which should never be pulled in from the client. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-789) Update README to reflect bookkeeper modules
[
https://issues.apache.org/jira/browse/BOOKKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo updated BOOKKEEPER-789:
-
Fix Version/s: (was: 4.3.1)
4.3.0
Update README to reflect bookkeeper modules
---
Key: BOOKKEEPER-789
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-789
Project: Bookkeeper
Issue Type: Task
Components: bookkeeper-stats
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.3.0
Attachments: BOOKKEEPER-789.diff
{quote}
BookKeeper project contains: section missing the following projects info.
- bookkeeper-stats (Stats API for bookkeeper)
- hedwig-client-jms (Hedwig client jms)
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (BOOKKEEPER-589) Release notes update for non-BC changes
[ https://issues.apache.org/jira/browse/BOOKKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-589. -- Resolution: Done Assignee: Sijie Guo (was: Ivan Kelly) Release notes update for non-BC changes --- Key: BOOKKEEPER-589 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-589 Project: Bookkeeper Issue Type: Sub-task Components: Documentation Reporter: Ivan Kelly Assignee: Sijie Guo Priority: Blocker Fix For: 4.3.0 4.3.0 client will not be able to connect to 4.2.0 servers, due to something stupid in the protocol version handling. 4.2.0 and lower will blindly reject any messages which have a protocolVersion higher than that it's current version, even if the data format has not changed. The release notes should reflect this. Also, think about how the protocolVersion is used some more. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (BOOKKEEPER-790) Add JNA license in NOTICE files
Sijie Guo created BOOKKEEPER-790: Summary: Add JNA license in NOTICE files Key: BOOKKEEPER-790 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-790 Project: Bookkeeper Issue Type: Task Reporter: Sijie Guo Assignee: Sijie Guo Priority: Blocker Fix For: 4.3.0 Add JNA in NOTICE file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-790) Add JNA license in NOTICE files
[ https://issues.apache.org/jira/browse/BOOKKEEPER-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-790: - Attachment: BOOKKEEPER-790.patch add JNA in NOTICE file. Add JNA license in NOTICE files --- Key: BOOKKEEPER-790 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-790 Project: Bookkeeper Issue Type: Task Reporter: Sijie Guo Assignee: Sijie Guo Priority: Blocker Fix For: 4.3.0 Attachments: BOOKKEEPER-790.patch Add JNA in NOTICE file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-788) Provide release inspector script
[ https://issues.apache.org/jira/browse/BOOKKEEPER-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-788: - Fix Version/s: (was: 4.3.1) Provide release inspector script Key: BOOKKEEPER-788 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-788 Project: Bookkeeper Issue Type: Improvement Reporter: Jiannan Wang Assignee: Jiannan Wang Priority: Trivial Fix For: 4.4.0 Attachments: BOOKKEEPER-788.patch For each release, we need to type a sequence of commands to validate release candidate tag. This process could be achieved by a single script. Here is the behavior of the script in my mind: 1. Collecting build environment info (Operation System, JDK, Maven) 2. Run 'mvn install -DskipTests' 3. Checking code (findbugs, rat). 4. Running unit test 5. Start standalone Bookie and Hedwig service 6. Run simple Bookie test: bookkeeper-server/bin/bookkeeper simpletest -ensemble 3 -writeQuorum 3 7. Run simple Hedwig test: hedwig-server/bin/hedwig console; pubsub topic subscriber 10 message 8. Tar all above logs when error/exit In addition, this script could also be provided to user which could collect related information to diagnose compile/UT failure issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-789) Update README to reflect bookkeeper modules
[
https://issues.apache.org/jira/browse/BOOKKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo updated BOOKKEEPER-789:
-
Fix Version/s: (was: 4.3.0)
4.3.1
Update README to reflect bookkeeper modules
---
Key: BOOKKEEPER-789
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-789
Project: Bookkeeper
Issue Type: Task
Components: bookkeeper-stats
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.3.1
Attachments: BOOKKEEPER-789.diff
{quote}
BookKeeper project contains: section missing the following projects info.
- bookkeeper-stats (Stats API for bookkeeper)
- hedwig-client-jms (Hedwig client jms)
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-788) Provide release inspector script
[ https://issues.apache.org/jira/browse/BOOKKEEPER-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-788: - Affects Version/s: (was: 4.3.1) 4.3.0 Provide release inspector script Key: BOOKKEEPER-788 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-788 Project: Bookkeeper Issue Type: Improvement Affects Versions: 4.3.0 Reporter: Jiannan Wang Assignee: Jiannan Wang Priority: Trivial For each release, we need to type a sequence of commands to validate release candidate tag. This process could be achieved by a single script. Here is the behavior of the script in my mind: 1. Collecting build environment info (Operation System, JDK, Maven) 2. Run 'mvn install -DskipTests' 3. Checking code (findbugs, rat). 4. Running unit test 5. Start standalone Bookie and Hedwig service 6. Run simple Bookie test: bookkeeper-server/bin/bookkeeper simpletest -ensemble 3 -writeQuorum 3 7. Run simple Hedwig test: hedwig-server/bin/hedwig console; pubsub topic subscriber 10 message 8. Tar all above logs when error/exit In addition, this script could also be provided to user which could collect related information to diagnose compile/UT failure issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-788) Provide release inspector script
[ https://issues.apache.org/jira/browse/BOOKKEEPER-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-788: - Fix Version/s: 4.3.1 4.4.0 Provide release inspector script Key: BOOKKEEPER-788 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-788 Project: Bookkeeper Issue Type: Improvement Affects Versions: 4.3.0 Reporter: Jiannan Wang Assignee: Jiannan Wang Priority: Trivial Fix For: 4.4.0, 4.3.1 For each release, we need to type a sequence of commands to validate release candidate tag. This process could be achieved by a single script. Here is the behavior of the script in my mind: 1. Collecting build environment info (Operation System, JDK, Maven) 2. Run 'mvn install -DskipTests' 3. Checking code (findbugs, rat). 4. Running unit test 5. Start standalone Bookie and Hedwig service 6. Run simple Bookie test: bookkeeper-server/bin/bookkeeper simpletest -ensemble 3 -writeQuorum 3 7. Run simple Hedwig test: hedwig-server/bin/hedwig console; pubsub topic subscriber 10 message 8. Tar all above logs when error/exit In addition, this script could also be provided to user which could collect related information to diagnose compile/UT failure issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (BOOKKEEPER-789) Update README to reflect bookkeeper modules
Sijie Guo created BOOKKEEPER-789:
Summary: Update README to reflect bookkeeper modules
Key: BOOKKEEPER-789
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-789
Project: Bookkeeper
Issue Type: Task
Components: bookkeeper-stats
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.3.0
{quote}
BookKeeper project contains: section missing the following projects info.
- bookkeeper-stats (Stats API for bookkeeper)
- hedwig-client-jms (Hedwig client jms)
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-789) Update README to reflect bookkeeper modules
[
https://issues.apache.org/jira/browse/BOOKKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo updated BOOKKEEPER-789:
-
Attachment: BOOKKEEPER-789.diff
Update README to reflect bookkeeper modules
---
Key: BOOKKEEPER-789
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-789
Project: Bookkeeper
Issue Type: Task
Components: bookkeeper-stats
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.3.0
Attachments: BOOKKEEPER-789.diff
{quote}
BookKeeper project contains: section missing the following projects info.
- bookkeeper-stats (Stats API for bookkeeper)
- hedwig-client-jms (Hedwig client jms)
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-589) Release notes update for non-BC changes
[ https://issues.apache.org/jira/browse/BOOKKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159288#comment-14159288 ] Sijie Guo commented on BOOKKEEPER-589: -- I don't want to be blocked by any kind of complicated the release flow. I would follow what [~ikelly] suggested to keep release flow simple enough. Release notes update for non-BC changes --- Key: BOOKKEEPER-589 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-589 Project: Bookkeeper Issue Type: Sub-task Components: Documentation Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Blocker Fix For: 4.3.0 4.3.0 client will not be able to connect to 4.2.0 servers, due to something stupid in the protocol version handling. 4.2.0 and lower will blindly reject any messages which have a protocolVersion higher than that it's current version, even if the data format has not changed. The release notes should reflect this. Also, think about how the protocolVersion is used some more. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155166#comment-14155166
]
Sijie Guo commented on BOOKKEEPER-634:
--
- [~ikelly] limit sometime is useful for testing the tool. [~rakeshr] you just
ignored my comment again, as I said that if user doesn't provide [-limit], you
should iterate over all the ledgers, not just set a value like
Integer.MAX_VALUE.
- printing messages:
* It is not good idea to have printing operation in BookKeeperAdmin. It should
only be in BookieShell. BookKeeperAdmin is an admin client not a tool.
* please add an option [-verbose] for printing this messages.
* I'd rather prefer printing progress message every {N} ledgers, rather than
every {X} seconds. it is too noisy.
- -1 on Future.
* it is mixing callback with Future, which brings in too much inconsistent
styles in BookKeeperAdmin. I think we already have quite good pattern on
replication code about multiple callbacks. if we are sticking on the callback
styles, you don't even need to have a different set of status code. we should
only use a single set of status code, rather than introducing something
different, which make code maintenance complicated.
Provide admin tool to rename bookie identifier in ledger metadata
-
Key: BOOKKEEPER-634
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-client, bookkeeper-server
Affects Versions: 4.2.1
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch,
001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch,
BOOKKEEPER-634.patch
This JIRA to discuss about admin tool for changing the bookie's IP to
hostname.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155175#comment-14155175
]
Sijie Guo commented on BOOKKEEPER-634:
--
{quote}
One thing that's a little weird about the tool is that it only updates the
ledgers for a single bookie. So for each bookie changed, you'll have to iterate
over all ledgers. Not sure how to fix this cleanly though.
{quote}
This behavior also exists on replication tool. I have a fix to support multiple
bookies. I think for now, let's starting with renaming a bookie first, we could
iterate the change later to support renaming multiple bookies, with the change
to support replicating multiple bookies.
{quote}
For this reason I think we need to be clearer on the scenarios in which a admin
would use this tool, and also we need to be able to audit the ledgers to ensure
that if we update a bookie id, it doesn't exist in the system and can't remerge
in the system.
{quote}
the clear sequence for the admin tool:
1) cookie will be updated first, which hence bookie will be restarted and
registered bookie id as different id.
2) every client will be aware of the book id change, since the
available_bookies zookeeper path will be updated.
3) after this point, running updating ledger metadata will change the metadata
version, hence the writers will have to re-read metadata in case of ensemble
changing. so new ledger or new ensemble will use the new bookie id, while the
old ledger metadata will be updated when re-reading on bad version.
I think it is good so far. but we need to document this sequence anyway.
Provide admin tool to rename bookie identifier in ledger metadata
-
Key: BOOKKEEPER-634
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-client, bookkeeper-server
Affects Versions: 4.2.1
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch,
001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch,
BOOKKEEPER-634.patch
This JIRA to discuss about admin tool for changing the bookie's IP to
hostname.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-634: - Fix Version/s: (was: 4.3.0) 4.3.1 Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.1 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, 002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155184#comment-14155184 ] Sijie Guo commented on BOOKKEEPER-634: -- moved this to 4.3.1 since it is an admin tool and we don't have a patch ready for release. Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.1 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, 002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-639) Provide hostname based bookie and ledger metadata to support IP change
[ https://issues.apache.org/jira/browse/BOOKKEEPER-639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-639: - Fix Version/s: 4.3.1 Provide hostname based bookie and ledger metadata to support IP change -- Key: BOOKKEEPER-639 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-639 Project: Bookkeeper Issue Type: Improvement Components: bookkeeper-auto-recovery, bookkeeper-client, bookkeeper-server Affects Versions: 4.3.0 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152846#comment-14152846 ] Sijie Guo commented on BOOKKEEPER-634: -- [~rakeshr] are u able to produce a patch in these two days? since this is the remaining ticket for BOOKKEEPER-639. Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153902#comment-14153902 ] Sijie Guo commented on BOOKKEEPER-634: -- limit sounds good, but it should be an optional. if [-limit N] isn't specified, it would iterate over all the ledgers. please don't set any limitation like Integer.MAX. and also it isn't the 'limit' to overwhelm the system.'batchSize' isn't accurate though. I was expecting a rate limiting. but it is fine as the starting point. we could improve it in future. I don't want to block this one. Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151401#comment-14151401 ] Sijie Guo commented on BOOKKEEPER-634: -- I thought I already made comment about these two concerns. and 'bandwidth' should be 'concurrency' https://issues.apache.org/jira/browse/BOOKKEEPER-773?focusedCommentId=14129701page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14129701 . Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151401#comment-14151401 ] Sijie Guo edited comment on BOOKKEEPER-634 at 9/29/14 6:28 AM: --- I just found that I already made comment before and the concerns just being raised again and again, without being paid attention. anyway, 'bandwidth' should be 'concurrency'. https://issues.apache.org/jira/browse/BOOKKEEPER-773?focusedCommentId=14129701page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14129701 . was (Author: hustlmsp): I thought I already made comment about these two concerns. and 'bandwidth' should be 'concurrency' https://issues.apache.org/jira/browse/BOOKKEEPER-773?focusedCommentId=14129701page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14129701 . Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151405#comment-14151405 ] Sijie Guo commented on BOOKKEEPER-634: -- btw, I think we stuck on these two tickets for too long time. we need to move on and make a decision if we want to include these two tickets or not. Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149685#comment-14149685 ] Sijie Guo commented on BOOKKEEPER-634: -- let's stick on renaming bookie identifier on ledger metadata here. -1 on getting all ledgers just for counting the total number of ledgers, it is not good for a real production use case. And it doesn't make sense to add an API to get a count in prior to renaming, since ledger is adding and deleting all the time. so instead of printing percentage of progress, why couldn't me just print how many ledgers already are renamed? I didn't say the we need to rename in sequence. what I pointed out in my comments again and again, is that you should think of a real production system, you should limit the concurrency of ledger metadata access, to not overwhelm the system. -1 from me if these two points couldn't be addressed. Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148671#comment-14148671 ] Sijie Guo commented on BOOKKEEPER-773: -- make sense to me. [~rakeshr] do you have the latest patch? Provide admin tool to rename bookie identifier in Cookies - Key: BOOKKEEPER-773 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 004-BOOKKEEPER-773-rename-bookieid.patch, 005-BOOKKEEPER-773-rename-bookieid.patch, 006-BOOKKEEPER-773-rename-bookieid.patch, 007-BOOKKEEPER-773-rename-bookieid.patch, 008-BOOKKEEPER-773-rename-bookieid.patch, 009-BOOKKEEPER-773-rename-bookieid.patch, 010-BOOKKEEPER-773-rename-bookieid.patch The idea of this JIRA to implement a mechanism to efficiently rename the bookie identifier present in the Cookies. Cookie information will be present in: - ledger journal directories in each Bookie server - cookies znode in ZooKeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145755#comment-14145755 ] Sijie Guo commented on BOOKKEEPER-773: -- what is the difference with previous algorithm? could you clarify the difference on the sequence? Provide admin tool to rename bookie identifier in Cookies - Key: BOOKKEEPER-773 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 004-BOOKKEEPER-773-rename-bookieid.patch, 005-BOOKKEEPER-773-rename-bookieid.patch, 006-BOOKKEEPER-773-rename-bookieid.patch, 007-BOOKKEEPER-773-rename-bookieid.patch, 008-BOOKKEEPER-773-rename-bookieid.patch, 009-BOOKKEEPER-773-rename-bookieid.patch, 010-BOOKKEEPER-773-rename-bookieid.patch The idea of this JIRA to implement a mechanism to efficiently rename the bookie identifier present in the Cookies. Cookie information will be present in: - ledger journal directories in each Bookie server - cookies znode in ZooKeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142936#comment-14142936
]
Sijie Guo commented on BOOKKEEPER-773:
--
ok. first of all, I don't know what is the difference between cookie.copy and
newBuilder(cookie).
{code}
/**
+ * Gets a copy of this cookie object.
+ *
+ * @return cookie builder object
+ */
+Builder copy() {
+Builder builder = newBuilder(this);
+builder.setZnodeVersion(znodeVersion);
+return builder;
+}
{code}
secondly, I thought I had a comment in cookie builder to say we shouldn't have
znode version in builder. znode version should only exist in cookie instance,
which shouldn't be passed around between builders. I missed checking your patch
on addressing this comment.
https://issues.apache.org/jira/browse/BOOKKEEPER-782?focusedCommentId=14131090page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14131090
Provide admin tool to rename bookie identifier in Cookies
-
Key: BOOKKEEPER-773
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
004-BOOKKEEPER-773-rename-bookieid.patch,
005-BOOKKEEPER-773-rename-bookieid.patch,
006-BOOKKEEPER-773-rename-bookieid.patch,
007-BOOKKEEPER-773-rename-bookieid.patch,
008-BOOKKEEPER-773-rename-bookieid.patch,
009-BOOKKEEPER-773-rename-bookieid.patch,
010-BOOKKEEPER-773-rename-bookieid.patch
The idea of this JIRA to implement a mechanism to efficiently rename the
bookie identifier present in the Cookies. Cookie information will be present
in:
- ledger journal directories in each Bookie server
- cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144028#comment-14144028 ] Sijie Guo commented on BOOKKEEPER-773: -- +1 on Ivan's suggestion. Provide admin tool to rename bookie identifier in Cookies - Key: BOOKKEEPER-773 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 004-BOOKKEEPER-773-rename-bookieid.patch, 005-BOOKKEEPER-773-rename-bookieid.patch, 006-BOOKKEEPER-773-rename-bookieid.patch, 007-BOOKKEEPER-773-rename-bookieid.patch, 008-BOOKKEEPER-773-rename-bookieid.patch, 009-BOOKKEEPER-773-rename-bookieid.patch, 010-BOOKKEEPER-773-rename-bookieid.patch The idea of this JIRA to implement a mechanism to efficiently rename the bookie identifier present in the Cookies. Cookie information will be present in: - ledger journal directories in each Bookie server - cookies znode in ZooKeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142902#comment-14142902
]
Sijie Guo commented on BOOKKEEPER-773:
--
minor comment:
1.
{code}
+LOG.info(Updating cookie file present in journalDirectory
{}, journalDirectory);
+LOG.info(Updating cookie file present in ledgerDirectories
{}, ledgerDirectories);
+newCookie.writeToDirectory(journalDirectory);
+for (File dir : ledgerDirectories) {
+newCookie.writeToDirectory(dir);
+}
{code}
log on ledgerDirectories should after writeToDirectory before writing to ledger
directories.
2. I don't understand why you need a copy method. isn't the builder good
enough? I don't like adding such method in an immutable object.
otherwise, the patch looks good to me.
Provide admin tool to rename bookie identifier in Cookies
-
Key: BOOKKEEPER-773
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
004-BOOKKEEPER-773-rename-bookieid.patch,
005-BOOKKEEPER-773-rename-bookieid.patch,
006-BOOKKEEPER-773-rename-bookieid.patch,
007-BOOKKEEPER-773-rename-bookieid.patch,
008-BOOKKEEPER-773-rename-bookieid.patch,
009-BOOKKEEPER-773-rename-bookieid.patch,
010-BOOKKEEPER-773-rename-bookieid.patch
The idea of this JIRA to implement a mechanism to efficiently rename the
bookie identifier present in the Cookies. Cookie information will be present
in:
- ledger journal directories in each Bookie server
- cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-589) Release notes update for non-BC changes
[ https://issues.apache.org/jira/browse/BOOKKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141747#comment-14141747 ] Sijie Guo commented on BOOKKEEPER-589: -- [~fpj] how we could address the problem you mentioned? [~ikelly] which file we need to update? Release notes update for non-BC changes --- Key: BOOKKEEPER-589 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-589 Project: Bookkeeper Issue Type: Sub-task Components: Documentation Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Blocker Fix For: 4.3.0 4.3.0 client will not be able to connect to 4.2.0 servers, due to something stupid in the protocol version handling. 4.2.0 and lower will blindly reject any messages which have a protocolVersion higher than that it's current version, even if the data format has not changed. The release notes should reflect this. Also, think about how the protocolVersion is used some more. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141751#comment-14141751
]
Sijie Guo commented on BOOKKEEPER-773:
--
addition to Ivan's comment
{code}
+@Test(timeout = 6)
+public void testCookieDoesntExists() throws Exception {
+for (int i = 0; i bsConfs.size(); i++) {
+ServerConfiguration conf = bsConfs.get(i);
+BookieServer bks = bs.get(i);
+bks.shutdown();
+
+LOG.info(Perform renamebookieincookies command with true);
+BookieShell bkShell = new BookieShell();
+bkShell.setConf(conf);
+// passing invalid, so will take the default as false
+String[] argv = new String[] { bkrename, -cookie,
useHostNameAsBookieID, invalid };
+Assert.assertEquals(Failed to return the error code!, -1,
bkShell.run(argv));
+}
+}
{code}
why this test case need to run multiple times?
otherwise, the patch looks better.
[~rakeshr], could you provide a new patch addressed the comments?
Provide admin tool to rename bookie identifier in Cookies
-
Key: BOOKKEEPER-773
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
004-BOOKKEEPER-773-rename-bookieid.patch,
005-BOOKKEEPER-773-rename-bookieid.patch,
006-BOOKKEEPER-773-rename-bookieid.patch,
007-BOOKKEEPER-773-rename-bookieid.patch,
008-BOOKKEEPER-773-rename-bookieid.patch
The idea of this JIRA to implement a mechanism to efficiently rename the
bookie identifier present in the Cookies. Cookie information will be present
in:
- ledger journal directories in each Bookie server
- cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (BOOKKEEPER-786) Fix Findbugs Error In Codahale Stats Provider
Sijie Guo created BOOKKEEPER-786:
Summary: Fix Findbugs Error In Codahale Stats Provider
Key: BOOKKEEPER-786
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-786
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-stats
Reporter: Sijie Guo
Assignee: Sijie Guo
{quote}
[INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Inconsistent synchronization of
org.apache.bookkeeper.stats.CodahaleMetricsProvider.metrics; locked 83% of time
[org.apache.bookkeeper.stats.CodahaleMetricsProvider] At
CodahaleMetricsProvider.java:[lines 49-145]
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-786) Fix Findbugs Error In Codahale Stats Provider
[
https://issues.apache.org/jira/browse/BOOKKEEPER-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo updated BOOKKEEPER-786:
-
Fix Version/s: 4.3.0
Fix Findbugs Error In Codahale Stats Provider
-
Key: BOOKKEEPER-786
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-786
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-stats
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.3.0
Attachments: BOOKKEEPER-786.patch
{quote}
[INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Inconsistent synchronization of
org.apache.bookkeeper.stats.CodahaleMetricsProvider.metrics; locked 83% of
time [org.apache.bookkeeper.stats.CodahaleMetricsProvider] At
CodahaleMetricsProvider.java:[lines 49-145]
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-786) Fix Findbugs Error In Codahale Stats Provider
[
https://issues.apache.org/jira/browse/BOOKKEEPER-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo updated BOOKKEEPER-786:
-
Attachment: BOOKKEEPER-786.patch
Fix Findbugs Error In Codahale Stats Provider
-
Key: BOOKKEEPER-786
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-786
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-stats
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.3.0
Attachments: BOOKKEEPER-786.patch
{quote}
[INFO] BugInstance size is 1
[INFO] Error size is 0
[INFO] Total bugs: 1
[INFO] Inconsistent synchronization of
org.apache.bookkeeper.stats.CodahaleMetricsProvider.metrics; locked 83% of
time [org.apache.bookkeeper.stats.CodahaleMetricsProvider] At
CodahaleMetricsProvider.java:[lines 49-145]
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-782) Use builder pattern for Cookie
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136850#comment-14136850
]
Sijie Guo commented on BOOKKEEPER-782:
--
-1 on generateCookie on a cookie instance, we should keep cookie instance
methods behave as immutable object.
what you suggested before should be ok. why you don't use it?
{code}
String instanceId = getInstanceId(zk);
Cookie masterCookie = Cookie.generateCookie(conf);
if (null != instanceId) {
Cookie.Builder builder = Cookie.newBuilder(masterCookie);
builder.setInstanceId(instanceId);
masterCookie = builder.build();
}
{code}
Use builder pattern for Cookie
--
Key: BOOKKEEPER-782
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-782
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: BOOKKEEPER-782.patch, BOOKKEEPER-782.patch,
BOOKKEEPER-782.patch, BOOKKEEPER-782.patch, BOOKKEEPER-782.patch
It would be good to use builder pattern for Cookie, rather than modifying the
fields in place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-784) BookKeeperCloseTest#testLedgerCheck is failing intermittently
[
https://issues.apache.org/jira/browse/BOOKKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136851#comment-14136851
]
Sijie Guo commented on BOOKKEEPER-784:
--
+1 on removing the pre close parts.
BookKeeperCloseTest#testLedgerCheck is failing intermittently
-
Key: BOOKKEEPER-784
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-784
Project: Bookkeeper
Issue Type: Bug
Reporter: Rakesh R
Assignee: Rakesh R
Labels: test
Fix For: 4.3.0
*Stacktrace*
{code}
java.lang.AssertionError: Should have client closed exception expected:0
but was:-19
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:470)
at
org.apache.bookkeeper.client.BookKeeperCloseTest.testLedgerCheck(BookKeeperCloseTest.java:501)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
{code}
Link:
https://builds.apache.org/job/bookkeeper-trunk-precommit-build/722/testReport/junit/org.apache.bookkeeper.client/BookKeeperCloseTest/testLedgerCheck/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-785) Fix javadoc warnings in trunk
[ https://issues.apache.org/jira/browse/BOOKKEEPER-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138479#comment-14138479 ] Sijie Guo commented on BOOKKEEPER-785: -- +1 . committing Fix javadoc warnings in trunk - Key: BOOKKEEPER-785 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-785 Project: Bookkeeper Issue Type: Bug Reporter: Ivan Kelly Assignee: Ivan Kelly Fix For: 4.3.0 Attachments: 0001-Fixes-for-javadoc-warnings.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-784) BookKeeperCloseTest#testLedgerCheck is failing intermittently
[
https://issues.apache.org/jira/browse/BOOKKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138493#comment-14138493
]
Sijie Guo commented on BOOKKEEPER-784:
--
the patch looks good to me. +1, committing.
BookKeeperCloseTest#testLedgerCheck is failing intermittently
-
Key: BOOKKEEPER-784
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-784
Project: Bookkeeper
Issue Type: Bug
Reporter: Rakesh R
Labels: test
Fix For: 4.3.0
Attachments:
0001-BOOKKEEPER-784-BookKeeperCloseTest-testLedgerCheck-i.patch,
0001-BOOKKEEPER-784-BookKeeperCloseTest-testLedgerCheck-i.patch
*Stacktrace*
{code}
java.lang.AssertionError: Should have client closed exception expected:0
but was:-19
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.failNotEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:126)
at org.junit.Assert.assertEquals(Assert.java:470)
at
org.apache.bookkeeper.client.BookKeeperCloseTest.testLedgerCheck(BookKeeperCloseTest.java:501)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
{code}
Link:
https://builds.apache.org/job/bookkeeper-trunk-precommit-build/722/testReport/junit/org.apache.bookkeeper.client/BookKeeperCloseTest/testLedgerCheck/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-589) Release notes update for non-BC changes
[ https://issues.apache.org/jira/browse/BOOKKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138503#comment-14138503 ] Sijie Guo commented on BOOKKEEPER-589: -- [~ikelly] what we should provide for this ticket? Release notes update for non-BC changes --- Key: BOOKKEEPER-589 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-589 Project: Bookkeeper Issue Type: Sub-task Components: Documentation Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Blocker Fix For: 4.3.0 4.3.0 client will not be able to connect to 4.2.0 servers, due to something stupid in the protocol version handling. 4.2.0 and lower will blindly reject any messages which have a protocolVersion higher than that it's current version, even if the data format has not changed. The release notes should reflect this. Also, think about how the protocolVersion is used some more. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138502#comment-14138502 ] Sijie Guo commented on BOOKKEEPER-773: -- [~rakeshr] could you update your patch? Provide admin tool to rename bookie identifier in Cookies - Key: BOOKKEEPER-773 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 004-BOOKKEEPER-773-rename-bookieid.patch, 005-BOOKKEEPER-773-rename-bookieid.patch, 006-BOOKKEEPER-773-rename-bookieid.patch The idea of this JIRA to implement a mechanism to efficiently rename the bookie identifier present in the Cookies. Cookie information will be present in: - ledger journal directories in each Bookie server - cookies znode in ZooKeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14138506#comment-14138506 ] Sijie Guo commented on BOOKKEEPER-634: -- ping [~rakeshr] Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-782) Use builder pattern for Cookie
[ https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135833#comment-14135833 ] Sijie Guo commented on BOOKKEEPER-782: -- I know it doesn't change the object state. but it is so weird and confusing to have a set* method in an immutable object. +1 for Ivan's suggestion, you could have a method generateCookieWithBookieId. Use builder pattern for Cookie -- Key: BOOKKEEPER-782 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-782 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: BOOKKEEPER-782.patch, BOOKKEEPER-782.patch, BOOKKEEPER-782.patch, BOOKKEEPER-782.patch It would be good to use builder pattern for Cookie, rather than modifying the fields in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-783) Avoid running out of fds in MutlipleThreadReadTest
[
https://issues.apache.org/jira/browse/BOOKKEEPER-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135836#comment-14135836
]
Sijie Guo commented on BOOKKEEPER-783:
--
ping [~fpj]
Avoid running out of fds in MutlipleThreadReadTest
--
Key: BOOKKEEPER-783
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-783
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Sijie Guo
Labels: test
Fix For: 4.3.0
Attachments: BOOKKEEPER-783.patch
{code}
org.jboss.netty.channel.ChannelException: Failed to create a selector.
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.openSelector(AbstractNioSelector.java:343)
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.init(AbstractNioSelector.java:100)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorker.init(AbstractNioWorker.java:52)
at
org.jboss.netty.channel.socket.nio.NioWorker.init(NioWorker.java:45)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.createWorker(NioWorkerPool.java:45)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.createWorker(NioWorkerPool.java:28)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorkerPool.newWorker(AbstractNioWorkerPool.java:143)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorkerPool.init(AbstractNioWorkerPool.java:81)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.init(NioWorkerPool.java:39)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.init(NioWorkerPool.java:33)
at
org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.init(NioClientSocketChannelFactory.java:151)
at
org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.init(NioClientSocketChannelFactory.java:116)
at org.apache.bookkeeper.client.BookKeeper.init(BookKeeper.java:204)
at
org.apache.bookkeeper.client.BookKeeperTestClient.init(BookKeeperTestClient.java:50)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.createClients(MultipleThreadReadTest.java:73)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.multiLedgerMultiThreadRead(MultipleThreadReadTest.java:282)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.test1Ledger50ThreadsRead(MultipleThreadReadTest.java:326)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
Caused by: java.io.IOException: Too many open files
at sun.nio.ch.EPollArrayWrapper.epollCreate(Native Method)
at sun.nio.ch.EPollArrayWrapper.init(EPollArrayWrapper.java:69)
at sun.nio.ch.EPollSelectorImpl.init(EPollSelectorImpl.java:52)
at
sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:18)
at java.nio.channels.Selector.open(Selector.java:209)
at
org.jboss.netty.channel.socket.nio.SelectorUtil.open(SelectorUtil.java:63)
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.openSelector(AbstractNioSelector.java:341)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-783) Avoid running out of fds in MutlipleThreadReadTest
[
https://issues.apache.org/jira/browse/BOOKKEEPER-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134365#comment-14134365
]
Sijie Guo commented on BOOKKEEPER-783:
--
[~fpj] the test was to test multiple read/write threads in bookie server side.
we don't actually need multiple clients to spawn multiple connections, since in
bookie server side, individual read requests would be submitted to different
read threads.
Avoid running out of fds in MutlipleThreadReadTest
--
Key: BOOKKEEPER-783
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-783
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Sijie Guo
Labels: test
Fix For: 4.3.0
Attachments: BOOKKEEPER-783.patch
{code}
org.jboss.netty.channel.ChannelException: Failed to create a selector.
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.openSelector(AbstractNioSelector.java:343)
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.init(AbstractNioSelector.java:100)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorker.init(AbstractNioWorker.java:52)
at
org.jboss.netty.channel.socket.nio.NioWorker.init(NioWorker.java:45)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.createWorker(NioWorkerPool.java:45)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.createWorker(NioWorkerPool.java:28)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorkerPool.newWorker(AbstractNioWorkerPool.java:143)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorkerPool.init(AbstractNioWorkerPool.java:81)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.init(NioWorkerPool.java:39)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.init(NioWorkerPool.java:33)
at
org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.init(NioClientSocketChannelFactory.java:151)
at
org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.init(NioClientSocketChannelFactory.java:116)
at org.apache.bookkeeper.client.BookKeeper.init(BookKeeper.java:204)
at
org.apache.bookkeeper.client.BookKeeperTestClient.init(BookKeeperTestClient.java:50)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.createClients(MultipleThreadReadTest.java:73)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.multiLedgerMultiThreadRead(MultipleThreadReadTest.java:282)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.test1Ledger50ThreadsRead(MultipleThreadReadTest.java:326)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
Caused by: java.io.IOException: Too many open files
at sun.nio.ch.EPollArrayWrapper.epollCreate(Native Method)
at sun.nio.ch.EPollArrayWrapper.init(EPollArrayWrapper.java:69)
at sun.nio.ch.EPollSelectorImpl.init(EPollSelectorImpl.java:52)
at
sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:18)
at java.nio.channels.Selector.open(Selector.java:209)
at
org.jboss.netty.channel.socket.nio.SelectorUtil.open(SelectorUtil.java:63)
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.openSelector(AbstractNioSelector.java:341)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-782) Use builder pattern for Cookie
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14134867#comment-14134867
]
Sijie Guo commented on BOOKKEEPER-782:
--
regarding following comments, the patch looks good.
- it is strange to have both setInstanceId in both Cookie and Builder. as I
commented before, we shouldn't have setInstanceId in Cookie, as Cookie is an
immutable object.
- it is not good to have cookie constructor with builder. as builder is used to
build cookie.
I would suggest as follow:
{code}
// cookie construct
private Cookie(int layoutVersion, String bookieHost, String journalDir, String
ledgerDirs, int znodeVersion, String instanceId)
// build construct
private Builder(); // build from scratch
private Builder(Cookie cookie); // build from existing cookie
newBuilder();
newBuilder(Cookie cookie);
// build function
Cookie build() {
return new Cookie(...);
}
{code}
Use builder pattern for Cookie
--
Key: BOOKKEEPER-782
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-782
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: BOOKKEEPER-782.patch, BOOKKEEPER-782.patch,
BOOKKEEPER-782.patch, BOOKKEEPER-782.patch
It would be good to use builder pattern for Cookie, rather than modifying the
fields in place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129688#comment-14129688
]
Sijie Guo commented on BOOKKEEPER-773:
--
I think the thread is kind of being too long. let me recap what I commented
before (since I didn't see them in the new patch).
(those comments are only one rename cookie part)
* in general, all class variables in Cookie should be final. please use a
Builder pattern to generate a new Cookie object when modifying it. DONT modify
the field in-place, which would usually introduce bugs.
* getArgBooleanValue: I would suggest throw exceptions when encountered any bad
arguments, rather then silent them.
{code}
+private static boolean getArgBooleanValue(String arg, String option,
boolean defaultVal) {
+try {
+return Boolean.parseBoolean(arg);
+} catch (NumberFormatException nfe) {
+System.err.println(ERROR: invalid value for option + option +
: + arg);
+return defaultVal;
+}
+}
{code}
*
Provide admin tool to rename bookie identifier in Cookies
-
Key: BOOKKEEPER-773
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
004-BOOKKEEPER-773-rename-bookieid.patch,
005-BOOKKEEPER-773-rename-bookieid.patch
The idea of this JIRA to implement a mechanism to efficiently rename the
bookie identifier present in the Cookies. Cookie information will be present
in:
- ledger journal directories in each Bookie server
- cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129701#comment-14129701
]
Sijie Guo commented on BOOKKEEPER-773:
--
{code}
I'd like to retain the progress information. How about adding a 'bandwidth'
parameter(by default 10 operations) - this will be maximum number of ledgers
which can be renamed concurrently. If 11th operation comes it will wait.
{code}
there are actually two concerns on your implementation: 1) you pulled all
ledgers into a list, which doesn't work if your cluster have a lot of ledgers.
you might not encounter this issue on hdfs namenode, but we have this issue on
a real production cluster. so don't pull all ledgers together into a list, use
ledger iterator. 2) you send all the requests immediately, which will overwhelm
the system.
'bandwidth' (it is actually 'concurrency') is good for 2). but it doesn't
resolve 1). if you do want retain the progress information, please provide two
different implementation, one is using your current solution, while the other
one is using ledger iterator. so people could choose what to use. although I
don't suggest to have two implementation on this, it would make code
maintenance become hard.
Provide admin tool to rename bookie identifier in Cookies
-
Key: BOOKKEEPER-773
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
004-BOOKKEEPER-773-rename-bookieid.patch,
005-BOOKKEEPER-773-rename-bookieid.patch
The idea of this JIRA to implement a mechanism to efficiently rename the
bookie identifier present in the Cookies. Cookie information will be present
in:
- ledger journal directories in each Bookie server
- cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-775) Improve MultipleThreadReadTest to reduce flakiness
[ https://issues.apache.org/jira/browse/BOOKKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131083#comment-14131083 ] Sijie Guo commented on BOOKKEEPER-775: -- [~rakeshr] [~fpj] it is not the flakiness we discussed here. but it turns out most of the build failed due to 'Failed to create a selector.', it means there are too many open files. I doubt there might be some leaks or too low fd limit in jenkins. will take a look at more. Improve MultipleThreadReadTest to reduce flakiness -- Key: BOOKKEEPER-775 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-775 Project: Bookkeeper Issue Type: Test Components: bookkeeper-server Reporter: Sijie Guo Assignee: Sijie Guo Labels: test Fix For: 4.3.0 Attachments: BOOKKEEPER-775.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-782) Use builder pattern for Cookie
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131090#comment-14131090
]
Sijie Guo commented on BOOKKEEPER-782:
--
- since you already have builder, you shouldn't have setInstanceId on Cookie
itself. the interface should be like below:
{code}
Cookie oldCookie;
CookieBuilder builder = Cookie.newBuilder(oldCookie);
builder.setInstanceId(...);
Cookie newCookie = builder.build();
{code}
- znode version isn't part of a cookie. so it would not be part of builder,
which it would be a final. since it is kind of a state of a cookie object, each
time we update or delete the cookie object, the state will be changed. we only
use builder when we want to modify the fields of a cookie. hence, you don't
need to change the sigature of writeCookie and deleteCookie.
Use builder pattern for Cookie
--
Key: BOOKKEEPER-782
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-782
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: BOOKKEEPER-782.patch
It would be good to use builder pattern for Cookie, rather than modifying the
fields in place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (BOOKKEEPER-783) Avoid running out of fds in MutlipleThreadReadTest
Sijie Guo created BOOKKEEPER-783:
Summary: Avoid running out of fds in MutlipleThreadReadTest
Key: BOOKKEEPER-783
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-783
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.3.0
{code}
org.jboss.netty.channel.ChannelException: Failed to create a selector.
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.openSelector(AbstractNioSelector.java:343)
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.init(AbstractNioSelector.java:100)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorker.init(AbstractNioWorker.java:52)
at
org.jboss.netty.channel.socket.nio.NioWorker.init(NioWorker.java:45)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.createWorker(NioWorkerPool.java:45)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.createWorker(NioWorkerPool.java:28)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorkerPool.newWorker(AbstractNioWorkerPool.java:143)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorkerPool.init(AbstractNioWorkerPool.java:81)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.init(NioWorkerPool.java:39)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.init(NioWorkerPool.java:33)
at
org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.init(NioClientSocketChannelFactory.java:151)
at
org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.init(NioClientSocketChannelFactory.java:116)
at org.apache.bookkeeper.client.BookKeeper.init(BookKeeper.java:204)
at
org.apache.bookkeeper.client.BookKeeperTestClient.init(BookKeeperTestClient.java:50)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.createClients(MultipleThreadReadTest.java:73)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.multiLedgerMultiThreadRead(MultipleThreadReadTest.java:282)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.test1Ledger50ThreadsRead(MultipleThreadReadTest.java:326)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
Caused by: java.io.IOException: Too many open files
at sun.nio.ch.EPollArrayWrapper.epollCreate(Native Method)
at sun.nio.ch.EPollArrayWrapper.init(EPollArrayWrapper.java:69)
at sun.nio.ch.EPollSelectorImpl.init(EPollSelectorImpl.java:52)
at
sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:18)
at java.nio.channels.Selector.open(Selector.java:209)
at
org.jboss.netty.channel.socket.nio.SelectorUtil.open(SelectorUtil.java:63)
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.openSelector(AbstractNioSelector.java:341)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-783) Avoid running out of fds in MutlipleThreadReadTest
[
https://issues.apache.org/jira/browse/BOOKKEEPER-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo updated BOOKKEEPER-783:
-
Attachment: BOOKKEEPER-783.patch
test1Ledger50ThreadsRead will create 50 bookkeeper clients, which hence would
create 50 zookeeper clients, and each bookkeeper client would connect to 6
bookies, which might be the reason that cause running out of fds.
attached a patch:
- use one single bookkeeper client for reads. which would reduce the number of
connections spawn for this test case.
- reduce the number of entries writes/reads
- reduce the number of threads for test1Ledger50ThreadsRead
Avoid running out of fds in MutlipleThreadReadTest
--
Key: BOOKKEEPER-783
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-783
Project: Bookkeeper
Issue Type: Bug
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Sijie Guo
Labels: test
Fix For: 4.3.0
Attachments: BOOKKEEPER-783.patch
{code}
org.jboss.netty.channel.ChannelException: Failed to create a selector.
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.openSelector(AbstractNioSelector.java:343)
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.init(AbstractNioSelector.java:100)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorker.init(AbstractNioWorker.java:52)
at
org.jboss.netty.channel.socket.nio.NioWorker.init(NioWorker.java:45)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.createWorker(NioWorkerPool.java:45)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.createWorker(NioWorkerPool.java:28)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorkerPool.newWorker(AbstractNioWorkerPool.java:143)
at
org.jboss.netty.channel.socket.nio.AbstractNioWorkerPool.init(AbstractNioWorkerPool.java:81)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.init(NioWorkerPool.java:39)
at
org.jboss.netty.channel.socket.nio.NioWorkerPool.init(NioWorkerPool.java:33)
at
org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.init(NioClientSocketChannelFactory.java:151)
at
org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory.init(NioClientSocketChannelFactory.java:116)
at org.apache.bookkeeper.client.BookKeeper.init(BookKeeper.java:204)
at
org.apache.bookkeeper.client.BookKeeperTestClient.init(BookKeeperTestClient.java:50)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.createClients(MultipleThreadReadTest.java:73)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.multiLedgerMultiThreadRead(MultipleThreadReadTest.java:282)
at
org.apache.bookkeeper.test.MultipleThreadReadTest.test1Ledger50ThreadsRead(MultipleThreadReadTest.java:326)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at
org.junit.internal.runners.statements.FailOnTimeout$1.run(FailOnTimeout.java:28)
Caused by: java.io.IOException: Too many open files
at sun.nio.ch.EPollArrayWrapper.epollCreate(Native Method)
at sun.nio.ch.EPollArrayWrapper.init(EPollArrayWrapper.java:69)
at sun.nio.ch.EPollSelectorImpl.init(EPollSelectorImpl.java:52)
at
sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:18)
at java.nio.channels.Selector.open(Selector.java:209)
at
org.jboss.netty.channel.socket.nio.SelectorUtil.open(SelectorUtil.java:63)
at
org.jboss.netty.channel.socket.nio.AbstractNioSelector.openSelector(AbstractNioSelector.java:341)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-775) Improve MultipleThreadReadTest to reduce flakiness
[ https://issues.apache.org/jira/browse/BOOKKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128122#comment-14128122 ] Sijie Guo commented on BOOKKEEPER-775: -- the goal of this task to make this test more reliable, to reduce flakiness. since this test case would keep failing in a slow environment. Improve MultipleThreadReadTest to reduce flakiness -- Key: BOOKKEEPER-775 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-775 Project: Bookkeeper Issue Type: Test Components: bookkeeper-server Reporter: Sijie Guo Assignee: Sijie Guo Labels: test Fix For: 4.3.0 Attachments: BOOKKEEPER-775.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129677#comment-14129677 ] Sijie Guo commented on BOOKKEEPER-773: -- - it seems that the patch contains lots of unnecessary formats, it made hard to review actually. - still you didn't address my comments on renameBookieIdInLedger on BOOKKEEPER-634. This tool should focus on real production use case, not just print fancy information. The current implementation will definitely have huge side effects on real production traffic, if you don't control the number of requests issued to zookeeper. so -1 on renameBookieIdInLedger. another suggestion, even you use same command 'bkrename', you don't actually put all two tickets together. you could do: 1) first implement the options for renaming bookie identifier, since I think we are fine with your renaming bookie identifier part. (patch for BOOKKEEPER-773) 2) secondly add options to 'bkrename' to support renaming bookie in ledgers. (another patch for BOOKKEEPER-634). it is much clear and easier for reviewing and get things checked in faster. Provide admin tool to rename bookie identifier in Cookies - Key: BOOKKEEPER-773 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 004-BOOKKEEPER-773-rename-bookieid.patch, 005-BOOKKEEPER-773-rename-bookieid.patch The idea of this JIRA to implement a mechanism to efficiently rename the bookie identifier present in the Cookies. Cookie information will be present in: - ledger journal directories in each Bookie server - cookies znode in ZooKeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-776) Flaky test BookieRecoveryTest
[
https://issues.apache.org/jira/browse/BOOKKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126562#comment-14126562
]
Sijie Guo commented on BOOKKEEPER-776:
--
I think '4.2.9.Final' is a typo. since the current netty version in bookkeeper
is 3.2.9.Final.
{code}
dependency
groupIdorg.jboss.netty/groupId
artifactIdnetty/artifactId
version3.2.9.Final/version
scopecompile/scope
/dependency
{code}
Flaky test BookieRecoveryTest
-
Key: BOOKKEEPER-776
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-776
Project: Bookkeeper
Issue Type: Test
Components: bookkeeper-client
Reporter: Sijie Guo
Assignee: Ivan Kelly
Labels: test
Fix For: 4.3.0
Attachments: 0001-BOOKKEEPER-776-Flaky-test-BookieRecoveryTest.patch,
TEST-org.apache.bookkeeper.client.BookieRecoveryTest.xml,
TEST-org.apache.bookkeeper.client.BookieRecoveryTest.xml.fail1,
TEST-org.apache.bookkeeper.client.BookieRecoveryTest.xml.fail2
testMetadataConflictWithRecovery[0](org.apache.bookkeeper.client.BookieRecoveryTest):
Not fully replicated
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (BOOKKEEPER-775) Improve MultipleThreadReadTest to reduce flakiness
[ https://issues.apache.org/jira/browse/BOOKKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-775: - Attachment: BOOKKEEPER-775.patch Improve MultipleThreadReadTest to reduce flakiness -- Key: BOOKKEEPER-775 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-775 Project: Bookkeeper Issue Type: Test Components: bookkeeper-server Reporter: Sijie Guo Assignee: Sijie Guo Labels: test Fix For: 4.3.0 Attachments: BOOKKEEPER-775.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (BOOKKEEPER-781) Fix OOM on Hedwig Tests
Sijie Guo created BOOKKEEPER-781:
Summary: Fix OOM on Hedwig Tests
Key: BOOKKEEPER-781
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-781
Project: Bookkeeper
Issue Type: Improvement
Components: hedwig-server
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.3.0
{code}
java.lang.OutOfMemoryError: Direct buffer memory
at java.nio.Bits.reserveMemory(Bits.java:632)
at java.nio.DirectByteBuffer.init(DirectByteBuffer.java:97)
at java.nio.ByteBuffer.allocateDirect(ByteBuffer.java:288)
at
org.jboss.netty.channel.socket.nio.SocketSendBufferPool$Preallocation.init(SocketSendBufferPool.java:155)
at
org.jboss.netty.channel.socket.nio.SocketSendBufferPool.init(SocketSendBufferPool.java:42)
at
org.jboss.netty.channel.socket.nio.NioWorker.init(NioWorker.java:84)
at
org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.init(NioServerSocketPipelineSink.java:66)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.init(NioServerSocketChannelFactory.java:138)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.init(NioServerSocketChannelFactory.java:109)
at
org.apache.bookkeeper.proto.BookieNettyServer.init(BookieNettyServer.java:76)
at org.apache.bookkeeper.proto.BookieServer.init(BookieServer.java:97)
at org.apache.bookkeeper.proto.BookieServer.init(BookieServer.java:86)
at
org.apache.hedwig.server.persistence.BookKeeperTestBase$TestBookieServer.init(BookKeeperTestBase.java:86)
at
org.apache.hedwig.server.persistence.BookKeeperTestBase.startBookie(BookKeeperTestBase.java:234)
at
org.apache.hedwig.server.persistence.BookKeeperTestBase.startUpNewBookieServer(BookKeeperTestBase.java:222)
at
org.apache.hedwig.server.persistence.BookKeeperTestBase.setUp(BookKeeperTestBase.java:159)
at
org.apache.hedwig.server.HedwigHubTestBase.setUp(HedwigHubTestBase.java:178)
at
org.apache.hedwig.server.integration.TestHedwigHub.setUp(TestHedwigHub.java:226)
at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:24)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:110)
at
[jira] [Updated] (BOOKKEEPER-781) Fix OOM on Hedwig Tests
[
https://issues.apache.org/jira/browse/BOOKKEEPER-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo updated BOOKKEEPER-781:
-
Attachment: BOOKKEEPER-781.patch
try increase memory usage for tests.
Fix OOM on Hedwig Tests
---
Key: BOOKKEEPER-781
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-781
Project: Bookkeeper
Issue Type: Improvement
Components: hedwig-server
Reporter: Sijie Guo
Assignee: Sijie Guo
Labels: test
Fix For: 4.3.0
Attachments: BOOKKEEPER-781.patch
{code}
java.lang.OutOfMemoryError: Direct buffer memory
at java.nio.Bits.reserveMemory(Bits.java:632)
at java.nio.DirectByteBuffer.init(DirectByteBuffer.java:97)
at java.nio.ByteBuffer.allocateDirect(ByteBuffer.java:288)
at
org.jboss.netty.channel.socket.nio.SocketSendBufferPool$Preallocation.init(SocketSendBufferPool.java:155)
at
org.jboss.netty.channel.socket.nio.SocketSendBufferPool.init(SocketSendBufferPool.java:42)
at
org.jboss.netty.channel.socket.nio.NioWorker.init(NioWorker.java:84)
at
org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.init(NioServerSocketPipelineSink.java:66)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.init(NioServerSocketChannelFactory.java:138)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.init(NioServerSocketChannelFactory.java:109)
at
org.apache.bookkeeper.proto.BookieNettyServer.init(BookieNettyServer.java:76)
at org.apache.bookkeeper.proto.BookieServer.init(BookieServer.java:97)
at org.apache.bookkeeper.proto.BookieServer.init(BookieServer.java:86)
at
org.apache.hedwig.server.persistence.BookKeeperTestBase$TestBookieServer.init(BookKeeperTestBase.java:86)
at
org.apache.hedwig.server.persistence.BookKeeperTestBase.startBookie(BookKeeperTestBase.java:234)
at
org.apache.hedwig.server.persistence.BookKeeperTestBase.startUpNewBookieServer(BookKeeperTestBase.java:222)
at
org.apache.hedwig.server.persistence.BookKeeperTestBase.setUp(BookKeeperTestBase.java:159)
at
org.apache.hedwig.server.HedwigHubTestBase.setUp(HedwigHubTestBase.java:178)
at
org.apache.hedwig.server.integration.TestHedwigHub.setUp(TestHedwigHub.java:226)
at sun.reflect.GeneratedMethodAccessor50.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:24)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124330#comment-14124330 ] Sijie Guo commented on BOOKKEEPER-773: -- why couldn't you validate this in the command? Provide admin tool to rename bookie identifier in Cookies - Key: BOOKKEEPER-773 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch The idea of this JIRA to implement a mechanism to efficiently rename the bookie identifier present in the Cookies. Cookie information will be present in: - ledger journal directories in each Bookie server - cookies znode in ZooKeeper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[ https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124331#comment-14124331 ] Sijie Guo commented on BOOKKEEPER-634: -- ping. [~rakeshr] I am going to cut 4.3.0 release. do you get any chance to finish this? Provide admin tool to rename bookie identifier in ledger metadata - Key: BOOKKEEPER-634 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-client, bookkeeper-server Affects Versions: 4.2.1 Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch, 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch, BOOKKEEPER-634.patch This JIRA to discuss about admin tool for changing the bookie's IP to hostname. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-776) Flaky test BookieRecoveryTest
[ https://issues.apache.org/jira/browse/BOOKKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124339#comment-14124339 ] Sijie Guo commented on BOOKKEEPER-776: -- +1 for the patch. -1 for bumping to 4.x.x, since it would break backward compatibility. since it is end of the 4.3.0 release, we should not change major dependency. Flaky test BookieRecoveryTest - Key: BOOKKEEPER-776 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-776 Project: Bookkeeper Issue Type: Test Components: bookkeeper-client Reporter: Sijie Guo Assignee: Ivan Kelly Labels: test Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-776-Flaky-test-BookieRecoveryTest.patch, TEST-org.apache.bookkeeper.client.BookieRecoveryTest.xml, TEST-org.apache.bookkeeper.client.BookieRecoveryTest.xml.fail1, TEST-org.apache.bookkeeper.client.BookieRecoveryTest.xml.fail2 testMetadataConflictWithRecovery[0](org.apache.bookkeeper.client.BookieRecoveryTest): Not fully replicated -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110364#comment-14110364 ] Sijie Guo commented on BOOKKEEPER-736: -- 1 will fix it. 2 The way to keep a default constructor with a NullStatsLogger. I don't see a strong reason to remove them. so I will keep them around. Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, BOOKKEEPER-736.v3.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110377#comment-14110377 ] Sijie Guo commented on BOOKKEEPER-736: -- attach the new patch Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, BOOKKEEPER-736.v3.patch, BOOKKEEPER-736.v4.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-736: - Attachment: BOOKKEEPER-736.v4.patch Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, BOOKKEEPER-736.v3.patch, BOOKKEEPER-736.v4.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110471#comment-14110471 ] Sijie Guo commented on BOOKKEEPER-736: -- it doesn't make any sense to spread NullStatsLogger to every places to construct them. so a constructor with NullStatsLogger is necessary for sure. Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, BOOKKEEPER-736.v3.patch, BOOKKEEPER-736.v4.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110859#comment-14110859 ] Sijie Guo commented on BOOKKEEPER-736: -- as I said, the default constructor is a shortcut constructor for instantiating an object with default NullStatsLogger. it is useful everywhere not just for testing and to keep backward compatible if needed. I don't like the idea to mark every this kind of constructor to be visible for testing, which doesn't seems to be exposed only for testing. Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, BOOKKEEPER-736.v3.patch, BOOKKEEPER-736.v4.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108817#comment-14108817 ] Sijie Guo commented on BOOKKEEPER-736: -- k. I will fix the rereplicate stat. for the urledgers counter, I don't want to add this counter. as it is hard and doesn't make any sense to collect an inaccurate counter. Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-736: - Attachment: BOOKKEEPER-736.v3.patch attach a new patch improving re-replicate stat collection Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, BOOKKEEPER-736.v3.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (BOOKKEEPER-398) Improving stats collection in bookkeeper
[ https://issues.apache.org/jira/browse/BOOKKEEPER-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-398. -- Resolution: Fixed Improving stats collection in bookkeeper Key: BOOKKEEPER-398 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-398 Project: Bookkeeper Issue Type: Improvement Components: hedwig-server Affects Versions: 4.2.0 Reporter: Aniruddha Assignee: Aniruddha Fix For: 4.3.0 Attachments: BK-398.patch We have been experimenting with using the Twitter stats package (http://twitter.github.com/commons/apidocs/com/twitter/common/stats/package-summary.html) for exporting hedwig stats over HTTP. This is open-sourced under the Apache license. The motivation for this was better logging of percentile latencies and requests-per-second (which are difficult to measure with the current implementation of hedwig stats). Is this something the community would be interested in? If so, I could work on a patch. Reviewboard : https://reviews.apache.org/r/7134/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14100109#comment-14100109
]
Sijie Guo commented on BOOKKEEPER-736:
--
{quote}
rereplicateOpStats.registerSuccessfulEvent(latencyMillis)
{quote}
rereplicate op stats already has a counter for the re-replication operations.
{quote}
If there are UrLedgers it gives hint that the BK cluster has to be carefully
observed to see its successful recovery, because there are missing replicas and
could be a concern for critical data like Namenode WAL
{quote}
as I said that, the counter dosn't provided any meaningful info on
underreplicated ledgers. for example,
bookie process starts up, it marks 3 ledgers as underreplicated, the counter is
3.
bookie failed and restarted, the counter was reset to 0. those 3 ledgers are
marked as replicated after re-replicated. so the counter becomes -3. what does
-3 mean? it means nothing.
if you strongly want to put those stats in, please provide the mechanism that
could provide a meaningful stat for them. otherwise, we just end up arguing on
meaningless things.
Stats for AutoRecovery
--
Key: BOOKKEEPER-736
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736
Project: Bookkeeper
Issue Type: New Feature
Components: bookkeeper-auto-recovery
Reporter: Rakesh R
Assignee: Sijie Guo
Fix For: 4.3.0
Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch,
Prototype-JMX-beans-for-standalone-autorecovery-process.png
Idea of this JIRA is to provide jmx interfaces to get the statistics of the
auto recovery activities.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098218#comment-14098218
]
Sijie Guo commented on BOOKKEEPER-736:
--
{quote}
the total number of ledgers which a bookie(say BK1) has successfully
re-replicated to itself.
{quote}
the stats of re-replication already gives what you want.
{quote}
NumUrLedgers - the total number of under replicated ledgers in the BK cluster
{quote}
as I said, the only place that have total number of under replicated ledgers in
the bk cluster is the zookeeper metadata. the counter that you have just
indicated that under replicated ledgers that the bookie process found during it
is running. it doest provide any useful info.
Stats for AutoRecovery
--
Key: BOOKKEEPER-736
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736
Project: Bookkeeper
Issue Type: New Feature
Components: bookkeeper-auto-recovery
Reporter: Rakesh R
Assignee: Sijie Guo
Fix For: 4.3.0
Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch,
Prototype-JMX-beans-for-standalone-autorecovery-process.png
Idea of this JIRA is to provide jmx interfaces to get the statistics of the
auto recovery activities.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (BOOKKEEPER-630) Add tag to o.a.b.net.* to indict which release of hadoop they came from, move DNS to o.a.b.net.* and indent
[ https://issues.apache.org/jira/browse/BOOKKEEPER-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096630#comment-14096630 ] Sijie Guo commented on BOOKKEEPER-630: -- rebase the patch to latest trunk. Add tag to o.a.b.net.* to indict which release of hadoop they came from, move DNS to o.a.b.net.* and indent --- Key: BOOKKEEPER-630 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-630 Project: Bookkeeper Issue Type: Improvement Reporter: Flavio Junqueira Assignee: Sijie Guo Priority: Trivial Fix For: 4.3.0 Attachments: BOOKKEEPER-630.diff, BOOKKEEPER-630.v2.diff We didn't reformat the code before bringing it in from hadoop commons in the patch of BOOKKEEPER-618. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (BOOKKEEPER-630) Add tag to o.a.b.net.* to indict which release of hadoop they came from, move DNS to o.a.b.net.* and indent
[ https://issues.apache.org/jira/browse/BOOKKEEPER-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-630: - Attachment: BOOKKEEPER-630.v2.diff Add tag to o.a.b.net.* to indict which release of hadoop they came from, move DNS to o.a.b.net.* and indent --- Key: BOOKKEEPER-630 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-630 Project: Bookkeeper Issue Type: Improvement Reporter: Flavio Junqueira Assignee: Sijie Guo Priority: Trivial Fix For: 4.3.0 Attachments: BOOKKEEPER-630.diff, BOOKKEEPER-630.v2.diff We didn't reformat the code before bringing it in from hadoop commons in the patch of BOOKKEEPER-618. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098134#comment-14098134 ] Sijie Guo commented on BOOKKEEPER-736: -- [~rakeshr] I don't know if NumUrLedgers, NumRereplicatedLedgers is useful, since it doesn't indicated the number of under replicated ledgers in the cluster at a given point. I would suggest leave them out and re-consider adding them back if there is a use case that need them. Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-736: - Attachment: BOOKKEEPER-736.v2.patch Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087361#comment-14087361 ] Sijie Guo commented on BOOKKEEPER-773: -- a minor comment: it would be better to use a Builder pattern for Cookie, rather than modifying the fields in place. Provide admin tool to rename bookie identifier in Cookies - Key: BOOKKEEPER-773 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch, 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch The idea of this JIRA to implement a mechanism to efficiently rename the bookie identifier present in the Cookies. Cookie information will be present in: - ledger journal directories in each Bookie server - cookies znode in ZooKeeper -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087919#comment-14087919
]
Sijie Guo commented on BOOKKEEPER-736:
--
{quote}
Here I tried to expose few details(attributes) where user might be interested.
What do you think of including these too.
{quote}
The stats library currently doesn't have the ability to expose attributes.
Although I am not sure it is worth to expose them (e.g. startTime,
checkInterval), which they never changed and could be found by logs and
configurations. Why you need them to be exposed as a stat?
Stats for AutoRecovery
--
Key: BOOKKEEPER-736
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736
Project: Bookkeeper
Issue Type: New Feature
Components: bookkeeper-auto-recovery
Reporter: Rakesh R
Assignee: Sijie Guo
Fix For: 4.3.0
Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch,
Prototype-JMX-beans-for-standalone-autorecovery-process.png
Idea of this JIRA is to provide jmx interfaces to get the statistics of the
auto recovery activities.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14082003#comment-14082003
]
Sijie Guo commented on BOOKKEEPER-773:
--
{quote}
change the bookie id and update it back to zookeeper to use same zk path.
I think this is not required and can be removed ?
{quote}
it is good to have to make sure a bookie couldn't start if it fails in the
middle of renaming cookie. changing the bookie id first would prevent a bookie
start since cookies will not match. it would remind people to finish renaming
cookie.
I would suggest not generating cookie from configuration. or at lease you
should verify the cookie matches the cookie you read from zookeeper before
setting new bookie id.
regarding the above comments, the flow looks good to me.
other comments on your patch:
- you should handle the case that the new cookie was already created in
zookeeper, in previous rename run. and added test case for it.
- incorrect option description: opts.addOption(l, useHostNameAsBookieID,
true, Ledger ID);
- I don't understand why you need to bump cookie version. there isn't cookie
format changes.
- why you need to test 3 bookies? why can't just test one bookie?
Provide admin tool to rename bookie identifier in Cookies
-
Key: BOOKKEEPER-773
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch
The idea of this JIRA to implement a mechanism to efficiently rename the
bookie identifier present in the Cookies. Cookie information will be present
in:
- ledger journal directories in each Bookie server
- cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (BOOKKEEPER-775) Improve MultipleThreadReadTest to reduce flakiness
Sijie Guo created BOOKKEEPER-775: Summary: Improve MultipleThreadReadTest to reduce flakiness Key: BOOKKEEPER-775 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-775 Project: Bookkeeper Issue Type: Test Components: bookkeeper-server Reporter: Sijie Guo Assignee: Sijie Guo -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (BOOKKEEPER-775) Improve MultipleThreadReadTest to reduce flakiness
[ https://issues.apache.org/jira/browse/BOOKKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-775: - Fix Version/s: 4.3.0 Improve MultipleThreadReadTest to reduce flakiness -- Key: BOOKKEEPER-775 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-775 Project: Bookkeeper Issue Type: Test Components: bookkeeper-server Reporter: Sijie Guo Assignee: Sijie Guo Labels: test Fix For: 4.3.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-697) stats collection on bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083256#comment-14083256 ] Sijie Guo commented on BOOKKEEPER-697: -- https://issues.apache.org/jira/browse/BOOKKEEPER-775 for MultipleThreadReadTest https://issues.apache.org/jira/browse/BOOKKEEPER-776 for BookieRecoveryTest stats collection on bookkeeper server - Key: BOOKKEEPER-697 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-697 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Sijie Guo Assignee: Aniruddha Fix For: 4.3.0 Attachments: BOOKKEEPER-697.patch Stats collection on bookkeeper server. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (BOOKKEEPER-776) Flaky test BookieRecoveryTest
Sijie Guo created BOOKKEEPER-776: Summary: Flaky test BookieRecoveryTest Key: BOOKKEEPER-776 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-776 Project: Bookkeeper Issue Type: Test Components: bookkeeper-client Reporter: Sijie Guo Fix For: 4.3.0 testMetadataConflictWithRecovery[0](org.apache.bookkeeper.client.BookieRecoveryTest): Not fully replicated -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-772) Reorder read sequnce
[ https://issues.apache.org/jira/browse/BOOKKEEPER-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080301#comment-14080301 ] Sijie Guo commented on BOOKKEEPER-772: -- this is an extension on placement policy. Reorder read sequnce - Key: BOOKKEEPER-772 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-772 Project: Bookkeeper Issue Type: Improvement Components: bookkeeper-client Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 4.4.0 We should reorder the read sequence base on location, bookie availability, for latency consideration. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (BOOKKEEPER-588) SSL support
[ https://issues.apache.org/jira/browse/BOOKKEEPER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-588: - Fix Version/s: (was: 4.3.0) 4.4.0 SSL support --- Key: BOOKKEEPER-588 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-588 Project: Bookkeeper Issue Type: Sub-task Reporter: Ivan Kelly Assignee: Ivan Kelly Fix For: 4.4.0 Attachments: 0004-BOOKKEEPER-588-SSL-support-for-bookkeeper.patch SSL support using startTLS -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-634) Provide admin tool to rename bookie identifier in ledger metadata
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080401#comment-14080401
]
Sijie Guo commented on BOOKKEEPER-634:
--
{code}
+final String curBookieIdString[] = args[0].split(:);
+if (curBookieIdString.length != 2) {
+System.err.println(BookieId inputted has invalid format +
(host:port or ip:port expected):
++ args[0]);
+return -1;
+}
+final String toBookieIdString[] = args[1].split(:);
+if (toBookieIdString.length != 2) {
+System.err.println(BookieId inputted has invalid format +
(host:port or ip:port expected):
++ args[0]);
+return -1;
+}
+final BookieSocketAddress curBookieAddr = new
BookieSocketAddress(curBookieIdString[0],
+Integer.parseInt(toBookieIdString[1]));
+final BookieSocketAddress toBookieAddr = new
BookieSocketAddress(toBookieIdString[0],
+Integer.parseInt(toBookieIdString[1]));
{code}
1. You shouldn't construct BookieSocketAddress in your own way. You should use
'new BookieSocketAddress(addrStr);'
2. The way that you get whole ledgers into a set and then issues all reads at
the same time is definitely terrible. You should use the LedgerIterator and do
it iterator by iterator, and you have to bind the outstanding metadata reads
and updates to not overwhelm metadata store (zookeeper).
3. adding timeout to a method isn't a great solution. the method is actually
could be implemented in asynchronous way, so leave the decision to the caller
to decide whether need to timeout or not.
4. ReReadLedgerMetadataCb is a bad name since there isn't re-read behavior.
Provide admin tool to rename bookie identifier in ledger metadata
-
Key: BOOKKEEPER-634
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-634
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-client, bookkeeper-server
Affects Versions: 4.2.1
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.3.0
Attachments: 0001-BOOKKEEPER-634-initial-draft-version.patch,
001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch,
BOOKKEEPER-634-rename-bookieid-in-ledger.patch, BOOKKEEPER-634.patch,
BOOKKEEPER-634.patch
This JIRA to discuss about admin tool for changing the bookie's IP to
hostname.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (BOOKKEEPER-773) Provide admin tool to rename bookie identifier in Cookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080403#comment-14080403 ] Sijie Guo commented on BOOKKEEPER-773: -- 1. use BookieSocketAddress constructor with a string. don't do it yourself. 2. you'd better change bookie id path if bookie id is changed. so the correct sequence would be * read cookie from zookeeper. * change the bookie id and update it back to zookeeper to use same zk path. * update cookie into local directories. * create new cookie with new zk path with new bookie id * delete the old one. Provide admin tool to rename bookie identifier in Cookies - Key: BOOKKEEPER-773 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch The idea of this JIRA to implement a mechanism to efficiently rename the bookie identifier present in the Cookies. Cookie information will be present in: - ledger journal directories in each Bookie server - cookies znode in ZooKeeper -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (BOOKKEEPER-690) Add state diagram in document
[ https://issues.apache.org/jira/browse/BOOKKEEPER-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-690. -- Resolution: Fixed Created wiki page: https://cwiki.apache.org/confluence/display/BOOKKEEPER/Bookie+Client+State+Transition Thanks Rakesh. Add state diagram in document - Key: BOOKKEEPER-690 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-690 Project: Bookkeeper Issue Type: Task Components: bookkeeper-client Reporter: Sijie Guo Assignee: Rakesh R Priority: Minor Fix For: 4.3.0 Attachments: BookieClient connection state transitions.docx, Screen Shot 2014-07-26 at 11.24.47 PM.png, bookie client state diagram.png Add client state diagram for bookkeeper client in document. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-697) stats collection on bookkeeper server
[
https://issues.apache.org/jira/browse/BOOKKEEPER-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078060#comment-14078060
]
Sijie Guo commented on BOOKKEEPER-697:
--
{code}
I'm not sure what's going on with the use of NullStatsLogger in some
constructors.
{code}
The constructors with NullStatsLogger.INSTANCE are mostly for test cases. So I
don't need to check a lot of places in test cases due to constructor signature
changes. The server will construct with a StatsLogger instantiated by
StatsProvider (see #main function in BookieServer).
{code}
but a different test case. It doesn't like this patch is causing it, so the
tests might be a bit unstable with the recent changes
{code}
what test cases you observed? is it ReadOnlyBookieTest : BOOKKEEPER-774 ? or
MultipleThread**Test?
stats collection on bookkeeper server
-
Key: BOOKKEEPER-697
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-697
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Aniruddha
Fix For: 4.3.0
Attachments: BOOKKEEPER-697.patch
Stats collection on bookkeeper server.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (BOOKKEEPER-690) Add state diagram in document
[ https://issues.apache.org/jira/browse/BOOKKEEPER-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-690: - Attachment: Screen Shot 2014-07-26 at 11.24.47 PM.png [~fpj] this is what I encountered trying to create a page. do you know who I should contact for helps? Add state diagram in document - Key: BOOKKEEPER-690 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-690 Project: Bookkeeper Issue Type: Task Components: bookkeeper-client Reporter: Sijie Guo Assignee: Rakesh R Priority: Minor Fix For: 4.3.0 Attachments: BookieClient connection state transitions.docx, Screen Shot 2014-07-26 at 11.24.47 PM.png, bookie client state diagram.png Add client state diagram for bookkeeper client in document. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (BOOKKEEPER-697) stats collection on bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-697: - Attachment: BOOKKEEPER-697.patch attach a patch for adding stats for bookie server. stats collection on bookkeeper server - Key: BOOKKEEPER-697 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-697 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Sijie Guo Assignee: Aniruddha Fix For: 4.3.0 Attachments: BOOKKEEPER-697.patch Stats collection on bookkeeper server. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (BOOKKEEPER-681) gather statistics for fileinfo eviction,
[ https://issues.apache.org/jira/browse/BOOKKEEPER-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-681. -- Resolution: Won't Fix gather statistics for fileinfo eviction, - Key: BOOKKEEPER-681 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-681 Project: Bookkeeper Issue Type: Bug Reporter: Ivan Kelly Fix For: 4.3.0 So that we can see when we're using too many file handles. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-736: - Summary: Stats for AutoRecovery (was: JMX support for AutoRecovery) Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075882#comment-14075882 ] Sijie Guo commented on BOOKKEEPER-736: -- change the title to 'Stats for AutoRecovery' since we don't encourage user to add JMX beans directly, adding stats should use bookkeeper-stats library. Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (BOOKKEEPER-738) Provide jmx bean registration mechanism
[ https://issues.apache.org/jira/browse/BOOKKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-738. -- Resolution: Won't Fix Assignee: (was: Rakesh R) close the ticket since we don't encourage user to add JMX beans directly, adding stats should use bookkeeper-stats library. Provide jmx bean registration mechanism --- Key: BOOKKEEPER-738 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-738 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-auto-recovery Reporter: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-738-AutoRecovery-Registry.patch This JIRA to discuss the way to do the registration of the exposed beans in the autorecovery module. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (BOOKKEEPER-737) Define JMX beans for the autorecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-737. -- Resolution: Won't Fix Assignee: (was: Rakesh R) close the ticket since we don't encourage user to add JMX beans directly, adding stats should use bookkeeper-stats library. Define JMX beans for the autorecovery - Key: BOOKKEEPER-737 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-737 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-auto-recovery Reporter: Rakesh R Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-737-AutoRecovery-JMXBeans.patch Users are interested to know the auto ledger rereplication details. Expose useful beans like numUrLedgers, numRereplicatedLedgers, failedRereplication attempts, auditor details et. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-736: - Attachment: BOOKKEEPER-736.patch attach a patch to add stats for auto recovery. Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Rakesh R Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (BOOKKEEPER-736) Stats for AutoRecovery
[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075896#comment-14075896 ] Sijie Guo commented on BOOKKEEPER-736: -- the patch is generated based on BOOKKEEPER-697. Stats for AutoRecovery -- Key: BOOKKEEPER-736 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 Project: Bookkeeper Issue Type: New Feature Components: bookkeeper-auto-recovery Reporter: Rakesh R Assignee: Sijie Guo Fix For: 4.3.0 Attachments: BOOKKEEPER-736.patch, Prototype-JMX-beans-for-standalone-autorecovery-process.png Idea of this JIRA is to provide jmx interfaces to get the statistics of the auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (BOOKKEEPER-49) bookkeeper - parallel async read same entry of same ledger will fail
[ https://issues.apache.org/jira/browse/BOOKKEEPER-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-49. - Resolution: Won't Fix after moving to protobuf in BOOKKEEPER-582, we used txn id to track requests. this issue will not exist anymore. so close it as 'Won't Fix' bookkeeper - parallel async read same entry of same ledger will fail Key: BOOKKEEPER-49 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-49 Project: Bookkeeper Issue Type: Bug Components: bookkeeper-client Affects Versions: 4.0.0, 4.1.0 Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 4.3.0 Attachments: 0001-BOOKKEEPER-49-bookkeeper-parallel-async-read-same-en.patch all ledgers shared a PerChannelBookieClient. PerChannelBookieClient put all the read requests in a ConcurrentHashMapCompletionKey, ReadCompletion map called readCompletions, which is indexed by CompletionKey. If two read requests have same entryId and same ledgerId, they have the same CompletionKey, the latter one will overwrite the previous one. So a read request's callback will not be invoked. we may need to chain the callbacks for same completion keys. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (BOOKKEEPER-587) Make BK use protobufs on the wire
[ https://issues.apache.org/jira/browse/BOOKKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo resolved BOOKKEEPER-587. -- Resolution: Implemented the wire part is also in BOOKKEEPER-582. Make BK use protobufs on the wire - Key: BOOKKEEPER-587 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-587 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Ivan Kelly Assignee: Ivan Kelly Fix For: 4.3.0 Attachments: 0003-BOOKKEEPER-587-Make-BK-use-protobufs-on-the-wire.-Bu.patch Building on BOOKKEEPER-582, make bookkeeper use protobufs for on wire transmission. -- This message was sent by Atlassian JIRA (v6.2#6252)
