Re: Issue 1806 in lilypond: Wrong search for translated docs
Updates: Labels: -Priority-High Comment #7 on issue 1806 by pkx1...@gmail.com: Wrong search for translated docs http://code.google.com/p/lilypond/issues/detail?id=1806 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1806 in lilypond: Wrong search for translated docs
Comment #6 on issue 1806 by philehol...@googlemail.com: Wrong search for translated docs http://code.google.com/p/lilypond/issues/detail?id=1806 No - that's for a separate enhancement - adding an extra search box so that users can choose to search the docs or the site, which is not currently possible. This enhancement would complement that. Currently, we need ten separate versions of search-box.ihtml - one for each language. The only difference between them is the word "search"; "suche", etc. My proposal implements a little bit of Javascript that detects the page language as it loads, and changes the value of the search box to an appropriate one for the page. There's then no customisation needed and only one search-box.ihtml. This would make updating the search box much easier. I've not made a patch yet, because of the complex way the html is built, but an illustrative example is at http://www.holmessoft.co.uk/homepage/lilypond/WebLang/ Please let me know what you think. (P.S. the "search" words aren't the properly translated ones - I need to get them later). ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1806 in lilypond: Wrong search for translated docs
Comment #5 on issue 1806 by janek.li...@gmail.com: Wrong search for translated docs http://code.google.com/p/lilypond/issues/detail?id=1806 As i understand, patch is here: http://codereview.appspot.com/4894053/ ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1806 in lilypond: Wrong search for translated docs
Comment #4 on issue 1806 by percival.music.ca: Wrong search for translated docs http://code.google.com/p/lilypond/issues/detail?id=1806 We need to see a patch eventually. My criteria for LGTM is whether it doesn't screw up anything else. I'm not going to test searching in other languages; somebody else can play with that. I just want to make sure that it doesn't break anything that's currently working. Looking at an example on your website won't convince me of anything; the only way to convince me that it doesn't break stuff is to upload the patch and I'll test it myself. That said, people who are interested in languages may well appreciate having some pages they can test. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1806 in lilypond: Wrong search for translated docs
Comment #3 on issue 1806 by philehol...@googlemail.com: Wrong search for translated docs http://code.google.com/p/lilypond/issues/detail?id=1806 I've now done some javascript stuff that extracts the language from the page name and automatically sets the text in the search box to be appropriate for the page language. I could put up a patch, but with the risk that it wouldn't be obvious how it works and would take time to test. Alternatively, I could put up a few pages on my own website that show this in action. Any preferences? ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1806 in lilypond: Wrong search for translated docs
- Original Message - From: "Jean-Charles Malahieude" To: "Lily Bugs" ; "Phil Holmes" Sent: Monday, August 08, 2011 1:10 PM Subject: Re: Issue 1806 in lilypond: Wrong search for translated docs Quoting Phil: Where there is no language specific search box (e.g. cs) I assume the root version is used. This was updated by Graham. Some of the other search boxes were updated (e.g. es) but most were not. This would be quite quick to fix manually, but it would seem worth adding the other change suggested in 1171 at the same time - use site:lilypond.org/doc/v2.14 as the restriction, rather than forcing +2.14 as part of the search term. I'm just unable to figure it out, but would it be possible to "feed" those .ihtml in the same way as the other pages with what is in VERSION during the build process? Wee wouldn't then have to care about it. I'll correct the French version this afternoon. Cheers, Jean-Charles http://code.google.com/p/lilypond/issues/detail?id=1171 -- Phil Holmes ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1806 in lilypond: Wrong search for translated docs
Quoting Phil: Where there is no language specific search box (e.g. cs) I assume the root version is used. This was updated by Graham. Some of the other search boxes were updated (e.g. es) but most were not. This would be quite quick to fix manually, but it would seem worth adding the other change suggested in 1171 at the same time - use site:lilypond.org/doc/v2.14 as the restriction, rather than forcing +2.14 as part of the search term. I'm just unable to figure it out, but would it be possible to "feed" those .ihtml in the same way as the other pages with what is in VERSION during the build process? Wee wouldn't then have to care about it. I'll correct the French version this afternoon. Cheers, Jean-Charles ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1806 in lilypond: Wrong search for translated docs
Updates: Owner: philehol...@googlemail.com Comment #2 on issue 1806 by philehol...@googlemail.com: Wrong search for translated docs http://code.google.com/p/lilypond/issues/detail?id=1806 (No comment was entered for this change.) ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
Re: Issue 1806 in lilypond: Wrong search for translated docs
Updates: Status: Started Comment #1 on issue 1806 by philehol...@googlemail.com: Wrong search for translated docs http://code.google.com/p/lilypond/issues/detail?id=1806 Here's the answer: phil@phil-lily:~/lilypond-git$ locate 'search-box.ihtml' /home/phil/lilypond-git/Documentation/search-box.ihtml /home/phil/lilypond-git/Documentation/de/search-box.ihtml /home/phil/lilypond-git/Documentation/es/search-box.ihtml /home/phil/lilypond-git/Documentation/fr/search-box.ihtml /home/phil/lilypond-git/Documentation/hu/search-box.ihtml /home/phil/lilypond-git/Documentation/it/search-box.ihtml /home/phil/lilypond-git/Documentation/nl/search-box.ihtml /home/phil/lilypond-git/Documentation/zh/search-box.ihtml Where there is no language specific search box (e.g. cs) I assume the root version is used. This was updated by Graham. Some of the other search boxes were updated (e.g. es) but most were not. This would be quite quick to fix manually, but it would seem worth adding the other change suggested in 1171 at the same time - use site:lilypond.org/doc/v2.14 as the restriction, rather than forcing +2.14 as part of the search term. ___ bug-lilypond mailing list bug-lilypond@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond
