Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v11]
On Mon, 28 Sep 2020 19:53:37 GMT, Monica Beckwith wrote: >> This is a continuation of >> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html >> >> Changes since then: >> * We've improved the write barrier as suggested by Andrew [1] >> * The define-guards around R18 have been changed to `R18_RESERVED`. This >> will be enabled for Windows only for now but >> will be required for the upcoming macOS+Aarch64 [2] port as well. >> * We've incorporated https://github.com/openjdk/jdk/pull/154 by @AntonKozlov >> in our PR for now and built the >> Windows-specific CPU feature detection on top of it. >> >> [1] >> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009597.html >> [2] https://openjdk.java.net/jeps/8251280 > > Monica Beckwith has updated the pull request incrementally with one > additional commit since the last revision: > > r18 only on Linux Marked as reviewed by dholmes (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/212
Integrated: 8248984: Bump minimum boot jdk to JDK 15
On Wed, 23 Sep 2020 22:32:37 GMT, Mikael Vidstedt wrote: > JDK 15 is now GA. The minimum boot JDK version for mainline/JDK 16 should be > bumped to this version. > > Testing: tier1-5 passed with a slightly earlier version of this change. > Re-running tier1 now for good luck. This pull request has now been integrated. Changeset: 527b0e44 Author:Mikael Vidstedt URL: https://git.openjdk.java.net/jdk/commit/527b0e44 Stats: 18 lines in 2 files changed: 0 ins; 13 del; 5 mod 8248984: Bump minimum boot jdk to JDK 15 Reviewed-by: darcy, erikj, dholmes - PR: https://git.openjdk.java.net/jdk/pull/326
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v11]
> This is a continuation of > https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html > > Changes since then: > * We've improved the write barrier as suggested by Andrew [1] > * The define-guards around R18 have been changed to `R18_RESERVED`. This will > be enabled for Windows only for now but > will be required for the upcoming macOS+Aarch64 [2] port as well. > * We've incorporated https://github.com/openjdk/jdk/pull/154 by @AntonKozlov > in our PR for now and built the > Windows-specific CPU feature detection on top of it. > > [1] > https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009597.html > [2] https://openjdk.java.net/jeps/8251280 Monica Beckwith has updated the pull request incrementally with one additional commit since the last revision: r18 only on Linux - Changes: - all: https://git.openjdk.java.net/jdk/pull/212/files - new: https://git.openjdk.java.net/jdk/pull/212/files/a7cdaad6..398d7645 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=212&range=10 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=212&range=09-10 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/212.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/212/head:pull/212 PR: https://git.openjdk.java.net/jdk/pull/212
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v10]
On Mon, 28 Sep 2020 19:38:15 GMT, Bernhard Urban-Forster
wrote:
>> this looks better I think, if it's done right from beginning, we won't have
>> to modify it later.
>> The Question is, can we do it ahead of JEP-391 ?
>> If we can't then maybe better to leave it this way for now:
>> WIN64_ONLY("rtls") NOT_WIN64("r18")
>>
>> as r18 is supposed to be reserved register on aarch64, linux is just an
>> exception where it's allowed.
>
> Let us go with the following in this PR as that's the extend of this PR:
> Suggestion:
>
> "r17", LINUX_ONLY("r18") WIN64_ONLY("rtls"), "r19",
> We can update it accordingly in a PR for JEP-391.
Ok, Great.
-
PR: https://git.openjdk.java.net/jdk/pull/212
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v10]
On Mon, 28 Sep 2020 19:28:10 GMT, Vladimir Kempik wrote:
>> The idea is that the naming should suggest that `r18` shouldn't be used on
>> that particular platform. Same is true for
>> macOS, but the ABI docs suggest a different usage, hence we have something
>> like that in our internal branch for macOS:
>> Suggestion:
>> "r17", NOT_R18_RESERVED("r18") WIN64_ONLY("rtls")
>> MACOS_ONLY("rplatform"), "r19",
>> Are you suggesting it should rather be something like this eventually?
>> Suggestion:
>>
>> "r17", LINUX_ONLY("r18") WIN64_ONLY("rtls") MACOS_ONLY("rplatform"),
>> "r19",
>
> this looks better I think, if it's done right from beginning, we won't have
> to modify it later.
> The Question is, can we do it ahead of JEP-391 ?
> If we can't then maybe better to leave it this way for now:
> WIN64_ONLY("rtls") NOT_WIN64("r18")
>
> as r18 is supposed to be reserved register on aarch64, linux is just an
> exception where it's allowed.
Let us go with the following in this PR as that's the extend of this PR:
Suggestion:
"r17", LINUX_ONLY("r18") WIN64_ONLY("rtls"), "r19",
We can update it accordingly in a PR for JEP-391.
-
PR: https://git.openjdk.java.net/jdk/pull/212
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v10]
On Mon, 28 Sep 2020 19:09:17 GMT, Bernhard Urban-Forster
wrote:
>> src/hotspot/cpu/aarch64/register_aarch64.cpp line 44:
>>
>>> 42: "rscratch1", "rscratch2",
>>> 43: "r10", "r11", "r12", "r13", "r14", "r15", "r16",
>>> 44: "r17", NOT_R18_RESERVED("r18") WIN64_ONLY("rtls"), "r19",
>>
>> For me this line doesn't look good in case of expanding this functionality
>> to macos-aarch64
>> as it's just the name of register and it's r18 on every platform except
>> WIN64 and has nothing to do with reserving r18.
>
> The idea is that the naming should suggest that `r18` shouldn't be used on
> that particular platform. Same is true for
> macOS, but the ABI docs suggest a different usage, hence we have something
> like that in our internal branch for macOS:
> Suggestion:
> "r17", NOT_R18_RESERVED("r18") WIN64_ONLY("rtls")
> MACOS_ONLY("rplatform"), "r19",
> Are you suggesting it should rather be something like this eventually?
> Suggestion:
>
> "r17", LINUX_ONLY("r18") WIN64_ONLY("rtls") MACOS_ONLY("rplatform"),
> "r19",
this looks better I think, if it's done right from beginning, we won't have to
modify it later.
The Question is, can we do it ahead of JEP-391 ?
If we can't then maybe better to leave it this way for now:
WIN64_ONLY("rtls") NOT_WIN64("r18")
as r18 is supposed to be reserved register on aarch64, linux is just an
exception where it's allowed.
-
PR: https://git.openjdk.java.net/jdk/pull/212
Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package [v5]
On Wed, 23 Sep 2020 22:47:47 GMT, Vladimir Kozlov wrote: >> Marked as reviewed by egahlin (Reviewer). > > @marschall I will sponsor it after you integrate the latest update. @vnkozlov done, I hope I now made it correctly with a merge commit for the latest merge conflict - PR: https://git.openjdk.java.net/jdk/pull/45
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v10]
On Mon, 28 Sep 2020 17:37:32 GMT, Vladimir Kempik wrote:
>> Monica Beckwith has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains 24 commits:
>> - Merge remote-tracking branch 'upstream/master' into jdk-windows
>> - SA: update copyright
>> - Fix graal codestyle
>> - Reduce includes
>> - Merge remote-tracking branch 'upstream/master' into jdk-windows
>> - os_windows: remove duplicated UMA handling
>> - test_safefetch{32,N} works fine on win+aarch64
>> - cleanup for 8253539: Remove unused JavaThread functions for
>> set_last_Java_fp/pc
>> - cleanup for 8253457: Remove unimplemented register stack functions
>> - Merge remote-tracking branch 'upstream/master' into jdk-windows
>> - ... and 14 more:
>> https://git.openjdk.java.net/jdk/compare/ec9bee68...a7cdaad6
>
> src/hotspot/cpu/aarch64/register_aarch64.cpp line 44:
>
>> 42: "rscratch1", "rscratch2",
>> 43: "r10", "r11", "r12", "r13", "r14", "r15", "r16",
>> 44: "r17", NOT_R18_RESERVED("r18") WIN64_ONLY("rtls"), "r19",
>
> For me this line doesn't look good in case of expanding this functionality to
> macos-aarch64
> as it's just the name of register and it's r18 on every platform except WIN64
> and has nothing to do with reserving r18.
The idea is that the naming should suggest that `r18` shouldn't be used on that
particular platform. Same is true for
macOS, but the ABI docs suggest a different usage, hence we have something like
that in our internal branch for macOS:
Suggestion:
"r17", NOT_R18_RESERVED("r18") WIN64_ONLY("rtls") MACOS_ONLY("rplatform"),
"r19",
Are you suggesting it should rather be something like this eventually?
Suggestion:
"r17", LINUX_ONLY("r18") WIN64_ONLY("rtls") MACOS_ONLY("rplatform"), "r19",
-
PR: https://git.openjdk.java.net/jdk/pull/212
Integrated: 8253616: Change to GCC 10.2 for building on Linux at Oracle
On Thu, 24 Sep 2020 21:31:49 GMT, Mikael Vidstedt wrote: > Please review this change which updates the defaults in the linux devkit > creator, the doc/building.md file, and the JIB > (Oracle) configuration to gcc 10.2. This pull request has now been integrated. Changeset: d25b03e9 Author:Mikael Vidstedt URL: https://git.openjdk.java.net/jdk/commit/d25b03e9 Stats: 33 lines in 4 files changed: 20 ins; 0 del; 13 mod 8253616: Change to GCC 10.2 for building on Linux at Oracle Reviewed-by: erikj - PR: https://git.openjdk.java.net/jdk/pull/349
Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v3]
On Fri, 25 Sep 2020 21:45:13 GMT, Ioi Lam wrote: >> Yumin Qi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8247536: Support for pre-generated java.lang.invoke classes in CDS static >> archive > > test/hotspot/jtreg/runtime/cds/appcds/DumpClassListWithLF.java line 32: > >> 30: * @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds >> 31: * @compile ClassListFormatBase.java test-classes/Hello.java >> 32: * @run driver DumpClassListWithLF > > The `@compile` line can be removed to speed up the test execution. You can > add this: > > @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds/test-classes > > and also change the code below > > appJar, classlist( > -"Hello", > +Hello.class.getName(), > > (There's no need for `/test/hotspot/jtreg/runtime/cds/appcds` in `@library` > because that's the current directory of > this test). I tried using @library and passed local tests, but it failed mach5 for complaining no file Hello.class found from path. - PR: https://git.openjdk.java.net/jdk/pull/193
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v10]
On Mon, 28 Sep 2020 14:07:16 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18 have been changed to `R18_RESERVED`. This
>> will be enabled for Windows only for now but
>> will be required for the upcoming macOS+Aarch64 [2] port as well.
>> * We've incorporated https://github.com/openjdk/jdk/pull/154 by @AntonKozlov
>> in our PR for now and built the
>> Windows-specific CPU feature detection on top of it.
>>
>> [1]
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009597.html
>> [2] https://openjdk.java.net/jeps/8251280
>
> Monica Beckwith has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now
> contains 24 commits:
> - Merge remote-tracking branch 'upstream/master' into jdk-windows
> - SA: update copyright
> - Fix graal codestyle
> - Reduce includes
> - Merge remote-tracking branch 'upstream/master' into jdk-windows
> - os_windows: remove duplicated UMA handling
> - test_safefetch{32,N} works fine on win+aarch64
> - cleanup for 8253539: Remove unused JavaThread functions for
> set_last_Java_fp/pc
> - cleanup for 8253457: Remove unimplemented register stack functions
> - Merge remote-tracking branch 'upstream/master' into jdk-windows
> - ... and 14 more:
> https://git.openjdk.java.net/jdk/compare/ec9bee68...a7cdaad6
src/hotspot/cpu/aarch64/register_aarch64.cpp line 44:
> 42: "rscratch1", "rscratch2",
> 43: "r10", "r11", "r12", "r13", "r14", "r15", "r16",
> 44: "r17", NOT_R18_RESERVED("r18") WIN64_ONLY("rtls"), "r19",
For me this line doesn't look good in case of expanding this functionality to
macos-aarch64
as it's just the name of register and it's r18 on every platform except WIN64
and has nothing to do with reserving r18.
-
PR: https://git.openjdk.java.net/jdk/pull/212
Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive [v6]
> This patch is reorganized after 8252725, which is separated from this patch > to refactor jlink glugin code. The previous > webrev with hg can be found at: > http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 > integrated, the > regeneration of holder classes is simply to call the new added > GenerateJLIClassesHelper.cdsGenerateHolderClasses > function. Tests: tier1-4 Yumin Qi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - In case of exception happens during reloading class, CHECK will return without free the allocated buffer for class bytes so moved the buffer allocation and freeing to caller. Also removed test 6 since there is not guarantee that we can give a signature which will always fail. Additional changes to GenerateJLIClassesHelper according to review suggestion. - Merge branch 'master' of https://github.com/openjdk/jdk into jdk-8247536 - Merge branch 'master' of https://git.openjdk.java.net/jdk into jdk-8247536 - 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive - 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive - 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive - Merge branch 'master' into jdk-8247536 - Merge branch 'master' of https://github.com/openjdk/jdk - Merge branch 'master' of https://github.com/openjdk/jdk - 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive - ... and 6 more: https://git.openjdk.java.net/jdk/compare/1ae6b533...9ab52116 - Changes: https://git.openjdk.java.net/jdk/pull/193/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=193&range=05 Stats: 457 lines in 21 files changed: 433 ins; 13 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/193.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/193/head:pull/193 PR: https://git.openjdk.java.net/jdk/pull/193
Re: RFR: 8253616: Change to GCC 10.2 for building on Linux at Oracle [v2]
> Please review this change which updates the defaults in the linux devkit > creator, the doc/building.md file, and the JIB > (Oracle) configuration to gcc 10.2. Mikael Vidstedt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge - 8253616: Change to GCC 10.2 for building on Linux at Oracle - Changes: https://git.openjdk.java.net/jdk/pull/349/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=349&range=01 Stats: 33 lines in 4 files changed: 20 ins; 0 del; 13 mod Patch: https://git.openjdk.java.net/jdk/pull/349.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/349/head:pull/349 PR: https://git.openjdk.java.net/jdk/pull/349
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v10]
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for Windows only for now but
> will be required for the upcoming macOS+Aarch64 [2] port as well.
> * We've incorporated https://github.com/openjdk/jdk/pull/154 by @AntonKozlov
> in our PR for now and built the
> Windows-specific CPU feature detection on top of it.
>
> [1]
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009597.html
> [2] https://openjdk.java.net/jeps/8251280
Monica Beckwith has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
contains 24 commits:
- Merge remote-tracking branch 'upstream/master' into jdk-windows
- SA: update copyright
- Fix graal codestyle
- Reduce includes
- Merge remote-tracking branch 'upstream/master' into jdk-windows
- os_windows: remove duplicated UMA handling
- test_safefetch{32,N} works fine on win+aarch64
- cleanup for 8253539: Remove unused JavaThread functions for
set_last_Java_fp/pc
- cleanup for 8253457: Remove unimplemented register stack functions
- Merge remote-tracking branch 'upstream/master' into jdk-windows
- ... and 14 more: https://git.openjdk.java.net/jdk/compare/ec9bee68...a7cdaad6
-
Changes: https://git.openjdk.java.net/jdk/pull/212/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=212&range=09
Stats: 2566 lines in 62 files changed: 2208 ins; 126 del; 232 mod
Patch: https://git.openjdk.java.net/jdk/pull/212.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/212/head:pull/212
PR: https://git.openjdk.java.net/jdk/pull/212
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v9]
> This is a continuation of > https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html > > Changes since then: > * We've improved the write barrier as suggested by Andrew [1] > * The define-guards around R18 have been changed to `R18_RESERVED`. This will > be enabled for Windows only for now but > will be required for the upcoming macOS+Aarch64 [2] port as well. > * We've incorporated https://github.com/openjdk/jdk/pull/154 by @AntonKozlov > in our PR for now and built the > Windows-specific CPU feature detection on top of it. > > [1] > https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009597.html > [2] https://openjdk.java.net/jeps/8251280 Monica Beckwith has updated the pull request incrementally with one additional commit since the last revision: SA: update copyright - Changes: - all: https://git.openjdk.java.net/jdk/pull/212/files - new: https://git.openjdk.java.net/jdk/pull/212/files/275a0b7f..23b209db Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=212&range=08 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=212&range=07-08 Stats: 5 lines in 5 files changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/212.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/212/head:pull/212 PR: https://git.openjdk.java.net/jdk/pull/212
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v6]
On Thu, 24 Sep 2020 15:43:10 GMT, Chris Plummer wrote: >> Monica Beckwith has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains 17 additional commits since >> the last revision: >> - cleanup for 8253539: Remove unused JavaThread functions for >> set_last_Java_fp/pc >> - cleanup for 8253457: Remove unimplemented register stack functions >> - Merge remote-tracking branch 'upstream/master' into jdk-windows >> - Update orderAccess_windows_aarch64.hpp >> >>changing from Acq-reL to Sequential Consistency to avoid compiler >> reordering when no ordering hints are provided >> - 8248787: G1: Workaround MSVC bug >>Reviewed-by: >>Contributed-by: mbeckwit, luhenry, burban >> - 8248670: Windows: Exception handling support on AArch64 >>Reviewed-by: >>Contributed-by: mbeckwit, luhenry, burban >> - 8248660: AArch64: Make _clear_cache and _nop portable >>Summary: __builtin___clear_cache, etc. >>Contributed-by: mbeckwit, luhenry, burban >> - 8248659: AArch64: Extend CPU Feature detection >>Reviewed-by: >>Contributed-by: mbeckwit, luhenry, burban >> - 8248656: Add Windows AArch64 platform support code >>Reviewed-by: >>Contributed-by: mbeckwit, luhenry, burban >> - 8248498: Add build system support for Windows AArch64 >>Reviewed-by: >>Contributed-by: mbeckwit, luhenry, burban >> - ... and 7 more: >> https://git.openjdk.java.net/jdk/compare/451890eb...2b662010 > > I looked at changes to existing SA files. These changes look fine. > > I did not look at the new aarch64 SA files other than the copyright section. > I assume they are clones of the x64 > versions with some symbolic renaming. If there is any more than that and > you'd like me to have a look, let me know. > As for the copyright in the new SA files, I believe it is incorrect and needs > to include Oracle. There are a number of > other non-SA files that are new and also have the same copyright issue. > I also looked at > src/jdk.attach/windows/classes/sun/tools/attach/AttachProviderImpl.java. It > looks fine except it needs > a copyright date update. @plummercj thank you for your feedback. I've updated the copyright in mentioned files. - PR: https://git.openjdk.java.net/jdk/pull/212
Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v8]
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for Windows only for now but
> will be required for the upcoming macOS+Aarch64 [2] port as well.
> * We've incorporated https://github.com/openjdk/jdk/pull/154 by @AntonKozlov
> in our PR for now and built the
> Windows-specific CPU feature detection on top of it.
>
> [1]
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009597.html
> [2] https://openjdk.java.net/jeps/8251280
Monica Beckwith has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
excludes the unrelated changes brought in by the merge/rebase. The pull request
contains 22 additional commits since
the last revision:
- Fix graal codestyle
- Reduce includes
- Merge remote-tracking branch 'upstream/master' into jdk-windows
- os_windows: remove duplicated UMA handling
- test_safefetch{32,N} works fine on win+aarch64
- cleanup for 8253539: Remove unused JavaThread functions for
set_last_Java_fp/pc
- cleanup for 8253457: Remove unimplemented register stack functions
- Merge remote-tracking branch 'upstream/master' into jdk-windows
- Update orderAccess_windows_aarch64.hpp
changing from Acq-reL to Sequential Consistency to avoid compiler reordering
when no ordering hints are provided
- 8248787: G1: Workaround MSVC bug
Reviewed-by:
Contributed-by: mbeckwit, luhenry, burban
- ... and 12 more: https://git.openjdk.java.net/jdk/compare/4dd32e55...275a0b7f
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/212/files
- new: https://git.openjdk.java.net/jdk/pull/212/files/68f61d60..275a0b7f
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=212&range=07
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=212&range=06-07
Stats: 25771 lines in 386 files changed: 3908 ins; 20954 del; 909 mod
Patch: https://git.openjdk.java.net/jdk/pull/212.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/212/head:pull/212
PR: https://git.openjdk.java.net/jdk/pull/212
Re: RFR: 8253424: Add support for running pre-submit testing using GitHub Actions
On 2020-09-23 19:27, Erik Joelsson wrote: The version-numbers file (which is also a shared properties style file) is not using quotes for values, which is fine as long as there are no spaces. I believe if you read it as a properties file, you need to strip the quotes if you have them. I prefer if version-numbers and test-dependencies using the same format. I've been away for a while, but now I'm back -- with a royal backlog. :) On a related note, I *really* think we should move the version-numbers file to make/conf. I think I even have an open bug on that somewhere. The move itself is trivial, but the consequences needs to be checked carefully. I'm happy that you put the new test-dependencies file in make/conf, though! /Magnus
Integrated: 8253424: Add support for running pre-submit testing using GitHub Actions
On Mon, 21 Sep 2020 13:32:09 GMT, Robin Westberg wrote: > A few days ago I posted an initial version of the necessary configuration > required to run pre-submit build and tests > for JDK main-line contributions using GitHub Actions [2] and the free tier > [3] available to everyone working with open > source repositories. I've incorporated the feedback into an updated version > that I believe is ready to be integrated. > If this is integrated into the `master` branch, future branches created and > updated in personal forks will build and > run the basic tier 1 tests as described in this configuration, on Linux, > Windows and macOS (all on x64). It's of course > possible for any contributor to opt out fully or partially of these automatic > runs in a few different ways. To opt out > completely, a contributor can simply disable GitHub Actions on their personal > fork, and no further jobs will be > executed. Another option is to add a repository secret [4] with the name > `JDK_SUBMIT_FILTER` set to any value. If this > is set, only branches prefixed with `submit/` will be subject to automatic > build and test. This can also be further > refined by adding a repository secret named `JDK_SUBMIT_PLATFORMS` with a > value such as `Linux x64, Windows x64` to > limit automatic build and test to these two platforms. It will still be > possible to run the tests on any branch and/or > platform by manually triggering the workflow. To see what this looks like in > practice, an example run can be found > here: https://github.com/rwestberg/jdk/actions/runs/265131985 (note that > there is currently a failing test on Windows > which is tracked by JDK-8249095, which should probably be resolved before > this change is integrated). Best regards, > Robin [1] > https://mail.openjdk.java.net/pipermail/jdk-dev/2020-September/004736.html [2] > https://github.com/features/actions [3] > https://docs.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits > [4] > https://docs.github.com/en/actions/reference/encrypted-secrets This pull request has now been integrated. Changeset: 840aa2b7 Author:Robin Westberg URL: https://git.openjdk.java.net/jdk/commit/840aa2b7 Stats: 904 lines in 2 files changed: 904 ins; 0 del; 0 mod 8253424: Add support for running pre-submit testing using GitHub Actions Reviewed-by: ehelin, erikj - PR: https://git.openjdk.java.net/jdk/pull/284
