from:"Andy Herrick"

Re: RFR: 8277429: Conflicting jpackage static library name

2021-11-20 Thread Andy Herrick

On Sat, 20 Nov 2021 03:26:51 GMT, Alexey Semenyuk  wrote:

> 8277429: Conflicting jpackage static library name

Marked as reviewed by herrick (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/6485

Integrated: JDK-8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App Store.

2021-03-24 Thread Andy Herrick

On Wed, 24 Mar 2021 11:00:53 GMT, Andy Herrick  wrote:

> Restoring fix to JDK-8248904: Add support to jpackage for the Mac App Store.

This pull request has now been integrated.

Changeset: deda80f0
Author:    Andy Herrick 
URL:   https://git.openjdk.java.net/jdk/commit/deda80f0
Stats: 296 lines in 22 files changed: 189 ins; 43 del; 64 mod

8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App Store.

Co-authored-by: Erwin Morrhey 
Reviewed-by: kcr, asemenyuk

-

PR: https://git.openjdk.java.net/jdk/pull/3172

RFR: JDK-8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App Store.

2021-03-24 Thread Andy Herrick

Restoring fix to JDK-8248904: Add support to jpackage for the Mac App Store.

-

Commit messages:
 - JDK-8264057: [redo] JDK-8248904: Add support to jpackage for the Mac App 
Store.

Changes: https://git.openjdk.java.net/jdk/pull/3172/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3172=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8264057
  Stats: 296 lines in 22 files changed: 189 ins; 43 del; 64 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3172.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3172/head:pull/3172

PR: https://git.openjdk.java.net/jdk/pull/3172

Re: RFR: 8254702: jpackage app launcher crashes on CentOS [v6]

2021-02-05 Thread Andy Herrick

On Fri, 5 Feb 2021 17:44:21 GMT, Alexey Semenyuk  wrote:

>> Fix for https://bugs.openjdk.java.net/browse/JDK-8254702
>> 
>> The fix splits Linux app launcher in app launcher and launcher shared lib. 
>> App launcher is pure C and doesn't have C++ code. App launcher lib 
>> incorporates bulk of C++ code from app launcher. 
>> At startup app launcher loads launcher shared lib and calls functions it 
>> provides to get data for launching JVM (path to jli lib and arguments for 
>> JLI_Launch function call).
>> App launcher unloads launcher shared lib before launching JVM to remove C++ 
>> runtime from the process memory.
>> 
>> Getting rid of C++ code from app launcher required to rewrite app 
>> installation location lookup code from C++ to C. LinuxPackage.c source is C 
>> alternative for 
>> https://github.com/openjdk/jdk/blob/master/src/jdk.jpackage/linux/native/applauncher/Package.cpp
>>  and 
>> https://github.com/openjdk/jdk/blob/master/src/jdk.jpackage/linux/native/applauncher/Executor.cpp.
>> 
>> Layout of jpackage's native code changed:
>> - `common`: code shared between all jpackage binaries.
>> - `applauncher`: launcher only code.
>> - `applauncherlib`: launcher lib code on Linux and launcher code on other 
>> platforms.
>> - `applaunchercommon`: code shared between launcher and launcher lib on 
>> Linux and launcher code on other platforms.
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8254702: jpackage app launcher crashes on CentOS

looks ok if build team approves

-

Marked as reviewed by herrick (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2320

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

2020-12-08 Thread Andy Herrick

On Tue, 8 Dec 2020 14:56:20 GMT, Andy Herrick  wrote:

>> Looks like test failed due to:
>> [Fatal Error] b.wxl:3:1: XML document structures must start and end within 
>> the same entity.
>> So, I am not sure how increased repeat will help. Do we know why it failed 
>> to parse XML?
>
>> 
>> 
>> Looks like test failed due to:
>> [Fatal Error] b.wxl:3:1: XML document structures must start and end within 
>> the same entity.
>> So, I am not sure how increased repeat will help. Do we know why it failed 
>> to parse XML?
> 
> If you scroll down from that error - you can see that that is the expected 
> error and the return code from jpackage is asserted to be 1, and it is 
> asserted that the resulting WinL10NTest.msi does not exist.
> 
> the @Parameters for "data" cause instance of this test to be run 8 times with 
> different args.  This instances is expected to fail since allWxlFilesValid is 
> false.
> later in the log 
> (https://mach5.us.oracle.com:10060/api/v1/results/mach5-one-jdk-16+26-1740-tier2-20201124-1335-16116386-open_test_jdk_tier2_part2-windows-x64-125-1606226621-1556/log)
>  you can see the timeout, where unpack.bat is run three times with 3 second 
> delay and returns 1618 each time:
> **13:58:30.303] TRACE: exec: Execute [cmd /c 
> .\\test.3563aceb\\unpacked-msi\\unpack.bat](3); discard I/O...
> [13:58:33.469] TRACE: exec: Done. Exit code: 1618
> [13:58:36.492] TRACE: exec: Execute [cmd /c 
> .\\test.3563aceb\\unpacked-msi\\unpack.bat](3); discard I/O...
> [13:58:39.636] TRACE: exec: Done. Exit code: 1618
> [13:58:42.652] TRACE: exec: Execute [cmd /c 
> .\\test.3563aceb\\unpacked-msi\\unpack.bat](3); discard I/O...
> [13:58:45.803] TRACE: exec: Done. Exit code: 1618
> [13:58:48.832] ERROR: Expected [0]. Actual [1618]: Check command [cmd /c 
> .\\test.3563aceb\\unpacked-msi\\unpack.bat](3) exited with 0 code
> [13:58:48.832] [  FAILED  ] WinL10nTest([name=a.wxl; culture=fr, name=b.wxl; 
> culture=fr](length=2), fr;en-us, null).test; checks=17
> [13:58:48.832] [ RUN  ] WinL10nTest([name=a.wxl; culture=fr, name=b.wxl; 
> culture=it, name=c.wxl; culture=fr, name=d.wxl; culture=it](length=4), 
> fr;it;en-us,**
> 
> running unpack.bat with msiexec command in it succeed for one test instance 
> after the expected failure, then got 1618 return on the second test instance 
> after the expected failure with the above timeout.

I converted to draft because somehow merging with master caused a mess - since 
is simple change in one test file I may create a new branch and new pull 
request cleanly again.

-

PR: https://git.openjdk.java.net/jdk/pull/1676

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618 [v2]

2020-12-08 Thread Andy Herrick

> increase retries and timeout increasing in runMsiexecWithRetries

Andy Herrick has updated the pull request incrementally with 18 additional 
commits since the last revision:

 - 8256149: Weird AST structure for incomplete member select
   
   Reviewed-by: vromero
 - 8257194: Add 'foreign linker API' in 'jdk.incubator.foreign' module 
desc/summary
   
   Reviewed-by: jvernee, shade
 - 8257848: -XX:CompileCommand=blackhole,* should be diagnostic
   
   Reviewed-by: vlivanov
 - 8242258: (jrtfs) Path::toUri throws AssertionError for malformed input
   
   Reviewed-by: alanb
 - 8254733: HotSpot Style Guide should permit using range-based for loops
   
   Reviewed-by: dholmes, pliden, jrose, dcubed, iklam, eosterlund, tschatzl, kvn
 - 8253644: C2: assert(skeleton_predicate_has_opaque(iff)) failed: unexpected
   
   Reviewed-by: roland, kvn
 - 8256411: Based anonymous classes have a weird end position
   
   Reviewed-by: vromero
 - 8257813: [redo] C2: Filter type in PhiNode::Value() for induction variables 
of trip-counted integer loops
   
   Reviewed-by: chagedorn, kvn
 - 8257769: Cipher.getParameters() throws NPE for ChaCha20-Poly1305
   
   Reviewed-by: mullan, valeriep
 - 8257855: Example SafeVarargsNotApplicableToRecordAccessors breaks test 
tools/javac/diags/CheckExamples.java
   
   Reviewed-by: jjg
 - ... and 8 more: https://git.openjdk.java.net/jdk/compare/7c4743c5...5d065497

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1676/files
  - new: https://git.openjdk.java.net/jdk/pull/1676/files/7c4743c5..5d065497

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=1676=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1676=00-01

  Stats: 1938 lines in 49 files changed: 1465 ins; 276 del; 197 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1676.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1676/head:pull/1676

PR: https://git.openjdk.java.net/jdk/pull/1676

Integrated: JDK-8252870: Finalize (remove "incubator" from) jpackage

2020-11-04 Thread Andy Herrick

On Tue, 13 Oct 2020 12:51:54 GMT, Andy Herrick  wrote:

> JDK-8252870: Finalize (remove "incubator" from) jpackage

This pull request has now been integrated.

Changeset: 26e7ef78
Author:    Andy Herrick 
URL:   https://git.openjdk.java.net/jdk/commit/26e7ef78
Stats: 1733 lines in 259 files changed: 692 ins; 701 del; 340 mod

8252870: Finalize (remove "incubator" from) jpackage

Reviewed-by: kcr, erikj, almatvee, asemenyuk, prr, ihse

-

PR: https://git.openjdk.java.net/jdk/pull/633

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v6]

2020-11-04 Thread Andy Herrick

> JDK-8252870: Finalize (remove "incubator" from) jpackage

Andy Herrick has updated the pull request with a new target base due to a merge 
or a rebase. The pull request now contains seven commits:

 - Merge branch 'master' into JDK-8252870
 - Merge branch 'master' into JDK-8252870
 - Merge branch master into JDK-8252870
 - Merge branch 'master' into JDK-8252870
 - JDK-8252870: Finalize (remove "incubator" from) jpackage
 - reverting two auto-generated files, and changing module-info to "@since 
16"
 - JDK-8252870: Finalize (remove "incubator" from) jpackage
   Merge branch 'finalize' into JDK-8252870
 - 8252869 Finalize (remove incubator from) jpackage (implementation)

-

Changes: https://git.openjdk.java.net/jdk/pull/633/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=633=05
  Stats: 1733 lines in 259 files changed: 692 ins; 701 del; 340 mod
  Patch: https://git.openjdk.java.net/jdk/pull/633.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/633/head:pull/633

PR: https://git.openjdk.java.net/jdk/pull/633

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v5]

2020-10-31 Thread Andy Herrick

> JDK-8252870: Finalize (remove "incubator" from) jpackage

Andy Herrick has updated the pull request with a new target base due to a merge 
or a rebase. The pull request now contains six commits:

 - Merge branch 'master' into JDK-8252870
 - Merge branch master into JDK-8252870
 - Merge branch 'master' into JDK-8252870
 - JDK-8252870: Finalize (remove "incubator" from) jpackage
 - reverting two auto-generated files, and changing module-info to "@since 
16"
 - JDK-8252870: Finalize (remove "incubator" from) jpackage
   Merge branch 'finalize' into JDK-8252870
 - 8252869 Finalize (remove incubator from) jpackage (implementation)

-

Changes: https://git.openjdk.java.net/jdk/pull/633/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=633=04
  Stats: 1733 lines in 259 files changed: 692 ins; 701 del; 340 mod
  Patch: https://git.openjdk.java.net/jdk/pull/633.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/633/head:pull/633

PR: https://git.openjdk.java.net/jdk/pull/633

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v4]

2020-10-21 Thread Andy Herrick

> JDK-8252870: Finalize (remove "incubator" from) jpackage

Andy Herrick has updated the pull request with a new target base due to a merge 
or a rebase. The pull request now contains five commits:

 - Merge branch master into JDK-8252870
 - Merge branch 'master' into JDK-8252870
 - JDK-8252870: Finalize (remove "incubator" from) jpackage
 - reverting two auto-generated files, and changing module-info to "@since 
16"
 - JDK-8252870: Finalize (remove "incubator" from) jpackage
   Merge branch 'finalize' into JDK-8252870
 - 8252869 Finalize (remove incubator from) jpackage (implementation)

-

Changes: https://git.openjdk.java.net/jdk/pull/633/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=633=03
  Stats: 1733 lines in 259 files changed: 692 ins; 701 del; 340 mod
  Patch: https://git.openjdk.java.net/jdk/pull/633.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/633/head:pull/633

PR: https://git.openjdk.java.net/jdk/pull/633

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v3]

2020-10-15 Thread Andy Herrick

> JDK-8252870: Finalize (remove "incubator" from) jpackage

Andy Herrick has updated the pull request with a new target base due to a merge 
or a rebase. The pull request now
contains four commits:

 - Merge branch 'master' into JDK-8252870
 - JDK-8252870: Finalize (remove "incubator" from) jpackage
 - reverting two auto-generated files, and changing module-info to "@since 
16"
 - JDK-8252870: Finalize (remove "incubator" from) jpackage
   Merge branch 'finalize' into JDK-8252870
 - 8252869 Finalize (remove incubator from) jpackage (implementation)

-

Changes: https://git.openjdk.java.net/jdk/pull/633/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=633=02
  Stats: 1733 lines in 259 files changed: 692 ins; 701 del; 340 mod
  Patch: https://git.openjdk.java.net/jdk/pull/633.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/633/head:pull/633

PR: https://git.openjdk.java.net/jdk/pull/633

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Andy Herrick

On Tue, 13 Oct 2020 23:28:24 GMT, Alexander Matveev  
wrote:

>> Andy Herrick has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   JDK-8252870: Finalize (remove "incubator" from) jpackage
>> - reverting two auto-generated files, and changing module-info to 
>> "@since 16"
>
> Marked as reviewed by almatvee (Committer).

>  src/jdk.jpackage/macosx/classes/module-info.java.extra
> jdk.jpackage.internal.MacAppBundler,
> jdk.jpackage.internal.MacAppStoreBundler,
not related to this change directly, but even in 14 there was no 
MacAppStoreBundler

-

PR: https://git.openjdk.java.net/jdk/pull/633

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Andy Herrick

On Tue, 13 Oct 2020 13:44:22 GMT, Kevin Rushforth  wrote:

>> Andy Herrick has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   JDK-8252870: Finalize (remove "incubator" from) jpackage
>> - reverting two auto-generated files, and changing module-info to 
>> "@since 16"
>
> make/data/symbols/jdk.jpackage-E.sym.txt line 29:
> 
>> 27: # ##
>> 28: #
>> 29: module name jdk.jpackage
> 
> I think you need to revert this. Note this comment:
> 
>  # ### THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT. ###

reverted

> make/data/symbols/symbols line 40:
> 
>> 38: platform version C base B files
>> java.base-C.sym.txt:java.compiler-C.sym.txt:java.desktop-C.sym.txt:java.naming-C.sym.txt:java.rmi-C.sym.txt:java.xml-C.sym.txt:jdk.compiler-C.sym.txt:jdk.jfr-C.sym.txt:jdk.jsobject-C.sym.txt:jdk.unsupported-C.sym.txt
>> 39: platform version D base C files
>> java.base-D.sym.txt:java.compiler-D.sym.txt:java.desktop-D.sym.txt:java.management-D.sym.txt:java.management.rmi-D.sym.txt:java.net.http-D.sym.txt:java.security.jgss-D.sym.txt:java.xml-D.sym.txt:java.xml.crypto-D.sym.txt:jdk.compiler-D.sym.txt:jdk.httpserver-D.sym.txt:jdk.jartool-D.sym.txt:jdk.javadoc-D.sym.txt:jdk.jlink-D.sym.txt:jdk.jshell-D.sym.txt
>> 40: platform version E base D files
>> java.base-E.sym.txt:java.compiler-E.sym.txt:java.desktop-E.sym.txt:java.xml-E.sym.txt:jdk.compiler-E.sym.txt:jdk.httpserver-E.sym.txt:jdk.incubator.foreign-E.sym.txt:jdk.jpackage-E.sym.txt:jdk.jfr-E.sym.txt:jdk.jlink-E.sym.txt:jdk.jshell-E.sym.txt:jdk.jsobject-E.sym.txt:jdk.management-E.sym.txt:jdk.net-E.sym.txt:jdk.pack-E.sym.txt
> 
> Similarly, I think you need to revert this.

reverted

> src/jdk.jpackage/share/classes/module-info.java line 49:
> 
>> 47:  */
>> 48:
>> 49: module jdk.jpackage {
> 
> Change to `@since 16`

changed to @since16

-

PR: https://git.openjdk.java.net/jdk/pull/633

Re: RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

2020-10-13 Thread Andy Herrick

> JDK-8252870: Finalize (remove "incubator" from) jpackage

Andy Herrick has updated the pull request incrementally with one additional 
commit since the last revision:

  JDK-8252870: Finalize (remove "incubator" from) jpackage
- reverting two auto-generated files, and changing module-info to "@since 
16"

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/633/files
  - new: https://git.openjdk.java.net/jdk/pull/633/files/4b95b41c..4b1e6363

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=633=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=633=00-01

  Stats: 64 lines in 4 files changed: 31 ins; 31 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/633.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/633/head:pull/633

PR: https://git.openjdk.java.net/jdk/pull/633

RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage

2020-10-13 Thread Andy Herrick

JDK-8252870: Finalize (remove "incubator" from) jpackage

-

Commit messages:
 - JDK-8252870: Finalize (remove "incubator" from) jpackage
 - 8252869 Finalize (remove incubator from) jpackage (implementation)

Changes: https://git.openjdk.java.net/jdk/pull/633/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=633=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252870
  Stats: 1796 lines in 262 files changed: 723 ins; 732 del; 341 mod
  Patch: https://git.openjdk.java.net/jdk/pull/633.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/633/head:pull/633

PR: https://git.openjdk.java.net/jdk/pull/633

RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg

2020-03-27 Thread Andy Herrick


Please review the fix to issue [1] at [2].

This change enables notarization on Mac for dmg images and app-image zip 
files.


/Andy

[1]: https://bugs.openjdk.java.net/browse/JDK-8237490

[2]: http://cr.openjdk.java.net/~herrick/8237490

RFR: JDK-8241400: [macos] jpackageapplauncher/main.m built using CXXFLAGS_JDKEXE

2020-03-26 Thread Andy Herrick


Please review the fix to issue [1] at [2].

Simple makefile fix.

/Andy

[1]: https://bugs.openjdk.java.net/browse/JDK-8241400

[2]: http://cr.openjdk.java.net/~herrick/8241400/webrev.01/

Re: RFR: JDK-8234284: [dmg] Change DMG background image to TIFF

2019-12-11 Thread Andy Herrick


Fix looks fine to me.

adding build-dev since even this simple a makefile change should be 
reviewed by build-dev


On 12/10/2019 10:24 PM, Alexander Matveev wrote:

Please review fix [2] for jpackage bug [1].

 - Changed background image for DMG to TIFF format, which can be used 
to embed 2x image to support HiDPI displays.


Thanks,
Alexander

[1] https://bugs.openjdk.java.net/browse/JDK-8234284

[2] http://cr.openjdk.java.net/~almatvee/8234284/webrev.00/

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-12-03 Thread Andy Herrick

On 12/2/2019 2:07 PM, Phil Race wrote:

This makes it very difficult to do more than a cursory re-review.

There is one thing I just spotted.

I believe these two scripts
http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-11/test/jdk/tools/jpackage/test_jpackage.sh.html
http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-11/test/jdk/tools/jpackage/run_tests.sh.html

OK - run_tests.sh has been modified to not download jtreg from an
external server.

/Andy

Should not be part of what is pushed.

They should be removed from the webrev.

-phil.

On 11/27/19 6:07 AM, Andy Herrick wrote:

yes - The attempted incremental patch is not much use. The source
files were moved several times, and despite using "hg addremove -s
60", many of the files show as a remove and a new file.

/Andy

On 11/26/2019 9:01 PM, Philip Race wrote:
> I believe otherwise it is an accurate incremental webrev of the
jpackage changes since EA-5.

It is also not very incremental.
*
*src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/main/Main.java

is definitely not "new" ...

-phil.

On 11/26/19, 2:17 PM, Andy Herrick wrote:
yes, this incremental webrev contains the JNLPConverter code,
which it should not.

I believe otherwise it is an accurate incremental webrev of the
jpackage changes since EA-5.

/Andy

On 11/26/2019 4:53 PM, Phil Race wrote:

Andy,

I am puzzled by what I see here
> The webrev at [3] shows the changes since EA-06 (Build
13-jpackage+1-49 ) up to the current point.

> [3] http://cr.openjdk.java.net/~herrick/8212780/webrev.06-10/

This includes the JNLPConverter which isn't what I expected to see
and

(correctly) isn't in the cumulative webrev

Since [3] seemed like the most obvious thing to do a review of the
recent
changes I'd like to be sure it has the correct content and I am
not sure it does ...

-phil.

On 11/26/19 1:36 PM, Kevin Rushforth wrote:

This all looks good.

-- Kevin

On 11/26/2019 12:56 PM, Erik Joelsson wrote:

(adding build-dev)

Build changes look good.

/Erik

On 2019-11-20 09:37, Andy Herrick wrote:
I posted new composite webrev [7], and git patch [8] after
pushing fix for JDK-8234402 [6].

[7] http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-11/

[8]
http://cr.openjdk.java.net/~herrick/8212780/JDK-EA-11.git.patch

/Andy

On 11/19/2019 3:13 PM, Kevin Rushforth wrote:
I took the "git diff" patch [5] that you uploaded yesterday,
applied it, and verified that it is the same as what is in the
JDK-8200758-branch branch of the sandbox. It builds and runs
fine for me.

I ran jcheck and it found the following three files with
whitespace errors that will need to be fixed before you push:

src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/PackageProperty.java:49:
Trailing whitespace
src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/ToolProviderFactory.java:35:
Trailing whitespace
test/jdk/tools/jpackage/share/AddLauncherBase.java:137:
Trailing whitespace

The second of these will go away with the fix for JDK-8234402
[6], so you don't need to do anything there. Once the fix for
JDK-8234402 is pushed to sandbox, I presume you will update
the webrev, right?

Pending the fix for JDK-8234402 and the needed white-space
fixes, this is a +1 from me (although I am not a jdk Project
Reviewer, so you will need at least one review from someone
who is).

-- Kevin

[5]
http://cr.openjdk.java.net/~herrick/8212780/JDK-EA-10.git.patch

[6] https://bugs.openjdk.java.net/browse/JDK-8234402

On 11/13/2019 4:23 PM, Andy Herrick wrote:
Please review changes for [1] which is the implementation
bug for JEP-343.

The webrev at [2] is the total cumulative webrev of changes
for the jpackage tool, currently in the JDK-8200758-branch
branch of the open sandbox repository.

The webrev at [3] shows the changes since EA-06 (Build
13-jpackage+1-49 ) up to the current point.

The latest EA (Build 14-jpackage+1-49 ) is posted at [4].

Please send feedback to core-libs-...@openjdk.java.net

[1] https://bugs.openjdk.java.net/browse/JDK-8212780

[2] http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-10/

[3] http://cr.openjdk.java.net/~herrick/8212780/webrev.06-10/

[4] http://jdk.java.net/jpackage/

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-11-27 Thread Andy Herrick

yes - The attempted incremental patch is not much use.  The source files 
were moved several times, and despite using "hg addremove -s 60", many 
of the files show as a remove and a new file.

/Andy

On 11/26/2019 9:01 PM, Philip Race wrote:
> I believe otherwise it is an accurate incremental webrev of the 
jpackage changes since EA-5.

It is also not very incremental.
*
*src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/main/Main.java

is definitely not "new" ...

-phil.

On 11/26/19, 2:17 PM, Andy Herrick wrote:
yes,  this incremental webrev contains the JNLPConverter code, which 
it should not.

I believe otherwise it is an accurate incremental webrev of the 
jpackage changes since EA-5.

/Andy

On 11/26/2019 4:53 PM, Phil Race wrote:

Andy,

I am puzzled by what I see here
> The webrev at [3] shows the changes since EA-06 (Build 
13-jpackage+1-49 ) up to the current point.

> [3] http://cr.openjdk.java.net/~herrick/8212780/webrev.06-10/

This includes the JNLPConverter which isn't what I expected to see and
(correctly) isn't in the cumulative webrev 

Since [3] seemed like the most obvious thing to do a review of the 
recent
changes I'd like to be sure it has the correct content and I am not 
sure it does ...

-phil.

On 11/26/19 1:36 PM, Kevin Rushforth wrote:

This all looks good.

+1

-- Kevin

On 11/26/2019 12:56 PM, Erik Joelsson wrote:

(adding build-dev)

Build changes look good.

/Erik

On 2019-11-20 09:37, Andy Herrick wrote:
I posted new composite webrev [7], and git patch [8] after 
pushing fix for JDK-8234402 [6].

[7] http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-11/

[8] http://cr.openjdk.java.net/~herrick/8212780/JDK-EA-11.git.patch

/Andy

On 11/19/2019 3:13 PM, Kevin Rushforth wrote:
I took the "git diff" patch [5] that you uploaded yesterday, 
applied it, and verified that it is the same as what is in the 
JDK-8200758-branch branch of the sandbox. It builds and runs 
fine for me.

I ran jcheck and it found the following three files with 
whitespace errors that will need to be fixed before you push:

src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/PackageProperty.java:49: 
Trailing whitespace
src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/ToolProviderFactory.java:35: 
Trailing whitespace
test/jdk/tools/jpackage/share/AddLauncherBase.java:137: Trailing 
whitespace

The second of these will go away with the fix for JDK-8234402 
[6], so you don't need to do anything there. Once the fix for 
JDK-8234402 is pushed to sandbox, I presume you will update the 
webrev, right?

Pending the fix for JDK-8234402 and the needed white-space 
fixes, this is a +1 from me (although I am not a jdk Project 
Reviewer, so you will need at least one review from someone who 
is).

-- Kevin

[5] http://cr.openjdk.java.net/~herrick/8212780/JDK-EA-10.git.patch
[6] https://bugs.openjdk.java.net/browse/JDK-8234402

On 11/13/2019 4:23 PM, Andy Herrick wrote:
Please review  changes for [1] which is the implementation bug 
for JEP-343.

The webrev at [2] is the total cumulative webrev of changes for 
the jpackage tool, currently in the JDK-8200758-branch branch 
of the open sandbox repository.

The webrev at [3] shows the changes since EA-06 (Build 
13-jpackage+1-49 ) up to the current point.

The latest EA (Build 14-jpackage+1-49 ) is posted at [4].

Please send feedback to core-libs-...@openjdk.java.net

[1] https://bugs.openjdk.java.net/browse/JDK-8212780

[2] http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-10/

[3] http://cr.openjdk.java.net/~herrick/8212780/webrev.06-10/

[4] http://jdk.java.net/jpackage/

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-11-26 Thread Andy Herrick

yes,  this incremental webrev contains the JNLPConverter code, which it 
should not.

I believe otherwise it is an accurate incremental webrev of the jpackage 
changes since EA-5.

/Andy

On 11/26/2019 4:53 PM, Phil Race wrote:

Andy,

I am puzzled by what I see here
> The webrev at [3] shows the changes since EA-06 (Build 
13-jpackage+1-49 ) up to the current point.

> [3] http://cr.openjdk.java.net/~herrick/8212780/webrev.06-10/

This includes the JNLPConverter which isn't what I expected to see and
(correctly) isn't in the cumulative webrev 

Since [3] seemed like the most obvious thing to do a review of the recent
changes I'd like to be sure it has the correct content and I am not 
sure it does ...

-phil.

On 11/26/19 1:36 PM, Kevin Rushforth wrote:

This all looks good.

+1

-- Kevin

On 11/26/2019 12:56 PM, Erik Joelsson wrote:

(adding build-dev)

Build changes look good.

/Erik

On 2019-11-20 09:37, Andy Herrick wrote:
I posted new composite webrev [7], and git patch [8] after pushing 
fix for JDK-8234402 [6].

[7] http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-11/

[8] http://cr.openjdk.java.net/~herrick/8212780/JDK-EA-11.git.patch

/Andy

On 11/19/2019 3:13 PM, Kevin Rushforth wrote:
I took the "git diff" patch [5] that you uploaded yesterday, 
applied it, and verified that it is the same as what is in the 
JDK-8200758-branch branch of the sandbox. It builds and runs fine 
for me.

I ran jcheck and it found the following three files with 
whitespace errors that will need to be fixed before you push:

src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/PackageProperty.java:49: 
Trailing whitespace
src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/ToolProviderFactory.java:35: 
Trailing whitespace
test/jdk/tools/jpackage/share/AddLauncherBase.java:137: Trailing 
whitespace

The second of these will go away with the fix for JDK-8234402 [6], 
so you don't need to do anything there. Once the fix for 
JDK-8234402 is pushed to sandbox, I presume you will update the 
webrev, right?

Pending the fix for JDK-8234402 and the needed white-space fixes, 
this is a +1 from me (although I am not a jdk Project Reviewer, so 
you will need at least one review from someone who is).

-- Kevin

[5] http://cr.openjdk.java.net/~herrick/8212780/JDK-EA-10.git.patch
[6] https://bugs.openjdk.java.net/browse/JDK-8234402

On 11/13/2019 4:23 PM, Andy Herrick wrote:
Please review  changes for [1] which is the implementation bug 
for JEP-343.

The webrev at [2] is the total cumulative webrev of changes for 
the jpackage tool, currently in the JDK-8200758-branch branch of 
the open sandbox repository.

The webrev at [3] shows the changes since EA-06 (Build 
13-jpackage+1-49 ) up to the current point.

The latest EA (Build 14-jpackage+1-49 ) is posted at [4].

Please send feedback to core-libs-...@openjdk.java.net

[1] https://bugs.openjdk.java.net/browse/JDK-8212780

[2] http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-10/

[3] http://cr.openjdk.java.net/~herrick/8212780/webrev.06-10/

[4] http://jdk.java.net/jpackage/

Fwd: Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-11-26 Thread Andy Herrick

Forwarding review thread to build-dev.

/Andy

 Forwarded Message 
Subject:Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation
Date:   Wed, 20 Nov 2019 12:37:20 -0500
From:   Andy Herrick 
Organization:   Oracle Corporation
To: 	Kevin Rushforth , core-libs-dev 

I posted new composite webrev [7], and git patch [8] after pushing fix 
for JDK-8234402 [6].

[7] http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-11/

[8] http://cr.openjdk.java.net/~herrick/8212780/JDK-EA-11.git.patch

/Andy

On 11/19/2019 3:13 PM, Kevin Rushforth wrote:
I took the "git diff" patch [5] that you uploaded yesterday, applied 
it, and verified that it is the same as what is in the 
JDK-8200758-branch branch of the sandbox. It builds and runs fine for me.

I ran jcheck and it found the following three files with whitespace 
errors that will need to be fixed before you push:

src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/PackageProperty.java:49: 
Trailing whitespace
src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/ToolProviderFactory.java:35: 
Trailing whitespace
test/jdk/tools/jpackage/share/AddLauncherBase.java:137: Trailing 
whitespace

The second of these will go away with the fix for JDK-8234402 [6], so 
you don't need to do anything there. Once the fix for JDK-8234402 is 
pushed to sandbox, I presume you will update the webrev, right?

Pending the fix for JDK-8234402 and the needed white-space fixes, this 
is a +1 from me (although I am not a jdk Project Reviewer, so you will 
need at least one review from someone who is).

-- Kevin

[5] http://cr.openjdk.java.net/~herrick/8212780/JDK-EA-10.git.patch
[6] https://bugs.openjdk.java.net/browse/JDK-8234402

On 11/13/2019 4:23 PM, Andy Herrick wrote:
Please review  changes for [1] which is the implementation bug for 
JEP-343.

The webrev at [2] is the total cumulative webrev of changes for the 
jpackage tool, currently in the JDK-8200758-branch branch of the open 
sandbox repository.

The webrev at [3] shows the changes since EA-06 (Build 
13-jpackage+1-49 ) up to the current point.

The latest EA (Build 14-jpackage+1-49 ) is posted at [4].

Please send feedback to core-libs-...@openjdk.java.net

[1] https://bugs.openjdk.java.net/browse/JDK-8212780

[2] http://cr.openjdk.java.net/~herrick/8212780/webrev.EA-10/

[3] http://cr.openjdk.java.net/~herrick/8212780/webrev.06-10/

[4] http://jdk.java.net/jpackage/

Re: RFR: JDK-8223080: Build team code review requests.

2019-06-06 Thread Andy Herrick


tried to bcc build-dev on this, but not sure if it got thru.

/Andy


On 6/5/2019 9:43 PM, David Holmes wrote:

Hi Andy,

Build changes should be reviewed on build-dev@openjdk.java.net.

Cheers,
David

On 6/06/2019 9:46 am, Andy Herrick wrote:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


[1] https://bugs.openjdk.java.net/browse/JDK-8223080
[2] http://cr.openjdk.java.net/~herrick/8223080/

/Andy

RFR: JDK-8223080: Build team code review requests.

2019-06-05 Thread Andy Herrick


Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


[1] https://bugs.openjdk.java.net/browse/JDK-8223080
[2] http://cr.openjdk.java.net/~herrick/8223080/

/Andy

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-05-02 Thread Andy Herrick

Alexey:

Please file Bugs for these two issues.

/Andy

On 5/2/2019 1:49 PM, Alexey Semenyuk wrote:

Some findings:

http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/raw_files/new/make/launcher/Launcher-jdk.jpackage.gmk:

I think definitions of BUILD_JPACKAGE_APPLAUNCHEREXE and
BUILD_JPACKAGE_APPLAUNCHERWEXE targets should be moved to
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/make/lib/Lib-jdk.jpackage.gmk.html.
Reason: these targets don't output executables into images/jdk/bin
directory. They produce artifacts that stored as resources in jpackage
just like other targets defined in Lib-jdk.jpackage.gmk.

Wix source code produced by
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java.html
doesn't comply to recommendations of how files should be packed in
component. The recommendation is to use one file per a component -
http://wixtoolset.org/documentation/manual/v3/howtos/files_and_registry/add_a_file.html.
However jpackage produces way less components than files:

---
$ less config/bundle.wxi | grep 'http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java.html:745

+ " Guid=\"" + UUID.randomUUID().toString() + "\""
Use of random GUIDs for components is not recommended and potentially
can result in issues with application updates. The recommended
approach is to generate stable GUIDs -
http://wixtoolset.org/documentation/manual/v3/howtos/general/generate_guids.html,
http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/How-does-heat-maintain-consistent-GUIDs-td7599757.html.

Algorithm to create stable GUIDs is explained at
https://tools.ietf.org/html/rfc4122#page-13. However we can avoid the
hassle of generating stable GUIDs if we would put only one file in
every component. In this case WiX is able to generate stable GUIDs for
us.

- Alexey

On 4/27/2019 8:46 PM, Philip Race wrote:
Adding build-dev for the build changes. I don't know if these were
previously reviewed there,
but I am not sure what the changes in NativeCompilation.gmk have to
do with jpackage.

-phil.

On 4/24/19, 5:47 PM, Andy Herrick wrote:

On 4/24/2019 8:44 PM, Andy Herrick wrote:
Please review changes for [1] which is the implementation bug for
JEP-343.

The webrev at [2] is the total cumulative webrev of changes for the
jpackage tool, currently in the JDK-8200758-branch branch of the
open sandbox repository.

The webrev at [3] shows the changes from EA-05 to EA-06.
sorry - the links are reversed from what is stated above. [2] is the
incremental webrev since EA 05, [3] is the cumulativewebrev

/Andy

The latest EA-6 (build 49) is posted at [4].

Please send feedback to core-libs-...@openjdk.java.net

[1] https://bugs.openjdk.java.net/browse/JDK-8200758

[2] http://cr.openjdk.java.net/~herrick/8212780/webrev.05-06/

[3] http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/

[4] http://jdk.java.net/jpackage/

/Andy

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-05-01 Thread Andy Herrick




I have filed JDK-8223189 
 to address these.


/Andy


On 4/30/2019 7:02 PM, Kevin Rushforth wrote:

I have a couple nit-picky comments:

1. The change to src/jdk.jlink/share/classes/module-info.java is 
unrelated to jpackage and should be reverted (there is only a 
white-space change and a copyright date change to that file)



2. The following files have whitespace errors that will cause jcheck 
to fail:
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java:326: 
Trailing whitespace
src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java:58: 
Tab character
src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java:217: 
Trailing whitespace
src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java:55: 
Trailing whitespace



3. I recommend to replace the wild-card imports with explicit imports, 
for example:
src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java 
(java.util.* and java.io.*)
(I think the wild-card static import is fine, just not the import 
every class from a package)


I'll try to remember to note these as I go through the review. This 
one could be done as a follow-up bug rather than doing it prior to 
integration if you prefer.


-- Kevin

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-05-01 Thread Andy Herrick

I filed task JDK-8223187 
 to look into (1) and 
CR JDK-8223188  to 
address (2).


/Andy


On 4/30/2019 6:53 PM, Phil Race wrote:

A couple of questions / observations :-
1) setlocale
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/linux/native/jpackageapplauncher/launcher.cpp.html

   52 int main(int argc, char *argv[]) {
   53 int result = 1;
   54 setlocale(LC_ALL, "en_US.utf8");

Why is this setlocale() call there ?

What does this mean for a user whose desktop is (say) German, or French, or 
Japanese ?

When the Java app is launched from this environment is it inheriting this US 
locale ? I hope not.

We have the same on Mac :-

http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/macosx/native/jpackageapplauncher/main.m.html

and windows :-

http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/src/jdk.jpackage/windows/native/jpackageapplauncher/WinLauncher.cpp.html

   64 ::setlocale(LC_ALL, "en_US.utf8");


2) C++ files containing C

src/jdk.jpackage/windows/native/libjpackage/WindowsRegistry.cpp



src/jdk.jpackage/windows/native/libjpackage/jpackage.cpp



src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp



have their entire contents wrapped in

   36 #ifdef __cplusplus
   37 extern "C" {
   38 #endif

  159 #ifdef __cplusplus
  160 }
  161 #endif

wouldn't it be better to put them in .c files ?


-phil.

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2019-04-29 Thread Andy Herrick





On 4/29/2019 12:21 PM, Erik Joelsson wrote:
There is a new set of macros that should be used to check things like 
target OS. The new macro is called like this:


ifeq ($(call isTargetOs, windows macosx linux), false)

Lib-jdk.jpackage.gmk and Launcher-jdk.jpackage.gmk:

Same thing with checking for target OS:

ifeq ($(call isTargetOs, windows), true)

Otherwise this looks good from a build perspective. 


I have filed JDK-8223080 
 to address this.


/Andy

RFR: JDK-8217269: jpackage Makefile improvments

2019-01-21 Thread Andy Herrick


re-sending this to build-dev:

Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox 
repository (jpackage).


The webrev includes all the jpackage Makefile Improvements listed in 
[1], other than what is covered by [4], and also includes fix for white 
space errors requested in [3].


[1] https://bugs.openjdk.java.net/browse/JDK-8217269

[2] http://cr.openjdk.java.net/~herrick/8217269/webrev.01/

[3] https://bugs.openjdk.java.net/browse/JDK-8216521

[4] https://bugs.openjdk.java.net/browse/JDK-8217317

/Andy

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-13 Thread Andy Herrick


I agree with this and would take it further.

1 file is in ./share/classes/jdk/jpackager/internal/builders - why not 
just ./share/classes/jdk/jpackager/internal


2 files are in ./share/classes/jdk/jpackager/internal/bundlers - why not 
just in ./share/classes/jdk/jpackager/internal


1 file is in ./linux/classes/jdk/jpackager/internal/builders/linux - why 
not just ./linux/classes/jdk/jpackager/internal


1 file is in ./macosx/classes/jdk/jpackager/internal/builders/mac - why 
not just ./macosx/classes/jdk/jpackager/internal


1 file is in ./windows/classes/jdk/jpackager/internal/builders/windows - 
why not just ./windows/classes/jdk/jpackager/internal


then just move the associated resources -

Basically put everything except Main in same package - everything would 
be easier to find, and we could make almost all methods package-private 
(the only exception would be the few things called by Main, and the 
ToolProvider.



On 11/13/2018 2:54 PM, Phil Race wrote:
Question .. why is "mac", "linux" and "windows" necessary in the 
package name here ?


 src/jdk.jpackager/macosx/classes/jdk/jpackager/internal/mac/MacAppBundler.java 

 src/jdk.jpackager/windows/classes/jdk/jpackager/internal/builders/windows/WindowsAppImageBuilder.java 

src/jdk.jpackager/linux/classes/jdk/jpackager/internal/linux/LinuxRpmBundler.java 



There's not likely to be a clash, so is there some other reason not to 
want these

in the same package as the shared internals like
src/jdk.jpackager/share/classes/jdk/jpackager/internal/Param.java

?

-phil.


I agree with this and would take it further.

1 file is in ./share/classes/jdk/jpackager/internal/builders - why not 
just ./share/classes/jdk/jpackager/internal


2 files are in ./share/classes/jdk/jpackager/internal/bundlers - why not 
just in ./share/classes/jdk/jpackager/internal


1 file is in ./linux/classes/jdk/jpackager/internal/builders/linux - why 
not just ./linux/classes/jdk/jpackager/internal


1 file is in ./macosx/classes/jdk/jpackager/internal/builders/mac - why 
not just ./macosx/classes/jdk/jpackager/internal


1 file is in ./windows/classes/jdk/jpackager/internal/builders/windows - 
why not just ./windows/classes/jdk/jpackager/internal


then just move the associated resources -

Basically put everything except Main in same package - everything would 
be easier to find, and we could make almost all methods package-private 
(the only exception would be the few things called by Main, and the 
ToolProvider.


/Andy

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-13 Thread Andy Herrick



On 11/13/2018 3:39 AM, Alan Bateman wrote:

On 12/11/2018 21:40, Philip Race wrote:

  74
  75 static String getTmpDir() {
  76 String os = System.getProperty("os.name").toLowerCase();
  77 if (os.contains("win")) {
  78 return System.getProperty("user.home")
  79 + 
"\\AppData\\LocalLow\\Sun\\Java\\JPackager\\tmp";

  80 } else if (os.contains("mac") || os.contains("os x")) {
  81 return System.getProperty("user.home")
  82 + "/Library/Application 
Support/Oracle/Java/JPackager/tmp";

  83 } else if (os.contains("nix") || os.contains("nux")
  84 || os.contains("aix")) {
  85 return System.getProperty("user.home") + 
"/.java/jpackager/tmp";

  86 }
  87
  88 return System.getProperty("java.io.tmpdir");


This seems unduly complex, and I don't understand the implication of
supporting AIX .. or some unknown "Unix", when packager is targeted
only at mac, linux + windows.
user.home is specified to be the user's home directory so I would 
think it should use that consistently everywhere. I assume "Sun" and 
"Oracle" can be dropped from the file location too.


Agreed - the resulting paths will all start with 
System.getProperty("user.home") and the "Sun" and "Oracle" 
sub-directories will be removed both here and in the matching native 
launcher code.  Added that to JDK-8213756 



/Andy




-Alan

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-13 Thread Andy Herrick

Yes - The intent of getTmpDir() here is to match the GetTempDirectory() 
in launcher, which this does for the three supported platforms, but 
there is no need to check for the unsupported platforms.


I will clean this up as you suggest as part ofJDK-8213756 
<https://bugs.openjdk.java.net/browse/JDK-8213756>


/Andy

On 11/12/2018 4:40 PM, Philip Race wrote:

   74
   75 static String getTmpDir() {
   76 String os = System.getProperty("os.name").toLowerCase();
   77 if (os.contains("win")) {
   78 return System.getProperty("user.home")
   79 + "\\AppData\\LocalLow\\Sun\\Java\\JPackager\\tmp";
   80 } else if (os.contains("mac") || os.contains("os x")) {
   81 return System.getProperty("user.home")
   82 + "/Library/Application 
Support/Oracle/Java/JPackager/tmp";
   83 } else if (os.contains("nix") || os.contains("nux")
   84 || os.contains("aix")) {
   85 return System.getProperty("user.home") + 
"/.java/jpackager/tmp";
   86 }
   87
   88 return System.getProperty("java.io.tmpdir");

This seems unduly complex, and I don't understand the implication of
supporting AIX .. or some unknown "Unix", when packager is targeted
only at mac, linux + windows.

I think its sufficient to look for the strings windows, macos and linux.
And if you want a persistent storage location then default to the "unix"
location if there's no match .. although I am not sure it makes sense
on platforms that aren't targeted by jpackager.

-phil.


-phil.

On 11/12/18, 12:22 PM, Philip Race wrote:

Adding build-dev back ..

I noticed that module jdk.jpackager.runtime requires java.desktop on 
all platforms


So far as I can tell this is for a Mac-only support for receiving and
handling file open events. Probably it only makes sense or gets used
when the API is used from a running desktop application.

I might ask if we need this at all, but I definitely think it should
not be required on all platforms if needed only for Mac even if
we might want it on windows in a future version.

Do we not envisage cases where you need the runtime API for
some kind of daemon service for which there should be a singleton ?
Do you really want to force the desktop module to be dragged along
in such a case ?

I think we should remove this dependency even if it means losing a
MacOS feature at least for now.

-phil.

On 11/11/18, 2:40 PM, Andy Herrick wrote:

On 11/9/2018 5:25 PM, Andy Herrick wrote:
This is an update to the Request For Review of the implementation 
of the Java Packager Tool (jpackager) as described in JEP 343: 
Packaging Tool <https://bugs.openjdk.java.net/browse/JDK-8200758>


This refresh renames the packages used to jdk.jpackager and 
jdk.jpackager.runtime, removes the JNLPConverter demo, adds an 
initial set of automated tests, and contains fixes to the 
following issues:


JDK-8213324 jpackager deletes existing app directory without warning
JDK-8213166 jpackager --argument arg is broken
JDK-8213163 --app-image arg does not work creating exe installers
JDK-8212089 Prepare packager for localization
JDK-8212537 Create method and class description comments for main 
functionality

JDK-8213332 Create minimal automated tests for jpackager
JDK-821 Fix issues found in jpackager with automated tests
JDK-8213394 Stop using Log.info() except for expected output.
JDK-8213345 Secondary Launchers broken on mac.
JDK-8213156 rename packages for jpackager
JDK-8213244 Fix all warnings in jpackager java code
JDK-8212143 Remove native code that supports UserJvmOptionsService
JDK-8213162 Association description in Inno Setup cannot contain 
double quotes


The following additional issues are targeted to be address in the 
next few weeks:

JDK-8212936 Makefile and other improvements for jpackager
JDK-8212164 resolve jre.list and jre.module.list
JDK-8213392 Enhance --help and --version
JDK-8208652 File name is not passed to main() via file 
association on OS X

JDK-8212538 Determine standard way to determine if a Modular jar
JDK-8213558 Create more unit tests
Note: The above issues are targeted to 'internal' - meaning we 
expect to resolve them in the sandbox before the initial push to 
JDK12.
Issues targeted to '12' are expected to be fixed after the initial 
push.


/Andy


Webrev: http://cr.openjdk.java.net/~herrick/8212780/webrev.2/

please send feedback to core-libs-...@openjdk.java.net

/Andy Herrick

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-12 Thread Andy Herrick




On 11/12/2018 4:54 PM, Philip Race wrote:


On 11/12/18, 1:45 PM, Andy Herrick wrote:


On 11/12/2018 3:22 PM, Philip Race wrote:

Adding build-dev back ..

I noticed that module jdk.jpackager.runtime requires java.desktop on 
all platforms


So far as I can tell this is for a Mac-only support for receiving and
handling file open events. Probably it only makes sense or gets used
when the API is used from a running desktop application.

I might ask if we need this at all, but I definitely think it should
not be required on all platforms if needed only for Mac even if
we might want it on windows in a future version.

Do we not envisage cases where you need the runtime API for
some kind of daemon service for which there should be a singleton ?
Do you really want to force the desktop module to be dragged along
in such a case ?

I think we should remove this dependency even if it means losing a
MacOS feature at least for now.


1.) we could remove that functionality (I don't even really 
understand the use case for it), and remove the two arg 
registerSingleInstance method from the public interface, and remove 
the requires statement in module-info.java.


I was thinking remove it as above since since even the javadoc for 
that method

feels obliged to say it is just for macos :-

  95 /**
  96  * Registers {@code SingleInstanceListener} for current process.
  97  * If the {@code SingleInstanceListener} object is already 
registered, or
  98  * {@code slistener} is {@code null}, then the registration 
is skipped.

  99  *
 100  * @param slistener the listener to handle the single 
instance behaviour.
 101  * @param setFileHandler if {@code true}, the listener is 
notified when the
 102  * application is asked to open a list of files. If 
OS is not MacOS,

 103  * the parameter is ignored.
 104  */


yuck. If such optional functionality is needed it needs to be done via
adding a "doesPlatformSupportFileHandler() method rather than saying 
the above.


-phil.


OK - I filed JDK-8213756 
<https://bugs.openjdk.java.net/browse/JDK-8213756> to handle removing 
this API, fixing the call to new SingleInstanceImpl() to be wrapped in 
synchronized null check, and fixing comments you referred to .


/Andy




or ...

2.) we could move that functionality to a platform dependent class, 
having dummy methods of setOpenFileHandler in the windows and linux  
platform dependent class.  Then we could add a module-info.java.extra 
in src/jdk.jpackager.runtime/macos/classes with that requires statement.


/Andy



-phil.

On 11/11/18, 2:40 PM, Andy Herrick wrote:

On 11/9/2018 5:25 PM, Andy Herrick wrote:
This is an update to the Request For Review of the implementation 
of the Java Packager Tool (jpackager) as described in JEP 343: 
Packaging Tool <https://bugs.openjdk.java.net/browse/JDK-8200758>


This refresh renames the packages used to jdk.jpackager and 
jdk.jpackager.runtime, removes the JNLPConverter demo, adds an 
initial set of automated tests, and contains fixes to the 
following issues:


JDK-8213324 jpackager deletes existing app directory without warning
JDK-8213166 jpackager --argument arg is broken
JDK-8213163 --app-image arg does not work creating exe installers
JDK-8212089 Prepare packager for localization
JDK-8212537 Create method and class description comments for main 
functionality

JDK-8213332 Create minimal automated tests for jpackager
JDK-821 Fix issues found in jpackager with automated tests
JDK-8213394 Stop using Log.info() except for expected output.
JDK-8213345 Secondary Launchers broken on mac.
JDK-8213156 rename packages for jpackager
JDK-8213244 Fix all warnings in jpackager java code
JDK-8212143 Remove native code that supports UserJvmOptionsService
JDK-8213162 Association description in Inno Setup cannot contain 
double quotes


The following additional issues are targeted to be address in the 
next few weeks:

JDK-8212936 Makefile and other improvements for jpackager
JDK-8212164 resolve jre.list and jre.module.list
JDK-8213392 Enhance --help and --version
JDK-8208652 File name is not passed to main() via file 
association on OS X

JDK-8212538 Determine standard way to determine if a Modular jar
JDK-8213558 Create more unit tests
Note: The above issues are targeted to 'internal' - meaning we 
expect to resolve them in the sandbox before the initial push to 
JDK12.
Issues targeted to '12' are expected to be fixed after the initial 
push.


/Andy


Webrev: http://cr.openjdk.java.net/~herrick/8212780/webrev.2/

please send feedback to core-libs-...@openjdk.java.net

/Andy Herrick

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-12 Thread Andy Herrick




On 11/12/2018 3:22 PM, Philip Race wrote:

Adding build-dev back ..

I noticed that module jdk.jpackager.runtime requires java.desktop on 
all platforms


So far as I can tell this is for a Mac-only support for receiving and
handling file open events. Probably it only makes sense or gets used
when the API is used from a running desktop application.

I might ask if we need this at all, but I definitely think it should
not be required on all platforms if needed only for Mac even if
we might want it on windows in a future version.

Do we not envisage cases where you need the runtime API for
some kind of daemon service for which there should be a singleton ?
Do you really want to force the desktop module to be dragged along
in such a case ?

I think we should remove this dependency even if it means losing a
MacOS feature at least for now.


1.) we could remove that functionality (I don't even really understand 
the use case for it), and remove the two arg registerSingleInstance 
method from the public interface, and remove the requires statement in 
module-info.java.


or ...

2.) we could move that functionality to a platform dependent class, 
having dummy methods of setOpenFileHandler in the windows and linux  
platform dependent class.  Then we could add a module-info.java.extra in 
src/jdk.jpackager.runtime/macos/classes with that requires statement.


/Andy



-phil.

On 11/11/18, 2:40 PM, Andy Herrick wrote:

On 11/9/2018 5:25 PM, Andy Herrick wrote:
This is an update to the Request For Review of the implementation of 
the Java Packager Tool (jpackager) as described in JEP 343: 
Packaging Tool <https://bugs.openjdk.java.net/browse/JDK-8200758>


This refresh renames the packages used to jdk.jpackager and 
jdk.jpackager.runtime, removes the JNLPConverter demo, adds an 
initial set of automated tests, and contains fixes to the following 
issues:


JDK-8213324 jpackager deletes existing app directory without warning
JDK-8213166 jpackager --argument arg is broken
JDK-8213163 --app-image arg does not work creating exe installers
JDK-8212089 Prepare packager for localization
JDK-8212537 Create method and class description comments for main 
functionality

JDK-8213332 Create minimal automated tests for jpackager
JDK-821 Fix issues found in jpackager with automated tests
JDK-8213394 Stop using Log.info() except for expected output.
JDK-8213345 Secondary Launchers broken on mac.
JDK-8213156 rename packages for jpackager
JDK-8213244 Fix all warnings in jpackager java code
JDK-8212143 Remove native code that supports UserJvmOptionsService
JDK-8213162 Association description in Inno Setup cannot contain 
double quotes


The following additional issues are targeted to be address in the 
next few weeks:

JDK-8212936 Makefile and other improvements for jpackager
JDK-8212164 resolve jre.list and jre.module.list
JDK-8213392 Enhance --help and --version
JDK-8208652 File name is not passed to main() via file 
association on OS X

JDK-8212538 Determine standard way to determine if a Modular jar
JDK-8213558 Create more unit tests
Note: The above issues are targeted to 'internal' - meaning we expect 
to resolve them in the sandbox before the initial push to JDK12.

Issues targeted to '12' are expected to be fixed after the initial push.

/Andy


Webrev: http://cr.openjdk.java.net/~herrick/8212780/webrev.2/

please send feedback to core-libs-...@openjdk.java.net

/Andy Herrick

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-11 Thread Andy Herrick

yes of the nine build system issues brought up by Magnus and Erik 
(listed in JDK-8212936 ) , only one has been addressed so far.


This is at the top of the list of remaining issues we will be working ont:

The following additional issues are targeted to be address in the next few 
weeks:
JDK-8212936 Makefile and other improvements for jpackager
JDK-8212164 resolve jre.list and jre.module.list
...

I may need some expert help  to implement some of these changes.

/Andy

On 11/11/2018 3:02 AM, Alan Bateman wrote:

On 10/11/2018 21:59, Magnus Ihse Bursie wrote:
I can't see that you've addressed any of the build system changes 
Erik and I requested? Or is this just a preliminary review, and you 
intend to go at least one more round before attempting to push? If 
so, this was not very clear to me.


I see Andy has a separate issue in JIRA tracking this:
  https://bugs.openjdk.java.net/browse/JDK-8212936

but I agree the bug management around this feature isn't clear to 
potential reviewers. My guess is he may be using JIRA issues to track 
feedback/changes between each iteration of the webrev so this is why 
affects and fixVersion are set to "internal". I think you need to make 
clear if the make file issues need to be addressed for the initial 
push - I suspect they do.


-Alan

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-09 Thread Andy Herrick





On 11/9/2018 5:25 PM, Andy Herrick wrote:
This is an update to the Request For Review of the implementation of 
the Java Packager Tool (jpackager) as described in JEP 343: Packaging 
Tool <https://bugs.openjdk.java.net/browse/JDK-8200758>


This refresh renames the packages used to jdk.jpackager and 
jdk.jpackager.runtime, removes the JNLPConverter demo, adds an initial 
set of automated tests, and contains fixes to the following issues:


JDK-8213324 jpackager deletes existing app directory without warning
JDK-8213166 jpackager --argument arg is broken
JDK-8213163 --app-image arg does not work creating exe installers
JDK-8212089 Prepare packager for localization
JDK-8212537 Create method and class description comments for main 
functionality

JDK-8213332 Create minimal automated tests for jpackager
JDK-821 Fix issues found in jpackager with automated tests
JDK-8213394 Stop using Log.info() except for expected output.
JDK-8213345 Secondary Launchers broken on mac.
JDK-8213156 rename packages for jpackager
JDK-8213244 Fix all warnings in jpackager java code
JDK-8212143 Remove native code that supports UserJvmOptionsService
JDK-8213162 Association description in Inno Setup cannot contain 
double quotes


The following additional issues are targeted to be address in the next 
few weeks:

JDK-8212936 Makefile and other improvements for jpackager
JDK-8212164 resolve jre.list and jre.module.list
JDK-8213392 Enhance --help and --version
JDK-8208652 File name is not passed to main() via file association 
on OS X

JDK-8212538 Determine standard way to determine if a Modular jar
JDK-8213558 Create more unit tests

Webrev: http://cr.openjdk.java.net/~herrick/8212780/webrev.2/

please send feedback to core-libs-...@openjdk.java.net

/Andy Herrick

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-10-30 Thread Andy Herrick





On 10/30/2018 10:11 AM, Andy Herrick wrote:



On 10/24/2018 10:22 AM, Alan Bateman wrote:

On 23/10/2018 16:49, Andy Herrick wrote:
This patch implements the Java Packager Tool (jpackager) as 
described in JEP 343: Packaging Tool 
<https://bugs.openjdk.java.net/browse/JDK-8200758>


jpackager is a simple packaging tool, based on the JavaFX 
|javapackager| tool, that:


 * Supports native packaging formats to give the end user a natural
   installation experience. These formats include |msi| and |exe| on
   Windows, |pkg| and |dmg| on MacOS, and |deb| and |rpm| on Linux.
 * Allows launch-time parameters to be specified at packaging time.
 * Can be invoked directly, from the command line, or programmatically,
   via the |ToolProvider| API.

Webrev:

http://cr.openjdk.java.net/~herrick/8212780/webrev.01/


cc'ing build-dev as it's important to get it reviewed there.

What is the plan for tests to go with this tool? I see there is one 
test in the webrev to do some argument validation but I don't see 
anything else right now.
We plan to incorporate the initial feedback from this review, and 
include an initial set of automated tests in a refresh sometime next 
week.

We will continue to develop and automate tests for future updates.


What is the status of the JNLPConverter tool? I see it is included as 
a "demo" but maybe it would be better to host somewhere else as this 
is for developers migrating Java Web Start applications.

Our current plan is to deliver it only as a demo.
After further discussion, we have decided to remove the JNLPConversion 
tool , and find another home for it.


/Andy



Would it be possible to update the JEP with all the CLI options? That 
would be useful for review and also useful for those invoking it with 
the ToolProvider API.

Done.


If I read the webrev correctly then it adds two modules, one with the 
jpackager tool and the other with an API. It would be useful to get a 
bit more information on the split. Also I think the name of the API 
module and the package that it exports needs discussion to make sure 
that the right names are chosen.
Yes - though we are currently using jdk.packager.services, we are open 
to other suggestions as the name for these. "jdk.packager.runtime" has 
also been suggested.


-Alan

/Andy

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-10-30 Thread Andy Herrick





On 10/24/2018 10:22 AM, Alan Bateman wrote:

On 23/10/2018 16:49, Andy Herrick wrote:
This patch implements the Java Packager Tool (jpackager) as described 
in JEP 343: Packaging Tool 
<https://bugs.openjdk.java.net/browse/JDK-8200758>


jpackager is a simple packaging tool, based on the JavaFX 
|javapackager| tool, that:


 * Supports native packaging formats to give the end user a natural
   installation experience. These formats include |msi| and |exe| on
   Windows, |pkg| and |dmg| on MacOS, and |deb| and |rpm| on Linux.
 * Allows launch-time parameters to be specified at packaging time.
 * Can be invoked directly, from the command line, or programmatically,
   via the |ToolProvider| API.

Webrev:

http://cr.openjdk.java.net/~herrick/8212780/webrev.01/


cc'ing build-dev as it's important to get it reviewed there.

What is the plan for tests to go with this tool? I see there is one 
test in the webrev to do some argument validation but I don't see 
anything else right now.
We plan to incorporate the initial feedback from this review, and 
include an initial set of automated tests in a refresh sometime next week.

We will continue to develop and automate tests for future updates.


What is the status of the JNLPConverter tool? I see it is included as 
a "demo" but maybe it would be better to host somewhere else as this 
is for developers migrating Java Web Start applications.

Our current plan is to deliver it only as a demo.


Would it be possible to update the JEP with all the CLI options? That 
would be useful for review and also useful for those invoking it with 
the ToolProvider API.

Done.


If I read the webrev correctly then it adds two modules, one with the 
jpackager tool and the other with an API. It would be useful to get a 
bit more information on the split. Also I think the name of the API 
module and the package that it exports needs discussion to make sure 
that the right names are chosen.
Yes - though we are currently using jdk.packager.services, we are open 
to other suggestions as the name for these. "jdk.packager.runtime" has 
also been suggested.


-Alan

/Andy

hg: jdk7/deploy/jdk: 7021567: need to create jnlp javadoc for 64 bit bundles.

2011-03-01 Thread andy . herrick

Changeset: 7931291bc5d3
Author:herrick
Date:  2011-03-01 17:09 -0500
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/7931291bc5d3

7021567: need to create jnlp javadoc for 64 bit bundles.
Summary: need to create jnlp javadoc for 64 bit bundles.
Reviewed-by: igor, ohair

! make/common/Release.gmk

hg: jdk7/deploy/jdk: 2 new changesets

2011-02-09 Thread andy . herrick

Changeset: e4802c87e5c7
Author:herrick
Date:  2011-02-09 09:19 -0500
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/e4802c87e5c7

7016724: Remove sun.jkernel.* classes in JDK 7
Summary: Remove sun.jkernel.* classes in JDK 7
Reviewed-by: ohair, alanb, mchung

! make/modules/modules.config
! make/sun/Makefile
- make/sun/jkernel/FILES_c_windows.gmk
- make/sun/jkernel/FILES_java.gmk
- make/sun/jkernel/Makefile
! src/share/classes/java/awt/color/ICC_Profile.java
! src/share/classes/java/util/zip/ZipEntry.java
- src/share/classes/sun/jkernel/BackgroundDownloader.java
- src/share/classes/sun/jkernel/Bundle.java
- src/share/classes/sun/jkernel/BundleCheck.java
- src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java
- src/share/classes/sun/jkernel/DigestOutputStream.java
- src/share/classes/sun/jkernel/DownloadManager.java
- src/share/classes/sun/jkernel/KernelError.java
- src/share/classes/sun/jkernel/Mutex.java
- src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java
- src/share/classes/sun/jkernel/StandaloneMessageDigest.java
- src/share/classes/sun/jkernel/StandaloneSHA.java
! src/share/classes/sun/jvmstat/monitor/MonitoredVmUtil.java
! src/share/classes/sun/misc/BootClassLoaderHook.java
! src/share/classes/sun/tools/attach/HotSpotAttachProvider.java
! src/windows/bin/java_md.c
- src/windows/native/sun/jkernel/DownloadDialog.cpp
- src/windows/native/sun/jkernel/DownloadDialog.h
- src/windows/native/sun/jkernel/DownloadHelper.cpp
- src/windows/native/sun/jkernel/DownloadHelper.h
- src/windows/native/sun/jkernel/graphics/bullet.bmp
- src/windows/native/sun/jkernel/graphics/cautionshield32.bmp
- src/windows/native/sun/jkernel/graphics/java-icon.ico
- src/windows/native/sun/jkernel/graphics/masthead.bmp
- src/windows/native/sun/jkernel/graphics/warningmasthead.bmp
- src/windows/native/sun/jkernel/kernel.cpp
- src/windows/native/sun/jkernel/kernel.def
- src/windows/native/sun/jkernel/kernel.h
- src/windows/native/sun/jkernel/kernel.rc
- src/windows/native/sun/jkernel/kernel_de.rc
- src/windows/native/sun/jkernel/kernel_en.rc
- src/windows/native/sun/jkernel/kernel_es.rc
- src/windows/native/sun/jkernel/kernel_fr.rc
- src/windows/native/sun/jkernel/kernel_it.rc
- src/windows/native/sun/jkernel/kernel_ja.rc
- src/windows/native/sun/jkernel/kernel_ko.rc
- src/windows/native/sun/jkernel/kernel_pt_BR.rc
- src/windows/native/sun/jkernel/kernel_sv.rc
- src/windows/native/sun/jkernel/kernel_zh.rc
- src/windows/native/sun/jkernel/kernel_zh_TW.rc
- src/windows/native/sun/jkernel/resource.h
- src/windows/native/sun/jkernel/stdafx.cpp
- src/windows/native/sun/jkernel/stdafx.h
- src/windows/native/sun/jkernel/version.rc

Changeset: dc909d130397
Author:herrick
Date:  2011-02-09 09:32 -0500
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/dc909d130397

Merge

- make/java/hpi/Makefile
- make/java/hpi/hpi_common.gmk
- make/java/hpi/native/Makefile
- make/java/hpi/native/mapfile-vers
- make/java/hpi/native/reorder-i586
- make/java/hpi/native/reorder-sparc
- make/java/hpi/native/reorder-sparcv9
- make/java/hpi/windows/Makefile
- src/share/hpi/export/bool.h
- src/share/hpi/export/dll.h
- src/share/hpi/export/hpi.h
- src/share/hpi/include/hpi_impl.h
- src/share/hpi/include/vm_calls.h
- src/share/hpi/src/hpi.c
- src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties
- src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties
- src/solaris/hpi/export/byteorder_md.h
- src/solaris/hpi/export/hpi_md.h
- src/solaris/hpi/export/io_md.h
- src/solaris/hpi/export/path_md.h
- src/solaris/hpi/export/timeval_md.h
- src/solaris/hpi/include/hpi_init.h
- src/solaris/hpi/include/interrupt.h
- src/solaris/hpi/include/largefile.h
- src/solaris/hpi/include/largefile_linux.h
- src/solaris/hpi/include/largefile_solaris.h
- src/solaris/hpi/native_threads/include/condvar_md.h
- src/solaris/hpi/native_threads/include/monitor_md.h
- src/solaris/hpi/native_threads/include/mutex_md.h
- src/solaris/hpi/native_threads/include/np.h
- src/solaris/hpi/native_threads/include/porting.h
- src/solaris/hpi/native_threads/include/threads_md.h
- src/solaris/hpi/native_threads/src/condvar_md.c
- src/solaris/hpi/native_threads/src/interrupt_md.c
- src/solaris/hpi/native_threads/src/monitor_md.c
- src/solaris/hpi/native_threads/src/mutex_md.c
- src/solaris/hpi/native_threads/src/sys_api_td.c
- src/solaris/hpi/native_threads/src/threads_linux.c
- src/solaris/hpi/native_threads/src/threads_md.c
- src/solaris/hpi/native_threads/src/threads_solaris.c
- src/solaris/hpi/src/interrupt.c
- src/solaris/hpi/src/linker_md.c
- src/solaris/hpi/src/memory_md.c
- src/solaris/hpi/src/system_md.c
- src/windows/hpi/export/byteorder_md.h
- src/windows/hpi/export/hpi_md.h
- src/windows/hpi/export/io_md.h
- src/windows/hpi/export/path_md.h
- src/windows/hpi/export/timeval_md.h
- src/windows/hpi/include/monitor_md.h
- src/windows/hpi/include/mutex_md.h
- src/windows/hpi/include/threads_md.h
-

hg: jdk7/deploy/corba: Added tag jdk7-b122 for changeset 1523a060032c

2010-12-20 Thread andy . herrick

Changeset: ccc68bc57c82
Author:cl
Date:  2010-12-16 18:17 -0800
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/ccc68bc57c82

Added tag jdk7-b122 for changeset 1523a060032c

! .hgtags

hg: jdk7/deploy: 2 new changesets

2010-12-20 Thread andy . herrick

Changeset: d61adc5101e0
Author:cl
Date:  2010-12-16 18:17 -0800
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/d61adc5101e0

Added tag jdk7-b122 for changeset f1591eed71f6

! .hgtags

Changeset: ca5471357681
Author:herrick
Date:  2010-12-20 13:13 -0500
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/ca5471357681

Merge

hg: jdk7/deploy/hotspot: Added tag jdk7-b122 for changeset 3a548dc9cb45

2010-12-20 Thread andy . herrick

Changeset: 1132ed4a0086
Author:cl
Date:  2010-12-16 18:17 -0800
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/1132ed4a0086

Added tag jdk7-b122 for changeset 3a548dc9cb45

! .hgtags

hg: jdk7/deploy/jaxp: Added tag jdk7-b122 for changeset 03ff13d19c8f

2010-12-20 Thread andy . herrick

Changeset: ced66f2b52cf
Author:cl
Date:  2010-12-16 18:17 -0800
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/ced66f2b52cf

Added tag jdk7-b122 for changeset 03ff13d19c8f

! .hgtags

hg: jdk7/deploy/corba: Added tag jdk7-b121 for changeset 2cc9f3299210

2010-12-12 Thread andy . herrick

Changeset: 1523a060032c
Author:katleman
Date:  2010-12-09 21:25 -0800
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/1523a060032c

Added tag jdk7-b121 for changeset 2cc9f3299210

! .hgtags

hg: jdk7/deploy/jdk: 2 new changesets

2010-10-29 Thread andy . herrick

Changeset: 3e6726bbf80a
Author:cl
Date:  2010-10-28 13:31 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/3e6726bbf80a

Added tag jdk7-b116 for changeset 1657ed4e1d86

! .hgtags

Changeset: d15fa53991c8
Author:herrick
Date:  2010-10-29 16:01 -0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/d15fa53991c8

Merge

hg: jdk7/deploy/jaxp: Added tag jdk7-b116 for changeset f8d4e6c6cfce

2010-10-29 Thread andy . herrick

Changeset: 9ee4d96e8934
Author:cl
Date:  2010-10-28 13:31 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/9ee4d96e8934

Added tag jdk7-b116 for changeset f8d4e6c6cfce

! .hgtags

hg: jdk7/deploy/corba: Added tag jdk7-b116 for changeset 98c028de4301

2010-10-29 Thread andy . herrick

Changeset: fa502e4834da
Author:cl
Date:  2010-10-28 13:31 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/fa502e4834da

Added tag jdk7-b116 for changeset 98c028de4301

! .hgtags

hg: jdk7/deploy/hotspot: 46 new changesets

2010-10-22 Thread andy . herrick

Changeset: 1c52033222eb
Author:trims
Date:  2010-10-01 18:04 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/1c52033222eb

Added tag hs20-b01 for changeset 5511edd5d719

! .hgtags

Changeset: c77e8f982901
Author:never
Date:  2010-09-15 20:25 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/c77e8f982901

6984979: OptimizeFill misses some cases with an odd memory graph
Reviewed-by: kvn

! src/share/vm/opto/loopTransform.cpp

Changeset: fd5d4527cdf5
Author:iveresov
Date:  2010-09-21 13:38 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/fd5d4527cdf5

6986270: guarantee(*bcp != Bytecodes::_monitorenter || exec_mode != 
Deoptimization::Unpack_exception) fails
Summary: Propagate the compiler type of the deopting method to 
vframeArrayElement::unpack_on_stack()
Reviewed-by: jrose, never

! src/share/vm/runtime/deoptimization.cpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/thread.hpp
! src/share/vm/runtime/vframeArray.cpp

Changeset: 5867d89c129b
Author:never
Date:  2010-09-22 13:01 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/5867d89c129b

6982537: Crash in Node*step_through_mergemem
Reviewed-by: kvn

! src/share/vm/opto/escape.cpp
! src/share/vm/opto/memnode.cpp

Changeset: 87b64980e2f1
Author:never
Date:  2010-09-22 21:10 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/87b64980e2f1

6972540: sun/nio/ch/SocketChannelImpl compilation crashed when executing 
CompileTheWorld
Reviewed-by: kvn

! src/share/vm/c1/c1_LIR.cpp
! src/share/vm/c1/c1_LIR.hpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/c1/c1_LinearScan.cpp

Changeset: c40600e85311
Author:never
Date:  2010-09-22 23:51 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/c40600e85311

6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub
Reviewed-by: kvn, twisti

! src/share/vm/opto/stringopts.cpp

Changeset: c93c652551b5
Author:twisti
Date:  2010-09-24 03:51 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/c93c652551b5

6986944: JSR 292 assert(caller_nm-is_method_handle_return(caller_frame.pc())) 
failed: must be MH call site
Reviewed-by: never, kvn

! src/cpu/x86/vm/methodHandles_x86.cpp
! src/share/vm/ci/ciMethod.cpp

Changeset: f02a8bbe6ed4
Author:roland
Date:  2009-12-29 19:08 +0100
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/f02a8bbe6ed4

6986046: C1 valuestack cleanup
Summary: fixes an historical oddity in C1 with inlining where all of the 
expression stacks are kept in the topmost ValueStack instead of being in their 
respective ValueStacks.
Reviewed-by: never
Contributed-by: Christian Wimmer cwim...@uci.edu

! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp
! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp
! src/cpu/x86/vm/c1_CodeStubs_x86.cpp
! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp
! src/share/vm/c1/c1_CFGPrinter.cpp
! src/share/vm/c1/c1_Canonicalizer.cpp
! src/share/vm/c1/c1_Compilation.hpp
! src/share/vm/c1/c1_GraphBuilder.cpp
! src/share/vm/c1/c1_GraphBuilder.hpp
! src/share/vm/c1/c1_IR.cpp
! src/share/vm/c1/c1_IR.hpp
! src/share/vm/c1/c1_Instruction.cpp
! src/share/vm/c1/c1_Instruction.hpp
! src/share/vm/c1/c1_InstructionPrinter.cpp
! src/share/vm/c1/c1_LIR.cpp
! src/share/vm/c1/c1_LIRAssembler.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/c1/c1_LinearScan.cpp
! src/share/vm/c1/c1_LinearScan.hpp
! src/share/vm/c1/c1_Optimizer.cpp
! src/share/vm/c1/c1_ValueStack.cpp
! src/share/vm/c1/c1_ValueStack.hpp
! src/share/vm/c1/c1_globals.hpp
! src/share/vm/includeDB_compiler1

Changeset: 861f533d12b0
Author:roland
Date:  2010-09-24 13:14 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/861f533d12b0

Merge


Changeset: df015ec64052
Author:iveresov
Date:  2010-09-27 15:04 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/df015ec64052

6987115: Non-tiered compilation policy creates unnecessary C1 threads
Summary: Fixed NonTieredCompPolicy::compiler_count() to return correct thread 
count.
Reviewed-by: twisti, kvn

! src/share/vm/runtime/compilationPolicy.cpp

Changeset: 1375bc8922e4
Author:never
Date:  2010-09-27 20:44 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/1375bc8922e4

6987763: assert(kind() == EmptyExceptionState) failed: only 
EmptyExceptionStates can be modified
Reviewed-by: roland, kvn, iveresov

! src/share/vm/c1/c1_ValueStack.hpp

Changeset: 8aa5fd5d2046
Author:twisti
Date:  2010-09-29 00:30 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/8aa5fd5d2046

6987634: JSR 292 assert(start_bci() = 0  start_bci()  code_size()) failed: 
correct osr_bci argument
Reviewed-by: never, kvn

! src/share/vm/opto/doCall.cpp

Changeset: ad0638ff8ea4
Author:roland
Date:  2010-09-29 18:53 +0200
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/ad0638ff8ea4

6988303: 6986046 breaks build

hg: jdk7/deploy/jaxp: Added tag jdk7-b115 for changeset dc1612e1d3ac

2010-10-22 Thread andy . herrick

Changeset: f8d4e6c6cfce
Author:cl
Date:  2010-10-21 17:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/f8d4e6c6cfce

Added tag jdk7-b115 for changeset dc1612e1d3ac

! .hgtags

hg: jdk7/deploy/jaxws: Added tag jdk7-b115 for changeset 824cc44bd6eb

2010-10-22 Thread andy . herrick

Changeset: 376ac153078d
Author:cl
Date:  2010-10-21 17:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/376ac153078d

Added tag jdk7-b115 for changeset 824cc44bd6eb

! .hgtags

hg: jdk7/deploy: 2 new changesets

2010-10-16 Thread andy . herrick

Changeset: 73c9023ae9b0
Author:cl
Date:  2010-10-14 19:24 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/73c9023ae9b0

Added tag jdk7-b114 for changeset 27985a5c6e52

! .hgtags

Changeset: 2fae5a0f6c72
Author:herrick
Date:  2010-10-16 12:31 -0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/2fae5a0f6c72

Merge

hg: jdk7/deploy/corba: Added tag jdk7-b114 for changeset 88fddb73c5c4

2010-10-16 Thread andy . herrick

Changeset: da7561d479e0
Author:cl
Date:  2010-10-14 19:24 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/da7561d479e0

Added tag jdk7-b114 for changeset 88fddb73c5c4

! .hgtags

hg: jdk7/deploy/hotspot: Added tag jdk7-b114 for changeset 68d6141ea19d

2010-10-16 Thread andy . herrick

Changeset: 477faa484f91
Author:cl
Date:  2010-10-14 19:24 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/477faa484f91

Added tag jdk7-b114 for changeset 68d6141ea19d

! .hgtags

hg: jdk7/deploy/jaxp: Added tag jdk7-b114 for changeset d57197d22c2b

2010-10-16 Thread andy . herrick

Changeset: dc1612e1d3ac
Author:cl
Date:  2010-10-14 19:25 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/dc1612e1d3ac

Added tag jdk7-b114 for changeset d57197d22c2b

! .hgtags

hg: jdk7/deploy/jaxws: Added tag jdk7-b114 for changeset 400f494c81c5

2010-10-16 Thread andy . herrick

Changeset: 824cc44bd6eb
Author:cl
Date:  2010-10-14 19:25 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/824cc44bd6eb

Added tag jdk7-b114 for changeset 400f494c81c5

! .hgtags

hg: jdk7/deploy/corba: Added tag jdk7-b113 for changeset a89a6c5be9d1

2010-10-08 Thread andy . herrick

Changeset: 88fddb73c5c4
Author:cl
Date:  2010-10-07 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/88fddb73c5c4

Added tag jdk7-b113 for changeset a89a6c5be9d1

! .hgtags

hg: jdk7/deploy/hotspot: Added tag jdk7-b113 for changeset beef35b96b81

2010-10-08 Thread andy . herrick

Changeset: 68d6141ea19d
Author:cl
Date:  2010-10-07 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/68d6141ea19d

Added tag jdk7-b113 for changeset beef35b96b81

! .hgtags

hg: jdk7/deploy/jaxp: Added tag jdk7-b113 for changeset bc0c84ce54c3

2010-10-08 Thread andy . herrick

Changeset: d57197d22c2b
Author:cl
Date:  2010-10-07 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/d57197d22c2b

Added tag jdk7-b113 for changeset bc0c84ce54c3

! .hgtags

hg: jdk7/deploy/jaxws: Added tag jdk7-b113 for changeset d35c94fd2236

2010-10-08 Thread andy . herrick

Changeset: 400f494c81c5
Author:cl
Date:  2010-10-07 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/400f494c81c5

Added tag jdk7-b113 for changeset d35c94fd2236

! .hgtags

hg: jdk7/deploy/jdk: 2 new changesets

2010-10-08 Thread andy . herrick

Changeset: 621be994f8d9
Author:cl
Date:  2010-10-07 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/621be994f8d9

Added tag jdk7-b113 for changeset 61d3b9fbb26b

! .hgtags

Changeset: e45cac3fe09b
Author:herrick
Date:  2010-10-08 11:43 -0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/e45cac3fe09b

Merge

hg: jdk7/deploy: 8 new changesets

2010-10-02 Thread andy . herrick

Changeset: 989da1ce9287
Author:cl
Date:  2010-09-23 17:33 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/989da1ce9287

Added tag jdk7-b111 for changeset 9702d6fef68e

! .hgtags

Changeset: 1fbed32d2ddd
Author:gbenson
Date:  2010-08-24 13:27 +0100
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/1fbed32d2ddd

6976186: Integrate Shark
Summary: Shark is a JIT compiler for Zero that uses the LLVM compiler 
infrastructure.
Reviewed-by: ohair

! make/hotspot-rules.gmk

Changeset: 90357eee5234
Author:lana
Date:  2010-09-02 22:07 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/90357eee5234

Merge


Changeset: b331aef4bef0
Author:ohair
Date:  2010-09-07 15:51 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/b331aef4bef0

Merge


Changeset: 87e98a1df774
Author:lana
Date:  2010-09-16 11:18 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/87e98a1df774

Merge


Changeset: b852103caf73
Author:lana
Date:  2010-09-24 16:38 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/b852103caf73

Merge


Changeset: c1df968c4527
Author:cl
Date:  2010-10-01 15:44 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/c1df968c4527

Added tag jdk7-b112 for changeset b852103caf73

! .hgtags

Changeset: 2a7813a9b529
Author:herrick
Date:  2010-10-02 11:08 -0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/2a7813a9b529

Merge

hg: jdk7/deploy/corba: 7 new changesets

2010-10-02 Thread andy . herrick

Changeset: 21c218f9a7be
Author:cl
Date:  2010-09-23 17:33 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/21c218f9a7be

Added tag jdk7-b111 for changeset 640fa4d4e2ad

! .hgtags

Changeset: 0f60cf26c5b5
Author:ohair
Date:  2010-08-30 14:39 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/0f60cf26c5b5

6981043: Clean out all native code makefile logic from corba repository
Reviewed-by: jjg

! make/Makefile
! make/common/Defs-linux.gmk
! make/common/Defs-solaris.gmk
! make/common/Defs-windows.gmk
! make/common/Defs.gmk
- make/common/Library.gmk
- make/common/Mapfile-vers.gmk
! make/common/Rules.gmk
- make/common/internal/NativeCompileRules.gmk
- make/common/shared/Compiler-gcc.gmk
- make/common/shared/Compiler-msvc.gmk
- make/common/shared/Compiler-sun.gmk
- make/common/shared/Compiler.gmk
! make/common/shared/Defs-java.gmk
! make/common/shared/Defs-linux.gmk
! make/common/shared/Defs-solaris.gmk
! make/common/shared/Defs-windows.gmk
! make/common/shared/Defs.gmk
! make/common/shared/Platform.gmk
! make/org/omg/idl/Makefile

Changeset: d6297db2b9dd
Author:lana
Date:  2010-09-02 22:07 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/d6297db2b9dd

Merge


Changeset: 0a91416c1402
Author:ohair
Date:  2010-09-07 15:50 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/0a91416c1402

Merge

- make/common/Library.gmk
- make/common/Mapfile-vers.gmk
- make/common/internal/NativeCompileRules.gmk
- make/common/shared/Compiler-gcc.gmk
- make/common/shared/Compiler-msvc.gmk
- make/common/shared/Compiler-sun.gmk
- make/common/shared/Compiler.gmk

Changeset: ae60f98d2f42
Author:lana
Date:  2010-09-16 11:18 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/ae60f98d2f42

Merge

- make/common/Library.gmk
- make/common/Mapfile-vers.gmk
- make/common/internal/NativeCompileRules.gmk
- make/common/shared/Compiler-gcc.gmk
- make/common/shared/Compiler-msvc.gmk
- make/common/shared/Compiler-sun.gmk
- make/common/shared/Compiler.gmk

Changeset: cc67fdc4fee9
Author:lana
Date:  2010-09-24 16:38 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/cc67fdc4fee9

Merge

- make/common/Library.gmk
- make/common/Mapfile-vers.gmk
- make/common/internal/NativeCompileRules.gmk
- make/common/shared/Compiler-gcc.gmk
- make/common/shared/Compiler-msvc.gmk
- make/common/shared/Compiler-sun.gmk
- make/common/shared/Compiler.gmk

Changeset: a89a6c5be9d1
Author:cl
Date:  2010-10-01 15:44 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/a89a6c5be9d1

Added tag jdk7-b112 for changeset cc67fdc4fee9

! .hgtags

hg: jdk7/deploy/jaxp: 7 new changesets

2010-10-02 Thread andy . herrick

Changeset: 028a06f776c0
Author:cl
Date:  2010-09-23 17:33 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/028a06f776c0

Added tag jdk7-b111 for changeset 8106c747067c

! .hgtags

Changeset: a3fe5892cd26
Author:ohair
Date:  2010-09-01 13:28 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/a3fe5892cd26

6981408: Upgrade jaxp to 1.4.4
Reviewed-by: darcy
Contributed-by: Joe Wang huizhe.w...@oracle.com

! jaxp.properties

Changeset: 4a249814b147
Author:lana
Date:  2010-09-02 22:09 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/4a249814b147

Merge


Changeset: e58a0bea47f6
Author:ohair
Date:  2010-09-07 15:50 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/e58a0bea47f6

Merge


Changeset: b23fd715a158
Author:lana
Date:  2010-09-16 11:18 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/b23fd715a158

Merge


Changeset: 1b0525424288
Author:lana
Date:  2010-09-24 16:38 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/1b0525424288

Merge


Changeset: bc0c84ce54c3
Author:cl
Date:  2010-10-01 15:45 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/bc0c84ce54c3

Added tag jdk7-b112 for changeset 1b0525424288

! .hgtags

hg: jdk7/deploy/jaxws: 7 new changesets

2010-10-02 Thread andy . herrick

Changeset: 3c8627862d07
Author:cl
Date:  2010-09-23 17:33 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/3c8627862d07

Added tag jdk7-b111 for changeset 2575ebca96c7

! .hgtags

Changeset: c6c2f9094bdd
Author:ohair
Date:  2010-08-30 16:00 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/c6c2f9094bdd

6962317: jdk7 jaxws source bundle still needs rebranding
6955300: Missing files in the jaf source bundle
Reviewed-by: ramap

! jaxws.properties

Changeset: 5dd2cc894d0c
Author:lana
Date:  2010-09-02 22:09 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/5dd2cc894d0c

Merge


Changeset: 74737bd256fa
Author:ohair
Date:  2010-09-07 15:51 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/74737bd256fa

Merge


Changeset: 4635da51e3cb
Author:lana
Date:  2010-09-16 11:18 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/4635da51e3cb

Merge


Changeset: 8e0f0054817f
Author:lana
Date:  2010-09-24 16:38 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/8e0f0054817f

Merge


Changeset: d35c94fd2236
Author:cl
Date:  2010-10-01 15:45 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/d35c94fd2236

Added tag jdk7-b112 for changeset 8e0f0054817f

! .hgtags

hg: jdk7/deploy/langtools: 34 new changesets

2010-10-02 Thread andy . herrick

Changeset: 7ad86852c38a
Author:cl
Date:  2010-09-23 17:33 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/7ad86852c38a

Added tag jdk7-b111 for changeset 8bec624274ef

! .hgtags

Changeset: e9d09e97d669
Author:jjg
Date:  2010-08-24 11:31 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/e9d09e97d669

6935638: -implicit:none prevents compilation with annotation processing
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
+ test/tools/javac/processing/options/TestImplicitNone.java

Changeset: f3323b1c65ee
Author:jjg
Date:  2010-08-24 15:09 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/f3323b1c65ee

6929404: Filer.getResource(SOURCE_PATH, ...) does not work when -sourcepath 
contains 1 entry
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java
+ test/tools/javac/processing/filer/TestGetResource2.java

Changeset: 6ef801fa38b7
Author:jjg
Date:  2010-08-25 11:24 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/6ef801fa38b7

6979564: : for path separator in dist/bin/javac does not work on Windows
Reviewed-by: jjh

! make/build.xml
! src/share/bin/launcher.sh-template

Changeset: 70ebdef189c9
Author:jjg
Date:  2010-08-25 11:40 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/70ebdef189c9

6960424: new option -Xpkginfo for better control of when package-info.class is 
generated
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/code/Attribute.java
! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Enter.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
! src/share/classes/com/sun/tools/javac/main/OptionName.java
! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java
! src/share/classes/com/sun/tools/javac/resources/javac.properties
+ test/tools/javac/TestPkgInfo.java

Changeset: ecff24121064
Author:naoto
Date:  2010-08-25 15:31 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/ecff24121064

6875847: Java Locale Enhancement
Summary: Fix for javac to allow sun.util.locale package accessible.
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/resources/legacy.properties

Changeset: cfd047f3cf60
Author:jjg
Date:  2010-08-26 15:17 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/cfd047f3cf60

6604599: ToolProvider should be less compiler-specific
Reviewed-by: darcy

! src/share/classes/javax/tools/ToolProvider.java
+ test/tools/javac/api/ToolProvider/HelloWorldTest.java
+ test/tools/javac/api/ToolProvider/ToolProviderTest1.java
+ test/tools/javac/api/ToolProvider/ToolProviderTest2.java

Changeset: ae3acbf63943
Author:jjg
Date:  2010-08-26 16:13 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/ae3acbf63943

6980017: javap -XDdetail:source behaves badly if source not available.
Reviewed-by: ksrini

! src/share/classes/com/sun/tools/javap/CodeWriter.java
! src/share/classes/com/sun/tools/javap/SourceWriter.java
+ test/tools/javap/T6980017.java

Changeset: 3a9f319be48a
Author:jjg
Date:  2010-08-27 17:14 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/3a9f319be48a

6980724: test/tools/javac/InterfaceAssert.java sometimes fails
Reviewed-by: darcy

! test/tools/javac/InterfaceAssert.java

Changeset: b4e7a57af8df
Author:jjg
Date:  2010-08-27 17:21 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/b4e7a57af8df

6570730: com.sun.source.tree.ModifiersTree.getFlags() should return class type
Reviewed-by: mcimadamore

! src/share/classes/com/sun/source/tree/Tree.java
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
- test/tools/javac/T6341023.java
+ test/tools/javac/tree/ClassTreeTest.java
+ test/tools/javac/tree/TreeKindTest.java

Changeset: eb7c263aab73
Author:jjg
Date:  2010-08-27 17:59 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/eb7c263aab73

6980707: Reduce use of IOException in JavaCompiler
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! src/share/classes/com/sun/tools/javac/main/Main.java
! 
src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javac/util/FatalError.java
! test/tools/javac/diags/examples.not-yet.txt

Changeset: 4124840b35fe
Author:jjg
Date:  2010-08-30 18:03 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/4124840b35fe

6403465: javac should defer diagnostics until it can be determined they are 
persistent
Reviewed-by: mcimadamore, darcy

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
!

hg: jdk7/deploy: 10 new changesets

2010-09-17 Thread andy . herrick

Changeset: d6ea39e0d3eb
Author:ohair
Date:  2010-09-07 15:13 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/d6ea39e0d3eb

6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform 
list
Reviewed-by: kamg

! make/jprt.properties

Changeset: 81dfc728d7bb
Author:cl
Date:  2010-09-08 14:04 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/81dfc728d7bb

Merge


Changeset: f241877c0ac9
Author:cl
Date:  2010-09-09 15:07 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/f241877c0ac9

Added tag jdk7-b109 for changeset 81dfc728d7bb

! .hgtags

Changeset: 782c0c738f6d
Author:ohair
Date:  2010-09-08 15:13 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/782c0c738f6d

6974017: Upgrade required Solaris Studio compilers to 5.10 (12 update 1 + 
patches)
Reviewed-by: jcoomes

! README-builds.html

Changeset: 973560f0387d
Author:cl
Date:  2010-09-08 17:29 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/973560f0387d

Merge


Changeset: c129c592e9d6
Author:ohair
Date:  2010-09-09 17:08 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/c129c592e9d6

6982137: Rebranding pass 2 - missed copyright changes
Reviewed-by: mbykov

! make/templates/gpl-cp-header
! make/templates/gpl-header

Changeset: 2a02d4a6955c
Author:cl
Date:  2010-09-15 13:40 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/2a02d4a6955c

Merge


Changeset: 85736b9f2026
Author:herrick
Date:  2010-09-17 07:08 -0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/85736b9f2026

Merge


Changeset: 9702d6fef68e
Author:cl
Date:  2010-09-16 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/9702d6fef68e

Added tag jdk7-b110 for changeset 2a02d4a6955c

! .hgtags

Changeset: d4a7e4600b21
Author:herrick
Date:  2010-09-17 07:10 -0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/d4a7e4600b21

Merge

hg: jdk7/deploy/corba: 4 new changesets

2010-09-17 Thread andy . herrick

Changeset: 3821536d79ab
Author:ohair
Date:  2010-09-07 15:16 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/3821536d79ab

6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform 
list
Reviewed-by: kamg

! make/jprt.properties

Changeset: c3dd858e09b2
Author:cl
Date:  2010-09-08 14:04 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/c3dd858e09b2

Merge


Changeset: 0e1f80fda227
Author:cl
Date:  2010-09-09 15:07 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/0e1f80fda227

Added tag jdk7-b109 for changeset c3dd858e09b2

! .hgtags

Changeset: 640fa4d4e2ad
Author:cl
Date:  2010-09-16 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/640fa4d4e2ad

Added tag jdk7-b110 for changeset 0e1f80fda227

! .hgtags

hg: jdk7/deploy/hotspot: 4 new changesets

2010-09-17 Thread andy . herrick

Changeset: 2fe09e2e70d0
Author:cl
Date:  2010-09-03 12:49 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/2fe09e2e70d0

Added tag jdk7-b108 for changeset e44a93947ccb

! .hgtags

Changeset: cc4bb3022b31
Author:cl
Date:  2010-09-09 14:27 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/cc4bb3022b31

Merge

! .hgtags
- src/share/vm/gc_implementation/parallelScavenge/prefetchQueue.hpp

Changeset: 2f25f2b8de27
Author:cl
Date:  2010-09-09 15:07 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/2f25f2b8de27

Added tag jdk7-b109 for changeset cc4bb3022b31

! .hgtags

Changeset: 07b042e13dde
Author:cl
Date:  2010-09-16 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/07b042e13dde

Added tag jdk7-b110 for changeset 2f25f2b8de27

! .hgtags

hg: jdk7/deploy/jaxp: 4 new changesets

2010-09-17 Thread andy . herrick

Changeset: cc845b339690
Author:ohair
Date:  2010-09-07 15:15 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/cc845b339690

6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform 
list
Reviewed-by: kamg

! make/jprt.properties

Changeset: 0f382d6120fc
Author:cl
Date:  2010-09-08 14:04 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/0f382d6120fc

Merge


Changeset: d422dbdd0976
Author:cl
Date:  2010-09-09 15:07 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/d422dbdd0976

Added tag jdk7-b109 for changeset 0f382d6120fc

! .hgtags

Changeset: 8106c747067c
Author:cl
Date:  2010-09-16 15:13 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/8106c747067c

Added tag jdk7-b110 for changeset d422dbdd0976

! .hgtags

hg: jdk7/deploy/jaxws: 4 new changesets

2010-09-17 Thread andy . herrick

Changeset: 06c51671c84b
Author:ohair
Date:  2010-09-07 15:16 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/06c51671c84b

6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform 
list
Reviewed-by: kamg

! make/jprt.properties

Changeset: 4f626e0d70bd
Author:cl
Date:  2010-09-08 14:04 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/4f626e0d70bd

Merge


Changeset: 95ecac35fb11
Author:cl
Date:  2010-09-09 15:07 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/95ecac35fb11

Added tag jdk7-b109 for changeset 4f626e0d70bd

! .hgtags

Changeset: 2575ebca96c7
Author:cl
Date:  2010-09-16 15:13 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxws/rev/2575ebca96c7

Added tag jdk7-b110 for changeset 95ecac35fb11

! .hgtags

hg: jdk7/deploy/jdk: 13 new changesets

2010-09-17 Thread andy . herrick

Changeset: df049d0b973f
Author:ohair
Date:  2010-09-07 15:17 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/df049d0b973f

6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform 
list
Reviewed-by: kamg

! make/jprt.properties

Changeset: 4571856d4628
Author:cl
Date:  2010-09-03 12:50 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/4571856d4628

Added tag jdk7-b108 for changeset 17a5d84b7561

! .hgtags

Changeset: ab0d3f54a63f
Author:cl
Date:  2010-09-09 13:48 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/ab0d3f54a63f

Merge


Changeset: 3937dd29f45a
Author:cl
Date:  2010-09-09 15:07 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/3937dd29f45a

Added tag jdk7-b109 for changeset ab0d3f54a63f

! .hgtags

Changeset: c5f6cd3bd70b
Author:ohair
Date:  2010-09-08 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/c5f6cd3bd70b

6974017: Upgrade required Solaris Studio compilers to 5.10 (12 update 1 + 
patches)
Reviewed-by: jcoomes

! make/common/shared/Compiler-sun.gmk
! make/common/shared/Defs-versions.gmk

Changeset: 8f5a6ea8c9e9
Author:ohair
Date:  2010-09-09 16:26 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/8f5a6ea8c9e9

6982137: Rebranding pass 2 - missed copyright changes
Reviewed-by: mbykov

! make/templates/gpl-cp-header
! make/templates/gpl-header
! src/share/classes/java/lang/CharacterName.java
! src/share/classes/sun/font/GlyphDisposedListener.java
! src/share/classes/sun/jvmstat/monitor/Units.java
! src/share/classes/sun/jvmstat/monitor/Variability.java
! src/solaris/classes/sun/font/XRGlyphCache.java
! src/solaris/classes/sun/font/XRGlyphCacheEntry.java
! src/solaris/classes/sun/font/XRTextRenderer.java
! src/solaris/classes/sun/java2d/jules/IdleTileCache.java
! src/solaris/classes/sun/java2d/jules/JulesAATileGenerator.java
! src/solaris/classes/sun/java2d/jules/JulesPathBuf.java
! src/solaris/classes/sun/java2d/jules/JulesRenderingEngine.java
! src/solaris/classes/sun/java2d/jules/JulesShapePipe.java
! src/solaris/classes/sun/java2d/jules/JulesTile.java
! src/solaris/classes/sun/java2d/jules/TileWorker.java
! src/solaris/classes/sun/java2d/jules/TrapezoidList.java
! src/solaris/classes/sun/java2d/xr/DirtyRegion.java
! src/solaris/classes/sun/java2d/xr/GrowableByteArray.java
! src/solaris/classes/sun/java2d/xr/GrowableEltArray.java
! src/solaris/classes/sun/java2d/xr/GrowableIntArray.java
! src/solaris/classes/sun/java2d/xr/GrowablePointArray.java
! src/solaris/classes/sun/java2d/xr/GrowableRectArray.java
! src/solaris/classes/sun/java2d/xr/MaskTile.java
! src/solaris/classes/sun/java2d/xr/MaskTileManager.java
! src/solaris/classes/sun/java2d/xr/MutableInteger.java
! src/solaris/classes/sun/java2d/xr/XIDGenerator.java
! src/solaris/classes/sun/java2d/xr/XRBackend.java
! src/solaris/classes/sun/java2d/xr/XRBackendNative.java
! src/solaris/classes/sun/java2d/xr/XRColor.java
! src/solaris/classes/sun/java2d/xr/XRCompositeManager.java
! src/solaris/classes/sun/java2d/xr/XRDrawImage.java
! src/solaris/classes/sun/java2d/xr/XRGraphicsConfig.java
! src/solaris/classes/sun/java2d/xr/XRMaskBlit.java
! src/solaris/classes/sun/java2d/xr/XRMaskFill.java
! src/solaris/classes/sun/java2d/xr/XRMaskImage.java
! src/solaris/classes/sun/java2d/xr/XRPMBlitLoops.java
! src/solaris/classes/sun/java2d/xr/XRPaints.java
! src/solaris/classes/sun/java2d/xr/XRRenderer.java
! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java
! src/solaris/classes/sun/java2d/xr/XRSurfaceDataProxy.java
! src/solaris/classes/sun/java2d/xr/XRUtils.java
! src/solaris/classes/sun/java2d/xr/XRVolatileSurfaceManager.java
! src/solaris/classes/sun/java2d/xr/XcbRequestCounter.java
! src/solaris/native/sun/java2d/x11/XRBackendNative.c
! src/solaris/native/sun/java2d/x11/XRSurfaceData.c
! test/com/sun/java/swing/plaf/gtk/Test6963870.java
! test/java/lang/StringBuffer/Capacity.java
! test/java/security/cert/CertificateFactory/openssl/BadFooter.java
! test/java/util/zip/GZIP/GZIPInputStreamRead.java
! test/javax/swing/JFormattedTextField/Test6462562.java
! test/javax/swing/JTabbedPane/6670274/bug6670274.java
! test/javax/swing/JTable/6768387/bug6768387.java
! test/javax/swing/JTable/6788484/bug6788484.java
! test/javax/swing/JTable/6937798/bug6937798.java
! test/javax/swing/JTableHeader/6884066/bug6884066.java
! test/javax/swing/JTableHeader/6889007/bug6889007.java
! test/javax/swing/JTextArea/6925473/bug6925473.java
! test/javax/swing/JTextArea/6940863/bug6940863.java
! test/javax/swing/JViewport/6953396/bug6953396.java
! test/javax/swing/border/Test6910490.java
! test/javax/swing/plaf/synth/SynthToolBarUI/6739756/bug6739756.java
! test/javax/swing/text/WrappedPlainView/6857057/StubBranchElement.java
! test/javax/swing/text/WrappedPlainView/6857057/StubLeafElement.java
! test/javax/swing/text/WrappedPlainView/6857057/bug6857057.java
! test/sun/security/krb5/MicroTime.java

hg: jdk7/deploy/corba: Added tag jdk7-b108 for changeset 8d810527b499

2010-09-03 Thread andy . herrick

Changeset: 74d57b218468
Author:cl
Date:  2010-09-03 12:49 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/74d57b218468

Added tag jdk7-b108 for changeset 8d810527b499

! .hgtags

hg: jdk7/deploy: Added tag jdk7-b108 for changeset 140fdef4ddf5

2010-09-03 Thread andy . herrick

Changeset: 0df9c57eb80d
Author:cl
Date:  2010-09-03 12:49 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/0df9c57eb80d

Added tag jdk7-b108 for changeset 140fdef4ddf5

! .hgtags

hg: jdk7/deploy/jaxp: Added tag jdk7-b108 for changeset 7d379f8934ca

2010-09-03 Thread andy . herrick

Changeset: 840d6acde4e8
Author:cl
Date:  2010-09-03 12:49 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/840d6acde4e8

Added tag jdk7-b108 for changeset 7d379f8934ca

! .hgtags

hg: jdk7/deploy: 3 new changesets

2010-08-20 Thread andy . herrick

Changeset: 9f96a4269d77
Author:cl
Date:  2010-08-06 12:51 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/9f96a4269d77

Added tag jdk7-b104 for changeset f8be576feefc

! .hgtags

Changeset: 43096cccf1ce
Author:cl
Date:  2010-08-13 11:38 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/43096cccf1ce

Added tag jdk7-b105 for changeset 9f96a4269d77

! .hgtags

Changeset: 7d396ad455c3
Author:cl
Date:  2010-08-19 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/rev/7d396ad455c3

Added tag jdk7-b106 for changeset 43096cccf1ce

! .hgtags

hg: jdk7/deploy/corba: 3 new changesets

2010-08-20 Thread andy . herrick

Changeset: 6f21b030092f
Author:cl
Date:  2010-08-06 12:51 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/6f21b030092f

Added tag jdk7-b104 for changeset 9607213481d4

! .hgtags

Changeset: 519daea4
Author:cl
Date:  2010-08-13 11:38 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/519daea4

Added tag jdk7-b105 for changeset 6f21b030092f

! .hgtags

Changeset: 232adb83eae8
Author:cl
Date:  2010-08-19 15:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/corba/rev/232adb83eae8

Added tag jdk7-b106 for changeset 519daea4

! .hgtags

hg: jdk7/deploy/jaxp: 3 new changesets

2010-08-20 Thread andy . herrick

Changeset: 3233b9a4c12e
Author:cl
Date:  2010-08-06 12:51 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/3233b9a4c12e

Added tag jdk7-b104 for changeset d42c4acb6424

! .hgtags

Changeset: 5ba8469212a6
Author:cl
Date:  2010-08-13 11:38 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/5ba8469212a6

Added tag jdk7-b105 for changeset 3233b9a4c12e

! .hgtags

Changeset: 20ee37c1372a
Author:cl
Date:  2010-08-19 15:13 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jaxp/rev/20ee37c1372a

Added tag jdk7-b106 for changeset 5ba8469212a6

! .hgtags

hg: jdk7/deploy/jdk: 50 new changesets

2010-08-20 Thread andy . herrick

Changeset: 6950da80c75c
Author:ohair
Date:  2010-08-02 16:31 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/6950da80c75c

6973616: Update minimum boot jdk from 1.5 to 1.6
Reviewed-by: igor, jjg

! make/common/shared/Defs-versions.gmk

Changeset: dd48c78218a7
Author:ohair
Date:  2010-08-02 16:31 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/dd48c78218a7

6971426: jdk/make/docs docs target does not work on windows
Reviewed-by: igor, jjg

! make/docs/Makefile

Changeset: f46ec75b1663
Author:ohair
Date:  2010-08-03 10:53 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/f46ec75b1663

6974239: Correct reference to jdk document site in javadoc
Reviewed-by: skannan

! make/docs/Makefile

Changeset: 1a92820132a0
Author:cl
Date:  2010-08-04 22:02 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/1a92820132a0

Merge


Changeset: d967f8507d9d
Author:cl
Date:  2010-08-06 12:52 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/d967f8507d9d

Added tag jdk7-b104 for changeset 1a92820132a0

! .hgtags

Changeset: 539528c5d395
Author:lana
Date:  2010-07-14 09:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/539528c5d395

Merge


Changeset: cf0c23a99823
Author:lana
Date:  2010-07-29 17:12 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/cf0c23a99823

Merge

- src/linux/doc/man/ja/kinit.1
- src/linux/doc/man/ja/klist.1
- src/linux/doc/man/ja/ktab.1
- test/java/nio/channels/ServerSocketChannel/AcceptAddress.java
- test/java/nio/charset/coders/Surrogate.java
- test/tools/launcher/Makefile.SolarisRunpath
- test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so
- test/tools/launcher/lib/i386/lib32/liblibrary.so
- test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so
- test/tools/launcher/lib/sparc/lib32/liblibrary.so
- test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so
- test/tools/launcher/lib/sparc/lib64/liblibrary.so

Changeset: c6f443c3d96a
Author:lana
Date:  2010-08-02 19:41 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/c6f443c3d96a

Merge


Changeset: c38803ce0560
Author:uta
Date:  2010-07-23 18:59 +0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/c38803ce0560

6969851: VM hangs/crashes in FileDialog test (VS2008/2010 build)
Reviewed-by: prr, art

! src/windows/native/sun/windows/awt.h

Changeset: 9bb8d5c093fc
Author:lana
Date:  2010-07-29 13:48 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/9bb8d5c093fc

Merge

- src/linux/doc/man/ja/kinit.1
- src/linux/doc/man/ja/klist.1
- src/linux/doc/man/ja/ktab.1
- test/java/nio/channels/ServerSocketChannel/AcceptAddress.java
- test/java/nio/charset/coders/Surrogate.java
- test/tools/launcher/Makefile.SolarisRunpath
- test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so
- test/tools/launcher/lib/i386/lib32/liblibrary.so
- test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so
- test/tools/launcher/lib/sparc/lib32/liblibrary.so
- test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so
- test/tools/launcher/lib/sparc/lib64/liblibrary.so

Changeset: 8a72583dc41d
Author:lana
Date:  2010-08-02 19:42 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/8a72583dc41d

Merge


Changeset: 65403b9bcb58
Author:peterz
Date:  2010-07-13 17:26 +0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/65403b9bcb58

6462562: InternationalFormatter inserts text incorrectly
6578432: Currency format instance does not work with Swing's NumberFormatter
Reviewed-by: rupashka

! src/share/classes/javax/swing/text/DefaultFormatter.java
! src/share/classes/javax/swing/text/InternationalFormatter.java
+ test/javax/swing/JFormattedTextField/Test6462562.java

Changeset: a0d7b76abcd3
Author:alexp
Date:  2010-07-29 19:34 +0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/a0d7b76abcd3

4743225: Size of JComboBox list is wrong when list is populated via 
PopupMenuListener
Reviewed-by: rupashka

! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java
+ test/javax/swing/JComboBox/4743225/bug4743225.java

Changeset: 0e8acbf12695
Author:lana
Date:  2010-07-29 13:22 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/jdk/rev/0e8acbf12695

Merge

- src/linux/doc/man/ja/kinit.1
- src/linux/doc/man/ja/klist.1
- src/linux/doc/man/ja/ktab.1
- test/java/nio/channels/ServerSocketChannel/AcceptAddress.java
- test/java/nio/charset/coders/Surrogate.java
- test/tools/launcher/Makefile.SolarisRunpath
- test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so
- test/tools/launcher/lib/i386/lib32/liblibrary.so
- test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so
- test/tools/launcher/lib/sparc/lib32/liblibrary.so
- test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so
- test/tools/launcher/lib/sparc/lib64/liblibrary.so

Changeset: 951e46d93af0
Author:malenkov
Date:  2010-07-30 19:21 +0400
URL:

hg: jdk7/deploy/hotspot: 30 new changesets

2010-08-20 Thread andy . herrick

Changeset: b4acf10eb134
Author:trims
Date:  2010-08-05 02:48 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/b4acf10eb134

Added tag hs19-b04 for changeset e55900b5c1b8

! .hgtags

Changeset: 6709c14587c2
Author:cl
Date:  2010-08-06 12:51 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/6709c14587c2

Added tag jdk7-b104 for changeset b4acf10eb134

! .hgtags

Changeset: 3dc64719cf18
Author:cl
Date:  2010-08-13 11:38 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/3dc64719cf18

Added tag jdk7-b105 for changeset 6709c14587c2

! .hgtags

Changeset: a81afd9c293c
Author:alanb
Date:  2010-07-16 13:14 +0100
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/a81afd9c293c

6649594: Intermittent IOExceptions during dynamic attach on linux and solaris
Reviewed-by: dcubed, dholmes

! src/os/linux/vm/attachListener_linux.cpp
! src/os/solaris/vm/attachListener_solaris.cpp

Changeset: 920aa833fd16
Author:apangin
Date:  2010-07-17 21:49 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/920aa833fd16

Merge


Changeset: a5c9d63a187d
Author:apangin
Date:  2010-07-20 08:41 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/a5c9d63a187d

6964170: Verifier crashes
Summary: Check if klassOop != NULL rather than klass_part != NULL
Reviewed-by: kamg, never

! src/share/vm/classfile/verificationType.cpp
! src/share/vm/classfile/verifier.cpp

Changeset: 7f0fdccac34f
Author:apangin
Date:  2010-07-25 07:31 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/7f0fdccac34f

Merge

! src/share/vm/classfile/verifier.cpp

Changeset: 3d90023429ec
Author:aph
Date:  2010-07-28 17:38 +0100
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/3d90023429ec

6888526: Linux getCurrentThreadCpuTime is drastically slower than Windows
Reviewed-by: dcubed, dholmes

! src/os/linux/vm/globals_linux.hpp
! src/share/vm/runtime/arguments.cpp

Changeset: a64438a2b7e8
Author:coleenp
Date:  2010-07-28 17:57 -0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/a64438a2b7e8

6958465: Sparc aten build24.0: openjdk-7.ea-b96 failed Error: Formal argument 
... requires an lvalue
Summary: Fix compilation errors.  Made non-const references const so can be 
assigned with lvalue.
Reviewed-by: phh, xlu

! src/cpu/sparc/vm/assembler_sparc.cpp
! src/cpu/sparc/vm/assembler_sparc.hpp
! src/cpu/sparc/vm/assembler_sparc.inline.hpp

Changeset: 126ea7725993
Author:bobv
Date:  2010-08-03 08:13 -0400
URL:   http://hg.openjdk.java.net/jdk7/deploy/hotspot/rev/126ea7725993

6953477: Increase portability and flexibility of building Hotspot
Summary: A collection of portability improvements including shared code support 
for PPC, ARM platforms, software floating point, cross compilation support and 
improvements in error crash detail.
Reviewed-by: phh, never, coleenp, dholmes

! agent/src/os/linux/ps_proc.c
! make/Makefile
! make/defs.make
! make/linux/makefiles/build_vm_def.sh
! make/linux/makefiles/buildtree.make
! make/linux/makefiles/defs.make
! make/linux/makefiles/gcc.make
! make/linux/makefiles/product.make
! make/linux/makefiles/sa.make
! make/linux/makefiles/saproc.make
! make/linux/makefiles/vm.make
! make/solaris/makefiles/defs.make
! src/cpu/sparc/vm/bytecodeInterpreter_sparc.inline.hpp
! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp
! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp
! src/cpu/sparc/vm/interpreterRT_sparc.cpp
! src/cpu/sparc/vm/javaFrameAnchor_sparc.hpp
! src/cpu/sparc/vm/templateTable_sparc.cpp
! src/cpu/x86/vm/bytecodeInterpreter_x86.inline.hpp
! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp
! src/cpu/x86/vm/c1_Runtime1_x86.cpp
! src/cpu/x86/vm/frame_x86.cpp
! src/cpu/x86/vm/interpreterRT_x86_32.cpp
! src/cpu/x86/vm/javaFrameAnchor_x86.hpp
! src/cpu/x86/vm/templateTable_x86_32.cpp
! src/cpu/x86/vm/templateTable_x86_64.cpp
! src/os/linux/launcher/java_md.c
! src/os/linux/vm/os_linux.cpp
! src/os/solaris/vm/os_solaris.cpp
! src/os/windows/vm/os_windows.cpp
! src/os_cpu/linux_sparc/vm/thread_linux_sparc.cpp
! src/os_cpu/linux_x86/vm/os_linux_x86.cpp
! src/os_cpu/linux_x86/vm/thread_linux_x86.cpp
! src/os_cpu/linux_zero/vm/thread_linux_zero.cpp
! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp
! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.cpp
! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp
! src/os_cpu/solaris_x86/vm/thread_solaris_x86.cpp
! src/os_cpu/windows_x86/vm/os_windows_x86.cpp
! src/os_cpu/windows_x86/vm/thread_windows_x86.cpp
! src/share/vm/asm/codeBuffer.hpp
! src/share/vm/c1/c1_CodeStubs.hpp
! src/share/vm/c1/c1_Compilation.hpp
! src/share/vm/c1/c1_FrameMap.cpp
! src/share/vm/c1/c1_FrameMap.hpp
! src/share/vm/c1/c1_LIR.cpp
! src/share/vm/c1/c1_LIR.hpp
! src/share/vm/c1/c1_LIRGenerator.cpp
! src/share/vm/c1/c1_LIRGenerator.hpp
! src/share/vm/c1/c1_LinearScan.cpp
! src/share/vm/c1/c1_Runtime1.cpp
! src/share/vm/c1/c1_Runtime1.hpp
!

hg: jdk7/deploy/langtools: 25 new changesets

2010-08-20 Thread andy . herrick

Changeset: 49489c1d8fae
Author:cl
Date:  2010-08-06 12:52 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/49489c1d8fae

Added tag jdk7-b104 for changeset fc7219517ec1

! .hgtags

Changeset: a5454419dd46
Author:jjg
Date:  2010-07-13 19:14 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/a5454419dd46

6966732: replace use of static Log.getLocalizedString with non-static 
alternative where possible
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! 
src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
! src/share/classes/com/sun/tools/javac/util/Log.java

Changeset: 0e1fab5cffc8
Author:jjg
Date:  2010-07-13 19:17 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/0e1fab5cffc8

6968434: test CheckResourceKeys fails on control builds
Reviewed-by: darcy

! test/tools/javac/diags/CheckResourceKeys.java

Changeset: e57b27703e8b
Author:jjg
Date:  2010-07-13 19:20 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/e57b27703e8b

6968789: incorrect  text in diamond not supported message
Reviewed-by: darcy

! src/share/classes/com/sun/tools/javac/resources/compiler.properties

Changeset: b49b0d72c071
Author:mcimadamore
Date:  2010-07-15 16:31 +0100
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/b49b0d72c071

6967002: JDK7 b99 javac compilation error (java.lang.AssertionError)
Summary: bug in JavacParser related to parsing of type annotations in varargs 
position
Reviewed-by: jjg
Contributed-by: mahm...@notnoop.com

! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
+ test/tools/javac/typeAnnotations/6967002/T6967002.java
+ test/tools/javac/typeAnnotations/6967002/T6967002.out

Changeset: 472e74211e11
Author:mcimadamore
Date:  2010-07-15 16:31 +0100
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/472e74211e11

6964669: javac reports error on miranda methods
Summary: synthetic name clash check should not apply to miranda methods
Reviewed-by: jjg
Contributed-by: tomas.zez...@sun.com

! src/share/classes/com/sun/tools/javac/comp/Check.java
+ test/tools/javac/miranda/6964669/T6964669.java
+ test/tools/javac/miranda/6964669/pkg/A.java
+ test/tools/javac/miranda/6964669/pkg/B.java
+ test/tools/javac/miranda/6964669/pkg/C.java

Changeset: 13354e1abba7
Author:darcy
Date:  2010-07-16 19:35 -0700
URL:   http://hg.openjdk.java.net/jdk7/deploy/langtools/rev/13354e1abba7

6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in 
the compiler
6964740: Project Coin: More tests for ARM compiler changes
6965277: Project Coin: Correctness issues in ARM implementation
6967065: add -Xlint warning category for Automatic Resource Management (ARM)
Reviewed-by: jjb, darcy, mcimadamore, jjg, briangoetz
Contributed-by: tb...@google.com

! make/build.properties
! src/share/classes/com/sun/source/tree/TryTree.java
! src/share/classes/com/sun/source/util/TreeScanner.java
! src/share/classes/com/sun/tools/javac/code/Lint.java
! src/share/classes/com/sun/tools/javac/code/Source.java
! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classes/com/sun/tools/javac/code/Symtab.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/Flow.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/classes/com/sun/tools/javac/comp/TransTypes.java
! src/share/classes/com/sun/tools/javac/jvm/CRTable.java
! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
! src/share/classes/com/sun/tools/javac/tree/Pretty.java
! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java
! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java
! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java
! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java
! src/share/classes/com/sun/tools/javac/util/Names.java
+ test/tools/javac/TryWithResources/ArmLint.java
+ test/tools/javac/TryWithResources/ArmLint.out
+ test/tools/javac/TryWithResources/BadTwr.java
+ test/tools/javac/TryWithResources/BadTwr.out
+ test/tools/javac/TryWithResources/BadTwrSyntax.java
+ test/tools/javac/TryWithResources/BadTwrSyntax.out
+ test/tools/javac/TryWithResources/DuplicateResource.java
+ test/tools/javac/TryWithResources/DuplicateResourceDecl.java
+ test/tools/javac/TryWithResources/DuplicateResourceDecl.out
+ test/tools/javac/TryWithResources/ImplicitFinal.java
+ test/tools/javac/TryWithResources/ImplicitFinal.out
+ test/tools/javac/TryWithResources/PlainTry.java
+ test/tools/javac/TryWithResources/PlainTry.out
+

81 matches

Mail list logo