Re: RFR(S) 8197453 : Add support of extra problem list

[Erik Joelsson]

Makefile change looks good.

/Erik


On 2018-02-27 09:45, Ekaterina Pavlova wrote:

Jon,

thanks for the review.
I have updated the webrev.

thanks,
-katya


On 2/26/18 12:02 PM, Jonathan Gibbons wrote:
If these new problem-list files are destined for use by jtreg, I 
would encourage adding a platform specifier on each line, after the 
bug number. If you want to mark the test as excluded on all 
platforms, the convention is to use "generic-all".


-- Jon


On 2/26/18 11:47 AM, Igor Ignatyev wrote:

adding build-dev alias

-- Igor

On Feb 8, 2018, at 3:08 PM, Ekaterina Pavlova 
 wrote:


Hi all,

ProblemList.txt files used by makefiles for jtreg testing allow to 
specify list of tests to be excluded
from execution on all or specific platforms. However to test such 
features like Graal we want to be able
to specify list of failed tests which fail in particular JVM mode 
only.
Please review this change which adds support of extra problem list 
and introduces 2 Graal specific problem list files.

- test/hotspot/jtreg/ProblemList-graal.txt
- test/jdk/ProblemList-graal.txt


 JBS: https://bugs.openjdk.java.net/browse/JDK-8197453
  webrev: http://cr.openjdk.java.net/~epavlova//8197453/webrev.00/
testing: precheckin, tier1 and tier2 with empty EXTRA_PROBLEM_LISTS.
  testing in Graal mode with 
EXTRA_PROBLEM_LISTS=ProblemList-graal.txt


thanks,
-katya

p.s.
Igor Ignatyev volunteered to sponsor this change.

Re: RFR(S) 8197453 : Add support of extra problem list

[Igor Ignatyev]

Hi Katya,

the fix looks good to me.

-- Igor

> On Feb 27, 2018, at 9:45 AM, Ekaterina Pavlova  
> wrote:
> 
> Jon,
> 
> thanks for the review.
> I have updated the webrev.
> 
> thanks,
> -katya
> 
> 
> On 2/26/18 12:02 PM, Jonathan Gibbons wrote:
>> If these new problem-list files are destined for use by jtreg, I would 
>> encourage adding a platform specifier on each line, after the bug number. If 
>> you want to mark the test as excluded on all platforms, the convention is to 
>> use "generic-all".
>> -- Jon
>> On 2/26/18 11:47 AM, Igor Ignatyev wrote:
>>> adding build-dev alias
>>> 
>>> -- Igor
>>> 
 On Feb 8, 2018, at 3:08 PM, Ekaterina Pavlova 
  wrote:
 
 Hi all,
 
 ProblemList.txt files used by makefiles for jtreg testing allow to specify 
 list of tests to be excluded
 from execution on all or specific platforms. However to test such features 
 like Graal we want to be able
 to specify list of failed tests which fail in particular JVM mode only.
 Please review this change which adds support of extra problem list and 
 introduces 2 Graal specific problem list files.
 - test/hotspot/jtreg/ProblemList-graal.txt
 - test/jdk/ProblemList-graal.txt
 
 
  JBS: https://bugs.openjdk.java.net/browse/JDK-8197453
   webrev: http://cr.openjdk.java.net/~epavlova//8197453/webrev.00/
 testing: precheckin, tier1 and tier2 with empty EXTRA_PROBLEM_LISTS.
   testing in Graal mode with 
 EXTRA_PROBLEM_LISTS=ProblemList-graal.txt
 
 thanks,
 -katya
 
 p.s.
 Igor Ignatyev volunteered to sponsor this change.
> 

Re: RFR(S) 8197453 : Add support of extra problem list

[Ekaterina Pavlova]

Jon,

thanks for the review.
I have updated the webrev.

thanks,
-katya


On 2/26/18 12:02 PM, Jonathan Gibbons wrote:

If these new problem-list files are destined for use by jtreg, I would encourage adding a 
platform specifier on each line, after the bug number. If you want to mark the test as 
excluded on all platforms, the convention is to use "generic-all".

-- Jon


On 2/26/18 11:47 AM, Igor Ignatyev wrote:

adding build-dev alias

-- Igor


On Feb 8, 2018, at 3:08 PM, Ekaterina Pavlova  
wrote:

Hi all,

ProblemList.txt files used by makefiles for jtreg testing allow to specify list 
of tests to be excluded
from execution on all or specific platforms. However to test such features like 
Graal we want to be able
to specify list of failed tests which fail in particular JVM mode only.
Please review this change which adds support of extra problem list and 
introduces 2 Graal specific problem list files.
- test/hotspot/jtreg/ProblemList-graal.txt
- test/jdk/ProblemList-graal.txt


 JBS: https://bugs.openjdk.java.net/browse/JDK-8197453
  webrev: http://cr.openjdk.java.net/~epavlova//8197453/webrev.00/
testing: precheckin, tier1 and tier2 with empty EXTRA_PROBLEM_LISTS.
  testing in Graal mode with EXTRA_PROBLEM_LISTS=ProblemList-graal.txt

thanks,
-katya

p.s.
Igor Ignatyev volunteered to sponsor this change.

Re: RFR(S) 8197453 : Add support of extra problem list

[Jonathan Gibbons]

Igor,

I think this is more a style issue than an issue we want to enforce. I 
think it is good style to use a platform specifier, including 
generic-all for "all platforms", so that people will realize they can 
put some more restrictive alternative.


-- Jon

On 02/26/2018 03:07 PM, Igor Ignatyev wrote:

Hi Jon,

yes, they are. we will  generic-all to each line.

do you think it makes sense to file an RFE for jtreg to report a missed 
platform specifier as an error?

Thanks,
-- Igor


On Feb 26, 2018, at 12:02 PM, Jonathan Gibbons  
wrote:

If these new problem-list files are destined for use by jtreg, I would encourage adding a 
platform specifier on each line, after the bug number. If you want to mark the test as 
excluded on all platforms, the convention is to use "generic-all".

-- Jon


On 2/26/18 11:47 AM, Igor Ignatyev wrote:

adding build-dev alias

-- Igor


On Feb 8, 2018, at 3:08 PM, Ekaterina Pavlova  
wrote:

Hi all,

ProblemList.txt files used by makefiles for jtreg testing allow to specify list 
of tests to be excluded
from execution on all or specific platforms. However to test such features like 
Graal we want to be able
to specify list of failed tests which fail in particular JVM mode only.
Please review this change which adds support of extra problem list and 
introduces 2 Graal specific problem list files.
- test/hotspot/jtreg/ProblemList-graal.txt
- test/jdk/ProblemList-graal.txt


 JBS: https://bugs.openjdk.java.net/browse/JDK-8197453
  webrev: http://cr.openjdk.java.net/~epavlova//8197453/webrev.00/
testing: precheckin, tier1 and tier2 with empty EXTRA_PROBLEM_LISTS.
  testing in Graal mode with EXTRA_PROBLEM_LISTS=ProblemList-graal.txt

thanks,
-katya

p.s.
Igor Ignatyev volunteered to sponsor this change.

Re: RFR(S) 8197453 : Add support of extra problem list

[Igor Ignatyev]

Hi Jon,

yes, they are. we will  generic-all to each line.

do you think it makes sense to file an RFE for jtreg to report a missed 
platform specifier as an error?

Thanks,
-- Igor 

> On Feb 26, 2018, at 12:02 PM, Jonathan Gibbons  
> wrote:
> 
> If these new problem-list files are destined for use by jtreg, I would 
> encourage adding a platform specifier on each line, after the bug number. If 
> you want to mark the test as excluded on all platforms, the convention is to 
> use "generic-all".
> 
> -- Jon
> 
> 
> On 2/26/18 11:47 AM, Igor Ignatyev wrote:
>> adding build-dev alias
>> 
>> -- Igor
>> 
>>> On Feb 8, 2018, at 3:08 PM, Ekaterina Pavlova 
>>>  wrote:
>>> 
>>> Hi all,
>>> 
>>> ProblemList.txt files used by makefiles for jtreg testing allow to specify 
>>> list of tests to be excluded
>>> from execution on all or specific platforms. However to test such features 
>>> like Graal we want to be able
>>> to specify list of failed tests which fail in particular JVM mode only.
>>> Please review this change which adds support of extra problem list and 
>>> introduces 2 Graal specific problem list files.
>>> - test/hotspot/jtreg/ProblemList-graal.txt
>>> - test/jdk/ProblemList-graal.txt
>>> 
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8197453
>>>  webrev: http://cr.openjdk.java.net/~epavlova//8197453/webrev.00/
>>> testing: precheckin, tier1 and tier2 with empty EXTRA_PROBLEM_LISTS.
>>>  testing in Graal mode with 
>>> EXTRA_PROBLEM_LISTS=ProblemList-graal.txt
>>> 
>>> thanks,
>>> -katya
>>> 
>>> p.s.
>>> Igor Ignatyev volunteered to sponsor this change.
> 

Re: RFR(S) 8197453 : Add support of extra problem list

[Jonathan Gibbons]

If these new problem-list files are destined for use by jtreg, I would 
encourage adding a platform specifier on each line, after the bug 
number. If you want to mark the test as excluded on all platforms, the 
convention is to use "generic-all".


-- Jon


On 2/26/18 11:47 AM, Igor Ignatyev wrote:

adding build-dev alias

-- Igor


On Feb 8, 2018, at 3:08 PM, Ekaterina Pavlova  
wrote:

Hi all,

ProblemList.txt files used by makefiles for jtreg testing allow to specify list 
of tests to be excluded
from execution on all or specific platforms. However to test such features like 
Graal we want to be able
to specify list of failed tests which fail in particular JVM mode only.
Please review this change which adds support of extra problem list and 
introduces 2 Graal specific problem list files.
- test/hotspot/jtreg/ProblemList-graal.txt
- test/jdk/ProblemList-graal.txt


 JBS: https://bugs.openjdk.java.net/browse/JDK-8197453
  webrev: http://cr.openjdk.java.net/~epavlova//8197453/webrev.00/
testing: precheckin, tier1 and tier2 with empty EXTRA_PROBLEM_LISTS.
  testing in Graal mode with EXTRA_PROBLEM_LISTS=ProblemList-graal.txt

thanks,
-katya

p.s.
Igor Ignatyev volunteered to sponsor this change.

Re: RFR(S) 8197453 : Add support of extra problem list

[Igor Ignatyev]

adding build-dev alias

-- Igor

> On Feb 8, 2018, at 3:08 PM, Ekaterina Pavlova  
> wrote:
> 
> Hi all,
> 
> ProblemList.txt files used by makefiles for jtreg testing allow to specify 
> list of tests to be excluded
> from execution on all or specific platforms. However to test such features 
> like Graal we want to be able
> to specify list of failed tests which fail in particular JVM mode only.
> Please review this change which adds support of extra problem list and 
> introduces 2 Graal specific problem list files.
> - test/hotspot/jtreg/ProblemList-graal.txt
> - test/jdk/ProblemList-graal.txt
> 
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8197453
>  webrev: http://cr.openjdk.java.net/~epavlova//8197453/webrev.00/
> testing: precheckin, tier1 and tier2 with empty EXTRA_PROBLEM_LISTS.
>  testing in Graal mode with EXTRA_PROBLEM_LISTS=ProblemList-graal.txt
> 
> thanks,
> -katya
> 
> p.s.
> Igor Ignatyev volunteered to sponsor this change.