RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac
Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk.java.net/~michaelm/7076487/webrev.1/ Thanks, Michael.
Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac
Thank you for doing this Michael. The changes look good to me, but someone from the build group should cast an eye on the makefile changes. -Chris. On 10/10/2013 11:10 AM, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk.java.net/~michaelm/7076487/webrev.1/ Thanks, Michael.
Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac
On 10/10/2013 11:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk.java.net/~michaelm/7076487/webrev.1/ This looks okay to me (I didn't look at the Sctp* sources closely as I assume they are just a copy of the dummy implementation from src/windows). A minor comment (a question) is whether there is a convention to sort the values of EXFILES or not. If there is then you might have to re-order them. -Alan
Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac
On 10/10/13 12:01, Alan Bateman wrote: On 10/10/2013 11:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk.java.net/~michaelm/7076487/webrev.1/ This looks okay to me (I didn't look at the Sctp* sources closely as I assume they are just a copy of the dummy implementation from src/windows). Yes. That's what I meant to say. The sources are copied from the windows tree. They just throw UnsupportedOperationException, but it means that Sctp tests can be compiled on all the reference platforms now. A minor comment (a question) is whether there is a convention to sort the values of EXFILES or not. If there is then you might have to re-order them. Right. I'll defer to someone from build on that question. Thanks Michael
Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac
On 2013-10-10 12:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk.java.net/~michaelm/7076487/webrev.1/ The build part looks fine to me. /Magnus
Re: RFR: 7076487 (sctp) SCTP API classes does not exist in JDK for Mac
On 10/10/13 04:12 AM, Magnus Ihse Bursie wrote: On 2013-10-10 12:10, Michael McMahon wrote: Can I get the following change for jdk 8 reviewed please? It's a simple build change to enable compilation of the dummy SCTP API layer on macosx, plus the dummy implementation used on windows. The existing jdk_sctp tests cover this. http://cr.openjdk.java.net/~michaelm/7076487/webrev.1/ The build part looks fine to me. /Magnus Makefile changes look good to me as well. Tim
