Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-10-28 Thread Anthony Scarpino
On Wed, 28 Oct 2020 10:52:27 GMT, Magnus Ihse Bursie  wrote:

>> throw new IllegalStateException(
>> new InvalidAlgorithmParameterException(
>> "Curve not supported:  Private: " +
>> ((privNC != null) ? privNC.toString() : " unknown") +
>> ", PublicKey:" +
>> ((pubNC != null) ? pubNC.toString() : " unknown")));
>
> I opened https://bugs.openjdk.java.net/browse/JDK-8255530 for the remaining 
> cleanup.

I have the change in a workspace, just hadn't created the bug yet.. thanks

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-10-28 Thread Magnus Ihse Bursie
On Tue, 22 Sep 2020 14:04:55 GMT, Sean Mullan  wrote:

>> Anthony Scarpino has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   remove JDKOPT_DETECT_INTREE_EC from configure.ac
>
> throw new IllegalStateException(
> new InvalidAlgorithmParameterException(
> "Curve not supported:  Private: " +
> ((privNC != null) ? privNC.toString() : " unknown") +
> ", PublicKey:" +
> ((pubNC != null) ? pubNC.toString() : " unknown")));

I opened https://bugs.openjdk.java.net/browse/JDK-8255530 for the remaining 
cleanup.

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-10-26 Thread Magnus Ihse Bursie
Sorry for being late on this one (I'm working through a huge backlog), 
but it does not seem like the removal was complete.


ENABLE_INTREE_EC is still present in spec.gmk. And it is still checked 
in modules/jdk.crypto.ec/Lib.gmk. In fact, this entire file should be 
removed.


Anthony, can you please open a new JBS issue to fix the remaining cleanup?

/Magnus

On 2020-09-22 15:23, Erik Joelsson wrote:

On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino  
wrote:


This change removes the native elliptic curves library code; as well as, and 
calls to that code, tests, and files
associated with those libraries.  The makefiles have been changed to remove 
from all source builds of the ec code.  The
SunEC system property is removed and java.security configurations changed to 
reflect the removed curves.  This will
remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
secp128r1, secp128r2, secp160k1, secp160r1,
secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
sect113r2, sect131r1, sect131r2,
sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
sect239k1, sect283k1, sect283r1,
sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 c2tnb191v2, 
X9.62 c2tnb191v3, X9.62 c2tnb239v1,
X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, X9.62 
prime192v2, X9.62 prime192v3, X9.62
prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
brainpoolP320r1, brainpoolP384r1, brainpoolP512r1

Anthony Scarpino has updated the pull request incrementally with one additional 
commit since the last revision:

   remove JDKOPT_DETECT_INTREE_EC from configure.ac

Build changes look good.

Marked as reviewed by erikj (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/289




Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Anthony Scarpino
On Thu, 24 Sep 2020 21:37:14 GMT, Weijun Wang  wrote:

>> jdk.disabled.namedCurves is commented out and I don't think it's good for 
>> every operation disabled algorithms call to
>> check an empty property.  The description for the disabledAlgorithm 
>> properties say you have to use "include", so I
>> don't think it is necessary to we keep it active..
>
> I just think this is an unnecessary behavior change. After all, the purpose 
> of `jdk.disabled.namedCurves` is to be
> included in other disabledAlgorithms properties.
> No strong opinion on this. Please decide yourself.

I understand what you are saying.  The property only existed because there were 
so many curves that would have
overwhelmed the disabledAlgorithms.  I also don't like making this a permanent 
addition to the disabledAlgorithm
properties. It's possible we may remove the property in the future as it's 
likely unnecessary going forward.

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Weijun Wang
On Thu, 24 Sep 2020 21:15:34 GMT, Anthony Scarpino  
wrote:

>> src/java.base/share/conf/security/java.security line 636:
>> 
>>> 634: #
>>> 635: jdk.certpath.disabledAlgorithms=MD2, MD5, SHA1 jdkCA & usage 
>>> TLSServer, \
>>> 636: RSA keySize < 1024, DSA keySize < 1024, EC keySize < 224
>> 
>> `jdk.disabled.namedCurves` still exists. If someone decides to add a curve 
>> there, shouldn't it be also disabled here?
>
> jdk.disabled.namedCurves is commented out and I don't think it's good for 
> every operation disabled algorithms call to
> check an empty property.  The description for the disabledAlgorithm 
> properties say you have to use "include", so I
> don't think it is necessary to we keep it active..

I just think this is an unnecessary behavior change. After all, the purpose of 
`jdk.disabled.namedCurves` is to be
included in other disabledAlgorithms properties.

No strong opinion on this. Please decide yourself.

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Anthony Scarpino
On Thu, 24 Sep 2020 19:48:45 GMT, Weijun Wang  wrote:

>> Anthony Scarpino has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   change exception for ec keyagreement
>>   fix supportedcurves in SunEC
>
> src/java.base/share/conf/security/java.security line 636:
> 
>> 634: #
>> 635: jdk.certpath.disabledAlgorithms=MD2, MD5, SHA1 jdkCA & usage TLSServer, 
>> \
>> 636: RSA keySize < 1024, DSA keySize < 1024, EC keySize < 224
> 
> `jdk.disabled.namedCurves` still exists. If someone decides to add a curve 
> there, shouldn't it be also disabled here?

jdk.disabled.namedCurves is commented out and I don't think it's good for every 
operation disabled algorithms call to
check an empty property.  The description for the disabledAlgorithm properties 
say you have to use "include", so I
don't think it is necessary to we keep it active..

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-24 Thread Weijun Wang
On Wed, 23 Sep 2020 23:38:03 GMT, Anthony Scarpino  
wrote:

>> This change removes the native elliptic curves library code; as well as, and 
>> calls to that code, tests, and files
>> associated with those libraries.  The makefiles have been changed to remove 
>> from all source builds of the ec code.  The
>> SunEC system property is removed and java.security configurations changed to 
>> reflect the removed curves.  This will
>> remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
>> secp128r1, secp128r2, secp160k1, secp160r1,
>> secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
>> sect113r2, sect131r1, sect131r2,
>> sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
>> sect239k1, sect283k1, sect283r1,
>> sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 
>> c2tnb191v2, X9.62 c2tnb191v3, X9.62 c2tnb239v1,
>> X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, 
>> X9.62 prime192v2, X9.62 prime192v3, X9.62
>> prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
>> brainpoolP320r1, brainpoolP384r1, brainpoolP512r1
>
> Anthony Scarpino has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   change exception for ec keyagreement
>   fix supportedcurves in SunEC

src/java.base/share/conf/security/java.security line 636:

> 634: #
> 635: jdk.certpath.disabledAlgorithms=MD2, MD5, SHA1 jdkCA & usage TLSServer, \
> 636: RSA keySize < 1024, DSA keySize < 1024, EC keySize < 224

`jdk.disabled.namedCurves` still exists. If someone decides to add a curve 
there, shouldn't it be also disabled here?

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v3]

2020-09-23 Thread Anthony Scarpino
> This change removes the native elliptic curves library code; as well as, and 
> calls to that code, tests, and files
> associated with those libraries.  The makefiles have been changed to remove 
> from all source builds of the ec code.  The
> SunEC system property is removed and java.security configurations changed to 
> reflect the removed curves.  This will
> remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
> secp128r1, secp128r2, secp160k1, secp160r1,
> secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
> sect113r2, sect131r1, sect131r2,
> sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
> sect239k1, sect283k1, sect283r1,
> sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 
> c2tnb191v2, X9.62 c2tnb191v3, X9.62 c2tnb239v1,
> X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, X9.62 
> prime192v2, X9.62 prime192v3, X9.62
> prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
> brainpoolP320r1, brainpoolP384r1, brainpoolP512r1

Anthony Scarpino has updated the pull request incrementally with one additional 
commit since the last revision:

  change exception for ec keyagreement
  fix supportedcurves in SunEC

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/289/files
  - new: https://git.openjdk.java.net/jdk/pull/289/files/8a04ce7a..1f9820ab

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=289=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=289=01-02

  Stats: 20 lines in 3 files changed: 4 ins; 10 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/289.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/289/head:pull/289

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-23 Thread Anthony Scarpino
On Wed, 23 Sep 2020 17:07:21 GMT, Valerie Peng  wrote:

>> Anthony Scarpino has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   remove JDKOPT_DETECT_INTREE_EC from configure.ac
>
> src/jdk.crypto.ec/share/classes/sun/security/ec/SunEC.java line 219:
> 
>> 217:
>> 218: Collection supportedCurves;
>> 219: supportedCurves = CurveDB.getSupportedCurves();
> 
> Shouldn't the supportedCurves be the hardcoded 3 curves?

Ah yes.  Thanks for seeing that.

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-23 Thread Anthony Scarpino
On Tue, 22 Sep 2020 13:53:12 GMT, Sean Mullan  wrote:

>> Anthony Scarpino has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   remove JDKOPT_DETECT_INTREE_EC from configure.ac
>
> src/jdk.crypto.ec/share/classes/sun/security/ec/ECDHKeyAgreement.java line 
> 180:
> 
>> 178: ((privNC != null) ? privNC.toString() : " 
>> unknown") +
>> 179: ", PublicKey:" +
>> 180: ((pubNC != null) ? pubNC.toString() : " 
>> unknown")));
> 
> Spacing issues: "PublicKey:" should be "PublicKey: " and " unknown" should be 
> "unknown".

After considering the keys closer, I don't need to specify the key anymore.  
PrivateKey and PublicKey were removed

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-23 Thread Valerie Peng
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino  
wrote:

>> This change removes the native elliptic curves library code; as well as, and 
>> calls to that code, tests, and files
>> associated with those libraries.  The makefiles have been changed to remove 
>> from all source builds of the ec code.  The
>> SunEC system property is removed and java.security configurations changed to 
>> reflect the removed curves.  This will
>> remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
>> secp128r1, secp128r2, secp160k1, secp160r1,
>> secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
>> sect113r2, sect131r1, sect131r2,
>> sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
>> sect239k1, sect283k1, sect283r1,
>> sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 
>> c2tnb191v2, X9.62 c2tnb191v3, X9.62 c2tnb239v1,
>> X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, 
>> X9.62 prime192v2, X9.62 prime192v3, X9.62
>> prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
>> brainpoolP320r1, brainpoolP384r1, brainpoolP512r1
>
> Anthony Scarpino has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   remove JDKOPT_DETECT_INTREE_EC from configure.ac

src/jdk.crypto.ec/share/classes/sun/security/ec/SunEC.java line 219:

> 217:
> 218: Collection supportedCurves;
> 219: supportedCurves = CurveDB.getSupportedCurves();

Shouldn't the supportedCurves be the hardcoded 3 curves?

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-22 Thread Sean Mullan
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino  
wrote:

>> This change removes the native elliptic curves library code; as well as, and 
>> calls to that code, tests, and files
>> associated with those libraries.  The makefiles have been changed to remove 
>> from all source builds of the ec code.  The
>> SunEC system property is removed and java.security configurations changed to 
>> reflect the removed curves.  This will
>> remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
>> secp128r1, secp128r2, secp160k1, secp160r1,
>> secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
>> sect113r2, sect131r1, sect131r2,
>> sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
>> sect239k1, sect283k1, sect283r1,
>> sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 
>> c2tnb191v2, X9.62 c2tnb191v3, X9.62 c2tnb239v1,
>> X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, 
>> X9.62 prime192v2, X9.62 prime192v3, X9.62
>> prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
>> brainpoolP320r1, brainpoolP384r1, brainpoolP512r1
>
> Anthony Scarpino has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   remove JDKOPT_DETECT_INTREE_EC from configure.ac

throw new IllegalStateException(
new InvalidAlgorithmParameterException(
"Curve not supported:  Private: " +
((privNC != null) ? privNC.toString() : " unknown") +
", PublicKey:" +
((pubNC != null) ? pubNC.toString() : " unknown")));

src/jdk.crypto.ec/share/classes/sun/security/ec/ECDHKeyAgreement.java line 180:

> 178: ((privNC != null) ? privNC.toString() : " 
> unknown") +
> 179: ", PublicKey:" +
> 180: ((pubNC != null) ? pubNC.toString() : " 
> unknown")));

Spacing issues: "PublicKey:" should be "PublicKey: " and " unknown" should be 
"unknown".

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-22 Thread Erik Joelsson
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino  
wrote:

>> This change removes the native elliptic curves library code; as well as, and 
>> calls to that code, tests, and files
>> associated with those libraries.  The makefiles have been changed to remove 
>> from all source builds of the ec code.  The
>> SunEC system property is removed and java.security configurations changed to 
>> reflect the removed curves.  This will
>> remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
>> secp128r1, secp128r2, secp160k1, secp160r1,
>> secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
>> sect113r2, sect131r1, sect131r2,
>> sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
>> sect239k1, sect283k1, sect283r1,
>> sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 
>> c2tnb191v2, X9.62 c2tnb191v3, X9.62 c2tnb239v1,
>> X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, 
>> X9.62 prime192v2, X9.62 prime192v3, X9.62
>> prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
>> brainpoolP320r1, brainpoolP384r1, brainpoolP512r1
>
> Anthony Scarpino has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   remove JDKOPT_DETECT_INTREE_EC from configure.ac

Build changes look good.

Marked as reviewed by erikj (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-21 Thread Xue-Lei Andrew Fan
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino  
wrote:

>> This change removes the native elliptic curves library code; as well as, and 
>> calls to that code, tests, and files
>> associated with those libraries.  The makefiles have been changed to remove 
>> from all source builds of the ec code.  The
>> SunEC system property is removed and java.security configurations changed to 
>> reflect the removed curves.  This will
>> remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
>> secp128r1, secp128r2, secp160k1, secp160r1,
>> secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
>> sect113r2, sect131r1, sect131r2,
>> sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
>> sect239k1, sect283k1, sect283r1,
>> sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 
>> c2tnb191v2, X9.62 c2tnb191v3, X9.62 c2tnb239v1,
>> X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, 
>> X9.62 prime192v2, X9.62 prime192v3, X9.62
>> prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
>> brainpoolP320r1, brainpoolP384r1, brainpoolP512r1
>
> Anthony Scarpino has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   remove JDKOPT_DETECT_INTREE_EC from configure.ac

Looks good to me.

-

Marked as reviewed by xuelei (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-21 Thread Anthony Scarpino
> This change removes the native elliptic curves library code; as well as, and 
> calls to that code, tests, and files
> associated with those libraries.  The makefiles have been changed to remove 
> from all source builds of the ec code.  The
> SunEC system property is removed and java.security configurations changed to 
> reflect the removed curves.  This will
> remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
> secp128r1, secp128r2, secp160k1, secp160r1,
> secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
> sect113r2, sect131r1, sect131r2,
> sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
> sect239k1, sect283k1, sect283r1,
> sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 
> c2tnb191v2, X9.62 c2tnb191v3, X9.62 c2tnb239v1,
> X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, X9.62 
> prime192v2, X9.62 prime192v3, X9.62
> prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
> brainpoolP320r1, brainpoolP384r1, brainpoolP512r1

Anthony Scarpino has updated the pull request incrementally with one additional 
commit since the last revision:

  remove JDKOPT_DETECT_INTREE_EC from configure.ac

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/289/files
  - new: https://git.openjdk.java.net/jdk/pull/289/files/47eee3f4..8a04ce7a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=289=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=289=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/289.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/289/head:pull/289

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves [v2]

2020-09-21 Thread Anthony Scarpino
On Mon, 21 Sep 2020 23:50:07 GMT, Erik Joelsson  wrote:

>> Anthony Scarpino has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   remove JDKOPT_DETECT_INTREE_EC from configure.ac
>
> make/autoconf/jdk-options.m4 line 234:
> 
>> 232: # Enable or disable the elliptic curve crypto implementation
>> 233: #
>> 234: AC_DEFUN_ONCE([JDKOPT_DETECT_INTREE_EC],
> 
> There should be a call to this macro from either configure.ac or this file 
> that also needs to be removed.

found it in configure.ac and removed

-

PR: https://git.openjdk.java.net/jdk/pull/289


Re: RFR: 8235710: Remove the legacy elliptic curves

2020-09-21 Thread Erik Joelsson
On Mon, 21 Sep 2020 21:10:58 GMT, Anthony Scarpino  
wrote:

> This change removes the native elliptic curves library code; as well as, and 
> calls to that code, tests, and files
> associated with those libraries.  The makefiles have been changed to remove 
> from all source builds of the ec code.  The
> SunEC system property is removed and java.security configurations changed to 
> reflect the removed curves.  This will
> remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
> secp128r1, secp128r2, secp160k1, secp160r1,
> secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
> sect113r2, sect131r1, sect131r2,
> sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
> sect239k1, sect283k1, sect283r1,
> sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 
> c2tnb191v2, X9.62 c2tnb191v3, X9.62 c2tnb239v1,
> X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, X9.62 
> prime192v2, X9.62 prime192v3, X9.62
> prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
> brainpoolP320r1, brainpoolP384r1, brainpoolP512r1

make/autoconf/jdk-options.m4 line 234:

> 232: # Enable or disable the elliptic curve crypto implementation
> 233: #
> 234: AC_DEFUN_ONCE([JDKOPT_DETECT_INTREE_EC],

There should be a call to this macro from either configure.ac or this file that 
also needs to be removed.

-

PR: https://git.openjdk.java.net/jdk/pull/289


RFR: 8235710: Remove the legacy elliptic curves

2020-09-21 Thread Anthony Scarpino
This change removes the native elliptic curves library code; as well as, and 
calls to that code, tests, and files
associated with those libraries.  The makefiles have been changed to remove 
from all source builds of the ec code.  The
SunEC system property is removed and java.security configurations changed to 
reflect the removed curves.

This will remove the following elliptic curves from SunEC:   secp112r1, 
secp112r2, secp128r1, secp128r2, secp160k1,
secp160r1, secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, 
sect113r1, sect113r2, sect131r1,
sect131r2, sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, 
sect233r1, sect239k1, sect283k1,
sect283r1, sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 
c2tnb191v2, X9.62 c2tnb191v3, X9.62
c2tnb239v1, X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 
c2tnb431r1, X9.62 prime192v2, X9.62 prime192v3,
X9.62 prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
brainpoolP320r1, brainpoolP384r1, brainpoolP512r1

-

Commit messages:
 - 8235710: Remove the legacy elliptic curves

Changes: https://git.openjdk.java.net/jdk/pull/289/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=289=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8235710
  Stats: 20143 lines in 75 files changed: 25 ins; 20038 del; 80 mod
  Patch: https://git.openjdk.java.net/jdk/pull/289.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/289/head:pull/289

PR: https://git.openjdk.java.net/jdk/pull/289