Re: RFR: 8251400: Fix incorrect addition of library to test in JDK-8237858
On Fri, 3 Dec 2021 03:22:03 GMT, David Holmes wrote: >> In JDK-8237858, -pthread was added to all native tests, instead of the one >> single test that needed it. In the meantime, two new tests with pthread >> dependencies has crept in unnoticed due to this. > > Looks good. > > I don't think `-pthread` would actually hurt anything though. > > Thanks, > David @dholmes-ora I agree that it's mostly benign in this case, but where do you draw the line? For every library you can argue "this does not really hurt to include on all tests" and suddenly you have a very complex testing environment if all tests have all libraries all the time... - PR: https://git.openjdk.java.net/jdk/pull/6682
Re: RFR: 8251400: Fix incorrect addition of library to test in JDK-8237858
On Thu, 2 Dec 2021 22:45:37 GMT, Magnus Ihse Bursie wrote: > In JDK-8237858, -pthread was added to all native tests, instead of the one > single test that needed it. In the meantime, two new tests with pthread > dependencies has crept in unnoticed due to this. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6682
Re: RFR: 8251400: Fix incorrect addition of library to test in JDK-8237858
On Thu, 2 Dec 2021 22:45:37 GMT, Magnus Ihse Bursie wrote: > In JDK-8237858, -pthread was added to all native tests, instead of the one > single test that needed it. In the meantime, two new tests with pthread > dependencies has crept in unnoticed due to this. Looks good. I don't think `-pthread` would actually hurt anything though. Thanks, David - Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6682
RFR: 8251400: Fix incorrect addition of library to test in JDK-8237858
In JDK-8237858, -pthread was added to all native tests, instead of the one single test that needed it. In the meantime, two new tests with pthread dependencies has crept in unnoticed due to this. - Commit messages: - 8251400: Fix incorrect addition of library to test in JDK-8237858 Changes: https://git.openjdk.java.net/jdk/pull/6682/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6682=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251400 Stats: 13 lines in 2 files changed: 5 ins; 7 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/6682.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6682/head:pull/6682 PR: https://git.openjdk.java.net/jdk/pull/6682
