Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v4]
On Tue, 27 Feb 2024 11:01:03 GMT, Magnus Ihse Bursie wrote: >> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been >> integrated, it is possible to do some cleanup. The goal of >> [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change >> any behavior, even if that behavior seemed odd. >> >> Now let's try to fix that. We can: >> >> a) remove JNIEXPORT from c2v functions. >> b) make debug.cpp functions exported similarly on all platforms. >> c) remove JNIEXPORT from aarch64 asm debug function. >> >> Note that this PR is [dependent >> on](https://mail.openjdk.org/pipermail/jdk-dev/2021-March/005232.html) >> https://github.com/openjdk/jdk/pull/17955. > > Magnus Ihse Bursie has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains 10 commits: > > - Merge branch 'master' into hotspot-symbols-followup > - Remove jvmci globals > - 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 > - Revert "Use #pragma instead of HIDDEN define" > >This reverts commit 00e40a7f6e4cdef6592d72b3d08063cdcc41532a. > - Use #pragma instead of HIDDEN define > - Rename the version script to version-script.txt > - Restore linker script to linux/gcc builds > - Rename the Windows export file to .def > - Remove unused symbol _Copy_conjoint_bytes on linux/arm32 > - 8017234: Hotspot should stop using mapfiles There was a bit back and forth with this PR, but now I believe it is finally ready. Any reviewers? - PR Comment: https://git.openjdk.org/jdk/pull/17967#issuecomment-1967657651
Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v4]
On Tue, 27 Feb 2024 15:35:56 GMT, Ludovic Henry wrote: >> It does not sound like anyone object to the removal of `JNIEXPORT` for >> `das1`, then. >> >> Or should I just remove the entire function, if it serves no purpose that >> any current maintainers know or care about? > > You can probably remove the entire function given it's an indirection to > `das` anyway. I remember using it for debugging during the first stages of > the Windows-AArch64 port but I've long forgotten about it. @luhenry @magicus das1 was added when we were implementing the AArch64 port in order to help us integrate the debugger support we provided when running JITted code on our AArch64 simulator into gdb. Now that we have real hardware it is redundant. - PR Review Comment: https://git.openjdk.org/jdk/pull/17967#discussion_r1504535787
Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v4]
On Mon, 26 Feb 2024 20:07:35 GMT, Magnus Ihse Bursie wrote: >> I use `das` every day. In contrast, I don't know what `das1` is for. > > It does not sound like anyone object to the removal of `JNIEXPORT` for > `das1`, then. > > Or should I just remove the entire function, if it serves no purpose that any > current maintainers know or care about? You can probably remove the entire function given it's an indirection to `das` anyway. I remember using it for debugging during the first stages of the Windows-AArch64 port but I've long forgotten about it. - PR Review Comment: https://git.openjdk.org/jdk/pull/17967#discussion_r1504463486
Re: RFR: 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 [v4]
> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been > integrated, it is possible to do some cleanup. The goal of > [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change > any behavior, even if that behavior seemed odd. > > Now let's try to fix that. We can: > > a) remove JNIEXPORT from c2v functions. > b) make debug.cpp functions exported similarly on all platforms. > c) remove JNIEXPORT from aarch64 asm debug function. > > Note that this PR is [dependent > on](https://mail.openjdk.org/pipermail/jdk-dev/2021-March/005232.html) > https://github.com/openjdk/jdk/pull/17955. Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits: - Merge branch 'master' into hotspot-symbols-followup - Remove jvmci globals - 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 - Revert "Use #pragma instead of HIDDEN define" This reverts commit 00e40a7f6e4cdef6592d72b3d08063cdcc41532a. - Use #pragma instead of HIDDEN define - Rename the version script to version-script.txt - Restore linker script to linux/gcc builds - Rename the Windows export file to .def - Remove unused symbol _Copy_conjoint_bytes on linux/arm32 - 8017234: Hotspot should stop using mapfiles - Changes: https://git.openjdk.org/jdk/pull/17967/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17967&range=03 Stats: 12 lines in 3 files changed: 0 ins; 8 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/17967.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17967/head:pull/17967 PR: https://git.openjdk.org/jdk/pull/17967
