Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Tomas Doran


On 5 Dec 2008, at 23:00, Guillermo Roditi wrote:
I think the trunk version fixes all your problems, but nobody has  
been able to accurately describe their problems or produce a simple  
failing test case.


I've found another one - if you assign a list to a CAF accessor, then  
it packs the argument into a list-ref, and stores that..


This is used by (at least) Catalyst-Plugin-Server.

Test attached.

Cheers
t0m


list_assign.t
Description: Binary data



___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Guillermo Roditi

 HTML::Widget uses Class::Accessor::Chained::Fast, which overrides
 make_accessor. As mk_accessors no longer uses make_accessor to generate the
 coderef, this breaks horribly...


Uhm. wontfix? I don't even know how it would be possible to fix this. We'll
stop using Adopt::CAF by default, which should stop these kinds of
breakages.


-- 
Guillermo Roditi (groditi)
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Tomas Doran


On 29 Dec 2008, at 16:40, Guillermo Roditi wrote:

HTML::Widget uses Class::Accessor::Chained::Fast, which overrides  
make_accessor. As mk_accessors no longer uses make_accessor to  
generate the coderef, this breaks horribly...


Uhm. wontfix? I don't even know how it would be possible to fix  
this. We'll stop using Adopt::CAF by default, which should stop  
these kinds of breakages.


Works for me.

Committed as r8974

Cheers
t0m


___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-29 Thread Oliver Gorwits
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Guillermo Roditi wrote:
 Catalyst::Plugin::HashedCookies calls 
 Catalyst::Request-make_accessor, which in some ways is quite
 broken (as you're re-opening the package from outside), but it
 isn't actually very hard to fix/support..
 
 Yeah, that's totally broken and I don't even know if we want to
 support this kind of behavior. 

I've fixed the plugin not to have the above behaviour, and sent that
to CPAN. Many thanks to those who helped/kicked me into action :-)

- --
Oliver Gorwits, Network and Telecommunications Group,
Oxford University Computing Services
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJWV4P2NPq7pwWBt4RAqYkAKCYjFh3OTSqpT91JGCWfRMZOMP4rgCgpWuV
6OeebqGhR5e8V9mE3nsdebE=
=/2Jj
-END PGP SIGNATURE-

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-27 Thread Tomas Doran

On 5 Dec 2008, at 23:00, Guillermo Roditi wrote:
I think the trunk version fixes all your problems, but nobody has  
been able to accurately describe their problems or produce a simple  
failing test case.


HTML::Widget uses Class::Accessor::Chained::Fast, which overrides  
make_accessor. As mk_accessors no longer uses make_accessor to  
generate the coderef, this breaks horribly...


Test case attached.

Cheers
t0m



class_accessor_chained_fast.t
Description: Binary data





___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-27 Thread Tomas Doran


On 5 Dec 2008, at 23:00, Guillermo Roditi wrote:

All of you who have experienced errors rooted in MooseX::Emulate/ 
Adopt::Class::Accessor::Fast please please please send me error  
messages and show me the code that breaks.


Catalyst::Plugin::HashedCookies calls Catalyst::Request- 
make_accessor, which in some ways is quite broken (as you're re- 
opening the package from outside), but it isn't actually very hard to  
fix/support..


Tests and patch attached.

Cheers
t0m



reopen_packages.diff
Description: Binary data
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Tomas Doran


On 17 Dec 2008, at 14:52, Carl Franks wrote:


Can you try trunk, as I think this issue is already fixed there?


Confirmed working - many thanks.


No problem.

There isn't a failing test for this - I just changed it because it  
looked 'more right' and didn't break anything.


Fancy attempting one (as there _should_ be one)?

Cheers
t0m


___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-17 Thread Carl Franks
2008/12/17 Tomas Doran bobtf...@bobtfish.net:

 On 17 Dec 2008, at 14:52, Carl Franks wrote:

 Can you try trunk, as I think this issue is already fixed there?

 Confirmed working - many thanks.

 No problem.

 There isn't a failing test for this - I just changed it because it looked
 'more right' and didn't break anything.

 Fancy attempting one (as there _should_ be one)?

Patch is attached.
Unfortunately the test framework already strips the filenames down to
the basename before POSTing, so we can't test that filename() and
basename() differ.

I noticed the warnings below while running
t/aggregate/live_engine_request_uploads.t
- don't really know what to make of them.
Upgrading to latest HTTP::Body didn't help.

Argument 9, 9 isn't numeric in subtraction (-) at
/home/cafranks/checkout/catalyst-5.0/t/../lib/Catalyst/Engine.pm line
567.
Argument 9, 9 isn't numeric in numeric gt () at
/opt/perl-5.10.0/lib/site_perl/5.10.0/HTTP/Body.pm line 192.
Argument 9, 9 isn't numeric in numeric eq (==) at
/opt/perl-5.10.0/lib/site_perl/5.10.0/HTTP/Body/OctetStream.pm line
40.
Argument 9, 9 isn't numeric in subtraction (-) at
/home/cafranks/checkout/catalyst-5.0/t/../lib/Catalyst/Engine.pm line
567.
Argument 9, 9 isn't numeric in subtraction (-) at
/home/cafranks/checkout/catalyst-5.0/t/../lib/Catalyst/Engine.pm line
328.

Also, I got a test failure when I tried running `prove -lr t` - but no
failures when running `make test`.
Is that considered a problem?

Carl


basename.patch
Description: Binary data
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-14 Thread Chisel Wright
On Sun, Dec 14, 2008 at 01:47:03AM +, Tomas Doran wrote:
 I in no way think it is related, but can you try upgrading to the latest 
 Moose just in case this solves your issue?

I don't get the same level of FAIL after upgrading to 0.63. The app
appears to be behaving as I'd expect it to.

There are a few (startup gripes) but nothing that stops it all from
running:

  Subroutine initialize redefined at /usr/share/perl5/Class/C3.pm line 70.
  Subroutine uninitialize redefined at /usr/share/perl5/Class/C3.pm line 88.
  Subroutine reinitialize redefined at /usr/share/perl5/Class/C3.pm line 101.
  Parley is trying to use NEXT, which is crap. use Class::C3 or Moose method 
modifiers instead. at 
/usr/local/share/perl/5.10.0/Catalyst/Plugin/StackTrace.pm line 176
  Parley::View::TT is trying to use NEXT, which is crap. use Class::C3 or Moose 
method modifiers instead. at /usr/share/perl5/Catalyst/View/TT.pm line 122
  Parley::View::JSON is trying to use NEXT, which is crap. use Class::C3 or 
Moose method modifiers instead. at 
/usr/local/share/perl/5.10.0/Catalyst/View/JSON.pm line 15
  Parley::View::Plain is trying to use NEXT, which is crap. use Class::C3 or 
Moose method modifiers instead. at /usr/share/perl5/Catalyst/View/TT.pm line 122
  Parley::Model::ParleyDB is trying to use NEXT, which is crap. use Class::C3 
or Moose method modifiers instead. at 
/usr/local/share/perl/5.10.0/Catalyst/Model/DBIC/Schema.pm line 284

I assume these will go away when the dependencies are updated.

 saying perl -I ~/Catalyst-Runtime whatever will work fine, that's what 
 I'm using...

I thought as much, I was just doubting myself that day. I tend to work
on the assumption that something that doesn't work is usually because
I've done something dumb. :)

Cheers for your input,

Chiz
-- 
Chisel Wright
e: chi...@herlpacker.co.uk
w: http://www.herlpacker.co.uk/

  Always move fast - you never know who's catching up!

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-13 Thread Tomas Doran


On 9 Dec 2008, at 10:10, Chisel Wright wrote:


On Tue, Dec 09, 2008 at 08:30:10AM +, Tomas Doran wrote:

What versions of Moose and Class::MOP are you running?


0.60 and 0.68 respectively



I in no way think it is related, but can you try upgrading to the  
latest Moose just in case this solves your issue?



I'll see if I can find somewhere to actually install Catalyst-Runtime
properly, rather than just using a path hack.


saying perl -I ~/Catalyst-Runtime whatever will work fine, that's  
what I'm using...




I'm just worried about knackering my installation and not being  
able to

revert.


You don't need to worry about that - reverting to the latest 5.80 is  
as simple as asking CPAN to force install Catalyst-Runtime, but  
testing using just an un-wrapped tarball of the dev release should  
also work fine...


Cheers
t0m


___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-10 Thread Guillermo Roditi
On Tue, Dec 9, 2008 at 9:35 AM, Tomas Doran [EMAIL PROTECTED] wrote:


 I agree that all 'real' Moose classes shouldn't be breaking the meta method
 like this, but the fact is that there *IS* real code out there which is
 going to be broken by this, and it's something which we can _avoid_ breaking
 without too much effort..


As agreed, we'll replace calls to -can with calls to -meta-has_method to
fix this. We will also have to use Class::MOP directly to find the metaclass
instead of using -meta.

So, problem resolved, fix known. will fix and release when i have some time.
some time later this week, maybe next.
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-10 Thread Tomas Doran


On 10 Dec 2008, at 20:20, Guillermo Roditi wrote:
So, problem resolved, fix known. will fix and release when i have  
some time. some time later this week, maybe next.


Awesome, thanks.

t0m

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-09 Thread Guillermo Roditi
On Sun, Dec 7, 2008 at 4:38 PM, Tomas Doran [EMAIL PROTECTED] wrote:


 Please find attached a simple test case for the behavior needed by
 Catalyst::Plugin::Cache::Curried (and anything else which says
 __PACKAGE__-mk_accessors(qw/ meta /)) - found by looking at MojoMojo's
 current test failures.


Yeah dude. wontfix. You don't get to take over Moose's meta method.
Immutable replaces the accessor when inlining the meta method. You can argue
with Moose over who has the right to that particular method name, but that's
out of the scope of my module.

-- 
Guillermo Roditi (groditi)
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-08 Thread Chisel Wright
On Fri, Dec 05, 2008 at 04:25:49PM +0100, Marcus Ramberg wrote:
There are still a few problems to solve before the next stable CPAN
release (Some of the plugins are still failing tests, most notoriously the
backwards compatibility tests of Catalyst-Plugin-Authentication), but
Catalyst-Runtime now works on our apps. That is why we would like for you
to try it out, and tell us what breaks on your apps (If you don't, we will
happily ignore your anguished cries later (Well, probably not, but please
test it anyways!)) The  developer release is currently on it's way to
CPAN, and should be available for your local mirror before long. In case
you are interested, I've included the change log since the last dev
release below.

I don't know if I've done something stupid somewhere.

Running the tests for Catalyst-Runtime-5.8000_04 passes:

  All tests successful.
  Files=40, Tests=2106, 57 wallclock secs ( 0.68 usr  0.20 sys + 46.77 cusr  
1.80 
  
MyApp is fine under 5.7014, starting it with:

  
PERL5LIB=${HOME}/development/open_source/dev-tests/Catalyst-Runtime-5.8000_04/lib
  CATALYST_DEBUG=1 DBIC_TRACE=1 ./script/parley_server.pl
  --host=localhost -r -rd 2 --port=3000

any hits to the app give me the following:

[info] *** Request 3 (0.005/s) [11697] [Mon Dec  8 22:05:46 2008] ***
[error] Caught exception in engine Attribute (headers) does not pass the type 
constraint because: Validation failed for 'Header' failed with value 
HTTP::Headers=HASH(0xa6dee88) at 
/usr/local/share/perl/5.10.0/Moose/Meta/Class.pm line 193

Moose::Meta::Class::construct_instance('Moose::Meta::Class=HASH(0x95e96a8)', 
'HASH(0xa6de8a8)') called at /usr/local/lib/perl/5.10.0/Class/MOP/Class.pm line 
388
Class::MOP::Class::new_object('Moose::Meta::Class=HASH(0x95e96a8)', 
'HASH(0xa6de8a8)') called at /usr/local/share/perl/5.10.0/Moose/Meta/Class.pm 
line 157
Moose::Meta::Class::new_object('Moose::Meta::Class=HASH(0x95e96a8)', 
'HASH(0xa6de8a8)') called at /usr/local/share/perl/5.10.0/Moose/Object.pm line 
17
Moose::Object::new('Parley', 'HASH(0xa6de888)') called at 
/home/chisel/development/open_source/dev-tests/Catalyst-Runtime-5.8000_04/lib/Catalyst.pm
 line 1671
Catalyst::prepare('Parley') called at 
/usr/local/share/perl/5.10.0/Catalyst/Plugin/FormValidator.pm line 35
Catalyst::Plugin::FormValidator::prepare('Parley') called at 
/home/chisel/development/open_source/dev-tests/Catalyst-Runtime-5.8000_04/lib/Catalyst.pm
 line 1638
eval {...} called at 
/home/chisel/development/open_source/dev-tests/Catalyst-Runtime-5.8000_04/lib/Catalyst.pm
 line 1630
Catalyst::handle_request('Parley') called at 
/home/chisel/development/open_source/dev-tests/Catalyst-Runtime-5.8000_04/lib/Catalyst/Engine/HTTP.pm
 line 375

Catalyst::Engine::HTTP::_handler('Catalyst::Engine::HTTP::Restarter=HASH(0x9a8ecd8)',
 'Parley', 3000, 'GET', '/forum/list', 'HTTP/1.1') called at 
/home/chisel/development/open_source/dev-tests/Catalyst-Runtime-5.8000_04/lib/Catalyst/Engine/HTTP.pm
 line 281

Catalyst::Engine::HTTP::run('Catalyst::Engine::HTTP::Restarter=HASH(0x9a8ecd8)',
 'Parley', 3000, 'localhost', 'HASH(0x9337648)') called at 
/home/chisel/development/open_source/dev-tests/Catalyst-Runtime-5.8000_04/lib/Catalyst/Engine/HTTP/Restarter.pm
 line 70
Class::MOP::Class:::around('CODE(0x8fa3af8)', 
'Catalyst::Engine::HTTP::Restarter=HASH(0x9a8ecd8)', 'Parley', 3000, 
'localhost', 'HASH(0x9337648)') called at 
/usr/local/lib/perl/5.10.0/Class/MOP/Method/Wrapped.pm line 129

Class::MOP::Method::Wrapped::__ANON__('Catalyst::Engine::HTTP::Restarter=HASH(0x9a8ecd8)',
 'Parley', 3000, 'localhost', 'HASH(0x9337648)') called at 
/usr/local/lib/perl/5.10.0/Class/MOP/Method/Wrapped.pm line 89

Catalyst::Engine::HTTP::Restarter::run('Catalyst::Engine::HTTP::Restarter=HASH(0x9a8ecd8)',
 'Parley', 3000, 'localhost', 'HASH(0x9337648)') called at 
/home/chisel/development/open_source/dev-tests/Catalyst-Runtime-5.8000_04/lib/Catalyst.pm
 line 1934
Catalyst::run('Parley', 3000, 'localhost', 'HASH(0x9337648)') called at 
./script/parley_server.pl line 57

Is this likely to be my stupidity?
-- 
Chisel Wright
e: [EMAIL PROTECTED]
w: http://www.herlpacker.co.uk/

  All complaints must be submitted in writing
  on the back of a ten pound note.

___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-08 Thread Tomas Doran


On 8 Dec 2008, at 23:15, Bill Moseley wrote:


This suppose to be drop-in compatible with 5.7?


That's the aim, although we're probably not there yet..


perl, v5.10.0

All tests pass building Catalyst-Runtime but it's very noisy:

Subroutine uninitialize redefined at /usr/share/perl5/Class/C3.pm  
line 88.
Subroutine reinitialize redefined at /usr/share/perl5/Class/C3.pm  
line 101.


But, I suspect that's 5.10.0 on this test machine.  I had to clean  
up a

bunch of those for my apps when I upgraded as well.


This has been fixed in trunk I believe.


Running make test on an application that passes all tests with 5.7015
results in:

Failed 14/113 test scripts. 325/616 subtests failed.
Files=113, Tests=616, 127 wallclock secs (60.45 cusr +  4.38 csys =  
64.83 CPU)

Failed 14/113 test programs. 325/616 subtests failed.

Sorry, I didn't have time to look into this, so I'll just paste a few
errors I saw:

A few private plugins and views complain that NEXT is crap.  Hopefully
I'll find time to get those updated before the current non-crap
becomes crap, too.


It's possible to suppress that warning by saying no warnings  
'Class::C3::Adopt::NEXT'; in the offending code until you get it  
ported to Class::C3's next::method.


You can do this right now (as next::method works in 5.7).

Writing a little more advice for this for the POD is on my todo list.  
Suggested doc fixes (and suggestions to make the warning better)  
gratefully received if you have any.




A few failed the Class::MOP::is_class_loaded($class) test.

require App::Model::Foo was successful but the package is
not defined


This means that you have a file 'lib/App/Model/Foo.pm, but that file  
doesn't appear to define package App::Model::Foo.


I'd guess that your app is subtly broken in some way (like the file  
being mis-named) which is causing Class::MOP to not like the file.


Is that true for your application, and can you think of a better  
wording which would make the error message more clear/explicit about  
the problem?




Also:

Compilation failed in require at
/usr/local/lib/perl/5.10.0/Class/MOP.pm line 151.


Undefined subroutine Test::WWW::Mechanize::Catalyst::Aux::request


There's a fair amount of noise due to that, but I think that's causing
the build of the test failures.


Yeah, that'd figure - I guess there are stack traces to go with this?


I suspect this is doing the most damage:

require App::Model::Foo was successful but the package is
not defined

which is not entirely clear what that means.


Hopefully explained above.

If you could run the tests again manually with prove -v, and email me  
the results off-list then it'd help me diagnose the issues you're  
seeing further.


Many thanks for the help!

Cheers
t0m


___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-07 Thread Tomas Doran


On 5 Dec 2008, at 23:00, Guillermo Roditi wrote:

All of you who have experienced errors rooted in MooseX::Emulate/ 
Adopt::Class::Accessor::Fast please please please send me error  
messages and show me the code that breaks.


I think the trunk version fixes all your problems, but nobody has  
been able to accurately describe their problems or produce a simple  
failing test case.


Since the extra accessor generators went in, most stuff which was  
broken is fixed.



So, if my code is breaking your code, holla back!


I'm not sure if the correct fix for the lies in Catalyst, or  
MX::E::CAF, but:


http://dev.catalystframework.org/svnweb/Catalyst/revision?rev=8781

is the minimal test case I've been able to produce for the breakage  
of the Catalyst::Plugin::Authentication's tests and which people  
still using the back-compat auth plugins in their apps would be  
seeing (if any of them were trying it and shouting).


Cheers
t0m


___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-07 Thread Tomas Doran


On 5 Dec 2008, at 23:00, Guillermo Roditi wrote:
I think the trunk version fixes all your problems, but nobody has  
been able to accurately describe their problems or produce a simple  
failing test case.


So, if my code is breaking your code, holla back!


Please find attached a simple test case for the behavior needed by  
Catalyst::Plugin::Cache::Curried (and anything else which says  
__PACKAGE__-mk_accessors(qw/ meta /)) - found by looking at  
MojoMojo's current test failures.


Cheers
t0m


meta-method.diff
Description: Binary data
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


[Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-05 Thread Marcus Ramberg
After hours and hours of panic, despair, hair hugging and straight
procrastination, we have finally managed to produce a Catalyst-Runtime
distribution that
a) Has a Moose
b) Performs similarly to the previous stable version, and most importantly
c) Works with the old 5.7 based applications.
d) Has some nice new features (notable since last dev release is virtual
host support for tests)

There are still a few problems to solve before the next stable CPAN release
(Some of the plugins are still failing tests, most notoriously the backwards
compatibility tests of Catalyst-Plugin-Authentication), but Catalyst-Runtime
now works on our apps. That is why we would like for you to try it out, and
tell us what breaks on your apps (If you don't, we will happily ignore your
anguished cries later (Well, probably not, but please test it anyways!)) The
 developer release is currently on it's way to CPAN, and should be available
for your local mirror before long. In case you are interested, I've included
the change log since the last dev release below.

With regards
Marcus Ramberg
Catalyst Release Manager.


5.8000_04  2008-12-05 12:15:00
- Silence Class::C3::Adopt::NEXT warnings in the test suite (rafl)
- Fix loads of 'used once, possible typo' warnings (rafl)
- Additional tests to ensure upload temp files are deleted (andyg)
- Remove use of NEXT from the test suite, except for one case
  which tests if Class::C3::Adopt::NEXT is working (t0m)
- Use a predicate to avoid recursion in cases where the uri
  method is overridden by a plugin, and calls the base method,
  for example Catalyst::Plugin::SmartURI (t0m)
  - Test for this (caelum)
- Compose the MooseX::Emulate::Class::Accessor::Fast role to
  Catalyst::Action, Catalyst::Request, and all other modules which
  inherit from Class::Accessor::Fast in 5.70.
  This fixes:
- Catalyst::Controller::HTML::FormFu (zamolxes)
- Catalyst::Request::REST (t0m)
  - Test for this (t0m)
- Make hostname resolution lazy (Marc Mims)
- Support mocking virtualhosts in test suite (Jason Gottshall)
- Add README (marcus)
- Fix TODO list (t0m)
- Use Class::C3::Adopt::NEXT (rafl)
- Ignore C3 warnings on 5.10 when testing ensure_class_loaded (rafl)
- Add TODO test for chained bug (gbjk)
- Fix list address in documentation (zarquon)
- Fix ACCEPT_CONTEXT on MyApp, called as a class method (marcus)
   - Test for this (marcus)
- Bump MooseX::Emulate::Class::Accessor::Fast version requirement
to
  get more back compatibility (t0m)
- Improve documentation for $req-captures (caelum)
- Fix a bug in Catalyst::Stats, stopping garbage being inserted into
  the stats if a user calls begin = but no end = (jhannah)
   - Test for this (jhannah)
- Trim lines sooner in stats to avoid ugly Text::SimpleTable
wrapping
  (jhannah)
- Change Catalyst::ClassData to tweak the symbol table inline for
  performance after profiling (mst)
- Fix POD typo in finalize_error (jhannah)
- Add tests to ensure that we delete the temp files created by
  HTTP::Body's OctetStream parser (t0m)
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/


Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN

2008-12-05 Thread Guillermo Roditi
All of you who have experienced errors rooted in
MooseX::Emulate/Adopt::Class::Accessor::Fast please please please send me
error messages and show me the code that breaks.

I think the trunk version fixes all your problems, but nobody has been able
to accurately describe their problems or produce a simple failing test case.

So, if my code is breaking your code, holla back!

-- 
Guillermo Roditi (groditi)
___
List: Catalyst@lists.scsys.co.uk
Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/
Dev site: http://dev.catalyst.perl.org/