Re: [PATCH 0/2] two small patches for CEPH wireshark plugin
You could look at the wip-wireshark-zafman branch. I rebased it and force pushed it. It has changes to the wireshark.patch and a minor change I needed to get it to build. I'm surprised the recent checkin didn't include the change to packet-ceph.c which I needed to get it to build. David Zafman Senior Developer david.zaf...@inktank.com On Jan 24, 2013, at 12:49 PM, Danny Al-Gaaf danny.al-g...@bisect.de wrote: Am 24.01.2013 19:31, schrieb Sage Weil: Hi Danny! [...] Since you brought up wireshark... We would LOVE LOVE LOVE it if this plugin could get upstream into wireshark. Yes, this would be great. IIRC, the problem (last time we checked, ages ago) was that there were strict coding guidelines for that project that weren't followed. I'm not sure if that is still the case, or even if that is accurate. It would be great if someone on this list who is looking for a way to contribute could take the lead on trying to make this happen... :-) I'll take a look at it maybe ... if I find some free time for it. What about the patches? Can we apply them to the ceph git tree until we have another solution for the wireshark code? Danny -- To unsubscribe from this list: send the line unsubscribe ceph-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe ceph-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] two small patches for CEPH wireshark plugin
Danny Al-Gaaf (2): wireshark: fix guint64 print format handling wireshark: fix indention wireshark/ceph/packet-ceph.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) -- 1.8.1.1 -- To unsubscribe from this list: send the line unsubscribe ceph-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] two small patches for CEPH wireshark plugin
Hi Danny! On Thu, 24 Jan 2013, Danny Al-Gaaf wrote: Danny Al-Gaaf (2): wireshark: fix guint64 print format handling wireshark: fix indention wireshark/ceph/packet-ceph.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) Since you brought up wireshark... We would LOVE LOVE LOVE it if this plugin could get upstream into wireshark. IIRC, the problem (last time we checked, ages ago) was that there were strict coding guidelines for that project that weren't followed. I'm not sure if that is still the case, or even if that is accurate. It would be great if someone on this list who is looking for a way to contribute could take the lead on trying to make this happen... :-) sage -- To unsubscribe from this list: send the line unsubscribe ceph-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] two small patches for CEPH wireshark plugin
On Thu, 24 Jan 2013, Danny Al-Gaaf wrote: Am 24.01.2013 19:31, schrieb Sage Weil: Hi Danny! [...] Since you brought up wireshark... We would LOVE LOVE LOVE it if this plugin could get upstream into wireshark. Yes, this would be great. IIRC, the problem (last time we checked, ages ago) was that there were strict coding guidelines for that project that weren't followed. I'm not sure if that is still the case, or even if that is accurate. It would be great if someone on this list who is looking for a way to contribute could take the lead on trying to make this happen... :-) I'll take a look at it maybe ... if I find some free time for it. What about the patches? Can we apply them to the ceph git tree until we have another solution for the wireshark code? Already in master. Thanks! sage -- To unsubscribe from this list: send the line unsubscribe ceph-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html