RE: Deadlock in ceph journal
[Copying ceph-devel, dropping ceph-users]
Yeah, that looks like a bug. I pushed wip-filejournal that reapplies
Jianpeng's original patch and this one. I'm not certain about last other
suggested fix, though, but I'm hoping that this fix explains the strange
behavior Jianpeng and Mark have seen?
sage
On Wed, 20 Aug 2014, Somnath Roy wrote:
>
> I think this is the issue..
>
>
>
> http://tracker.ceph.com/issues/9073
>
>
>
> Thanks & Regards
>
> Somnath
>
>
>
> From: Somnath Roy
> Sent: Tuesday, August 19, 2014 6:25 PM
> To: Sage Weil (s...@inktank.com); Samuel Just (sam.j...@inktank.com)
> Cc: ceph-us...@lists.ceph.com
> Subject: Deadlock in ceph journal
>
>
>
> Hi Sage/Sam,
>
> During our testing we found a potential deadlock scenario in the filestore
> journal code base. This is happening because of two reason.
>
>
>
> 1. This is because code is not signaling aio_cond from
> check_aio_completion() in case seq = 0
>
> 2. Following changes in the write_thread_entry() is allowing a very
> first header write with seq = 0.
>
> if (writeq.empty() && !must_write_header) {
>
>
>
>
>
> Now, during ceph-deploy activate this is what happening.
>
>
>
> 1. The very first write of header with seq = 0 issued and it is waiting for
> aio completion. So, aio_num = 1.
>
> 2. superblock write came in and got into while (aio_num > 0) block of
> write_thread_entry() and waiting on the aio_cond
>
> 3. The seq = 0 aio completed but not setting completed_something = true and
> as a result aio_cond is not signaled.
>
> 4. write_thread_entry() is getting into deadlock.
>
>
>
> This is a timing problem and if header write is returned before superblock
> write this will not happen and will be happening in case of block journal
> device only (aio is enabled).
>
>
>
> Here is the log snippet we are getting.
>
>
>
> 2014-08-19 12:59:10.029363 7f60fa33b700 10 journal write_thread_entry start
>
> 2014-08-19 12:59:10.029395 7f60fa33b700 20 journal prepare_multi_write
> queue_pos now 4096
>
> 2014-08-19 12:59:10.029427 7f60fa33b700 15 journal do_aio_write writing
> 4096~0 + header
>
> 2014-08-19 12:59:10.029439 7f60fa33b700 20 journal write_aio_bl 0~4096 seq 0
>
> 2014-08-19 12:59:10.029442 7f60f9339700 10 journal write_finish_thread_entry
> enter
>
> 2014-08-19 12:59:10.029466 7f60fa33b700 20 journal write_aio_bl .. 0~4096 in
> 1
>
> 2014-08-19 12:59:10.029498 7f60fa33b700 20 journal write_aio_bl 4096~0 seq 0
>
> 2014-08-19 12:59:10.029505 7f60fa33b700 5 journal put_throttle finished 0
> ops and 0 bytes, now 0 ops and 0 bytes
>
> 2014-08-19 12:59:10.029510 7f60fa33b700 20 journal write_thread_entry going
> to sleep
>
> 2014-08-19 12:59:10.029538 7f60ff178800 10 journal journal_start
>
> 2014-08-19 12:59:10.029566 7f60f9339700 20 journal write_finish_thread_entry
> waiting for aio(s)
>
> 2014-08-19 12:59:10.029726 7f60ff178800 15
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) read
> meta/23c2fcde/osd_superblock/0//-1 0~0
>
> 2014-08-19 12:59:10.029793 7f60ff178800 -1
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) could not find
> 23c2fcde/osd_superblock/0//-1 in index: (2) No such file or directory
>
> 2014-08-19 12:59:10.029815 7f60ff178800 10
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R)
> FileStore::read(meta/23c2fcde/osd_superblock/0//-1) open error: (2) No such
> file or directory
>
> 2014-08-19 12:59:10.029892 7f60ff178800 5
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) queue_transactions new osr(default
> 0x42ea9f0)/0x42ea9f0
>
> 2014-08-19 12:59:10.029922 7f60ff178800 10 journal op_submit_start 2
>
> 2014-08-19 12:59:10.030009 7f60ff178800 5
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) queue_transactions (writeahead) 2
> 0x7fff6e817080
>
> 2014-08-19 12:59:10.030028 7f60ff178800 10 journal op_journal_transactions 2
> 0x7fff6e817080
>
> 2014-08-19 12:59:10.030039 7f60ff178800 5 journal submit_entry seq 2 len
> 505 (0x42a76f0)
>
> 2014-08-19 12:59:10.030065 7f60fa33b700 20 journal write_thread_entry woke
> up
>
> 2014-08-19 12:59:10.030070 7f60fa33b700 20 journal write_thread_entry aio
> throttle: aio num 1 bytes 4096 ... exp 2 min_new 4 ... pending 0
>
> 2014-08-19 12:59:10.030076 7f60fa33b700 20 journal write_thread_entry
> deferring until more aios complete: 1 aios with 4096 bytes needs 4 bytes to
> start a new aio (currently 0 pending)
>
> 2014-08-19 12:59:10.030084 7f60ff178800 10 journal op_submit_finish 2
>
> 2014-08-19 12:59:10.030389 7f60f9339700 10 journal write_finish_thread_entry
> aio 0~4096 done
>
> 2014-08-19 12:59:10.030402 7f60f9339700 20 journal check_aio_completion
>
> 2014-08-19 12:59:10.030406 7f60f9339700 20 journal check_aio_completion
> completed seq 0 0~4096
>
> 2014-08-19 12:59:10.030412 7f60f9339700 20 journal write_finish_thread_entry
> sleeping
>
> 2014-08-19 12:59:15.026609 7f60fab3c700 20
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) sync_entry woke after 5.000459
>
> 2014-08-19 12:59:15.026659 7f60fab3c700 10 jour
RE: Deadlock in ceph journal
Thanks Sage !
So, the latest master should have the fix, right ?
Regards
Somnath
-Original Message-
From: Sage Weil [mailto:sw...@redhat.com]
Sent: Tuesday, August 19, 2014 8:55 PM
To: Somnath Roy
Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org; Mark
Kirkwood; jianpeng...@intel.com
Subject: RE: Deadlock in ceph journal
[Copying ceph-devel, dropping ceph-users]
Yeah, that looks like a bug. I pushed wip-filejournal that reapplies
Jianpeng's original patch and this one. I'm not certain about last other
suggested fix, though, but I'm hoping that this fix explains the strange
behavior Jianpeng and Mark have seen?
sage
On Wed, 20 Aug 2014, Somnath Roy wrote:
>
> I think this is the issue..
>
>
>
> http://tracker.ceph.com/issues/9073
>
>
>
> Thanks & Regards
>
> Somnath
>
>
>
> From: Somnath Roy
> Sent: Tuesday, August 19, 2014 6:25 PM
> To: Sage Weil (s...@inktank.com); Samuel Just (sam.j...@inktank.com)
> Cc: ceph-us...@lists.ceph.com
> Subject: Deadlock in ceph journal
>
>
>
> Hi Sage/Sam,
>
> During our testing we found a potential deadlock scenario in the
> filestore journal code base. This is happening because of two reason.
>
>
>
> 1. This is because code is not signaling aio_cond from
> check_aio_completion() in case seq = 0
>
> 2. Following changes in the write_thread_entry() is allowing a
> very first header write with seq = 0.
>
>if (writeq.empty() && !must_write_header) {
>
>
>
>
>
> Now, during ceph-deploy activate this is what happening.
>
>
>
> 1. The very first write of header with seq = 0 issued and it is
> waiting for aio completion. So, aio_num = 1.
>
> 2. superblock write came in and got into while (aio_num > 0) block of
> write_thread_entry() and waiting on the aio_cond
>
> 3. The seq = 0 aio completed but not setting completed_something =
> true and as a result aio_cond is not signaled.
>
> 4. write_thread_entry() is getting into deadlock.
>
>
>
> This is a timing problem and if header write is returned before
> superblock write this will not happen and will be happening in case of
> block journal device only (aio is enabled).
>
>
>
> Here is the log snippet we are getting.
>
>
>
> 2014-08-19 12:59:10.029363 7f60fa33b700 10 journal write_thread_entry
> start
>
> 2014-08-19 12:59:10.029395 7f60fa33b700 20 journal prepare_multi_write
> queue_pos now 4096
>
> 2014-08-19 12:59:10.029427 7f60fa33b700 15 journal do_aio_write
> writing
> 4096~0 + header
>
> 2014-08-19 12:59:10.029439 7f60fa33b700 20 journal write_aio_bl 0~4096
> seq 0
>
> 2014-08-19 12:59:10.029442 7f60f9339700 10 journal
> write_finish_thread_entry enter
>
> 2014-08-19 12:59:10.029466 7f60fa33b700 20 journal write_aio_bl ..
> 0~4096 in
> 1
>
> 2014-08-19 12:59:10.029498 7f60fa33b700 20 journal write_aio_bl 4096~0
> seq 0
>
> 2014-08-19 12:59:10.029505 7f60fa33b700 5 journal put_throttle
> finished 0 ops and 0 bytes, now 0 ops and 0 bytes
>
> 2014-08-19 12:59:10.029510 7f60fa33b700 20 journal write_thread_entry
> going to sleep
>
> 2014-08-19 12:59:10.029538 7f60ff178800 10 journal journal_start
>
> 2014-08-19 12:59:10.029566 7f60f9339700 20 journal
> write_finish_thread_entry waiting for aio(s)
>
> 2014-08-19 12:59:10.029726 7f60ff178800 15
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) read
> meta/23c2fcde/osd_superblock/0//-1 0~0
>
> 2014-08-19 12:59:10.029793 7f60ff178800 -1
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) could not find
> 23c2fcde/osd_superblock/0//-1 in index: (2) No such file or directory
>
> 2014-08-19 12:59:10.029815 7f60ff178800 10
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R)
> FileStore::read(meta/23c2fcde/osd_superblock/0//-1) open error: (2) No
> such file or directory
>
> 2014-08-19 12:59:10.029892 7f60ff178800 5
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) queue_transactions new
> osr(default
> 0x42ea9f0)/0x42ea9f0
>
> 2014-08-19 12:59:10.029922 7f60ff178800 10 journal op_submit_start 2
>
> 2014-08-19 12:59:10.030009 7f60ff178800 5
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) queue_transactions
> (writeahead) 2
> 0x7fff6e817080
>
> 2014-08-19 12:59:10.030028 7f60ff178800 10 journal
> op_journal_transactions 2
> 0x7fff6e817080
>
> 2014-08-19 12:59:10.030039 7f60ff178800 5 journal submit_entry seq 2
> len
> 505 (0x42a76f0)
>
> 2014-08-19 12:59:10.030065 7f60fa33b700 20 journal write_thread_entry
> woke up
>
> 2014-08-19 12:59:10.030070 7f60fa33b700 20 journal write_thread_entry
> aio
> throttle: aio num 1 bytes 4096 ... exp 2 min_new 4 ... pending 0
>
> 2014-08-19 12:59:10.030076 7f60
RE: Deadlock in ceph journal
I got it, not yet there in master.
https://github.com/ceph/ceph/commit/b40ddc5dcf95b4849706314b34e72b607629773f
Sorry for the confusion.
Thanks & Regards
Somnath
-Original Message-
From: Somnath Roy
Sent: Tuesday, August 19, 2014 9:38 PM
To: 'Sage Weil'
Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org; Mark
Kirkwood; jianpeng...@intel.com
Subject: RE: Deadlock in ceph journal
Thanks Sage !
So, the latest master should have the fix, right ?
Regards
Somnath
-Original Message-
From: Sage Weil [mailto:sw...@redhat.com]
Sent: Tuesday, August 19, 2014 8:55 PM
To: Somnath Roy
Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org; Mark
Kirkwood; jianpeng...@intel.com
Subject: RE: Deadlock in ceph journal
[Copying ceph-devel, dropping ceph-users]
Yeah, that looks like a bug. I pushed wip-filejournal that reapplies
Jianpeng's original patch and this one. I'm not certain about last other
suggested fix, though, but I'm hoping that this fix explains the strange
behavior Jianpeng and Mark have seen?
sage
On Wed, 20 Aug 2014, Somnath Roy wrote:
>
> I think this is the issue..
>
>
>
> http://tracker.ceph.com/issues/9073
>
>
>
> Thanks & Regards
>
> Somnath
>
>
>
> From: Somnath Roy
> Sent: Tuesday, August 19, 2014 6:25 PM
> To: Sage Weil (s...@inktank.com); Samuel Just (sam.j...@inktank.com)
> Cc: ceph-us...@lists.ceph.com
> Subject: Deadlock in ceph journal
>
>
>
> Hi Sage/Sam,
>
> During our testing we found a potential deadlock scenario in the
> filestore journal code base. This is happening because of two reason.
>
>
>
> 1. This is because code is not signaling aio_cond from
> check_aio_completion() in case seq = 0
>
> 2. Following changes in the write_thread_entry() is allowing a
> very first header write with seq = 0.
>
>if (writeq.empty() && !must_write_header) {
>
>
>
>
>
> Now, during ceph-deploy activate this is what happening.
>
>
>
> 1. The very first write of header with seq = 0 issued and it is
> waiting for aio completion. So, aio_num = 1.
>
> 2. superblock write came in and got into while (aio_num > 0) block of
> write_thread_entry() and waiting on the aio_cond
>
> 3. The seq = 0 aio completed but not setting completed_something =
> true and as a result aio_cond is not signaled.
>
> 4. write_thread_entry() is getting into deadlock.
>
>
>
> This is a timing problem and if header write is returned before
> superblock write this will not happen and will be happening in case of
> block journal device only (aio is enabled).
>
>
>
> Here is the log snippet we are getting.
>
>
>
> 2014-08-19 12:59:10.029363 7f60fa33b700 10 journal write_thread_entry
> start
>
> 2014-08-19 12:59:10.029395 7f60fa33b700 20 journal prepare_multi_write
> queue_pos now 4096
>
> 2014-08-19 12:59:10.029427 7f60fa33b700 15 journal do_aio_write
> writing
> 4096~0 + header
>
> 2014-08-19 12:59:10.029439 7f60fa33b700 20 journal write_aio_bl 0~4096
> seq 0
>
> 2014-08-19 12:59:10.029442 7f60f9339700 10 journal
> write_finish_thread_entry enter
>
> 2014-08-19 12:59:10.029466 7f60fa33b700 20 journal write_aio_bl ..
> 0~4096 in
> 1
>
> 2014-08-19 12:59:10.029498 7f60fa33b700 20 journal write_aio_bl 4096~0
> seq 0
>
> 2014-08-19 12:59:10.029505 7f60fa33b700 5 journal put_throttle
> finished 0 ops and 0 bytes, now 0 ops and 0 bytes
>
> 2014-08-19 12:59:10.029510 7f60fa33b700 20 journal write_thread_entry
> going to sleep
>
> 2014-08-19 12:59:10.029538 7f60ff178800 10 journal journal_start
>
> 2014-08-19 12:59:10.029566 7f60f9339700 20 journal
> write_finish_thread_entry waiting for aio(s)
>
> 2014-08-19 12:59:10.029726 7f60ff178800 15
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) read
> meta/23c2fcde/osd_superblock/0//-1 0~0
>
> 2014-08-19 12:59:10.029793 7f60ff178800 -1
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) could not find
> 23c2fcde/osd_superblock/0//-1 in index: (2) No such file or directory
>
> 2014-08-19 12:59:10.029815 7f60ff178800 10
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R)
> FileStore::read(meta/23c2fcde/osd_superblock/0//-1) open error: (2) No
> such file or directory
>
> 2014-08-19 12:59:10.029892 7f60ff178800 5
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) queue_transactions new
> osr(default
> 0x42ea9f0)/0x42ea9f0
>
> 2014-08-19 12:59:10.029922 7f60ff178800 10 journal op_submit_start 2
>
> 2014-08-19 12:59:10.030009 7f60ff178800 5
> filestore(/var/lib/ceph/tmp/mnt.NKfs2R) queue_transactions
> (writeahead) 2
> 0x7fff6e817080
>
> 2014-08-19 12:59:10.030028 7f60ff178800 10 journal
> op_journal_transactions 2
> 0x7
RE: Deadlock in ceph journal
On Wed, 20 Aug 2014, Somnath Roy wrote:
> Thanks Sage !
> So, the latest master should have the fix, right ?
The original patch that caused the regression is reverted, but we'd like
to reapply it if we sort out the issues. wip-filejournal has the
offending patch and your fix.. but I'm eager to hear if Jianpeng and Mark
can confirm it's complete/correct or if there is still a problem.
sage
>
> Regards
> Somnath
>
> -Original Message-
> From: Sage Weil [mailto:sw...@redhat.com]
> Sent: Tuesday, August 19, 2014 8:55 PM
> To: Somnath Roy
> Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org; Mark
> Kirkwood; jianpeng...@intel.com
> Subject: RE: Deadlock in ceph journal
>
> [Copying ceph-devel, dropping ceph-users]
>
> Yeah, that looks like a bug. I pushed wip-filejournal that reapplies
> Jianpeng's original patch and this one. I'm not certain about last other
> suggested fix, though, but I'm hoping that this fix explains the strange
> behavior Jianpeng and Mark have seen?
>
> sage
>
>
> On Wed, 20 Aug 2014, Somnath Roy wrote:
> >
> > I think this is the issue..
> >
> >
> >
> > http://tracker.ceph.com/issues/9073
> >
> >
> >
> > Thanks & Regards
> >
> > Somnath
> >
> >
> >
> > From: Somnath Roy
> > Sent: Tuesday, August 19, 2014 6:25 PM
> > To: Sage Weil (s...@inktank.com); Samuel Just (sam.j...@inktank.com)
> > Cc: ceph-us...@lists.ceph.com
> > Subject: Deadlock in ceph journal
> >
> >
> >
> > Hi Sage/Sam,
> >
> > During our testing we found a potential deadlock scenario in the
> > filestore journal code base. This is happening because of two reason.
> >
> >
> >
> > 1. This is because code is not signaling aio_cond from
> > check_aio_completion() in case seq = 0
> >
> > 2. Following changes in the write_thread_entry() is allowing a
> > very first header write with seq = 0.
> >
> >if (writeq.empty() && !must_write_header) {
> >
> >
> >
> >
> >
> > Now, during ceph-deploy activate this is what happening.
> >
> >
> >
> > 1. The very first write of header with seq = 0 issued and it is
> > waiting for aio completion. So, aio_num = 1.
> >
> > 2. superblock write came in and got into while (aio_num > 0) block of
> > write_thread_entry() and waiting on the aio_cond
> >
> > 3. The seq = 0 aio completed but not setting completed_something =
> > true and as a result aio_cond is not signaled.
> >
> > 4. write_thread_entry() is getting into deadlock.
> >
> >
> >
> > This is a timing problem and if header write is returned before
> > superblock write this will not happen and will be happening in case of
> > block journal device only (aio is enabled).
> >
> >
> >
> > Here is the log snippet we are getting.
> >
> >
> >
> > 2014-08-19 12:59:10.029363 7f60fa33b700 10 journal write_thread_entry
> > start
> >
> > 2014-08-19 12:59:10.029395 7f60fa33b700 20 journal prepare_multi_write
> > queue_pos now 4096
> >
> > 2014-08-19 12:59:10.029427 7f60fa33b700 15 journal do_aio_write
> > writing
> > 4096~0 + header
> >
> > 2014-08-19 12:59:10.029439 7f60fa33b700 20 journal write_aio_bl 0~4096
> > seq 0
> >
> > 2014-08-19 12:59:10.029442 7f60f9339700 10 journal
> > write_finish_thread_entry enter
> >
> > 2014-08-19 12:59:10.029466 7f60fa33b700 20 journal write_aio_bl ..
> > 0~4096 in
> > 1
> >
> > 2014-08-19 12:59:10.029498 7f60fa33b700 20 journal write_aio_bl 4096~0
> > seq 0
> >
> > 2014-08-19 12:59:10.029505 7f60fa33b700 5 journal put_throttle
> > finished 0 ops and 0 bytes, now 0 ops and 0 bytes
> >
> > 2014-08-19 12:59:10.029510 7f60fa33b700 20 journal write_thread_entry
> > going to sleep
> >
> > 2014-08-19 12:59:10.029538 7f60ff178800 10 journal journal_start
> >
> > 2014-08-19 12:59:10.029566 7f60f9339700 20 journal
> > write_finish_thread_entry waiting for aio(s)
> >
> > 2014-08-19 12:59:10.029726 7f60ff178800 15
> > filestore(/var/lib/ceph/tmp/mnt.NKfs2R) read
> > meta/23c2fcde/osd_superblock/0//-1 0~0
> >
> > 2014-08-19 12:59:10.029793 7f60ff178800 -1
> > filestore(/var/lib/ceph/tmp/mnt.NKfs2R) could not find
> > 23c2fcde/osd_superblock/0//-1 in index: (2) No such file or directory
> >
> > 2014-08-19 12:59:10.029815 7f60ff178800 10
> > filestore(/var/lib/ceph/tmp/mnt.NKf
RE: Deadlock in ceph journal
I will also take the patch and test it out.
Thanks & Regards
Somnath
-Original Message-
From: Sage Weil [mailto:sw...@redhat.com]
Sent: Tuesday, August 19, 2014 9:51 PM
To: Somnath Roy
Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org; Mark
Kirkwood; jianpeng...@intel.com
Subject: RE: Deadlock in ceph journal
On Wed, 20 Aug 2014, Somnath Roy wrote:
> Thanks Sage !
> So, the latest master should have the fix, right ?
The original patch that caused the regression is reverted, but we'd like to
reapply it if we sort out the issues. wip-filejournal has the offending patch
and your fix.. but I'm eager to hear if Jianpeng and Mark can confirm it's
complete/correct or if there is still a problem.
sage
>
> Regards
> Somnath
>
> -Original Message-
> From: Sage Weil [mailto:sw...@redhat.com]
> Sent: Tuesday, August 19, 2014 8:55 PM
> To: Somnath Roy
> Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org;
> Mark Kirkwood; jianpeng...@intel.com
> Subject: RE: Deadlock in ceph journal
>
> [Copying ceph-devel, dropping ceph-users]
>
> Yeah, that looks like a bug. I pushed wip-filejournal that reapplies
> Jianpeng's original patch and this one. I'm not certain about last other
> suggested fix, though, but I'm hoping that this fix explains the strange
> behavior Jianpeng and Mark have seen?
>
> sage
>
>
> On Wed, 20 Aug 2014, Somnath Roy wrote:
> >
> > I think this is the issue..
> >
> >
> >
> > http://tracker.ceph.com/issues/9073
> >
> >
> >
> > Thanks & Regards
> >
> > Somnath
> >
> >
> >
> > From: Somnath Roy
> > Sent: Tuesday, August 19, 2014 6:25 PM
> > To: Sage Weil (s...@inktank.com); Samuel Just (sam.j...@inktank.com)
> > Cc: ceph-us...@lists.ceph.com
> > Subject: Deadlock in ceph journal
> >
> >
> >
> > Hi Sage/Sam,
> >
> > During our testing we found a potential deadlock scenario in the
> > filestore journal code base. This is happening because of two reason.
> >
> >
> >
> > 1. This is because code is not signaling aio_cond from
> > check_aio_completion() in case seq = 0
> >
> > 2. Following changes in the write_thread_entry() is allowing a
> > very first header write with seq = 0.
> >
> >if (writeq.empty() && !must_write_header) {
> >
> >
> >
> >
> >
> > Now, during ceph-deploy activate this is what happening.
> >
> >
> >
> > 1. The very first write of header with seq = 0 issued and it is
> > waiting for aio completion. So, aio_num = 1.
> >
> > 2. superblock write came in and got into while (aio_num > 0) block
> > of
> > write_thread_entry() and waiting on the aio_cond
> >
> > 3. The seq = 0 aio completed but not setting completed_something =
> > true and as a result aio_cond is not signaled.
> >
> > 4. write_thread_entry() is getting into deadlock.
> >
> >
> >
> > This is a timing problem and if header write is returned before
> > superblock write this will not happen and will be happening in case
> > of block journal device only (aio is enabled).
> >
> >
> >
> > Here is the log snippet we are getting.
> >
> >
> >
> > 2014-08-19 12:59:10.029363 7f60fa33b700 10 journal
> > write_thread_entry start
> >
> > 2014-08-19 12:59:10.029395 7f60fa33b700 20 journal
> > prepare_multi_write queue_pos now 4096
> >
> > 2014-08-19 12:59:10.029427 7f60fa33b700 15 journal do_aio_write
> > writing
> > 4096~0 + header
> >
> > 2014-08-19 12:59:10.029439 7f60fa33b700 20 journal write_aio_bl
> > 0~4096 seq 0
> >
> > 2014-08-19 12:59:10.029442 7f60f9339700 10 journal
> > write_finish_thread_entry enter
> >
> > 2014-08-19 12:59:10.029466 7f60fa33b700 20 journal write_aio_bl ..
> > 0~4096 in
> > 1
> >
> > 2014-08-19 12:59:10.029498 7f60fa33b700 20 journal write_aio_bl
> > 4096~0 seq 0
> >
> > 2014-08-19 12:59:10.029505 7f60fa33b700 5 journal put_throttle
> > finished 0 ops and 0 bytes, now 0 ops and 0 bytes
> >
> > 2014-08-19 12:59:10.029510 7f60fa33b700 20 journal
> > write_thread_entry going to sleep
> >
> > 2014-08-19 12:59:10.029538 7f60ff178800 10 journal journal_start
> >
> > 2014-08-19 12:59:10.029566 7f60f9339700 20 journal
> > write_finish_thread_entry waiting for aio(s)
> >
> > 2014-08-19 12:59:10.029726 7f60ff178800 15
> > filestore(/var/lib/ceph/tmp/mnt.NK
Re: Deadlock in ceph journal
Not yet, If you have to use master either revert commit 4eb18dd487da4cb621dcbecfc475fc0871b356ac or apply the patch for fixing the hang mentioned here https://github.com/ceph/ceph/pull/2185 Otherwise you could use the wip-filejournal branch which Sage has just added! Cheers Mark On 20/08/14 16:38, Somnath Roy wrote: Thanks Sage ! So, the latest master should have the fix, right ? -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Deadlock in ceph journal
Sorry, I see that sage has reverted it. On 20/08/14 16:58, Mark Kirkwood wrote: Not yet, If you have to use master either revert commit 4eb18dd487da4cb621dcbecfc475fc0871b356ac or apply the patch for fixing the hang mentioned here https://github.com/ceph/ceph/pull/2185 -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Deadlock in ceph journal
I suspect what is really needed is a drain_aio() function that will wait
for all pending aio ops to complete on shutdown. What happens to those
IOs if the process exists while they are in flight is probably undefined;
we should just avoid doing that.
sage
On Wed, 20 Aug 2014, Somnath Roy wrote:
> I will also take the patch and test it out.
>
> Thanks & Regards
> Somnath
>
> -Original Message-
> From: Sage Weil [mailto:sw...@redhat.com]
> Sent: Tuesday, August 19, 2014 9:51 PM
> To: Somnath Roy
> Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org; Mark
> Kirkwood; jianpeng...@intel.com
> Subject: RE: Deadlock in ceph journal
>
> On Wed, 20 Aug 2014, Somnath Roy wrote:
> > Thanks Sage !
> > So, the latest master should have the fix, right ?
>
> The original patch that caused the regression is reverted, but we'd like to
> reapply it if we sort out the issues. wip-filejournal has the offending
> patch and your fix.. but I'm eager to hear if Jianpeng and Mark can confirm
> it's complete/correct or if there is still a problem.
>
> sage
>
> >
> > Regards
> > Somnath
> >
> > -Original Message-
> > From: Sage Weil [mailto:sw...@redhat.com]
> > Sent: Tuesday, August 19, 2014 8:55 PM
> > To: Somnath Roy
> > Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org;
> > Mark Kirkwood; jianpeng...@intel.com
> > Subject: RE: Deadlock in ceph journal
> >
> > [Copying ceph-devel, dropping ceph-users]
> >
> > Yeah, that looks like a bug. I pushed wip-filejournal that reapplies
> > Jianpeng's original patch and this one. I'm not certain about last other
> > suggested fix, though, but I'm hoping that this fix explains the strange
> > behavior Jianpeng and Mark have seen?
> >
> > sage
> >
> >
> > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > >
> > > I think this is the issue..
> > >
> > >
> > >
> > > http://tracker.ceph.com/issues/9073
> > >
> > >
> > >
> > > Thanks & Regards
> > >
> > > Somnath
> > >
> > >
> > >
> > > From: Somnath Roy
> > > Sent: Tuesday, August 19, 2014 6:25 PM
> > > To: Sage Weil (s...@inktank.com); Samuel Just (sam.j...@inktank.com)
> > > Cc: ceph-us...@lists.ceph.com
> > > Subject: Deadlock in ceph journal
> > >
> > >
> > >
> > > Hi Sage/Sam,
> > >
> > > During our testing we found a potential deadlock scenario in the
> > > filestore journal code base. This is happening because of two reason.
> > >
> > >
> > >
> > > 1. This is because code is not signaling aio_cond from
> > > check_aio_completion() in case seq = 0
> > >
> > > 2. Following changes in the write_thread_entry() is allowing a
> > > very first header write with seq = 0.
> > >
> > >if (writeq.empty() && !must_write_header) {
> > >
> > >
> > >
> > >
> > >
> > > Now, during ceph-deploy activate this is what happening.
> > >
> > >
> > >
> > > 1. The very first write of header with seq = 0 issued and it is
> > > waiting for aio completion. So, aio_num = 1.
> > >
> > > 2. superblock write came in and got into while (aio_num > 0) block
> > > of
> > > write_thread_entry() and waiting on the aio_cond
> > >
> > > 3. The seq = 0 aio completed but not setting completed_something =
> > > true and as a result aio_cond is not signaled.
> > >
> > > 4. write_thread_entry() is getting into deadlock.
> > >
> > >
> > >
> > > This is a timing problem and if header write is returned before
> > > superblock write this will not happen and will be happening in case
> > > of block journal device only (aio is enabled).
> > >
> > >
> > >
> > > Here is the log snippet we are getting.
> > >
> > >
> > >
> > > 2014-08-19 12:59:10.029363 7f60fa33b700 10 journal
> > > write_thread_entry start
> > >
> > > 2014-08-19 12:59:10.029395 7f60fa33b700 20 journal
> > > prepare_multi_write queue_pos now 4096
> > >
> > > 2014-08-19 12:59:10.029427 7f60fa33b700 15 journal do_aio_write
> > > writing
> > > 4096~0 + header
> > >
> > > 2014-08-19 12:59:10.029439 7f60fa33b700 20 journal write_aio_bl
>
RE: Deadlock in ceph journal
Yes, Maybe for io_submit, it must use io_getevent. Otherwise the result is
undefined.
If stop_write == true, we don't use aio. How about this way?
Jianpeng
> -Original Message-
> From: Sage Weil [mailto:sw...@redhat.com]
> Sent: Wednesday, August 20, 2014 11:34 PM
> To: Somnath Roy
> Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org; Mark
> Kirkwood; Ma, Jianpeng
> Subject: RE: Deadlock in ceph journal
>
> I suspect what is really needed is a drain_aio() function that will wait for
> all
> pending aio ops to complete on shutdown. What happens to those IOs if the
> process exists while they are in flight is probably undefined; we should just
> avoid doing that.
>
> sage
>
>
> On Wed, 20 Aug 2014, Somnath Roy wrote:
>
> > I will also take the patch and test it out.
> >
> > Thanks & Regards
> > Somnath
> >
> > -Original Message-
> > From: Sage Weil [mailto:sw...@redhat.com]
> > Sent: Tuesday, August 19, 2014 9:51 PM
> > To: Somnath Roy
> > Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org;
> > Mark Kirkwood; jianpeng...@intel.com
> > Subject: RE: Deadlock in ceph journal
> >
> > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > > Thanks Sage !
> > > So, the latest master should have the fix, right ?
> >
> > The original patch that caused the regression is reverted, but we'd like to
> reapply it if we sort out the issues. wip-filejournal has the offending
> patch and
> your fix.. but I'm eager to hear if Jianpeng and Mark can confirm it's
> complete/correct or if there is still a problem.
> >
> > sage
> >
> > >
> > > Regards
> > > Somnath
> > >
> > > -Original Message-----
> > > From: Sage Weil [mailto:sw...@redhat.com]
> > > Sent: Tuesday, August 19, 2014 8:55 PM
> > > To: Somnath Roy
> > > Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org;
> > > Mark Kirkwood; jianpeng...@intel.com
> > > Subject: RE: Deadlock in ceph journal
> > >
> > > [Copying ceph-devel, dropping ceph-users]
> > >
> > > Yeah, that looks like a bug. I pushed wip-filejournal that reapplies
> Jianpeng's original patch and this one. I'm not certain about last other
> suggested fix, though, but I'm hoping that this fix explains the strange
> behavior
> Jianpeng and Mark have seen?
> > >
> > > sage
> > >
> > >
> > > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > > >
> > > > I think this is the issue..
> > > >
> > > >
> > > >
> > > > http://tracker.ceph.com/issues/9073
> > > >
> > > >
> > > >
> > > > Thanks & Regards
> > > >
> > > > Somnath
> > > >
> > > >
> > > >
> > > > From: Somnath Roy
> > > > Sent: Tuesday, August 19, 2014 6:25 PM
> > > > To: Sage Weil (s...@inktank.com); Samuel Just
> > > > (sam.j...@inktank.com)
> > > > Cc: ceph-us...@lists.ceph.com
> > > > Subject: Deadlock in ceph journal
> > > >
> > > >
> > > >
> > > > Hi Sage/Sam,
> > > >
> > > > During our testing we found a potential deadlock scenario in the
> > > > filestore journal code base. This is happening because of two reason.
> > > >
> > > >
> > > >
> > > > 1. This is because code is not signaling aio_cond from
> > > > check_aio_completion() in case seq = 0
> > > >
> > > > 2. Following changes in the write_thread_entry() is allowing a
> > > > very first header write with seq = 0.
> > > >
> > > >if (writeq.empty() && !must_write_header) {
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > Now, during ceph-deploy activate this is what happening.
> > > >
> > > >
> > > >
> > > > 1. The very first write of header with seq = 0 issued and it is
> > > > waiting for aio completion. So, aio_num = 1.
> > > >
> > > > 2. superblock write came in and got into while (aio_num > 0) block
> > > > of
> > > > write_thread_entry() and waiting on the aio_cond
> > > >
> > > > 3. The seq = 0 aio completed but not setting completed_something =
> > > > true and as a result aio_cond is not sign
RE: Deadlock in ceph journal
On Thu, 21 Aug 2014, Ma, Jianpeng wrote:
> Yes, Maybe for io_submit, it must use io_getevent. Otherwise the result is
> undefined.
> If stop_write == true, we don't use aio. How about this way?
That seems reasonable, now that I understand why it doesn't work the
other way. Do you mind resending your original patch with a comment
in the code to that effect? ("do sync write since we don't wait for
aio completions for header-only writes during shutdown")
sage
>
> Jianpeng
>
> > -Original Message-
> > From: Sage Weil [mailto:sw...@redhat.com]
> > Sent: Wednesday, August 20, 2014 11:34 PM
> > To: Somnath Roy
> > Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org; Mark
> > Kirkwood; Ma, Jianpeng
> > Subject: RE: Deadlock in ceph journal
> >
> > I suspect what is really needed is a drain_aio() function that will wait
> > for all
> > pending aio ops to complete on shutdown. What happens to those IOs if the
> > process exists while they are in flight is probably undefined; we should
> > just
> > avoid doing that.
> >
> > sage
> >
> >
> > On Wed, 20 Aug 2014, Somnath Roy wrote:
> >
> > > I will also take the patch and test it out.
> > >
> > > Thanks & Regards
> > > Somnath
> > >
> > > -Original Message-
> > > From: Sage Weil [mailto:sw...@redhat.com]
> > > Sent: Tuesday, August 19, 2014 9:51 PM
> > > To: Somnath Roy
> > > Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org;
> > > Mark Kirkwood; jianpeng...@intel.com
> > > Subject: RE: Deadlock in ceph journal
> > >
> > > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > > > Thanks Sage !
> > > > So, the latest master should have the fix, right ?
> > >
> > > The original patch that caused the regression is reverted, but we'd like
> > > to
> > reapply it if we sort out the issues. wip-filejournal has the offending
> > patch and
> > your fix.. but I'm eager to hear if Jianpeng and Mark can confirm it's
> > complete/correct or if there is still a problem.
> > >
> > > sage
> > >
> > > >
> > > > Regards
> > > > Somnath
> > > >
> > > > -Original Message-
> > > > From: Sage Weil [mailto:sw...@redhat.com]
> > > > Sent: Tuesday, August 19, 2014 8:55 PM
> > > > To: Somnath Roy
> > > > Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org;
> > > > Mark Kirkwood; jianpeng...@intel.com
> > > > Subject: RE: Deadlock in ceph journal
> > > >
> > > > [Copying ceph-devel, dropping ceph-users]
> > > >
> > > > Yeah, that looks like a bug. I pushed wip-filejournal that reapplies
> > Jianpeng's original patch and this one. I'm not certain about last other
> > suggested fix, though, but I'm hoping that this fix explains the strange
> > behavior
> > Jianpeng and Mark have seen?
> > > >
> > > > sage
> > > >
> > > >
> > > > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > > > >
> > > > > I think this is the issue..
> > > > >
> > > > >
> > > > >
> > > > > http://tracker.ceph.com/issues/9073
> > > > >
> > > > >
> > > > >
> > > > > Thanks & Regards
> > > > >
> > > > > Somnath
> > > > >
> > > > >
> > > > >
> > > > > From: Somnath Roy
> > > > > Sent: Tuesday, August 19, 2014 6:25 PM
> > > > > To: Sage Weil (s...@inktank.com); Samuel Just
> > > > > (sam.j...@inktank.com)
> > > > > Cc: ceph-us...@lists.ceph.com
> > > > > Subject: Deadlock in ceph journal
> > > > >
> > > > >
> > > > >
> > > > > Hi Sage/Sam,
> > > > >
> > > > > During our testing we found a potential deadlock scenario in the
> > > > > filestore journal code base. This is happening because of two reason.
> > > > >
> > > > >
> > > > >
> > > > > 1. This is because code is not signaling aio_cond from
> > > > > check_aio_completion() in case seq = 0
> > > > >
> > > > > 2. Following changes in the write_thread_entry() is allowing a
&g
RE: Deadlock in ceph journal
Hi sage,
The pull request:https://github.com/ceph/ceph/pull/2296.
Mark
After sage merge this into wip-filejournal, can you test again? I think at
present only you can do this work!
Thanks!
Jianpeng
> -Original Message-
> From: Sage Weil [mailto:sw...@redhat.com]
> Sent: Thursday, August 21, 2014 11:53 AM
> To: Ma, Jianpeng
> Cc: Somnath Roy; Samuel Just (sam.j...@inktank.com);
> ceph-devel@vger.kernel.org; Mark Kirkwood
> Subject: RE: Deadlock in ceph journal
>
> On Thu, 21 Aug 2014, Ma, Jianpeng wrote:
> > Yes, Maybe for io_submit, it must use io_getevent. Otherwise the result is
> undefined.
> > If stop_write == true, we don't use aio. How about this way?
>
> That seems reasonable, now that I understand why it doesn't work the other
> way. Do you mind resending your original patch with a comment in the code
> to that effect? ("do sync write since we don't wait for aio completions for
> header-only writes during shutdown")
>
> sage
>
>
> >
> > Jianpeng
> >
> > > -Original Message-
> > > From: Sage Weil [mailto:sw...@redhat.com]
> > > Sent: Wednesday, August 20, 2014 11:34 PM
> > > To: Somnath Roy
> > > Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org;
> > > Mark Kirkwood; Ma, Jianpeng
> > > Subject: RE: Deadlock in ceph journal
> > >
> > > I suspect what is really needed is a drain_aio() function that will
> > > wait for all pending aio ops to complete on shutdown. What happens
> > > to those IOs if the process exists while they are in flight is
> > > probably undefined; we should just avoid doing that.
> > >
> > > sage
> > >
> > >
> > > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > >
> > > > I will also take the patch and test it out.
> > > >
> > > > Thanks & Regards
> > > > Somnath
> > > >
> > > > -Original Message-
> > > > From: Sage Weil [mailto:sw...@redhat.com]
> > > > Sent: Tuesday, August 19, 2014 9:51 PM
> > > > To: Somnath Roy
> > > > Cc: Samuel Just (sam.j...@inktank.com);
> > > > ceph-devel@vger.kernel.org; Mark Kirkwood; jianpeng...@intel.com
> > > > Subject: RE: Deadlock in ceph journal
> > > >
> > > > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > > > > Thanks Sage !
> > > > > So, the latest master should have the fix, right ?
> > > >
> > > > The original patch that caused the regression is reverted, but
> > > > we'd like to
> > > reapply it if we sort out the issues. wip-filejournal has the
> > > offending patch and your fix.. but I'm eager to hear if Jianpeng and
> > > Mark can confirm it's complete/correct or if there is still a problem.
> > > >
> > > > sage
> > > >
> > > > >
> > > > > Regards
> > > > > Somnath
> > > > >
> > > > > -Original Message-
> > > > > From: Sage Weil [mailto:sw...@redhat.com]
> > > > > Sent: Tuesday, August 19, 2014 8:55 PM
> > > > > To: Somnath Roy
> > > > > Cc: Samuel Just (sam.j...@inktank.com);
> > > > > ceph-devel@vger.kernel.org; Mark Kirkwood; jianpeng...@intel.com
> > > > > Subject: RE: Deadlock in ceph journal
> > > > >
> > > > > [Copying ceph-devel, dropping ceph-users]
> > > > >
> > > > > Yeah, that looks like a bug. I pushed wip-filejournal that
> > > > > reapplies
> > > Jianpeng's original patch and this one. I'm not certain about last
> > > other suggested fix, though, but I'm hoping that this fix explains
> > > the strange behavior Jianpeng and Mark have seen?
> > > > >
> > > > > sage
> > > > >
> > > > >
> > > > > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > > > > >
> > > > > > I think this is the issue..
> > > > > >
> > > > > >
> > > > > >
> > > > > > http://tracker.ceph.com/issues/9073
> > > > > >
> > > > > >
> > > > > >
> > > > > > Thanks & Regards
> > > > > >
> > > > > > Somnath
> > > > > >
> > > > > >
> > > > > >
> > > > > > From: Somnath Roy
> > > &
Re: Deadlock in ceph journal
Will do. On 21/08/14 19:30, Ma, Jianpeng wrote: Mark After sage merge this into wip-filejournal, can you test again? I think at present only you can do this work! -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Deadlock in ceph journal
I've pushed the patch to wip-filejournal. Mark, can you test please?
Thanks!
sage
On Thu, 21 Aug 2014, Ma, Jianpeng wrote:
> Hi sage,
>The pull request:https://github.com/ceph/ceph/pull/2296.
>
> Mark
>After sage merge this into wip-filejournal, can you test again? I think at
> present only you can do this work!
>
> Thanks!
> Jianpeng
>
> > -Original Message-
> > From: Sage Weil [mailto:sw...@redhat.com]
> > Sent: Thursday, August 21, 2014 11:53 AM
> > To: Ma, Jianpeng
> > Cc: Somnath Roy; Samuel Just (sam.j...@inktank.com);
> > ceph-devel@vger.kernel.org; Mark Kirkwood
> > Subject: RE: Deadlock in ceph journal
> >
> > On Thu, 21 Aug 2014, Ma, Jianpeng wrote:
> > > Yes, Maybe for io_submit, it must use io_getevent. Otherwise the result is
> > undefined.
> > > If stop_write == true, we don't use aio. How about this way?
> >
> > That seems reasonable, now that I understand why it doesn't work the other
> > way. Do you mind resending your original patch with a comment in the code
> > to that effect? ("do sync write since we don't wait for aio completions for
> > header-only writes during shutdown")
> >
> > sage
> >
> >
> > >
> > > Jianpeng
> > >
> > > > -Original Message-
> > > > From: Sage Weil [mailto:sw...@redhat.com]
> > > > Sent: Wednesday, August 20, 2014 11:34 PM
> > > > To: Somnath Roy
> > > > Cc: Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org;
> > > > Mark Kirkwood; Ma, Jianpeng
> > > > Subject: RE: Deadlock in ceph journal
> > > >
> > > > I suspect what is really needed is a drain_aio() function that will
> > > > wait for all pending aio ops to complete on shutdown. What happens
> > > > to those IOs if the process exists while they are in flight is
> > > > probably undefined; we should just avoid doing that.
> > > >
> > > > sage
> > > >
> > > >
> > > > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > > >
> > > > > I will also take the patch and test it out.
> > > > >
> > > > > Thanks & Regards
> > > > > Somnath
> > > > >
> > > > > -Original Message-
> > > > > From: Sage Weil [mailto:sw...@redhat.com]
> > > > > Sent: Tuesday, August 19, 2014 9:51 PM
> > > > > To: Somnath Roy
> > > > > Cc: Samuel Just (sam.j...@inktank.com);
> > > > > ceph-devel@vger.kernel.org; Mark Kirkwood; jianpeng...@intel.com
> > > > > Subject: RE: Deadlock in ceph journal
> > > > >
> > > > > On Wed, 20 Aug 2014, Somnath Roy wrote:
> > > > > > Thanks Sage !
> > > > > > So, the latest master should have the fix, right ?
> > > > >
> > > > > The original patch that caused the regression is reverted, but
> > > > > we'd like to
> > > > reapply it if we sort out the issues. wip-filejournal has the
> > > > offending patch and your fix.. but I'm eager to hear if Jianpeng and
> > > > Mark can confirm it's complete/correct or if there is still a problem.
> > > > >
> > > > > sage
> > > > >
> > > > > >
> > > > > > Regards
> > > > > > Somnath
> > > > > >
> > > > > > -Original Message-
> > > > > > From: Sage Weil [mailto:sw...@redhat.com]
> > > > > > Sent: Tuesday, August 19, 2014 8:55 PM
> > > > > > To: Somnath Roy
> > > > > > Cc: Samuel Just (sam.j...@inktank.com);
> > > > > > ceph-devel@vger.kernel.org; Mark Kirkwood; jianpeng...@intel.com
> > > > > > Subject: RE: Deadlock in ceph journal
> > > > > >
> > > > > > [Copying ceph-devel, dropping ceph-users]
> > > > > >
> > > > > > Yeah, that looks like a bug. I pushed wip-filejournal that
> > > > > > reapplies
> > > > Jianpeng's original patch and this one. I'm not certain about last
> > > > other suggested fix, though, but I'm hoping that this fix explains
> > > > the strange behavior Jianpeng and Mark have seen?
> > > > > >
> > > > > > sage
> > > > > >
> > > > > >
> > > > > > O
Re: Deadlock in ceph journal
On 22/08/14 03:23, Sage Weil wrote: I've pushed the patch to wip-filejournal. Mark, can you test please? I've tested wip-filejournal and looks good (25 test runs, good journal header each time). Cheers Mark -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Deadlock in ceph journal
On Fri, 22 Aug 2014, Mark Kirkwood wrote: > On 22/08/14 03:23, Sage Weil wrote: > > I've pushed the patch to wip-filejournal. Mark, can you test please? > > > > I've tested wip-filejournal and looks good (25 test runs, good journal header > each time). Thanks! Merged. sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Deadlock in ceph journal
On 22/08/14 12:49, Sage Weil wrote: On Fri, 22 Aug 2014, Mark Kirkwood wrote: On 22/08/14 03:23, Sage Weil wrote: I've pushed the patch to wip-filejournal. Mark, can you test please? I've tested wip-filejournal and looks good (25 test runs, good journal header each time). Thanks! Merged. Excellent. One thing that does still concern me - if I understand what is happening here correctly: we write to the journal using aio until we want to stop doing writes (presumably pre closing it), then use normal io to write at that point. Given that we appear to be using direct io whenever we use aio, does this mean we end up mixing direct and buffered io to the journal [1] (or is the normal i.e non aio write still using direct io)? Cheers Mark [1] which I understand is bad... -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Deadlock in ceph journal
I think it is using direct io for non-aio mode as well. Thanks & Regards Somnath -Original Message- From: Mark Kirkwood [mailto:mark.kirkw...@catalyst.net.nz] Sent: Friday, August 22, 2014 3:19 PM To: Sage Weil Cc: Ma, Jianpeng; Somnath Roy; Samuel Just (sam.j...@inktank.com); ceph-devel@vger.kernel.org Subject: Re: Deadlock in ceph journal On 22/08/14 12:49, Sage Weil wrote: > On Fri, 22 Aug 2014, Mark Kirkwood wrote: >> On 22/08/14 03:23, Sage Weil wrote: >>> I've pushed the patch to wip-filejournal. Mark, can you test please? >>> >> >> I've tested wip-filejournal and looks good (25 test runs, good >> journal header each time). > > Thanks! Merged. > Excellent. One thing that does still concern me - if I understand what is happening here correctly: we write to the journal using aio until we want to stop doing writes (presumably pre closing it), then use normal io to write at that point. Given that we appear to be using direct io whenever we use aio, does this mean we end up mixing direct and buffered io to the journal [1] (or is the normal i.e non aio write still using direct io)? Cheers Mark [1] which I understand is bad... PLEASE NOTE: The information contained in this electronic mail message is intended only for the use of the designated recipient(s) named above. If the reader of this message is not the intended recipient, you are hereby notified that you have received this message in error and that any review, dissemination, distribution, or copying of this message is strictly prohibited. If you have received this communication in error, please notify the sender by telephone or e-mail (as shown above) immediately and destroy any and all copies of this message in your possession (whether hard copies or electronically stored copies). -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Deadlock in ceph journal
On Fri, 22 Aug 2014, Somnath Roy wrote: > I think it is using direct io for non-aio mode as well. Right. aio is always direct io (in our case at least). sage > > Thanks & Regards > Somnath > > -Original Message- > From: Mark Kirkwood [mailto:mark.kirkw...@catalyst.net.nz] > Sent: Friday, August 22, 2014 3:19 PM > To: Sage Weil > Cc: Ma, Jianpeng; Somnath Roy; Samuel Just (sam.j...@inktank.com); > ceph-devel@vger.kernel.org > Subject: Re: Deadlock in ceph journal > > On 22/08/14 12:49, Sage Weil wrote: > > On Fri, 22 Aug 2014, Mark Kirkwood wrote: > >> On 22/08/14 03:23, Sage Weil wrote: > >>> I've pushed the patch to wip-filejournal. Mark, can you test please? > >>> > >> > >> I've tested wip-filejournal and looks good (25 test runs, good > >> journal header each time). > > > > Thanks! Merged. > > > > Excellent. > > One thing that does still concern me - if I understand what is happening here > correctly: we write to the journal using aio until we want to stop doing > writes (presumably pre closing it), then use normal io to write at that point. > > Given that we appear to be using direct io whenever we use aio, does this > mean we end up mixing direct and buffered io to the journal [1] (or is the > normal i.e non aio write still using direct io)? > > Cheers > > Mark > > [1] which I understand is bad... > > > > PLEASE NOTE: The information contained in this electronic mail message is > intended only for the use of the designated recipient(s) named above. If the > reader of this message is not the intended recipient, you are hereby notified > that you have received this message in error and that any review, > dissemination, distribution, or copying of this message is strictly > prohibited. If you have received this communication in error, please notify > the sender by telephone or e-mail (as shown above) immediately and destroy > any and all copies of this message in your possession (whether hard copies or > electronically stored copies). > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Deadlock in ceph journal
On 23/08/14 10:22, Somnath Roy wrote:
I think it is using direct io for non-aio mode as well.
Thanks & Regards
Somnath
One thing that does still concern me - if I understand what is happening here
correctly: we write to the journal using aio until we want to stop doing writes
(presumably pre closing it), then use normal io to write at that point.
Given that we appear to be using direct io whenever we use aio, does this mean
we end up mixing direct and buffered io to the journal [1] (or is the normal
i.e non aio write still using direct io)?
Thanks Somnath,
I think you are correct (I missed the bit in FileJournal::_open that
seems to cover this):
if (forwrite) {
flags = O_RDWR;
if (directio)
flags |= O_DIRECT | O_DSYNC;
i.e the journal is opened with DIRECT, so all writes (async or not) will
be direct.
Cheers
Mark
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Deadlock in ceph journal
Hi all,
At weekend, I read the kernel code about aio & direction. For close(), it
don't wait aio to complete.
But for fsync(), it will wait all aio to complete.
Mark used this patch(which using fsync() on write_thread_entry) and the
result is looks good.
I want to revert the patch which don't use aio when closing journal. And
using fsync(). It make the code simple.
How about this?
Thanks!
Jianpeng
> ceph-devel@vger.kernel.org
> Subject: Re: Deadlock in ceph journal
>
> On 23/08/14 10:22, Somnath Roy wrote:
> > I think it is using direct io for non-aio mode as well.
> >
> > Thanks & Regards
> > Somnath
> >
>
> > One thing that does still concern me - if I understand what is happening
> > here
> correctly: we write to the journal using aio until we want to stop doing
> writes
> (presumably pre closing it), then use normal io to write at that point.
> >
> > Given that we appear to be using direct io whenever we use aio, does this
> mean we end up mixing direct and buffered io to the journal [1] (or is the
> normal i.e non aio write still using direct io)?
> >
> >
>
> Thanks Somnath,
>
> I think you are correct (I missed the bit in FileJournal::_open that seems to
> cover this):
>
>
>if (forwrite) {
> flags = O_RDWR;
> if (directio)
>flags |= O_DIRECT | O_DSYNC;
>
>
> i.e the journal is opened with DIRECT, so all writes (async or not) will
> be direct.
>
> Cheers
>
> Mark
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Deadlock in ceph journal
Sounds good. Can you send a patch?
sage
On Mon, 25 Aug 2014, Ma, Jianpeng wrote:
> Hi all,
>At weekend, I read the kernel code about aio & direction. For close(), it
> don't wait aio to complete.
> But for fsync(), it will wait all aio to complete.
>Mark used this patch(which using fsync() on write_thread_entry) and the
> result is looks good.
>I want to revert the patch which don't use aio when closing journal. And
> using fsync(). It make the code simple.
>How about this?
>
> Thanks!
> Jianpeng
>
> > ceph-devel@vger.kernel.org
> > Subject: Re: Deadlock in ceph journal
> >
> > On 23/08/14 10:22, Somnath Roy wrote:
> > > I think it is using direct io for non-aio mode as well.
> > >
> > > Thanks & Regards
> > > Somnath
> > >
> >
> > > One thing that does still concern me - if I understand what is happening
> > > here
> > correctly: we write to the journal using aio until we want to stop doing
> > writes
> > (presumably pre closing it), then use normal io to write at that point.
> > >
> > > Given that we appear to be using direct io whenever we use aio, does this
> > mean we end up mixing direct and buffered io to the journal [1] (or is the
> > normal i.e non aio write still using direct io)?
> > >
> > >
> >
> > Thanks Somnath,
> >
> > I think you are correct (I missed the bit in FileJournal::_open that seems
> > to
> > cover this):
> >
> >
> >if (forwrite) {
> > flags = O_RDWR;
> > if (directio)
> >flags |= O_DIRECT | O_DSYNC;
> >
> >
> > i.e the journal is opened with DIRECT, so all writes (async or not) will
> > be direct.
> >
> > Cheers
> >
> > Mark
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: Deadlock in ceph journal
The attachment is the patch.
Jianpeng
> -Original Message-
> From: ceph-devel-ow...@vger.kernel.org
> [mailto:ceph-devel-ow...@vger.kernel.org] On Behalf Of Sage Weil
> Sent: Monday, August 25, 2014 10:15 AM
> To: Ma, Jianpeng
> Cc: Mark Kirkwood; Somnath Roy; Samuel Just (sam.j...@inktank.com);
> ceph-devel@vger.kernel.org
> Subject: RE: Deadlock in ceph journal
>
> Sounds good. Can you send a patch?
>
> sage
>
>
> On Mon, 25 Aug 2014, Ma, Jianpeng wrote:
>
> > Hi all,
> >At weekend, I read the kernel code about aio & direction. For close(), it
> don't wait aio to complete.
> > But for fsync(), it will wait all aio to complete.
> >Mark used this patch(which using fsync() on write_thread_entry) and the
> result is looks good.
> >I want to revert the patch which don't use aio when closing journal. And
> using fsync(). It make the code simple.
> >How about this?
> >
> > Thanks!
> > Jianpeng
> >
> > > ceph-devel@vger.kernel.org
> > > Subject: Re: Deadlock in ceph journal
> > >
> > > On 23/08/14 10:22, Somnath Roy wrote:
> > > > I think it is using direct io for non-aio mode as well.
> > > >
> > > > Thanks & Regards
> > > > Somnath
> > > >
> > >
> > > > One thing that does still concern me - if I understand what is
> > > > happening here
> > > correctly: we write to the journal using aio until we want to stop
> > > doing writes (presumably pre closing it), then use normal io to write at
> > > that
> point.
> > > >
> > > > Given that we appear to be using direct io whenever we use aio,
> > > > does this
> > > mean we end up mixing direct and buffered io to the journal [1] (or
> > > is the normal i.e non aio write still using direct io)?
> > > >
> > > >
> > >
> > > Thanks Somnath,
> > >
> > > I think you are correct (I missed the bit in FileJournal::_open that
> > > seems to cover this):
> > >
> > >
> > >if (forwrite) {
> > > flags = O_RDWR;
> > > if (directio)
> > >flags |= O_DIRECT | O_DSYNC;
> > >
> > >
> > > i.e the journal is opened with DIRECT, so all writes (async or not)
> > > will be direct.
> > >
> > > Cheers
> > >
> > > Mark
> > --
> > To unsubscribe from this list: send the line "unsubscribe ceph-devel"
> > in the body of a message to majord...@vger.kernel.org More majordomo
> > info at http://vger.kernel.org/majordomo-info.html
> >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the
> body
> of a message to majord...@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
0001-os-FileJournal-Before-write_thread_entry-exit-using-.patch
Description: 0001-os-FileJournal-Before-write_thread_entry-exit-using-.patch
