[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Fangrui Song via Phabricator via cfe-commits 
MaskRay added a comment.

In D100981#2709450 , @thakis wrote:

> maskray: your undelete didn't add back BuiltinsLe64.def so builds are broken 
> atm

Fixed by vitalybuka


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100981/new/

https://reviews.llvm.org/D100981

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Nico Weber via Phabricator via cfe-commits 
thakis added a comment.

maskray: your undelete didn't add back BuiltinsLe64.def so builds are broken atm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100981/new/

https://reviews.llvm.org/D100981

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Derek Schuff via Phabricator via cfe-commits 
dschuff added a comment.

Would it make sense for you to to upstream an LLVM target such as le32-halide? 
(Or perhaps even arm32-halide or some other?) Then you'd actually have more 
control over your own codegen, datalayout, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100981/new/

https://reviews.llvm.org/D100981

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Steven Johnson via Phabricator via cfe-commits 
srj added a comment.

In D100981#2709205 , @MaskRay wrote:

> In D100981#2709044 , @srj wrote:
>
>> Any chance that this could be (temporarily) reverted? This will break 
>> literally all Halide compilation; we're working on a fix on our side, but it 
>> would be nice to have a few days to be sure we have it right, and I suspect 
>> there's no urgency to removing this right now.
>
> Will https://github.com/halide/Halide/pull/5934 take longer? If it does, I 
> can temporarily revert this.

Yeah, the first simple attempt in https://github.com/halide/Halide/pull/5934 
doesn't work (many things are broken). Temporarily reverting this would be a 
huge huge favor to us.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100981/new/

https://reviews.llvm.org/D100981

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Fangrui Song via Phabricator via cfe-commits 
MaskRay added a comment.
Herald added a subscriber: tmatheson.

In D100981#2709044 , @srj wrote:

> Any chance that this could be (temporarily) reverted? This will break 
> literally all Halide compilation; we're working on a fix on our side, but it 
> would be nice to have a few days to be sure we have it right, and I suspect 
> there's no urgency to removing this right now.

Will https://github.com/halide/Halide/pull/5934 take longer? If it does, I can 
temporarily revert this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100981/new/

https://reviews.llvm.org/D100981

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Steven Johnson via Phabricator via cfe-commits 
srj added a comment.

Any chance that this could be (temporarily) reverted? This will break literally 
all Halide compilation; we're working on a fix on our side, but it would be 
nice to have a few days to be sure we have it right, and I suspect there's no 
urgency to removing this right now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100981/new/

https://reviews.llvm.org/D100981

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100981: Delete le32/le64 targets

2021-04-22 Thread Andrew Adams via Phabricator via cfe-commits 
abadams added a comment.

In D100981#2706899 , @dschuff wrote:

> Thanks. I had heard in the past that there were some other folks who had used 
> le32/le64 as a "generic" target (in fact that's why it's named so 
> generically, rather than being called "pnacl" or similar) but I haven't heard 
> of anything recently, and as you can see nobody has upstreamed any support 
> for other OS or target specializations or asked to collaborate on it. 
> Practically speaking even a target that wants fairly generic bitcode would 
> probably want its own triple, so unless this removal captures someone's 
> attention who wants to keep maintaining it, this should be fine to remove.

I think that was us, the Halide language. Any suggested alternative for us to 
use now? This does indeed break all our llvm usage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100981/new/

https://reviews.llvm.org/D100981

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100981: Delete le32/le64 targets

2021-04-21 Thread Fangrui Song via Phabricator via cfe-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG77ac823fd285: Delete le32/le64 targets (authored by MaskRay).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100981/new/

https://reviews.llvm.org/D100981

Files:
  clang/include/clang/Basic/BuiltinsLe64.def
  clang/include/clang/Basic/TargetBuiltins.h
  clang/include/clang/module.modulemap
  clang/lib/Basic/CMakeLists.txt
  clang/lib/Basic/Targets.cpp
  clang/lib/Basic/Targets/Le64.cpp
  clang/lib/Basic/Targets/Le64.h
  clang/lib/Basic/Targets/OSTargets.h
  clang/lib/CodeGen/ItaniumCXXABI.cpp
  clang/lib/CodeGen/TargetInfo.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/test/CodeGen/ext-int-cc.c
  clang/test/CodeGen/le32-arguments.c
  clang/test/CodeGen/le32-libcall-pow.c
  clang/test/CodeGen/le32-regparm.c
  clang/test/CodeGen/le32-vaarg.c
  clang/test/CodeGen/pr18235.c
  clang/test/CodeGen/target-data.c
  clang/test/CodeGenCXX/member-function-pointers.cpp
  clang/test/CodeGenCXX/static-init-pnacl.cpp
  clang/test/Driver/le32-toolchain.c
  clang/test/Driver/le32-unknown-nacl.cpp
  clang/test/Driver/le64-unknown-unknown.cpp
  clang/test/Headers/stdarg.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/lib/Support/Triple.cpp
  llvm/test/CodeGen/Generic/no-target.ll
  llvm/unittests/ADT/TripleTest.cpp
  llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn

Index: llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn
===
--- llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn
+++ llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn
@@ -93,7 +93,6 @@
 "Targets/BPF.cpp",
 "Targets/Hexagon.cpp",
 "Targets/Lanai.cpp",
-"Targets/Le64.cpp",
 "Targets/M68k.cpp",
 "Targets/MSP430.cpp",
 "Targets/Mips.cpp",
Index: llvm/unittests/ADT/TripleTest.cpp
===
--- llvm/unittests/ADT/TripleTest.cpp
+++ llvm/unittests/ADT/TripleTest.cpp
@@ -1044,14 +1044,6 @@
   EXPECT_EQ(Triple::renderscript32, T.get32BitArchVariant().getArch());
   EXPECT_EQ(Triple::renderscript64, T.get64BitArchVariant().getArch());
 
-  T.setArch(Triple::le32);
-  EXPECT_EQ(Triple::le32, T.get32BitArchVariant().getArch());
-  EXPECT_EQ(Triple::le64, T.get64BitArchVariant().getArch());
-
-  T.setArch(Triple::le64);
-  EXPECT_EQ(Triple::le32, T.get32BitArchVariant().getArch());
-  EXPECT_EQ(Triple::le64, T.get64BitArchVariant().getArch());
-
   T.setArch(Triple::armeb);
   EXPECT_EQ(Triple::armeb, T.get32BitArchVariant().getArch());
   EXPECT_EQ(Triple::aarch64_be, T.get64BitArchVariant().getArch());
@@ -1166,14 +1158,6 @@
   EXPECT_EQ(Triple::tce, T.getBigEndianArchVariant().getArch());
   EXPECT_EQ(Triple::tcele, T.getLittleEndianArchVariant().getArch());
 
-  T.setArch(Triple::le32);
-  EXPECT_EQ(Triple::UnknownArch, T.getBigEndianArchVariant().getArch());
-  EXPECT_EQ(Triple::le32, T.getLittleEndianArchVariant().getArch());
-
-  T.setArch(Triple::le64);
-  EXPECT_EQ(Triple::UnknownArch, T.getBigEndianArchVariant().getArch());
-  EXPECT_EQ(Triple::le64, T.getLittleEndianArchVariant().getArch());
-
   T.setArch(Triple::csky);
   EXPECT_EQ(Triple::UnknownArch, T.getBigEndianArchVariant().getArch());
   EXPECT_EQ(Triple::csky, T.getLittleEndianArchVariant().getArch());
Index: llvm/test/CodeGen/Generic/no-target.ll
===
--- llvm/test/CodeGen/Generic/no-target.ll
+++ /dev/null
@@ -1,3 +0,0 @@
-; RUN: not llc -mtriple le32-unknown-nacl %s -o - 2>&1 | FileCheck %s
-
-; CHECK: error: unable to get target for 'le32-unknown-nacl'
Index: llvm/lib/Support/Triple.cpp
===
--- llvm/lib/Support/Triple.cpp
+++ llvm/lib/Support/Triple.cpp
@@ -42,8 +42,6 @@
   case hsail:  return "hsail";
   case kalimba:return "kalimba";
   case lanai:  return "lanai";
-  case le32:   return "le32";
-  case le64:   return "le64";
   case m68k:   return "m68k";
   case mips64: return "mips64";
   case mips64el:   return "mips64el";
@@ -136,9 +134,6 @@
   case nvptx:   return "nvvm";
   case nvptx64: return "nvvm";
 
-  case le32:return "le32";
-  case le64:return "le64";
-
   case amdil:
   case amdil64: return "amdil";
 
@@ -315,8 +310,6 @@
 .Case("xcore", xcore)
 .Case("nvptx", nvptx)
 .Case("nvptx64", nvptx64)
-.Case("le32", le32)
-.Case("le64", le64)
 .Case("amdil", amdil)
 .Case("amdil64", amdil64)
 .Case("hsail", hsail)
@@ -448,8 +441,6 @@
 .Case("xcore", Triple::xcore)
 .Case("nvptx", Triple::nvptx)
 .Case("nvptx64", Triple::nvptx64)
-.Case("le32", Triple::le32)
-.Case("le64", Triple::le64)
 .Case("amdil", Triple::amdil)
 .Case("amdil64", Triple::amdil64)
 .Case("hsail", Triple::hsail

[PATCH] D100981: Delete le32/le64 targets

2021-04-21 Thread Derek Schuff via Phabricator via cfe-commits 
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

Thanks. I had heard in the past that there were some other folks who had used 
le32/le64 as a "generic" target (in fact that's why it's named so generically, 
rather than being called "pnacl" or similar) but I haven't heard of anything 
recently, and as you can see nobody has upstreamed any support for other OS or 
target specializations or asked to collaborate on it. Practically speaking even 
a target that wants fairly generic bitcode would probably want its own triple, 
so unless this removal captures someone's attention who wants to keep 
maintaining it, this should be fine to remove.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100981/new/

https://reviews.llvm.org/D100981

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100981: Delete le32/le64 targets

2021-04-21 Thread Fangrui Song via Phabricator via cfe-commits 
MaskRay created this revision.
MaskRay added a reviewer: dschuff.
Herald added subscribers: dexonsmith, jfb, hiraditya, mgorny.
MaskRay requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, aheejin.
Herald added projects: clang, LLVM.

They are unused now.

Note: NaCl is still used and is currently expected to be needed until 2022-06
(https://blog.chromium.org/2020/08/changes-to-chrome-app-support-timeline.html).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100981

Files:
  clang/include/clang/Basic/BuiltinsLe64.def
  clang/include/clang/Basic/TargetBuiltins.h
  clang/include/clang/module.modulemap
  clang/lib/Basic/CMakeLists.txt
  clang/lib/Basic/Targets.cpp
  clang/lib/Basic/Targets/Le64.cpp
  clang/lib/Basic/Targets/Le64.h
  clang/lib/Basic/Targets/OSTargets.h
  clang/lib/CodeGen/ItaniumCXXABI.cpp
  clang/lib/CodeGen/TargetInfo.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/test/CodeGen/ext-int-cc.c
  clang/test/CodeGen/le32-arguments.c
  clang/test/CodeGen/le32-libcall-pow.c
  clang/test/CodeGen/le32-regparm.c
  clang/test/CodeGen/le32-vaarg.c
  clang/test/CodeGen/pr18235.c
  clang/test/CodeGen/target-data.c
  clang/test/CodeGenCXX/member-function-pointers.cpp
  clang/test/CodeGenCXX/static-init-pnacl.cpp
  clang/test/Driver/le32-toolchain.c
  clang/test/Driver/le32-unknown-nacl.cpp
  clang/test/Driver/le64-unknown-unknown.cpp
  clang/test/Headers/stdarg.cpp
  llvm/include/llvm/ADT/Triple.h
  llvm/lib/Support/Triple.cpp
  llvm/test/CodeGen/Generic/no-target.ll
  llvm/unittests/ADT/TripleTest.cpp
  llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn

Index: llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn
===
--- llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn
+++ llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn
@@ -93,7 +93,6 @@
 "Targets/BPF.cpp",
 "Targets/Hexagon.cpp",
 "Targets/Lanai.cpp",
-"Targets/Le64.cpp",
 "Targets/M68k.cpp",
 "Targets/MSP430.cpp",
 "Targets/Mips.cpp",
Index: llvm/unittests/ADT/TripleTest.cpp
===
--- llvm/unittests/ADT/TripleTest.cpp
+++ llvm/unittests/ADT/TripleTest.cpp
@@ -1044,14 +1044,6 @@
   EXPECT_EQ(Triple::renderscript32, T.get32BitArchVariant().getArch());
   EXPECT_EQ(Triple::renderscript64, T.get64BitArchVariant().getArch());
 
-  T.setArch(Triple::le32);
-  EXPECT_EQ(Triple::le32, T.get32BitArchVariant().getArch());
-  EXPECT_EQ(Triple::le64, T.get64BitArchVariant().getArch());
-
-  T.setArch(Triple::le64);
-  EXPECT_EQ(Triple::le32, T.get32BitArchVariant().getArch());
-  EXPECT_EQ(Triple::le64, T.get64BitArchVariant().getArch());
-
   T.setArch(Triple::armeb);
   EXPECT_EQ(Triple::armeb, T.get32BitArchVariant().getArch());
   EXPECT_EQ(Triple::aarch64_be, T.get64BitArchVariant().getArch());
@@ -1166,14 +1158,6 @@
   EXPECT_EQ(Triple::tce, T.getBigEndianArchVariant().getArch());
   EXPECT_EQ(Triple::tcele, T.getLittleEndianArchVariant().getArch());
 
-  T.setArch(Triple::le32);
-  EXPECT_EQ(Triple::UnknownArch, T.getBigEndianArchVariant().getArch());
-  EXPECT_EQ(Triple::le32, T.getLittleEndianArchVariant().getArch());
-
-  T.setArch(Triple::le64);
-  EXPECT_EQ(Triple::UnknownArch, T.getBigEndianArchVariant().getArch());
-  EXPECT_EQ(Triple::le64, T.getLittleEndianArchVariant().getArch());
-
   T.setArch(Triple::csky);
   EXPECT_EQ(Triple::UnknownArch, T.getBigEndianArchVariant().getArch());
   EXPECT_EQ(Triple::csky, T.getLittleEndianArchVariant().getArch());
Index: llvm/test/CodeGen/Generic/no-target.ll
===
--- llvm/test/CodeGen/Generic/no-target.ll
+++ /dev/null
@@ -1,3 +0,0 @@
-; RUN: not llc -mtriple le32-unknown-nacl %s -o - 2>&1 | FileCheck %s
-
-; CHECK: error: unable to get target for 'le32-unknown-nacl'
Index: llvm/lib/Support/Triple.cpp
===
--- llvm/lib/Support/Triple.cpp
+++ llvm/lib/Support/Triple.cpp
@@ -42,8 +42,6 @@
   case hsail:  return "hsail";
   case kalimba:return "kalimba";
   case lanai:  return "lanai";
-  case le32:   return "le32";
-  case le64:   return "le64";
   case m68k:   return "m68k";
   case mips64: return "mips64";
   case mips64el:   return "mips64el";
@@ -136,9 +134,6 @@
   case nvptx:   return "nvvm";
   case nvptx64: return "nvvm";
 
-  case le32:return "le32";
-  case le64:return "le64";
-
   case amdil:
   case amdil64: return "amdil";
 
@@ -315,8 +310,6 @@
 .Case("xcore", xcore)
 .Case("nvptx", nvptx)
 .Case("nvptx64", nvptx64)
-.Case("le32", le32)
-.Case("le64", le64)
 .Case("amdil", amdil)
 .Case("amdil64", amdil64)
 .Case("hsail", hsail)
@@ -448,8 +441,6 @@
 .Case("xcore", Triple::xcore)
 .Case("nvptx", Triple::nvptx)
 .Case("nvptx64", Triple::nvptx64)