Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-17 Thread Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278949: [Include-fixer] Install executables and support 
scripts (authored by eugenezelenko).

Changed prior to commit:
  https://reviews.llvm.org/D23045?vs=66414=68384#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D23045

Files:
  clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/CMakeLists.txt
  clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt

Index: clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt
===
--- clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt
+++ clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt
@@ -1,6 +1,9 @@
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
 
-add_clang_executable(clang-include-fixer ClangIncludeFixer.cpp)
+add_clang_executable(clang-include-fixer
+  ClangIncludeFixer.cpp
+  )
+
 target_link_libraries(clang-include-fixer
   clangBasic
   clangFormat
@@ -11,3 +14,13 @@
   clangToolingCore
   findAllSymbols
   )
+
+install(TARGETS clang-include-fixer
+  RUNTIME DESTINATION bin)
+
+install(PROGRAMS clang-include-fixer.el
+  DESTINATION share/clang
+  COMPONENT clang-include-fixer)
+install(PROGRAMS clang-include-fixer.py
+  DESTINATION share/clang
+  COMPONENT clang-include-fixer)
Index: 
clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/CMakeLists.txt
===
--- clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/CMakeLists.txt
+++ clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/CMakeLists.txt
@@ -1,13 +1,22 @@
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
 
-add_clang_executable(find-all-symbols FindAllSymbolsMain.cpp)
-target_link_libraries(find-all-symbols
+add_clang_executable(find-all-symbols
+  FindAllSymbolsMain.cpp
+  )
 
+target_link_libraries(find-all-symbols
   clangAST
   clangASTMatchers
   clangBasic
   clangFrontend
   clangLex
   clangTooling
   findAllSymbols
   )
+
+install(TARGETS find-all-symbols
+  RUNTIME DESTINATION bin)
+
+install(PROGRAMS run-find-all-symbols.py
+  DESTINATION share/clang
+  COMPONENT find-all-symbols)


Index: clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt
===
--- clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt
+++ clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt
@@ -1,6 +1,9 @@
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
 
-add_clang_executable(clang-include-fixer ClangIncludeFixer.cpp)
+add_clang_executable(clang-include-fixer
+  ClangIncludeFixer.cpp
+  )
+
 target_link_libraries(clang-include-fixer
   clangBasic
   clangFormat
@@ -11,3 +14,13 @@
   clangToolingCore
   findAllSymbols
   )
+
+install(TARGETS clang-include-fixer
+  RUNTIME DESTINATION bin)
+
+install(PROGRAMS clang-include-fixer.el
+  DESTINATION share/clang
+  COMPONENT clang-include-fixer)
+install(PROGRAMS clang-include-fixer.py
+  DESTINATION share/clang
+  COMPONENT clang-include-fixer)
Index: clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/CMakeLists.txt
===
--- clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/CMakeLists.txt
+++ clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/CMakeLists.txt
@@ -1,13 +1,22 @@
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
 
-add_clang_executable(find-all-symbols FindAllSymbolsMain.cpp)
-target_link_libraries(find-all-symbols
+add_clang_executable(find-all-symbols
+  FindAllSymbolsMain.cpp
+  )
 
+target_link_libraries(find-all-symbols
   clangAST
   clangASTMatchers
   clangBasic
   clangFrontend
   clangLex
   clangTooling
   findAllSymbols
   )
+
+install(TARGETS find-all-symbols
+  RUNTIME DESTINATION bin)
+
+install(PROGRAMS run-find-all-symbols.py
+  DESTINATION share/clang
+  COMPONENT find-all-symbols)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-17 Thread Haojian Wu via cfe-commits 
hokein added a comment.

Sorry for the delay. I totally missed it.



Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22
@@ +21,2 @@
+  DESTINATION share/clang
+  COMPONENT find-all-symbols)

Eugene.Zelenko wrote:
> hokein wrote:
> > I think we can put it in `clang-include-fixer` as find-all-symbols is a 
> > sub-tool of include-fixer.
> In other make files executable name and COMPONENT for scripts are same. 
> Should I add COMPONENT to find-all-symbols executable too?
My previous comment is just my personal preference, not a strong opinion. The 
patch is good enough now, feel free to submit it.

Keeping the `find-all-symbols` executable binary in `RUNTIME DESTINATION bin` 
is fine.


Repository:
  rL LLVM

https://reviews.llvm.org/D23045



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-12 Thread Eugene Zelenko via cfe-commits 
Eugene.Zelenko added a comment.

Ping. I could not proceed until my question answered.


Repository:
  rL LLVM

https://reviews.llvm.org/D23045



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-02 Thread Eugene Zelenko via cfe-commits 
Eugene.Zelenko added inline comments.


Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22
@@ +21,2 @@
+  DESTINATION share/clang
+  COMPONENT find-all-symbols)

hokein wrote:
> I think we can put it in `clang-include-fixer` as find-all-symbols is a 
> sub-tool of include-fixer.
In other make files executable name and COMPONENT for scripts are same. Should 
I add COMPONENT to find-all-symbols executable too?


Repository:
  rL LLVM

https://reviews.llvm.org/D23045



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-02 Thread Haojian Wu via cfe-commits 
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22
@@ +21,2 @@
+  DESTINATION share/clang
+  COMPONENT find-all-symbols)

I think we can put it in `clang-include-fixer` as find-all-symbols is a 
sub-tool of include-fixer.


Repository:
  rL LLVM

https://reviews.llvm.org/D23045



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23045: [Include-fixer] Install executables and support scripts

2016-08-01 Thread Eugene Zelenko via cfe-commits 
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: ioeric, bkramer, hokein.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.

I tested this changes on my RHEL 6 build.

Repository:
  rL LLVM

https://reviews.llvm.org/D23045

Files:
  include-fixer/find-all-symbols/tool/CMakeLists.txt
  include-fixer/tool/CMakeLists.txt

Index: include-fixer/tool/CMakeLists.txt
===
--- include-fixer/tool/CMakeLists.txt
+++ include-fixer/tool/CMakeLists.txt
@@ -1,6 +1,9 @@
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
 
-add_clang_executable(clang-include-fixer ClangIncludeFixer.cpp)
+add_clang_executable(clang-include-fixer
+  ClangIncludeFixer.cpp
+  )
+
 target_link_libraries(clang-include-fixer
   clangBasic
   clangFormat
@@ -11,3 +14,13 @@
   clangToolingCore
   findAllSymbols
   )
+
+install(TARGETS clang-include-fixer
+  RUNTIME DESTINATION bin)
+
+install(PROGRAMS clang-include-fixer.el
+  DESTINATION share/clang
+  COMPONENT clang-include-fixer)
+install(PROGRAMS clang-include-fixer.py
+  DESTINATION share/clang
+  COMPONENT clang-include-fixer)
Index: include-fixer/find-all-symbols/tool/CMakeLists.txt
===
--- include-fixer/find-all-symbols/tool/CMakeLists.txt
+++ include-fixer/find-all-symbols/tool/CMakeLists.txt
@@ -1,8 +1,10 @@
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
 
-add_clang_executable(find-all-symbols FindAllSymbolsMain.cpp)
+add_clang_executable(find-all-symbols
+  FindAllSymbolsMain.cpp
+  )
+
 target_link_libraries(find-all-symbols
-
   clangAST
   clangASTMatchers
   clangBasic
@@ -11,3 +13,10 @@
   clangTooling
   findAllSymbols
   )
+
+install(TARGETS find-all-symbols
+  RUNTIME DESTINATION bin)
+
+install(PROGRAMS run-find-all-symbols.py
+  DESTINATION share/clang
+  COMPONENT find-all-symbols)


Index: include-fixer/tool/CMakeLists.txt
===
--- include-fixer/tool/CMakeLists.txt
+++ include-fixer/tool/CMakeLists.txt
@@ -1,6 +1,9 @@
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
 
-add_clang_executable(clang-include-fixer ClangIncludeFixer.cpp)
+add_clang_executable(clang-include-fixer
+  ClangIncludeFixer.cpp
+  )
+
 target_link_libraries(clang-include-fixer
   clangBasic
   clangFormat
@@ -11,3 +14,13 @@
   clangToolingCore
   findAllSymbols
   )
+
+install(TARGETS clang-include-fixer
+  RUNTIME DESTINATION bin)
+
+install(PROGRAMS clang-include-fixer.el
+  DESTINATION share/clang
+  COMPONENT clang-include-fixer)
+install(PROGRAMS clang-include-fixer.py
+  DESTINATION share/clang
+  COMPONENT clang-include-fixer)
Index: include-fixer/find-all-symbols/tool/CMakeLists.txt
===
--- include-fixer/find-all-symbols/tool/CMakeLists.txt
+++ include-fixer/find-all-symbols/tool/CMakeLists.txt
@@ -1,8 +1,10 @@
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/..)
 
-add_clang_executable(find-all-symbols FindAllSymbolsMain.cpp)
+add_clang_executable(find-all-symbols
+  FindAllSymbolsMain.cpp
+  )
+
 target_link_libraries(find-all-symbols
-
   clangAST
   clangASTMatchers
   clangBasic
@@ -11,3 +13,10 @@
   clangTooling
   findAllSymbols
   )
+
+install(TARGETS find-all-symbols
+  RUNTIME DESTINATION bin)
+
+install(PROGRAMS run-find-all-symbols.py
+  DESTINATION share/clang
+  COMPONENT find-all-symbols)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits