[clang] [clang-format] Don't sort qualifiers across preprocessor directives (PR #81958)

[Owen Pan via cfe-commits]

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/81958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't sort qualifiers across preprocessor directives (PR #81958)

[Owen Pan via cfe-commits]

owenca wrote:

> LGTM, as long as someone doesn't say it should be
> 
> ```c++
> #if FOO
>constexpr
> #endif
>inline
>int i = 0;
> ```
> 
> but I think this change is fine..I would rather we didn't try and support 
> that.. thank you.

Yep! Otherwise, you would have to handle the following, given that the order is 
`[const, inline, constexpr, type]`:
```c++
inline
#if FOO
constexpr /* foo */
#else
const /* bar */
#endif
int i = 0;
```

https://github.com/llvm/llvm-project/pull/81958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't sort qualifiers across preprocessor directives (PR #81958)

[via cfe-commits]

https://github.com/mydeveloperday approved this pull request.

LGTM, as long as someone doesn't say it should be

```c++
#if FOO
   constexpr
#endif
   inline
   int i = 0;
```

but I think this change is fine..I would rather we didn't try and support 
that.. thank you.

https://github.com/llvm/llvm-project/pull/81958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't sort qualifiers across preprocessor directives (PR #81958)

[via cfe-commits]

llvmbot wrote:




@llvm/pr-subscribers-clang-format

Author: Owen Pan (owenca)


Changes

Fixes #80579.

---
Full diff: https://github.com/llvm/llvm-project/pull/81958.diff


2 Files Affected:

- (modified) clang/lib/Format/QualifierAlignmentFixer.cpp (+2) 
- (modified) clang/unittests/Format/QualifierFixerTest.cpp (+13) 


``diff
diff --git a/clang/lib/Format/QualifierAlignmentFixer.cpp 
b/clang/lib/Format/QualifierAlignmentFixer.cpp
index 84941746f0df71..0c63d330b5aed4 100644
--- a/clang/lib/Format/QualifierAlignmentFixer.cpp
+++ b/clang/lib/Format/QualifierAlignmentFixer.cpp
@@ -561,6 +561,8 @@ void 
LeftRightQualifierAlignmentFixer::fixQualifierAlignment(
 
 for (const auto *Tok = First; Tok && Tok != Last && Tok->Next;
  Tok = Tok->Next) {
+  if (Tok->MustBreakBefore)
+break;
   if (Tok->is(tok::comment))
 continue;
   if (RightAlign) {
diff --git a/clang/unittests/Format/QualifierFixerTest.cpp 
b/clang/unittests/Format/QualifierFixerTest.cpp
index 0aa755acfc8213..43476aea66337b 100644
--- a/clang/unittests/Format/QualifierFixerTest.cpp
+++ b/clang/unittests/Format/QualifierFixerTest.cpp
@@ -1177,6 +1177,19 @@ TEST_F(QualifierFixerTest, 
DontPushQualifierThroughNonSpecifiedTypes) {
   verifyFormat("const inline static Foo;", Style);
 }
 
+TEST_F(QualifierFixerTest, QualifiersBrokenUpByPPDirectives) {
+  auto Style = getLLVMStyle();
+  Style.QualifierAlignment = FormatStyle::QAS_Custom;
+  Style.QualifierOrder = {"constexpr", "inline", "type"};
+
+  verifyFormat("inline\n"
+   "#if FOO\n"
+   "constexpr\n"
+   "#endif\n"
+   "int i = 0;",
+   Style);
+}
+
 TEST_F(QualifierFixerTest, UnsignedQualifier) {
 
   FormatStyle Style = getLLVMStyle();

``




https://github.com/llvm/llvm-project/pull/81958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't sort qualifiers across preprocessor directives (PR #81958)

[Owen Pan via cfe-commits]

https://github.com/owenca created 
https://github.com/llvm/llvm-project/pull/81958

Fixes #80579.

>From 13614f5760a26ba6134abdd555176a1aa2ed3974 Mon Sep 17 00:00:00 2001
From: Owen Pan 
Date: Thu, 15 Feb 2024 17:37:44 -0800
Subject: [PATCH] [clang-format] Don't sort qualifiers across preprocessor
 directives

Fixes #80579.
---
 clang/lib/Format/QualifierAlignmentFixer.cpp  |  2 ++
 clang/unittests/Format/QualifierFixerTest.cpp | 13 +
 2 files changed, 15 insertions(+)

diff --git a/clang/lib/Format/QualifierAlignmentFixer.cpp 
b/clang/lib/Format/QualifierAlignmentFixer.cpp
index 84941746f0df71..0c63d330b5aed4 100644
--- a/clang/lib/Format/QualifierAlignmentFixer.cpp
+++ b/clang/lib/Format/QualifierAlignmentFixer.cpp
@@ -561,6 +561,8 @@ void 
LeftRightQualifierAlignmentFixer::fixQualifierAlignment(
 
 for (const auto *Tok = First; Tok && Tok != Last && Tok->Next;
  Tok = Tok->Next) {
+  if (Tok->MustBreakBefore)
+break;
   if (Tok->is(tok::comment))
 continue;
   if (RightAlign) {
diff --git a/clang/unittests/Format/QualifierFixerTest.cpp 
b/clang/unittests/Format/QualifierFixerTest.cpp
index 0aa755acfc8213..43476aea66337b 100644
--- a/clang/unittests/Format/QualifierFixerTest.cpp
+++ b/clang/unittests/Format/QualifierFixerTest.cpp
@@ -1177,6 +1177,19 @@ TEST_F(QualifierFixerTest, 
DontPushQualifierThroughNonSpecifiedTypes) {
   verifyFormat("const inline static Foo;", Style);
 }
 
+TEST_F(QualifierFixerTest, QualifiersBrokenUpByPPDirectives) {
+  auto Style = getLLVMStyle();
+  Style.QualifierAlignment = FormatStyle::QAS_Custom;
+  Style.QualifierOrder = {"constexpr", "inline", "type"};
+
+  verifyFormat("inline\n"
+   "#if FOO\n"
+   "constexpr\n"
+   "#endif\n"
+   "int i = 0;",
+   Style);
+}
+
 TEST_F(QualifierFixerTest, UnsignedQualifier) {
 
   FormatStyle Style = getLLVMStyle();

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits