Author: alexfh
Date: Fri Nov 24 01:52:05 2017
New Revision: 318941

URL: http://llvm.org/viewvc/llvm-project?rev=318941&view=rev
Log:
[clang-tidy] rename_check.py misc-dangling-handle bugprone-dangling-handle

Reviewers: hokein

Reviewed By: hokein

Subscribers: mgorny, xazax.hun, cfe-commits

Differential Revision: https://reviews.llvm.org/D40389

Added:
    clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.cpp
      - copied, changed from r318926, 
clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp
    clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.h
      - copied, changed from r318926, 
clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.h
    clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-dangling-handle.rst
      - copied, changed from r318926, 
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-dangling-handle.rst
    clang-tools-extra/trunk/test/clang-tidy/bugprone-dangling-handle.cpp
      - copied, changed from r318926, 
clang-tools-extra/trunk/test/clang-tidy/misc-dangling-handle.cpp
Removed:
    clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp
    clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.h
    clang-tools-extra/trunk/docs/clang-tidy/checks/misc-dangling-handle.rst
    clang-tools-extra/trunk/test/clang-tidy/misc-dangling-handle.cpp
Modified:
    clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp
    clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt
    clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt
    clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp
    clang-tools-extra/trunk/docs/ReleaseNotes.rst
    clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst

Modified: clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp?rev=318941&r1=318940&r2=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp 
(original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/BugproneTidyModule.cpp Fri Nov 
24 01:52:05 2017
@@ -12,6 +12,7 @@
 #include "../ClangTidyModuleRegistry.h"
 #include "ArgumentCommentCheck.h"
 #include "CopyConstructorInitCheck.h"
+#include "DanglingHandleCheck.h"
 #include "IntegerDivisionCheck.h"
 #include "MisplacedOperatorInStrlenInAllocCheck.h"
 #include "StringConstructorCheck.h"
@@ -29,6 +30,8 @@ public:
         "bugprone-argument-comment");
     CheckFactories.registerCheck<CopyConstructorInitCheck>(
         "bugprone-copy-constructor-init");
+    CheckFactories.registerCheck<DanglingHandleCheck>(
+        "bugprone-dangling-handle");
     CheckFactories.registerCheck<IntegerDivisionCheck>(
         "bugprone-integer-division");
     CheckFactories.registerCheck<MisplacedOperatorInStrlenInAllocCheck>(

Modified: clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt?rev=318941&r1=318940&r2=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt (original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/CMakeLists.txt Fri Nov 24 
01:52:05 2017
@@ -4,6 +4,7 @@ add_clang_library(clangTidyBugproneModul
   ArgumentCommentCheck.cpp
   BugproneTidyModule.cpp
   CopyConstructorInitCheck.cpp
+  DanglingHandleCheck.cpp
   IntegerDivisionCheck.cpp
   MisplacedOperatorInStrlenInAllocCheck.cpp
   StringConstructorCheck.cpp

Copied: clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.cpp 
(from r318926, clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp)
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.cpp?p2=clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.cpp&p1=clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp&r1=318926&r2=318941&rev=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.cpp Fri Nov 
24 01:52:05 2017
@@ -18,7 +18,7 @@ using namespace clang::tidy::matchers;
 
 namespace clang {
 namespace tidy {
-namespace misc {
+namespace bugprone {
 
 namespace {
 
@@ -179,6 +179,6 @@ void DanglingHandleCheck::check(const Ma
       << Handle->getQualifiedNameAsString();
 }
 
-} // namespace misc
+} // namespace bugprone
 } // namespace tidy
 } // namespace clang

Copied: clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.h (from 
r318926, clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.h)
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.h?p2=clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.h&p1=clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.h&r1=318926&r2=318941&rev=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.h (original)
+++ clang-tools-extra/trunk/clang-tidy/bugprone/DanglingHandleCheck.h Fri Nov 
24 01:52:05 2017
@@ -7,20 +7,20 @@
 //
 
//===----------------------------------------------------------------------===//
 
-#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_DANGLING_HANDLE_H
-#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_DANGLING_HANDLE_H
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_DANGLING_HANDLE_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_DANGLING_HANDLE_H
 
 #include "../ClangTidy.h"
 
 namespace clang {
 namespace tidy {
-namespace misc {
+namespace bugprone {
 
 /// Detect dangling references in value handlers like
 /// std::experimental::string_view.
 ///
 /// For the user-facing documentation see:
-/// http://clang.llvm.org/extra/clang-tidy/checks/misc-dangling-handle.html
+/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-dangling-handle.html
 class DanglingHandleCheck : public ClangTidyCheck {
 public:
   DanglingHandleCheck(StringRef Name, ClangTidyContext *Context);
@@ -36,8 +36,8 @@ private:
   const ast_matchers::internal::Matcher<RecordDecl> IsAHandle;
 };
 
-} // namespace misc
+} // namespace bugprone
 } // namespace tidy
 } // namespace clang
 
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_DANGLING_HANDLE_H
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_DANGLING_HANDLE_H

Modified: clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt?rev=318941&r1=318940&r2=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/CMakeLists.txt Fri Nov 24 01:52:05 
2017
@@ -7,7 +7,6 @@ add_clang_library(clangTidyMiscModule
   MisplacedConstCheck.cpp
   UnconventionalAssignOperatorCheck.cpp
   BoolPointerImplicitConversionCheck.cpp
-  DanglingHandleCheck.cpp
   DefinitionsInHeadersCheck.cpp
   FoldInitTypeCheck.cpp
   ForwardDeclarationNamespaceCheck.cpp

Removed: clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp?rev=318940&view=auto
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.cpp (removed)
@@ -1,184 +0,0 @@
-//===--- DanglingHandleCheck.cpp - 
clang-tidy------------------------------===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include "DanglingHandleCheck.h"
-#include "../utils/Matchers.h"
-#include "../utils/OptionsUtils.h"
-#include "clang/AST/ASTContext.h"
-#include "clang/ASTMatchers/ASTMatchFinder.h"
-
-using namespace clang::ast_matchers;
-using namespace clang::tidy::matchers;
-
-namespace clang {
-namespace tidy {
-namespace misc {
-
-namespace {
-
-ast_matchers::internal::BindableMatcher<Stmt>
-handleFrom(const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle,
-           const ast_matchers::internal::Matcher<Expr> &Arg) {
-  return cxxConstructExpr(hasDeclaration(cxxMethodDecl(ofClass(IsAHandle))),
-                          hasArgument(0, Arg));
-}
-
-ast_matchers::internal::Matcher<Stmt> handleFromTemporaryValue(
-    const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
-  // If a ternary operator returns a temporary value, then both branches hold a
-  // temporary value. If one of them is not a temporary then it must be copied
-  // into one to satisfy the type of the operator.
-  const auto TemporaryTernary =
-      conditionalOperator(hasTrueExpression(cxxBindTemporaryExpr()),
-                          hasFalseExpression(cxxBindTemporaryExpr()));
-
-  return handleFrom(IsAHandle, anyOf(cxxBindTemporaryExpr(), 
TemporaryTernary));
-}
-
-ast_matchers::internal::Matcher<RecordDecl> isASequence() {
-  return hasAnyName("::std::deque", "::std::forward_list", "::std::list",
-                    "::std::vector");
-}
-
-ast_matchers::internal::Matcher<RecordDecl> isASet() {
-  return hasAnyName("::std::set", "::std::multiset", "::std::unordered_set",
-                    "::std::unordered_multiset");
-}
-
-ast_matchers::internal::Matcher<RecordDecl> isAMap() {
-  return hasAnyName("::std::map", "::std::multimap", "::std::unordered_map",
-                    "::std::unordered_multimap");
-}
-
-ast_matchers::internal::BindableMatcher<Stmt> makeContainerMatcher(
-    const ast_matchers::internal::Matcher<RecordDecl> &IsAHandle) {
-  // This matcher could be expanded to detect:
-  //  - Constructors: eg. vector<string_view>(3, string("A"));
-  //  - emplace*(): This requires a different logic to determine that
-  //                the conversion will happen inside the container.
-  //  - map's insert: This requires detecting that the pair conversion triggers
-  //                  the bug. A little more complicated than what we have now.
-  return callExpr(
-      hasAnyArgument(
-          ignoringParenImpCasts(handleFromTemporaryValue(IsAHandle))),
-      anyOf(
-          // For sequences: assign, push_back, resize.
-          cxxMemberCallExpr(
-              callee(functionDecl(hasAnyName("assign", "push_back", 
"resize"))),
-              on(expr(hasType(hasUnqualifiedDesugaredType(
-                  recordType(hasDeclaration(recordDecl(isASequence())))))))),
-          // For sequences and sets: insert.
-          cxxMemberCallExpr(callee(functionDecl(hasName("insert"))),
-                            on(expr(hasType(hasUnqualifiedDesugaredType(
-                                recordType(hasDeclaration(recordDecl(
-                                    anyOf(isASequence(), isASet()))))))))),
-          // For maps: operator[].
-          cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(isAMap()))),
-                              hasOverloadedOperatorName("[]"))));
-}
-
-} // anonymous namespace
-
-DanglingHandleCheck::DanglingHandleCheck(StringRef Name,
-                                         ClangTidyContext *Context)
-    : ClangTidyCheck(Name, Context),
-      HandleClasses(utils::options::parseStringList(Options.get(
-          "HandleClasses",
-          "std::basic_string_view;std::experimental::basic_string_view"))),
-      IsAHandle(cxxRecordDecl(hasAnyName(std::vector<StringRef>(
-                                  HandleClasses.begin(), HandleClasses.end())))
-                    .bind("handle")) {}
-
-void DanglingHandleCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
-  Options.store(Opts, "HandleClasses",
-                utils::options::serializeStringList(HandleClasses));
-}
-
-void DanglingHandleCheck::registerMatchersForVariables(MatchFinder *Finder) {
-  const auto ConvertedHandle = handleFromTemporaryValue(IsAHandle);
-
-  // Find 'Handle foo(ReturnsAValue());'
-  Finder->addMatcher(
-      varDecl(hasType(hasUnqualifiedDesugaredType(
-                  recordType(hasDeclaration(cxxRecordDecl(IsAHandle))))),
-              hasInitializer(
-                  exprWithCleanups(has(ignoringParenImpCasts(ConvertedHandle)))
-                      .bind("bad_stmt"))),
-      this);
-
-  // Find 'Handle foo = ReturnsAValue();'
-  Finder->addMatcher(
-      varDecl(
-          hasType(hasUnqualifiedDesugaredType(
-              recordType(hasDeclaration(cxxRecordDecl(IsAHandle))))),
-          unless(parmVarDecl()),
-          hasInitializer(exprWithCleanups(has(ignoringParenImpCasts(handleFrom(
-                                              IsAHandle, ConvertedHandle))))
-                             .bind("bad_stmt"))),
-      this);
-  // Find 'foo = ReturnsAValue();  // foo is Handle'
-  Finder->addMatcher(
-      cxxOperatorCallExpr(callee(cxxMethodDecl(ofClass(IsAHandle))),
-                          hasOverloadedOperatorName("="),
-                          hasArgument(1, ConvertedHandle))
-          .bind("bad_stmt"),
-      this);
-
-  // Container insertions that will dangle.
-  Finder->addMatcher(makeContainerMatcher(IsAHandle).bind("bad_stmt"), this);
-}
-
-void DanglingHandleCheck::registerMatchersForReturn(MatchFinder *Finder) {
-  // Return a local.
-  Finder->addMatcher(
-      returnStmt(
-          // The AST contains two constructor calls:
-          //   1. Value to Handle conversion.
-          //   2. Handle copy construction.
-          // We have to match both.
-          has(ignoringImplicit(handleFrom(
-              IsAHandle,
-              handleFrom(IsAHandle,
-                         declRefExpr(to(varDecl(
-                             // Is function scope ...
-                             hasAutomaticStorageDuration(),
-                             // ... and it is a local array or Value.
-                             anyOf(hasType(arrayType()),
-                                   hasType(hasUnqualifiedDesugaredType(
-                                       recordType(hasDeclaration(recordDecl(
-                                           unless(IsAHandle)))))))))))))),
-          // Temporary fix for false positives inside lambdas.
-          unless(hasAncestor(lambdaExpr())))
-          .bind("bad_stmt"),
-      this);
-
-  // Return a temporary.
-  Finder->addMatcher(
-      returnStmt(
-          has(ignoringParenImpCasts(exprWithCleanups(has(ignoringParenImpCasts(
-              handleFrom(IsAHandle, handleFromTemporaryValue(IsAHandle))))))))
-          .bind("bad_stmt"),
-      this);
-}
-
-void DanglingHandleCheck::registerMatchers(MatchFinder *Finder) {
-  registerMatchersForVariables(Finder);
-  registerMatchersForReturn(Finder);
-}
-
-void DanglingHandleCheck::check(const MatchFinder::MatchResult &Result) {
-  auto *Handle = Result.Nodes.getNodeAs<CXXRecordDecl>("handle");
-  diag(Result.Nodes.getNodeAs<Stmt>("bad_stmt")->getLocStart(),
-       "%0 outlives its value")
-      << Handle->getQualifiedNameAsString();
-}
-
-} // namespace misc
-} // namespace tidy
-} // namespace clang

Removed: clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.h
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.h?rev=318940&view=auto
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.h (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/DanglingHandleCheck.h (removed)
@@ -1,43 +0,0 @@
-//===--- DanglingHandleCheck.h - clang-tidy----------------------*- C++ 
-*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_DANGLING_HANDLE_H
-#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_DANGLING_HANDLE_H
-
-#include "../ClangTidy.h"
-
-namespace clang {
-namespace tidy {
-namespace misc {
-
-/// Detect dangling references in value handlers like
-/// std::experimental::string_view.
-///
-/// For the user-facing documentation see:
-/// http://clang.llvm.org/extra/clang-tidy/checks/misc-dangling-handle.html
-class DanglingHandleCheck : public ClangTidyCheck {
-public:
-  DanglingHandleCheck(StringRef Name, ClangTidyContext *Context);
-  void registerMatchers(ast_matchers::MatchFinder *Finder) override;
-  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
-  void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
-
-private:
-  void registerMatchersForVariables(ast_matchers::MatchFinder *Finder);
-  void registerMatchersForReturn(ast_matchers::MatchFinder *Finder);
-
-  const std::vector<std::string> HandleClasses;
-  const ast_matchers::internal::Matcher<RecordDecl> IsAHandle;
-};
-
-} // namespace misc
-} // namespace tidy
-} // namespace clang
-
-#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_DANGLING_HANDLE_H

Modified: clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp?rev=318941&r1=318940&r2=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/MiscTidyModule.cpp Fri Nov 24 
01:52:05 2017
@@ -12,7 +12,6 @@
 #include "../ClangTidyModuleRegistry.h"
 #include "AssertSideEffectCheck.h"
 #include "BoolPointerImplicitConversionCheck.h"
-#include "DanglingHandleCheck.h"
 #include "DefinitionsInHeadersCheck.h"
 #include "FoldInitTypeCheck.h"
 #include "ForwardDeclarationNamespaceCheck.h"
@@ -73,7 +72,6 @@ public:
         "misc-unconventional-assign-operator");
     CheckFactories.registerCheck<BoolPointerImplicitConversionCheck>(
         "misc-bool-pointer-implicit-conversion");
-    CheckFactories.registerCheck<DanglingHandleCheck>("misc-dangling-handle");
     CheckFactories.registerCheck<DefinitionsInHeadersCheck>(
         "misc-definitions-in-headers");
     CheckFactories.registerCheck<FoldInitTypeCheck>("misc-fold-init-type");

Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/ReleaseNotes.rst?rev=318941&r1=318940&r2=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/docs/ReleaseNotes.rst (original)
+++ clang-tools-extra/trunk/docs/ReleaseNotes.rst Fri Nov 24 01:52:05 2017
@@ -57,6 +57,9 @@ The improvements are...
 Improvements to clang-tidy
 --------------------------
 
+- The 'misc-dangling-handle' check was renamed to `bugprone-dangling-handle
+  
<http://clang.llvm.org/extra/clang-tidy/checks/bugprone-dangling-handle.html>`_
+
 - The 'misc-argument-comment' check was renamed to `bugprone-argument-comment
   
<http://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html>`_
 

Copied: 
clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-dangling-handle.rst 
(from r318926, 
clang-tools-extra/trunk/docs/clang-tidy/checks/misc-dangling-handle.rst)
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-dangling-handle.rst?p2=clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-dangling-handle.rst&p1=clang-tools-extra/trunk/docs/clang-tidy/checks/misc-dangling-handle.rst&r1=318926&r2=318941&rev=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/docs/clang-tidy/checks/misc-dangling-handle.rst 
(original)
+++ clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-dangling-handle.rst 
Fri Nov 24 01:52:05 2017
@@ -1,7 +1,7 @@
-.. title:: clang-tidy - misc-dangling-handle
+.. title:: clang-tidy - bugprone-dangling-handle
 
-misc-dangling-handle
-====================
+bugprone-dangling-handle
+========================
 
 Detect dangling references in value handles like
 ``std::experimental::string_view``.

Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst?rev=318941&r1=318940&r2=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst (original)
+++ clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Fri Nov 24 01:52:05 
2017
@@ -19,6 +19,7 @@ Clang-Tidy Checks
    boost-use-to-string
    bugprone-argument-comment
    bugprone-copy-constructor-init
+   bugprone-dangling-handle
    bugprone-integer-division
    bugprone-misplaced-operator-in-strlen-in-alloc
    bugprone-string-constructor
@@ -108,7 +109,6 @@ Clang-Tidy Checks
    llvm-twine-local
    misc-assert-side-effect
    misc-bool-pointer-implicit-conversion
-   misc-dangling-handle
    misc-definitions-in-headers
    misc-fold-init-type
    misc-forward-declaration-namespace

Removed: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-dangling-handle.rst
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-dangling-handle.rst?rev=318940&view=auto
==============================================================================
--- clang-tools-extra/trunk/docs/clang-tidy/checks/misc-dangling-handle.rst 
(original)
+++ clang-tools-extra/trunk/docs/clang-tidy/checks/misc-dangling-handle.rst 
(removed)
@@ -1,38 +0,0 @@
-.. title:: clang-tidy - misc-dangling-handle
-
-misc-dangling-handle
-====================
-
-Detect dangling references in value handles like
-``std::experimental::string_view``.
-These dangling references can be a result of constructing handles from 
temporary
-values, where the temporary is destroyed soon after the handle is created.
-
-Examples:
-
-.. code-block:: c++
-
-  string_view View = string();  // View will dangle.
-  string A;
-  View = A + "A";  // still dangle.
-
-  vector<string_view> V;
-  V.push_back(string());  // V[0] is dangling.
-  V.resize(3, string());  // V[1] and V[2] will also dangle.
-
-  string_view f() {
-    // All these return values will dangle.
-    return string();
-    string S;
-    return S;
-    char Array[10]{};
-    return Array;
-  }
-
-Options
--------
-
-.. option:: HandleClasses
-
-   A semicolon-separated list of class names that should be treated as handles.
-   By default only ``std::experimental::basic_string_view`` is considered.

Copied: clang-tools-extra/trunk/test/clang-tidy/bugprone-dangling-handle.cpp 
(from r318926, clang-tools-extra/trunk/test/clang-tidy/misc-dangling-handle.cpp)
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/bugprone-dangling-handle.cpp?p2=clang-tools-extra/trunk/test/clang-tidy/bugprone-dangling-handle.cpp&p1=clang-tools-extra/trunk/test/clang-tidy/misc-dangling-handle.cpp&r1=318926&r2=318941&rev=318941&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-dangling-handle.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/bugprone-dangling-handle.cpp Fri 
Nov 24 01:52:05 2017
@@ -1,6 +1,6 @@
-// RUN: %check_clang_tidy %s misc-dangling-handle %t -- \
+// RUN: %check_clang_tidy %s bugprone-dangling-handle %t -- \
 // RUN:   -config="{CheckOptions: \
-// RUN:             [{key: misc-dangling-handle.HandleClasses, \
+// RUN:             [{key: bugprone-dangling-handle.HandleClasses, \
 // RUN:               value: 'std::basic_string_view; ::llvm::StringRef;'}]}" \
 // RUN:   -- -std=c++11
 
@@ -79,7 +79,7 @@ std::string ReturnsAString();
 
 void Positives() {
   std::string_view view1 = std::string();
-  // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives 
its value [misc-dangling-handle]
+  // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives 
its value [bugprone-dangling-handle]
 
   std::string_view view_2 = ReturnsAString();
   // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives

Removed: clang-tools-extra/trunk/test/clang-tidy/misc-dangling-handle.cpp
URL: 
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/misc-dangling-handle.cpp?rev=318940&view=auto
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-dangling-handle.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/misc-dangling-handle.cpp (removed)
@@ -1,191 +0,0 @@
-// RUN: %check_clang_tidy %s misc-dangling-handle %t -- \
-// RUN:   -config="{CheckOptions: \
-// RUN:             [{key: misc-dangling-handle.HandleClasses, \
-// RUN:               value: 'std::basic_string_view; ::llvm::StringRef;'}]}" \
-// RUN:   -- -std=c++11
-
-namespace std {
-
-template <typename T>
-class vector {
- public:
-  using const_iterator = const T*;
-  using iterator = T*;
-  using size_type = int;
-
-  void assign(size_type count, const T& value);
-  iterator insert(const_iterator pos, const T& value);
-  iterator insert(const_iterator pos, T&& value);
-  iterator insert(const_iterator pos, size_type count, const T& value);
-  void push_back(const T&);
-  void push_back(T&&);
-  void resize(size_type count, const T& value);
-};
-
-template <typename, typename>
-class pair {};
-
-template <typename T>
-class set {
- public:
-  using const_iterator = const T*;
-  using iterator = T*;
-
-  std::pair<iterator, bool> insert(const T& value);
-  std::pair<iterator, bool> insert(T&& value);
-  iterator insert(const_iterator hint, const T& value);
-  iterator insert(const_iterator hint, T&& value);
-};
-
-template <typename Key, typename Value>
-class map {
- public:
-  using value_type = pair<Key, Value>;
-  value_type& operator[](const Key& key);
-  value_type& operator[](Key&& key);
-};
-
-class basic_string {
- public:
-  basic_string();
-  basic_string(const char*);
-  ~basic_string();
-};
-
-typedef basic_string string;
-
-class basic_string_view {
- public:
-  basic_string_view(const char*);
-  basic_string_view(const basic_string&);
-};
-
-typedef basic_string_view string_view;
-
-}  // namespace std
-
-namespace llvm {
-
-class StringRef {
- public:
-  StringRef();
-  StringRef(const char*);
-  StringRef(const std::string&);
-};
-
-}  // namespace llvm
-
-std::string ReturnsAString();
-
-void Positives() {
-  std::string_view view1 = std::string();
-  // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives 
its value [misc-dangling-handle]
-
-  std::string_view view_2 = ReturnsAString();
-  // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives
-
-  view1 = std::string();
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-
-  const std::string& str_ref = "";
-  std::string_view view3 = true ? "A" : str_ref;
-  // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives
-  view3 = true ? "A" : str_ref;
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-
-  std::string_view view4(ReturnsAString());
-  // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives
-}
-
-void OtherTypes() {
-  llvm::StringRef ref = std::string();
-  // CHECK-MESSAGES: [[@LINE-1]]:19: warning: llvm::StringRef outlives its 
value
-}
-
-const char static_array[] = "A";
-std::string_view ReturnStatements(int i, std::string value_arg,
-                                  const std::string &ref_arg) {
-  const char array[] = "A";
-  const char* ptr = "A";
-  std::string s;
-  static std::string ss;
-  switch (i) {
-    // Bad cases
-    case 0:
-      return array;  // refers to local
-      // CHECK-MESSAGES: [[@LINE-1]]:7: warning: std::basic_string_view outliv
-    case 1:
-      return s;  // refers to local
-      // CHECK-MESSAGES: [[@LINE-1]]:7: warning: std::basic_string_view outliv
-    case 2:
-      return std::string();  // refers to temporary
-      // CHECK-MESSAGES: [[@LINE-1]]:7: warning: std::basic_string_view outliv
-    case 3:
-      return value_arg;  // refers to by-value arg
-      // CHECK-MESSAGES: [[@LINE-1]]:7: warning: std::basic_string_view outliv
-
-    // Ok cases
-    case 100:
-      return ss;  // refers to static
-    case 101:
-      return static_array;  // refers to static
-    case 102:
-      return ptr;  // pointer is ok
-    case 103:
-      return ref_arg;  // refers to by-ref arg
-  }
-
-  struct S {
-    std::string_view view() { return value; }
-    std::string value;
-  };
-
-  (void)[&]()->std::string_view {
-    // This should not warn. The string is bound by reference.
-    return s;
-  };
-  (void)[=]() -> std::string_view {
-    // This should not warn. The reference is valid as long as the lambda.
-    return s;
-  };
-  (void)[=]() -> std::string_view {
-    // FIXME: This one should warn. We are returning a reference to a local
-    // lambda variable.
-    std::string local;
-    return local;
-  };
-  return "";
-}
-
-void Containers() {
-  std::vector<std::string_view> v;
-  v.assign(3, std::string());
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-  v.insert(nullptr, std::string());
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-  v.insert(nullptr, 3, std::string());
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-  v.push_back(std::string());
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-  v.resize(3, std::string());
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-
-  std::set<std::string_view> s;
-  s.insert(std::string());
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-  s.insert(nullptr, std::string());
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-
-  std::map<std::string_view, int> m;
-  m[std::string()];
-  // CHECK-MESSAGES: [[@LINE-1]]:3: warning: std::basic_string_view outlives
-}
-
-void TakesAStringView(std::string_view);
-
-void Negatives(std::string_view default_arg = ReturnsAString()) {
-  std::string str;
-  std::string_view view = str;
-
-  TakesAStringView(std::string());
-}


_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to