Re: [Chicken-hackers] [PATCH] Add proper list checks to assq/assv/assoc and memq/memv/member
Hey Peter, Peter Bex peter@xs4all.nl writes: Thanks for this one. thanks for reviewing! You somehow missed C_i_memv, though, which resulted in library-tests to fail. So at least the tests are complete :) Hm, that's weird, I was sure I had given it a final run. Anyway, I might be missing something but my patch actually does cover C_i_memv (lines 73-82), doesn't it? AFAICT you added another check to C_u_i_memq, referring to memv in the error message. But isn't the point of C_u_* variants to be unchecked? Note that I made a bootstrap build before running the tests. Maybe that's why the tests didn't fail for me? Thanks again and cheers! Moritz ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Add proper list checks to assq/assv/assoc and memq/memv/member
On Mon, Jan 27, 2014 at 01:06:48PM +0100, Moritz Heidkamp wrote: You somehow missed C_i_memv, though, which resulted in library-tests to fail. So at least the tests are complete :) Hm, that's weird, I was sure I had given it a final run. Anyway, I might be missing something but my patch actually does cover C_i_memv (lines 73-82), doesn't it? AFAICT you added another check to C_u_i_memq, referring to memv in the error message. But isn't the point of C_u_* variants to be unchecked? I don't know, I seem to be losing my mind or something :) Note that I made a bootstrap build before running the tests. Maybe that's why the tests didn't fail for me? I did a full rebuild using the new CHICKEN. The test failed because it did not receive an error so that's unlikely to be due to old code. Cheers, Peter -- http://www.more-magic.net ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Add proper list checks to assq/assv/assoc and memq/memv/member
On Fri, Jan 24, 2014 at 02:56:45PM +0100, Moritz Heidkamp wrote: Fellow Chickeneers, please see the commit message of the attached patch for details! Thanks for this one. You somehow missed C_i_memv, though, which resulted in library-tests to fail. So at least the tests are complete :) I've fixed that small bug and pushed the change. Cheers, Peter -- http://www.more-magic.net ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
