[chromium-dev] Re: How to debug Chrome on MacOS
Looks like you're hitting a DCHECK() in the code, I'm guessing it has to do with a corrupt profile. Try deleting your profile. There's a wiki page with some tips on debugging the OSX version here: http://dev.chromium.org/developers/debugging-on-os-x Best regards, Jeremy On Thu, May 28, 2009 at 10:45 PM, Daniel Dreiberg daniel.dreiber...@gmail.com wrote: Hi, I have get chrome source and I have opened the 'chrome.xcode project'. I am able to compile it successfully. And when I click 'Build and Go (Debug)' I see the status bar said 'GDB: Loading program' and then 'GDB: Running' and all the sudden I see 'GDB: Interrupted' And I never see chrome is launched. Can you please tell me how can I debug Chrome under MacOS? And when i open the Debugger view, I see this stack trace: #0 0x0056b55f in DebugUtil::BreakDebugger at debug_util_posix.cc:116 #1 0x0058c76a in logging::LogMessage::~LogMessage at logging.cc:521 #2 0x004c1866 in VisitedLinkMaster::DebugValidate at visitedlink_master.h:386 #3 0x004bb852 in VisitedLinkMaster::InitFromFile at visitedlink_master.cc:579 #4 0x004bdbdb in VisitedLinkMaster::Init at visitedlink_master.cc:262 #5 0x0036283c in ProfileImpl::GetVisitedLinkMaster at profile.cc:608 #6 0x0037bf8c in BrowserRenderProcessHost::InitVisitedLinks at browser_render_process_host.cc:443 #7 0x0037e4e8 in BrowserRenderProcessHost::Init at browser_render_process_host.cc:366 #8 0x00395028 in RenderViewHost::CreateRenderView at render_view_host.cc:142 #9 0x0049c523 in TabContents::CreateRenderViewForRenderManager at tab_contents.cc:2390 #10 0x00494b10 in RenderViewHostManager::Navigate at render_view_host_manager.cc:84 #11 0x0049f4e9 in TabContents::NavigateToPendingEntry at tab_contents.cc:677 #12 0x00485182 in NavigationController::NavigateToPendingEntry at navigation_controller.cc:871 #13 0x00486016 in NavigationController::LoadEntry at navigation_controller.cc:204 #14 0x00486090 in NavigationController::LoadURL at navigation_controller.cc:382 #15 0x00146309 in Browser::CreateTabContentsForURL at browser.cc:1431 #16 0x0014bcb4 in Browser::AddTabWithURL at browser.cc:526 #17 0x0015be29 in BrowserInit::LaunchWithProfile::OpenURLsInBrowser at browser_init.cc:508 #18 0x0015d23d in BrowserInit::LaunchWithProfile::Launch at browser_init.cc:419 #19 0x0015d7c5 in (anonymous namespace)::LaunchBrowser at browser_init.cc:322 #20 0x0015eddc in BrowserInit::ProcessCmdLineImpl at browser_init.cc:714 #21 0x001682e9 in BrowserInit::Start at browser_init.h:39 #22 0x00165ac6 in BrowserMain at browser_main.cc:724 #23 0x4e86 in ChromeMain at chrome_dll_main.cc:484 #24 0x3413 in main at chrome_exe_main.mm:34 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Two tools for automatically getting a recent build of Chromium
Hey all, If you want to have up-to-date builds of Chromium on multiple VMs for testing, you'll want to automate syncing source, building Chromium from source or downloading the last know good build and symbols from the build server. To do this, I created two scripts build.py and download.py, which I am sharing with you. They are a work in progress but they are stable enough for others to try them and give feedback. Tested with Python 2.6. Let me know if you find this useful, want to request features or if you find any bugs. If there is a demand for this kind of tool, I will consider maintaining up-to-date versions. build.py: The goal of this script is to allow unattended updating of source and building of a clean version of Chromium from source. It should attempt to fix any errors automagically where possible. (I particularly like that last feature and am looking for a way to easily report known issues and fixes) Requirements: Python, Visual Studio 2005 and depot_tools installed on the system. download.py: The goal of this script is to grab the Last Known Good Build binaries and symbols from the build server and unpack them into a folder. (If you already have the LKGB, it does nothing). Requirements: Python installed on the system. Try the '-?' argument on each script for more details. Cheers, BJ Berend-Jan SkyLined Wever (skyli...@google.com) Security Software Engineer Google NL B.V. Reg: C. Debussylaan 34, 15th floor 1082 MD A'dam 34198589 NL VAT / Tax ID:- 812788515 B01 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~--- build.py Description: Binary data download.py Description: Binary data
[chromium-dev] Re: Where is the integration point betwee chromium and V8
My spidey sense would guess that you set the breakpoint in the Browser
process, when V8 and WebKit run in the Renderer process.
Good luck
-- dean
2009/5/29 Lucius Fox lucius.fo...@gmail.com:
Thank you.
I tried your suggestion on XCode on MacOS. But it still does not break for me.
I set a break point at:
LocalScript Script::Compile(v8::HandleString source,
v8::ScriptOrigin* origin,
v8::ScriptData* script_data) {
ON_BAILOUT(v8::Script::Compile(), return LocalScript());
LOG_API(Script::Compile);
ENTER_V8;
i::Handlei::String str = Utils::OpenHandle(*source);
i::Handlei::Object name_obj;
int line_offset = 0;
int column_offset = 0;
/* Set my break point in the line below */
if (origin != NULL) {
Here is how I set my breakpoint:
1. I open the build/all.xcodeproj
2. click open the test_shell.xcodeproj
3. click open the v8.xcodeproject
4. open api.cc
5. set breakpoint in the location I mentioned above
6. go to test_shell.xcodeproj and click 'Build and Go(Debug)'
7. load an url, (e.g. www.yahoo.com)
The site gets loaded, but the break point never breaks.
I appreciate if anyone can help me with this.
Thank you.
2009/5/27 Søren Gjesse sgje...@chromium.org:
Hi,
There must be something wrong with your setting of break points. There is
only on way of getting JavaScript code into V8 from a client application,
and that is through the static method v8::Script::Compile in the public API.
This method is defined in api.cc where it in turn calls
v8::internal:Compiler::Complie defined in compiler.cc. All the adding of
code to V8 from Chromium is handled in v8_proxy.cpp.
Code added from within JavaScript through the use of eval will be handled by
v8::internal:Compiler::ComplieEval.
Note that if you are using Chromium for this you need to take the
multiprocess architecture into account either by using the --single-process
switch to turn it off or by attaching to the process you will actually like
to debug.
Regards,
Søren
On Thu, May 28, 2009 at 07:52, Lucius Fox lucius.fo...@gmail.com wrote:
Hi,
i am trying to understand how chromium passes JS script node/JS file
to v8 engine for execution.
So i setup breakpoints in Xcode with test)shell xcode project opened:
Compiler::Compile
Compiler::CompileEval
Compiler::CompileLazy
And then I 'build and go (debug)' to get a TestShell. It did start up
the TestShell, and it did break in the initial breakpoint I setup in
test_shell_main.cc. But when I load a page with Javascript for sure,
e.g. www.cnn.con, it never breaks in the Compiler functions that I
mentioned above.
Can you please tell me how does chromium passes JS script node/JS file
to v8 engine for execution
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Where is the integration point betwee chromium and V8
I just re-read your post and realized you were using test_shell, which
is single process. In that case, I am not sure what the problem is,
and have no experience with xcode.
Sorry, good luck
On Fri, May 29, 2009 at 11:06 AM, Dean McNameede...@chromium.org wrote:
My spidey sense would guess that you set the breakpoint in the Browser
process, when V8 and WebKit run in the Renderer process.
Good luck
-- dean
2009/5/29 Lucius Fox lucius.fo...@gmail.com:
Thank you.
I tried your suggestion on XCode on MacOS. But it still does not break for
me.
I set a break point at:
LocalScript Script::Compile(v8::HandleString source,
v8::ScriptOrigin* origin,
v8::ScriptData* script_data) {
ON_BAILOUT(v8::Script::Compile(), return LocalScript());
LOG_API(Script::Compile);
ENTER_V8;
i::Handlei::String str = Utils::OpenHandle(*source);
i::Handlei::Object name_obj;
int line_offset = 0;
int column_offset = 0;
/* Set my break point in the line below */
if (origin != NULL) {
Here is how I set my breakpoint:
1. I open the build/all.xcodeproj
2. click open the test_shell.xcodeproj
3. click open the v8.xcodeproject
4. open api.cc
5. set breakpoint in the location I mentioned above
6. go to test_shell.xcodeproj and click 'Build and Go(Debug)'
7. load an url, (e.g. www.yahoo.com)
The site gets loaded, but the break point never breaks.
I appreciate if anyone can help me with this.
Thank you.
2009/5/27 Søren Gjesse sgje...@chromium.org:
Hi,
There must be something wrong with your setting of break points. There is
only on way of getting JavaScript code into V8 from a client application,
and that is through the static method v8::Script::Compile in the public API.
This method is defined in api.cc where it in turn calls
v8::internal:Compiler::Complie defined in compiler.cc. All the adding of
code to V8 from Chromium is handled in v8_proxy.cpp.
Code added from within JavaScript through the use of eval will be handled by
v8::internal:Compiler::ComplieEval.
Note that if you are using Chromium for this you need to take the
multiprocess architecture into account either by using the --single-process
switch to turn it off or by attaching to the process you will actually like
to debug.
Regards,
Søren
On Thu, May 28, 2009 at 07:52, Lucius Fox lucius.fo...@gmail.com wrote:
Hi,
i am trying to understand how chromium passes JS script node/JS file
to v8 engine for execution.
So i setup breakpoints in Xcode with test)shell xcode project opened:
Compiler::Compile
Compiler::CompileEval
Compiler::CompileLazy
And then I 'build and go (debug)' to get a TestShell. It did start up
the TestShell, and it did break in the initial breakpoint I setup in
test_shell_main.cc. But when I load a page with Javascript for sure,
e.g. www.cnn.con, it never breaks in the Compiler functions that I
mentioned above.
Can you please tell me how does chromium passes JS script node/JS file
to v8 engine for execution
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Two tools for automatically getting a recent build of Chromium
Have you seen http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/chrome-update.py?view=markup ? On Fri, May 29, 2009 at 4:37 AM, Berend-Jan Wever skyli...@chromium.orgwrote: Hey all, If you want to have up-to-date builds of Chromium on multiple VMs for testing, you'll want to automate syncing source, building Chromium from source or downloading the last know good build and symbols from the build server. To do this, I created two scripts build.py and download.py, which I am sharing with you. They are a work in progress but they are stable enough for others to try them and give feedback. Tested with Python 2.6. Let me know if you find this useful, want to request features or if you find any bugs. If there is a demand for this kind of tool, I will consider maintaining up-to-date versions. build.py: The goal of this script is to allow unattended updating of source and building of a clean version of Chromium from source. It should attempt to fix any errors automagically where possible. (I particularly like that last feature and am looking for a way to easily report known issues and fixes) Requirements: Python, Visual Studio 2005 and depot_tools installed on the system. download.py: The goal of this script is to grab the Last Known Good Build binaries and symbols from the build server and unpack them into a folder. (If you already have the LKGB, it does nothing). Requirements: Python installed on the system. Try the '-?' argument on each script for more details. Cheers, BJ Berend-Jan SkyLined Wever (skyli...@google.com) Security Software Engineer Google NL B.V. Reg: C. Debussylaan 34, 15th floor 1082 MD A'dam 34198589 NL VAT / Tax ID:- 812788515 B01 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Where is the integration point betwee chromium and V8
Xcode can have problems properly setting breakpoints in subprojects. There
are two ways to work around this:
- Uncheck the Load *symbols lazily option in Xcode's debugging
preferences.*
- Open up the gdb console window and set breakpoints from the gdb command
line
--Amanda
2009/5/29 Lucius Fox lucius.fo...@gmail.com
Thank you.
I tried your suggestion on XCode on MacOS. But it still does not break for
me.
I set a break point at:
LocalScript Script::Compile(v8::HandleString source,
v8::ScriptOrigin* origin,
v8::ScriptData* script_data) {
ON_BAILOUT(v8::Script::Compile(), return LocalScript());
LOG_API(Script::Compile);
ENTER_V8;
i::Handlei::String str = Utils::OpenHandle(*source);
i::Handlei::Object name_obj;
int line_offset = 0;
int column_offset = 0;
/* Set my break point in the line below */
if (origin != NULL) {
Here is how I set my breakpoint:
1. I open the build/all.xcodeproj
2. click open the test_shell.xcodeproj
3. click open the v8.xcodeproject
4. open api.cc
5. set breakpoint in the location I mentioned above
6. go to test_shell.xcodeproj and click 'Build and Go(Debug)'
7. load an url, (e.g. www.yahoo.com)
The site gets loaded, but the break point never breaks.
I appreciate if anyone can help me with this.
Thank you.
2009/5/27 Søren Gjesse sgje...@chromium.org:
Hi,
There must be something wrong with your setting of break points. There is
only on way of getting JavaScript code into V8 from a client application,
and that is through the static method v8::Script::Compile in the public
API.
This method is defined in api.cc where it in turn calls
v8::internal:Compiler::Complie defined in compiler.cc. All the adding of
code to V8 from Chromium is handled in v8_proxy.cpp.
Code added from within JavaScript through the use of eval will be handled
by
v8::internal:Compiler::ComplieEval.
Note that if you are using Chromium for this you need to take the
multiprocess architecture into account either by using the
--single-process
switch to turn it off or by attaching to the process you will actually
like
to debug.
Regards,
Søren
On Thu, May 28, 2009 at 07:52, Lucius Fox lucius.fo...@gmail.com
wrote:
Hi,
i am trying to understand how chromium passes JS script node/JS file
to v8 engine for execution.
So i setup breakpoints in Xcode with test)shell xcode project opened:
Compiler::Compile
Compiler::CompileEval
Compiler::CompileLazy
And then I 'build and go (debug)' to get a TestShell. It did start up
the TestShell, and it did break in the initial breakpoint I setup in
test_shell_main.cc. But when I load a page with Javascript for sure,
e.g. www.cnn.con, it never breaks in the Compiler functions that I
mentioned above.
Can you please tell me how does chromium passes JS script node/JS file
to v8 engine for execution
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: reminder: don't use CHECK()
On Thu, May 28, 2009 at 6:55 PM, Evan Stade est...@chromium.org wrote: I was hitting a CHECK() today in x11_util::GetSecondaryXConnection() (or w.e it's called). But that's because X somehow ran out of available connections, or something, and I couldn't launch any other programs either. At that point there's probably nothing to do, but a nice error message might help. I wonder if we were at fault for that? I've never seen that happen otherwise. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Problem with building in rlz
Hi all, I recently started getting this error while building Chromium: 2-- Build started: Project: rlz, Configuration: Debug Win32 -- 2Copying binaries/rlz_dll.pdb to I:\trunk\src\chrome\Debug\rlz_dll.pdb 2The system cannot find the path specified. 2Project : error PRJ0019: A tool returned an error code from Copying binaries/rlz_dll.pdb to I:\trunk\src\chrome\Debug\rlz_dll.pdb 2Build log was saved at file://I:\trunk\src\chrome\Debug\obj\rlz\BuildLog.htm 2rlz - 1 error(s), 0 warning(s) 1The operation completed successfully. 1The operation completed successfully. 1The operation completed successfully. Anybody got any idea what may be causing this? Berend-Jan SkyLined Wever (skyli...@google.com) Security Software Engineer Google NL B.V. Reg: C. Debussylaan 34, 15th floor 1082 MD A'dam 34198589 NL VAT / Tax ID:- 812788515 B01 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Clobber if you get V8 linker errors in the next sync
When I landed the WebKIt integration this morning a bunch of the bots needed clobbering due to linker errors. The errors were missing V8 handles while linking generate_profile. I haven't seen any of the commonly-compiled projects fail because of this, so it's possible you don't have to clobber since you probably don't care about this project. Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Problem with building in rlz
On Fri, May 29, 2009 at 8:51 AM, Berend-Jan Wever skyli...@chromium.org wrote: 2Copying binaries/rlz_dll.pdb to I:\trunk\src\chrome\Debug\rlz_dll.pdb 2The system cannot find the path specified. Looks like you're missing a file. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Clobber if you get V8 linker errors in the next sync
Does it make sense to try and fix/add dependencies in the gyp whenever we run into problems like this? I don't know the details of why these dependencies aren't catched already, but it seems like over time we could stop hitting these problems? On Fri, May 29, 2009 at 9:15 AM, Brett Wilson bre...@chromium.org wrote: When I landed the WebKIt integration this morning a bunch of the bots needed clobbering due to linker errors. The errors were missing V8 handles while linking generate_profile. I haven't seen any of the commonly-compiled projects fail because of this, so it's possible you don't have to clobber since you probably don't care about this project. Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Auto Spelling Correction
Wait wait, how did you manage to write those?? :) -Nick On Thu, May 28, 2009 at 6:12 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Great job! I now can't be embarrassed when I write beleive or recieve :) Thanks :) -- Mohamed Mansour On Thu, May 28, 2009 at 7:25 PM, Nick Baum nickb...@chromium.org wrote: Great to see this live, Sid! To clarify, we're deliberately not including any UI for now, and we expect this to be somewhat annoying at first. The hope is that you can help us figure out what's annoying about it, and we'll try to improve the algorithm. Once it's more helpful than annoying, we'll add UI to handle exceptions. Give it a try and let us know how it works for you! -Nick On Thu, May 28, 2009 at 3:52 PM, sidchat sidc...@chromium.org wrote: The new dev build (3.0.182.2) now has a command line option to enable auto spell corrections. This feature will correct words which have been typed wrong due to swapping letters once by mistake - a very common example is typing teh instead of the - moer instead of more and so on. There are no UI support for this yet - just the command line enabler '--auto-spell-correct'. Please do take a look at it and tell me issues about it. If we are sure we want this feature, I will go ahead and make this a full blown Chrome feature by adding UI support (disable through context menu and Options menu, Stop auto-correcting this word options etc). -Sid --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Auto Spelling Correction
I hope it isn't a bug. Because people might need them :) Just type 'believe', and use your arrow keys to goto the 'i', and delete that. And add the 'i' after the 'e' . And you will properly have the erroneous word. -- Mohamed Mansour On Fri, May 29, 2009 at 12:50 PM, Nick Baum nickb...@chromium.org wrote: Wait wait, how did you manage to write those?? :) -Nick On Thu, May 28, 2009 at 6:12 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Great job! I now can't be embarrassed when I write beleive or recieve :) Thanks :) -- Mohamed Mansour On Thu, May 28, 2009 at 7:25 PM, Nick Baum nickb...@chromium.org wrote: Great to see this live, Sid! To clarify, we're deliberately not including any UI for now, and we expect this to be somewhat annoying at first. The hope is that you can help us figure out what's annoying about it, and we'll try to improve the algorithm. Once it's more helpful than annoying, we'll add UI to handle exceptions. Give it a try and let us know how it works for you! -Nick On Thu, May 28, 2009 at 3:52 PM, sidchat sidc...@chromium.org wrote: The new dev build (3.0.182.2) now has a command line option to enable auto spell corrections. This feature will correct words which have been typed wrong due to swapping letters once by mistake - a very common example is typing teh instead of the - moer instead of more and so on. There are no UI support for this yet - just the command line enabler '--auto-spell-correct'. Please do take a look at it and tell me issues about it. If we are sure we want this feature, I will go ahead and make this a full blown Chrome feature by adding UI support (disable through context menu and Options menu, Stop auto-correcting this word options etc). -Sid --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Historgram in V8 compilation cache
Hi, In V8 compilation cache code v8/src/compilation-cache.cc, it create a histogram. StatsTable::CreateHistogram Can you please tell me what is that for? Is it for debugging/profiling purpose? Or it is for JIT compilation? Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Auto Spelling Correction
Okay I found a couple of errors. Been testing it since you guys have committed it. You cannot do contractions. Try typing has not, will not, does not, etc. You can't do it. Try making the first letter capitalized. -- Mohamed Mansour On Fri, May 29, 2009 at 2:09 PM, Mohamed Mansour m0.interact...@gmail.comwrote: I hope it isn't a bug. Because people might need them :) Just type 'believe', and use your arrow keys to goto the 'i', and delete that. And add the 'i' after the 'e' . And you will properly have the erroneous word. -- Mohamed Mansour On Fri, May 29, 2009 at 12:50 PM, Nick Baum nickb...@chromium.org wrote: Wait wait, how did you manage to write those?? :) -Nick On Thu, May 28, 2009 at 6:12 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Great job! I now can't be embarrassed when I write beleive or recieve :) Thanks :) -- Mohamed Mansour On Thu, May 28, 2009 at 7:25 PM, Nick Baum nickb...@chromium.orgwrote: Great to see this live, Sid! To clarify, we're deliberately not including any UI for now, and we expect this to be somewhat annoying at first. The hope is that you can help us figure out what's annoying about it, and we'll try to improve the algorithm. Once it's more helpful than annoying, we'll add UI to handle exceptions. Give it a try and let us know how it works for you! -Nick On Thu, May 28, 2009 at 3:52 PM, sidchat sidc...@chromium.org wrote: The new dev build (3.0.182.2) now has a command line option to enable auto spell corrections. This feature will correct words which have been typed wrong due to swapping letters once by mistake - a very common example is typing teh instead of the - moer instead of more and so on. There are no UI support for this yet - just the command line enabler '--auto-spell-correct'. Please do take a look at it and tell me issues about it. If we are sure we want this feature, I will go ahead and make this a full blown Chrome feature by adding UI support (disable through context menu and Options menu, Stop auto-correcting this word options etc). -Sid --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: reminder: don't use CHECK()
I wonder if we were at fault for that? I've never seen that happen otherwise. I only had like 15 X clients according to xlsclients (max is 255). I saved the stack trace but it's worthless as it's just a standard GetScreenInfo ViewHost msg that we attempt to execute with the 2ndary x connection. So I restarted X and it went away. (Note that my x session had been up for like a month.) I searched the internets and it seems to happen to people for a variety of reasons, usually with no resolution found. -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Auto Spelling Correction
Let me clarify. Try typing this: *Hasn't* the dog ate his food. -- Mohamed Mansour On Fri, May 29, 2009 at 7:02 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Okay I found a couple of errors. Been testing it since you guys have committed it. You cannot do contractions. Try typing has not, will not, does not, etc. You can't do it. Try making the first letter capitalized. -- Mohamed Mansour On Fri, May 29, 2009 at 2:09 PM, Mohamed Mansour m0.interact...@gmail.com wrote: I hope it isn't a bug. Because people might need them :) Just type 'believe', and use your arrow keys to goto the 'i', and delete that. And add the 'i' after the 'e' . And you will properly have the erroneous word. -- Mohamed Mansour On Fri, May 29, 2009 at 12:50 PM, Nick Baum nickb...@chromium.orgwrote: Wait wait, how did you manage to write those?? :) -Nick On Thu, May 28, 2009 at 6:12 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Great job! I now can't be embarrassed when I write beleive or recieve :) Thanks :) -- Mohamed Mansour On Thu, May 28, 2009 at 7:25 PM, Nick Baum nickb...@chromium.orgwrote: Great to see this live, Sid! To clarify, we're deliberately not including any UI for now, and we expect this to be somewhat annoying at first. The hope is that you can help us figure out what's annoying about it, and we'll try to improve the algorithm. Once it's more helpful than annoying, we'll add UI to handle exceptions. Give it a try and let us know how it works for you! -Nick On Thu, May 28, 2009 at 3:52 PM, sidchat sidc...@chromium.org wrote: The new dev build (3.0.182.2) now has a command line option to enable auto spell corrections. This feature will correct words which have been typed wrong due to swapping letters once by mistake - a very common example is typing teh instead of the - moer instead of more and so on. There are no UI support for this yet - just the command line enabler '--auto-spell-correct'. Please do take a look at it and tell me issues about it. If we are sure we want this feature, I will go ahead and make this a full blown Chrome feature by adding UI support (disable through context menu and Options menu, Stop auto-correcting this word options etc). -Sid --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Historgram in V8 compilation cache
It is purely for gathering statistics on our use of the cache and has no influence on the generated code. -- Mads On Fri, May 29, 2009 at 3:32 PM, Lucius Fox lucius.fo...@gmail.com wrote: Hi, In V8 compilation cache code v8/src/compilation-cache.cc, it create a histogram. StatsTable::CreateHistogram Can you please tell me what is that for? Is it for debugging/profiling purpose? Or it is for JIT compilation? Thank you. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Auto Spelling Correction
*Hasn't* the dog ate his food. Yes - this is due to the bug http://code.google.com/p/chromium/issues/detail?id=11897 - it seems that bug has reappeared. -Sid -- Mohamed Mansour On Fri, May 29, 2009 at 7:02 PM, Mohamed Mansour m0.interact...@gmail.comwrote: Okay I found a couple of errors. Been testing it since you guys have committed it. You cannot do contractions. Try typing has not, will not, does not, etc. You can't do it. Try making the first letter capitalized. -- Mohamed Mansour On Fri, May 29, 2009 at 2:09 PM, Mohamed Mansour m0.interact...@gmail.com wrote: I hope it isn't a bug. Because people might need them :) Just type 'believe', and use your arrow keys to goto the 'i', and delete that. And add the 'i' after the 'e' . And you will properly have the erroneous word. -- Mohamed Mansour On Fri, May 29, 2009 at 12:50 PM, Nick Baum nickb...@chromium.orgwrote: Wait wait, how did you manage to write those?? :) -Nick On Thu, May 28, 2009 at 6:12 PM, Mohamed Mansour m0.interact...@gmail.com wrote: Great job! I now can't be embarrassed when I write beleive or recieve :) Thanks :) -- Mohamed Mansour On Thu, May 28, 2009 at 7:25 PM, Nick Baum nickb...@chromium.orgwrote: Great to see this live, Sid! To clarify, we're deliberately not including any UI for now, and we expect this to be somewhat annoying at first. The hope is that you can help us figure out what's annoying about it, and we'll try to improve the algorithm. Once it's more helpful than annoying, we'll add UI to handle exceptions. Give it a try and let us know how it works for you! -Nick On Thu, May 28, 2009 at 3:52 PM, sidchat sidc...@chromium.org wrote: The new dev build (3.0.182.2) now has a command line option to enable auto spell corrections. This feature will correct words which have been typed wrong due to swapping letters once by mistake - a very common example is typing teh instead of the - moer instead of more and so on. There are no UI support for this yet - just the command line enabler '--auto-spell-correct'. Please do take a look at it and tell me issues about it. If we are sure we want this feature, I will go ahead and make this a full blown Chrome feature by adding UI support (disable through context menu and Options menu, Stop auto-correcting this word options etc). -Sid --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] 2 questions about SVN
Hi, 1- if i want to see ONLY the .cc files i changed in a folder i type svn diff *.cc -works but say i do the same in ...\src\chrome i get this : svn: Can't open file '*.cc\.svn\entries': ??T? ,-.?, T? ,`~%, ?. ,?╪? %~ T? ?..% ? ??-'% ,?╪`.? T,.%%?. which i need to find all the changes i did (svn diff by itself is too much info and i need to filter) 2- i would like to use windiff against my modified sources so say i have modified a.cc if i do a svn revert a.cc it will overwrite my modified file, which is not what i want and svn diff a.cc is not very readable to me so what i would like to do is revert but give a new name for the file and then i can add a tool in the IDE to quickly windiff thanx --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: 2 questions about SVN
2009/5/29 nakro yoav.zilberb...@gmail.com: Hi, 1- if i want to see ONLY the .cc files i changed in a folder i type svn diff *.cc -works but say i do the same in ...\src\chrome i get this : svn: Can't open file '*.cc\.svn\entries': ??T? ,-.?, T? ,`~%, ?. ,?╪? %~ T? ?..% ? ??-'% ,?╪`.? T,.%%?. which i need to find all the changes i did (svn diff by itself is too much info and i need to filter) 2- i would like to use windiff against my modified sources so say i have modified a.cc if i do a svn revert a.cc it will overwrite my modified file, which is not what i want and svn diff a.cc is not very readable to me so what i would like to do is revert but give a new name for the file and then i can add a tool in the IDE to quickly windiff thanx 1. svn diff `find . -name *.cc` 2. svn diff a.cc | patch -Rp0 -o a_trunk.cc -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: chrome://downloads/ behaviour (some suggestions and a bug, i think)
(also, having read the source code that handles downloads, i didn't really get why you first create a temp file only to transfer it at the end to the real name. i am sure you have reasons but i was just curious) to parallelize the process of choosing the download location and actually getting the file (in the case of save as dialogs) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac History Menu Implementation
I like firefox's approach with the recently closed in a submenu of the history menu. Honestly though I can't say I use it very frequently. I just feel safer knowing it's there. -- Evan Stade On Thu, May 28, 2009 at 1:14 PM, Ben Goodger (Google) b...@chromium.org wrote: I would say try as a replacement. i.e. similar to the dock menu... 9 most visited items + 3-4 recently closed -Ben On Thu, May 28, 2009 at 12:35 PM, Robert Sesek rse...@gmail.com wrote: On Tue, May 26, 2009 at 00:59, Ben Goodger (Google) b...@chromium.org wrote: I think we had discussed adding most visited/recently closed items here, sort of like a NTP without the NTP. I think this is an interesting idea, particularly the most recently closed items. Are you thinking this is supplemental to the typical (i.e., what other browsers do) history menu, or as a replacement for it? - Robert --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: 2 questions about SVN
thanx evan, just to be clear i use *windows* (hence the windiff thing) and i have svn 1.6.1 (the normal env i hope, i did not modify it) 1- svn diff `find . -name *.cc` returns: svn.exe: invalid option character: n 2- 'patch' is not recognized as an internal or external command operable program or batch file. and indeed there is no patch utility i haven't used unix in years, but as it seems your solution is unix based, and thoughts are welcome --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: 2 questions about SVN
use cygwin -- Evan Stade On Fri, May 29, 2009 at 6:29 PM, nakro yoav.zilberb...@gmail.com wrote: thanx evan, just to be clear i use *windows* (hence the windiff thing) and i have svn 1.6.1 (the normal env i hope, i did not modify it) 1- svn diff `find . -name *.cc` returns: svn.exe: invalid option character: n 2- 'patch' is not recognized as an internal or external command operable program or batch file. and indeed there is no patch utility i haven't used unix in years, but as it seems your solution is unix based, and thoughts are welcome --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: 2 questions about SVN
Try using Tortise SVN, it has built-in visual diff and explorer shell integration (and it's free). http://tortoisesvn.tigris.org You might even be able to set the diff program it uses, I'm not sure (I'm on my Mac right now, but I use Tortise on my Windows machine). Note that this is only the SVN part of things -- you'll still have to use gclient to do some operations on the whole tree (like sync the dependencies). -Greg. On Fri, May 29, 2009 at 6:29 PM, nakro yoav.zilberb...@gmail.com wrote: thanx evan, just to be clear i use *windows* (hence the windiff thing) and i have svn 1.6.1 (the normal env i hope, i did not modify it) 1- svn diff `find . -name *.cc` returns: svn.exe: invalid option character: n 2- 'patch' is not recognized as an internal or external command operable program or batch file. and indeed there is no patch utility i haven't used unix in years, but as it seems your solution is unix based, and thoughts are welcome --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: 2 questions about SVN
Evan, i have cygwin in my path and i know that when you build chrome it registers cygwin via some registry mounting hack as a prof if i enter pwd it indeed works like in unix still, none of your solutions works can you really run this on your windows OS ? for example, in my cygwin/bin directory there is no 'patch' command and not in my 'depot_tools' folder in fact there is no patch.exe anywhere on my disk --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: 2 questions about SVN
how do you apply other people's diffs if you don't have patch? Run cygwin's setup.exe and select the 'patch' package. -- Evan Stade On Fri, May 29, 2009 at 6:43 PM, nakro yoav.zilberb...@gmail.com wrote: Evan, i have cygwin in my path and i know that when you build chrome it registers cygwin via some registry mounting hack as a prof if i enter pwd it indeed works like in unix still, none of your solutions works can you really run this on your windows OS ? for example, in my cygwin/bin directory there is no 'patch' command and not in my 'depot_tools' folder in fact there is no patch.exe anywhere on my disk --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
Is anyone planning to do a UI review of linux and/or mac? We copy windows where we can (for padding and hard-coded sizes and whatnot), but there are tons of places where that's not possible. Also, padding numbers don't really translate 1 for 1 all the time. I've been choosing numbers based on my own aesthetic preferences, but sometimes it feels like I'm drawing them out of a hat. 4 pixels, 5 pixels, 6 pixels, what's the difference? I'll also take this opportunity to complain that the dangerous downloads dialog warning icon is way off center on windows. (see attachment. for comparison purposes, I've also attached linux ;) -- Evan Stade On Wed, May 27, 2009 at 2:27 PM, Ben Goodger (Google) b...@chromium.org wrote: I want to stress this point. It's always best to discuss any change in Chrome code with others before you invest a lot of time on it. You will doubtless get helpful feedback and there's a high likelihood you'll save a lot of time. -Ben On Wed, May 27, 2009 at 2:23 PM, Glen Murphy g...@chromium.org wrote: It would save effort if you discussed the changes you plan to make before writing code. Otherwise just drop us an email and point to the CL (screenshots help, as not all of the team are engineers). On Wed, May 27, 2009 at 2:19 PM, Mohamed Mansourm0.interact...@gmail.com wrote: So do we send a CL to all of you guys or just one? Assuming all of you touched it. -- Mohamed Mansour On Wed, May 27, 2009 at 4:01 PM, Ben Goodger (Google) b...@chromium.org wrote: Also FYI, If you're just porting existing UI to a different platform, no need to discuss with us. Same thing if it's a platform specific difference that we've discussed previously (e.g. we know there's a menu bar on the Mac). The intent with this is to catch new features that don't exist on any platform yet as they creep in. -Ben On Wed, May 27, 2009 at 12:36 PM, Ben Goodger (Google) b...@chromium.org wrote: This has happened a couple of times now. If you're adding any visible user interface, even if it's just a checkbox to the advanced page of Options, you must discuss it with: myself (ben@) Glen Murphy (glen@) Nick Baum (nickbaum@) Brian Rakowski (brian@) first. If you don't, it's highly likely that your change will be reverted :-) -Ben --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~--- attachment: droopy_warning_icon.jpgattachment: lnx_warning_icon.jpg
[chromium-dev] Re: 2 questions about SVN
Greg and Evan, thanx a lot Greg your solution is perfect, and it works! Evan, i of course never applied anyone else's patch, and i have to say i never saw in your online documentation about how to get the code any mention of this cygwin setup i needed to do, i must have missed it, sorry i will look for it to find how to get this cygwin thing going thanx to you both --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
On Fri, May 29, 2009 at 7:45 PM, Evan Stade est...@chromium.org wrote: I'll also take this opportunity to complain that the dangerous downloads dialog warning icon is way off center on windows. (see attachment. for comparison purposes, I've also attached linux ;) The entire download bar UI has serious alignment issues depending on theme, fonts, etc. The fact that on my machines, the dropmarker in the right edge of a download's button isn't even close to vertically centered always saddens me. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Important: User visible UI changes must be discussed with the UI folk
...these issues are filed as bugs so we can fix them, right? On Fri, May 29, 2009 at 22:23, Peter Kasting pkast...@chromium.org wrote: On Fri, May 29, 2009 at 7:45 PM, Evan Stade est...@chromium.org wrote: I'll also take this opportunity to complain that the dangerous downloads dialog warning icon is way off center on windows. (see attachment. for comparison purposes, I've also attached linux ;) The entire download bar UI has serious alignment issues depending on theme, fonts, etc. The fact that on my machines, the dropmarker in the right edge of a download's button isn't even close to vertically centered always saddens me. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
