[chromium-dev] Uploading new Patch to the existing issue.
I wanna upload new patch to the existing issue (on the code-review board) regarding reviewer's comments. But every time I try to upload my patch, it is not added to the issue (previously created) but the new issue is created with that patch. Plz let me know how I can solve it. Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: build problem (chromium.r9040.tar.gz)
I have not checked out the code using 'gclient sync'. Anyway, The URL for the build instructions I followed. - 1. http://dev.chromium.org/developers/how-tos/build-instructions-windows Link to here -> 2. http://dev.chromium.org/developers/how-tos/get-the-code Link to here -> 3. http://build.chromium.org/buildbot/archives/chromium_tarball.html And it started to download chromium.r9045.tar.gz automatically. --- I visited the server (http://src.chromium.org/viewvc/chrome/trunk/ src/...) and looked over the latest version (directory revision 9125) of the grit_resource_file.bat and third_party folder. And I verified that there are no differences between them (the latest) and my local files. - There are not python_24 and cygwin under third_party folder and grit_resource_file.bat still references them. So, in this case, if I check out the latest files using 'gclient sync', is there anything that is changed? On 2월4일, 오전11시12분, Evan Martin wrote: > You must use gclient sync to check out. What is the URL for the build > instructions were you following? I can fix them. > > On Tue, Feb 3, 2009 at 6:04 PM, DeArto20 wrote: > > > I have downloaded r9040 tar-ball from the chromium web site and built > > it in VS2005 > > (Before building it, I have removed the previous version completely in > > my hard disk.) > > > But it made lots of errors. - One of those was > > 'generated_resources.h'. > > > So, I have looked into it in detail and found that the batch file > > 'grit_resource_file.bat' is a little weird. > > It has following lines in it. > > > --- > > --- > > --- > > :: Put cygwin in the path > > call %SolutionDir%\..\third_party\cygwin\setup_env.bat > > > %SolutionDir%\..\third_party\python_24\python.exe %SolutionDir%\.. > > \tools\grit\grit.py -i %InFile% build -o %OutDir% > > --- > > --- > > --- > > > It contains 'third_party\cygwin' and 'third_party\python_24'. But as > > far as I know, those are not available anymore. > > (r9040 doesn't have 'cygwin' or 'python_24' inside the 'third_party' > > folder.) > > > How do you think about this? And what should I do for building the > > project successfully? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] build problem (chromium.r9040.tar.gz)
I have downloaded r9040 tar-ball from the chromium web site and built it in VS2005 (Before building it, I have removed the previous version completely in my hard disk.) But it made lots of errors. - One of those was 'generated_resources.h'. So, I have looked into it in detail and found that the batch file 'grit_resource_file.bat' is a little weird. It has following lines in it. - :: Put cygwin in the path call %SolutionDir%\..\third_party\cygwin\setup_env.bat %SolutionDir%\..\third_party\python_24\python.exe %SolutionDir%\.. \tools\grit\grit.py -i %InFile% build -o %OutDir% - It contains 'third_party\cygwin' and 'third_party\python_24'. But as far as I know, those are not available anymore. (r9040 doesn't have 'cygwin' or 'python_24' inside the 'third_party' folder.) How do you think about this? And what should I do for building the project successfully? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Context menu for title bar doesn't appear when a tab's context menu was open
I wanted to know how others in this group think about my suggestion about above bug (issue 5695), If it is reasonable or not. On 1월10일, 오전1시49분, Peter Kasting wrote: > On Fri, Jan 9, 2009 at 6:13 AM, DeArto20 wrote: > > The following is the reply written by me on bugtracker - Issue 5695. > > So... why are you mailing it to this list? > > PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Context menu for title bar doesn't appear when a tab's context menu was open
I wanted know how others in this group think about my suggestion about above bug (issue 5695), If it is reasonable or not. On 1월10일, 오전1시49분, Peter Kasting wrote: > On Fri, Jan 9, 2009 at 6:13 AM, DeArto20 wrote: > > The following is the reply written by me on bugtracker - Issue 5695. > > So... why are you mailing it to this list? > > PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Context menu for title bar doesn't appear when a tab's context menu was open
The following is the reply written by me on bugtracker - Issue 5695. http://crbug.com/5695 +++ I think chrome browser lacks consistency in displaying context menu. * Current State - context menu for the 'Tab' : Show up on right mouse button 'Release' context menu for the 'App' : Show up on right mouse button 'Press' - This inconsistent concept (one by 'Release' and the other by 'Press') is not natural (in the UI point of view) and can cause problems. Currently, when the right mouse button is 'Pressed' on the title bar, its handler seems to take following two steps in order. 1. Close the current context menu if it exists. 2. Create new context menu. Processing two operations (Closing and Creating) at one time ('Press') can cause conflict problems. - If the current context menu is for an 'App', there's no problem. But if it is for a 'Tab', it seems that above two steps come into the conflict and doesn't work well. *Suggestion * So, Divide two operations (Closing and Creating) into seperate handlers. - Closing always on 'Press' and Creating always on 'Release'. If this concept is applied, no conflict can occur. - When the mouse button is 'Pressed', current (for a Tab or for an App.) context menu is closed and when the button is 'Released', new context menu is created. And, it is natural that displaying context menu is always done by 'Release' operation. (MS IE also uses this concept.) * Suggested State: - context menu for the 'Tab' : Show up on right mouse button 'Release' context menu for the 'App' : Show up on right mouse button 'Release' - +++ I wanna know your opinions about this. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Context menu for title bar doesn't appear when a tab's context menu was open
The following is my reply on the Issue 5695 in the bugtracker. (http:// crbug.com/5695) ++ I think chrome browser lacks consistency in displaying context menu. * Current State context menu for the 'Tab' : Show up on right mouse button 'Release' context menu for the 'App' : Show up on right mouse button 'Press' This inconsistent concept (one by 'Release' and the other by 'Press') is not natural (in the UI point of view) and can cause problems. Currently, when the right mouse button is 'Pressed' on the title bar, its handler seems to take following two steps in order. 1. Close the current context menu if it exists. 2. Create new context menu. Processing two operations (Closing and Creating) at one time ('Press') can cause conflict problems. - If the current context menu is for an 'App', there's no problem. But if it is for a 'Tab', it seems that above two steps come into the conflict and doesn't work well. *Suggestion * So, Divide two operations (Closing and Creating) into seperate handlers. - Closing always on 'Press' and Creating always on 'Release'. If this concept is applied, no conflict can occur. - When the mouse button is 'Pressed', current (for a Tab or for an App.) context menu is closed and when the button is 'Released', new context menu is created. And, it is natural that displaying context menu is always done by 'Release' operation. (MS IE also uses this concept.) * Suggested State: context menu for the 'Tab' : Show up on right mouse button 'Release' context menu for the 'App' : Show up on right mouse button 'Release' ++ I wanna know your opinions about this. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Problem with 'gcl' use.
It works fine. Thanks!! On 1월1일, 오후11시21분, Tommi wrote: > Hey DeArto20, > > Try running gcl from the src directory. For me that's C:\chromium\src. > > On Thu, Jan 1, 2009 at 2:00 PM, DeArto20 wrote: > > > Hi. > > > I have a problem during 'request review'. > > > Specifically, when i execute 'gcl change XXX' in the command window, I > > get the following result. > > > "gcl run outside of repository" > > > How can i solve this problem. Plz let me know what should i do. > > > Have a good day! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Problem with 'gcl' use.
It works fine! Thanks!! On 1월1일, 오후11시21분, Tommi wrote: > Hey DeArto20, > > Try running gcl from the src directory. For me that's C:\chromium\src. > > On Thu, Jan 1, 2009 at 2:00 PM, DeArto20 wrote: > > > Hi. > > > I have a problem during 'request review'. > > > Specifically, when i execute 'gcl change XXX' in the command window, I > > get the following result. > > > "gcl run outside of repository" > > > How can i solve this problem. Plz let me know what should i do. > > > Have a good day! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Problem with 'gcl' use.
It works fine. Thanks!! On 1월1일, 오후11시21분, Tommi wrote: > Hey DeArto20, > > Try running gcl from the src directory. For me that's C:\chromium\src. > > On Thu, Jan 1, 2009 at 2:00 PM, DeArto20 wrote: > > > Hi. > > > I have a problem during 'request review'. > > > Specifically, when i execute 'gcl change XXX' in the command window, I > > get the following result. > > > "gcl run outside of repository" > > > How can i solve this problem. Plz let me know what should i do. > > > Have a good day! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Problem with 'gcl' use.
test On 1월1일, 오후11시00분, DeArto20 wrote: > Hi. > > I have a problem during 'request review'. > > Specifically, when i execute 'gcl change XXX' in the command window, I > get the following result. > > "gcl run outside of repository" > > How can i solve this problem. Plz let me know what should i do. > > Have a good day! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Problem with 'gcl' use.
Hi. I have a problem during 'request review'. Specifically, when i execute 'gcl change XXX' in the command window, I get the following result. "gcl run outside of repository" How can i solve this problem. Plz let me know what should i do. Have a good day! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Questions About Contributing Codes
Hi. I'm new on this chromium project. I have some questions about joining on this project as a developer. I wanna know how developers find the problems that should be improved or resolved. - 1. Do they check bug tracker board? : In this case, how can he (or she) be assigned on the issue that he (or she) is interested in? - 2. Do they find the problem during their daily use of chrome browser? : In this case, is there no need that he (or she) should report that issue to someone or some board? And then, simply write his (or her) own code for that issue and request review (using review board) about it? Thanks for reading. Have a good day! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---