[chromium-dev] Re: External protocol dialog checkbox
On Tue, Oct 20, 2009 at 9:37 PM, Evan Stade wrote: > > fyi: http://codereview.chromium.org/306017/show > > Yes. As soon as that GRD change gets in I'm patching my code... Avi --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: External protocol dialog checkbox
fyi: http://codereview.chromium.org/306017/show -- Evan Stade On Tue, Oct 20, 2009 at 5:41 PM, Brian Rakowski wrote: > Seems like everyone agrees that "Cancel" should become "Don't launch" > > On Tue, Oct 20, 2009 at 1:07 PM, Mark Mentovai wrote: >> >> Evan Stade wrote: >> > There's a checkbox in the external protocol dialog with the text >> > "Remember my choice for all links of this type." (On windows and >> > linux, this is not actually implemented, but there are bugs out to fix >> > that) The options are then "Cancel" and "Launch Application". The >> > conflict here is that in general Cancel is supposed to not do >> > anything, hence it can't honor the "Remember my choice for all links >> > of this type" option. So that checkbox should either be renamed >> > "Always allow this protocol", and not allow the user to always block >> > that protocol, or the cancel button should be renamed to "don't launch >> > app" or equivalent. >> >> I agree with this 100%. When Avi implemented this dialog on the Mac, >> I was really mean about it and I wouldn't let him make the "remember" >> checkbox actually remember anything as long as the button's text >> remained "Cancel". >> >> The button label should change to "Don't Launch" or something along >> those lines. Leaving it at Cancel is ambiguous. >> >> Mark >> >> >> > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: External protocol dialog checkbox
Seems like everyone agrees that "Cancel" should become "Don't launch" On Tue, Oct 20, 2009 at 1:07 PM, Mark Mentovai wrote: > > Evan Stade wrote: > > There's a checkbox in the external protocol dialog with the text > > "Remember my choice for all links of this type." (On windows and > > linux, this is not actually implemented, but there are bugs out to fix > > that) The options are then "Cancel" and "Launch Application". The > > conflict here is that in general Cancel is supposed to not do > > anything, hence it can't honor the "Remember my choice for all links > > of this type" option. So that checkbox should either be renamed > > "Always allow this protocol", and not allow the user to always block > > that protocol, or the cancel button should be renamed to "don't launch > > app" or equivalent. > > I agree with this 100%. When Avi implemented this dialog on the Mac, > I was really mean about it and I wouldn't let him make the "remember" > checkbox actually remember anything as long as the button's text > remained "Cancel". > > The button label should change to "Don't Launch" or something along > those lines. Leaving it at Cancel is ambiguous. > > Mark > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: External protocol dialog checkbox
Evan Stade wrote: > There's a checkbox in the external protocol dialog with the text > "Remember my choice for all links of this type." (On windows and > linux, this is not actually implemented, but there are bugs out to fix > that) The options are then "Cancel" and "Launch Application". The > conflict here is that in general Cancel is supposed to not do > anything, hence it can't honor the "Remember my choice for all links > of this type" option. So that checkbox should either be renamed > "Always allow this protocol", and not allow the user to always block > that protocol, or the cancel button should be renamed to "don't launch > app" or equivalent. I agree with this 100%. When Avi implemented this dialog on the Mac, I was really mean about it and I wouldn't let him make the "remember" checkbox actually remember anything as long as the button's text remained "Cancel". The button label should change to "Don't Launch" or something along those lines. Leaving it at Cancel is ambiguous. Mark --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: External protocol dialog checkbox
I'm more in favor of renaming cancel. [ ] Remember my choice for links of this type [ Launch application ] [ Do not launch application ] (or even 'Do nothing') On Tue, Oct 20, 2009 at 1:01 PM, Evan Stade wrote: > There's a checkbox in the external protocol dialog with the text > "Remember my choice for all links of this type." (On windows and > linux, this is not actually implemented, but there are bugs out to fix > that) The options are then "Cancel" and "Launch Application". The > conflict here is that in general Cancel is supposed to not do > anything, hence it can't honor the "Remember my choice for all links > of this type" option. So that checkbox should either be renamed > "Always allow this protocol", and not allow the user to always block > that protocol, or the cancel button should be renamed to "don't launch > app" or equivalent. > > -- Evan Stade > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: External protocol dialog checkbox
The latter in fact is how it's implemented on the Mac, though without the renaming of the checkbox that would make it clear what's going on. I'd support either version, and would alter my code to make it happen. Avi On Tue, Oct 20, 2009 at 4:01 PM, Evan Stade wrote: > > There's a checkbox in the external protocol dialog with the text > "Remember my choice for all links of this type." (On windows and > linux, this is not actually implemented, but there are bugs out to fix > that) The options are then "Cancel" and "Launch Application". The > conflict here is that in general Cancel is supposed to not do > anything, hence it can't honor the "Remember my choice for all links > of this type" option. So that checkbox should either be renamed > "Always allow this protocol", and not allow the user to always block > that protocol, or the cancel button should be renamed to "don't launch > app" or equivalent. > > -- Evan Stade > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
