[chromium-dev] Re: Local State / Preferences distinction
Actually, the original distinction was stuff that could be shared across computers and stuff that couldn't be shared (i.e., local state). I think originally this was for the difference between stuff that a mounted home directory would sync and stuff that wouldn't sync. In practice, I think it's used for both, which is all the more reason to merge them. On Wed, Oct 7, 2009 at 12:46 PM, Evan Stade est...@chromium.org wrote: I was looking at http://crbug.com/19061, which is a bug Tony filed to merge the Local State and Preferences files. Both files hold user preferences, but the idea is that Local State holds prefs that are common to all user profiles, and Preferences is unique to each user (thus it is in the Default/ user profile directory). We don't actually support using multiple user profiles though, it seems. The win for combining them is to remove another file read on startup. Also, the distinction is confusing and some stuff is arguably in the wrong place (e.g. browser window dimensions are in Local State). However, the loss is that we will lose the ability to have multiple user profiles in one user data directory (don't know what our plans are for this, if any). This patch is pretty large so I'd like some feedback before starting it. -- Evan Stade --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Local State / Preferences distinction
On Wed, Oct 7, 2009 at 12:52 PM, Tony Chang t...@chromium.org wrote: Actually, the original distinction was stuff that could be shared across computers and stuff that couldn't be shared (i.e., local state). I think originally this was for the difference between stuff that a mounted home directory would sync and stuff that wouldn't sync. In practice, I think it's used for both, which is all the more reason to merge them. This comes up with the quasi-defunct profile system. Local State is supposed to be cross-profile, while the stuff in Default is your profile data. The safe browsing data in Local State should always stay with the safe browsing files, which currently stay in user-data-dir. I suspect the metrics stuff should also be cross profile. Do we need this profile support? The interface has been hidden behind a command line flag enable-udd-profiles. Is it time to rip all of this profile stuff out? Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Local State / Preferences distinction
The quasi-defunct profile system that uses the enable-udd-profiles still has a separate Local State file and safe browsing databases because it used different user data directory (udd). This change seems orthogonal to the profile system as it is currently implemented. We can resplit the Preferences file in the future if needed (and once the actual split is clear or needed). On Wed, Oct 7, 2009 at 1:16 PM, Brett Wilson bre...@chromium.org wrote: On Wed, Oct 7, 2009 at 12:52 PM, Tony Chang t...@chromium.org wrote: Actually, the original distinction was stuff that could be shared across computers and stuff that couldn't be shared (i.e., local state). I think originally this was for the difference between stuff that a mounted home directory would sync and stuff that wouldn't sync. In practice, I think it's used for both, which is all the more reason to merge them. This comes up with the quasi-defunct profile system. Local State is supposed to be cross-profile, while the stuff in Default is your profile data. The safe browsing data in Local State should always stay with the safe browsing files, which currently stay in user-data-dir. I suspect the metrics stuff should also be cross profile. Do we need this profile support? The interface has been hidden behind a command line flag enable-udd-profiles. Is it time to rip all of this profile stuff out? Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Local State / Preferences distinction
On Wed, Oct 7, 2009 at 1:26 PM, Tony Chang t...@chromium.org wrote: The quasi-defunct profile system that uses the enable-udd-profiles still has a separate Local State file and safe browsing databases because it used different user data directory (udd). This change seems orthogonal to the profile system as it is currently implemented. We can resplit the Preferences file in the future if needed (and once the actual split is clear or needed). I couldn't figure out how it works, but it looks like the UDD profile switching is broken on WIndows (the submenu doesn't even pop anything up for me) and the code I was thinking of in the ProfileManager seems to never be used. This mess makes me very sad. Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
