[chromium-dev] Re: Makefile build broken
On Thu, Jun 11, 2009 at 11:49 AM, Albert J. Wong (王重傑) wrote: > I'll probably just submit the generated files as tony suggested. Check with Tony, but I think I just reviewed a GYP change which will make (forgive the pun) it work again. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Makefile build broken
sorry for the bustage. I had assumed the make file was still a toy with only 2-3 people using it (not many linux chrome folks where I am). Thanks for rolling it back Adam. I'll probably just submit the generated files as tony suggested. -Albert On Thu, Jun 11, 2009 at 9:51 AM, Thomas Van Lenten wrote: > > > On Thu, Jun 11, 2009 at 12:48 PM, Adam Langley wrote: > >> >> On Thu, Jun 11, 2009 at 8:52 AM, Tony Chang wrote: >> > Albert, what do you think? I estimate that about 5-7 people on the >> > linux team use the make build these days. >> >> I reverted in r18168. It sucks that there's no try or builders for the >> make build, but it's what everyone uses these days. > > > If the times are really better, we can change the default in gyp, someone > just needs to update the buildbot scripts accordingly. > > TVL > > >> >> >> >> AGL >> >> >> > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Makefile build broken
On Thu, Jun 11, 2009 at 12:48 PM, Adam Langley wrote: > > On Thu, Jun 11, 2009 at 8:52 AM, Tony Chang wrote: > > Albert, what do you think? I estimate that about 5-7 people on the > > linux team use the make build these days. > > I reverted in r18168. It sucks that there's no try or builders for the > make build, but it's what everyone uses these days. If the times are really better, we can change the default in gyp, someone just needs to update the buildbot scripts accordingly. TVL > > > > AGL > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Makefile build broken
On Thu, Jun 11, 2009 at 8:52 AM, Tony Chang wrote: > Albert, what do you think? I estimate that about 5-7 people on the > linux team use the make build these days. I reverted in r18168. It sucks that there's no try or builders for the make build, but it's what everyone uses these days. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Makefile build broken
The make file generator has a bug. I started to work on fixing the build last night but it's not finished and I'm not sure how long it will take me this morning. I think it's a little unfair to revert even though all the buildbots are green (since there's no make buildbot and we can use the scons build instead). Alternately, if this file is not going to change often, maybe we can just check the generated file into the tree? Albert, what do you think? I estimate that about 5-7 people on the linux team use the make build these days. On Thu, Jun 11, 2009 at 8:29 AM, Adam Langley wrote: > On Thu, Jun 11, 2009 at 2:39 AM, Dean McNamee wrote: >> At least for me, I'm hitting an error with generate_stubs.py. Will >> try to figure out the proper fix, in the mean time I fixed up the >> paths manually and ran the following from my source root. I was able >> to successfully build. This is for a debug build, replace Debug w/ >> Release for a release build. > > Tony and awong were talking about this last night, but I don't know > what the resolution was (I suspect none). > > If this is still busted: it's time to revert. Better inconvenience one > person than screw up the morning for many. > > > AGL > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Makefile build broken
On Thu, Jun 11, 2009 at 2:39 AM, Dean McNamee wrote: > At least for me, I'm hitting an error with generate_stubs.py. Will > try to figure out the proper fix, in the mean time I fixed up the > paths manually and ran the following from my source root. I was able > to successfully build. This is for a debug build, replace Debug w/ > Release for a release build. Tony and awong were talking about this last night, but I don't know what the resolution was (I suspect none). If this is still busted: it's time to revert. Better inconvenience one person than screw up the morning for many. AGL --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
