[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!
Can we have a trybot with that configuration, which would just compile the code? I think it would really save people's time. I never build with TOOLKIT_VIEWS, and in case of breakage I would have to immediately revert and then investigate. If I got a trybot failure, I would know much more before committing. On Mon, Jul 20, 2009 at 17:50, Ben Goodger (Google) wrote: > > This mostly applies to people working on UI. > > Sometime tonight or tomorrow we'll be moving the TOOLKIT_VIEWS builder > to the front page of the waterfall. Right now it's building just the > chrome target, and running no tests, but in time we'll build this out. > This is an experimental build distinct from the standard Chromium > linux which we will ship but a codepath which we will support as first > class for other purposes. So please keep it green! If it goes red, the > same rules that apply to any other builder on the front page will > apply. > > To build, > > export GYP_DEFINES="toolkit_views=1" > gclient runhooks --force > hammer chrome > > Thanks, > > -Ben > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!
On Mon, Jul 20, 2009 at 5:50 PM, Ben Goodger (Google) wrote: > > This mostly applies to people working on UI. > > Sometime tonight or tomorrow we'll be moving the TOOLKIT_VIEWS builder > to the front page of the waterfall. Right now it's building just the > chrome target, and running no tests, but in time we'll build this out. > This is an experimental build distinct from the standard Chromium > linux which we will ship but a codepath which we will support as first > class for other purposes. So please keep it green! If it goes red, the > same rules that apply to any other builder on the front page will > apply. Now available at : http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Builder%20(Toolkit%20dbg) > > > To build, > > export GYP_DEFINES="toolkit_views=1" > gclient runhooks --force > hammer chrome > > Thanks, > > -Ben > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!
On Tue, Jul 21, 2009 at 8:31 AM, Paweł Hajdan Jr. wrote: > Can we have a trybot with that configuration, which would just compile the > code? I think it would really save people's time. I never build with > TOOLKIT_VIEWS, and in case of breakage I would have to immediately revert > and then investigate. If I got a trybot failure, I would know much more > before committing. Ben: How likely is this to break? I'm reluctant to add yet another try bot because they do take a lot of resources. There are maybe 200-300 try changes sent every day. That means we need enough resources to build this configuration that many times, and it needs to answer fast enough. I think we should create this try bot, but make it "on demand" only. We are already planning to do this for valgrind, purify and layout tests. That won't help much catching random errors at the first place, but at least you'll be able to see if you fixed it correctly. And if you think your code might be breaking it, you can always pre-emptively trigger a try run on this try bot. I'm not sure yet when this kind of infrastructure is going to be ready. I think it's on maruel's plate. Nicolas > > On Mon, Jul 20, 2009 at 17:50, Ben Goodger (Google) wrote: > >> >> This mostly applies to people working on UI. >> >> Sometime tonight or tomorrow we'll be moving the TOOLKIT_VIEWS builder >> to the front page of the waterfall. Right now it's building just the >> chrome target, and running no tests, but in time we'll build this out. >> This is an experimental build distinct from the standard Chromium >> linux which we will ship but a codepath which we will support as first >> class for other purposes. So please keep it green! If it goes red, the >> same rules that apply to any other builder on the front page will >> apply. >> >> To build, >> >> export GYP_DEFINES="toolkit_views=1" >> gclient runhooks --force >> hammer chrome >> >> Thanks, >> >> -Ben >> >> >> > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!
On Tue, Jul 21, 2009 at 8:42 AM, Nicolas Sylvain wrote: > On Tue, Jul 21, 2009 at 8:31 AM, Paweł Hajdan Jr. > wrote: >> >> Can we have a trybot with that configuration, which would just compile the >> code? I think it would really save people's time. I never build with >> TOOLKIT_VIEWS, and in case of breakage I would have to immediately revert >> and then investigate. If I got a trybot failure, I would know much more >> before committing. > > Ben: How likely is this to break? > I'm reluctant to add yet another try bot because they do take a lot of > resources. There are maybe 200-300 try changes sent every day. That means > we need enough resources to build this configuration that many times, and it > needs to answer fast enough. I don't think an automatically-running trybot is very critical for this build at the moment. Most of the things that break it are pretty simple (need to add a file to GYP, or maybe a stub for something) so the breakage won't be super complicated. Most errors will be caught by the regular trybots. Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!
What brett said. When the infrastructure is available to easily configure an on-demand one, go ahead and do it then. -Ben On Tue, Jul 21, 2009 at 3:56 PM, Brett Wilson wrote: > > On Tue, Jul 21, 2009 at 8:42 AM, Nicolas Sylvain wrote: >> On Tue, Jul 21, 2009 at 8:31 AM, Paweł Hajdan Jr. >> wrote: >>> >>> Can we have a trybot with that configuration, which would just compile the >>> code? I think it would really save people's time. I never build with >>> TOOLKIT_VIEWS, and in case of breakage I would have to immediately revert >>> and then investigate. If I got a trybot failure, I would know much more >>> before committing. >> >> Ben: How likely is this to break? >> I'm reluctant to add yet another try bot because they do take a lot of >> resources. There are maybe 200-300 try changes sent every day. That means >> we need enough resources to build this configuration that many times, and it >> needs to answer fast enough. > > I don't think an automatically-running trybot is very critical for > this build at the moment. Most of the things that break it are pretty > simple (need to add a file to GYP, or maybe a stub for something) so > the breakage won't be super complicated. Most errors will be caught by > the regular trybots. > > Brett > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
