[chromium-dev] Re: Tab-modal dialogs on the Mac
I'm pretty happy with it. It would be nice to polish things like the missing shadow, but that shouldn't stop us from landing it or adding it to GTM. --Amanda On Fri, May 22, 2009 at 10:16 AM, Avi Drissman wrote: > On Wed, May 20, 2009 at 6:44 PM, Mark Mentovai wrote: >> >> Avi and I found that the Exposé funkiness, present on his Leopard >> machine and my Leopard laptop last week, is all of the sudden gone on >> my Leopard laptop this week. The difference? 10.5.7, most likely. > > Experimenting on various 10.5.6 and 10.5.7 machines leads me to this > conclusion as well. > > I take from the silence that people are pretty happy with this, then. If so, > I'll wind things down with DTS and figure out how to test-ify it for > acceptance into GTM. > > Avi > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
On Wed, May 20, 2009 at 6:44 PM, Mark Mentovai wrote: > Avi and I found that the Exposé funkiness, present on his Leopard > machine and my Leopard laptop last week, is all of the sudden gone on > my Leopard laptop this week. The difference? 10.5.7, most likely. > Experimenting on various 10.5.6 and 10.5.7 machines leads me to this conclusion as well. I take from the silence that people are pretty happy with this, then. If so, I'll wind things down with DTS and figure out how to test-ify it for acceptance into GTM. Avi --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
Avi, this is cool enough that you should do a blog post about it once landed. jrg On Wed, May 20, 2009 at 3:06 PM, Avi Drissman wrote: > OK, this fixes just about everything important. > > Known issues: > - Expose funkiness with 10.5. Since that's fixed in 10.6, that's unlikely > to get attention. > - Window control funkiness, where they appear disabled but aren't. I don't > think that's huge. > - No shadow at the top. Mark cares more than I do. > > Please pound on this hard. I have a DTS incident in (not that I got any > useful advice from it) and I'd like to get back to him within, say, a week > on the off-chance that we find anything and he's willing to give me a hand. > > Avi > > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
Avi Drissman wrote: > OK, this fixes just about everything important. > > Known issues: > - Expose funkiness with 10.5. Since that's fixed in 10.6, that's unlikely to > get attention. Avi and I found that the Exposé funkiness, present on his Leopard machine and my Leopard laptop last week, is all of the sudden gone on my Leopard laptop this week. The difference? 10.5.7, most likely. > - Window control funkiness, where they appear disabled but aren't. I don't > think that's huge. > - No shadow at the top. Mark cares more than I do. I do, true, but it's still not a show-stopper. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
On Wed, May 20, 2009 at 6:06 PM, Avi Drissman wrote: > - Window control funkiness, where they appear disabled but aren't. I don't > think that's huge. Also, they're drawn as enabled while a click on a tab is tracking, but go back to looking disabled on mouseup. Very peculiar. I'll pound on it more after dinner. --Amanda --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
Thanks. So I fiddled with the "hiding sheets" part, and now leave the sheet in place but make it fully transparent. That helps a lot with some expose issues (and all the ones still left are fixed in SL). That leaves the fact that the shouldterminate delegate call is broken and that event handling and fuzzing issues are entirely broken on SL. Unless someone has any thoughts on that, I'm going to drop DTS a call later today. Code's in my experimental directory for anyone wanting to play with it. Avi On Fri, May 8, 2009 at 1:35 PM, Mark Mentovai wrote: > Amanda Walker wrote: > > Yeah. And I have to say, the tab-modal file sheet is very, very cool. > > It would be a shame to lose that capability. > > I agree, I think it'd be worth seeing how polished we can get things > with Avi's POC. It's a cool behavior that has the exact "feel" that > sheet users would expect. > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
Amanda Walker wrote: > Yeah. And I have to say, the tab-modal file sheet is very, very cool. > It would be a shame to lose that capability. I agree, I think it'd be worth seeing how polished we can get things with Avi's POC. It's a cool behavior that has the exact "feel" that sheet users would expect. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
Yeah. And I have to say, the tab-modal file sheet is very, very cool. It would be a shame to lose that capability. --Amanda On Fri, May 8, 2009 at 3:58 PM, Avi Drissman wrote: > The problem with that approach is that you can't cleanly close a sheet in > the general case. If it's our sheet then perhaps that'd work, but for > something like the save file sheet, there's no good way to convince it to > close that isn't more hacky than what I'm doing... > > Avi > > On Fri, May 8, 2009 at 12:44 PM, Scott Hess wrote: >> >> I hate to suggest this, since it's sort of icky (*), but would it make >> sense to instead use regular old sheets, and save/restore state across >> tab switches? I mean so that if the tab is not visible, there is no >> OS-level sheet, there's a state container somewhere in the tab which >> will be restored with the tab. That should short-circuit a lot of >> funky interactions that are broken in places we cannot see them, at a >> cost of making some "for free" stuff not work (we'll have to manually >> manage those interactions). >> >> (*) I don't like icky, but icky where you own the code is preferable >> to icky where you're having to reverse-engineer someone else's code. >> >> -scott >> >> >> On Fri, May 8, 2009 at 11:20 AM, Avi Drissman wrote: >> > On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai wrote: >> >> >> >> Hit "login", then play with Exposé. The "show me my desktop" function >> >> leaves the sheet hanging; the "show me my app's windows" and "show me >> >> all windows" functions send the sheet offscreen. >> > >> > These are all fixed by the system in SL. >> > Unfortunately, everything else is broken in SL. Putting the sheet back >> > leaves it ignoring all mouse input, and when it's hidden the blurring >> > effect >> > on the host window remains. >> > Urgh. >> > I've fiddled around with several approaches and gotten nowhere. I might >> > end >> > up having to use that DTS incident after all... >> > Avi >> > >> > >> > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
The problem with that approach is that you can't cleanly close a sheet in the general case. If it's our sheet then perhaps that'd work, but for something like the save file sheet, there's no good way to convince it to close that isn't more hacky than what I'm doing... Avi On Fri, May 8, 2009 at 12:44 PM, Scott Hess wrote: > I hate to suggest this, since it's sort of icky (*), but would it make > sense to instead use regular old sheets, and save/restore state across > tab switches? I mean so that if the tab is not visible, there is no > OS-level sheet, there's a state container somewhere in the tab which > will be restored with the tab. That should short-circuit a lot of > funky interactions that are broken in places we cannot see them, at a > cost of making some "for free" stuff not work (we'll have to manually > manage those interactions). > > (*) I don't like icky, but icky where you own the code is preferable > to icky where you're having to reverse-engineer someone else's code. > > -scott > > > On Fri, May 8, 2009 at 11:20 AM, Avi Drissman wrote: > > On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai wrote: > >> > >> Hit "login", then play with Exposé. The "show me my desktop" function > >> leaves the sheet hanging; the "show me my app's windows" and "show me > >> all windows" functions send the sheet offscreen. > > > > These are all fixed by the system in SL. > > Unfortunately, everything else is broken in SL. Putting the sheet back > > leaves it ignoring all mouse input, and when it's hidden the blurring > effect > > on the host window remains. > > Urgh. > > I've fiddled around with several approaches and gotten nowhere. I might > end > > up having to use that DTS incident after all... > > Avi > > > > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
I hate to suggest this, since it's sort of icky (*), but would it make sense to instead use regular old sheets, and save/restore state across tab switches? I mean so that if the tab is not visible, there is no OS-level sheet, there's a state container somewhere in the tab which will be restored with the tab. That should short-circuit a lot of funky interactions that are broken in places we cannot see them, at a cost of making some "for free" stuff not work (we'll have to manually manage those interactions). (*) I don't like icky, but icky where you own the code is preferable to icky where you're having to reverse-engineer someone else's code. -scott On Fri, May 8, 2009 at 11:20 AM, Avi Drissman wrote: > On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai wrote: >> >> Hit "login", then play with Exposé. The "show me my desktop" function >> leaves the sheet hanging; the "show me my app's windows" and "show me >> all windows" functions send the sheet offscreen. > > These are all fixed by the system in SL. > Unfortunately, everything else is broken in SL. Putting the sheet back > leaves it ignoring all mouse input, and when it's hidden the blurring effect > on the host window remains. > Urgh. > I've fiddled around with several approaches and gotten nowhere. I might end > up having to use that DTS incident after all... > Avi > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai wrote: > Hit "login", then play with Exposé. The "show me my desktop" function > leaves the sheet hanging; the "show me my app's windows" and "show me > all windows" functions send the sheet offscreen. > These are all fixed by the system in SL. Unfortunately, everything else is broken in SL. Putting the sheet back leaves it ignoring all mouse input, and when it's hidden the blurring effect on the host window remains. Urgh. I've fiddled around with several approaches and gotten nowhere. I might end up having to use that DTS incident after all... Avi --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai wrote: > multisheet > disables x and - (there is no +, but I assume it'd be disabled too). > It shouldn't disable - and +. > I don't think I have control over that. I don't think that Cocoa's support for child windows putting up sheets is quite complete. > > ab-modality in > the face of a closing window seems like it needs some careful thought > and planning. > I added methods to the controller to get the views with tabs and am recommending that any users of the class disallow closing of the window while tabs are up. > (Maybe the right thing to > do, in this case and the window-close case, is to switch to the tab > with the sheet? What if there are multiple sheets open?) If there are multiple sheets open, then it's the job of the app logic to decide what to do. In the simple case that I include, if the current tab has a sheet I leave it up, otherwise I switch to the first tab that has a sheet. The quit case is a little bit nastier. The problem is that when you have a hidden sheet up, -applicationShouldTerminate actually *doesn't get called!*I'm still trying to figure this one out. I think that the tab > control should not be greyed out at all, since it is directly usable. > That's a few hours of futzing with focus issues. For our use cases, is it worth it? After all, we're likely to be using it in cases where we control the drawing of the controls. Punting for now. > Hit "login", then play with Exposé. The "show me my desktop" function > leaves the sheet hanging; the "show me my app's windows" and "show me > all windows" functions send the sheet offscreen. > You forgot to note that if the sheet is hidden and you do a "show app windows" or "show all windows" the fact that I hide the window off-screen wrecks everyone's position. I'm going to have to wrestle with Exposé for that. There's no API to make a window hide from Exposé in Leopard or below and the SPIs I've tried aren't working. I'm going to play with Sno... um, a beta OS to see what I find. Visually, Cocoa sheets have a bit of a shadow at the top, making it > look like they've slid out from the parent window. The multisheet > looks like it slides out of thin air and then just hangs there. > I remember reading that it's a window that does that. I can't convince Cocoa to do that. Visual; punting. Avi --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
I think that this is really cool. Really cool. I asked Avi where this was headed, and he said that if it's headed into GTM then this app will drive development for polish and feedback is welcome. Here are the rough edges I found while playing around with this: When a native sheet is born, the parent window's x button becomes inactive, but its + and - buttons are still usable. multisheet disables x and - (there is no +, but I assume it'd be disabled too). It shouldn't disable - and +. Hit "login", watch the sheet open. Change tabs. The close button (or command-W) is now usable. You can close the window with a sheet hooked up in another tab, which pisses things off pretty badly. You can't quit because there's a live sheet somewhere, and you can't get to the live sheet because the parent window is gone. Tab-modality in the face of a closing window seems like it needs some careful thought and planning. Similarly... Hit "login", watch the sheet open. Change tabs. Press command-Q. All you get is a beep. That's nice, why are you beeping at me? The parent window loses active appearance and, unbeknownst to anyone, the open sheet from the other tab gets focus. (Maybe the right thing to do, in this case and the window-close case, is to switch to the tab with the sheet? What if there are multiple sheets open?) Hit "login", watch the sheet open. The tab bar and parent window are now greyed out. Click on the title bar or on the active (but greyed out) tab. The window itself now gains focus and the tab bar is active. There's something really jarring here. I think that the tab control should not be greyed out at all, since it is directly usable. Hit "login", then play with Exposé. The "show me my desktop" function leaves the sheet hanging; the "show me my app's windows" and "show me all windows" functions send the sheet offscreen. Visually, Cocoa sheets have a bit of a shadow at the top, making it look like they've slid out from the parent window. The multisheet looks like it slides out of thin air and then just hangs there. Mark --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
1. Naming's arbitrary. The name "hanger window" comes from an earlier design idea where the clear window was sized only 10 px high, and was the "hanger" upon which the sheet hung. Once I got the idea that I could also use it to block input to the underlying view, I guess it outgrew the name. (shrug) 2. It was made separable just so I could easily move it from the POC to Chromium, but I'm open to GTMing it. Dave, are there any features you'd like to see? Avi On Thu, May 7, 2009 at 7:49 AM, Mike Pinkerton wrote: > I dig it! NICE! > > It's similar to the overlay window trick we use for tab dragging > between windows. Maybe for consistency you should call the "hanger" > window the "overlay" window? > > Is there any way we can keep this generic and put it into GTM? > > On Thu, May 7, 2009 at 8:46 AM, Amanda Walker wrote: > > That's cleaner than I expected, and the behavior looks right. Nice > > job! I vote for continuing with this approach. > > > > --Amanda > > > > On Thu, May 7, 2009 at 12:17 AM, Avi Drissman wrote: > >> OK, so attached is my proof of concept. The code is pretty clear, though > if > >> you have questions, please let me know. > >> > >> +maf: Your offhand comment about tabs being subwindows led me to this > >> implementation; thanks! > >> +dmac: What do you think? I'll send the DTS incident back to you > tomorrow. > >> > >> Avi > >> > >> On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: > >>> > >>> Having signed up for the login dialog, I'm seeing that it's a pretty > >>> interesting subject. If you try out a page with HTTP auth, you'll see > that > >>> you get what looks like a dialog for the username and password. But if > you > >>> click around, you find that you can switch tabs, and that the dialog is > >>> tab-modal. In fact, the UI test has a test > (LoginPromptTest.TestTwoAuths) to > >>> make sure that you can have two auths going on at once. > >>> > >>> I was thinking about doing this as a sheet, but that's window-modal and > of > >>> less functionality. I can play games with dialogs (making them child > windows > >>> and/or hiding/showing along with the tab) but that gets to be less > Mac/like. > >>> > >>> As I type this I wonder if we can get a sheet to come down under the > tab > >>> bar and hide/show it with the tab. Would that be good UI-wise? > >>> > >>> And of course, I'd probably retrofit the file picker to do that too. > >>> > >>> Thoughts? > >>> > >>> Avi > >> > >> > > > > > > -- > Mike Pinkerton > Mac Weenie > pinker...@google.com > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
I dig it! NICE! It's similar to the overlay window trick we use for tab dragging between windows. Maybe for consistency you should call the "hanger" window the "overlay" window? Is there any way we can keep this generic and put it into GTM? On Thu, May 7, 2009 at 8:46 AM, Amanda Walker wrote: > That's cleaner than I expected, and the behavior looks right. Nice > job! I vote for continuing with this approach. > > --Amanda > > On Thu, May 7, 2009 at 12:17 AM, Avi Drissman wrote: >> OK, so attached is my proof of concept. The code is pretty clear, though if >> you have questions, please let me know. >> >> +maf: Your offhand comment about tabs being subwindows led me to this >> implementation; thanks! >> +dmac: What do you think? I'll send the DTS incident back to you tomorrow. >> >> Avi >> >> On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: >>> >>> Having signed up for the login dialog, I'm seeing that it's a pretty >>> interesting subject. If you try out a page with HTTP auth, you'll see that >>> you get what looks like a dialog for the username and password. But if you >>> click around, you find that you can switch tabs, and that the dialog is >>> tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) to >>> make sure that you can have two auths going on at once. >>> >>> I was thinking about doing this as a sheet, but that's window-modal and of >>> less functionality. I can play games with dialogs (making them child windows >>> and/or hiding/showing along with the tab) but that gets to be less Mac/like. >>> >>> As I type this I wonder if we can get a sheet to come down under the tab >>> bar and hide/show it with the tab. Would that be good UI-wise? >>> >>> And of course, I'd probably retrofit the file picker to do that too. >>> >>> Thoughts? >>> >>> Avi >> >> > -- Mike Pinkerton Mac Weenie pinker...@google.com --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
That's cleaner than I expected, and the behavior looks right. Nice job! I vote for continuing with this approach. --Amanda On Thu, May 7, 2009 at 12:17 AM, Avi Drissman wrote: > OK, so attached is my proof of concept. The code is pretty clear, though if > you have questions, please let me know. > > +maf: Your offhand comment about tabs being subwindows led me to this > implementation; thanks! > +dmac: What do you think? I'll send the DTS incident back to you tomorrow. > > Avi > > On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: >> >> Having signed up for the login dialog, I'm seeing that it's a pretty >> interesting subject. If you try out a page with HTTP auth, you'll see that >> you get what looks like a dialog for the username and password. But if you >> click around, you find that you can switch tabs, and that the dialog is >> tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) to >> make sure that you can have two auths going on at once. >> >> I was thinking about doing this as a sheet, but that's window-modal and of >> less functionality. I can play games with dialogs (making them child windows >> and/or hiding/showing along with the tab) but that gets to be less Mac/like. >> >> As I type this I wonder if we can get a sheet to come down under the tab >> bar and hide/show it with the tab. Would that be good UI-wise? >> >> And of course, I'd probably retrofit the file picker to do that too. >> >> Thoughts? >> >> Avi > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
Yeah, that'd be awesome. Ben Goodger wrote: > I remember Nicholas saying he thought it'd be possible to fabricate a > non-modal sheet like thing. > > -Ben > > On Tue, May 5, 2009 at 3:25 PM, Mark Mentovai wrote: >> The sheet approach or the sheet-look approach? >> >> I like the sheet-look approach, but Cocoa sheets are window-modal, >> which I don't think is all that cool given how we use tabs (or want to >> use tabs). >> >> Mark >> >> Ben Goodger (Google) wrote: >>> The sheet approach sounds fine to me for Mac dialogs. Note also that >>> anything you do should not become app-modal when the tab is selected. >>> >>> On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: Having signed up for the login dialog, I'm seeing that it's a pretty interesting subject. If you try out a page with HTTP auth, you'll see that you get what looks like a dialog for the username and password. But if you click around, you find that you can switch tabs, and that the dialog is tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) to make sure that you can have two auths going on at once. I was thinking about doing this as a sheet, but that's window-modal and of less functionality. I can play games with dialogs (making them child windows and/or hiding/showing along with the tab) but that gets to be less Mac/like. As I type this I wonder if we can get a sheet to come down under the tab bar and hide/show it with the tab. Would that be good UI-wise? And of course, I'd probably retrofit the file picker to do that too. Thoughts? Avi >>> >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
I remember Nicholas saying he thought it'd be possible to fabricate a non-modal sheet like thing. -Ben On Tue, May 5, 2009 at 3:25 PM, Mark Mentovai wrote: > The sheet approach or the sheet-look approach? > > I like the sheet-look approach, but Cocoa sheets are window-modal, > which I don't think is all that cool given how we use tabs (or want to > use tabs). > > Mark > > Ben Goodger (Google) wrote: >> The sheet approach sounds fine to me for Mac dialogs. Note also that >> anything you do should not become app-modal when the tab is selected. >> >> On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: >>> Having signed up for the login dialog, I'm seeing that it's a pretty >>> interesting subject. If you try out a page with HTTP auth, you'll see that >>> you get what looks like a dialog for the username and password. But if you >>> click around, you find that you can switch tabs, and that the dialog is >>> tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) to >>> make sure that you can have two auths going on at once. >>> >>> I was thinking about doing this as a sheet, but that's window-modal and of >>> less functionality. I can play games with dialogs (making them child windows >>> and/or hiding/showing along with the tab) but that gets to be less Mac/like. >>> >>> As I type this I wonder if we can get a sheet to come down under the tab bar >>> and hide/show it with the tab. Would that be good UI-wise? >>> >>> And of course, I'd probably retrofit the file picker to do that too. >>> >>> Thoughts? >>> >>> Avi >>> >>> >>> >>> >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
The sheet approach or the sheet-look approach? I like the sheet-look approach, but Cocoa sheets are window-modal, which I don't think is all that cool given how we use tabs (or want to use tabs). Mark Ben Goodger (Google) wrote: > The sheet approach sounds fine to me for Mac dialogs. Note also that > anything you do should not become app-modal when the tab is selected. > > On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: >> Having signed up for the login dialog, I'm seeing that it's a pretty >> interesting subject. If you try out a page with HTTP auth, you'll see that >> you get what looks like a dialog for the username and password. But if you >> click around, you find that you can switch tabs, and that the dialog is >> tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) to >> make sure that you can have two auths going on at once. >> >> I was thinking about doing this as a sheet, but that's window-modal and of >> less functionality. I can play games with dialogs (making them child windows >> and/or hiding/showing along with the tab) but that gets to be less Mac/like. >> >> As I type this I wonder if we can get a sheet to come down under the tab bar >> and hide/show it with the tab. Would that be good UI-wise? >> >> And of course, I'd probably retrofit the file picker to do that too. >> >> Thoughts? >> >> Avi >> >> >> >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
The sheet approach sounds fine to me for Mac dialogs. Note also that anything you do should not become app-modal when the tab is selected. -Ben On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: > Having signed up for the login dialog, I'm seeing that it's a pretty > interesting subject. If you try out a page with HTTP auth, you'll see that > you get what looks like a dialog for the username and password. But if you > click around, you find that you can switch tabs, and that the dialog is > tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) to > make sure that you can have two auths going on at once. > > I was thinking about doing this as a sheet, but that's window-modal and of > less functionality. I can play games with dialogs (making them child windows > and/or hiding/showing along with the tab) but that gets to be less Mac/like. > > As I type this I wonder if we can get a sheet to come down under the tab bar > and hide/show it with the tab. Would that be good UI-wise? > > And of course, I'd probably retrofit the file picker to do that too. > > Thoughts? > > Avi > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
I need to play with this. It's pretty obvious how this would have been done in Carbon (where you can attach/detach sheets with abandon) but it's less obvious how to do this in Cocoa, where -[NSWindow attachedSheet] implies just one sheet per window, and it's not obvious how to attach a sheet to a window without also running an event loop. The alternative is to create a window in sheet style but attach it ourselves. Then the question is faking the reveal effect. Once again, it's obvious how to do it in Carbon (WindowTransitionEffect) but less so in Cocoa. If anyone has immediate answers let me know. Otherwise I'll see what I can wrestle up. Avi On Tue, May 5, 2009 at 2:43 PM, Amanda Walker wrote: > I'd be worried about flashing/jankiness using a real sheet, but a > child window pinned to the top edge of the tab with the right > transitions might work nicely. There's also some stuff Jeremy was > doing in Gears that involved doing interesting things with login > prompts that may (or may not) be relevant. It would certainly be nice > to keep things tab-modal, even though Cocoa doesn't really grok that > idea. > > --Amanda > > > On Tue, May 5, 2009 at 5:40 PM, Avi Drissman wrote: > > Having signed up for the login dialog, I'm seeing that it's a pretty > > interesting subject. If you try out a page with HTTP auth, you'll see > that > > you get what looks like a dialog for the username and password. But if > you > > click around, you find that you can switch tabs, and that the dialog is > > tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) > to > > make sure that you can have two auths going on at once. > > > > I was thinking about doing this as a sheet, but that's window-modal and > of > > less functionality. I can play games with dialogs (making them child > windows > > and/or hiding/showing along with the tab) but that gets to be less > Mac/like. > > > > As I type this I wonder if we can get a sheet to come down under the tab > bar > > and hide/show it with the tab. Would that be good UI-wise? > > > > And of course, I'd probably retrofit the file picker to do that too. > > > > Thoughts? > > > > Avi > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
I don't think that's important. Avi On Tue, May 5, 2009 at 2:46 PM, Evan Martin wrote: > One question that's been on my mind is how important it is for the > dialog to be draggable. > We can't simultaneously do (normal window title bar) and (constrained > to a tab) on Linux. > A Mac-style "sheet" would be consistent with other tab-related UI like > the find bar. > > On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: > > Having signed up for the login dialog, I'm seeing that it's a pretty > > interesting subject. If you try out a page with HTTP auth, you'll see > that > > you get what looks like a dialog for the username and password. But if > you > > click around, you find that you can switch tabs, and that the dialog is > > tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) > to > > make sure that you can have two auths going on at once. > > > > I was thinking about doing this as a sheet, but that's window-modal and > of > > less functionality. I can play games with dialogs (making them child > windows > > and/or hiding/showing along with the tab) but that gets to be less > Mac/like. > > > > As I type this I wonder if we can get a sheet to come down under the tab > bar > > and hide/show it with the tab. Would that be good UI-wise? > > > > And of course, I'd probably retrofit the file picker to do that too. > > > > Thoughts? > > > > Avi > > > > > > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
I don't think it's important. It actually feels a little weird that it is. On Tue, May 5, 2009 at 2:46 PM, Evan Martin wrote: > > One question that's been on my mind is how important it is for the > dialog to be draggable. > We can't simultaneously do (normal window title bar) and (constrained > to a tab) on Linux. > A Mac-style "sheet" would be consistent with other tab-related UI like > the find bar. > > On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: >> Having signed up for the login dialog, I'm seeing that it's a pretty >> interesting subject. If you try out a page with HTTP auth, you'll see that >> you get what looks like a dialog for the username and password. But if you >> click around, you find that you can switch tabs, and that the dialog is >> tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) to >> make sure that you can have two auths going on at once. >> >> I was thinking about doing this as a sheet, but that's window-modal and of >> less functionality. I can play games with dialogs (making them child windows >> and/or hiding/showing along with the tab) but that gets to be less Mac/like. >> >> As I type this I wonder if we can get a sheet to come down under the tab bar >> and hide/show it with the tab. Would that be good UI-wise? >> >> And of course, I'd probably retrofit the file picker to do that too. >> >> Thoughts? >> >> Avi >> >> > >> > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
One question that's been on my mind is how important it is for the dialog to be draggable. We can't simultaneously do (normal window title bar) and (constrained to a tab) on Linux. A Mac-style "sheet" would be consistent with other tab-related UI like the find bar. On Tue, May 5, 2009 at 2:40 PM, Avi Drissman wrote: > Having signed up for the login dialog, I'm seeing that it's a pretty > interesting subject. If you try out a page with HTTP auth, you'll see that > you get what looks like a dialog for the username and password. But if you > click around, you find that you can switch tabs, and that the dialog is > tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) to > make sure that you can have two auths going on at once. > > I was thinking about doing this as a sheet, but that's window-modal and of > less functionality. I can play games with dialogs (making them child windows > and/or hiding/showing along with the tab) but that gets to be less Mac/like. > > As I type this I wonder if we can get a sheet to come down under the tab bar > and hide/show it with the tab. Would that be good UI-wise? > > And of course, I'd probably retrofit the file picker to do that too. > > Thoughts? > > Avi > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Tab-modal dialogs on the Mac
I'd be worried about flashing/jankiness using a real sheet, but a child window pinned to the top edge of the tab with the right transitions might work nicely. There's also some stuff Jeremy was doing in Gears that involved doing interesting things with login prompts that may (or may not) be relevant. It would certainly be nice to keep things tab-modal, even though Cocoa doesn't really grok that idea. --Amanda On Tue, May 5, 2009 at 5:40 PM, Avi Drissman wrote: > Having signed up for the login dialog, I'm seeing that it's a pretty > interesting subject. If you try out a page with HTTP auth, you'll see that > you get what looks like a dialog for the username and password. But if you > click around, you find that you can switch tabs, and that the dialog is > tab-modal. In fact, the UI test has a test (LoginPromptTest.TestTwoAuths) to > make sure that you can have two auths going on at once. > > I was thinking about doing this as a sheet, but that's window-modal and of > less functionality. I can play games with dialogs (making them child windows > and/or hiding/showing along with the tab) but that gets to be less Mac/like. > > As I type this I wonder if we can get a sheet to come down under the tab bar > and hide/show it with the tab. Would that be good UI-wise? > > And of course, I'd probably retrofit the file picker to do that too. > > Thoughts? > > Avi > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
