[chromium-dev] Re: rev 11763 removes frame pointer from ResourceRequest
I would be in favor of #2 -- retrieving the WebViewDelegate associated with the requestorID. On Mon, Mar 16, 2009 at 5:25 PM, John Abd-El-Malek j...@chromium.org wrote: two questions:1) app cache won't be used with workers, right? or is the goal for XHR requests from workers go through app cache? That would be pretty difficult to do since for example a shared worker isn't associated with any particular renderer. 2) what is the 'context' used for? the requestorID is the ID of the RenderView, so we could add static methods that get a RenderView (or WebViewDelegate) given its id, similar to how we do things in the browser process for RenderViewHost. Why do you need the reference btw? Is there code I can look at? On Mon, Mar 16, 2009 at 2:04 PM, Michael Nordman micha...@google.comwrote: We're going to need some kind of reference to the 'context' for the app cache impl too, i had been depending on the WebFrame ptr for this thusfar, but that won't help us in workers. On Mon, Mar 16, 2009 at 2:01 PM, John Abd-El-Malek j...@chromium.orgwrote: The reason I did it was because in the worker process, there's no frame. Why/where do you need it? On Mon, Mar 16, 2009 at 1:46 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: Hi John, Rev 11763 removes the WebFrame pointer that was previously passed to ResourceLoaderBridge::Create() in simple_resource_loader_bridge.cc. How can I use the new 'routing_id' parameter to retrieve the WebFrame pointer, if any, that originated the request? Thanks, Marshall --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: rev 11763 removes frame pointer from ResourceRequest
My needs in this case are related to the Chromium Embedded Framework (CEF). The code currently works as follows: 1. Retrieve our custom WebViewDelegate instance pointer via the WebFrame pointer passed to ResourceLoaderBridge::Create(). 2. Pass a CefBrowser pointer retrieved from our custom WebViewDelegate instance into the new ResourceLoaderBridgeImpl. 3. During the execution of RequestProxy::AsyncStart() access callbacks provided by CefHandler (retrieved from CefBrowser) to optionally provide alternate data streams, transparently redirect requests, etc. You can view the source code here: http://code.google.com/p/chromiumembedded/source/browse/trunk/libcef/browser_resource_loader_bridge.cc Does chromium currently maintain the relationship between the 'routing_id' parameter and the WebFrame pointer somewhere within the code base, or will we need to add this mapping capability ourselves? Or is there perhaps a completely different approach that CEF should be using to provide this capability? Thanks, Marshall On Mon, Mar 16, 2009 at 4:01 PM, John Abd-El-Malek j...@chromium.org wrote: The reason I did it was because in the worker process, there's no frame. Why/where do you need it? On Mon, Mar 16, 2009 at 1:46 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: Hi John, Rev 11763 removes the WebFrame pointer that was previously passed to ResourceLoaderBridge::Create() in simple_resource_loader_bridge.cc. How can I use the new 'routing_id' parameter to retrieve the WebFrame pointer, if any, that originated the request? Thanks, Marshall --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: rev 11763 removes frame pointer from ResourceRequest
On Mon, Mar 16, 2009 at 4:25 PM, Marshall Greenblatt magreenbl...@gmail.com wrote: My needs in this case are related to the Chromium Embedded Framework (CEF). The code currently works as follows: 1. Retrieve our custom WebViewDelegate instance pointer via the WebFrame pointer passed to ResourceLoaderBridge::Create(). 2. Pass a CefBrowser pointer retrieved from our custom WebViewDelegate instance into the new ResourceLoaderBridgeImpl. 3. During the execution of RequestProxy::AsyncStart() access callbacks provided by CefHandler (retrieved from CefBrowser) to optionally provide alternate data streams, transparently redirect requests, etc. You can view the source code here: http://code.google.com/p/chromiumembedded/source/browse/trunk/libcef/browser_resource_loader_bridge.cc Does chromium currently maintain the relationship between the 'routing_id' parameter and the WebFrame pointer somewhere within the code base, or will we need to add this mapping capability ourselves? Or is there perhaps a completely different approach that CEF should be using to provide this capability? Routing IDs and frames are different things. If I recall correctly, there can be many frames on a page that would share the same routing ID, or in the case that John mentioned, there can be routing IDs but no frame. Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
