Re: [cp-patches] FYI: Socket timeout impl and fix
On May 13, 2006, at 8:14 AM, Michael Koch wrote: On Sat, May 13, 2006 at 05:11:16PM +0200, Sven de Marothy wrote: On Sat, 2006-05-13 at 16:58 +0200, Michael Koch wrote: AFAIK Linux is the only one. If we want to stay portable we need to use select() and wait for the time of the timeout. In libgcj its already handled this way. Thats the safest. Actually, I don't think we need to stay portable though. The JDK docs say: Some non-standard implmentation of this method may ignore the specified timeout. So.. Presumably, Solaris supports it too. But we don't need to though. Anyway, this is still better than before when it didn't work at all :) Well, it will still be broken an most if not all non-Linux Unices. Even on older (2.4 or older) Linuxes it will be broken. For what it's worth, Mac OS X 10.4.6's man page for `setsockopt' claims to support this. But using select is ultimately better, and even better than that is using epoll or kqueue where available. PGP.sig Description: This is a digitally signed message part
[cp-patches] FYI: a small formatting patch
hello all,
the attached patch --already committed-- is a small formatting patch.
2006-05-14 Raif S. Naffah [EMAIL PROTECTED]
* tools/gnu/classpath/tools/jarsigner/Main.java (main): Formatting.
cheers;
rsn
Index: Main.java
===
RCS file: /cvsroot/classpath/classpath/tools/gnu/classpath/tools/jarsigner/Main.java,v
retrieving revision 1.10
diff -u -r1.10 Main.java
--- Main.java 13 May 2006 00:34:57 - 1.10
+++ Main.java 14 May 2006 08:30:01 -
@@ -139,11 +139,11 @@
result = 0;
}
catch (OptionException x)
-{
- System.err.println(x.getMessage()); //$NON-NLS-1$
- if (tool.cmdLineParser != null)
-tool.cmdLineParser.printHelp();
-}
+ {
+System.err.println(x.getMessage()); //$NON-NLS-1$
+if (tool.cmdLineParser != null)
+ tool.cmdLineParser.printHelp();
+ }
catch (SecurityException x)
{
log.throwing(Main.class.getName(), main, x); //$NON-NLS-1$
pgplg79aGxGAx.pgp
Description: PGP signature
Re: [cp-patches] FYI: scatter-gather NIO
Casey == Casey Marshall [EMAIL PROTECTED] writes:
Casey I'm (finally) checking in Michael Barker's patch to better support
Casey socket and pipe channel scatter/gather IO. It seems to work fine for
Casey me on cacao/linux/x86 and jamvm/darwin/x86.
One nit here...
Caseypublic int read (ByteBuffer dst) throws IOException
Casey{
Casey +/*
Casey int result;
Casey byte[] buffer = new byte [dst.remaining ()];
[...]
Casey return result;
Casey +*/
Casey +return ch.read(dst);
Casey}
Just delete code, no need to comment it out.
Tom
Re: [cp-patches] Patch: FYI: implementing missing nio method
Hi Tom, On Sat, 2006-05-13 at 11:15 -0600, Tom Tromey wrote: Mark == Mark Wielaard [EMAIL PROTECTED] writes: 2006-05-01 Tom Tromey [EMAIL PROTECTED] * java/nio/ByteBufferImpl.java (compact): Don't reset position in empty case. Mark This does introduce a mauve regression. Sorry about that. No worries. builder wasn't sending out regression emails. Otherwise we would have caught this sooner. builder is up and running again and is able to send email again now. Mark Could you take a look? Fixed as appended. This is a little bigger than need be, I made it more closely resemble the other compact() implementations. Thanks. I'll also check this in on the release branch. And contrary to what I said on irc this also fixes the 3 mojo regressions we were seeing. Hurray! Thanks, Mark signature.asc Description: This is a digitally signed message part
Re: [cp-patches] Logger initialization regression fix and a little story on security contexts during class initialization
Hi Archie, On Thu, 2006-05-11 at 08:51 -0500, Archie Cobbs wrote: Mark Wielaard wrote: We had an interesting regression with the logging code in GNU Classpath. It wasn't immediately apparent because it was only caused with certain compilers. The class initialization order was subtly different between byte code compiled with gcj -C and jikes. So it didn't show up with gcj -C which I used when committing this code. Since class initialization is strictly defined by the JVM spec, doesn't this necessarily imply a bug in either gcj or jikes? The only other alternative is that they both compile the same code correctly, but do so differenly enough to change the class initialization order, which to me seems even more surprising (but possible I guess.. ?) Yeah, I didn't really investigate further since the issue was real and not just a contrived case in Mauve. We need to make sure that if a class is initialized from a non-trusted environment the static constructor runs correctly. Cheers, Mark signature.asc Description: This is a digitally signed message part
Re: [cp-patches] FYI: Socket timeout impl and fix
On Sun, 2006-05-14 at 00:17 -0700, Casey Marshall wrote: On May 12, 2006, at 2:06 PM, Sven de Marothy wrote: This adds the 1.5 timeout methods in URLConnection and implements them for HttUrlConnection (and HttpsUrlConnection). It also fixes a long-standing bug in the native-target-layer aicas thingie. SO_TIMEOUT timeout was being used as a socket option, when it's the name of the Java socket option. The POSIX constants are SO_SNDTIMEO and SO_RCVTIMEO. So timeouts actually work now. (I could say something nasty here about preprocessor macros.. ) This introduces a warning, and thus doesn't compile with -Werror, and generally doesn't look right (should the operator be `||' and not `|'? Otherwise, you aren't short-circuiting the second call to `setsockopt' if the first fails). Removing the warning just means putting parentheses around the `|' operation. No, '|' is what was intended. My intent is that it should fail if either call returns a nonzero (error) result. I should add a parenthesis though. /Sven
Re: [cp-patches] FYI: fix for PR 27595
Hi Robert, On Sun, 2006-05-14 at 01:20 +0200, Robert Schuster wrote: since this affects the users of 0.91 I would like to have that in the release branch. Added to the release branch. BTW. It is nice to have the Bug number in the ChangeLog entry and not just in the commit message. That way people can quickly grep the ChangeLog for fixed bugs. I added it as follows: 2006-05-14 Robert Schuster [EMAIL PROTECTED] PR classpath/27595 * javax/swing/text/AbstractDocument.java: (insertString): Flipped if-expression and its blocks. (remove): Dito. (replace): Flipped if-expression and its blocks, added note, invoke insertString and remove instead of insertStringImpl and removeImpl. Cheers, Mark signature.asc Description: This is a digitally signed message part
Re: FYI:Regression fix:Re: [cp-patches] FYI:JTree view and navigation fixes during the multiple selection
Hi Audrius, On Sat, 2006-05-13 at 12:08 +0200, Audrius Meskauskas wrote: 2006-05-13 Audrius Meskauskas [EMAIL PROTECTED] * javax/swing/tree/DefaultTreeSelectionModel.java (leadRow): Initialise to -1. Also added to the release branch. Thanks, Mark signature.asc Description: This is a digitally signed message part
Re: [cp-patches] FYI: GNUGlyphVector fixlet
Hi Roman, On Thu, 2006-05-11 at 16:19 +0200, Roman Kennke wrote: 2006-05-11 Roman Kennke [EMAIL PROTECTED] * gnu/java/awt/font/GNUGlyphVector.java (GNUGlyphVector): Don't apply the font renderer context's transform. [...] fontSize = font.getSize2D(); transform = font.getTransform(); // returns a modifiable copy -transform.concatenate(renderContext.getTransform()); +//transform.concatenate(renderContext.getTransform()); } Please just remove non-used code. Or add a comment explaining why it is commented out for now. Cheers, Mark signature.asc Description: This is a digitally signed message part
Re: [cp-patches] Re: FYI: Implement java.awt.print (demo)
On Sat, 2006-05-13 at 17:08 +0200, Sven de Marothy wrote: Here's a little working demo program. This is so cool! It just worked on my little printer here :) Please add a little note about this to the NEWS file. Cheers, Mark signature.asc Description: This is a digitally signed message part
Re: [cp-patches] Patch: SimpleTimeZone fix
Hi Lillian, On Wed, 2006-05-10 at 13:12 -0400, Lillian Angel wrote: I reverted this patch. It caused regressions. I am going to look into the bug I had and try to think of a better solution. 2006-05-10 Lillian Angel [EMAIL PROTECTED] * java/util/SimpleTimeZone.java: Reverted patch. (SimpleTimeZone): Throw exception if startMonth == endMonth. (SimpleTimeZone): Likewise. (checkRule): Rewritten to properly check all values (more efficently). This code is now more stable, at least less buggy than before. Fixed API documentation. (setStartRule): Moved checkRule call to end. (setStartRule): Likewise. (setEndRule): Likewise. (setEndRule): Likewise. Also reverted on the release branch now. Thanks, Mark signature.asc Description: This is a digitally signed message part
Re: [cp-patches] FYI: Socket timeout impl and fix
On May 14, 2006, at 9:08 AM, Sven de Marothy wrote: On Sun, 2006-05-14 at 00:17 -0700, Casey Marshall wrote: On May 12, 2006, at 2:06 PM, Sven de Marothy wrote: This adds the 1.5 timeout methods in URLConnection and implements them for HttUrlConnection (and HttpsUrlConnection). It also fixes a long-standing bug in the native-target-layer aicas thingie. SO_TIMEOUT timeout was being used as a socket option, when it's the name of the Java socket option. The POSIX constants are SO_SNDTIMEO and SO_RCVTIMEO. So timeouts actually work now. (I could say something nasty here about preprocessor macros.. ) This introduces a warning, and thus doesn't compile with -Werror, and generally doesn't look right (should the operator be `||' and not `|'? Otherwise, you aren't short-circuiting the second call to `setsockopt' if the first fails). Removing the warning just means putting parentheses around the `|' operation. No, '|' is what was intended. My intent is that it should fail if either call returns a nonzero (error) result. Yeah, I figured out what you were doing when going to sleep last night ;-) But still, wouldn't an be better for that? PGP.sig Description: This is a digitally signed message part
[cp-patches] FYI: Fix timeout on accepted sockets
Hi, This fixes an issue with timeouts on accepted sockets. Since we aren't using select for timeouts accepted sockets inherit the timeout value of their ServerSocket. This patch resets the timeout to zero. 2006-05-14 Mark Wielaard [EMAIL PROTECTED] PR 27459 * native/jni/java-net/javanet.c (_javanet_accept): Reset the inherited timeout on socket. I also added a Mauve test for this. Committed to trunk and release branch. Cheers, Mark diff -u -r1.33 javanet.c --- native/jni/java-net/javanet.c 6 Feb 2006 07:53:38 - 1.33 +++ native/jni/java-net/javanet.c 14 May 2006 20:01:57 - @@ -835,6 +835,9 @@ } while (result != TARGET_NATIVE_OK); + // Reset the inherited timeout + TARGET_NATIVE_NETWORK_SOCKET_SET_OPTION_SO_TIMEOUT (newfd, 0, result); + /* Populate instance variables */ _javanet_set_int_field (env, impl, gnu/java/net/PlainSocketImpl, native_fd, newfd); signature.asc Description: This is a digitally signed message part
Re: [cp-patches] Fix for DomNode.cloneNode
Hi Chris, On Tue, 2006-05-09 at 15:27 +0100, Chris Burdess wrote: I committed the following patch to work around a problem cloning DOM doctype nodes containing comments and/or PIs reported by Ian Rogers on IRC. 2006-05-09 Chris Burdess [EMAIL PROTECTED] * gnu/xml/dom/DomNode.java: Permit comments and PIs in doctype nodes to be preserved during cloneNode. Since this made an important test-suite work for JikesRVM I have also added it to the release branch. Cheers, Mark signature.asc Description: This is a digitally signed message part
[cp-patches] Patch: FYI: update .cvsignore
This updates .cvsignore in the new plugin directory. Tom 2006-05-14 Tom Tromey [EMAIL PROTECTED] * native/plugin/.cvsignore: Updated. Index: native/plugin/.cvsignore === RCS file: /cvsroot/classpath/classpath/native/plugin/.cvsignore,v retrieving revision 1.1 diff -u -r1.1 .cvsignore --- native/plugin/.cvsignore9 May 2006 18:11:13 - 1.1 +++ native/plugin/.cvsignore14 May 2006 20:29:25 - @@ -1 +1,6 @@ Makefile.in +.deps +.libs +libgcjwebplugin_la-gcjwebplugin.lo +libgcjwebplugin.la +Makefile
[cp-patches] Patch: FYI: jar -i
I'm checking this in.
This adds 'jar -i' support and also fixes some problems here and there
in jar. It also cleans up a couple oddities in related areas that I
noticed while working.
This is PR 27514.
Tom
2006-05-14 Tom Tromey [EMAIL PROTECTED]
PR classpath/27514:
* gnu/java/net/IndexListParser.java (JAR_INDEX_FILE): Renamed. Now
constant.
(JAR_INDEX_VERSION_KEY): Likewise.
(IndexListParser): Updated.
(getVersionInfo): Likewise.
* tools/gnu/classpath/tools/jar/Indexer.java: New file.
* tools/gnu/classpath/tools/jar/Action.java (run): Now throws
OptionException.
* tools/gnu/classpath/tools/jar/Main.java (initializeParser): Handle
-i.
(ModeOption): New constructor.
(parsed): Updated. Use setArchiveFile.
(setArchiveFile): New method.
(run): Handle no-argument case.
(main): Emit --help message on option error.
* tools/gnu/classpath/tools/jar/Updater.java (inputJar): New field.
(createManifest): New method.
(run): Updated. Throws OptionException. Correctly copy zip entry.
* tools/gnu/classpath/tools/jar/Creator.java (createManifest): New
method.
(writeManifest): Removed.
(outputStream): Now a JarOutputStream.
(writeCommandLineEntries): Changed parameters. Updated callers.
(run): Throws OptionException.
* java/util/jar/JarOutputStream.java (putNextEntry): Typo fix.
* java/util/jar/Manifest.java (read): Typo fix.
Index: gnu/java/net/IndexListParser.java
===
RCS file: /cvsroot/classpath/classpath/gnu/java/net/IndexListParser.java,v
retrieving revision 1.1
diff -u -r1.1 IndexListParser.java
--- gnu/java/net/IndexListParser.java 8 May 2006 21:30:06 - 1.1
+++ gnu/java/net/IndexListParser.java 14 May 2006 20:29:21 -
@@ -63,8 +63,9 @@
*/
public class IndexListParser
{
- String filePath = META-INF/INDEX.LIST;
- String versInfo = JarIndex-Version: ;
+ public static final String JAR_INDEX_FILE = META-INF/INDEX.LIST;
+ public static final String JAR_INDEX_VERSION_KEY = JarIndex-Version: ;
+
double versionNumber;
ArrayList headers = new ArrayList();
@@ -80,16 +81,16 @@
try
{
// Parse INDEX.LIST if it exists
-if (jarfile.getEntry(filePath) != null)
+if (jarfile.getEntry(JAR_INDEX_FILE) != null)
{
BufferedReader br = new BufferedReader(new InputStreamReader(new
URL(baseJarURL,
-
filePath).openStream()));
+
JAR_INDEX_FILE).openStream()));
// Must start with version info
String line = br.readLine();
-if (!line.startsWith(versInfo))
+if (!line.startsWith(JAR_INDEX_VERSION_KEY))
return;
-versionNumber =
Double.parseDouble(line.substring(versInfo.length()).trim());
+versionNumber =
Double.parseDouble(line.substring(JAR_INDEX_VERSION_KEY.length()).trim());
// Blank line must be next
line = br.readLine();
@@ -134,7 +135,7 @@
*/
public String getVersionInfo()
{
-return versInfo + getVersionNumber();
+return JAR_INDEX_VERSION_KEY + getVersionNumber();
}
/**
Index: java/util/jar/JarOutputStream.java
===
RCS file: /cvsroot/classpath/classpath/java/util/jar/JarOutputStream.java,v
retrieving revision 1.7
diff -u -r1.7 JarOutputStream.java
--- java/util/jar/JarOutputStream.java 2 Jul 2005 20:32:44 - 1.7
+++ java/util/jar/JarOutputStream.java 14 May 2006 20:29:24 -
@@ -101,7 +101,7 @@
/**
* Prepares the JarOutputStream for writing the next entry.
- * This implementation just calls codesuper.putNextEntre()/code.
+ * This implementation just calls codesuper.putNextEntry()/code.
*
* @param entry The information for the next entry
* @exception IOException when some unexpected I/O exception occurred
Index: java/util/jar/Manifest.java
===
RCS file: /cvsroot/classpath/classpath/java/util/jar/Manifest.java,v
retrieving revision 1.12
diff -u -r1.12 Manifest.java
--- java/util/jar/Manifest.java 25 Mar 2006 11:51:25 - 1.12
+++ java/util/jar/Manifest.java 14 May 2006 20:29:25 -
@@ -1,4 +1,4 @@
-/* Manifest.java -- Reads, writes and manipulaties jar manifest files
+/* Manifest.java -- Reads, writes and manipulates jar manifest files
Copyright (C) 2000, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -152,7 +152,7 @@
}
/**
- * Read and merge a codeMainfest/code from the designated input stream.
+ * Read and merge a codeManifest/code from the designated input stream.
*
* @param
Re: [cp-patches] RFC: ClassLoader reference implementation using getResources
Hi Olivier, On Thu, 2006-05-11 at 15:12 +0200, Olivier Jolly wrote: as proposed yesterday here is a patch proposition which should enable the loading of the core packages even if there is any endorsed jar file with an INDEX.LIST in it. It has the side effect of making those endorsed packages described as being from GNU but allow Jonas to be compiled with classpath. It would be nice to have this patch ported to the release branch if accepted. I didn't put this on the release branch since I have no good way to test it. And since it is all in VMClassLoader which is probably overridden by most runtimes they can add it later. Not saying the patch is bad, just saying that for now I didn't have time to think through all the consequences so I played it safe. Cheers, Mark signature.asc Description: This is a digitally signed message part
[cp-patches] FYI: JMenuItem.java - small API doc fix
This patch (committed) fixes a cut-and-paste error in the API docs for the paramString() method: 2006-05-14 David Gilbert [EMAIL PROTECTED] * javax/swing/JMenuItem.java (paramString): Fixed class name in API doc comment. Regards, Dave Index: javax/swing/JMenuItem.java === RCS file: /sources/classpath/classpath/javax/swing/JMenuItem.java,v retrieving revision 1.29 diff -u -r1.29 JMenuItem.java --- javax/swing/JMenuItem.java 20 Apr 2006 13:09:20 - 1.29 +++ javax/swing/JMenuItem.java 14 May 2006 20:27:04 - @@ -673,7 +673,7 @@ } /** - * Returns a string describing the attributes for the codeJToolTip/code + * Returns a string describing the attributes for the codeJMenuItem/code * component, for use in debugging. The return value is guaranteed to be * non-codenull/code, but the format of the string may vary between * implementations.
[cp-patches] FYI: JCheckBoxMenuItem.paramString()
This patch (committed) improves the debug info provided by the paramString() method
and adds/updates some API doc comments for some other methods in this class:
2006-05-14 David Gilbert [EMAIL PROTECTED]
* javax/swing/JCheckBoxMenuItem.java
(requestFocus): Fixed typo in API docs,
(paramString): Just call super.paramString(),
(getAccessibleContext): Added API docs,
(AccessibleJCheckBoxMenuItem): Likewise.
Regards,
Dave
Index: javax/swing/JCheckBoxMenuItem.java
===
RCS file: /sources/classpath/classpath/javax/swing/JCheckBoxMenuItem.java,v
retrieving revision 1.15
diff -u -r1.15 JCheckBoxMenuItem.java
--- javax/swing/JCheckBoxMenuItem.java 19 Oct 2005 15:45:03 - 1.15
+++ javax/swing/JCheckBoxMenuItem.java 14 May 2006 20:53:27 -
@@ -1,5 +1,5 @@
/* JCheckBoxMenuItem.java --
- Copyright (C) 2002, 2004 Free Software Foundation, Inc.
+ Copyright (C) 2002, 2004, 2006, Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -204,7 +204,7 @@
/**
* This method overrides JComponent.requestFocus with an empty
* implementation, since JCheckBoxMenuItems should not
-* receve focus in general.
+* receive focus in general.
*/
public void requestFocus()
{
@@ -212,16 +212,28 @@
}
/**
- * A string that describes this JCheckBoxMenuItem. Normally only used
- * for debugging.
+ * Returns a string describing the attributes for the
+ * codeJCheckBoxMenuItem/code component, for use in debugging. The
+ * return value is guaranteed to be non-codenull/code, but the format
+ * of the string may vary between implementations.
*
- * @return A string describing this JCheckBoxMenuItem
+ * @return A string describing the attributes of the
+ * codeJCheckBoxMenuItem/code.
*/
protected String paramString()
{
-return JCheckBoxMenuItem;
+// calling super seems to be sufficient to match the reference
+// implementation here...
+return super.paramString();
}
+ /**
+ * Returns the object that provides accessibility features for this
+ * codeJCheckBoxMenuItem/code component.
+ *
+ * @return The accessible context (an instance of
+ * [EMAIL PROTECTED] AccessibleJCheckBoxMenuItem}).
+ */
public AccessibleContext getAccessibleContext()
{
if (accessibleContext == null)
@@ -231,20 +243,29 @@
}
/**
- * Accessibility support for codeJCheckBoxMenuItem/code.
+ * Provides the accessibility features for the
codeJCheckBoxMenuItem/code
+ * component.
+ *
+ * @see JCheckBoxMenuItem#getAccessibleContext()
*/
protected class AccessibleJCheckBoxMenuItem extends AccessibleJMenuItem
{
private static final long serialVersionUID = 1079958073579370777L;
/**
- * Creates a new AccessibleJCheckBoxMenuItem object.
+ * Creates a new codeAccessibleJCheckBoxMenuItem/code instance.
*/
protected AccessibleJCheckBoxMenuItem()
{
// Nothing to do here.
}
+/**
+ * Returns the accessible role for the codeJCheckBoxMenuItem/code
+ * component.
+ *
+ * @return [EMAIL PROTECTED] AccessibleRole#CHECK_BOX}.
+ */
public AccessibleRole getAccessibleRole()
{
return AccessibleRole.CHECK_BOX;
[cp-patches] Re: GConf-backend for java.util.prefs
Il giorno dom, 14/05/2006 alle 11.34 -0400, Thomas Fitzsimmons ha scritto: Hi, Mario Torre wrote: As a side note, these directory can be configured at runtime by setting one of these two properties: java.util.prefs.gconf.user_root java.util.prefs.gconf.system_root Since these are GNU-specific properties, they should probably be prefixed with gnu.. Tom Hi I don't know if they are really GNU-specific, as the backend can be used also in non-GNU java implementation, having a common runtime property in this case is important. Anyway, I don't really see problems here to prefix gnu. to the properties. I attach the full backend patch with the properties changed to: gnu.java.util.prefs.gconf.user_root gnu.java.util.prefs.gconf.system_root The ChangeLog is the same, as the patch has not been committed to cvs: 2006-05-12 Mario Torre [EMAIL PROTECTED] * gnu/java/util/prefs/GConfBasedPreferences.java: new class. * gnu/java/util/prefs/GConfBasedFactory.java: new class. * gnu/java/util/prefs/gconf/GConfNativePeer.java: new class. * gnu_java_util_prefs_gconf_GConfNativePeer.h: generated header file. * classpath/native/jni/gconf-peer/GConfNativePeer.c: new C file. * configure.ac: update to introduce new files. Added options to build gconf native peer used by the GConf preference backend. * include/Makefile.am: update to introduce new files. * native/jni/Makefile.am update to introduce new files. * scripts/check_jni_methods.sh: added three new ignored file from check. * native/jni/gconf-peer/Makefile.am: new Makefile needed to build gconf-peer shared library. After (and if) it is committed to cvs, I'll post on the mauve list a couple of simple tests for the preference api. Mario -- Lima Software, SO.PR.IND. s.r.l. http://www.limasoftware.net/ pgp key: http://subkeys.pgp.net/ Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ gconf-preference-backend.patch.tar.gz Description: application/compressed-tar
[cp-patches] Patch: FYI: minor jar tweak
I'm checking this in.
This cleans up a tiny detail in the jar -i support.
It also makes it invalid to specify both -M and -m.
Tom
2006-05-14 Tom Tromey [EMAIL PROTECTED]
* tools/gnu/classpath/tools/jar/Indexer.java
(writeCommandLineEntries): Simplify insertion.
* tools/gnu/classpath/tools/jar/Main.java (run): Don't allow both
-m and -M.
Index: tools/gnu/classpath/tools/jar/Indexer.java
===
RCS file:
/cvsroot/classpath/classpath/tools/gnu/classpath/tools/jar/Indexer.java,v
retrieving revision 1.1
diff -u -r1.1 Indexer.java
--- tools/gnu/classpath/tools/jar/Indexer.java 14 May 2006 20:38:32 -
1.1
+++ tools/gnu/classpath/tools/jar/Indexer.java 14 May 2006 20:43:23 -
@@ -127,8 +127,9 @@
indexJarFile(contents, parameters.archiveFile, parameters.verbose);
if (contents.length() != 0)
{
-contents.insert(0, (IndexListParser.JAR_INDEX_VERSION_KEY
-+ 1.0\n\n));
+// Insert in reverse order to avoid computing anything.
+contents.insert(0, 1.0\n\n);
+contents.insert(0, IndexListParser.JAR_INDEX_VERSION_KEY);
ByteArrayInputStream in
= new ByteArrayInputStream(contents.toString().getBytes());
writeFile(false, in, IndexListParser.JAR_INDEX_FILE,
parameters.verbose);
Index: tools/gnu/classpath/tools/jar/Main.java
===
RCS file: /cvsroot/classpath/classpath/tools/gnu/classpath/tools/jar/Main.java,v
retrieving revision 1.3
diff -u -r1.3 Main.java
--- tools/gnu/classpath/tools/jar/Main.java 14 May 2006 20:38:32 -
1.3
+++ tools/gnu/classpath/tools/jar/Main.java 14 May 2006 20:43:23 -
@@ -217,6 +217,8 @@
throw new OptionException(must specify one of -t, -c, -u, -x, or -i);
if (changedDirectory != null)
throw new OptionException(-C argument requires both directory and
filename);
+if (! wantManifest manifestFile != null)
+ throw new OptionException(can't specify both -m and -M);
Action t = (Action) operationMode.newInstance();
t.run(this);
}
[cp-patches] Patch: RFC: splitting up URLClassLoader
I'm posting this for comments.
In libgcj we have a divergence in URLClassLoader, because we have
other ways to load classes. In particular we can extract classes
from shared libraries via 'gcjlib' URLs, and URLClassLoader knows
about this.
I'd like to re-merge here so that we have one less divergence to carry
around.
This patch allows this by moving the URLLoader class, and friends, to
gnu.java.net.loader. Then it changes URLClassLoader to look for
other loaders via reflection. This will let us add new URLLoader
subclasses in the libgcj tree and have things work properly.
Tom
2006-05-14 Tom Tromey [EMAIL PROTECTED]
* java/net/URLClassLoader.java: Moved inner classes to
gnu.java.net.loader.
(factoryCache): Changed type.
(URL_LOADER_PREFIX): New constant.
(URLClassLoader): Updated for new factoryCache.
(addURLImpl): Use reflection to search for a loader.
(findClass): Use getClass method on URLLoader.
(getURLStreamHandler): Removed.
* gnu/java/net/loader/URLLoader.java: New file, extracted
from URLClasLoader.
* gnu/java/net/loader/Resource.java: Likewise.
* gnu/java/net/loader/FileResource.java: Likewise.
* gnu/java/net/loader/FileURLLoaderjava: Likewise.
* gnu/java/net/loader/JarURLLoader.java: Likewise.
* gnu/java/net/loader/JarURLResource.java: Likewise.
* gnu/java/net/loader/RemoteURLLoader.java: Likewise.
* gnu/java/net/loader/RemoteResource.java: Likewise.
* gnu/java/net/loader/ULRStreamHandlerCache.java: New file.
Index: java/net/URLClassLoader.java
===
RCS file: /cvsroot/classpath/classpath/java/net/URLClassLoader.java,v
retrieving revision 1.49
diff -u -r1.49 URLClassLoader.java
--- java/net/URLClassLoader.java8 May 2006 21:30:06 - 1.49
+++ java/net/URLClassLoader.java14 May 2006 21:12:13 -
@@ -39,15 +39,21 @@
package java.net;
-import gnu.java.net.IndexListParser;
+import gnu.java.net.loader.FileURLLoader;
+import gnu.java.net.loader.JarURLLoader;
+import gnu.java.net.loader.RemoteURLLoader;
+import gnu.java.net.loader.Resource;
+import gnu.java.net.loader.URLLoader;
+import gnu.java.net.loader.URLStreamHandlerCache;
import java.io.ByteArrayOutputStream;
import java.io.EOFException;
import java.io.File;
-import java.io.FileInputStream;
import java.io.FilePermission;
import java.io.IOException;
import java.io.InputStream;
+import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
import java.security.AccessControlContext;
import java.security.AccessController;
import java.security.CodeSource;
@@ -55,15 +61,11 @@
import java.security.PrivilegedAction;
import java.security.SecureClassLoader;
import java.security.cert.Certificate;
-import java.util.ArrayList;
import java.util.Enumeration;
import java.util.HashMap;
import java.util.Iterator;
-import java.util.StringTokenizer;
import java.util.Vector;
import java.util.jar.Attributes;
-import java.util.jar.JarEntry;
-import java.util.jar.JarFile;
import java.util.jar.Manifest;
@@ -139,9 +141,15 @@
/**
* A cache to store mappings between handler factory and its
* private protocol handler cache (also a HashMap), so we can avoid
- * create handlers each time the same protocol comes.
+ * creating handlers each time the same protocol comes.
*/
- private static HashMap factoryCache = new HashMap(5);
+ private static URLStreamHandlerCache factoryCache
+= new URLStreamHandlerCache();
+
+ /**
+ * The prefix for URL loaders.
+ */
+ private static final String URL_LOADER_PREFIX = gnu.java.net.loader.Load_;
// Instance variables
@@ -169,494 +177,6 @@
// Helper classes
/**
- * A codeURLLoader/code contains all logic to load resources from a
- * given base codeURL/code.
- */
- abstract static class URLLoader
- {
-/**
- * Our classloader to get info from if needed.
- */
-final URLClassLoader classloader;
-
-/**
- * The base URL from which all resources are loaded.
- */
-final URL baseURL;
-
-/**
- * A codeCodeSource/code without any associated certificates.
- * It is common for classes to not have certificates associated
- * with them. If they come from the same codeURLLoader/code
- * then it is safe to share the associated codeCodeSource/code
- * between them since codeCodeSource/code is immutable.
- */
-final CodeSource noCertCodeSource;
-
-URLLoader(URLClassLoader classloader, URL baseURL)
-{
- this(classloader, baseURL, baseURL);
-}
-
-URLLoader(URLClassLoader classloader, URL baseURL, URL overrideURL)
-{
- this.classloader = classloader;
- this.baseURL = baseURL;
- this.noCertCodeSource = new CodeSource(overrideURL, null);
-}
-
-/**
- * Returns a codeResource/code loaded by this
- *
Re: [cp-patches] FYI: Socket timeout impl and fix
On Sun, 2006-05-14 at 12:45 -0700, Casey Marshall wrote: Yeah, I figured out what you were doing when going to sleep last night ;-) But still, wouldn't an be better for that? if( callA() == 0 callB() == 0 ) result = value1; else result = value2; Versus: result = ((callA() | callB()) == 0) ? value1 : value2; See? Shorter code! ;) -- Sven de Marothy [EMAIL PROTECTED]
Re: [cp-patches] FYI: Socket timeout impl and fix
On May 14, 2006, at 2:40 PM, Sven de Marothy wrote: On Sun, 2006-05-14 at 12:45 -0700, Casey Marshall wrote: Yeah, I figured out what you were doing when going to sleep last night ;-) But still, wouldn't an be better for that? if( callA() == 0 callB() == 0 ) result = value1; else result = value2; Versus: result = ((callA() | callB()) == 0) ? value1 : value2; See? Shorter code! ;) Hmm? result = (!callA() !callB()) ? value1 : value2; The should also short-circuit the call to callB() if callA() fails, which is probably what you want. But this is getting really nit-picky, and I don't care that much :-) PGP.sig Description: This is a digitally signed message part
[cp-patches] FYI: added CACAO to list of VMs
Hi! Edwin mentioned that CACAO isn't listed in the README. So, here it goes. @mark: maybe you can backport this to the release branch. TWISTI 2006-05-15 Christian Thalinger [EMAIL PROTECTED] * README: Added CACAO to list of VMs. Index: README === RCS file: /cvsroot/classpath/classpath/README,v retrieving revision 1.17 diff -u -3 -p -r1.17 README --- README 2 Sep 2005 03:44:12 - 1.17 +++ README 14 May 2006 22:35:08 - @@ -1,4 +1,4 @@ -GNU Classpath README - Last updated: August 31, 2005 +GNU Classpath README - Last updated: May 15, 2006 GNU Classpath, Essential Libraries for Java is a project to create a free software implementation of the core class libraries for the java @@ -29,6 +29,7 @@ Smaller environments (runtime only, no c with this GNU Classpath releases include (tested by and recommended for GNU Classpath hackers): + * CACAO (http://www.cacaojvm.org/) * JamVM (http://jamvm.sourceforge.net/) * Jikes RVM (http://www.ibm.com/developerworks/oss/jikesrvm/) * Kissme(http://kissme.sourceforge.net/)
[cp-patches] FYI: More AWT printing
This implements cancellable jobs, proper support for Pageable and also
reverse landscape. Whatever people want that for.
It's still slow of course.
/Sven
2006-05-15 Sven de Marothy [EMAIL PROTECTED]
* gnu/java/awt/print/JavaPrinterGraphics.java:
Sweeping changes I can't be bothered to document in detail.
* gnu/java/awt/print/JavaPrinterJob.java
(getPageAttributes): New method.
(setPageable,cancel,isCancelled): Implement.
Index: gnu/java/awt/print/JavaPrinterGraphics.java
===
RCS file: /sources/classpath/classpath/gnu/java/awt/print/JavaPrinterGraphics.java,v
retrieving revision 1.3
diff -U3 -r1.3 JavaPrinterGraphics.java
--- gnu/java/awt/print/JavaPrinterGraphics.java 13 May 2006 17:06:38 - 1.3
+++ gnu/java/awt/print/JavaPrinterGraphics.java 15 May 2006 01:35:09 -
@@ -37,6 +37,7 @@
package gnu.java.awt.print;
+import java.awt.print.Pageable;
import java.awt.print.PrinterGraphics;
import java.awt.print.Printable;
import java.awt.print.PrinterJob;
@@ -85,11 +86,6 @@
private PrinterJob printerJob;
/**
- * The paper format.
- */
- PageFormat pageFormat;
-
- /**
* Rendering resolution
*/
private static final double DPI = 72.0;
@@ -104,66 +100,96 @@
*/
private Image image;
- public JavaPrinterGraphics( PrinterJob printerJob, PageFormat pageFormat )
+ public JavaPrinterGraphics( PrinterJob printerJob )
{
this.printerJob = printerJob;
-this.pageFormat = pageFormat;
-
-// Create a really big image and draw to that.
-xSize = (int)(DPI*pageFormat.getWidth()/72.0);
-ySize = (int)(DPI*pageFormat.getHeight()/72.0);
-
-// FIXME: This should at least be BufferedImage. Fix once we have a working B.I.
-// Graphics2D should also be supported of course.
-image = new GtkImage(xSize, ySize);
-
-initImage();
}
/**
- * The only method worthy of mention here.
+ * Spool a document to PostScript.
+ * If Pageable is non-null, it will print that, otherwise it will use
+ * the supplied printable and pageFormat.
*/
- public SpooledDocument spoolPostScript(Printable p)
+ public SpooledDocument spoolPostScript(Printable printable,
+ PageFormat pageFormat,
+ Pageable pageable)
throws PrinterException
- {
- try
- {
- // spool to a temporary file
- File temp = File.createTempFile(cpspool, .ps);
- temp.deleteOnExit();
-
- PrintWriter out = new PrintWriter
- (new BufferedWriter
+ {
+try
+ {
+ // spool to a temporary file
+ File temp = File.createTempFile(cpspool, .ps);
+ temp.deleteOnExit();
+
+ PrintWriter out = new PrintWriter
+ (new BufferedWriter
(new OutputStreamWriter
(new FileOutputStream(temp), ISO8859_1), 100));
- writePSHeader(out);
- int status;
- int index = 0;
- while(p.print(this, pageFormat, index++) == Printable.PAGE_EXISTS)
- {
- g.dispose();
- g = null;
- writePage( out );
- initImage();
- }
-
+ writePSHeader(out);
+
+ if(pageable != null)
+ {
+ for(int index = 0; index pageable.getNumberOfPages(); index++)
+ spoolPage(out, pageable.getPrintable(index),
+ pageable.getPageFormat(index), index);
+ }
+ else
+ {
+ int index = 0;
+ while(spoolPage(out, printable, pageFormat, index++) ==
+ Printable.PAGE_EXISTS);
+ }
out.println(%%Trailer);
- out.println(grestore % restore original stuff);
out.println(%%EOF);
out.close();
return new SpooledDocument( temp );
}
- catch (IOException e)
- {
- PrinterException pe = new PrinterException();
- pe.initCause(e);
- throw pe;
- }
- }
+catch (IOException e)
+ {
+ PrinterException pe = new PrinterException();
+ pe.initCause(e);
+ throw pe;
+ }
+ }
- private void initImage()
+ /**
+ * Spools a single page, returns NO_SUCH_PAGE unsuccessful,
+ * PAGE_EXISTS if it was.
+ */
+ public int spoolPage(PrintWriter out,
+ Printable printable,
+ PageFormat pageFormat,
+ int index) throws IOException, PrinterException
+ {
+initImage( pageFormat );
+if(printable.print(this, pageFormat, index) == Printable.NO_SUCH_PAGE)
+ return Printable.NO_SUCH_PAGE;
+g.dispose();
+g = null;
+writePage( out, pageFormat );
+return Printable.PAGE_EXISTS;
+ }
+
+ private void initImage(PageFormat pageFormat)
{
+// Create a really big image and draw to that.
+xSize = (int)(DPI*pageFormat.getWidth()/72.0);
+ySize = (int)(DPI*pageFormat.getHeight()/72.0);
+
+// Swap X and Y sizes if it's a Landscape page.
+if( pageFormat.getOrientation() != PageFormat.PORTRAIT )
+ {
+ int t = xSize;
+ xSize = ySize;
+ ySize = t;
+ }
+
+// FIXME: This should at least be BufferedImage.
+// Fix once we have a working B.I.
+// Graphics2D should also be supported of course.
+image = new GtkImage(xSize, ySize);
+
[cp-patches] Patch: FYI: minor printing fix
I updated before preparing a different patch, and eclipse complained
about JavaPrinterJob. This fixes the assignment, which, previously,
did nothing. It also cleans up the imports.
Tom
2006-05-14 Tom Tromey [EMAIL PROTECTED]
* gnu/java/awt/print/JavaPrinterJob.java (setPrintable): Fixed
assignment.
Index: gnu/java/awt/print/JavaPrinterJob.java
===
RCS file: /cvsroot/classpath/classpath/gnu/java/awt/print/JavaPrinterJob.java,v
retrieving revision 1.2
diff -u -r1.2 JavaPrinterJob.java
--- gnu/java/awt/print/JavaPrinterJob.java 15 May 2006 01:40:32 -
1.2
+++ gnu/java/awt/print/JavaPrinterJob.java 15 May 2006 01:52:14 -
@@ -38,33 +38,29 @@
package gnu.java.awt.print;
-import java.util.Locale;
import java.awt.HeadlessException;
+import java.awt.print.PageFormat;
import java.awt.print.Pageable;
import java.awt.print.Printable;
-import java.awt.print.PrinterGraphics;
-import java.awt.print.Book;
-import java.awt.print.PageFormat;
-import java.awt.print.Paper;
-import java.awt.print.PrinterJob;
-import java.awt.print.PrinterAbortException;
import java.awt.print.PrinterException;
+import java.awt.print.PrinterJob;
+import java.util.Locale;
+
import javax.print.CancelablePrintJob;
-import javax.print.PrintService;
-import javax.print.PrintServiceLookup;
import javax.print.DocFlavor;
import javax.print.DocPrintJob;
import javax.print.PrintException;
-import javax.print.StreamPrintServiceFactory;
+import javax.print.PrintService;
+import javax.print.PrintServiceLookup;
import javax.print.ServiceUI;
+import javax.print.attribute.HashPrintRequestAttributeSet;
import javax.print.attribute.IntegerSyntax;
-import javax.print.attribute.TextSyntax;
import javax.print.attribute.PrintRequestAttributeSet;
-import javax.print.attribute.HashPrintRequestAttributeSet;
+import javax.print.attribute.TextSyntax;
import javax.print.attribute.standard.Copies;
import javax.print.attribute.standard.JobName;
-import javax.print.attribute.standard.RequestingUserName;
import javax.print.attribute.standard.OrientationRequested;
+import javax.print.attribute.standard.RequestingUserName;
/**
* This is the default implementation of PrinterJob
@@ -370,7 +366,7 @@
public void setPrintable(Printable printable, PageFormat page_format)
{
this.printable = printable;
-this.pageFormat = pageFormat;
+this.pageFormat = page_format;
}
/**
[cp-patches] Patch: FYI: getopt option validation
I'm checking this in.
jar had an error-printing case that was redundant with some code in
getopt. This particular code just prints a message about using
'--help' when the user uses bad command-line options, so it seemed
best to push this into a validate() method on Parser.
This patch also updates jar to clean up the mess.
Other tools ought to use this as appropriate.
Tom
2006-05-14 Tom Tromey [EMAIL PROTECTED]
* tools/gnu/classpath/tools/jar/Updater.java (run): No longer throws
OptionException.
* tools/gnu/classpath/tools/jar/Creator.java (run): No longer throws
OptionException.
* tools/gnu/classpath/tools/jar/Action.java (run): No longer throws
OptionException.
* tools/gnu/classpath/tools/jar/Indexer.java (run): Removed. Moved
validation to JarParser.
* tools/gnu/classpath/tools/jar/Main.java (JarParser): New class.
(run): Moved validation to JarParser. Don't throw OptionException.
(initializeParser): Create a JarParser.
(main): Don't catch OptionException.
* tools/gnu/classpath/tools/getopt/Parser.java (printHelp): No longer
public.
(validate): New method.
(parse): Call it. Print '-help' in error message when long-only.
Index: tools/gnu/classpath/tools/getopt/Parser.java
===
RCS file:
/cvsroot/classpath/classpath/tools/gnu/classpath/tools/getopt/Parser.java,v
retrieving revision 1.5
diff -u -r1.5 Parser.java
--- tools/gnu/classpath/tools/getopt/Parser.java10 May 2006 21:00:43
- 1.5
+++ tools/gnu/classpath/tools/getopt/Parser.java15 May 2006 01:52:17
-
@@ -250,7 +250,7 @@
this.printHelp(System.out);
}
- protected void printHelp(PrintStream out)
+ void printHelp(PrintStream out)
{
if (headerText != null)
{
@@ -275,6 +275,26 @@
formatText(out, footerText);
}
+ /**
+ * This method can be overridden by subclassses to provide some option
+ * validation. It is called by the parser after all options have been
+ * parsed. If an option validation problem is encountered, this should
+ * throw an [EMAIL PROTECTED] OptionException} whose message should be shown
to
+ * the user.
+ * p
+ * It is better to do validation here than after [EMAIL PROTECTED]
#parse(String[])}
+ * returns, because the parser will print a message referring the
+ * user to the code--help/code option.
+ * p
+ * The base implementation does nothing.
+ *
+ * @throws OptionException the error encountered
+ */
+ protected void validate() throws OptionException
+ {
+// Base implementation does nothing.
+ }
+
private String getArgument(String request) throws OptionException
{
++currentIndex;
@@ -380,12 +400,15 @@
// Add remaining arguments to leftovers.
for (++currentIndex; currentIndex args.length; ++currentIndex)
files.notifyFile(args[currentIndex]);
+// See if something went wrong.
+validate();
}
catch (OptionException err)
{
System.err.println(programName + : + err.getMessage());
System.err.println(programName + : Try ' + programName
- + --help' for more information.);
+ + + (longOnly ? -help : --help)
+ + ' for more information.);
System.exit(1);
}
}
Index: tools/gnu/classpath/tools/jar/Action.java
===
RCS file:
/cvsroot/classpath/classpath/tools/gnu/classpath/tools/jar/Action.java,v
retrieving revision 1.2
diff -u -r1.2 Action.java
--- tools/gnu/classpath/tools/jar/Action.java 14 May 2006 20:38:32 -
1.2
+++ tools/gnu/classpath/tools/jar/Action.java 15 May 2006 01:52:17 -
@@ -38,8 +38,6 @@
package gnu.classpath.tools.jar;
-import gnu.classpath.tools.getopt.OptionException;
-
import java.io.IOException;
public abstract class Action
@@ -49,5 +47,5 @@
}
public abstract void run(Main parameters)
-throws IOException, OptionException;
+throws IOException;
}
Index: tools/gnu/classpath/tools/jar/Creator.java
===
RCS file:
/cvsroot/classpath/classpath/tools/gnu/classpath/tools/jar/Creator.java,v
retrieving revision 1.3
diff -u -r1.3 Creator.java
--- tools/gnu/classpath/tools/jar/Creator.java 14 May 2006 20:38:32 -
1.3
+++ tools/gnu/classpath/tools/jar/Creator.java 15 May 2006 01:52:17 -
@@ -38,8 +38,6 @@
package gnu.classpath.tools.jar;
-import gnu.classpath.tools.getopt.OptionException;
-
import java.io.BufferedOutputStream;
import java.io.ByteArrayOutputStream;
import java.io.File;
@@ -222,7 +220,7 @@
outputStream.close();
}
- public void run(Main parameters) throws IOException, OptionException
+ public void run(Main parameters) throws
Re: [cp-patches] FYI: jarsigner now uses getopt parser
Raif == Raif S Naffah [EMAIL PROTECTED] writes:
Raif the attached patch --already committed-- replaces command line parsing
Raif in the jarsigner tool with the newly added getopt classes.
I have a few comments on this.
Raifprivate Main()
[...]
Raif try
Raif{
Raif tool.processArgs(args);
Raif tool.start();
Raif +result = 0;
Raif}
Raif +catch (OptionException x)
Raif +{
Raif + System.err.println(x.getMessage()); //$NON-NLS-1$
Raif + if (tool.cmdLineParser != null)
Raif +tool.cmdLineParser.printHelp();
Raif +}
Generally speaking GNU tools do not print --help output in response
to an error. Instead they typically just print a short error message
and a note to try --help.
Parser will do this for you automatically now; I recommend
implementing the new validate() method to do post-parsing option
checks.
Raifprivate void processArgs(String[] args) throws Exception
Raif if (args == null || args.length == 0)
Raif - HelpPrinter.printHelpAndExit(HELP_PATH);
Raif + throw new OptionException(Messages.getString(Main.133));
//$NON-NLS-1$
E.g., do this kind of thing in validate().
Also, I noticed that keytool isn't really using the new parser -- just
the help printer. Is there a way we can extend the parser to handle
the cases needed by keytool? Honestly I'd prefer not to export the
printHelp functionality from the parser, and this seems to be the only
external user. Also, since getopt really exists only for classpath
tools, it would be better to just extend it as needed to do what we
really want. (BTW if we're going to export the printHelp method, it
ought to have javadoc -- I'm trying to document all the exposed API of
getopt.)
Tom
[cp-patches] FYI: JFileChooser.paramString()
This patch (committed) reimplements the paramString() method to provide better
debugging info, and adds API docs that were missing for a couple of methods:
2006-05-15 David Gilbert [EMAIL PROTECTED]
* javax/swing/JFileChooser.java
(paramString): Reimplemented,
(getAccessibleContext): Updated API docs,
(AccessibleJFileChooser): Added API docs.
Regards,
Dave
Index: javax/swing/JFileChooser.java
===
RCS file: /sources/classpath/classpath/javax/swing/JFileChooser.java,v
retrieving revision 1.30
diff -u -r1.30 JFileChooser.java
--- javax/swing/JFileChooser.java 10 Apr 2006 10:19:28 - 1.30
+++ javax/swing/JFileChooser.java 15 May 2006 04:47:25 -
@@ -1,5 +1,5 @@
/* JFileChooser.java --
- Copyright (C) 2002, 2004, 2005 Free Software Foundation, Inc.
+ Copyright (C) 2002, 2004, 2005, 2006, Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -1514,19 +1514,60 @@
}
/**
- * DOCUMENT ME!
+ * Returns a string describing the attributes for the
+ * codeJFileChooser/code component, for use in debugging. The return
+ * value is guaranteed to be non-codenull/code, but the format of the
+ * string may vary between implementations.
*
- * @return DOCUMENT ME!
+ * @return A string describing the attributes of the
+ * codeJFileChooser/code.
*/
protected String paramString()
{
-return JFileChooser;
+StringBuffer sb = new StringBuffer(super.paramString());
+sb.append(,approveButtonText=);
+if (approveButtonText != null)
+ sb.append(approveButtonText);
+sb.append(,currentDirectory=);
+if (currentDir != null)
+ sb.append(currentDir);
+sb.append(,dialogTitle=);
+if (dialogTitle != null)
+ sb.append(dialogTitle);
+sb.append(,dialogType=);
+if (dialogType == OPEN_DIALOG)
+ sb.append(OPEN_DIALOG);
+if (dialogType == SAVE_DIALOG)
+ sb.append(SAVE_DIALOG);
+if (dialogType == CUSTOM_DIALOG)
+ sb.append(CUSTOM_DIALOG);
+sb.append(,fileSelectionMode=);
+if (fileSelectionMode == FILES_ONLY)
+ sb.append(FILES_ONLY);
+if (fileSelectionMode == DIRECTORIES_ONLY)
+ sb.append(DIRECTORIES_ONLY);
+if (fileSelectionMode == FILES_AND_DIRECTORIES)
+ sb.append(FILES_AND_DIRECTORIES);
+sb.append(,returnValue=);
+if (retval == APPROVE_OPTION)
+ sb.append(APPROVE_OPTION);
+if (retval == CANCEL_OPTION)
+ sb.append(CANCEL_OPTION);
+if (retval == ERROR_OPTION)
+ sb.append(ERROR_OPTION);
+sb.append(,selectedFile=);
+if (selectedFile != null)
+ sb.append(selectedFile);
+sb.append(,useFileHiding=).append(fileHiding);
+return sb.toString();
}
/**
- * Returns the accessible context.
+ * Returns the object that provides accessibility features for this
+ * codeJFileChooser/code component.
*
- * @return The accessible context.
+ * @return The accessible context (an instance of
+ * [EMAIL PROTECTED] AccessibleJFileChooser}).
*/
public AccessibleContext getAccessibleContext()
{
@@ -1536,16 +1577,26 @@
}
/**
- * Accessibility support for JFileChooser
+ * Provides the accessibility features for the codeJFileChooser/code
+ * component.
*/
protected class AccessibleJFileChooser
extends JComponent.AccessibleJComponent
{
+/**
+ * Creates a new instance of codeAccessibleJFileChooser/code.
+ */
protected AccessibleJFileChooser()
{
// Nothing to do here.
}
+/**
+ * Returns the accessible role for the codeJFileChooser/code
+ * component.
+ *
+ * @return [EMAIL PROTECTED] AccessibleRole#FILE_CHOOSER}.
+ */
public AccessibleRole getAccessibleRole()
{
return AccessibleRole.FILE_CHOOSER;
[cp-patches] FYI: JTabbedPane.paramString()
This patch (committed) reimplements the paramString() method to provide better
debugging info:
2006-05-15 David Gilbert [EMAIL PROTECTED]
* javax/swing/JTabbedPane.java
(paramString): Reimplemented,
(getAccessibleContext): Added API docs.
Regards,
Dave
Index: javax/swing/JTabbedPane.java
===
RCS file: /sources/classpath/classpath/javax/swing/JTabbedPane.java,v
retrieving revision 1.37
diff -u -r1.37 JTabbedPane.java
--- javax/swing/JTabbedPane.java20 Apr 2006 07:02:00 - 1.37
+++ javax/swing/JTabbedPane.java15 May 2006 05:09:04 -
@@ -1,5 +1,5 @@
/* JTabbedPane.java --
- Copyright (C) 2002, 2004, 2005 Free Software Foundation, Inc.
+ Copyright (C) 2002, 2004, 2005, 2006, Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -1623,20 +1623,35 @@
}
/**
- * This method returns a string representation of this JTabbedPane. It is
- * mainly used for debugging purposes.
+ * Returns a string describing the attributes for the
+ * codeJTabbedPane/code component, for use in debugging. The return
+ * value is guaranteed to be non-codenull/code, but the format of the
+ * string may vary between implementations.
*
- * @return A string representation of this JTabbedPane.
+ * @return A string describing the attributes of the
+ * codeJTabbedPane/code.
*/
protected String paramString()
{
-return JTabbedPane;
+StringBuffer sb = new StringBuffer(super.paramString());
+sb.append(,tabPlacement=);
+if (tabPlacement == TOP)
+ sb.append(TOP);
+if (tabPlacement == BOTTOM)
+ sb.append(BOTTOM);
+if (tabPlacement == LEFT)
+ sb.append(LEFT);
+if (tabPlacement == RIGHT)
+ sb.append(RIGHT);
+return sb.toString();
}
/**
- * DOCUMENT ME!
+ * Returns the object that provides accessibility features for this
+ * codeJTabbedPane/code component.
*
- * @return DOCUMENT ME!
+ * @return The accessible context (an instance of
+ * [EMAIL PROTECTED] AccessibleJTabbedPane}).
*/
public AccessibleContext getAccessibleContext()
{
Re: [cp-patches] Patch: FYI: minor printing fix
On Sun, 2006-05-14 at 19:50 -0600, Tom Tromey wrote: I updated before preparing a different patch, and eclipse complained about JavaPrinterJob. This fixes the assignment, which, previously, did nothing. It also cleans up the imports. Tom Ah, whoops. Thanks :) /Sven
[cp-testresults] FAIL: regressions for libgcj on Sun May 14 06:56:20 UTC 2006
Baseline from: Sat May 13 12:41:21 UTC 2006 Regressions: FAIL: Thread_Sleep -findirect-dispatch output - bytecode-native test Totals: PASS: 4774 XPASS: 0 FAIL: 1 XFAIL: 12 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: regressions for mauve-jamvm on Sun May 14 14:29:15 UTC 2006
Baseline from: Sun May 14 08:25:13 UTC 2006 Regressions: FAIL: gnu.testlet.java.lang.Thread.sleep: Interrupted sleep (number 2) New fails: FAIL: gnu.testlet.gnu.java.security.sig.rsa.TestOfRSASignatureCodec abnormal termination 142 CRASH or TIMEOUT FAIL: gnu.testlet.gnu.javax.swing.text.html.parser.support.Parser.HTML_randomTable: Exception: java.lang.Exception: 'htmlhead/headbodytablecaptioncapt/captiontbodytr td C_0_0 /td/trtr tdC_1_0 tdC_1_1tdC_1_2/tbody/table/body/html' - 'htmlhead/headbodytablecaption'capt'/captiontbodytrtd'C_0_0'/td/trtrtd'C_1_0'/tdtd'C_1_1'/tdtd'C_1_2'/tbody/td/tr/tbody/table/body/html' expected 'htmlhead/headbodytablecaption'capt'/captiontbodytrtd'C_0_0'/td/trtrtd'C_1_0'/tdtd'C_1_1'/tdtd'C_1_2'/td/tr/tbody/table/body/html' (number 1) FAIL: gnu.testlet.java.util.logging.SocketHandler.publish abnormal termination 139 CRASH or TIMEOUT Totals: PASS: 31425 XPASS: 0 FAIL: 259 XFAIL: 0 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
Re: GConf-backend for java.util.prefs
Il giorno dom, 14/05/2006 alle 14.51 +0200, Robert Schuster ha scritto: Hi, thanks to Mario a long standing wish to have a GConf-based backend for java.util.prefs is becoming a reality. I think it is quite clear that GNU Classpath wants this code! :) Hi! I know this is a long email, sorry to the list (and sorry also for my english)... I'm glad to hear you! I wrote this backend because we needed it, and I found that classpath needed it too... I think that contribute it to the community was the right think to do (and if it gets accepted is simply a great thing and an honor for me!). However there are some questions and things to do: 1) Copyright assignment. Mario and everyone who has worked on the code needs to assign copyright to the Free Software Foundation before we can integrate it. This is no problem at all, just I need to know how (and what) to do. 2) Backend chosing How is should the user or the package maintainers decide which backend is to be used? Do we want a configure-time option or provide a possibility to chose the backend when starting the VM (using a property). Ok, this is a bit tricky. In both gnu classpath[1] and sun jdk the backend is choosen by setting this system property: System.setProperty(java.util.prefs.PreferencesFactory, gnu.java.util.prefs.GConfBasedFactory); Assuming the package name for the backend will not change. Anyway, there are few problems, I tried to be more close to the specs as possible, but gconf does not work like the windows registry, and I think that sun had the windows registry in mind when they designed the preference api. There are a couple of problems (I'm still checking for others): * sync does not really sync the backend: is just an hint. From the specs: Sync Ensures that future reads from this preference node and its descendants reflect any changes that were committed to the persistent store (from any VM) prior to the sync invocation. This is not always true, gconf may cache changes, and do not reflect them immediately. Anyway, almost always these changes reflect immediately (and I call gconf_suggest_sync often to reduce this risk). Infact, the gconf database is not updated in sync with the client, but in a given VM, the changes are consistent. So, the statement (from any VM) cannot be always satisfied. * The second problem is where to store user and system properties. GConf uses the standard of /apps/appname to store user node appname preferences. System preference are stored in /system. The preference api stores them under /package, where package is, for example, /gnu/java/util/prefs/gconf/ This is not allowed by gconf (at least, not recommended), so I used this default: user preference in /apps/java/package and system preference in /system/package This follows the gconf standard, but creates an ugly unbalanced tree under the gconf database. Still, I think is a correct solution, after all, java.util.prefs requires that the preferences are stored under a directory called /package, gconf requires that user preference are stored under /apps/appname. The root /apps/java is not exposed to the java api, so both standards are happy... As a side note, these directory can be configured at runtime by setting one of these two properties: java.util.prefs.gconf.user_root java.util.prefs.gconf.system_root * Finally, it would be fine to integrate an observer for value_changed events. Actually, observers only generate an event if the value of a key is updated by java code. Instead, gconf should warn all registered listeners if a key changes no matter how this change is done (for example, an administrator sets a key with the gconf editor). If I have understood how classpath works, this can be enabled when the gtk-peer is also enabled. I'll work on this in the next few days hoping to came with a nice solution. Wow! What a long mail... sorry!! :) cya Robert Ciao, Mario [1] it seems that this does not work on the gcj version shipped on fedora, but works on the last classpath with cacao. -- Lima Software, SO.PR.IND. s.r.l. http://www.limasoftware.net/ pgp key: http://subkeys.pgp.net/ Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ signature.asc Description: Questa รจ una parte del messaggio firmata digitalmente
Re: libgcj merging and VMStackWalker
Hi Tom, On Sat, 2006-05-13 at 17:41 -0600, Tom Tromey wrote: I think this merge could be done fairly simply. In fact I think it just requires adding a 'Class' argument to VMStackWalker.getCallingClass and VMStackWalker.getCallingClassLoader. This argument would name the immediate caller, and these methods would be changed to return the class just above the argument class in the stack trace. With this change I think I could immediately merge Logger, ResourceBundle, Package, and parts of SecurityManager and the little CORBA differences. I don't think this would overly affect performance (a big worry on the gcj end) or maintainability on the Classpath side. It would require a small VM change. However, other VMs could simply add this method argument and then ignore it, and things would continue to work as they do today. I like it since this looks like the proposal I made last year. But there were some (strong) opinions about that change back then. You might want to read that thread: http://lists.gnu.org/archive/html/classpath-patches/2005-01/msg00138.html Cheers, Mark signature.asc Description: This is a digitally signed message part
Re: Socket inherits timeout from accept - is this right?
Hi Edwin, On Wed, 2006-05-03 at 16:34 +0200, Edwin Steiner wrote: I tracked down a problem where JOnAS on classpath/cacao dropped a database connection for no good reason. The cause was that the ServerSocket used for accept has a one-second timeout set, and the accepted Sockets inherit it. This inheritance of options is documented for the accept(2) system call, but I don't think it is intended behaviour on the java.net.Socket level. I did not find any reference to that in the ServerSocket documentation. Good catch. I fixed it in CVS (and on the 0.91 release branch). And I added a Mauve test for this. Thanks, Mark signature.asc Description: This is a digitally signed message part
[Bug classpath/27459] Socket inherits timeout setting from ServerSocket.accept
--- Comment #2 from cvs-commit at developer dot classpath dot org 2006-05-14 20:11 --- Subject: Bug 27459 CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 06/05/14 20:07:33 Modified files: . : ChangeLog native/jni/java-net: javanet.c Log message: PR 27459 * native/jni/java-net/javanet.c (_javanet_accept): Reset the inherited timeout on socket. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7399tr2=1.7400r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/native/jni/java-net/javanet.c.diff?tr1=1.33tr2=1.34r1=textr2=text -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27459 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
RE: libgcj merging and VMStackWalker
Hi,
I still don't get it. Why can you walk up one frame from the context
class, but not two frames from the VMStackWalker class?
Regards,
Jeroen
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
On Behalf Of Tom Tromey
Sent: Sunday, May 14, 2006 01:42
To: GNU Classpath Project
Cc: GCJ Hackers
Subject: libgcj merging and VMStackWalker
This week I spent some time looking at the libgcj/Classpath merge
situation. After removing all the simple merges that hadn't yet been
handled for some reason, I looked at VMStackWalker a little.
I think this merge could be done fairly simply. In fact I think it
just requires adding a 'Class' argument to
VMStackWalker.getCallingClass and VMStackWalker.getCallingClassLoader.
This argument would name the immediate caller, and these methods
would be changed to return the class just above the argument class in
the stack trace.
With this change I think I could immediately merge Logger,
ResourceBundle, Package, and parts of SecurityManager and the little
CORBA differences.
I don't think this would overly affect performance (a big worry on the
gcj end) or maintainability on the Classpath side.
It would require a small VM change. However, other VMs could simply
add this method argument and then ignore it, and things would continue
to work as they do today.
I've appended the VMStackWalker change so folks can see what it looks
like. I didn't include all the other changes, which are basically
mechanical.
On the libgcj side, VMStackWalker would be just a simple wrapper
around the existing stack-walking code. The class argument would make
it simpler for our stack walker to know when to start looking for the
'caller' class -- it would skip both VMStackWalker and the immediate
(internal) caller.
Comments?
Tom
Index: VMStackWalker.java
===
RCS file:
/cvsroot/classpath/classpath/vm/reference/gnu/classpath/VMStac
kWalker.java,v
retrieving revision 1.6
diff -u -r1.6 VMStackWalker.java
--- VMStackWalker.java13 Nov 2005 22:29:45 - 1.6
+++ VMStackWalker.java13 May 2006 23:28:36 -
@@ -78,7 +78,7 @@
* VM implementers are encouraged to provide a more efficient
* version of this method.
*/
- public static Class getCallingClass()
+ public static Class getCallingClass(Class context)
{
Class[] ctx = getClassContext();
if (ctx.length 3)
@@ -97,7 +97,7 @@
* VM implementers are encouraged to provide a more efficient
* version of this method.
*/
- public static ClassLoader getCallingClassLoader()
+ public static ClassLoader getCallingClassLoader(Class context)
{
Class[] ctx = getClassContext();
if (ctx.length 3)
Re: GConf-backend for java.util.prefs
Il giorno dom, 14/05/2006 alle 11.34 -0400, Thomas Fitzsimmons ha scritto: Hi, Mario Torre wrote: As a side note, these directory can be configured at runtime by setting one of these two properties: java.util.prefs.gconf.user_root java.util.prefs.gconf.system_root Since these are GNU-specific properties, they should probably be prefixed with gnu.. Tom Hi I don't know if they are really GNU-specific, as the backend can be used also in non-GNU java implementation, having a common runtime property in this case is important. Anyway, I don't really see problems here to prefix gnu. to the properties. I attach the full backend patch with the properties changed to: gnu.java.util.prefs.gconf.user_root gnu.java.util.prefs.gconf.system_root The ChangeLog is the same, as the patch has not been committed to cvs: 2006-05-12 Mario Torre [EMAIL PROTECTED] * gnu/java/util/prefs/GConfBasedPreferences.java: new class. * gnu/java/util/prefs/GConfBasedFactory.java: new class. * gnu/java/util/prefs/gconf/GConfNativePeer.java: new class. * gnu_java_util_prefs_gconf_GConfNativePeer.h: generated header file. * classpath/native/jni/gconf-peer/GConfNativePeer.c: new C file. * configure.ac: update to introduce new files. Added options to build gconf native peer used by the GConf preference backend. * include/Makefile.am: update to introduce new files. * native/jni/Makefile.am update to introduce new files. * scripts/check_jni_methods.sh: added three new ignored file from check. * native/jni/gconf-peer/Makefile.am: new Makefile needed to build gconf-peer shared library. After (and if) it is committed to cvs, I'll post on the mauve list a couple of simple tests for the preference api. Mario -- Lima Software, SO.PR.IND. s.r.l. http://www.limasoftware.net/ pgp key: http://subkeys.pgp.net/ Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ gconf-preference-backend.patch.tar.gz Description: application/compressed-tar
Re: Build failure: mozilla-plugin
Tom == Thomas Fitzsimmons [EMAIL PROTECTED] writes: Anyway, I think that classpath should be buildable without any mozilla dependencies. Tom Try --disable-plugin. For eclipse-based builds it would be friendlier if, by default, configure would search for the needed libraries and then simply not compile things if dependencies are missing. Also I noticed we are doing this: AC_SUBST(PLUGIN_DIR, $HOME/.mozilla/plugins/) That seems weird, especially for distro use. (Also according to GNU standards we shouldn't install anything outside $prefix.) I think we probably need another option to set this install directory. Finally... I see this in the plugin Makefile.am: install-libLTLIBRARIES: $(lib_LTLIBRARIES) $(INSTALL) -d -m0755 $(DESTDIR)@PLUGIN_DIR@ $(INSTALL) .libs/libgcjwebplugin.so $(DESTDIR)@PLUGIN_DIR@ Overriding an internal rule is not supported by automake. If we really, really want to do this, then the correct approach is a new directory variable. Tom
[commit-cp] classpath tools/gnu/classpath/tools/keytool/Ide...
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Raif S. Naffah [EMAIL PROTECTED] 06/05/14 08:20:19 Modified files: tools/gnu/classpath/tools/keytool: IdentityDBCmd.java KeyCloneCmd.java KeyPasswdCmd.java PrintCertCmd.java ListCmd.java StorePasswdCmd.java DeleteCmd.java CertReqCmd.java GenKeyCmd.java ExportCmd.java ImportCmd.java SelfCertCmd.java Command.java Main.java . : ChangeLog tools : Makefile.am Removed files: tools/gnu/classpath/tools/keytool: keytool.txt Log message: 2006-05-14 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/keytool/keytool.txt: Removed * tools/gnu/classpath/tools/keytool/StorePasswdCmd.java: Increased visibility of fields used by parser anonymous classes. (processArgs): Removed. (getParser): New method. * tools/gnu/classpath/tools/keytool/SelfCertCmd.java: Likewise. (setup): Mark (Eclipse) strings that need not be externalised. (start): Likewise. * tools/gnu/classpath/tools/keytool/PrintCertCmd.java: Likewise. * tools/gnu/classpath/tools/keytool/Main.java: Amended to use getopt command line option parsing. * tools/gnu/classpath/tools/keytool/ListCmd.java: Increased visibility of fields used by parser anonymous classes. (processArgs): Removed. (setup): set 'all' local field. (getParser): New method. * tools/gnu/classpath/tools/keytool/KeyPasswdCmd.java: Increased visibility of fields used by parser anonymous classes. (processArgs): Removed. (getParser): New method. * tools/gnu/classpath/tools/keytool/KeyCloneCmd.java: Likewise. (setNewKeyPassword): Fixed comments. * tools/gnu/classpath/tools/keytool/ImportCmd.java: Increased visibility of fields used by parser anonymous classes. (processArgs): Removed. (getParser): New method. (findTrustInCACerts): Mark (Eclipse) strings that need not be externalised. * tools/gnu/classpath/tools/keytool/GenKeyCmd.java: Increased visibility of fields used by parser anonymous classes. (processArgs): Removed. (setup): Mark (Eclipse) strings that need not be externalised. (getParser): New method. * tools/gnu/classpath/tools/keytool/IdentityDBCmd.java: Likewise. * tools/gnu/classpath/tools/keytool/DeleteCmd.java: Increased visibility of fields used by parser anonymous classes. (processArgs): Removed. (getParser): New method. * tools/gnu/classpath/tools/keytool/CertReqCmd.java: Likewise. (ATTRIBUTES_OPT): New constant. * tools/gnu/classpath/tools/keytool/ExportCmd.java: Increased visibility of fields used by parser anonymous classes. (processArgs): Removed. (setup): Mark (Eclipse) strings that need not be externalised. (start): Likewise. Reduced logging level. (getParser): New method. * tools/gnu/classpath/tools/keytool/Command.java (processArgs): Made it concrete. (getParser): New abstract method. * tools/Makefile.am (KEYTOOL_HELPS): Removed. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/keytool/IdentityDBCmd.java.diff?tr1=1.1tr2=1.2r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/keytool/KeyCloneCmd.java.diff?tr1=1.1tr2=1.2r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/keytool/KeyPasswdCmd.java.diff?tr1=1.1tr2=1.2r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/keytool/PrintCertCmd.java.diff?tr1=1.1tr2=1.2r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/keytool/ListCmd.java.diff?tr1=1.1tr2=1.2r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/keytool/StorePasswdCmd.java.diff?tr1=1.1tr2=1.2r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/keytool/DeleteCmd.java.diff?tr1=1.1tr2=1.2r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/keytool/CertReqCmd.java.diff?tr1=1.1tr2=1.2r1=textr2=text
[commit-cp] classpath resource/gnu/classpath/tools/keytool/...
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Raif S. Naffah [EMAIL PROTECTED] 06/05/14 08:26:32 Modified files: resource/gnu/classpath/tools/keytool: MessageBundle.properties . : ChangeLog Log message: 2006-05-14 Raif S. Naffah [EMAIL PROTECTED] * resource/gnu/classpath/tools/keytool/MessageBundle.properties: Added help text. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/resource/gnu/classpath/tools/keytool/MessageBundle.properties.diff?tr1=1.1tr2=1.2r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7397tr2=1.7398r1=textr2=text
[commit-cp] classpath ./ChangeLog tools/gnu/classpath/tools...
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Raif S. Naffah [EMAIL PROTECTED] 06/05/14 08:32:49 Modified files: . : ChangeLog tools/gnu/classpath/tools/jarsigner: Main.java Log message: 2006-05-14 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/jarsigner/Main.java (main): Formatting. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7398tr2=1.7399r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/jarsigner/Main.java.diff?tr1=1.10tr2=1.11r1=textr2=text
[commit-cp] classpath ./ChangeLog java/nio/ByteBufferImpl.java [classpath-0_91-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_91-branch Changes by: Mark Wielaard [EMAIL PROTECTED] 06/05/14 14:47:50 Modified files: . : ChangeLog java/nio : ByteBufferImpl.java Log message: 2006-05-13 Tom Tromey [EMAIL PROTECTED] * java/nio/ByteBufferImpl.java (compact): Always set position. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?only_with_tag=classpath-0_91-branchtr1=1.7277.2.13tr2=1.7277.2.14r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/java/nio/ByteBufferImpl.java.diff?only_with_tag=classpath-0_91-branchtr1=1.14tr2=1.14.2.1r1=textr2=text
[commit-cp] classpath ./ChangeLog javax/swing/text/Abstract... [classpath-0_91-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_91-branch Changes by: Mark Wielaard [EMAIL PROTECTED] 06/05/14 16:43:58 Modified files: . : ChangeLog javax/swing/text: AbstractDocument.java Log message: 2006-05-14 Robert Schuster [EMAIL PROTECTED] PR classpath/27595 * javax/swing/text/AbstractDocument.java: (insertString): Flipped if-expression and its blocks. (remove): Dito. (replace): Flipped if-expression and its blocks, added note, invoke insertString and remove instead of insertStringImpl and removeImpl. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?only_with_tag=classpath-0_91-branchtr1=1.7277.2.14tr2=1.7277.2.15r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/javax/swing/text/AbstractDocument.java.diff?only_with_tag=classpath-0_91-branchtr1=1.55.2.1tr2=1.55.2.2r1=textr2=text
[commit-cp] classpath ./ChangeLog java/util/SimpleTimeZone.... [classpath-0_91-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_91-branch Changes by: Mark Wielaard [EMAIL PROTECTED] 06/05/14 18:56:14 Modified files: . : ChangeLog java/util : SimpleTimeZone.java Log message: 2006-05-14 Lillian Angel [EMAIL PROTECTED] * java/util/SimpleTimeZone.java: Reverted patch. (SimpleTimeZone): Throw exception if startMonth == endMonth. (SimpleTimeZone): Likewise. (checkRule): Rewritten to properly check all values (more efficently). This code is now more stable, at least less buggy than before. Fixed API documentation. (setStartRule): Moved checkRule call to end. (setStartRule): Likewise. (setEndRule): Likewise. (setEndRule): Likewise. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?only_with_tag=classpath-0_91-branchtr1=1.7277.2.16tr2=1.7277.2.17r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/java/util/SimpleTimeZone.java.diff?only_with_tag=classpath-0_91-branchtr1=1.30tr2=1.30.2.1r1=textr2=text
[commit-cp] classpath ./ChangeLog native/jni/java-net/javan...
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 06/05/14 20:07:33 Modified files: . : ChangeLog native/jni/java-net: javanet.c Log message: PR 27459 * native/jni/java-net/javanet.c (_javanet_accept): Reset the inherited timeout on socket. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7399tr2=1.7400r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/native/jni/java-net/javanet.c.diff?tr1=1.33tr2=1.34r1=textr2=text
[commit-cp] classpath ./ChangeLog native/jni/java-net/javan... [classpath-0_91-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_91-branch Changes by: Mark Wielaard [EMAIL PROTECTED] 06/05/14 20:07:51 Modified files: . : ChangeLog native/jni/java-net: javanet.c Log message: PR 27459 * native/jni/java-net/javanet.c (_javanet_accept): Reset the inherited timeout on socket. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?only_with_tag=classpath-0_91-branchtr1=1.7277.2.17tr2=1.7277.2.18r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/native/jni/java-net/javanet.c.diff?only_with_tag=classpath-0_91-branchtr1=1.33tr2=1.33.6.1r1=textr2=text
[commit-cp] classpath ./ChangeLog gnu/xml/dom/DomNode.java [classpath-0_91-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_91-branch Changes by: Mark Wielaard [EMAIL PROTECTED] 06/05/14 20:20:26 Modified files: . : ChangeLog gnu/xml/dom: DomNode.java Log message: * gnu/xml/dom/DomNode.java: Permit comments and PIs in doctype nodes to be preserved during cloneNode. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?only_with_tag=classpath-0_91-branchtr1=1.7277.2.18tr2=1.7277.2.19r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/gnu/xml/dom/DomNode.java.diff?only_with_tag=classpath-0_91-branchtr1=1.14tr2=1.14.2.1r1=textr2=text
[commit-cp] classpath ./ChangeLog native/jni/java-net/javan...
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Mark Wielaard [EMAIL PROTECTED] 06/05/14 20:29:41 Modified files: . : ChangeLog native/jni/java-net: javanet.c Log message: * native/jni/java-net/javanet.c (_javanet_accept): Don't use C++ comments. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7400tr2=1.7401r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/native/jni/java-net/javanet.c.diff?tr1=1.34tr2=1.35r1=textr2=text
[commit-cp] classpath ./ChangeLog native/jni/java-net/javan... [classpath-0_91-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_91-branch Changes by: Mark Wielaard [EMAIL PROTECTED] 06/05/14 20:29:54 Modified files: . : ChangeLog native/jni/java-net: javanet.c Log message: * native/jni/java-net/javanet.c (_javanet_accept): Don't use C++ comments. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?only_with_tag=classpath-0_91-branchtr1=1.7277.2.19tr2=1.7277.2.20r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/native/jni/java-net/javanet.c.diff?only_with_tag=classpath-0_91-branchtr1=1.33.6.1tr2=1.33.6.2r1=textr2=text
[commit-cp] classpath ./ChangeLog native/plugin/.cvsignore
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Tom Tromey [EMAIL PROTECTED] 06/05/14 20:32:41 Modified files: . : ChangeLog native/plugin : .cvsignore Log message: * native/plugin/.cvsignore: Updated. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7401tr2=1.7402r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/native/plugin/.cvsignore.diff?tr1=1.1tr2=1.2r1=textr2=text
[commit-cp] classpath ./ChangeLog javax/swing/JMenuItem.java
CVSROOT:/sources/classpath Module name:classpath Branch: Changes by: David Gilbert [EMAIL PROTECTED] 06/05/14 20:35:53 Modified files: . : ChangeLog javax/swing: JMenuItem.java Log message: 2006-05-14 David Gilbert [EMAIL PROTECTED] * javax/swing/JMenuItem.java (paramString): Fixed class name in API doc comment. -- CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7402tr2=1.7403r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/javax/swing/JMenuItem.java.diff?tr1=1.29tr2=1.30r1=textr2=text
[commit-cp] classpath ./ChangeLog javax/swing/JCheckBoxMenu...
CVSROOT:/sources/classpath Module name:classpath Branch: Changes by: David Gilbert [EMAIL PROTECTED] 06/05/14 21:00:28 Modified files: . : ChangeLog javax/swing: JCheckBoxMenuItem.java Log message: 2006-05-14 David Gilbert [EMAIL PROTECTED] * javax/swing/JCheckBoxMenuItem.java (requestFocus): Fixed typo in API docs, (paramString): Just call super.paramString(), (getAccessibleContext): Added API docs, (AccessibleJCheckBoxMenuItem): Likewise. -- CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7405tr2=1.7406r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/javax/swing/JCheckBoxMenuItem.java.diff?tr1=1.15tr2=1.16r1=textr2=text
[commit-cp] classpath ChangeLog README
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Christian Thalinger [EMAIL PROTECTED] 06/05/14 22:43:50 Modified files: . : ChangeLog README Log message: 2006-05-15 Christian Thalinger [EMAIL PROTECTED] * README: Added CACAO to list of VMs. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7406tr2=1.7407r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/README.diff?tr1=1.17tr2=1.18r1=textr2=text
[commit-cp] classpath gnu/java/awt/print/JavaPrinterGraphic...
CVSROOT:/sources/classpath Module name:classpath Branch: Changes by: Sven de Marothy [EMAIL PROTECTED] 06/05/15 01:40:40 Modified files: gnu/java/awt/print: JavaPrinterGraphics.java JavaPrinterJob.java . : ChangeLog Log message: 2006-05-15 Sven de Marothy [EMAIL PROTECTED] * gnu/java/awt/print/JavaPrinterGraphics.java: Sweeping changes I can't be bothered to document in detail. * gnu/java/awt/print/JavaPrinterJob.java (getPageAttributes): New method. (setPageable,cancel,isCancelled): Implement. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/gnu/java/awt/print/JavaPrinterGraphics.java.diff?tr1=1.3tr2=1.4r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/gnu/java/awt/print/JavaPrinterJob.java.diff?tr1=1.1tr2=1.2r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7407tr2=1.7408r1=textr2=text
[commit-cp] classpath tools/gnu/classpath/tools/jar/Creator...
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Tom Tromey [EMAIL PROTECTED] 06/05/15 01:57:30 Modified files: tools/gnu/classpath/tools/jar: Creator.java Indexer.java Action.java Updater.java Main.java tools/gnu/classpath/tools/getopt: Parser.java . : ChangeLog Log message: * tools/gnu/classpath/tools/jar/Updater.java (run): No longer throws OptionException. * tools/gnu/classpath/tools/jar/Creator.java (run): No longer throws OptionException. * tools/gnu/classpath/tools/jar/Action.java (run): No longer throws OptionException. * tools/gnu/classpath/tools/jar/Indexer.java (run): Removed. Moved validation to JarParser. * tools/gnu/classpath/tools/jar/Main.java (JarParser): New class. (run): Moved validation to JarParser. Don't throw OptionException. (initializeParser): Create a JarParser. (main): Don't catch OptionException. * tools/gnu/classpath/tools/getopt/Parser.java (printHelp): No longer public. (validate): New method. (parse): Call it. Print '-help' in error message when long-only. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/jar/Creator.java.diff?tr1=1.3tr2=1.4r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/jar/Indexer.java.diff?tr1=1.2tr2=1.3r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/jar/Action.java.diff?tr1=1.2tr2=1.3r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/jar/Updater.java.diff?tr1=1.3tr2=1.4r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/jar/Main.java.diff?tr1=1.4tr2=1.5r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/tools/gnu/classpath/tools/getopt/Parser.java.diff?tr1=1.5tr2=1.6r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7409tr2=1.7410r1=textr2=text
[commit-cp] classpath ./ChangeLog javax/swing/JTabbedPane.java
CVSROOT:/sources/classpath Module name:classpath Branch: Changes by: David Gilbert [EMAIL PROTECTED] 06/05/15 05:15:30 Modified files: . : ChangeLog javax/swing: JTabbedPane.java Log message: 2006-05-15 David Gilbert [EMAIL PROTECTED] * javax/swing/JTabbedPane.java (paramString): Reimplemented, (getAccessibleContext): Added API docs. -- CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7411tr2=1.7412r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/javax/swing/JTabbedPane.java.diff?tr1=1.37tr2=1.38r1=textr2=text
