RFC: Removing unused import
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, Filtering warnings in Classpath with Eclipse, I found there are 388 warnings about The import XXX is never used. I can work on these warnings and I think I can commit the result without requesting for comment on each classes because it's a minimal impact patch. But before proceeding, I'd like to ask: 1- is it useful; 2- which package can I start working on? Packages that are involved: gnu.classpath.jdwp.** gnu.CORBA.** gnu.javax.crypto.** gnu.javax.imageio.bmp.* gnu.javax.net.ssl.* gnu.javax.net.ssl.provider.* gnu.javax.security.auth.Password gnu.javax.sound.midi.** gnu.java.awt.* gnu.java.awt.peer.gtk.* gnu.java.awt.peer.qt.* gnu.java.net.protocol.http.Headers gnu.java.security.prng.PRNGFactory gnu.java.security.x509.ext.GeneralNames gnu.regexp.RETokenRepeated gnu.xml.dom.html2.* gnu.xml.stream.* gnu.xml.transform.* gnu.xml.validation.datatype.* gnu.xml.validation.relaxng.FullSyntaxBuilder gnu.xml.validator.xmlschema.* gnu.xml.xpath.XPathParser javax.imageio.metadata.IIOMetadataFormatImpl javax.swing.RepaintManager javax.swing.plaf.basic.* javax.swing.plaf.metal.* javax.swing.table.DefaultTableRenderer javax.swing.text.* javax.xml.stream.* org.omg.** tools.gnu.classpath.tools.rmi.* tools.gnu.classpath.tools.rmi.** vm.reference.gnu.classpath.jdwp.* Thanks for your time and comments, - -- Arnaud Vandyck ,= ,-_-. =. ((_/)o o(\_)) `-'(. .)`-' \_/ Java Trap: http://www.gnu.org/philosophy/java-trap.html -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFEEFVo4vzFZu62tMIRAlCmAJ4l0XJ6/oUcXYv7GlNRyNkJsXFnCACfQ+CQ 3TdE+LrWu4a+8VyH2tItiHo= =ZBxW -END PGP SIGNATURE-
Re: RFC: Removing unused import
Arnaud Vandyck wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, Filtering warnings in Classpath with Eclipse, I found there are 388 warnings about The import XXX is never used. I can work on these warnings and I think I can commit the result without requesting for comment on each classes because it's a minimal impact patch. But before proceeding, I'd like to ask: 1- is it useful; In my opinion it is. Clearing away some of the trivial warnings makes it easier to see the important stuff. Regards, Dave
Re: RFC: Removing unused import
Arnaud Vandyck wrote: gnu.classpath.jdwp.** vm.reference.gnu.classpath.jdwp.* Doh! And here I thought I always kept track of that stuff pretty well. Don't bother with these, I'll clean them up myself. Thanks, Keith
Re: RFC: Removing unused import
Arnaud Vandyck wrote: Filtering warnings in Classpath with Eclipse, I found there are 388 warnings about The import XXX is never used. I can work on these warnings and I think I can commit the result without requesting for comment on each classes because it's a minimal impact patch. But before proceeding, I'd like to ask: 1- is it useful; It's useful.. but first verify that the tool is javadoc-aware. E.g., some imports may only be used in javadoc comments (in theory). -Archie __ Archie Cobbs *CTO, Awarix* http://www.awarix.com
Re: RFC: Removing unused import
Arnaud == Arnaud Vandyck [EMAIL PROTECTED] writes: Arnaud Filtering warnings in Classpath with Eclipse, I found there are 388 Arnaud warnings about The import XXX is never used. I can work on these Arnaud warnings and I think I can commit the result without requesting for Arnaud comment on each classes because it's a minimal impact patch. But before Arnaud proceeding, I'd like to ask: Arnaud 1- is it useful; Yeah, it is good to clear out the lame warnings from time to time. Arnaud 2- which package can I start working on? I think any code not in external/ is fair game. In the long run I suspect we may see regressions in this area, since only some developers are using Eclipse. Eventually we may prefer to simply disable this warning. Tom
Re: RFC: Removing unused import
Arnaud Vandyck wrote: Filtering warnings in Classpath with Eclipse, I found there are 388 warnings about The import XXX is never used. I can work on these warnings and I think I can commit the result without requesting for comment on each classes because it's a minimal impact patch. But before proceeding, I'd like to ask: 1- is it useful; Why not, if you can be bothered? It tidies things up and makes them easier to maintain. 2- which package can I start working on? Packages that are involved: ... gnu.xml.xpath.XPathParser This class, at least, is generated (from XPathParser.y). But feel free to remove unused imports from the other gnu.xml.* classes. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
Re: RFC: Removing unused import
Archie Cobbs wrote: It's useful.. but first verify that the tool is javadoc-aware. E.g., some imports may only be used in javadoc comments (in theory). -Archie ... and not only in the theory. In Classpath code there are a lot of imports that are only used in javadoc comments. Surely, I suppose that you will take this into consideration. Audrius.
Re: RFC: Removing unused import
Audrius Meskauskas wrote: Archie Cobbs wrote: It's useful.. but first verify that the tool is javadoc-aware. E.g., some imports may only be used in javadoc comments (in theory). -Archie ... and not only in the theory. In Classpath code there are a lot of imports that are only used in javadoc comments. Surely, I suppose that you will take this into consideration. Audrius. Eclipse does handle this correctly. Regards, Dave
