Re: glibj-generics-latest.zip on builder old?

2006-11-07 Thread Andrew John Hughes

On 6 Nov 2006, at 05:31, Michael Koch wrote:


On Mon, Nov 06, 2006 at 01:45:09AM +0100, Mark Wielaard wrote:

Hi,

On Mon, 2006-11-06 at 01:11 +0100, Mark Wielaard wrote:

On Fri, 2006-11-03 at 10:12 -0500, Stuart Ballard wrote:

On 11/1/06, Mark Wielaard [EMAIL PROTECTED] wrote:

Looking through the log it is:
1729. ERROR in ../../classpath/java/util/EnumSet.java (at line  
252)

return copyOf((EnumSetT) other);
   ^^
The method copyOf(EnumSetT) is ambiguous for the type EnumSetT


So do we reckon this is a Classpath bug or an ecj issue? Andrew,
presumably -generics builds for you - how does your ecj version
compare to the one on builder?


This seems to have been fixed now. Although I am not sure how that
happened precisely. The ecj version used on builder is: Eclipse Java
Compiler 0.722, 3.3.0 milestone-3


OK, sorry, my mistake. I wasn't looking at the right log file. It  
seems

to be broken for current ecj CVS. So I made builder use the installed
ecj for now (v_585_R31x, 3.1.2 release) and now it compiles also on
builder again.

If it really is a bug in the ecj (org.eclipse.jdt.core) CVS  
version then
we should create a bug report. Could someone familiar with EnumSet  
take

a look?


Afaik the Harmony people had a similar bug with ecj and reported this.
I dont have a link yet but I can look into this tonite.


Cheers,
Michael
--
http://www.worldforge.org/



Don't know if my other post reached the list or not (I can't see it  
in my archives), but

the problem is that there are two copyOf methods:

copyOf(EnumSetT)
copyOf(CollectionT)

where the latter calls the former, if an instanceof EnumSet succeeds.

Things still seem to be broken on builder.  I'm guessing 3.1.2 is too  
old, as problems
with the java.util.concurrent stuff seems to have been reintroduced  
(we went from ~95%

to ~26%, which is worse than an out-of-date version).

Cheers,
--
Andrew :) 



Re: glibj-generics-latest.zip on builder old?

2006-11-07 Thread Mark Wielaard
Hi Andrew,

On Tue, 2006-11-07 at 09:11 +, Andrew John Hughes wrote:
 Don't know if my other post reached the list or not (I can't see it  
 in my archives), but
 the problem is that there are two copyOf methods:
 
 copyOf(EnumSetT)
 copyOf(CollectionT)
 
 where the latter calls the former, if an instanceof EnumSet succeeds.

But that is good code isn't it?
Or is there a reason the compiler refuses it?

 Things still seem to be broken on builder.  I'm guessing 3.1.2 is too  
 old, as problems
 with the java.util.concurrent stuff seems to have been reintroduced  

I upgraded the ecj on builder to v_677_R32x, 3.2.1
(ecj-bootstrap-gcj_3.2.1-3_i386.deb)

Cheers,

Mark


signature.asc
Description: This is a digitally signed message part


Re: glibj-generics-latest.zip on builder old?

2006-11-07 Thread Stuart Ballard

On 11/7/06, Mark Wielaard [EMAIL PROTECTED] wrote:

 Things still seem to be broken on builder.  I'm guessing 3.1.2 is too
 old, as problems
 with the java.util.concurrent stuff seems to have been reintroduced

I upgraded the ecj on builder to v_677_R32x, 3.2.1
(ecj-bootstrap-gcj_3.2.1-3_i386.deb)


Part of the issue is Japitools aborting entirely part way through
Japizing when certain kinds of corrupt class files are encountered.

Work on fixing this is in progress.

Stuart.
--
http://sab39.dev.netreach.com/



Re: glibj-generics-latest.zip on builder old?

2006-11-07 Thread Mark Wielaard
Hi Stuart,

On Tue, 2006-11-07 at 08:38 -0500, Stuart Ballard wrote:
 On 11/7/06, Mark Wielaard [EMAIL PROTECTED] wrote:
   Things still seem to be broken on builder.  I'm guessing 3.1.2 is too
   old, as problems
   with the java.util.concurrent stuff seems to have been reintroduced
 
  I upgraded the ecj on builder to v_677_R32x, 3.2.1
  (ecj-bootstrap-gcj_3.2.1-3_i386.deb)
 
 Part of the issue is Japitools aborting entirely part way through
 Japizing when certain kinds of corrupt class files are encountered.
 
 Work on fixing this is in progress.

Ah, that would explain why whole packages were disappearing from the
comparison. Thanks for working on Japitools. I wish more projects would
use it when they do new releases to get a good overview of compatibility
between releases.

Do the zip files as published at http://builder.classpath.org/dist/ work
correct for Japitools now?

Cheers,

Mark


signature.asc
Description: This is a digitally signed message part


Re: glibj-generics-latest.zip on builder old?

2006-11-07 Thread Stuart Ballard

They seem to as of last night's run. I'm not aware of any remaining
problems, although that doesn't mean there aren't any subtle ones of
course :)

Stuart.

On 11/7/06, Mark Wielaard [EMAIL PROTECTED] wrote:

Hi Stuart,

On Tue, 2006-11-07 at 08:38 -0500, Stuart Ballard wrote:
 On 11/7/06, Mark Wielaard [EMAIL PROTECTED] wrote:
   Things still seem to be broken on builder.  I'm guessing 3.1.2 is too
   old, as problems
   with the java.util.concurrent stuff seems to have been reintroduced
 
  I upgraded the ecj on builder to v_677_R32x, 3.2.1
  (ecj-bootstrap-gcj_3.2.1-3_i386.deb)

 Part of the issue is Japitools aborting entirely part way through
 Japizing when certain kinds of corrupt class files are encountered.

 Work on fixing this is in progress.

Ah, that would explain why whole packages were disappearing from the
comparison. Thanks for working on Japitools. I wish more projects would
use it when they do new releases to get a good overview of compatibility
between releases.

Do the zip files as published at http://builder.classpath.org/dist/ work
correct for Japitools now?

Cheers,

Mark






--
http://sab39.dev.netreach.com/



Re: glibj-generics-latest.zip on builder old?

2006-11-05 Thread Mark Wielaard
On Fri, 2006-11-03 at 10:12 -0500, Stuart Ballard wrote:
 On 11/1/06, Mark Wielaard [EMAIL PROTECTED] wrote:
  Looking through the log it is:
  1729. ERROR in ../../classpath/java/util/EnumSet.java (at line 252)
  return copyOf((EnumSetT) other);
 ^^
  The method copyOf(EnumSetT) is ambiguous for the type EnumSetT
 
 So do we reckon this is a Classpath bug or an ecj issue? Andrew,
 presumably -generics builds for you - how does your ecj version
 compare to the one on builder?

This seems to have been fixed now. Although I am not sure how that
happened precisely. The ecj version used on builder is: Eclipse Java
Compiler 0.722, 3.3.0 milestone-3

Cheers,

Mark


signature.asc
Description: This is a digitally signed message part


Re: glibj-generics-latest.zip on builder old?

2006-11-05 Thread Michael Koch
On Mon, Nov 06, 2006 at 01:45:09AM +0100, Mark Wielaard wrote:
 Hi,
 
 On Mon, 2006-11-06 at 01:11 +0100, Mark Wielaard wrote:
  On Fri, 2006-11-03 at 10:12 -0500, Stuart Ballard wrote:
   On 11/1/06, Mark Wielaard [EMAIL PROTECTED] wrote:
Looking through the log it is:
1729. ERROR in ../../classpath/java/util/EnumSet.java (at line 252)
return copyOf((EnumSetT) other);
   ^^
The method copyOf(EnumSetT) is ambiguous for the type EnumSetT
   
   So do we reckon this is a Classpath bug or an ecj issue? Andrew,
   presumably -generics builds for you - how does your ecj version
   compare to the one on builder?
  
  This seems to have been fixed now. Although I am not sure how that
  happened precisely. The ecj version used on builder is: Eclipse Java
  Compiler 0.722, 3.3.0 milestone-3
 
 OK, sorry, my mistake. I wasn't looking at the right log file. It seems
 to be broken for current ecj CVS. So I made builder use the installed
 ecj for now (v_585_R31x, 3.1.2 release) and now it compiles also on
 builder again.
 
 If it really is a bug in the ecj (org.eclipse.jdt.core) CVS version then
 we should create a bug report. Could someone familiar with EnumSet take
 a look?

Afaik the Harmony people had a similar bug with ecj and reported this.
I dont have a link yet but I can look into this tonite.


Cheers,
Michael
-- 
http://www.worldforge.org/



Re: glibj-generics-latest.zip on builder old?

2006-11-03 Thread Stuart Ballard

On 11/1/06, Mark Wielaard [EMAIL PROTECTED] wrote:

Looking through the log it is:
1729. ERROR in ../../classpath/java/util/EnumSet.java (at line 252)
return copyOf((EnumSetT) other);
   ^^
The method copyOf(EnumSetT) is ambiguous for the type EnumSetT


So do we reckon this is a Classpath bug or an ecj issue? Andrew,
presumably -generics builds for you - how does your ecj version
compare to the one on builder?

Stuart.

PS I know, I'm being a pain in the neck, I'm just impatient to see the
Japi results with that latest merge in ;) Sorry
--
http://sab39.dev.netreach.com/



Re: glibj-generics-latest.zip on builder old?

2006-10-31 Thread Mark Wielaard
Hi Stuart,

On Tue, 2006-10-31 at 20:05 -0500, Stuart Ballard wrote:
 On http://builder.classpath.org/dist/, glibj-generics-latest.zip is
 dated Oct 18th as opposed to all the other files including
 classpath-generics-latest.tar.gz and glibj-latest.zip which are dated
 Oct 31st as expected. Is something up with the generics build causing
 it to fail to produce an updated zip?

Yes, according to classpath-testresults starting Oct 18th we have:
http://article.gmane.org/gmane.comp.java.classpath.testresults/2667

6267 problems (1 error, 6266 warnings)make[1]: *** [compile-classes]
Error 255
make[1]: Leaving directory `/home/cpdev/Nightly/generics/build/lib'
make: *** [all-recursive] Error 1

Unfortunately the large number of warnings obscure the 1 error.

Looking through the log it is:
1729. ERROR in ../../classpath/java/util/EnumSet.java (at line 252)
return copyOf((EnumSetT) other);
   ^^
The method copyOf(EnumSetT) is ambiguous for the type EnumSetT

 This is why Andrew's hard work with the generics merge the other day
 didn't result in a wonderfully huge Japi diff email...

Sometimes huge japi diff emails are also caught by mailman as way too
big an improve to be true :)

Cheers,

Mark