[cp-patches] FYI: gcc 4.3.0 warnings Java_math_VMBigInteger
This fixes a warning that comes to an error on my system, preventing compilation. Cheers, Mario 2008-05-16 Mario Torre <[EMAIL PROTECTED]> * native/jni/java-math/java_math_VMBigInteger.c (Java_java_math_VMBigInteger_natModInverse): fix variable res not initialized. -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-53 pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim Geschäftsführer: Dr. James J. Hunt Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ ### Eclipse Workspace Patch 1.0 #P classpath Index: native/jni/java-math/java_math_VMBigInteger.c === RCS file: /sources/classpath/classpath/native/jni/java-math/java_math_VMBigInteger.c,v retrieving revision 1.1 diff -u -r1.1 java_math_VMBigInteger.c --- native/jni/java-math/java_math_VMBigInteger.c 28 Feb 2008 22:44:23 - 1.1 +++ native/jni/java-math/java_math_VMBigInteger.c 16 May 2008 18:32:42 - @@ -1112,7 +1112,7 @@ #if defined(WITH_GNU_MP) mpz_srcptr _this; mpz_ptr _bi; - unsigned long res; + unsigned long res = 0; TRACE("begin"); _this = (mpz_srcptr)JCL_GetRawData (env, (*env)->GetObjectField (env, this, native_ptr));
Re: [cp-patches] RFC: NetworkInterface - implement some 1.6 methods
2008/5/15 Robert Schuster <[EMAIL PROTECTED]>: > Hi, > I committed this today. > > 2008-05-15 Robert Schuster <[EMAIL PROTECTED]> > > > * java/net/NetworkInterface.java: > (isUp): New method. > (isPointToPoint): Dito. > (isLoopback): Dito. > (supportsMulticast): Dito. > * vm/reference/java/net/VMNetworkInterface.java: > (isUp): New method. > (isPointToPoint): Dito. > (isLoopback): Dito. > (supportsMulticast): Dito. > * native/jni/java-net/java_net_VMNetworkInterface.c: > (isUp): New method. > (isPointToPoint): Dito. > (isLoopback): Dito. > (supportsMulticast): Dito. > > Regards > Robert > > Robert Schuster schrieb: > > > > Hi. > > > > Robert Schuster schrieb: > >> Hi, > >> I fixed the copy and paste error and another flaw. Casting to jboolean > >> did not alway returned the correct result. I made the if-flag-set then > >> JNI_TRUE otherwise JNI_FALSE explicit. Now it works correctly. > > If no one objects I would like to commit this patch. > > > > Regards > > Robert > > > > > FWIW, this made us regress on building on Solaris 9: if /bin/bash ../../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/share/nlp/projects/cashew/sources/classpath/native/jni/java-net -I../../../include -I/share/nlp/projects/cashew/sources/classpath/include -I/share/nlp/projects/cashew/sources/classpath/native/jni/classpath -I/share/nlp/projects/cashew/sources/classpath/native/jni/native-lib -W -Wall -Wmissing-declarations -Wwrite-strings -Wmissing-prototypes -Wno-long-long -Wstrict-prototypes -pedantic -Werror -g -O2 -MT java_net_VMNetworkInterface.lo -MD -MP -MF ".deps/java_net_VMNetworkInterface.Tpo" -c -o java_net_VMNetworkInterface.lo /share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c; \ then mv -f ".deps/java_net_VMNetworkInterface.Tpo" ".deps/java_net_VMNetworkInterface.Plo"; else rm -f ".deps/java_net_VMNetworkInterface.Tpo"; exit 1; fi gcc -DHAVE_CONFIG_H -I. -I/share/nlp/projects/cashew/sources/classpath/native/jni/java-net -I../../../include -I/share/nlp/projects/cashew/sources/classpath/include -I/share/nlp/projects/cashew/sources/classpath/native/jni/classpath -I/share/nlp/projects/cashew/sources/classpath/native/jni/native-lib -W -Wall -Wmissing-declarations -Wwrite-strings -Wmissing-prototypes -Wno-long-long -Wstrict-prototypes -pedantic -Werror -g -O2 -MT java_net_VMNetworkInterface.lo -MD -MP -MF .deps/java_net_VMNetworkInterface.Tpo -c /share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c -fPIC -DPIC -o .libs/java_net_VMNetworkInterface.o cc1: warnings being treated as errors /share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c: In function 'iff_flags': /share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c:277: warning: implicit declaration of function 'ioctl' /share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c:277: error: 'SIOCGIFFLAGS' undeclared (first use in this function) /share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c:277: error: (Each undeclared identifier is reported only once /share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c:277: error: for each function it appears in.) make[3]: *** [java_net_VMNetworkInterface.lo] Error 1 make[3]: Leaving directory `/share/nlp/projects/cashew/build/sparc-sun-solaris2.9/classpath/native/jni/java-net' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/share/nlp/projects/cashew/build/sparc-sun-solaris2.9/classpath/native/jni' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/share/nlp/projects/cashew/build/sparc-sun-solaris2.9/classpath/native' make: *** [all-recursive] Error 1 -- Andrew :-) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8