Re: [cp-patches] [RFC/PATCH] Check for gettext m4 macros in autogen.sh
I'm sorry I'm not a good one to review this. They changed the auto* tools quite a bit since I used to mess with them. Is autogen.sh something auto* creates, just wondering if it is okay to modify... On Tue, Mar 12, 2013 at 2:47 PM, Pekka Enberg wrote: > If gettext-devel package is not installed on Fedora, autogen.sh fails as > follows: > > [penberg@tux classpath]$ sh autogen.sh > configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not > m4_defun'd > m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... > m4/iconv.m4:22: AM_ICONV_LINK is expanded from... > m4/iconv.m4:77: AM_ICONV is expanded from... > > Make the script more user fiendly by explicitly checking for the > presence of gettext.m4 in the system. > > Cc: Andrew John Hughes > Cc: Brian Jones > Signed-off-by: Pekka Enberg > --- > ChangeLog |5 + > autogen.sh |7 +++ > 2 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index 289a979..e26f627 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2013-03-12 Pekka Enberg > + > + * autogen.sh: > + Check that gettext.m4 is installed. > + > 2013-03-09 Pekka Enberg > > * .gitignore: Exclude autogen-generated files. > diff --git a/autogen.sh b/autogen.sh > index adb8f0c..df0095f 100755 > --- a/autogen.sh > +++ b/autogen.sh > @@ -34,6 +34,13 @@ if $have_libtool ; then : ; else > DIE=1 > fi > > +if [ ! -e $(aclocal --print-ac-dir)/gettext.m4 ] ; then > + echo > + echo "You must have gettext package and, if applicable to your" > + echo "system, gettext-devel package installed to compile $PROJECT." > + DIE=1 > +fi > + > if test "$DIE" -eq 1; then > exit 1 > fi > -- > 1.7.7.6 >
Re: [cp-patches] GNU Classpath
On Oct 20, 2012, at 5:04 AM, Chris Burdess wrote: > Mario Torre wrote: >>> No. Updating the ChangeLog is a requirement. >> >> Maybe it's a requirement, but to be honest, is also a very redundant piece >> of information that is already in the commit log, > > The commit log is not part of the package. People may want to download the > package and see who the contributors were and when; the ChangeLog is a long > established convention for them to do this. > We did maintain the ChangeLog using commits originally and a script to suck them out and generate a file, but at some point we went to keeping a file instead, because it did not require a script. I suggest those merging changes into trunk/master have the ultimate responsibility regarding ensuring the ChangeLog is up to date and since it cannot be auto merged perhaps do not make changes to it except when merging to the release and trunk/master branches. As an aside I always found it easier to maintain my own ChangeLog entries in a separate file and only when committing upstream to add them to the project's file. Brian
Re: [cp-patches] [RFC PATCH] Bump up Java source and target version to 1.6
On Oct 15, 2012, at 2:37 AM, Pekka Enberg wrote: > On Sat, 13 Oct 2012, Ivan Maidanski wrote: >> If you could show the community that upgrading to 1.7 brings some >> benefit (e.g., like above) then it is ok to upgrade to 1.7 directly >> (thus eliminating Classpath VM implementors efforts to verify with 1.6). > > Java 1.7 has some nice language changes: > > http://docs.oracle.com/javase/7/docs/technotes/guides/language/enhancements.html#javase7 > > and more importantly, invokedynamic, that's heavily used by upcoming JRuby > 1.7. IIRC, Scala 2.10 will no longer run on Java 1.5 either. > >Pekka Although jruby needs invokedynamic to perform better I don't think this means the class library needs to change source version unless an actual API change would be unrecognized otherwise? You do however need a vm that supports invokedynamic and uses GNU Classpath. Does one exist?
Re: [cp-patches] Assertions and System Assertions in GNU Classpath
> On the administrative side, AFAICS you haven't contributed before. Do you > have > a copyright assignment with the FSF? The change appears to be minor enough to not require the paperwork to me. Mostly comments, very little code. But hey, if you're gonna be contributing better to get that started sooner than later. Brian
Re: [cp-patches] [PATCH] Fix raw type references in AnnotationInvocationHandler
On Wed, Oct 12, 2011 at 3:16 PM, Dr Andrew John Hughes wrote: > On 12:07 Wed 12 Oct , Ian Rogers wrote: >> On 12 October 2011 03:52, Mark Wielaard wrote: >> > On Wed, 2011-10-12 at 10:29 +0300, Pekka Enberg wrote: >> >> On Wed, Oct 12, 2011 at 1:28 AM, Dr Andrew John Hughes >> >> wrote: >> >> > If we're going to change that, it should happen after the next release >> >> > and with plenty of discussion / heads up for VMs. >> >> >> >> Right. I guess I could send patches for JamVM, CACAO, and Jato as >> >> well. Are there other VMs we care about? >> > >> > JikesRVM and GCJ of course! >> > Although they only use part of the VM interface at this time. >> > There is a somewhat full list at: >> > https://www.gnu.org/software/classpath/stories.html#jvm >> > Some of those are somewhat in "hibernation" though. >> > Heay, and JATO is missing... > > If we're going to do this, it needs to wait until after the next release. When is that? Brian
