Re: [cp-patches] FYI: MetalLookAndFeel.initComponentDefaults() minor fix
Tom Tromey wrote: "David" == David Gilbert <[EMAIL PROTECTED]> writes: David> This was pointed out by running FindBugs David> (http://findbugs.sourceforge.net/). How are you running FindBugs? I think it would be great if we were running it on the auto-builder and reporting FindBugs regressions. Maybe we could migrate your setup there? Tom I had to run it (manually) using Sun's JRE (just point it to the glibj.zip file and the CVS source files and go). I haven't been able to get results out of it with GNU Classpath yet. It has a graphical runner (Swing-based) which mostly works up until the final results are displayed - this final step displays various HTML reports, which our Free Swing can't handle well yet. There's also a command-line runner, which I only tried today for the first time. It seemed to get stuck on GNU Classpath, when I get a chance I'll run it on something smaller and see if it works (or at least gives some exception that we can look into). Regards, Dave
Re: [cp-patches] FYI: MetalLookAndFeel.initComponentDefaults() minor fix
> "David" == David Gilbert <[EMAIL PROTECTED]> writes: David> This was pointed out by running FindBugs David> (http://findbugs.sourceforge.net/). How are you running FindBugs? I think it would be great if we were running it on the auto-builder and reporting FindBugs regressions. Maybe we could migrate your setup there? Tom
[cp-patches] FYI: MetalLookAndFeel.initComponentDefaults() minor fix
This patch (committed) replaces 'new Boolean(true)' with 'Boolean.TRUE' to save creating a new instance: 2006-03-06 David Gilbert <[EMAIL PROTECTED]> * javax/swing/plaf/metal/MetalLookAndFeel.java (initComponentDefaults): Use Boolean.TRUE for 'CheckBoxMenuItem.borderPainted'. This was pointed out by running FindBugs (http://findbugs.sourceforge.net/). Regards, Dave Index: javax/swing/plaf/metal/MetalLookAndFeel.java === RCS file: /sources/classpath/classpath/javax/swing/plaf/metal/MetalLookAndFeel.java,v retrieving revision 1.78 diff -u -r1.78 MetalLookAndFeel.java --- javax/swing/plaf/metal/MetalLookAndFeel.java15 Feb 2006 16:20:13 - 1.78 +++ javax/swing/plaf/metal/MetalLookAndFeel.java6 Mar 2006 21:05:39 - @@ -1,5 +1,5 @@ /* MetalLookAndFeel.java - Copyright (C) 2002, 2005 Free Software Foundation, Inc. + Copyright (C) 2002, 2005, 2006, Free Software Foundation, Inc. This file is part of GNU Classpath. @@ -899,7 +899,7 @@ "CheckBoxMenuItem.acceleratorForeground", getAcceleratorForeground(), "CheckBoxMenuItem.acceleratorSelectionForeground", getAcceleratorSelectedForeground(), "CheckBoxMenuItem.background", getMenuBackground(), - "CheckBoxMenuItem.borderPainted", new Boolean(true), + "CheckBoxMenuItem.borderPainted", Boolean.TRUE, "CheckBoxMenuItem.commandSound", "sounds/MenuItemCommand.wav", "CheckBoxMenuItem.checkIcon", MetalIconFactory.getCheckBoxMenuItemIcon(), "CheckBoxMenuItem.disabledForeground", getMenuDisabledForeground(),
