Re: RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
On Wed, 19 Jun 2024 19:35:54 GMT, Alexey Ivanov wrote: > Would it be clearer if setDelay(50) was called in the constructor of > bug6492108? I am ok with the current placing of setDelay(50). - PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1647193228
Re: RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
On Wed, 19 Jun 2024 19:20:24 GMT, Alexey Ivanov wrote: >>> You should rather call >>> [setDelay(50)](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294) >>> to add the delay between method calls. >> >> this change does exactly that, it calls `SwingTestHelper#setDelay` since >> `bug6492108 extends SwingTestHelper` >> >>> You should ask Vitaly to test your changeset in his environment to confirm >>> the failure is gone. >> >> I am able to reproduce the issue locally on Ubuntu 22.04, and the provided >> fix works fine for me. >> >> I assume @vprovodin has already done this testing, since he was the one who >> provided the solution in the JBS issue description. > > My bad, I read it as if it were `delay(50)`. Would it be clearer if `setDelay(50)` was called in the constructor of `bug6492108`? - PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1646628379
Re: RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote: > Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a > delay to stable the test and multiple run in CI is Ok. Link is added in JBS. Marked as reviewed by aivanov (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19788#pullrequestreview-2128930008
Re: RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
On Wed, 19 Jun 2024 15:38:10 GMT, Alexander Zvegintsev wrote: >>> How does it help? You're delaying EDT. >> >> I was unable to reproduce the failure scenario in my local machine but >> didn't observe any failure in mach5 also. Will ask Vitaly or @azvegint to >> verify as they are able to replicate the failure. > >> You should rather call >> [setDelay(50)](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294) >> to add the delay between method calls. > > this change does exactly that, it calls `SwingTestHelper#setDelay` since > `bug6492108 extends SwingTestHelper` > >> You should ask Vitaly to test your changeset in his environment to confirm >> the failure is gone. > > I am able to reproduce the issue locally on Ubuntu 22.04, and the provided > fix works fine for me. > > I assume @vprovodin has already done this testing, since he was the one who > provided the solution in the JBS issue description. My bad, I read it as if it were `delay(50)`. - PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1646618947
Re: RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote: > Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a > delay to stable the test and multiple run in CI is Ok. Link is added in JBS. Marked as reviewed by azvegint (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19788#pullrequestreview-2128636821
Re: RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
On Wed, 19 Jun 2024 11:15:54 GMT, Abhishek Kumar wrote: >> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 113: >> >>> 111: } >>> 112: setDelay(50); >>> 113: return panel; >> >> How does it help? You're delaying EDT. >> >> You should rather call >> [`setDelay(50)`](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294) >> to add the delay between method calls. >> >> Alternatively, you can add `-delay 50` to [the test >> arguments](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L460-L467) >> in its `@run` tag. > >> How does it help? You're delaying EDT. > > I was unable to reproduce the failure scenario in my local machine but didn't > observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as > they are able to replicate the failure. > You should rather call > [setDelay(50)](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294) > to add the delay between method calls. this change does exactly that, it calls `SwingTestHelper#setDelay` since `bug6492108 extends SwingTestHelper` > I was unable to reproduce the failure scenario in my local machine but didn't > observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as > they are able to replicate the failure I am able to reproduce the issue locally on Ubuntu 22.04, and the provided fix works fine for me. I assume @vprovodin has already done this testing, since he was the one who provided the solution in the JBS issue description. - PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1646412776
Re: RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
On Wed, 19 Jun 2024 11:01:26 GMT, Alexey Ivanov wrote: > How does it help? You're delaying EDT. I was unable to reproduce the failure scenario in my local machine but didn't observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as they are able to replicate the failure. - PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1645969980
Re: RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote: > Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a > delay to stable the test and multiple run in CI is Ok. Link is added in JBS. You should ask Vitaly to test your changeset in his environment to confirm the failure is gone. test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 113: > 111: } > 112: setDelay(50); > 113: return panel; How does it help? You're delaying EDT. You should rather call [`setDelay(50)`](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294) to add the delay between method calls. Alternatively, you can add `-delay 50` to [the test arguments](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L460-L467) in its `@run` tag. - PR Review: https://git.openjdk.org/jdk/pull/19788#pullrequestreview-2127884342 PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1645934622
RFR: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a delay to stable the test and multiple run in CI is Ok. Link is added in JBS. - Commit messages: - delay added for stable test Changes: https://git.openjdk.org/jdk/pull/19788/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19788&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334170 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19788.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19788/head:pull/19788 PR: https://git.openjdk.org/jdk/pull/19788
