Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Mon, 10 Jun 2024 20:33:05 GMT, Alexey Ivanov wrote: > These improvements to the test can be combined with fixing > [JDK-8333026](https://bugs.openjdk.org/browse/JDK-8333026), or the test can > be updated separately. > > I'll submit a new bug to track this activity. Thank you for bringing it up. I've submitted [JDK-8334016](https://bugs.openjdk.org/browse/JDK-8334016): _Make `PrintNullString.java` semi-automatic_. - PR Comment: https://git.openjdk.org/jdk/pull/19540#issuecomment-2160667957
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > I have updated the test case with passing float value for evaluation and a > typo. Please review and let me know your suggestions if any. small typo and typing change, LGTM - Marked as reviewed by achung (Committer). PR Review: https://git.openjdk.org/jdk/pull/19540#pullrequestreview-2108713479
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Mon, 10 Jun 2024 20:15:55 GMT, Alisen Chung wrote: > Maybe outside the scope of this issue, but could this test be automated? I've been thinking about it, too. No, it can't be automated completely: the tester has to click Print / OK button in the Print dialog. Yes, other aspects of the test can be automated. The test code already detects a failure and reports it on the screen or on paper, thus the test can fail automatically if a failure condition is found. However, the first part where it paints on the screen can be fully automated. It could be moved to an independent test. These improvements to the test can be combined with fixing [JDK-8333026](https://bugs.openjdk.org/browse/JDK-8333026), or the test can be updated separately. I'll submit a new bug to track this activity. Thank you for bringing it up. - PR Comment: https://git.openjdk.org/jdk/pull/19540#issuecomment-2159232777
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > I have updated the test case with passing float value for evaluation and a > typo. Please review and let me know your suggestions if any. Maybe outside the scope of this issue, but could this test be automated? - PR Review: https://git.openjdk.org/jdk/pull/19540#pullrequestreview-2108672182
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > I have updated the test case with passing float value for evaluation and a > typo. Please review and let me know your suggestions if any. Ran the updated test and looks good to me. - Marked as reviewed by abhiscxk (Committer). PR Review: https://git.openjdk.org/jdk/pull/19540#pullrequestreview-2099660380
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Wed, 5 Jun 2024 12:20:00 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
>>
>>> 170:
>>> 171: try {
>>> 172: g2d.drawString(emptyIterator, 20.0f, 180.0f);
>>
>> Does the line below also need to change ?
>> `g2d.drawString("FAILURE: No IAE for empty iterator, float", 20.0f 180.0f);`
>
> No, it does not. It may though.
>
> The test declares it verifies `drawString(Iterator, float, float)` — the test
> does it now. How the error message is output on the screen isn't important:
> either `int` or `float` version will do the same thing.
@aivanov-jdk Thank you for clarification.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19540#discussion_r1628050634
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Wed, 5 Jun 2024 04:53:56 GMT, Abhishek Kumar wrote:
>> Hi Reviewers,
>> I have updated the test case with passing float value for evaluation and a
>> typo. Please review and let me know your suggestions if any.
>
> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
>
>> 170:
>> 171: try {
>> 172: g2d.drawString(emptyIterator, 20.0f, 180.0f);
>
> Does the line below also need to change ?
> `g2d.drawString("FAILURE: No IAE for empty iterator, float", 20.0f 180.0f);`
No, it does not. It may though.
The test declares it verifies `drawString(Iterator, float, float)` — the test
does it now. How the error message is output on the screen isn't important:
either `int` or `float` version will do the same thing.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19540#discussion_r1627655778
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 172:
> 170:
> 171: try {
> 172: g2d.drawString(emptyIterator, 20.0f, 180.0f);
Does the line below also need to change ?
`g2d.drawString("FAILURE: No IAE for empty iterator, float", 20.0f 180.0f);`
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19540#discussion_r1626943802
Re: RFR: JDK-8333360 : PrintNullString.java doesn't use float arguments
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad wrote: > Hi Reviewers, > I have updated the test case with passing float value for evaluation and a > typo. Please review and let me know your suggestions if any. Marked as reviewed by aivanov (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19540#pullrequestreview-2096332476
